@vellumai/assistant 0.10.2-dev.202606250318.5e7cfb0 → 0.10.2

package/src/__tests__/conversation-queue.test.ts

@@ -149,8 +149,6 @@ mock.module("../security/secret-allowlist.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   setConversationOriginChannelIfUnset: () => {},
   setConversationOriginInterfaceIfUnset: () => {},
   updateConversationContextWindow: () => {},
@@ -2913,92 +2911,3 @@ describe("MessageQueue byte budget", () => {
     ).toBe(false);
   });
 });
-
-describe("subagent notification user_message_echo suppression", () => {
-  beforeEach(() => {
-    pendingRuns = [];
-    capturedAddMessages.length = 0;
-  });
-
-  test("drained subagent-notification message persists and wakes the agent but emits no user_message_echo", async () => {
-    const conversation = makeConversation();
-    await conversation.loadFromDb();
-
-    const events1: ServerMessage[] = [];
-    const eventsNotif: ServerMessage[] = [];
-
-    // Occupy the conversation so the injected notification queues.
-    const p1 = conversation.processMessage({
-      content: "msg-1",
-      attachments: [],
-      onEvent: (e) => events1.push(e),
-      requestId: "req-1",
-    });
-    await waitForPendingRun(1);
-    expect(conversation.isProcessing()).toBe(true);
-
-    // A daemon-injected subagent completion notification carries
-    // `subagentNotification` metadata.
-    conversation.enqueueMessage({
-      content: '[Subagent "research" completed]',
-      onEvent: (e) => eventsNotif.push(e),
-      requestId: "req-notif",
-      metadata: {
-        subagentNotification: {
-          subagentId: "sub-1",
-          label: "research",
-          status: "completed",
-        },
-      },
-    });
-
-    // Resolving the first run drains the queued notification.
-    await resolveRun(0);
-    await p1;
-    await waitForPendingRun(2);
-
-    // It is still persisted (so the orchestrator LLM sees it in the transcript)
-    // and still wakes the agent (a run was created for the drained message)...
-    expect(
-      capturedAddMessages.some((m) => m.content.includes("Subagent")),
-    ).toBe(true);
-    expect(pendingRuns.length).toBe(2);
-    // ...but no user_message_echo is broadcast, so the client never renders it
-    // as a live user bubble.
-    expect(eventsNotif.some((e) => e.type === "user_message_echo")).toBe(false);
-
-    await resolveRun(1);
-    await new Promise((r) => setTimeout(r, 10));
-  });
-
-  test("drained ordinary message still emits user_message_echo", async () => {
-    const conversation = makeConversation();
-    await conversation.loadFromDb();
-
-    const events1: ServerMessage[] = [];
-    const eventsNormal: ServerMessage[] = [];
-
-    const p1 = conversation.processMessage({
-      content: "msg-1",
-      attachments: [],
-      onEvent: (e) => events1.push(e),
-      requestId: "req-1",
-    });
-    await waitForPendingRun(1);
-
-    conversation.enqueueMessage({
-      content: "ordinary message",
-      onEvent: (e) => eventsNormal.push(e),
-      requestId: "req-normal",
-    });
-
-    await resolveRun(0);
-    await p1;
-    await waitForPendingRun(2);
-
-    expect(eventsNormal.some((e) => e.type === "user_message_echo")).toBe(true);
-
-    await resolveRun(1);
-    await new Promise((r) => setTimeout(r, 10));
-  });
-});

package/src/__tests__/conversation-routes-guardian-reply.test.ts

@@ -77,8 +77,6 @@ mock.module("../runtime/confirmation-request-guardian-bridge.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   addMessage: (
     conversationId: string,
     role: string,
@@ -106,18 +104,6 @@ mock.module("../runtime/trust-context-resolver.js", () => ({
   }),
 }));
 
-mock.module("../contacts/guardian-delivery-reader.js", () => ({
-  getGuardianDelivery: async () => [
-    {
-      channelType: "vellum",
-      contactId: "guardian-contact",
-      principalId: "test-user",
-      address: "test-user",
-      status: "active",
-    },
-  ],
-}));
-
 import type { AuthContext } from "../runtime/auth/types.js";
 import { handleSendMessage } from "../runtime/routes/conversation-routes.js";
 import { callHandler } from "./helpers/call-route-handler.js";

package/src/__tests__/conversation-routes-slash-commands.test.ts

@@ -126,8 +126,6 @@ mock.module("../runtime/confirmation-request-guardian-bridge.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   addMessage: (
     conversationId: string,
     role: string,
@@ -192,18 +190,6 @@ mock.module("../runtime/trust-context-resolver.js", () => ({
   }),
 }));
 
-mock.module("../contacts/guardian-delivery-reader.js", () => ({
-  getGuardianDelivery: async () => [
-    {
-      channelType: "vellum",
-      contactId: "guardian-contact",
-      principalId: "test-user",
-      address: "test-user",
-      status: "active",
-    },
-  ],
-}));
-
 const ipcCallMock = mock(
   async (): Promise<Record<string, unknown> | undefined> => ({ ok: true }),
 );

package/src/__tests__/conversation-slash-queue.test.ts

@@ -100,8 +100,6 @@ mock.module("../security/secret-allowlist.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   setConversationOriginChannelIfUnset: () => {},
   setConversationOriginInterfaceIfUnset: () => {},
   updateConversationContextWindow: () => {},

package/src/__tests__/conversation-slash-unknown.test.ts

@@ -101,8 +101,6 @@ const addMessageCalls: Array<{
 }> = [];
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   setConversationOriginChannelIfUnset: () => {},
   updateConversationContextWindow: () => {},
   deleteMessageById: () => {},

package/src/__tests__/conversation-speed-override.test.ts

@@ -119,8 +119,6 @@ mock.module("../security/secret-allowlist.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   setConversationOriginChannelIfUnset: () => {},
   updateConversationContextWindow: () => {},
   deleteMessageById: () => {},

package/src/__tests__/conversation-surfaces-task-progress.test.ts

@@ -336,35 +336,6 @@ describe("task_progress surface compatibility", () => {
     });
   });
 
-  test("ui_show file_upload normalizes a comma-joined acceptedTypes string", async () => {
-    const sent: ServerMessage[] = [];
-    const ctx = makeContext(sent);
-
-    // The model may emit acceptedTypes as a comma-joined string; the renderer
-    // calls `.join`/`.some` on it, so the daemon hands the client a clean array.
-    const result = await surfaceProxyResolver(ctx, "ui_show", {
-      surface_type: "file_upload",
-      title: "Upload a receipt",
-      data: {
-        prompt: "Share the receipt",
-        acceptedTypes: "image/*, application/pdf",
-      },
-    });
-
-    expect(result.isError).toBe(false);
-
-    const showMessage = sent.find(
-      (msg): msg is UiSurfaceShow => msg.type === "ui_surface_show",
-    );
-    expect(showMessage).toBeDefined();
-    if (!showMessage || showMessage.surfaceType !== "file_upload") return;
-
-    expect(showMessage.data.acceptedTypes).toEqual([
-      "image/*",
-      "application/pdf",
-    ]);
-  });
-
   test("ui_show dynamic_page uses data.html when properly nested", async () => {
     const sent: ServerMessage[] = [];
     const ctx = makeContext(sent);

package/src/__tests__/conversation-title-service.test.ts

@@ -34,8 +34,6 @@ mock.module("../runtime/btw-sidechain.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   getConversation: mockGetConversation,
   getMessages: mockGetMessages,
   updateConversationTitle: mockUpdateConversationTitle,

package/src/__tests__/conversation-tool-setup-attribution.test.ts

@@ -321,50 +321,3 @@ describe("createToolExecutor attribution threading", () => {
     expect(calls[0].context.attribution).toBeNull();
   });
 });
-
-describe("createToolExecutor isInteractive threading", () => {
-  test("uses the resolved turn-level interactivity over live client state", async () => {
-    // A scheduled/background turn (currentTurnIsNonInteractive=true) must read
-    // as non-interactive even when a client is attached (hasNoClient=false), so
-    // ask_question short-circuits instead of parking on the response backstop.
-    const { executor, calls } = makeCapturingExecutor();
-    const toolFn = makeToolFn(
-      executor,
-      makeCtx({ currentTurnIsNonInteractive: true, hasNoClient: false }),
-    );
-
-    await toolFn("file_read", { path: "/tmp/a" });
-
-    expect(calls[0].context.isInteractive).toBe(false);
-  });
-
-  test("reflects an interactive turn as interactive", async () => {
-    const { executor, calls } = makeCapturingExecutor();
-    const toolFn = makeToolFn(
-      executor,
-      makeCtx({ currentTurnIsNonInteractive: false }),
-    );
-
-    await toolFn("file_read", { path: "/tmp/a" });
-
-    expect(calls[0].context.isInteractive).toBe(true);
-  });
-
-  test("falls back to live client state when no turn value is set", async () => {
-    // No in-flight turn resolution (e.g. tool execution outside runAgentLoop):
-    // derive interactivity from whether a client is connected.
-    const noClient = makeCapturingExecutor();
-    await makeToolFn(
-      noClient.executor,
-      makeCtx({ currentTurnIsNonInteractive: undefined, hasNoClient: true }),
-    )("file_read", { path: "/tmp/a" });
-    expect(noClient.calls[0].context.isInteractive).toBe(false);
-
-    const withClient = makeCapturingExecutor();
-    await makeToolFn(
-      withClient.executor,
-      makeCtx({ currentTurnIsNonInteractive: undefined, hasNoClient: false }),
-    )("file_read", { path: "/tmp/a" });
-    expect(withClient.calls[0].context.isInteractive).toBe(true);
-  });
-});

package/src/__tests__/conversation-usage.test.ts

@@ -23,8 +23,6 @@ mock.module("../config/loader.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   updateConversationUsage: (
     conversationId: string,
     inputTokens: number,

package/src/__tests__/conversation-workspace-cache-state.test.ts

@@ -87,8 +87,6 @@ mock.module("../security/secret-allowlist.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   setConversationOriginChannelIfUnset: () => {},
   setConversationHistoryStrippedAt: () => {},
   provenanceFromTrustContext: () => ({

package/src/__tests__/conversation-workspace-injection.test.ts

@@ -111,8 +111,6 @@ mock.module("../security/secret-allowlist.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   setConversationOriginChannelIfUnset: () => {},
   setConversationHistoryStrippedAt: () => {},
   provenanceFromTrustContext: () => ({

package/src/__tests__/conversation-workspace-tool-tracking.test.ts

@@ -109,8 +109,6 @@ mock.module("../security/secret-allowlist.js", () => ({
 }));
 
 mock.module("../memory/conversation-crud.js", () => ({
-    setConversationProcessingStartedAt: () => {},
-    isConversationProcessing: () => false,
   setConversationOriginChannelIfUnset: () => {},
   setConversationHistoryStrippedAt: () => {},
   provenanceFromTrustContext: () => ({

package/src/__tests__/credential-security-invariants.test.ts

@@ -182,7 +182,6 @@ describe("Invariant 2: no generic plaintext secret read API", () => {
       "daemon/handlers/config-slack-channel.ts", // Slack channel config credential management
       "providers/platform-proxy/context.ts", // managed proxy API key lookup for provider initialization
       "platform/client.ts", // platform client credential store fallback for standalone CLI auth
-      "mcp/mcp-header-store.ts", // MCP static auth header persistence (credential store CRUD + legacy migration)
       "mcp/mcp-oauth-provider.ts", // MCP OAuth token/client/discovery persistence
       "runtime/routes/integrations/slack/token.ts", // shared Slack token resolver (bot/user token lookup for CLI use routes)
       "mcp/client.ts", // MCP client cached-token lookup
@@ -222,6 +221,7 @@ describe("Invariant 2: no generic plaintext secret read API", () => {
       "runtime/routes/sanity-routes.ts", // Sanity connect/discover routes (reads stored api_token from credential store)
       "runtime/routes/platform-routes.ts", // CLI platform connect/disconnect/status routes (CLI-migrated to IPC)
       "ipc/skill-routes/providers.ts", // host.providers.secureKeys.getProviderKey IPC route (out-of-process SkillHost companion)
+      "daemon/external-plugins-bootstrap.ts", // reads credentials at plugin init (manifest.requiresCredential) via the CES-mediated getSecureKeyAsync path
       "inbound/platform-callback-registration.ts", // managed credential lookup for platform base URL, assistant ID, and API key
       "tts/providers/elevenlabs-provider.ts", // ElevenLabs TTS API key lookup
       "tts/providers/deepgram-provider.ts", // Deepgram TTS API key lookup