@transitrix/diagrams 1.0.0 → 1.1.0

package/src/goals/types.ts

@@ -1,85 +1,85 @@
-export type ImpactType = 'opportunity' | 'positive' | 'risk' | 'negative' | 'mixed';
-
-export interface Factor {
-  id: number;
-  name: string;
-  description?: string;
-  segment?: string;
-  impact_type: ImpactType;
-}
-
-export interface Goal {
-  id: number;
-  name: string;
-  type: string;
-  level: number;
-  parent_id: number;
-  link?: string;
-  tag?: string;
-  description?: string;
-  factors?: Factor[];
-  created_at?: string;
-}
-
-export interface GoalType {
-  name: string;
-  level: number;
-}
-
-export interface GoalTree {
-  goal_types: GoalType[];
-  goals: Goal[];
-}
-
-// Validation result shape moved to the shared `validation-types.ts` module
-// (one canonical definition across every notation). The re-exports below
-// preserve the public type surface this module historically exposed.
-export type {
-  ValidationError,
-  ValidationWarning,
-  ValidationResult,
-} from '../validation-types.js';
-
-import type { ValidationError } from '../validation-types.js';
-
-export interface MutationResult<T> {
-  ok: boolean;
-  result?: T;
-  error?: ValidationError;
-}
-
-import type { Scope } from '../scope.js';
-
-export interface LayoutOptions {
-  rankdir?: 'LR' | 'TB';
-  nodeWidth?: number;
-  nodeHeight?: number;
-  rankSep?: number;
-  nodeSep?: number;
-  hideCollapsed?: number[];
-  viewDepth?: number | null;
-  /** Trim the tree to a level cap or a subtree root (vkgeorgia/strategy#77). Defaults to 'all'. */
-  scope?: Scope;
-}
-
-export interface LaidOutNode {
-  id: number;
-  x: number;
-  y: number;
-  width: number;
-  height: number;
-  data: Goal;
-  isCollapsedRoot: boolean;
-  hasHiddenChildren: boolean;
-}
-
-export interface LaidOutEdge {
-  source: number;
-  target: number;
-}
-
-export interface GoalTreeLayout {
-  nodes: LaidOutNode[];
-  edges: LaidOutEdge[];
-  bounds: { x: number; y: number; width: number; height: number };
-}
+export type ImpactType = 'opportunity' | 'positive' | 'risk' | 'negative' | 'mixed';
+
+export interface Factor {
+  id: number;
+  name: string;
+  description?: string;
+  segment?: string;
+  impact_type: ImpactType;
+}
+
+export interface Goal {
+  id: number;
+  name: string;
+  type: string;
+  level: number;
+  parent_id: number;
+  link?: string;
+  tag?: string;
+  description?: string;
+  factors?: Factor[];
+  created_at?: string;
+}
+
+export interface GoalType {
+  name: string;
+  level: number;
+}
+
+export interface GoalTree {
+  goal_types: GoalType[];
+  goals: Goal[];
+}
+
+// Validation result shape moved to the shared `validation-types.ts` module
+// (one canonical definition across every notation). The re-exports below
+// preserve the public type surface this module historically exposed.
+export type {
+  ValidationError,
+  ValidationWarning,
+  ValidationResult,
+} from '../validation-types.js';
+
+import type { ValidationError } from '../validation-types.js';
+
+export interface MutationResult<T> {
+  ok: boolean;
+  result?: T;
+  error?: ValidationError;
+}
+
+import type { Scope } from '../scope.js';
+
+export interface LayoutOptions {
+  rankdir?: 'LR' | 'TB';
+  nodeWidth?: number;
+  nodeHeight?: number;
+  rankSep?: number;
+  nodeSep?: number;
+  hideCollapsed?: number[];
+  viewDepth?: number | null;
+  /** Trim the tree to a level cap or a subtree root (vkgeorgia/strategy#77). Defaults to 'all'. */
+  scope?: Scope;
+}
+
+export interface LaidOutNode {
+  id: number;
+  x: number;
+  y: number;
+  width: number;
+  height: number;
+  data: Goal;
+  isCollapsedRoot: boolean;
+  hasHiddenChildren: boolean;
+}
+
+export interface LaidOutEdge {
+  source: number;
+  target: number;
+}
+
+export interface GoalTreeLayout {
+  nodes: LaidOutNode[];
+  edges: LaidOutEdge[];
+  bounds: { x: number; y: number; width: number; height: number };
+}

package/src/goals/validate.ts

@@ -1,136 +1,136 @@
-import type { GoalTree, ValidationResult, ValidationError, ValidationWarning } from './types.js';
-
-export function validateGoalTree(input: unknown): ValidationResult {
-  const errors: ValidationError[] = [];
-  const warnings: ValidationWarning[] = [];
-
-  if (!input || typeof input !== 'object') {
-    return { valid: false, errors: [{ code: 'SCHEMA_INVALID', message: 'Input must be an object' }], warnings: [] };
-  }
-
-  const raw = input as Record<string, unknown>;
-
-  if (!Array.isArray(raw.goals)) {
-    errors.push({ code: 'SCHEMA_INVALID', message: 'goals must be an array', path: 'goals' });
-  }
-  if (!Array.isArray(raw.goal_types)) {
-    errors.push({ code: 'SCHEMA_INVALID', message: 'goal_types must be an array', path: 'goal_types' });
-  }
-  if (errors.length > 0) return { valid: false, errors, warnings };
-
-  const tree = raw as unknown as GoalTree;
-
-  // GOALS-013 — goal_types[].level values must be contiguous starting from 0.
-  // Per the N+1 rule (decision in vkgeorgia/strategy#66), the level set must
-  // be exactly {0, 1, …, N}; a gap breaks the parent→child level invariant
-  // and means GOALS-012 cannot be enforced consistently.
-  const levels = tree.goal_types
-    .map(gt => gt.level)
-    .filter(l => typeof l === 'number' && Number.isFinite(l));
-  if (levels.length > 0) {
-    const unique = Array.from(new Set(levels)).sort((a, b) => a - b);
-    const expected = Array.from({ length: unique.length }, (_, i) => i);
-    const contiguous = unique.length === expected.length && unique.every((v, i) => v === expected[i]);
-    if (!contiguous) {
-      errors.push({
-        code: 'GOALS-013',
-        message: `goal_types[].level values must be contiguous starting from 0; got [${unique.join(', ')}]`,
-        path: 'goal_types',
-      });
-    }
-  }
-
-  const maxLevel = Math.max(...tree.goal_types.map(gt => gt.level), 0);
-  const typeMap = new Map(tree.goal_types.map(gt => [gt.name, gt.level]));
-  const idSet = new Set<number>();
-  const levelById = new Map<number, number>();
-
-  for (let i = 0; i < tree.goals.length; i++) {
-    const g = tree.goals[i] as unknown;
-    const path = `goals[${i}]`;
-
-    if (!g || typeof g !== 'object') {
-      errors.push({ code: 'SCHEMA_INVALID', message: 'goal entry must be an object', path });
-      continue;
-    }
-    const goal = g as { id?: unknown; name?: unknown; level?: unknown; type?: unknown };
-
-    if (typeof goal.id !== 'number') {
-      errors.push({ code: 'SCHEMA_INVALID', message: 'goal id must be a number', path });
-      continue;
-    }
-    if (!goal.name || typeof goal.name !== 'string' || goal.name.trim() === '') {
-      errors.push({ code: 'EMPTY_NAME', message: `Goal ${goal.id} has empty name`, path });
-    }
-
-    if (idSet.has(goal.id)) {
-      errors.push({ code: 'DUPLICATE_ID', message: `Duplicate goal id: ${goal.id}`, path });
-    } else {
-      idSet.add(goal.id);
-    }
-
-    if (typeof goal.level !== 'number' || !Number.isFinite(goal.level)) {
-      errors.push({ code: 'SCHEMA_INVALID', message: `Goal ${goal.id} level must be a finite number`, path });
-      continue;
-    }
-    if (goal.level > maxLevel) {
-      errors.push({ code: 'MAX_LEVEL_EXCEEDED', message: `Goal ${goal.id} level ${goal.level} exceeds max ${maxLevel}`, path });
-    }
-    levelById.set(goal.id, goal.level);
-
-    const expectedLevel = typeof goal.type === 'string' ? typeMap.get(goal.type) : undefined;
-    if (expectedLevel !== undefined && expectedLevel !== goal.level) {
-      warnings.push({ code: 'TYPE_LEVEL_MISMATCH', message: `Goal ${goal.id} type "${String(goal.type)}" expects level ${expectedLevel}, got ${goal.level}`, path });
-    }
-  }
-
-  if (errors.length > 0) return { valid: false, errors, warnings };
-
-  // Check broken parent refs and cycles after all ids are collected
-  for (let i = 0; i < tree.goals.length; i++) {
-    const g = tree.goals[i];
-    const path = `goals[${i}]`;
-    if (!g || typeof g !== 'object') continue;
-    if (g.parent_id !== 0 && !idSet.has(g.parent_id)) {
-      warnings.push({ code: 'BROKEN_PARENT_REF', message: `Goal ${g.id} references missing parent ${g.parent_id} — moved to backlog`, path });
-      continue;
-    }
-    // GOALS-012 — parent must be exactly one level above the child (N+1
-    // hierarchy, decision in vkgeorgia/strategy#66). Only enforced when the
-    // parent is resolvable; a missing parent is covered by BROKEN_PARENT_REF.
-    if (g.parent_id !== 0) {
-      const parentLevel = levelById.get(g.parent_id);
-      if (parentLevel !== undefined && g.level !== parentLevel + 1) {
-        errors.push({
-          code: 'GOALS-012',
-          message: `Goal ${g.id} (level ${g.level}) must have a parent at level ${g.level - 1}; parent ${g.parent_id} is at level ${parentLevel}`,
-          path,
-        });
-      }
-    }
-  }
-
-  const cycleError = detectCycle(tree.goals);
-  if (cycleError) errors.push(cycleError);
-
-  return { valid: errors.length === 0, errors, warnings };
-}
-
-function detectCycle(goals: GoalTree['goals']): ValidationError | null {
-  const parentOf = new Map(goals.map(g => [g.id, g.parent_id]));
-
-  for (const g of goals) {
-    const visited = new Set<number>();
-    let cur: number = g.id;
-    while (cur !== 0) {
-      if (visited.has(cur)) {
-        return { code: 'CYCLE_DETECTED', message: `Cycle detected involving goal ${g.id}` };
-      }
-      visited.add(cur);
-      const parent = parentOf.get(cur);
-      if (parent === undefined) break;
-      cur = parent;
-    }
-  }
-  return null;
-}
+import type { GoalTree, ValidationResult, ValidationError, ValidationWarning } from './types.js';
+
+export function validateGoalTree(input: unknown): ValidationResult {
+  const errors: ValidationError[] = [];
+  const warnings: ValidationWarning[] = [];
+
+  if (!input || typeof input !== 'object') {
+    return { valid: false, errors: [{ code: 'SCHEMA_INVALID', message: 'Input must be an object' }], warnings: [] };
+  }
+
+  const raw = input as Record<string, unknown>;
+
+  if (!Array.isArray(raw.goals)) {
+    errors.push({ code: 'SCHEMA_INVALID', message: 'goals must be an array', path: 'goals' });
+  }
+  if (!Array.isArray(raw.goal_types)) {
+    errors.push({ code: 'SCHEMA_INVALID', message: 'goal_types must be an array', path: 'goal_types' });
+  }
+  if (errors.length > 0) return { valid: false, errors, warnings };
+
+  const tree = raw as unknown as GoalTree;
+
+  // GOALS-013 — goal_types[].level values must be contiguous starting from 0.
+  // Per the N+1 rule (decision in vkgeorgia/strategy#66), the level set must
+  // be exactly {0, 1, …, N}; a gap breaks the parent→child level invariant
+  // and means GOALS-012 cannot be enforced consistently.
+  const levels = tree.goal_types
+    .map(gt => gt.level)
+    .filter(l => typeof l === 'number' && Number.isFinite(l));
+  if (levels.length > 0) {
+    const unique = Array.from(new Set(levels)).sort((a, b) => a - b);
+    const expected = Array.from({ length: unique.length }, (_, i) => i);
+    const contiguous = unique.length === expected.length && unique.every((v, i) => v === expected[i]);
+    if (!contiguous) {
+      errors.push({
+        code: 'GOALS-013',
+        message: `goal_types[].level values must be contiguous starting from 0; got [${unique.join(', ')}]`,
+        path: 'goal_types',
+      });
+    }
+  }
+
+  const maxLevel = Math.max(...tree.goal_types.map(gt => gt.level), 0);
+  const typeMap = new Map(tree.goal_types.map(gt => [gt.name, gt.level]));
+  const idSet = new Set<number>();
+  const levelById = new Map<number, number>();
+
+  for (let i = 0; i < tree.goals.length; i++) {
+    const g = tree.goals[i] as unknown;
+    const path = `goals[${i}]`;
+
+    if (!g || typeof g !== 'object') {
+      errors.push({ code: 'SCHEMA_INVALID', message: 'goal entry must be an object', path });
+      continue;
+    }
+    const goal = g as { id?: unknown; name?: unknown; level?: unknown; type?: unknown };
+
+    if (typeof goal.id !== 'number') {
+      errors.push({ code: 'SCHEMA_INVALID', message: 'goal id must be a number', path });
+      continue;
+    }
+    if (!goal.name || typeof goal.name !== 'string' || goal.name.trim() === '') {
+      errors.push({ code: 'EMPTY_NAME', message: `Goal ${goal.id} has empty name`, path });
+    }
+
+    if (idSet.has(goal.id)) {
+      errors.push({ code: 'DUPLICATE_ID', message: `Duplicate goal id: ${goal.id}`, path });
+    } else {
+      idSet.add(goal.id);
+    }
+
+    if (typeof goal.level !== 'number' || !Number.isFinite(goal.level)) {
+      errors.push({ code: 'SCHEMA_INVALID', message: `Goal ${goal.id} level must be a finite number`, path });
+      continue;
+    }
+    if (goal.level > maxLevel) {
+      errors.push({ code: 'MAX_LEVEL_EXCEEDED', message: `Goal ${goal.id} level ${goal.level} exceeds max ${maxLevel}`, path });
+    }
+    levelById.set(goal.id, goal.level);
+
+    const expectedLevel = typeof goal.type === 'string' ? typeMap.get(goal.type) : undefined;
+    if (expectedLevel !== undefined && expectedLevel !== goal.level) {
+      warnings.push({ code: 'TYPE_LEVEL_MISMATCH', message: `Goal ${goal.id} type "${String(goal.type)}" expects level ${expectedLevel}, got ${goal.level}`, path });
+    }
+  }
+
+  if (errors.length > 0) return { valid: false, errors, warnings };
+
+  // Check broken parent refs and cycles after all ids are collected
+  for (let i = 0; i < tree.goals.length; i++) {
+    const g = tree.goals[i];
+    const path = `goals[${i}]`;
+    if (!g || typeof g !== 'object') continue;
+    if (g.parent_id !== 0 && !idSet.has(g.parent_id)) {
+      warnings.push({ code: 'BROKEN_PARENT_REF', message: `Goal ${g.id} references missing parent ${g.parent_id} — moved to backlog`, path });
+      continue;
+    }
+    // GOALS-012 — parent must be exactly one level above the child (N+1
+    // hierarchy, decision in vkgeorgia/strategy#66). Only enforced when the
+    // parent is resolvable; a missing parent is covered by BROKEN_PARENT_REF.
+    if (g.parent_id !== 0) {
+      const parentLevel = levelById.get(g.parent_id);
+      if (parentLevel !== undefined && g.level !== parentLevel + 1) {
+        errors.push({
+          code: 'GOALS-012',
+          message: `Goal ${g.id} (level ${g.level}) must have a parent at level ${g.level - 1}; parent ${g.parent_id} is at level ${parentLevel}`,
+          path,
+        });
+      }
+    }
+  }
+
+  const cycleError = detectCycle(tree.goals);
+  if (cycleError) errors.push(cycleError);
+
+  return { valid: errors.length === 0, errors, warnings };
+}
+
+function detectCycle(goals: GoalTree['goals']): ValidationError | null {
+  const parentOf = new Map(goals.map(g => [g.id, g.parent_id]));
+
+  for (const g of goals) {
+    const visited = new Set<number>();
+    let cur: number = g.id;
+    while (cur !== 0) {
+      if (visited.has(cur)) {
+        return { code: 'CYCLE_DETECTED', message: `Cycle detected involving goal ${g.id}` };
+      }
+      visited.add(cur);
+      const parent = parentOf.get(cur);
+      if (parent === undefined) break;
+      cur = parent;
+    }
+  }
+  return null;
+}

package/src/index.ts

@@ -1,23 +1,28 @@
-export * from "./activities/index";
-export * from "./activity-card/index";
-export * from "./geometry";
-export * from "./applications/index";
-export * from "./assertion/index";
-export * from "./blocks/index";
-export * from "./capability-map/index";
-export * from "./compliance/index";
-export * from "./compliance-matrix/index";
-export * from "./confidence/index";
-export * from "./fgca/index";
-export * from "./goals/index";
-export * from "./process-blueprint/index";
-export * from "./process-map/index";
-export * from "./products/index";
-export * from "./repo-validate/index";
-export * from "./requirement/index";
-export * from "./scenarios/index";
-export { SCHEMA_VERSION } from "./schema-version";
-export * from "./theme/index";
-export * from "./typed-id";
-export * from "./validation-types";
-export { coerceDatesToIsoStrings } from "./yaml-normalize";
+export * from "./activities/index";
+export * from "./activity-card/index";
+export * from "./actor/index";
+export * from "./geometry";
+export * from "./applications/index";
+export * from "./assertion/index";
+export * from "./blocks/index";
+export * from "./capability-map/index";
+export * from "./change/index";
+export * from "./compliance/index";
+export * from "./compliance-matrix/index";
+export * from "./confidence/index";
+export * from "./factor/index";
+export * from "./fgca/index";
+export * from "./goals/index";
+export * from "./process-blueprint/index";
+export * from "./process-map/index";
+export * from "./products/index";
+export * from "./repo-validate/index";
+export * from "./requirement/index";
+export * from "./scenarios/index";
+export * from "./stakeholder/index";
+export * from "./target-state/index";
+export { SCHEMA_VERSION } from "./schema-version";
+export * from "./theme/index";
+export * from "./typed-id";
+export * from "./validation-types";
+export { coerceDatesToIsoStrings } from "./yaml-normalize";