@transitrix/diagrams 1.0.0 → 1.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (315) hide show
  1. package/LICENSE +21 -21
  2. package/README.md +47 -47
  3. package/dist/__tests__/edge-path.test.js +8 -0
  4. package/dist/activities/cpm.js +11 -2
  5. package/dist/activities/gantt.js +6 -3
  6. package/dist/activities/types.d.ts +1 -0
  7. package/dist/activities/validate.js +3 -3
  8. package/dist/activity-card/__tests__/example.test.js +20 -1
  9. package/dist/activity-card/__tests__/layout.test.js +102 -11
  10. package/dist/activity-card/__tests__/resolver.test.js +161 -7
  11. package/dist/activity-card/index.d.ts +1 -1
  12. package/dist/activity-card/layout.d.ts +1 -1
  13. package/dist/activity-card/layout.js +220 -103
  14. package/dist/activity-card/resolver.js +115 -28
  15. package/dist/activity-card/types.d.ts +150 -27
  16. package/dist/activity-card/validate.js +3 -0
  17. package/dist/actor/__tests__/validate.test.js +63 -31
  18. package/dist/actor/index.d.ts +1 -1
  19. package/dist/actor/index.js +1 -1
  20. package/dist/actor/types.d.ts +7 -3
  21. package/dist/actor/types.js +17 -3
  22. package/dist/actor/validate.js +55 -26
  23. package/dist/assertion/types.d.ts +3 -1
  24. package/dist/assertion/types.js +1 -1
  25. package/dist/change/__tests__/validate.test.js +40 -34
  26. package/dist/change/index.d.ts +1 -0
  27. package/dist/change/types.d.ts +1 -1
  28. package/dist/change/types.js +2 -2
  29. package/dist/change/validate.d.ts +6 -1
  30. package/dist/change/validate.js +68 -41
  31. package/dist/compliance/__tests__/classify.test.js +34 -0
  32. package/dist/compliance/__tests__/coverage-metric.test.js +146 -46
  33. package/dist/compliance/__tests__/html.test.js +2 -2
  34. package/dist/compliance/__tests__/impact.test.js +509 -6
  35. package/dist/compliance/classify.d.ts +6 -0
  36. package/dist/compliance/classify.js +9 -1
  37. package/dist/compliance/coverage-metric.d.ts +31 -11
  38. package/dist/compliance/coverage-metric.js +149 -39
  39. package/dist/compliance/html.js +78 -81
  40. package/dist/compliance/impact.d.ts +100 -16
  41. package/dist/compliance/impact.js +272 -28
  42. package/dist/compliance/index.d.ts +2 -2
  43. package/dist/compliance/index.js +1 -1
  44. package/dist/compliance/markdown.js +1 -0
  45. package/dist/compliance/types.d.ts +25 -6
  46. package/dist/edge-path.d.ts +8 -4
  47. package/dist/edge-path.js +11 -6
  48. package/dist/factor/__tests__/validate.test.js +75 -46
  49. package/dist/factor/index.d.ts +3 -2
  50. package/dist/factor/index.js +1 -1
  51. package/dist/factor/types.d.ts +5 -8
  52. package/dist/factor/types.js +10 -5
  53. package/dist/factor/validate.d.ts +6 -1
  54. package/dist/factor/validate.js +68 -50
  55. package/dist/fgca/__tests__/chain-table.test.js +2 -2
  56. package/dist/fgca/__tests__/layout.test.js +11 -11
  57. package/dist/fgca/__tests__/preview-layout.test.js +7 -7
  58. package/dist/fgca/__tests__/resolver.test.js +185 -0
  59. package/dist/fgca/chain-table.d.ts +1 -1
  60. package/dist/fgca/chain-table.js +4 -4
  61. package/dist/fgca/index.d.ts +4 -2
  62. package/dist/fgca/index.js +2 -1
  63. package/dist/fgca/layout.d.ts +2 -2
  64. package/dist/fgca/layout.js +9 -9
  65. package/dist/fgca/nodeTypes.d.ts +1 -1
  66. package/dist/fgca/nodeTypes.js +2 -2
  67. package/dist/fgca/nodes/FGCAFactorNode.d.ts +3 -3
  68. package/dist/fgca/nodes/FGCAFactorNode.js +5 -5
  69. package/dist/fgca/parse-canonical.js +15 -10
  70. package/dist/fgca/preview-layout.d.ts +1 -1
  71. package/dist/fgca/preview-layout.js +4 -4
  72. package/dist/fgca/resolver.d.ts +49 -0
  73. package/dist/fgca/resolver.js +126 -0
  74. package/dist/fgca/types.d.ts +11 -11
  75. package/dist/fgca/types.js +2 -2
  76. package/dist/fgca/validate.d.ts +2 -2
  77. package/dist/fgca/validate.js +17 -14
  78. package/dist/goals/index.d.ts +1 -1
  79. package/dist/index.d.ts +5 -0
  80. package/dist/index.js +5 -0
  81. package/dist/process-blueprint/__tests__/layout.test.js +37 -0
  82. package/dist/process-blueprint/index.d.ts +1 -1
  83. package/dist/process-blueprint/layout.js +66 -35
  84. package/dist/process-blueprint/types.d.ts +36 -1
  85. package/dist/scenarios/index.d.ts +1 -1
  86. package/dist/scenarios/types.d.ts +4 -4
  87. package/dist/stakeholder/__tests__/validate.test.js +49 -47
  88. package/dist/stakeholder/index.d.ts +1 -0
  89. package/dist/stakeholder/types.d.ts +3 -4
  90. package/dist/stakeholder/types.js +2 -3
  91. package/dist/stakeholder/validate.d.ts +6 -1
  92. package/dist/stakeholder/validate.js +71 -50
  93. package/dist/target-state/__tests__/validate.test.js +43 -27
  94. package/dist/target-state/index.d.ts +2 -0
  95. package/dist/target-state/index.js +1 -0
  96. package/dist/target-state/types.d.ts +6 -1
  97. package/dist/target-state/types.js +8 -7
  98. package/dist/target-state/validate.d.ts +6 -1
  99. package/dist/target-state/validate.js +69 -45
  100. package/dist/theme/themes.js +71 -69
  101. package/dist/theme/tokens.d.ts +7 -1
  102. package/dist/theme/tokens.js +3 -1
  103. package/dist/webview/__tests__/entry-notations.test.js +2 -0
  104. package/dist/webview/__tests__/entry.test.js +11 -11
  105. package/dist/webview/__tests__/render-process.test.js +463 -0
  106. package/dist/webview/__tests__/render-util.test.d.ts +1 -0
  107. package/dist/webview/__tests__/render-util.test.js +54 -0
  108. package/dist/webview/entry.d.ts +1 -1
  109. package/dist/webview/entry.js +9 -5
  110. package/dist/webview/render-activities.d.ts +24 -2
  111. package/dist/webview/render-activities.js +92 -57
  112. package/dist/webview/render-activity-card.d.ts +11 -1
  113. package/dist/webview/render-activity-card.js +115 -79
  114. package/dist/webview/render-blocks.d.ts +24 -1
  115. package/dist/webview/render-blocks.js +58 -24
  116. package/dist/webview/render-fgca.d.ts +31 -0
  117. package/dist/webview/render-fgca.js +30 -19
  118. package/dist/webview/render-goals.d.ts +27 -1
  119. package/dist/webview/render-goals.js +42 -32
  120. package/dist/webview/render-process-blueprint.d.ts +11 -1
  121. package/dist/webview/render-process-blueprint.js +118 -53
  122. package/dist/webview/render-process.d.ts +95 -0
  123. package/dist/webview/render-process.js +392 -0
  124. package/dist/webview/render-scenarios.js +2 -2
  125. package/dist/webview/render-util.d.ts +19 -6
  126. package/dist/webview/render-util.js +23 -15
  127. package/package.json +54 -40
  128. package/src/__tests__/edge-path.test.ts +58 -46
  129. package/src/__tests__/scope.test.ts +27 -27
  130. package/src/__tests__/yaml-normalize.test.ts +158 -158
  131. package/src/activities/__tests__/cpm.test.ts +164 -164
  132. package/src/activities/__tests__/gantt.test.ts +245 -245
  133. package/src/activities/__tests__/layout.test.ts +112 -112
  134. package/src/activities/__tests__/validate.test.ts +409 -409
  135. package/src/activities/cpm.ts +107 -95
  136. package/src/activities/gantt.ts +277 -276
  137. package/src/activities/index.ts +28 -28
  138. package/src/activities/layout.ts +112 -112
  139. package/src/activities/types.ts +149 -148
  140. package/src/activities/validate.ts +357 -357
  141. package/src/activity-card/__tests__/example.test.ts +85 -66
  142. package/src/activity-card/__tests__/layout.test.ts +169 -63
  143. package/src/activity-card/__tests__/resolver.test.ts +330 -161
  144. package/src/activity-card/__tests__/validate.test.ts +131 -131
  145. package/src/activity-card/index.ts +38 -32
  146. package/src/activity-card/layout.ts +324 -194
  147. package/src/activity-card/resolver.ts +422 -337
  148. package/src/activity-card/types.ts +376 -237
  149. package/src/activity-card/validate.ts +162 -158
  150. package/src/actor/__tests__/validate.test.ts +70 -31
  151. package/src/actor/index.ts +1 -1
  152. package/src/actor/types.ts +21 -7
  153. package/src/actor/validate.ts +59 -27
  154. package/src/applications/__tests__/validate.test.ts +256 -256
  155. package/src/applications/index.ts +11 -11
  156. package/src/applications/types.ts +43 -43
  157. package/src/applications/validate.ts +131 -131
  158. package/src/assertion/__tests__/example.test.ts +37 -37
  159. package/src/assertion/__tests__/validate.test.ts +142 -142
  160. package/src/assertion/index.ts +12 -12
  161. package/src/assertion/types.ts +60 -58
  162. package/src/assertion/validate.ts +145 -145
  163. package/src/blocks/__tests__/layout.test.ts +169 -169
  164. package/src/blocks/__tests__/validate.test.ts +260 -260
  165. package/src/blocks/index.ts +17 -17
  166. package/src/blocks/layout.ts +186 -186
  167. package/src/blocks/types.ts +62 -62
  168. package/src/blocks/validate.ts +206 -206
  169. package/src/capability-map/__tests__/validate.test.ts +238 -238
  170. package/src/capability-map/index.ts +8 -8
  171. package/src/capability-map/types.ts +29 -29
  172. package/src/capability-map/validate.ts +127 -127
  173. package/src/change/__tests__/validate.test.ts +43 -34
  174. package/src/change/index.ts +1 -0
  175. package/src/change/types.ts +5 -3
  176. package/src/change/validate.ts +75 -43
  177. package/src/compliance/__tests__/classify.test.ts +64 -27
  178. package/src/compliance/__tests__/confidence.test.ts +98 -98
  179. package/src/compliance/__tests__/coverage-metric.test.ts +300 -188
  180. package/src/compliance/__tests__/demo-scenario.test.ts +273 -273
  181. package/src/compliance/__tests__/example.test.ts +57 -57
  182. package/src/compliance/__tests__/gap-report.test.ts +128 -128
  183. package/src/compliance/__tests__/html.test.ts +141 -141
  184. package/src/compliance/__tests__/impact.test.ts +1059 -481
  185. package/src/compliance/__tests__/markdown.test.ts +94 -94
  186. package/src/compliance/__tests__/views.test.ts +64 -64
  187. package/src/compliance/classify.ts +100 -84
  188. package/src/compliance/confidence.ts +69 -69
  189. package/src/compliance/coverage-metric.ts +404 -263
  190. package/src/compliance/gap-report.ts +94 -94
  191. package/src/compliance/html.ts +291 -295
  192. package/src/compliance/impact.ts +979 -677
  193. package/src/compliance/index.ts +57 -56
  194. package/src/compliance/markdown.ts +136 -135
  195. package/src/compliance/reverse-index.ts +33 -33
  196. package/src/compliance/types.ts +136 -120
  197. package/src/compliance/views.ts +46 -46
  198. package/src/compliance-matrix/__tests__/build.test.ts +200 -200
  199. package/src/compliance-matrix/__tests__/example.test.ts +57 -57
  200. package/src/compliance-matrix/index.ts +11 -11
  201. package/src/compliance-matrix/types.ts +102 -102
  202. package/src/edge-path.ts +50 -44
  203. package/src/factor/__tests__/validate.test.ts +81 -46
  204. package/src/factor/index.ts +3 -7
  205. package/src/factor/types.ts +15 -19
  206. package/src/factor/validate.ts +77 -51
  207. package/src/fgca/__tests__/chain-table.test.ts +172 -172
  208. package/src/fgca/__tests__/layout.test.ts +179 -179
  209. package/src/fgca/__tests__/parse-canonical.test.ts +248 -248
  210. package/src/fgca/__tests__/preview-layout.test.ts +124 -124
  211. package/src/fgca/__tests__/resolver.test.ts +209 -0
  212. package/src/fgca/__tests__/validate.test.ts +142 -142
  213. package/src/fgca/chain-table.ts +225 -225
  214. package/src/fgca/index.ts +47 -45
  215. package/src/fgca/layout.ts +204 -204
  216. package/src/fgca/nodeTypes.ts +11 -11
  217. package/src/fgca/nodes/FGCAActivityNode.tsx +65 -65
  218. package/src/fgca/nodes/FGCAChangeNode.tsx +64 -64
  219. package/src/fgca/nodes/FGCAFactorNode.tsx +64 -64
  220. package/src/fgca/nodes/FGCAGoalNode.tsx +72 -72
  221. package/src/fgca/parse-canonical.ts +405 -400
  222. package/src/fgca/preview-layout.ts +217 -217
  223. package/src/fgca/resolver.ts +159 -0
  224. package/src/fgca/types.ts +50 -50
  225. package/src/fgca/validate.ts +129 -126
  226. package/src/geometry.ts +9 -9
  227. package/src/goals/__tests__/layout.test.ts +175 -175
  228. package/src/goals/__tests__/mutations.test.ts +111 -111
  229. package/src/goals/__tests__/parse-canonical.test.ts +145 -145
  230. package/src/goals/__tests__/validate.test.ts +202 -202
  231. package/src/goals/index.ts +20 -21
  232. package/src/goals/layout.ts +172 -172
  233. package/src/goals/mutations.ts +123 -123
  234. package/src/goals/parse-canonical.ts +286 -286
  235. package/src/goals/types.ts +85 -85
  236. package/src/goals/validate.ts +136 -136
  237. package/src/index.ts +28 -23
  238. package/src/process-blueprint/__tests__/compliance-lane.test.ts +320 -320
  239. package/src/process-blueprint/__tests__/layout.test.ts +240 -195
  240. package/src/process-blueprint/__tests__/validate.test.ts +310 -310
  241. package/src/process-blueprint/index.ts +32 -31
  242. package/src/process-blueprint/layout.ts +564 -531
  243. package/src/process-blueprint/types.ts +278 -242
  244. package/src/process-blueprint/validate.ts +181 -181
  245. package/src/process-map/__tests__/validate.test.ts +223 -223
  246. package/src/process-map/index.ts +10 -10
  247. package/src/process-map/types.ts +36 -36
  248. package/src/process-map/validate.ts +135 -135
  249. package/src/products/__tests__/validate.test.ts +239 -239
  250. package/src/products/index.ts +9 -9
  251. package/src/products/types.ts +31 -31
  252. package/src/products/validate.ts +112 -112
  253. package/src/repo-validate/__tests__/validate-repo.test.ts +149 -149
  254. package/src/repo-validate/index.ts +2 -2
  255. package/src/repo-validate/types.ts +50 -50
  256. package/src/repo-validate/validate-repo.ts +196 -196
  257. package/src/requirement/__tests__/example.test.ts +24 -24
  258. package/src/requirement/__tests__/validate.test.ts +96 -96
  259. package/src/requirement/index.ts +4 -4
  260. package/src/requirement/types.ts +35 -35
  261. package/src/requirement/validate.ts +92 -92
  262. package/src/scenarios/__tests__/validate.test.ts +209 -209
  263. package/src/scenarios/index.ts +15 -15
  264. package/src/scenarios/types.ts +37 -37
  265. package/src/scenarios/validate.ts +122 -122
  266. package/src/schema-version.ts +16 -16
  267. package/src/scope.ts +46 -46
  268. package/src/stakeholder/__tests__/validate.test.ts +51 -47
  269. package/src/stakeholder/index.ts +1 -0
  270. package/src/stakeholder/types.ts +7 -7
  271. package/src/stakeholder/validate.ts +79 -52
  272. package/src/target-state/__tests__/validate.test.ts +48 -27
  273. package/src/target-state/index.ts +2 -0
  274. package/src/target-state/types.ts +11 -7
  275. package/src/target-state/validate.ts +76 -46
  276. package/src/theme/index.ts +4 -4
  277. package/src/theme/themes.ts +239 -237
  278. package/src/theme/tokens.ts +135 -133
  279. package/src/typed-id.ts +56 -56
  280. package/src/validation-types.ts +36 -36
  281. package/src/webview/__tests__/entry-notations.test.ts +79 -77
  282. package/src/webview/__tests__/entry.test.ts +64 -64
  283. package/src/webview/__tests__/render-goals.test.ts +72 -72
  284. package/src/webview/__tests__/render-process.test.ts +538 -0
  285. package/src/webview/__tests__/render-util.test.ts +66 -0
  286. package/src/webview/entry.ts +298 -292
  287. package/src/webview/render-activities.ts +111 -69
  288. package/src/webview/render-activity-card.ts +275 -234
  289. package/src/webview/render-blocks.ts +78 -28
  290. package/src/webview/render-fgca.ts +53 -28
  291. package/src/webview/render-goals.ts +133 -110
  292. package/src/webview/render-process-blueprint.ts +281 -207
  293. package/src/webview/render-process.ts +507 -0
  294. package/src/webview/render-scenarios.ts +3 -3
  295. package/src/webview/render-util.ts +27 -14
  296. package/src/webview/styles.css +322 -323
  297. package/src/yaml-normalize.ts +56 -56
  298. package/dist/element-envelope.d.ts +0 -15
  299. package/dist/element-envelope.js +0 -55
  300. package/dist/issues/__tests__/layout.test.js +0 -62
  301. package/dist/issues/__tests__/validate.test.js +0 -82
  302. package/dist/issues/index.d.ts +0 -4
  303. package/dist/issues/index.js +0 -2
  304. package/dist/issues/layout.d.ts +0 -10
  305. package/dist/issues/layout.js +0 -82
  306. package/dist/issues/types.d.ts +0 -61
  307. package/dist/issues/types.js +0 -6
  308. package/dist/issues/validate.d.ts +0 -3
  309. package/dist/issues/validate.js +0 -143
  310. package/dist/webview/transitrix-render.css +0 -323
  311. package/dist/webview/transitrix-render.js +0 -6452
  312. package/dist/webview/transitrix-render.js.map +0 -7
  313. package/src/element-envelope.ts +0 -76
  314. /package/dist/{issues/__tests__/layout.test.d.ts → fgca/__tests__/resolver.test.d.ts} +0 -0
  315. /package/dist/{issues/__tests__/validate.test.d.ts → webview/__tests__/render-process.test.d.ts} +0 -0
@@ -1,175 +1,175 @@
1
- import { describe, it, expect } from 'vitest';
2
- import { layoutGoalTree } from '../layout.js';
3
- import type { GoalTree } from '../types.js';
4
-
5
- const TREE: GoalTree = {
6
- goal_types: [
7
- { name: 'Strategy', level: 0 },
8
- { name: 'Business Goal', level: 1 },
9
- { name: 'Project', level: 2 },
10
- ],
11
- goals: [
12
- { id: 1, name: 'North Star', type: 'Strategy', level: 0, parent_id: 0 },
13
- { id: 2, name: 'EU Expansion', type: 'Business Goal', level: 1, parent_id: 1 },
14
- { id: 3, name: 'Berlin Office', type: 'Project', level: 2, parent_id: 2 },
15
- { id: 4, name: 'London Office', type: 'Project', level: 2, parent_id: 2 },
16
- ],
17
- };
18
-
19
- describe('layoutGoalTree', () => {
20
- it('returns nodes for all goals', () => {
21
- const layout = layoutGoalTree(TREE);
22
- expect(layout.nodes).toHaveLength(4);
23
- });
24
-
25
- it('returns edges for parent-child pairs', () => {
26
- const layout = layoutGoalTree(TREE);
27
- expect(layout.edges).toHaveLength(3); // 1→2, 2→3, 2→4
28
- });
29
-
30
- it('levels map to increasing x positions', () => {
31
- const layout = layoutGoalTree(TREE);
32
- const byId = new Map(layout.nodes.map(n => [n.id, n]));
33
- expect(byId.get(1)!.x).toBeLessThan(byId.get(2)!.x);
34
- expect(byId.get(2)!.x).toBeLessThan(byId.get(3)!.x);
35
- });
36
-
37
- it('siblings at same level have different y positions', () => {
38
- const layout = layoutGoalTree(TREE);
39
- const byId = new Map(layout.nodes.map(n => [n.id, n]));
40
- expect(byId.get(3)!.y).not.toBe(byId.get(4)!.y);
41
- });
42
-
43
- it('returns non-zero bounds for non-empty tree', () => {
44
- const layout = layoutGoalTree(TREE);
45
- expect(layout.bounds.width).toBeGreaterThan(0);
46
- expect(layout.bounds.height).toBeGreaterThan(0);
47
- });
48
-
49
- it('returns empty layout for empty goals', () => {
50
- const layout = layoutGoalTree({ goal_types: [], goals: [] });
51
- expect(layout.nodes).toHaveLength(0);
52
- expect(layout.edges).toHaveLength(0);
53
- });
54
-
55
- it('nodes have default 250×80 size', () => {
56
- const layout = layoutGoalTree(TREE);
57
- expect(layout.nodes[0].width).toBe(250);
58
- expect(layout.nodes[0].height).toBe(80);
59
- });
60
-
61
- it('respects custom nodeWidth/nodeHeight', () => {
62
- const layout = layoutGoalTree(TREE, { nodeWidth: 200, nodeHeight: 60 });
63
- expect(layout.nodes[0].width).toBe(200);
64
- expect(layout.nodes[0].height).toBe(60);
65
- });
66
-
67
- // vkgeorgia/strategy#75 — configurable spacing. The preview maps
68
- // horizontalGap → rankSep and verticalGap → nodeSep.
69
- it('larger rankSep widens the column step', () => {
70
- const tight = layoutGoalTree(TREE, { rankSep: 80 });
71
- const wide = layoutGoalTree(TREE, { rankSep: 200 });
72
- const stepOf = (l: ReturnType<typeof layoutGoalTree>) => {
73
- const byId = new Map(l.nodes.map(n => [n.id, n]));
74
- return byId.get(2)!.x - byId.get(1)!.x;
75
- };
76
- expect(stepOf(wide)).toBeGreaterThan(stepOf(tight));
77
- });
78
-
79
- it('larger nodeSep increases the gap between stacked siblings', () => {
80
- const gapOf = (sep: number) => {
81
- const l = layoutGoalTree(TREE, { nodeSep: sep });
82
- const byId = new Map(l.nodes.map(n => [n.id, n]));
83
- return Math.abs(byId.get(4)!.y - byId.get(3)!.y);
84
- };
85
- expect(gapOf(120)).toBeGreaterThan(gapOf(24));
86
- });
87
-
88
- it('each node carries original goal data', () => {
89
- const layout = layoutGoalTree(TREE);
90
- const node1 = layout.nodes.find(n => n.id === 1)!;
91
- expect(node1.data.name).toBe('North Star');
92
- });
93
-
94
- it('viewDepth hides nodes beyond depth', () => {
95
- const layout = layoutGoalTree(TREE, { viewDepth: 1 });
96
- // Level 2 nodes (id 3, 4) should be hidden
97
- expect(layout.nodes.every(n => n.data.level <= 1)).toBe(true);
98
- });
99
-
100
- it('compresses non-contiguous levels into adjacent columns (no phantom empty columns)', () => {
101
- // Legacy / non-canonical input: goal_types skip levels 1 and 3, so
102
- // goals sit at levels 0, 2, 4. Column x must advance by exactly one
103
- // step per used level, not per absolute level value — otherwise the
104
- // skipped levels open empty columns and double the horizontal spacing.
105
- const gapped: GoalTree = {
106
- goal_types: [
107
- { name: 'Strategy', level: 0 },
108
- { name: 'Strategic Goal', level: 2 },
109
- { name: 'Project Goal', level: 4 },
110
- ],
111
- goals: [
112
- { id: 1, name: 'Root', type: 'Strategy', level: 0, parent_id: 0 },
113
- { id: 2, name: 'Mid', type: 'Strategic Goal', level: 2, parent_id: 1 },
114
- { id: 3, name: 'Leaf', type: 'Project Goal', level: 4, parent_id: 2 },
115
- ],
116
- };
117
- const layout = layoutGoalTree(gapped);
118
- const byId = new Map(layout.nodes.map(n => [n.id, n]));
119
- const step = byId.get(2)!.x - byId.get(1)!.x;
120
- // Root→Mid and Mid→Leaf must use the same single-column step despite
121
- // the level numbers jumping by 2 each time.
122
- expect(byId.get(3)!.x - byId.get(2)!.x).toBe(step);
123
- // And that step is one node width + one rank separator (250 + 80).
124
- expect(step).toBe(250 + 80);
125
- });
126
-
127
- // Pre-release blocker regression (orchestrator review 2026-05-21).
128
- it('[blocker] does not stack-overflow on a self-parent cycle', () => {
129
- const cyclic: GoalTree = {
130
- goal_types: [{ name: 'X', level: 0 }],
131
- goals: [{ id: 1, name: 'self-parent', type: 'X', level: 0, parent_id: 1 }],
132
- };
133
- // Without a visited-set inside placeSubtree, this recurses forever.
134
- expect(() => layoutGoalTree(cyclic)).not.toThrow();
135
- });
136
-
137
- it('[blocker] does not stack-overflow on a 2-node mutual cycle', () => {
138
- const cyclic: GoalTree = {
139
- goal_types: [{ name: 'X', level: 0 }, { name: 'Y', level: 1 }],
140
- goals: [
141
- { id: 1, name: 'A', type: 'X', level: 0, parent_id: 2 },
142
- { id: 2, name: 'B', type: 'Y', level: 1, parent_id: 1 },
143
- ],
144
- };
145
- expect(() => layoutGoalTree(cyclic)).not.toThrow();
146
- });
147
-
148
- // vkgeorgia/strategy#77 — scope filtering.
149
- describe('scope', () => {
150
- const ids = (l: ReturnType<typeof layoutGoalTree>) => l.nodes.map(n => n.id).sort((a, b) => a - b);
151
-
152
- it("mode 'all' matches the baseline", () => {
153
- expect(ids(layoutGoalTree(TREE, { scope: { mode: 'all' } }))).toEqual(ids(layoutGoalTree(TREE)));
154
- });
155
-
156
- it("mode 'level' trims goals strictly above the cap", () => {
157
- // TREE: id1 level0, id2 level1, id3/id4 level2.
158
- const layout = layoutGoalTree(TREE, { scope: { mode: 'level', maxLevel: 1 } });
159
- expect(ids(layout)).toEqual([1, 2]);
160
- expect(layout.nodes.every(n => n.data.level <= 1)).toBe(true);
161
- });
162
-
163
- it("mode 'root' keeps the chosen goal and its descendants", () => {
164
- // root id2 → itself + children id3, id4.
165
- const layout = layoutGoalTree(TREE, { scope: { mode: 'root', rootGoalId: '2' } });
166
- expect(ids(layout)).toEqual([2, 3, 4]);
167
- });
168
-
169
- it("mode 'root' returns an empty layout when the root is absent", () => {
170
- const layout = layoutGoalTree(TREE, { scope: { mode: 'root', rootGoalId: '999' } });
171
- expect(layout.nodes).toHaveLength(0);
172
- expect(layout.edges).toHaveLength(0);
173
- });
174
- });
175
- });
1
+ import { describe, it, expect } from 'vitest';
2
+ import { layoutGoalTree } from '../layout.js';
3
+ import type { GoalTree } from '../types.js';
4
+
5
+ const TREE: GoalTree = {
6
+ goal_types: [
7
+ { name: 'Strategy', level: 0 },
8
+ { name: 'Business Goal', level: 1 },
9
+ { name: 'Project', level: 2 },
10
+ ],
11
+ goals: [
12
+ { id: 1, name: 'North Star', type: 'Strategy', level: 0, parent_id: 0 },
13
+ { id: 2, name: 'EU Expansion', type: 'Business Goal', level: 1, parent_id: 1 },
14
+ { id: 3, name: 'Berlin Office', type: 'Project', level: 2, parent_id: 2 },
15
+ { id: 4, name: 'London Office', type: 'Project', level: 2, parent_id: 2 },
16
+ ],
17
+ };
18
+
19
+ describe('layoutGoalTree', () => {
20
+ it('returns nodes for all goals', () => {
21
+ const layout = layoutGoalTree(TREE);
22
+ expect(layout.nodes).toHaveLength(4);
23
+ });
24
+
25
+ it('returns edges for parent-child pairs', () => {
26
+ const layout = layoutGoalTree(TREE);
27
+ expect(layout.edges).toHaveLength(3); // 1→2, 2→3, 2→4
28
+ });
29
+
30
+ it('levels map to increasing x positions', () => {
31
+ const layout = layoutGoalTree(TREE);
32
+ const byId = new Map(layout.nodes.map(n => [n.id, n]));
33
+ expect(byId.get(1)!.x).toBeLessThan(byId.get(2)!.x);
34
+ expect(byId.get(2)!.x).toBeLessThan(byId.get(3)!.x);
35
+ });
36
+
37
+ it('siblings at same level have different y positions', () => {
38
+ const layout = layoutGoalTree(TREE);
39
+ const byId = new Map(layout.nodes.map(n => [n.id, n]));
40
+ expect(byId.get(3)!.y).not.toBe(byId.get(4)!.y);
41
+ });
42
+
43
+ it('returns non-zero bounds for non-empty tree', () => {
44
+ const layout = layoutGoalTree(TREE);
45
+ expect(layout.bounds.width).toBeGreaterThan(0);
46
+ expect(layout.bounds.height).toBeGreaterThan(0);
47
+ });
48
+
49
+ it('returns empty layout for empty goals', () => {
50
+ const layout = layoutGoalTree({ goal_types: [], goals: [] });
51
+ expect(layout.nodes).toHaveLength(0);
52
+ expect(layout.edges).toHaveLength(0);
53
+ });
54
+
55
+ it('nodes have default 250×80 size', () => {
56
+ const layout = layoutGoalTree(TREE);
57
+ expect(layout.nodes[0].width).toBe(250);
58
+ expect(layout.nodes[0].height).toBe(80);
59
+ });
60
+
61
+ it('respects custom nodeWidth/nodeHeight', () => {
62
+ const layout = layoutGoalTree(TREE, { nodeWidth: 200, nodeHeight: 60 });
63
+ expect(layout.nodes[0].width).toBe(200);
64
+ expect(layout.nodes[0].height).toBe(60);
65
+ });
66
+
67
+ // vkgeorgia/strategy#75 — configurable spacing. The preview maps
68
+ // horizontalGap → rankSep and verticalGap → nodeSep.
69
+ it('larger rankSep widens the column step', () => {
70
+ const tight = layoutGoalTree(TREE, { rankSep: 80 });
71
+ const wide = layoutGoalTree(TREE, { rankSep: 200 });
72
+ const stepOf = (l: ReturnType<typeof layoutGoalTree>) => {
73
+ const byId = new Map(l.nodes.map(n => [n.id, n]));
74
+ return byId.get(2)!.x - byId.get(1)!.x;
75
+ };
76
+ expect(stepOf(wide)).toBeGreaterThan(stepOf(tight));
77
+ });
78
+
79
+ it('larger nodeSep increases the gap between stacked siblings', () => {
80
+ const gapOf = (sep: number) => {
81
+ const l = layoutGoalTree(TREE, { nodeSep: sep });
82
+ const byId = new Map(l.nodes.map(n => [n.id, n]));
83
+ return Math.abs(byId.get(4)!.y - byId.get(3)!.y);
84
+ };
85
+ expect(gapOf(120)).toBeGreaterThan(gapOf(24));
86
+ });
87
+
88
+ it('each node carries original goal data', () => {
89
+ const layout = layoutGoalTree(TREE);
90
+ const node1 = layout.nodes.find(n => n.id === 1)!;
91
+ expect(node1.data.name).toBe('North Star');
92
+ });
93
+
94
+ it('viewDepth hides nodes beyond depth', () => {
95
+ const layout = layoutGoalTree(TREE, { viewDepth: 1 });
96
+ // Level 2 nodes (id 3, 4) should be hidden
97
+ expect(layout.nodes.every(n => n.data.level <= 1)).toBe(true);
98
+ });
99
+
100
+ it('compresses non-contiguous levels into adjacent columns (no phantom empty columns)', () => {
101
+ // Legacy / non-canonical input: goal_types skip levels 1 and 3, so
102
+ // goals sit at levels 0, 2, 4. Column x must advance by exactly one
103
+ // step per used level, not per absolute level value — otherwise the
104
+ // skipped levels open empty columns and double the horizontal spacing.
105
+ const gapped: GoalTree = {
106
+ goal_types: [
107
+ { name: 'Strategy', level: 0 },
108
+ { name: 'Strategic Goal', level: 2 },
109
+ { name: 'Project Goal', level: 4 },
110
+ ],
111
+ goals: [
112
+ { id: 1, name: 'Root', type: 'Strategy', level: 0, parent_id: 0 },
113
+ { id: 2, name: 'Mid', type: 'Strategic Goal', level: 2, parent_id: 1 },
114
+ { id: 3, name: 'Leaf', type: 'Project Goal', level: 4, parent_id: 2 },
115
+ ],
116
+ };
117
+ const layout = layoutGoalTree(gapped);
118
+ const byId = new Map(layout.nodes.map(n => [n.id, n]));
119
+ const step = byId.get(2)!.x - byId.get(1)!.x;
120
+ // Root→Mid and Mid→Leaf must use the same single-column step despite
121
+ // the level numbers jumping by 2 each time.
122
+ expect(byId.get(3)!.x - byId.get(2)!.x).toBe(step);
123
+ // And that step is one node width + one rank separator (250 + 80).
124
+ expect(step).toBe(250 + 80);
125
+ });
126
+
127
+ // Pre-release blocker regression (orchestrator review 2026-05-21).
128
+ it('[blocker] does not stack-overflow on a self-parent cycle', () => {
129
+ const cyclic: GoalTree = {
130
+ goal_types: [{ name: 'X', level: 0 }],
131
+ goals: [{ id: 1, name: 'self-parent', type: 'X', level: 0, parent_id: 1 }],
132
+ };
133
+ // Without a visited-set inside placeSubtree, this recurses forever.
134
+ expect(() => layoutGoalTree(cyclic)).not.toThrow();
135
+ });
136
+
137
+ it('[blocker] does not stack-overflow on a 2-node mutual cycle', () => {
138
+ const cyclic: GoalTree = {
139
+ goal_types: [{ name: 'X', level: 0 }, { name: 'Y', level: 1 }],
140
+ goals: [
141
+ { id: 1, name: 'A', type: 'X', level: 0, parent_id: 2 },
142
+ { id: 2, name: 'B', type: 'Y', level: 1, parent_id: 1 },
143
+ ],
144
+ };
145
+ expect(() => layoutGoalTree(cyclic)).not.toThrow();
146
+ });
147
+
148
+ // vkgeorgia/strategy#77 — scope filtering.
149
+ describe('scope', () => {
150
+ const ids = (l: ReturnType<typeof layoutGoalTree>) => l.nodes.map(n => n.id).sort((a, b) => a - b);
151
+
152
+ it("mode 'all' matches the baseline", () => {
153
+ expect(ids(layoutGoalTree(TREE, { scope: { mode: 'all' } }))).toEqual(ids(layoutGoalTree(TREE)));
154
+ });
155
+
156
+ it("mode 'level' trims goals strictly above the cap", () => {
157
+ // TREE: id1 level0, id2 level1, id3/id4 level2.
158
+ const layout = layoutGoalTree(TREE, { scope: { mode: 'level', maxLevel: 1 } });
159
+ expect(ids(layout)).toEqual([1, 2]);
160
+ expect(layout.nodes.every(n => n.data.level <= 1)).toBe(true);
161
+ });
162
+
163
+ it("mode 'root' keeps the chosen goal and its descendants", () => {
164
+ // root id2 → itself + children id3, id4.
165
+ const layout = layoutGoalTree(TREE, { scope: { mode: 'root', rootGoalId: '2' } });
166
+ expect(ids(layout)).toEqual([2, 3, 4]);
167
+ });
168
+
169
+ it("mode 'root' returns an empty layout when the root is absent", () => {
170
+ const layout = layoutGoalTree(TREE, { scope: { mode: 'root', rootGoalId: '999' } });
171
+ expect(layout.nodes).toHaveLength(0);
172
+ expect(layout.edges).toHaveLength(0);
173
+ });
174
+ });
175
+ });
@@ -1,111 +1,111 @@
1
- import { describe, it, expect } from 'vitest';
2
- import { reparent, addChild, deleteWithDescendants, moveToBacklog, restoreFromBacklog } from '../mutations.js';
3
- import type { GoalTree } from '../types.js';
4
-
5
- const TREE: GoalTree = {
6
- goal_types: [
7
- { name: 'Strategy', level: 0 },
8
- { name: 'Business Goal', level: 1 },
9
- { name: 'Project', level: 2 },
10
- ],
11
- goals: [
12
- { id: 1, name: 'North Star', type: 'Strategy', level: 0, parent_id: 0 },
13
- { id: 2, name: 'EU Expansion', type: 'Business Goal', level: 1, parent_id: 1 },
14
- { id: 3, name: 'Berlin Office', type: 'Project', level: 2, parent_id: 2 },
15
- ],
16
- };
17
-
18
- describe('reparent', () => {
19
- it('moves a goal to a new parent', () => {
20
- const r = reparent(TREE, 3, 1);
21
- expect(r.ok).toBe(true);
22
- const moved = r.result!.goals.find(g => g.id === 3)!;
23
- expect(moved.parent_id).toBe(1);
24
- expect(moved.level).toBe(1);
25
- });
26
-
27
- it('refuses to create a cycle', () => {
28
- const r = reparent(TREE, 1, 3);
29
- expect(r.ok).toBe(false);
30
- expect(r.error?.code).toBe('MUTATION_REFUSED');
31
- });
32
-
33
- it('refuses self-reparent', () => {
34
- expect(reparent(TREE, 1, 1).ok).toBe(false);
35
- });
36
-
37
- it('refuses reparent that would exceed max level', () => {
38
- const r = reparent(TREE, 1, 3); // would make level 3 which exceeds max 2
39
- expect(r.ok).toBe(false);
40
- });
41
-
42
- it('preserves immutability — original tree unchanged', () => {
43
- reparent(TREE, 3, 1);
44
- expect(TREE.goals.find(g => g.id === 3)!.parent_id).toBe(2);
45
- });
46
- });
47
-
48
- describe('addChild', () => {
49
- it('adds a child with auto-assigned id and level', () => {
50
- const r = addChild(TREE, 2, { name: 'Warsaw Office', type: 'Project', level: 2, parent_id: 2 });
51
- expect(r.ok).toBe(true);
52
- const newGoal = r.result!.goals.find(g => g.name === 'Warsaw Office')!;
53
- expect(newGoal.id).toBeGreaterThan(3);
54
- expect(newGoal.parent_id).toBe(2);
55
- expect(newGoal.level).toBe(2);
56
- });
57
-
58
- it('adds root-level child when parentId is 0', () => {
59
- const r = addChild(TREE, 0, { name: 'Second Strategy', type: 'Strategy', level: 0, parent_id: 0 });
60
- expect(r.ok).toBe(true);
61
- expect(r.result!.goals.find(g => g.name === 'Second Strategy')!.level).toBe(0);
62
- });
63
-
64
- it('refuses when parent not found', () => {
65
- const r = addChild(TREE, 99, { name: 'X', type: 'Project', level: 2, parent_id: 99 });
66
- expect(r.ok).toBe(false);
67
- });
68
-
69
- it('preserves immutability', () => {
70
- const before = TREE.goals.length;
71
- addChild(TREE, 1, { name: 'New', type: 'Business Goal', level: 1, parent_id: 1 });
72
- expect(TREE.goals.length).toBe(before);
73
- });
74
- });
75
-
76
- describe('deleteWithDescendants', () => {
77
- it('deletes goal and all descendants', () => {
78
- const r = deleteWithDescendants(TREE, 2);
79
- expect(r.ok).toBe(true);
80
- const ids = r.result!.goals.map(g => g.id);
81
- expect(ids).not.toContain(2);
82
- expect(ids).not.toContain(3);
83
- expect(ids).toContain(1);
84
- });
85
-
86
- it('refuses when goal not found', () => {
87
- expect(deleteWithDescendants(TREE, 99).ok).toBe(false);
88
- });
89
-
90
- it('preserves immutability', () => {
91
- deleteWithDescendants(TREE, 2);
92
- expect(TREE.goals.length).toBe(3);
93
- });
94
- });
95
-
96
- describe('moveToBacklog', () => {
97
- it('sets parent_id to 0', () => {
98
- const r = moveToBacklog(TREE, 3);
99
- expect(r.ok).toBe(true);
100
- expect(r.result!.goals.find(g => g.id === 3)!.parent_id).toBe(0);
101
- });
102
- });
103
-
104
- describe('restoreFromBacklog', () => {
105
- it('reparents the goal to the new parent', () => {
106
- const backlogged = moveToBacklog(TREE, 3).result!;
107
- const r = restoreFromBacklog(backlogged, 3, 1);
108
- expect(r.ok).toBe(true);
109
- expect(r.result!.goals.find(g => g.id === 3)!.parent_id).toBe(1);
110
- });
111
- });
1
+ import { describe, it, expect } from 'vitest';
2
+ import { reparent, addChild, deleteWithDescendants, moveToBacklog, restoreFromBacklog } from '../mutations.js';
3
+ import type { GoalTree } from '../types.js';
4
+
5
+ const TREE: GoalTree = {
6
+ goal_types: [
7
+ { name: 'Strategy', level: 0 },
8
+ { name: 'Business Goal', level: 1 },
9
+ { name: 'Project', level: 2 },
10
+ ],
11
+ goals: [
12
+ { id: 1, name: 'North Star', type: 'Strategy', level: 0, parent_id: 0 },
13
+ { id: 2, name: 'EU Expansion', type: 'Business Goal', level: 1, parent_id: 1 },
14
+ { id: 3, name: 'Berlin Office', type: 'Project', level: 2, parent_id: 2 },
15
+ ],
16
+ };
17
+
18
+ describe('reparent', () => {
19
+ it('moves a goal to a new parent', () => {
20
+ const r = reparent(TREE, 3, 1);
21
+ expect(r.ok).toBe(true);
22
+ const moved = r.result!.goals.find(g => g.id === 3)!;
23
+ expect(moved.parent_id).toBe(1);
24
+ expect(moved.level).toBe(1);
25
+ });
26
+
27
+ it('refuses to create a cycle', () => {
28
+ const r = reparent(TREE, 1, 3);
29
+ expect(r.ok).toBe(false);
30
+ expect(r.error?.code).toBe('MUTATION_REFUSED');
31
+ });
32
+
33
+ it('refuses self-reparent', () => {
34
+ expect(reparent(TREE, 1, 1).ok).toBe(false);
35
+ });
36
+
37
+ it('refuses reparent that would exceed max level', () => {
38
+ const r = reparent(TREE, 1, 3); // would make level 3 which exceeds max 2
39
+ expect(r.ok).toBe(false);
40
+ });
41
+
42
+ it('preserves immutability — original tree unchanged', () => {
43
+ reparent(TREE, 3, 1);
44
+ expect(TREE.goals.find(g => g.id === 3)!.parent_id).toBe(2);
45
+ });
46
+ });
47
+
48
+ describe('addChild', () => {
49
+ it('adds a child with auto-assigned id and level', () => {
50
+ const r = addChild(TREE, 2, { name: 'Warsaw Office', type: 'Project', level: 2, parent_id: 2 });
51
+ expect(r.ok).toBe(true);
52
+ const newGoal = r.result!.goals.find(g => g.name === 'Warsaw Office')!;
53
+ expect(newGoal.id).toBeGreaterThan(3);
54
+ expect(newGoal.parent_id).toBe(2);
55
+ expect(newGoal.level).toBe(2);
56
+ });
57
+
58
+ it('adds root-level child when parentId is 0', () => {
59
+ const r = addChild(TREE, 0, { name: 'Second Strategy', type: 'Strategy', level: 0, parent_id: 0 });
60
+ expect(r.ok).toBe(true);
61
+ expect(r.result!.goals.find(g => g.name === 'Second Strategy')!.level).toBe(0);
62
+ });
63
+
64
+ it('refuses when parent not found', () => {
65
+ const r = addChild(TREE, 99, { name: 'X', type: 'Project', level: 2, parent_id: 99 });
66
+ expect(r.ok).toBe(false);
67
+ });
68
+
69
+ it('preserves immutability', () => {
70
+ const before = TREE.goals.length;
71
+ addChild(TREE, 1, { name: 'New', type: 'Business Goal', level: 1, parent_id: 1 });
72
+ expect(TREE.goals.length).toBe(before);
73
+ });
74
+ });
75
+
76
+ describe('deleteWithDescendants', () => {
77
+ it('deletes goal and all descendants', () => {
78
+ const r = deleteWithDescendants(TREE, 2);
79
+ expect(r.ok).toBe(true);
80
+ const ids = r.result!.goals.map(g => g.id);
81
+ expect(ids).not.toContain(2);
82
+ expect(ids).not.toContain(3);
83
+ expect(ids).toContain(1);
84
+ });
85
+
86
+ it('refuses when goal not found', () => {
87
+ expect(deleteWithDescendants(TREE, 99).ok).toBe(false);
88
+ });
89
+
90
+ it('preserves immutability', () => {
91
+ deleteWithDescendants(TREE, 2);
92
+ expect(TREE.goals.length).toBe(3);
93
+ });
94
+ });
95
+
96
+ describe('moveToBacklog', () => {
97
+ it('sets parent_id to 0', () => {
98
+ const r = moveToBacklog(TREE, 3);
99
+ expect(r.ok).toBe(true);
100
+ expect(r.result!.goals.find(g => g.id === 3)!.parent_id).toBe(0);
101
+ });
102
+ });
103
+
104
+ describe('restoreFromBacklog', () => {
105
+ it('reparents the goal to the new parent', () => {
106
+ const backlogged = moveToBacklog(TREE, 3).result!;
107
+ const r = restoreFromBacklog(backlogged, 3, 1);
108
+ expect(r.ok).toBe(true);
109
+ expect(r.result!.goals.find(g => g.id === 3)!.parent_id).toBe(1);
110
+ });
111
+ });