@transitrix/diagrams 1.0.0 → 1.1.0

package/src/activities/layout.ts

@@ -1,112 +1,112 @@
-import type { ActivityDoc, Activity, ActivitiesLayout, ActivitiesLayoutOptions, LayoutNode, LayoutEdge } from './types.js';
-import { computeCpm } from './cpm.js';
-
-const NODE_W = 200;
-const NODE_H = 80;
-const H_GAP = 80;
-const V_GAP = 24;
-
-export function layoutActivities(doc: ActivityDoc, options: ActivitiesLayoutOptions = {}): ActivitiesLayout {
-  const { horizontalGap = H_GAP, verticalGap = V_GAP } = options;
-  const activities = doc.activities;
-  if (activities.length === 0) {
-    return { nodes: [], edges: [], bounds: { x: 0, y: 0, width: 0, height: 0 } };
-  }
-
-  const cpm = computeCpm(activities);
-
-  // Topological column assignment via Kahn's
-  const successors = new Map<string, string[]>();
-  const inDegree = new Map<string, number>();
-  for (const a of activities) {
-    successors.set(a.id, []);
-    inDegree.set(a.id, 0);
-  }
-  for (const a of activities) {
-    for (const pred of (a.predecessors ?? [])) {
-      successors.get(pred)?.push(a.id);
-      inDegree.set(a.id, (inDegree.get(a.id) ?? 0) + 1);
-    }
-  }
-
-  const column = new Map<string, number>();
-  const queue: string[] = [];
-  for (const a of activities) {
-    if ((inDegree.get(a.id) ?? 0) === 0) queue.push(a.id);
-  }
-
-  while (queue.length > 0) {
-    const id = queue.shift()!;
-    const col = column.get(id) ?? 0;
-    for (const succ of (successors.get(id) ?? [])) {
-      const newCol = Math.max(column.get(succ) ?? 0, col + 1);
-      column.set(succ, newCol);
-      const newDeg = (inDegree.get(succ) ?? 1) - 1;
-      inDegree.set(succ, newDeg);
-      if (newDeg === 0) queue.push(succ);
-    }
-  }
-
-  // Group activities by column, sort within each column by `sort` then `id`
-  const cols = new Map<number, Activity[]>();
-  for (const a of activities) {
-    const col = column.get(a.id) ?? 0;
-    if (!cols.has(col)) cols.set(col, []);
-    cols.get(col)!.push(a);
-  }
-  for (const list of cols.values()) {
-    list.sort((a, b) => {
-      const sortA = a.sort ?? Number.MAX_SAFE_INTEGER;
-      const sortB = b.sort ?? Number.MAX_SAFE_INTEGER;
-      if (sortA !== sortB) return sortA - sortB;
-      return a.id.localeCompare(b.id);
-    });
-  }
-
-  // Assign positions
-  const nodeMap = new Map<string, LayoutNode>();
-  const nodes: LayoutNode[] = [];
-  const colCount = Math.max(0, ...[...cols.keys()]) + 1;
-
-  for (let c = 0; c < colCount; c++) {
-    const list = cols.get(c) ?? [];
-    const x = c * (NODE_W + horizontalGap);
-    let y = 0;
-    for (const a of list) {
-      const node: LayoutNode = {
-        id: a.id,
-        x,
-        y,
-        width: NODE_W,
-        height: NODE_H,
-        data: a,
-        cpm: cpm.get(a.id),
-      };
-      nodes.push(node);
-      nodeMap.set(a.id, node);
-      y += NODE_H + verticalGap;
-    }
-  }
-
-  // Build edges
-  const edges: LayoutEdge[] = [];
-  for (const a of activities) {
-    for (const predId of (a.predecessors ?? [])) {
-      if (nodeMap.has(predId)) {
-        const predCpm = cpm.get(predId);
-        const succCpm = cpm.get(a.id);
-        const isCritical = (predCpm?.isCritical ?? false) && (succCpm?.isCritical ?? false);
-        edges.push({ sourceId: predId, targetId: a.id, isCritical });
-      }
-    }
-  }
-
-  if (nodes.length === 0) return { nodes, edges, bounds: { x: 0, y: 0, width: 0, height: 0 } };
-
-  const minX = Math.min(...nodes.map(n => n.x));
-  const minY = Math.min(...nodes.map(n => n.y));
-  const maxX = Math.max(...nodes.map(n => n.x + n.width));
-  const maxY = Math.max(...nodes.map(n => n.y + n.height));
-
-  return { nodes, edges, bounds: { x: minX, y: minY, width: maxX - minX, height: maxY - minY } };
-}
+import type { ActivityDoc, Activity, ActivitiesLayout, ActivitiesLayoutOptions, LayoutNode, LayoutEdge } from './types.js';
+import { computeCpm } from './cpm.js';
+
+const NODE_W = 200;
+const NODE_H = 80;
+const H_GAP = 80;
+const V_GAP = 24;
+
+export function layoutActivities(doc: ActivityDoc, options: ActivitiesLayoutOptions = {}): ActivitiesLayout {
+  const { horizontalGap = H_GAP, verticalGap = V_GAP } = options;
+  const activities = doc.activities;
+  if (activities.length === 0) {
+    return { nodes: [], edges: [], bounds: { x: 0, y: 0, width: 0, height: 0 } };
+  }
+
+  const cpm = computeCpm(activities);
+
+  // Topological column assignment via Kahn's
+  const successors = new Map<string, string[]>();
+  const inDegree = new Map<string, number>();
+  for (const a of activities) {
+    successors.set(a.id, []);
+    inDegree.set(a.id, 0);
+  }
+  for (const a of activities) {
+    for (const pred of (a.predecessors ?? [])) {
+      successors.get(pred)?.push(a.id);
+      inDegree.set(a.id, (inDegree.get(a.id) ?? 0) + 1);
+    }
+  }
+
+  const column = new Map<string, number>();
+  const queue: string[] = [];
+  for (const a of activities) {
+    if ((inDegree.get(a.id) ?? 0) === 0) queue.push(a.id);
+  }
+
+  while (queue.length > 0) {
+    const id = queue.shift()!;
+    const col = column.get(id) ?? 0;
+    for (const succ of (successors.get(id) ?? [])) {
+      const newCol = Math.max(column.get(succ) ?? 0, col + 1);
+      column.set(succ, newCol);
+      const newDeg = (inDegree.get(succ) ?? 1) - 1;
+      inDegree.set(succ, newDeg);
+      if (newDeg === 0) queue.push(succ);
+    }
+  }
+
+  // Group activities by column, sort within each column by `sort` then `id`
+  const cols = new Map<number, Activity[]>();
+  for (const a of activities) {
+    const col = column.get(a.id) ?? 0;
+    if (!cols.has(col)) cols.set(col, []);
+    cols.get(col)!.push(a);
+  }
+  for (const list of cols.values()) {
+    list.sort((a, b) => {
+      const sortA = a.sort ?? Number.MAX_SAFE_INTEGER;
+      const sortB = b.sort ?? Number.MAX_SAFE_INTEGER;
+      if (sortA !== sortB) return sortA - sortB;
+      return a.id.localeCompare(b.id);
+    });
+  }
+
+  // Assign positions
+  const nodeMap = new Map<string, LayoutNode>();
+  const nodes: LayoutNode[] = [];
+  const colCount = Math.max(0, ...[...cols.keys()]) + 1;
+
+  for (let c = 0; c < colCount; c++) {
+    const list = cols.get(c) ?? [];
+    const x = c * (NODE_W + horizontalGap);
+    let y = 0;
+    for (const a of list) {
+      const node: LayoutNode = {
+        id: a.id,
+        x,
+        y,
+        width: NODE_W,
+        height: NODE_H,
+        data: a,
+        cpm: cpm.get(a.id),
+      };
+      nodes.push(node);
+      nodeMap.set(a.id, node);
+      y += NODE_H + verticalGap;
+    }
+  }
+
+  // Build edges
+  const edges: LayoutEdge[] = [];
+  for (const a of activities) {
+    for (const predId of (a.predecessors ?? [])) {
+      if (nodeMap.has(predId)) {
+        const predCpm = cpm.get(predId);
+        const succCpm = cpm.get(a.id);
+        const isCritical = (predCpm?.isCritical ?? false) && (succCpm?.isCritical ?? false);
+        edges.push({ sourceId: predId, targetId: a.id, isCritical });
+      }
+    }
+  }
+
+  if (nodes.length === 0) return { nodes, edges, bounds: { x: 0, y: 0, width: 0, height: 0 } };
+
+  const minX = Math.min(...nodes.map(n => n.x));
+  const minY = Math.min(...nodes.map(n => n.y));
+  const maxX = Math.max(...nodes.map(n => n.x + n.width));
+  const maxY = Math.max(...nodes.map(n => n.y + n.height));
+
+  return { nodes, edges, bounds: { x: minX, y: minY, width: maxX - minX, height: maxY - minY } };
+}

package/src/activities/types.ts

@@ -1,148 +1,149 @@
-// Activities historically exposed PREFIXED validation type names. Keep them
-// as aliases of the shared shape (`../validation-types.ts`) so external
-// consumers keep working.
-import type {
-  ValidationError as SharedValidationError,
-  ValidationWarning as SharedValidationWarning,
-  ValidationResult as SharedValidationResult,
-} from '../validation-types.js';
-
-export type ActivityValidationError = SharedValidationError;
-export type ActivityValidationWarning = SharedValidationWarning;
-export type ActivityValidationResult = SharedValidationResult;
-
-export interface Activity {
-  id: string;
-  name: string;
-  duration?: number;
-  activity_type?: string;
-  goals?: string[];
-  scenario?: string;
-  parent?: string;
-  predecessors?: string[];
-  owner?: string;
-  unit?: string;
-  employee?: string;
-  score?: number;
-  sort?: number;
-  tags?: string[];
-  start_date?: string;
-  end_date?: string;
-  labor_cost?: number;
-  resources_cost?: number;
-  effort?: number;
-  link?: string;
-  description?: string;
-  delivers_changes?: string[];
-}
-
-export type Weekday = 'mon' | 'tue' | 'wed' | 'thu' | 'fri' | 'sat' | 'sun';
-
-export interface ProjectCalendar {
-  working_days?: Weekday[];
-  hours_per_day?: number;
-  holidays?: string[];
-}
-
-export interface ProjectBlock {
-  start_date?: string;
-  calendar?: ProjectCalendar;
-}
-
-export interface ActivityDoc {
-  notation: string;
-  spec_version?: string;
-  title?: string;
-  description?: string;
-  version?: string;
-  date?: string;
-  author?: string;
-  project?: ProjectBlock;
-  activities: Activity[];
-}
-
-export interface CpmValues {
-  es: number;
-  ef: number;
-  ls: number;
-  lf: number;
-  slack: number;
-  isCritical: boolean;
-}
-
-export type CpmResult = Map<string, CpmValues>;
-
-export interface LayoutNode {
-  id: string;
-  x: number;
-  y: number;
-  width: number;
-  height: number;
-  data: Activity;
-  cpm?: CpmValues;
-}
-
-export interface LayoutEdge {
-  sourceId: string;
-  targetId: string;
-  isCritical: boolean;
-}
-
-export interface ActivitiesLayout {
-  nodes: LayoutNode[];
-  edges: LayoutEdge[];
-  bounds: { x: number; y: number; width: number; height: number };
-}
-
-export interface ActivitiesLayoutOptions {
-  /** Horizontal gap (px) between CPM columns. Default matches the historical hardcoded value. */
-  horizontalGap?: number;
-  /** Vertical gap (px) between stacked activity nodes. Default matches the historical hardcoded value. */
-  verticalGap?: number;
-}
-
-// ── Gantt view (spec §9) ─────────────────────────────────────────────────────
-
-export type GanttMode = 'computed' | 'pinned';
-
-export type GanttBarKind = 'leaf' | 'milestone' | 'phase';
-
-export interface GanttBar {
-  id: string;
-  name: string;
-  kind: GanttBarKind;
-  /** Inclusive start date as ISO 8601 yyyy-mm-dd. */
-  startDate: string;
-  /** Inclusive end date as ISO 8601 yyyy-mm-dd. For milestones equals startDate. */
-  endDate: string;
-  /** True if the activity is on the critical path (only when CPM applies — computed mode). */
-  isCritical: boolean;
-  /** Optional parent activity id (for phase grouping). */
-  parent?: string;
-  /** Activity record. */
-  data: Activity;
-}
-
-export interface GanttLink {
-  sourceId: string;
-  targetId: string;
-  isCritical: boolean;
-}
-
-export interface GanttLayout {
-  /** Render mode that produced this layout. */
-  mode: GanttMode;
-  /** Inclusive timeline bounds as ISO 8601 yyyy-mm-dd. */
-  timelineStart: string;
-  timelineEnd: string;
-  bars: GanttBar[];
-  links: GanttLink[];
-}
-
-export interface GanttUnavailable {
-  unavailable: true;
-  /** Human-readable explanation of what is missing. */
-  reason: string;
-}
-
-export type GanttResult = GanttLayout | GanttUnavailable;
+// Activities historically exposed PREFIXED validation type names. Keep them
+// as aliases of the shared shape (`../validation-types.ts`) so external
+// consumers keep working.
+import type {
+  ValidationError as SharedValidationError,
+  ValidationWarning as SharedValidationWarning,
+  ValidationResult as SharedValidationResult,
+} from '../validation-types.js';
+
+export type ActivityValidationError = SharedValidationError;
+export type ActivityValidationWarning = SharedValidationWarning;
+export type ActivityValidationResult = SharedValidationResult;
+
+export interface Activity {
+  id: string;
+  name: string;
+  duration?: number;
+  duration_days?: number;
+  activity_type?: string;
+  goals?: string[];
+  scenario?: string;
+  parent?: string;
+  predecessors?: string[];
+  owner?: string;
+  unit?: string;
+  employee?: string;
+  score?: number;
+  sort?: number;
+  tags?: string[];
+  start_date?: string;
+  end_date?: string;
+  labor_cost?: number;
+  resources_cost?: number;
+  effort?: number;
+  link?: string;
+  description?: string;
+  delivers_changes?: string[];
+}
+
+export type Weekday = 'mon' | 'tue' | 'wed' | 'thu' | 'fri' | 'sat' | 'sun';
+
+export interface ProjectCalendar {
+  working_days?: Weekday[];
+  hours_per_day?: number;
+  holidays?: string[];
+}
+
+export interface ProjectBlock {
+  start_date?: string;
+  calendar?: ProjectCalendar;
+}
+
+export interface ActivityDoc {
+  notation: string;
+  spec_version?: string;
+  title?: string;
+  description?: string;
+  version?: string;
+  date?: string;
+  author?: string;
+  project?: ProjectBlock;
+  activities: Activity[];
+}
+
+export interface CpmValues {
+  es: number;
+  ef: number;
+  ls: number;
+  lf: number;
+  slack: number;
+  isCritical: boolean;
+}
+
+export type CpmResult = Map<string, CpmValues>;
+
+export interface LayoutNode {
+  id: string;
+  x: number;
+  y: number;
+  width: number;
+  height: number;
+  data: Activity;
+  cpm?: CpmValues;
+}
+
+export interface LayoutEdge {
+  sourceId: string;
+  targetId: string;
+  isCritical: boolean;
+}
+
+export interface ActivitiesLayout {
+  nodes: LayoutNode[];
+  edges: LayoutEdge[];
+  bounds: { x: number; y: number; width: number; height: number };
+}
+
+export interface ActivitiesLayoutOptions {
+  /** Horizontal gap (px) between CPM columns. Default matches the historical hardcoded value. */
+  horizontalGap?: number;
+  /** Vertical gap (px) between stacked activity nodes. Default matches the historical hardcoded value. */
+  verticalGap?: number;
+}
+
+// ── Gantt view (spec §9) ─────────────────────────────────────────────────────
+
+export type GanttMode = 'computed' | 'pinned';
+
+export type GanttBarKind = 'leaf' | 'milestone' | 'phase';
+
+export interface GanttBar {
+  id: string;
+  name: string;
+  kind: GanttBarKind;
+  /** Inclusive start date as ISO 8601 yyyy-mm-dd. */
+  startDate: string;
+  /** Inclusive end date as ISO 8601 yyyy-mm-dd. For milestones equals startDate. */
+  endDate: string;
+  /** True if the activity is on the critical path (only when CPM applies — computed mode). */
+  isCritical: boolean;
+  /** Optional parent activity id (for phase grouping). */
+  parent?: string;
+  /** Activity record. */
+  data: Activity;
+}
+
+export interface GanttLink {
+  sourceId: string;
+  targetId: string;
+  isCritical: boolean;
+}
+
+export interface GanttLayout {
+  /** Render mode that produced this layout. */
+  mode: GanttMode;
+  /** Inclusive timeline bounds as ISO 8601 yyyy-mm-dd. */
+  timelineStart: string;
+  timelineEnd: string;
+  bars: GanttBar[];
+  links: GanttLink[];
+}
+
+export interface GanttUnavailable {
+  unavailable: true;
+  /** Human-readable explanation of what is missing. */
+  reason: string;
+}
+
+export type GanttResult = GanttLayout | GanttUnavailable;