@transitrix/diagrams 1.0.0 → 1.1.0

package/src/__tests__/edge-path.test.ts

@@ -1,46 +1,58 @@
-import { describe, it, expect } from 'vitest';
-import { horizontalCubicEdgePath, EDGE_MIN_HANDLE } from '../edge-path.js';
-
-describe('horizontalCubicEdgePath', () => {
-  // A short horizontal edge: |dx|=40 < EDGE_MIN_HANDLE*2, |dy|=0, so the
-  // base handle is the floor (64).
-  const sx = 0, sy = 0, tx = 40, ty = 0;
-
-  it('curvature 1 uses the floor handle (historical appearance)', () => {
-    const d = horizontalCubicEdgePath(sx, sy, tx, ty, 1);
-    // handle = max(64, 20, 0) = 64
-    expect(d).toBe(`M0,0 C${EDGE_MIN_HANDLE},0 ${40 - EDGE_MIN_HANDLE},0 40,0`);
-  });
-
-  it('default curvature equals explicit curvature 1', () => {
-    expect(horizontalCubicEdgePath(sx, sy, tx, ty)).toBe(horizontalCubicEdgePath(sx, sy, tx, ty, 1));
-  });
-
-  it('curvature 0 collapses control points onto the endpoints (straight line)', () => {
-    const d = horizontalCubicEdgePath(sx, sy, tx, ty, 0);
-    expect(d).toBe('M0,0 C0,0 40,0 40,0');
-  });
-
-  it('changing curvature changes the path output (AC#6)', () => {
-    const a = horizontalCubicEdgePath(sx, sy, tx, ty, 1);
-    const b = horizontalCubicEdgePath(sx, sy, tx, ty, 2);
-    expect(b).not.toBe(a);
-  });
-
-  it('larger curvature pushes the control handles further out', () => {
-    const handleOf = (curv: number) => {
-      // First control point x is `sx + handle`; parse it back out.
-      const m = horizontalCubicEdgePath(0, 0, 40, 0, curv).match(/^M0,0 C(-?\d+(?:\.\d+)?),0/);
-      return Number(m![1]);
-    };
-    expect(handleOf(2)).toBeGreaterThan(handleOf(1));
-    expect(handleOf(0.5)).toBeLessThan(handleOf(1));
-    expect(handleOf(2)).toBe(2 * EDGE_MIN_HANDLE);
-  });
-
-  it('handle scales with the vertical span for stacked nodes', () => {
-    // |dy|=200 ⇒ base handle = max(64, 0, 160) = 160; ×1 = 160.
-    const d = horizontalCubicEdgePath(0, 0, 0, 200, 1);
-    expect(d).toBe('M0,0 C160,0 -160,200 0,200');
-  });
-});
+import { describe, it, expect } from 'vitest';
+import { horizontalCubicEdgePath, EDGE_MIN_HANDLE } from '../edge-path.js';
+
+describe('horizontalCubicEdgePath', () => {
+  // A short horizontal edge: |dx|=40 < EDGE_MIN_HANDLE*2, |dy|=0, so the
+  // base handle is the floor (64).
+  const sx = 0, sy = 0, tx = 40, ty = 0;
+
+  it('curvature 1 uses the floor handle (historical appearance)', () => {
+    const d = horizontalCubicEdgePath(sx, sy, tx, ty, 1);
+    // handle = max(64, 20, 0) = 64
+    expect(d).toBe(`M0,0 C${EDGE_MIN_HANDLE},0 ${40 - EDGE_MIN_HANDLE},0 40,0`);
+  });
+
+  it('default curvature equals explicit curvature 1', () => {
+    expect(horizontalCubicEdgePath(sx, sy, tx, ty)).toBe(horizontalCubicEdgePath(sx, sy, tx, ty, 1));
+  });
+
+  it('curvature 0 collapses control points onto the endpoints (straight line)', () => {
+    const d = horizontalCubicEdgePath(sx, sy, tx, ty, 0);
+    expect(d).toBe('M0,0 C0,0 40,0 40,0');
+  });
+
+  it('changing curvature changes the path output (AC#6)', () => {
+    const a = horizontalCubicEdgePath(sx, sy, tx, ty, 1);
+    const b = horizontalCubicEdgePath(sx, sy, tx, ty, 2);
+    expect(b).not.toBe(a);
+  });
+
+  it('larger curvature pushes the control handles further out', () => {
+    const handleOf = (curv: number) => {
+      // First control point x is `sx + handle`; parse it back out.
+      const m = horizontalCubicEdgePath(0, 0, 40, 0, curv).match(/^M0,0 C(-?\d+(?:\.\d+)?),0/);
+      return Number(m![1]);
+    };
+    expect(handleOf(2)).toBeGreaterThan(handleOf(1));
+    expect(handleOf(0.5)).toBeLessThan(handleOf(1));
+    expect(handleOf(2)).toBe(2 * EDGE_MIN_HANDLE);
+  });
+
+  it('handle scales with the vertical span for stacked nodes', () => {
+    // |dy|=200 ⇒ base handle = max(64, 0, 160) = 160; ×1 = 160.
+    const d = horizontalCubicEdgePath(0, 0, 0, 200, 1);
+    expect(d).toBe('M0,0 C160,0 -160,200 0,200');
+  });
+
+  it('entryCurvature independently scales the arrival handle', () => {
+    // exit handle = max(64,20,0)*1 = 64; entry handle = max(64,20,0)*2 = 128.
+    const d = horizontalCubicEdgePath(0, 0, 40, 0, 1, 2);
+    expect(d).toBe(`M0,0 C${EDGE_MIN_HANDLE},0 ${40 - EDGE_MIN_HANDLE * 2},0 40,0`);
+  });
+
+  it('omitting entryCurvature gives symmetric handles (historical behaviour)', () => {
+    expect(horizontalCubicEdgePath(0, 0, 40, 0, 0.5)).toBe(
+      horizontalCubicEdgePath(0, 0, 40, 0, 0.5, 0.5),
+    );
+  });
+});

package/src/__tests__/scope.test.ts

@@ -1,27 +1,27 @@
-import { describe, it, expect } from 'vitest';
-import { checkScopeRoot, SCOPE_MISSING_ROOT_CODE, type Scope } from '../scope.js';
-
-describe('checkScopeRoot', () => {
-  it('returns null for non-root scopes', () => {
-    expect(checkScopeRoot({ mode: 'all' }, [1, 2])).toBeNull();
-    expect(checkScopeRoot({ mode: 'level', maxLevel: 1 }, [1, 2])).toBeNull();
-  });
-
-  it('returns null when the root id is present (numeric ids compared as strings)', () => {
-    const scope: Scope = { mode: 'root', rootGoalId: '2' };
-    expect(checkScopeRoot(scope, [1, 2, 3])).toBeNull();
-  });
-
-  it('returns a SCOPE-001 warning when the root id is absent', () => {
-    const scope: Scope = { mode: 'root', rootGoalId: '99' };
-    const w = checkScopeRoot(scope, [1, 2, 3]);
-    expect(w).not.toBeNull();
-    expect(w!.code).toBe(SCOPE_MISSING_ROOT_CODE);
-    expect(w!.message).toContain('99');
-  });
-
-  it('handles string goal ids', () => {
-    expect(checkScopeRoot({ mode: 'root', rootGoalId: 'g1' }, ['g1', 'g2'])).toBeNull();
-    expect(checkScopeRoot({ mode: 'root', rootGoalId: 'gX' }, ['g1', 'g2'])).not.toBeNull();
-  });
-});
+import { describe, it, expect } from 'vitest';
+import { checkScopeRoot, SCOPE_MISSING_ROOT_CODE, type Scope } from '../scope.js';
+
+describe('checkScopeRoot', () => {
+  it('returns null for non-root scopes', () => {
+    expect(checkScopeRoot({ mode: 'all' }, [1, 2])).toBeNull();
+    expect(checkScopeRoot({ mode: 'level', maxLevel: 1 }, [1, 2])).toBeNull();
+  });
+
+  it('returns null when the root id is present (numeric ids compared as strings)', () => {
+    const scope: Scope = { mode: 'root', rootGoalId: '2' };
+    expect(checkScopeRoot(scope, [1, 2, 3])).toBeNull();
+  });
+
+  it('returns a SCOPE-001 warning when the root id is absent', () => {
+    const scope: Scope = { mode: 'root', rootGoalId: '99' };
+    const w = checkScopeRoot(scope, [1, 2, 3]);
+    expect(w).not.toBeNull();
+    expect(w!.code).toBe(SCOPE_MISSING_ROOT_CODE);
+    expect(w!.message).toContain('99');
+  });
+
+  it('handles string goal ids', () => {
+    expect(checkScopeRoot({ mode: 'root', rootGoalId: 'g1' }, ['g1', 'g2'])).toBeNull();
+    expect(checkScopeRoot({ mode: 'root', rootGoalId: 'gX' }, ['g1', 'g2'])).not.toBeNull();
+  });
+});

package/src/__tests__/yaml-normalize.test.ts

@@ -1,158 +1,158 @@
-import { describe, it, expect, beforeAll, afterAll } from 'vitest';
-import yaml from 'js-yaml';
-import { coerceDatesToIsoStrings } from '../yaml-normalize.js';
-import { validateActivities } from '../activities/index.js';
-
-describe('coerceDatesToIsoStrings', () => {
-  it('replaces top-level Date with ISO YYYY-MM-DD string', () => {
-    const out = coerceDatesToIsoStrings(new Date(Date.UTC(2026, 5, 1))); // 2026-06-01 UTC
-    expect(out).toBe('2026-06-01');
-  });
-
-  it('replaces Date values inside nested arrays of objects', () => {
-    const input = {
-      activities: [
-        { id: 'A-001', start_date: new Date(Date.UTC(2026, 5, 1)), end_date: new Date(Date.UTC(2026, 5, 5)) },
-        { id: 'A-002', start_date: '2026-06-06' },
-      ],
-    };
-    coerceDatesToIsoStrings(input);
-    expect(input.activities[0].start_date).toBe('2026-06-01');
-    expect(input.activities[0].end_date).toBe('2026-06-05');
-    expect(input.activities[1].start_date).toBe('2026-06-06');
-  });
-
-  it('walks objects recursively', () => {
-    const input = {
-      project: { start_date: new Date(Date.UTC(2026, 0, 15)) },
-    };
-    coerceDatesToIsoStrings(input);
-    expect(input.project.start_date).toBe('2026-01-15');
-  });
-
-  it('leaves non-Date values untouched', () => {
-    const input = {
-      notation: 'activities',
-      activities: [{ id: 'A-001', duration: 3, start_date: '2026-06-01' }],
-    };
-    const out = coerceDatesToIsoStrings(input);
-    expect(out).toBe(input);
-    expect(input.activities[0].start_date).toBe('2026-06-01');
-    expect(input.activities[0].duration).toBe(3);
-  });
-
-  it('handles null, undefined, and primitive scalars', () => {
-    expect(coerceDatesToIsoStrings(null)).toBe(null);
-    expect(coerceDatesToIsoStrings(undefined)).toBe(undefined);
-    expect(coerceDatesToIsoStrings('hello')).toBe('hello');
-    expect(coerceDatesToIsoStrings(42)).toBe(42);
-    expect(coerceDatesToIsoStrings(true)).toBe(true);
-  });
-
-  it('handles arrays that contain bare Date elements', () => {
-    const arr = [new Date(Date.UTC(2026, 5, 1)), 'x', { d: new Date(Date.UTC(2026, 5, 2)) }];
-    coerceDatesToIsoStrings(arr);
-    expect(arr[0]).toBe('2026-06-01');
-    expect(arr[1]).toBe('x');
-    expect((arr[2] as { d: unknown }).d).toBe('2026-06-02');
-  });
-});
-
-describe('coerceDatesToIsoStrings — js-yaml integration', () => {
-  it('quoted ISO dates are preserved untouched', () => {
-    const text = [
-      'notation: activities',
-      'activities:',
-      '  - id: "A-001"',
-      '    name: "Quoted dates"',
-      '    duration: 3',
-      '    start_date: "2026-06-01"',
-      '    end_date: "2026-06-03"',
-      '',
-    ].join('\n');
-    const parsed = yaml.load(text) as { activities: { start_date: unknown; end_date: unknown }[] };
-    coerceDatesToIsoStrings(parsed);
-    expect(parsed.activities[0].start_date).toBe('2026-06-01');
-    expect(parsed.activities[0].end_date).toBe('2026-06-03');
-    const v = validateActivities(parsed);
-    expect(v.valid).toBe(true);
-  });
-
-  it('bare ISO dates are coerced to ISO strings and pass validation', () => {
-    const text = [
-      'notation: activities',
-      'activities:',
-      '  - id: "A-001"',
-      '    name: "Bare dates"',
-      '    duration: 3',
-      '    start_date: 2026-06-01',
-      '    end_date: 2026-06-03',
-      '',
-    ].join('\n');
-    const parsed = yaml.load(text) as { activities: { start_date: unknown; end_date: unknown }[] };
-    // Without coercion, js-yaml returns Date instances and the validator
-    // would emit ACT-008 because typeof !== 'string'. Sanity-check that
-    // assumption before normalisation.
-    expect(parsed.activities[0].start_date).toBeInstanceOf(Date);
-    coerceDatesToIsoStrings(parsed);
-    expect(parsed.activities[0].start_date).toBe('2026-06-01');
-    expect(parsed.activities[0].end_date).toBe('2026-06-03');
-    const v = validateActivities(parsed);
-    expect(v.valid).toBe(true);
-  });
-});
-
-// The issue calls out the timezone trap: a Date built from a bare ISO
-// date is midnight UTC, but if we used `getFullYear / getMonth / getDate`
-// instead of the UTC variants, a non-UTC process timezone would shift the
-// day. Pin a non-UTC TZ for this block so the regression bites if anyone
-// later swaps to local-time accessors.
-describe('coerceDatesToIsoStrings — non-UTC timezone', () => {
-  const originalTz = process.env.TZ;
-  beforeAll(() => {
-    // Pacific/Auckland is UTC+12/+13 — the most aggressive eastward shift
-    // available without DST gymnastics. If local-time accessors are used,
-    // `2026-06-01` parsed as midnight UTC reads back as `2026-06-01 12:00
-    // local`, which is still the right day — so use a westward TZ for the
-    // real test below. Auckland is here as a sanity case.
-    process.env.TZ = 'Pacific/Auckland';
-  });
-  afterAll(() => {
-    if (originalTz === undefined) {
-      delete process.env.TZ;
-    } else {
-      process.env.TZ = originalTz;
-    }
-  });
-
-  it('does not drift the day forward in an eastward timezone', () => {
-    const text = 'd: 2026-06-01\n';
-    const parsed = yaml.load(text) as { d: unknown };
-    coerceDatesToIsoStrings(parsed);
-    expect(parsed.d).toBe('2026-06-01');
-  });
-});
-
-describe('coerceDatesToIsoStrings — westward (negative offset) timezone', () => {
-  const originalTz = process.env.TZ;
-  beforeAll(() => {
-    // Pacific/Honolulu is UTC-10, no DST. Midnight UTC `2026-06-01` reads
-    // back as `2026-05-31 14:00 local`. Local-time accessors would yield
-    // `2026-05-31` — wrong by one day. UTC accessors yield `2026-06-01`.
-    process.env.TZ = 'Pacific/Honolulu';
-  });
-  afterAll(() => {
-    if (originalTz === undefined) {
-      delete process.env.TZ;
-    } else {
-      process.env.TZ = originalTz;
-    }
-  });
-
-  it('does not drift the day backward in a westward timezone', () => {
-    const text = 'd: 2026-06-01\n';
-    const parsed = yaml.load(text) as { d: unknown };
-    coerceDatesToIsoStrings(parsed);
-    expect(parsed.d).toBe('2026-06-01');
-  });
-});
+import { describe, it, expect, beforeAll, afterAll } from 'vitest';
+import yaml from 'js-yaml';
+import { coerceDatesToIsoStrings } from '../yaml-normalize.js';
+import { validateActivities } from '../activities/index.js';
+
+describe('coerceDatesToIsoStrings', () => {
+  it('replaces top-level Date with ISO YYYY-MM-DD string', () => {
+    const out = coerceDatesToIsoStrings(new Date(Date.UTC(2026, 5, 1))); // 2026-06-01 UTC
+    expect(out).toBe('2026-06-01');
+  });
+
+  it('replaces Date values inside nested arrays of objects', () => {
+    const input = {
+      activities: [
+        { id: 'A-001', start_date: new Date(Date.UTC(2026, 5, 1)), end_date: new Date(Date.UTC(2026, 5, 5)) },
+        { id: 'A-002', start_date: '2026-06-06' },
+      ],
+    };
+    coerceDatesToIsoStrings(input);
+    expect(input.activities[0].start_date).toBe('2026-06-01');
+    expect(input.activities[0].end_date).toBe('2026-06-05');
+    expect(input.activities[1].start_date).toBe('2026-06-06');
+  });
+
+  it('walks objects recursively', () => {
+    const input = {
+      project: { start_date: new Date(Date.UTC(2026, 0, 15)) },
+    };
+    coerceDatesToIsoStrings(input);
+    expect(input.project.start_date).toBe('2026-01-15');
+  });
+
+  it('leaves non-Date values untouched', () => {
+    const input = {
+      notation: 'activities',
+      activities: [{ id: 'A-001', duration: 3, start_date: '2026-06-01' }],
+    };
+    const out = coerceDatesToIsoStrings(input);
+    expect(out).toBe(input);
+    expect(input.activities[0].start_date).toBe('2026-06-01');
+    expect(input.activities[0].duration).toBe(3);
+  });
+
+  it('handles null, undefined, and primitive scalars', () => {
+    expect(coerceDatesToIsoStrings(null)).toBe(null);
+    expect(coerceDatesToIsoStrings(undefined)).toBe(undefined);
+    expect(coerceDatesToIsoStrings('hello')).toBe('hello');
+    expect(coerceDatesToIsoStrings(42)).toBe(42);
+    expect(coerceDatesToIsoStrings(true)).toBe(true);
+  });
+
+  it('handles arrays that contain bare Date elements', () => {
+    const arr = [new Date(Date.UTC(2026, 5, 1)), 'x', { d: new Date(Date.UTC(2026, 5, 2)) }];
+    coerceDatesToIsoStrings(arr);
+    expect(arr[0]).toBe('2026-06-01');
+    expect(arr[1]).toBe('x');
+    expect((arr[2] as { d: unknown }).d).toBe('2026-06-02');
+  });
+});
+
+describe('coerceDatesToIsoStrings — js-yaml integration', () => {
+  it('quoted ISO dates are preserved untouched', () => {
+    const text = [
+      'notation: activities',
+      'activities:',
+      '  - id: "A-001"',
+      '    name: "Quoted dates"',
+      '    duration: 3',
+      '    start_date: "2026-06-01"',
+      '    end_date: "2026-06-03"',
+      '',
+    ].join('\n');
+    const parsed = yaml.load(text) as { activities: { start_date: unknown; end_date: unknown }[] };
+    coerceDatesToIsoStrings(parsed);
+    expect(parsed.activities[0].start_date).toBe('2026-06-01');
+    expect(parsed.activities[0].end_date).toBe('2026-06-03');
+    const v = validateActivities(parsed);
+    expect(v.valid).toBe(true);
+  });
+
+  it('bare ISO dates are coerced to ISO strings and pass validation', () => {
+    const text = [
+      'notation: activities',
+      'activities:',
+      '  - id: "A-001"',
+      '    name: "Bare dates"',
+      '    duration: 3',
+      '    start_date: 2026-06-01',
+      '    end_date: 2026-06-03',
+      '',
+    ].join('\n');
+    const parsed = yaml.load(text) as { activities: { start_date: unknown; end_date: unknown }[] };
+    // Without coercion, js-yaml returns Date instances and the validator
+    // would emit ACT-008 because typeof !== 'string'. Sanity-check that
+    // assumption before normalisation.
+    expect(parsed.activities[0].start_date).toBeInstanceOf(Date);
+    coerceDatesToIsoStrings(parsed);
+    expect(parsed.activities[0].start_date).toBe('2026-06-01');
+    expect(parsed.activities[0].end_date).toBe('2026-06-03');
+    const v = validateActivities(parsed);
+    expect(v.valid).toBe(true);
+  });
+});
+
+// The issue calls out the timezone trap: a Date built from a bare ISO
+// date is midnight UTC, but if we used `getFullYear / getMonth / getDate`
+// instead of the UTC variants, a non-UTC process timezone would shift the
+// day. Pin a non-UTC TZ for this block so the regression bites if anyone
+// later swaps to local-time accessors.
+describe('coerceDatesToIsoStrings — non-UTC timezone', () => {
+  const originalTz = process.env.TZ;
+  beforeAll(() => {
+    // Pacific/Auckland is UTC+12/+13 — the most aggressive eastward shift
+    // available without DST gymnastics. If local-time accessors are used,
+    // `2026-06-01` parsed as midnight UTC reads back as `2026-06-01 12:00
+    // local`, which is still the right day — so use a westward TZ for the
+    // real test below. Auckland is here as a sanity case.
+    process.env.TZ = 'Pacific/Auckland';
+  });
+  afterAll(() => {
+    if (originalTz === undefined) {
+      delete process.env.TZ;
+    } else {
+      process.env.TZ = originalTz;
+    }
+  });
+
+  it('does not drift the day forward in an eastward timezone', () => {
+    const text = 'd: 2026-06-01\n';
+    const parsed = yaml.load(text) as { d: unknown };
+    coerceDatesToIsoStrings(parsed);
+    expect(parsed.d).toBe('2026-06-01');
+  });
+});
+
+describe('coerceDatesToIsoStrings — westward (negative offset) timezone', () => {
+  const originalTz = process.env.TZ;
+  beforeAll(() => {
+    // Pacific/Honolulu is UTC-10, no DST. Midnight UTC `2026-06-01` reads
+    // back as `2026-05-31 14:00 local`. Local-time accessors would yield
+    // `2026-05-31` — wrong by one day. UTC accessors yield `2026-06-01`.
+    process.env.TZ = 'Pacific/Honolulu';
+  });
+  afterAll(() => {
+    if (originalTz === undefined) {
+      delete process.env.TZ;
+    } else {
+      process.env.TZ = originalTz;
+    }
+  });
+
+  it('does not drift the day backward in a westward timezone', () => {
+    const text = 'd: 2026-06-01\n';
+    const parsed = yaml.load(text) as { d: unknown };
+    coerceDatesToIsoStrings(parsed);
+    expect(parsed.d).toBe('2026-06-01');
+  });
+});