@sylix/coworker 2.0.11 → 2.0.14

package/dist/skills/defaults/systems/shellcheck-configuration/SKILL.md

@@ -0,0 +1,456 @@
+---
+name: shellcheck-configuration
+description: Master ShellCheck static analysis configuration and usage for shell script quality. Use when setting up linting infrastructure, fixing code issues, or ensuring script portability.
+---
+
+# ShellCheck Configuration and Static Analysis
+
+Comprehensive guidance for configuring and using ShellCheck to improve shell script quality, catch common pitfalls, and enforce best practices through static code analysis.
+
+## When to Use This Skill
+
+- Setting up linting for shell scripts in CI/CD pipelines
+- Analyzing existing shell scripts for issues
+- Understanding ShellCheck error codes and warnings
+- Configuring ShellCheck for specific project requirements
+- Integrating ShellCheck into development workflows
+- Suppressing false positives and configuring rule sets
+- Enforcing consistent code quality standards
+- Migrating scripts to meet quality gates
+
+## ShellCheck Fundamentals
+
+### What is ShellCheck?
+
+ShellCheck is a static analysis tool that analyzes shell scripts and detects problematic patterns. It supports:
+
+- Bash, sh, dash, ksh, and other POSIX shells
+- Over 100 different warnings and errors
+- Configuration for target shell and flags
+- Integration with editors and CI/CD systems
+
+### Installation
+
+```bash
+# macOS with Homebrew
+brew install shellcheck
+
+# Ubuntu/Debian
+apt-get install shellcheck
+
+# From source
+git clone https://github.com/koalaman/shellcheck.git
+cd shellcheck
+make build
+make install
+
+# Verify installation
+shellcheck --version
+```
+
+## Configuration Files
+
+### .shellcheckrc (Project Level)
+
+Create `.shellcheckrc` in your project root:
+
+```
+# Specify target shell
+shell=bash
+
+# Enable optional checks
+enable=avoid-nullary-conditions
+enable=require-variable-braces
+
+# Disable specific warnings
+disable=SC1091
+disable=SC2086
+```
+
+### Environment Variables
+
+```bash
+# Set default shell target
+export SHELLCHECK_SHELL=bash
+
+# Enable strict mode
+export SHELLCHECK_STRICT=true
+
+# Specify configuration file location
+export SHELLCHECK_CONFIG=~/.shellcheckrc
+```
+
+## Common ShellCheck Error Codes
+
+### SC1000-1099: Parser Errors
+
+```bash
+# SC1004: Backslash continuation not followed by newline
+echo hello\
+world  # Error - needs line continuation
+
+# SC1008: Invalid data for operator `=='
+if [[ $var =  "value" ]]; then  # Space before ==
+    true
+fi
+```
+
+### SC2000-2099: Shell Issues
+
+```bash
+# SC2009: Consider using pgrep or pidof instead of grep|grep
+ps aux | grep -v grep | grep myprocess  # Use pgrep instead
+
+# SC2012: Use `ls` only for viewing. Use `find` for reliable output
+for file in $(ls -la)  # Better: use find or globbing
+
+# SC2015: Avoid using && and || instead of if-then-else
+[[ -f "$file" ]] && echo "found" || echo "not found"  # Less clear
+
+# SC2016: Expressions don't expand in single quotes
+echo '$VAR'  # Literal $VAR, not variable expansion
+
+# SC2026: This word is non-standard. Set POSIXLY_CORRECT
+# when using with scripts for other shells
+```
+
+### SC2100-2199: Quoting Issues
+
+```bash
+# SC2086: Double quote to prevent globbing and word splitting
+for i in $list; do  # Should be: for i in $list or for i in "$list"
+    echo "$i"
+done
+
+# SC2115: Literal tilde in path not expanded. Use $HOME instead
+~/.bashrc  # In strings, use "$HOME/.bashrc"
+
+# SC2181: Check exit code directly with `if`, not indirectly in a list
+some_command
+if [ $? -eq 0 ]; then  # Better: if some_command; then
+
+# SC2206: Quote to prevent word splitting or set IFS
+array=( $items )  # Should use: array=( $items )
+```
+
+### SC3000-3999: POSIX Compliance Issues
+
+```bash
+# SC3010: In POSIX sh, use 'case' instead of 'cond && foo'
+[[ $var == "value" ]] && do_something  # Not POSIX
+
+# SC3043: In POSIX sh, use 'local' is undefined
+function my_func() {
+    local var=value  # Not POSIX in some shells
+}
+```
+
+## Practical Configuration Examples
+
+### Minimal Configuration (Strict POSIX)
+
+```bash
+#!/bin/bash
+# Configure for maximum portability
+
+shellcheck \
+  --shell=sh \
+  --external-sources \
+  --check-sourced \
+  script.sh
+```
+
+### Development Configuration (Bash with Relaxed Rules)
+
+```bash
+#!/bin/bash
+# Configure for Bash development
+
+shellcheck \
+  --shell=bash \
+  --exclude=SC1091,SC2119 \
+  --enable=all \
+  script.sh
+```
+
+### CI/CD Integration Configuration
+
+```bash
+#!/bin/bash
+set -Eeuo pipefail
+
+# Analyze all shell scripts and fail on issues
+find . -type f -name "*.sh" | while read -r script; do
+    echo "Checking: $script"
+    shellcheck \
+        --shell=bash \
+        --format=gcc \
+        --exclude=SC1091 \
+        "$script" || exit 1
+done
+```
+
+### .shellcheckrc for Project
+
+```
+# Shell dialect to analyze against
+shell=bash
+
+# Enable optional checks
+enable=avoid-nullary-conditions,require-variable-braces,check-unassigned-uppercase
+
+# Disable specific warnings
+# SC1091: Not following sourced files (many false positives)
+disable=SC1091
+
+# SC2119: Use function_name instead of function_name -- (arguments)
+disable=SC2119
+
+# External files to source for context
+external-sources=true
+```
+
+## Integration Patterns
+
+### Pre-commit Hook Configuration
+
+```bash
+#!/bin/bash
+# .git/hooks/pre-commit
+
+#!/bin/bash
+set -e
+
+# Find all shell scripts changed in this commit
+git diff --cached --name-only | grep '\.sh$' | while read -r script; do
+    echo "Linting: $script"
+
+    if ! shellcheck "$script"; then
+        echo "ShellCheck failed on $script"
+        exit 1
+    fi
+done
+```
+
+### GitHub Actions Workflow
+
+```yaml
+name: ShellCheck
+
+on: [push, pull_request]
+
+jobs:
+  shellcheck:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Run ShellCheck
+        run: |
+          sudo apt-get install shellcheck
+          find . -type f -name "*.sh" -exec shellcheck {} \;
+```
+
+### GitLab CI Pipeline
+
+```yaml
+shellcheck:
+  stage: lint
+  image: koalaman/shellcheck-alpine
+  script:
+    - find . -type f -name "*.sh" -exec shellcheck {} \;
+  allow_failure: false
+```
+
+## Handling ShellCheck Violations
+
+### Suppressing Specific Warnings
+
+```bash
+#!/bin/bash
+
+# Disable warning for entire line
+# shellcheck disable=SC2086
+for file in $(ls -la); do
+    echo "$file"
+done
+
+# Disable for entire script
+# shellcheck disable=SC1091,SC2119
+
+# Disable multiple warnings (format varies)
+command_that_fails() {
+    # shellcheck disable=SC2015
+    [ -f "$1" ] && echo "found" || echo "not found"
+}
+
+# Disable specific check for source directive
+# shellcheck source=./helper.sh
+source helper.sh
+```
+
+### Common Violations and Fixes
+
+#### SC2086: Double quote to prevent word splitting
+
+```bash
+# Problem
+for i in $list; do done
+
+# Solution
+for i in $list; do done  # If $list is already quoted, or
+for i in "${list[@]}"; do done  # If list is an array
+```
+
+#### SC2181: Check exit code directly
+
+```bash
+# Problem
+some_command
+if [ $? -eq 0 ]; then
+    echo "success"
+fi
+
+# Solution
+if some_command; then
+    echo "success"
+fi
+```
+
+#### SC2015: Use if-then instead of && ||
+
+```bash
+# Problem
+[ -f "$file" ] && echo "exists" || echo "not found"
+
+# Solution - clearer intent
+if [ -f "$file" ]; then
+    echo "exists"
+else
+    echo "not found"
+fi
+```
+
+#### SC2016: Expressions don't expand in single quotes
+
+```bash
+# Problem
+echo 'Variable value: $VAR'
+
+# Solution
+echo "Variable value: $VAR"
+```
+
+#### SC2009: Use pgrep instead of grep
+
+```bash
+# Problem
+ps aux | grep -v grep | grep myprocess
+
+# Solution
+pgrep -f myprocess
+```
+
+## Performance Optimization
+
+### Checking Multiple Files
+
+```bash
+#!/bin/bash
+
+# Sequential checking
+for script in *.sh; do
+    shellcheck "$script"
+done
+
+# Parallel checking (faster)
+find . -name "*.sh" -print0 | \
+    xargs -0 -P 4 -n 1 shellcheck
+```
+
+### Caching Results
+
+```bash
+#!/bin/bash
+
+CACHE_DIR=".shellcheck_cache"
+mkdir -p "$CACHE_DIR"
+
+check_script() {
+    local script="$1"
+    local hash
+    local cache_file
+
+    hash=$(sha256sum "$script" | cut -d' ' -f1)
+    cache_file="$CACHE_DIR/$hash"
+
+    if [[ ! -f "$cache_file" ]]; then
+        if shellcheck "$script" > "$cache_file" 2>&1; then
+            touch "$cache_file.ok"
+        else
+            return 1
+        fi
+    fi
+
+    [[ -f "$cache_file.ok" ]]
+}
+
+find . -name "*.sh" | while read -r script; do
+    check_script "$script" || exit 1
+done
+```
+
+## Output Formats
+
+### Default Format
+
+```bash
+shellcheck script.sh
+
+# Output:
+# script.sh:1:3: warning: foo is referenced but not assigned. [SC2154]
+```
+
+### GCC Format (for CI/CD)
+
+```bash
+shellcheck --format=gcc script.sh
+
+# Output:
+# script.sh:1:3: warning: foo is referenced but not assigned.
+```
+
+### JSON Format (for parsing)
+
+```bash
+shellcheck --format=json script.sh
+
+# Output:
+# [{"file": "script.sh", "line": 1, "column": 3, "level": "warning", "code": 2154, "message": "..."}]
+```
+
+### Quiet Format
+
+```bash
+shellcheck --format=quiet script.sh
+
+# Returns non-zero if issues found, no output otherwise
+```
+
+## Best Practices
+
+1. **Run ShellCheck in CI/CD** - Catch issues before merging
+2. **Configure for your target shell** - Don't analyze bash as sh
+3. **Document exclusions** - Explain why violations are suppressed
+4. **Address violations** - Don't just disable warnings
+5. **Enable strict mode** - Use `--enable=all` with careful exclusions
+6. **Update regularly** - Keep ShellCheck current for new checks
+7. **Use pre-commit hooks** - Catch issues locally before pushing
+8. **Integrate with editors** - Get real-time feedback during development
+
+## Resources
+
+- **ShellCheck GitHub**: https://github.com/koalaman/shellcheck
+- **ShellCheck Wiki**: https://www.shellcheck.net/wiki/
+- **Error Code Reference**: https://www.shellcheck.net/

package/dist/skills/defaults/team-collaboration/multi-reviewer-patterns.md

@@ -0,0 +1,126 @@
+---
+name: multi-reviewer-patterns
+description: Coordinate parallel code reviews across multiple quality dimensions with finding deduplication, severity calibration, and consolidated reporting. Use this skill when organizing multi-reviewer code reviews, calibrating finding severity, or consolidating review results.
+---
+
+# Multi-Reviewer Patterns
+
+Patterns for coordinating parallel code reviews across multiple quality dimensions, deduplicating findings, calibrating severity, and producing consolidated reports.
+
+## When to Use This Skill
+
+- Organizing a multi-dimensional code review
+- Deciding which review dimensions to assign
+- Deduplicating findings from multiple reviewers
+- Calibrating severity ratings consistently
+- Producing a consolidated review report
+
+## Review Dimension Allocation
+
+### Available Dimensions
+
+| Dimension         | Focus                                   | When to Include                             |
+| ----------------- | --------------------------------------- | ------------------------------------------- |
+| **Security**      | Vulnerabilities, auth, input validation | Always for code handling user input or auth |
+| **Performance**   | Query efficiency, memory, caching       | When changing data access or hot paths      |
+| **Architecture**  | SOLID, coupling, patterns               | For structural changes or new modules       |
+| **Testing**       | Coverage, quality, edge cases           | When adding new functionality               |
+| **Accessibility** | WCAG, ARIA, keyboard nav                | For UI/frontend changes                     |
+
+### Recommended Combinations
+
+| Scenario               | Dimensions                                   |
+| ---------------------- | -------------------------------------------- |
+| API endpoint changes   | Security, Performance, Architecture          |
+| Frontend component     | Architecture, Testing, Accessibility         |
+| Database migration     | Performance, Architecture                    |
+| Authentication changes | Security, Testing                            |
+| Full feature review    | Security, Performance, Architecture, Testing |
+
+## Finding Deduplication
+
+When multiple reviewers report issues at the same location:
+
+### Merge Rules
+
+1. **Same file:line, same issue** — Merge into one finding, credit all reviewers
+2. **Same file:line, different issues** — Keep as separate findings
+3. **Same issue, different locations** — Keep separate but cross-reference
+4. **Conflicting severity** — Use the higher severity rating
+5. **Conflicting recommendations** — Include both with reviewer attribution
+
+### Deduplication Process
+
+```
+For each finding in all reviewer reports:
+  1. Check if another finding references the same file:line
+  2. If yes, check if they describe the same issue
+  3. If same issue: merge, keeping the more detailed description
+  4. If different issue: keep both, tag as "co-located"
+  5. Use highest severity among merged findings
+```
+
+## Severity Calibration
+
+### Severity Criteria
+
+| Severity     | Impact                                        | Likelihood             | Examples                                     |
+| ------------ | --------------------------------------------- | ---------------------- | -------------------------------------------- |
+| **Critical** | Data loss, security breach, complete failure  | Certain or very likely | SQL injection, auth bypass, data corruption  |
+| **High**     | Significant functionality impact, degradation | Likely                 | Memory leak, missing validation, broken flow |
+| **Medium**   | Partial impact, workaround exists             | Possible               | N+1 query, missing edge case, unclear error  |
+| **Low**      | Minimal impact, cosmetic                      | Unlikely               | Style issue, minor optimization, naming      |
+
+### Calibration Rules
+
+- Security vulnerabilities exploitable by external users: always Critical or High
+- Performance issues in hot paths: at least Medium
+- Missing tests for critical paths: at least Medium
+- Accessibility violations for core functionality: at least Medium
+- Code style issues with no functional impact: Low
+
+## Consolidated Report Template
+
+```markdown
+## Code Review Report
+
+**Target**: {files/PR/directory}
+**Reviewers**: {dimension-1}, {dimension-2}, {dimension-3}
+**Date**: {date}
+**Files Reviewed**: {count}
+
+### Critical Findings ({count})
+
+#### [CR-001] {Title}
+
+**Location**: `{file}:{line}`
+**Dimension**: {Security/Performance/etc.}
+**Description**: {what was found}
+**Impact**: {what could happen}
+**Fix**: {recommended remediation}
+
+### High Findings ({count})
+
+...
+
+### Medium Findings ({count})
+
+...
+
+### Low Findings ({count})
+
+...
+
+### Summary
+
+| Dimension    | Critical | High  | Medium | Low   | Total  |
+| ------------ | -------- | ----- | ------ | ----- | ------ |
+| Security     | 1        | 2     | 3      | 0     | 6      |
+| Performance  | 0        | 1     | 4      | 2     | 7      |
+| Architecture | 0        | 0     | 2      | 3     | 5      |
+| **Total**    | **1**    | **3** | **9**  | **5** | **18** |
+
+### Recommendation
+
+{Overall assessment and prioritized action items}
+```