@sapui5/sap.fe.core 1.102.0 → 1.103.0

package/src/sap/fe/core/controllerextensions/editFlow/draft.ts

@@ -1,25 +1,23 @@
-import ResourceBundle from "sap/base/i18n/ResourceBundle";
+import type ResourceBundle from "sap/base/i18n/ResourceBundle";
 import Log from "sap/base/Log";
-import AppComponent from "sap/fe/core/AppComponent";
+import type AppComponent from "sap/fe/core/AppComponent";
 import CommonUtils from "sap/fe/core/CommonUtils";
 import ActivitySync from "sap/fe/core/controllerextensions/collaboration/ActivitySync";
 import messageHandling from "sap/fe/core/controllerextensions/messageHandler/messageHandling";
 import DataLossOrDraftDiscardHandler from "sap/fe/core/controls/DataLossOrDraftDiscard/DataLossOrDraftDiscardHandler";
 import EditState from "sap/fe/core/helpers/EditState";
-import { SideEffectsService } from "sap/fe/core/services/SideEffectsServiceFactory";
+import type { SideEffectsService } from "sap/fe/core/services/SideEffectsServiceFactory";
 import Button from "sap/m/Button";
 import Dialog from "sap/m/Dialog";
 import MessageBox from "sap/m/MessageBox";
 import Text from "sap/m/Text";
 import Core from "sap/ui/core/Core";
-import View from "sap/ui/core/mvc/View";
-import Context from "sap/ui/model/odata/v4/Context";
-import ODataMetaModel from "sap/ui/model/odata/v4/ODataMetaModel";
-import ResourceModel from "sap/ui/model/resource/ResourceModel";
-import { CoreEx } from "types/extension_types";
+import type View from "sap/ui/core/mvc/View";
+import type ResourceModel from "sap/ui/model/resource/ResourceModel";
+import type { CoreEx, V4Context } from "types/extension_types";
 
 export type SiblingInformation = {
-	targetContext: Context;
+	targetContext: V4Context;
 	pathMapping: { oldPath: string; newPath: string }[];
 };
 
@@ -36,18 +34,19 @@ export type SiblingInformation = {
 
 /**
  * Callback to approve or reject the creation of a draft
+ *
  * @name sap.fe.core.actions.draft.ICallback.beforeCreateDraftFromActiveDocument
  * @function
  * @static
  * @abstract
  * @param {sap.ui.model.odata.v4.Context} oContext Context of the active document for the new draft
  * @returns {(boolean|Promise)} Approval of draft creation [true|false] or Promise that resolves with the boolean value
- *
  * @private
  */
 
 /**
  * Callback after a draft was successully created
+ *
  * @name sap.fe.core.actions.draft.ICallback.afterCreateDraftFromActiveDocument
  * @function
  * @static
@@ -55,21 +54,19 @@ export type SiblingInformation = {
  * @param {sap.ui.model.odata.v4.Context} oContext Context of the new draft
  * @param {sap.ui.model.odata.v4.Context} oActiveDocumentContext Context of the active document for the new draft
  * @returns {sap.ui.model.odata.v4.Context} oActiveDocumentContext
- *
  * @private
  */
 
 /**
  * Callback to approve or reject overwriting an unsaved draft of another user
+ *
  * @name sap.fe.core.actions.draft.ICallback.whenDecisionToOverwriteDocumentIsRequired
  * @function
  * @public
  * @static
  * @abstract
- *
  * @param {sap.ui.model.odata.v4.Context} oContext Context of the active document for the new draft
  * @returns {(boolean|Promise)} Approval to overwrite unsaved draft [true|false] or Promise that resolves with the boolean value
- *
  * @ui5-restricted
  */
 /* Constants for draft operations */
@@ -97,50 +94,50 @@ enum NavigationType {
 /**
  * Determines action name for a draft operation.
  *
- * @param {sap.ui.model.odata.v4.Context} oContext The context that should be bound to the operation
- * @param {string} sOperation The operation name
- * @returns {string} The name of the draft operation
+ * @param oContext The context that should be bound to the operation
+ * @param sOperation The operation name
+ * @returns The name of the draft operation
  */
-function getActionName(oContext: any, sOperation: string) {
+function getActionName(oContext: V4Context, sOperation: string) {
 	const oModel = oContext.getModel(),
 		oMetaModel = oModel.getMetaModel(),
 		sEntitySetPath = oMetaModel.getMetaPath(oContext.getPath());
 
-	return oMetaModel.getObject(sEntitySetPath + "@com.sap.vocabularies.Common.v1.DraftRoot/" + sOperation);
+	return oMetaModel.getObject(`${sEntitySetPath}@com.sap.vocabularies.Common.v1.DraftRoot/${sOperation}`);
 }
 /**
  * Creates an operation context binding for the given context and operation.
  *
- * @param {sap.ui.model.odata.v4.Context} oContext The context that should be bound to the operation
- * @param {string} sOperation The operation (action or function import)
+ * @param oContext The context that should be bound to the operation
+ * @param sOperation The operation (action or function import)
  * @param oOptions Options to create the operation context
- * @returns {sap.ui.model.odata.v4.ODataContextBinding} The context binding of the bound operation
+ * @returns The context binding of the bound operation
  */
-function createOperation(oContext: any, sOperation: string, oOptions?: any) {
+function createOperation(oContext: V4Context, sOperation: string, oOptions?: any) {
 	const sOperationName = getActionName(oContext, sOperation);
 
-	return oContext.getModel().bindContext(sOperationName + "(...)", oContext, oOptions);
+	return oContext.getModel().bindContext(`${sOperationName}(...)`, oContext, oOptions);
 }
 /**
  * Check if optional draft prepare action exists.
  *
- * @param {sap.ui.model.odata.v4.Context} oContext The context that should be bound to the operation
- * @returns {boolean} True if a a prepare action exists
+ * @param oContext The context that should be bound to the operation
+ * @returns True if a a prepare action exists
  */
-function hasPrepareAction(oContext: any) {
+function hasPrepareAction(oContext: V4Context) {
 	return !!getActionName(oContext, draftOperations.PREPARE);
 }
 /**
  * Creates a new draft from an active document.
  *
  * @function
- * @param {sap.ui.model.odata.v4.Context} oContext Context for which the action should be performed
- * @param {boolean} bPreserveChanges If true - existing changes from another user that are not locked are preserved and an error message (http status 409) is send from the backend, otherwise false - existing changes from another user that are not locked are overwritten</li>
- * @returns {Promise.<sap.ui.model.odata.v4.Context>} Resolve function returns the context of the operation
+ * @param oContext Context for which the action should be performed
+ * @param bPreserveChanges If true - existing changes from another user that are not locked are preserved and an error message (http status 409) is send from the backend, otherwise false - existing changes from another user that are not locked are overwritten</li>
+ * @returns Resolve function returns the context of the operation
  * @private
  * @ui5-restricted
  */
-function executeDraftEditAction(oContext: any, bPreserveChanges: boolean) {
+function executeDraftEditAction(oContext: V4Context, bPreserveChanges: boolean): Promise<V4Context> {
 	if (oContext.getProperty("IsActiveEntity")) {
 		const oOptions = { $$inheritExpandSelect: true };
 		const oOperation = createOperation(oContext, draftOperations.EDIT, oOptions);
@@ -170,14 +167,14 @@ function executeDraftEditAction(oContext: any, bPreserveChanges: boolean) {
  * Activates a draft document. The draft will replace the sibling entity and will be deleted by the back end.
  *
  * @function
- * @param {sap.ui.model.odata.v4.Context} oContext Context for which the action should be performed
- * @param {object} oAppComponent The AppComponent
- * @param {string} [sGroupId] The optional batch group in which the operation is to be executed
- * @returns {Promise.<sap.ui.model.odata.v4.Context>} Resolve function returns the context of the operation
+ * @param oContext Context for which the action should be performed
+ * @param oAppComponent The AppComponent
+ * @param [sGroupId] The optional batch group in which the operation is to be executed
+ * @returns Resolve function returns the context of the operation
  * @private
  * @ui5-restricted
  */
-function executeDraftActivationAction(oContext: any, oAppComponent: AppComponent, sGroupId?: string) {
+function executeDraftActivationAction(oContext: V4Context, oAppComponent: AppComponent, sGroupId?: string): Promise<V4Context> {
 	const bHasPrepareAction = hasPrepareAction(oContext);
 
 	// According to the draft spec if the service contains a prepare action and we trigger both prepare and
@@ -202,9 +199,9 @@ function executeDraftActivationAction(oContext: any, oAppComponent: AppComponent
 				//if ACTIVATE action fails then we request either the sideEffects against PREPARE action (if annotated) or the messages as fallback:
 				function () {
 					if (bHasPrepareAction) {
-						const sActionName = getActionName(oContext, draftOperations.PREPARE),
+						const actionName = getActionName(oContext, draftOperations.PREPARE),
 							oSideEffectsService = oAppComponent.getSideEffectsService(),
-							oBindingParameters = oSideEffectsService.getODataActionSideEffects(sActionName, oContext),
+							oBindingParameters = oSideEffectsService.getODataActionSideEffects(actionName, oContext),
 							aTargetPaths = oBindingParameters && oBindingParameters.pathExpressions;
 						if (aTargetPaths && aTargetPaths.length > 0) {
 							oSideEffectsService.requestSideEffects(aTargetPaths, oContext).catch(function (oError: any) {
@@ -227,13 +224,13 @@ function executeDraftActivationAction(oContext: any, oAppComponent: AppComponent
  * Execute a preparation action.
  *
  * @function
- * @param {sap.ui.model.odata.v4.Context} oContext Context for which the action should be performed
- * @param {string} groupId The optional batch group in which we want to execute the operation
- * @returns {Promise.<sap.ui.model.odata.v4.Context>} Resolve function returns the context of the operation
+ * @param oContext Context for which the action should be performed
+ * @param groupId The optional batch group in which we want to execute the operation
+ * @returns Resolve function returns the context of the operation
  * @private
  * @ui5-restricted
  */
-function executeDraftPreparationAction(oContext: Context, groupId?: string) {
+function executeDraftPreparationAction(oContext: V4Context, groupId?: string) {
 	if (!oContext.getProperty("IsActiveEntity")) {
 		const oOperation = createOperation(oContext, draftOperations.PREPARE);
 
@@ -257,28 +254,28 @@ function executeDraftPreparationAction(oContext: Context, groupId?: string) {
  * Determines the message path for a context.
  *
  * @function
- * @param {sap.ui.model.odata.v4.Context} oContext Context for which the path shall be determined
- * @returns {string} Message path, empty if not annotated
+ * @param oContext Context for which the path shall be determined
+ * @returns Message path, empty if not annotated
  * @private
  * @ui5-restricted
  */
-function getMessagesPath(oContext: Context): string {
+function getMessagesPath(oContext: V4Context): string {
 	const oModel = oContext.getModel(),
-		oMetaModel = oModel.getMetaModel() as ODataMetaModel,
+		oMetaModel = oModel.getMetaModel(),
 		sEntitySetPath = oMetaModel.getMetaPath(oContext.getPath());
-	return oMetaModel.getObject(sEntitySetPath + "/@com.sap.vocabularies.Common.v1.Messages/$Path");
+	return oMetaModel.getObject(`${sEntitySetPath}/@com.sap.vocabularies.Common.v1.Messages/$Path`);
 }
 /**
  * Requests the messages if annotated for a given context.
  *
  * @function
- * @param {sap.ui.model.odata.v4.Context} oContext Context for which the messages shall be requested
- * @param {object} oSideEffectsService Service for the SideEffects on SAP Fiori elements
- * @returns {Promise} Promise which is resolved once messages were requested
+ * @param oContext Context for which the messages shall be requested
+ * @param oSideEffectsService Service for the SideEffects on SAP Fiori elements
+ * @returns Promise which is resolved once messages were requested
  * @private
  * @ui5-restricted
  */
-function requestMessages(oContext: any, oSideEffectsService: SideEffectsService) {
+function requestMessages(oContext: V4Context, oSideEffectsService: SideEffectsService) {
 	const sMessagesPath = getMessagesPath(oContext);
 	if (sMessagesPath) {
 		return oSideEffectsService.requestSideEffects([{ $PropertyPath: sMessagesPath }] as any, oContext);
@@ -289,12 +286,12 @@ function requestMessages(oContext: any, oSideEffectsService: SideEffectsService)
  * Executes discard of a draft function using HTTP Post.
  *
  * @function
- * @param {sap.ui.model.odata.v4.Context} oContext Context for which the action should be performed
- * @returns {Promise.<sap.ui.model.odata.v4.Context>} Resolve function returns the context of the operation
+ * @param oContext Context for which the action should be performed
+ * @returns Resolve function returns the context of the operation
  * @private
  * @ui5-restricted
  */
-function executeDraftDiscardAction(oContext: any): Promise<boolean> {
+function executeDraftDiscardAction(oContext: V4Context): Promise<boolean> {
 	if (!oContext.getProperty("IsActiveEntity")) {
 		const oDiscardOperation = createOperation(oContext, draftOperations.DISCARD);
 		const localI18nRef = (Core as CoreEx).getLibraryResourceBundle("sap.fe.core");
@@ -318,13 +315,13 @@ function executeDraftDiscardAction(oContext: any): Promise<boolean> {
  * This method creates a sibling context for a subobject page and calculates a sibling path for all intermediate paths
  * between the object page and the subobject page.
  *
- * @param {object} rootCurrentContext The context for the root of the draft
- * @param {object} rightmostCurrentContext The context of the subobject page
- * @returns {Promise} returns the siblingInformation object
+ * @param rootCurrentContext The context for the root of the draft
+ * @param rightmostCurrentContext The context of the subobject page
+ * @returns The siblingInformation object
  */
 async function computeSiblingInformation(
-	rootCurrentContext: Context,
-	rightmostCurrentContext: Context
+	rootCurrentContext: V4Context,
+	rightmostCurrentContext: V4Context
 ): Promise<SiblingInformation | undefined> {
 	if (!rightmostCurrentContext.getPath().startsWith(rootCurrentContext.getPath())) {
 		// Wrong usage !!
@@ -355,7 +352,7 @@ async function computeSiblingInformation(
 		const canonicalPathPromises = segments.map((segment) => {
 			currentPath += `/${segment}`;
 			oldPaths.unshift(currentPath);
-			const siblingContext = model.bindContext(currentPath + "/SiblingEntity").getBoundContext() as Context;
+			const siblingContext = model.bindContext(`${currentPath}/SiblingEntity`).getBoundContext();
 			return siblingContext.requestCanonicalPath();
 		});
 
@@ -377,7 +374,7 @@ async function computeSiblingInformation(
 		});
 
 		return {
-			targetContext: model.bindContext(siblingPath).getBoundContext() as Context, // Create the rightmost sibling context from its path
+			targetContext: model.bindContext(siblingPath).getBoundContext(), // Create the rightmost sibling context from its path
 			pathMapping: oldPaths.map((oldPath, index) => {
 				return {
 					oldPath,
@@ -400,15 +397,15 @@ async function computeSiblingInformation(
  * @name sap.fe.core.actions.draft#createDraftFromActiveDocument
  * @memberof sap.fe.core.actions.draft
  * @static
- * @param {sap.ui.model.odata.v4.Context} oContext Context of the active document for the new draft
- * @param {AppComponent} oAppComponent The AppComponent
- * @param {object} mParameters The parameters
- * @param {boolean} [mParameters.oView] The view
- * @param {boolean} [mParameters.bPreserveChanges] Preserve changes of an existing draft of another user
- * @param {sap.fe.core.actions.draft.ICallback.beforeCreateDraftFromActiveDocument} [mParameters.fnBeforeCreateDraftFromActiveDocument] Callback that allows veto before create request is executed
- * @param {sap.fe.core.actions.draft.ICallback.afterCreateDraftFromActiveDocument} [mParameters.fnAfterCreateDraftFromActiveDocument] Callback for postprocessiong after draft document was created
- * @param {sap.fe.core.actions.draft.ICallback.whenDecisionToOverwriteDocumentIsRequired} [mParameters.fnWhenDecisionToOverwriteDocumentIsRequired] Callback for deciding on overwriting an unsaved change by another user
- * @returns {Promise} Promise resolves with the {@link sap.ui.model.odata.v4.Context context} of the new draft document
+ * @param oContext Context of the active document for the new draft
+ * @param oAppComponent The AppComponent
+ * @param mParameters The parameters
+ * @param [mParameters.oView] The view
+ * @param [mParameters.bPreserveChanges] Preserve changes of an existing draft of another user
+ * @param [mParameters.fnBeforeCreateDraftFromActiveDocument] Callback that allows veto before create request is executed
+ * @param [mParameters.fnAfterCreateDraftFromActiveDocument] Callback for postprocessiong after draft document was created
+ * @param [mParameters.fnWhenDecisionToOverwriteDocumentIsRequired] Callback for deciding on overwriting an unsaved change by another user
+ * @returns Promise resolves with the {@link sap.ui.model.odata.v4.Context context} of the new draft document
  * @private
  * @ui5-restricted
  */
@@ -431,14 +428,14 @@ async function createDraftFromActiveDocument(
 	/**
 	 * Overwrite or reject based on fnWhenDecisionToOverwriteDocumentIsRequired.
 	 *
-	 * @param {*} bOverwrite Overwrite the change or not
-	 * @returns {Promise} Resolves with result of {@link sap.fe.core.actions#executeDraftEditAction}
+	 * @param bOverwrite Overwrite the change or not
+	 * @returns Resolves with result of {@link sap.fe.core.actions#executeDraftEditAction}
 	 */
-	function overwriteOnDemand(bOverwrite: any) {
+	function overwriteOnDemand(bOverwrite: boolean) {
 		if (bOverwrite) {
 			//Overwrite existing changes
 			const oModel = oContext.getModel();
-			const draftDataContext = oModel.bindContext(oContext.getPath() + "/DraftAdministrativeData").getBoundContext();
+			const draftDataContext = oModel.bindContext(`${oContext.getPath()}/DraftAdministrativeData`).getBoundContext();
 			let oResourceBundle: ResourceBundle;
 
 			return ((mParameters.oView.getModel("sap.fe.i18n") as ResourceModel).getResourceBundle() as Promise<ResourceBundle>)
@@ -476,7 +473,7 @@ async function createDraftFromActiveDocument(
 					}
 				});
 		}
-		return Promise.reject(new Error("Draft creation aborted for document: " + oContext.getPath()));
+		return Promise.reject(new Error(`Draft creation aborted for document: ${oContext.getPath()}`));
 	}
 
 	function showMessageBox(sUnsavedChangesMsg: any) {
@@ -499,7 +496,7 @@ async function createDraftFromActiveDocument(
 					text: localI18nRef.getText("C_COMMON_OBJECT_PAGE_CANCEL"),
 					press: function () {
 						oDialog.close();
-						reject("Draft creation aborted for document: " + oContext.getPath());
+						reject(`Draft creation aborted for document: ${oContext.getPath()}`);
 					}
 				}),
 				afterClose: function () {
@@ -520,16 +517,17 @@ async function createDraftFromActiveDocument(
 		: true;
 
 	if (!bExecute) {
-		throw new Error("Draft creation was aborted by extension for document: " + oContext.getPath());
+		throw new Error(`Draft creation was aborted by extension for document: ${oContext.getPath()}`);
 	}
 	let openingSiblingContext = false;
 	try {
-		let oDraftContext: Context | null = null;
+		let oDraftContext: V4Context | undefined;
 		try {
 			oDraftContext = await draft.executeDraftEditAction(oContext, bRunPreserveChangesFlow);
 		} catch (oResponse: any) {
 			//Only call back if error 409
 			if (bRunPreserveChangesFlow && oResponse.status === 409) {
+				messageHandling.removeBoundTransitionMessages();
 				messageHandling.removeUnboundTransitionMessages();
 				if (ActivitySync.isCollaborationEnabled(mParameters.oView)) {
 					const siblingInfo = await draft.computeSiblingInformation(oContext, oContext);
@@ -544,10 +542,8 @@ async function createDraftFromActiveDocument(
 						mParam.fnWhenDecisionToOverwriteDocumentIsRequired ? mParam.fnWhenDecisionToOverwriteDocumentIsRequired() : true
 					);
 				}
-			} else {
-				if (!(oResponse && oResponse.canceled)) {
-					throw new Error(oResponse);
-				}
+			} else if (!(oResponse && oResponse.canceled)) {
+				throw new Error(oResponse);
 			}
 		}
 		if (openingSiblingContext) {
@@ -583,17 +579,17 @@ async function createDraftFromActiveDocument(
  * @name sap.fe.core.actions.draft#activateDocument
  * @memberof sap.fe.core.actions.draft
  * @static
- * @param {sap.ui.model.odata.v4.Context} oContext Context of the active document for the new draft
- * @param {object} oAppComponent The AppComponent
- * @param {object} mParameters The parameters
- * @param {sap.fe.core.actions.draft.ICallback.fnBeforeActivateDocument} [mParameters.fnBeforeActivateDocument] Callback that allows veto before create request is executed
- * @param {sap.fe.core.actions.draft.ICallback.fnAfterActivateDocument} [mParameters.fnAfterActivateDocument] Callback for postprocessiong after document was activated.
- * @returns {Promise} Promise resolves with the {@link sap.ui.model.odata.v4.Context context} of the new draft document
+ * @param oContext Context of the active document for the new draft
+ * @param oAppComponent The AppComponent
+ * @param mParameters The parameters
+ * @param [mParameters.fnBeforeActivateDocument] Callback that allows veto before create request is executed
+ * @param [mParameters.fnAfterActivateDocument] Callback for postprocessiong after document was activated.
+ * @returns Promise resolves with the {@link sap.ui.model.odata.v4.Context context} of the new draft document
  * @private
  * @ui5-restricted
  */
 function activateDocument(
-	oContext: any,
+	oContext: V4Context,
 	oAppComponent: AppComponent,
 	mParameters: { fnBeforeActivateDocument?: any; fnAfterActivateDocument?: any }
 ) {
@@ -605,7 +601,7 @@ function activateDocument(
 	return Promise.resolve(mParam.fnBeforeActivateDocument ? mParam.fnBeforeActivateDocument(oContext) : true)
 		.then(function (bExecute: any) {
 			if (!bExecute) {
-				return Promise.reject(new Error("Activation of the document was aborted by extension for document: " + oContext.getPath()));
+				return Promise.reject(new Error(`Activation of the document was aborted by extension for document: ${oContext.getPath()}`));
 			}
 
 			if (!hasPrepareAction(oContext)) {
@@ -645,12 +641,12 @@ function activateDocument(
  * @name sap.fe.core.actions.draft#deleteDraft
  * @memberof sap.fe.core.actions.draft
  * @static
- * @param {sap.ui.model.odata.v4.Context} oContext Context of the document to be discarded
+ * @param oContext Context of the document to be discarded
  * @private
- * @returns {Promise}
+ * @returns A Promise resolved when the context is deleted
  * @ui5-restricted
  */
-function deleteDraft(oContext: any): Promise<boolean> {
+function deleteDraft(oContext: V4Context): Promise<boolean> {
 	const sDiscardAction = getActionName(oContext, draftOperations.DISCARD),
 		bIsActiveEntity = oContext.getObject().IsActiveEntity;
 
@@ -692,7 +688,7 @@ function processDataLossOrDraftDiscardConfirmation(
 	navigationType: NavigationType = NavigationType.BackNavigation
 ) {
 	const oModel = oContext.getModel();
-	const draftDataContext = oModel.bindContext(oContext.getPath() + "/DraftAdministrativeData").getBoundContext();
+	const draftDataContext = oModel.bindContext(`${oContext.getPath()}/DraftAdministrativeData`).getBoundContext();
 
 	const collaborationConnected = ActivitySync.isConnected(oController.getView());
 	const processFunctionForDrafts = !collaborationConnected
@@ -727,74 +723,68 @@ function processDataLossOrDraftDiscardConfirmation(
 						} else {
 							processFunctionForDrafts();
 						}
-					} else {
-						if (!oContext.getObject().HasActiveEntity) {
-							// There is no active entity so we are editing either newly created data or
-							// a draft which has never been saved to active version
-							// Since we want to react differently in the two situations, we have to check the
-							// dirty state
-							if (EditState.isEditStateDirty()) {
-								// In this case data is being newly created and then we always want to
-								// show the dataloss dialog on navigation
-								DataLossOrDraftDiscardHandler.performAfterDiscardorKeepDraft(
-									processFunctionForDrafts,
-									fnCancelFunction,
-									oController,
-									bSkipBindingToView
-								);
-							} else {
-								// We are editing a draft which has been created earlier but never saved to active
-								// version and since the edit state is not dirty, there have been no user changes
-								// so in this case we want to silently navigate and do nothing
-								processFunctionForDrafts();
-							}
+					} else if (!oContext.getObject().HasActiveEntity) {
+						// There is no active entity so we are editing either newly created data or
+						// a draft which has never been saved to active version
+						// Since we want to react differently in the two situations, we have to check the
+						// dirty state
+						if (EditState.isEditStateDirty()) {
+							// In this case data is being newly created and then we always want to
+							// show the dataloss dialog on navigation
+							DataLossOrDraftDiscardHandler.performAfterDiscardorKeepDraft(
+								processFunctionForDrafts,
+								fnCancelFunction,
+								oController,
+								bSkipBindingToView
+							);
 						} else {
-							// We are editing a draft for an existing active entity
-							if (draftAdminData.CreationDateTime === draftAdminData.LastChangeDateTime) {
-								// The CreationDateTime and LastChangeDateTime are equal, so this draft was
-								// never saved before, hence we're currently editing a newly created draft for
-								// an existing active entity for the first time.
-								// Also there have so far been no changes made to the draft and in this
-								// case we want to silently navigate and delete the draft in case of a back
-								// navigation but in case of a forward navigation we want to silently keep it!
-								if (navigationType === NavigationType.BackNavigation) {
-									const mParameters = {
-										skipDiscardPopover: true
-									};
-									oController.editFlow
-										.cancelDocument(oContext, mParameters)
-										.then(() => {
-											processFunctionForDrafts();
-										})
-										.catch((error: any) => {
-											Log.error("Error while canceling the document", error);
-										});
-								} else {
-									// In case of a forward navigation we silently keep the draft and only
-									// execute the followup function.
-									processFunctionForDrafts();
-								}
-							} else {
-								// The CreationDateTime and LastChangeDateTime are NOT equal, so we are currently editing
-								// an existing draft and need to distinguish depending on if any changes
-								// have been made in the current editing session or not
-								if (EditState.isEditStateDirty()) {
-									// Changes have been made in the current editing session so we want
-									// to show the dataloss dialog and let the user decide
-									DataLossOrDraftDiscardHandler.performAfterDiscardorKeepDraft(
-										processFunctionForDrafts,
-										fnCancelFunction,
-										oController,
-										bSkipBindingToView
-									);
-								} else {
-									// The user started editing the existing draft but did not make any changes
-									// in the current editing session, so in this case we do not want
-									// to show the dataloss dialog but just keep the draft
+							// We are editing a draft which has been created earlier but never saved to active
+							// version and since the edit state is not dirty, there have been no user changes
+							// so in this case we want to silently navigate and do nothing
+							processFunctionForDrafts();
+						}
+					} else if (draftAdminData.CreationDateTime === draftAdminData.LastChangeDateTime) {
+						// We are editing a draft for an existing active entity
+						// The CreationDateTime and LastChangeDateTime are equal, so this draft was
+						// never saved before, hence we're currently editing a newly created draft for
+						// an existing active entity for the first time.
+						// Also there have so far been no changes made to the draft and in this
+						// case we want to silently navigate and delete the draftin case of a back
+						// navigation but in case of a forward navigation we want to silently keep it!
+						if (navigationType === NavigationType.BackNavigation) {
+							const mParameters = {
+								skipDiscardPopover: true
+							};
+							oController.editFlow
+								.cancelDocument(oContext, mParameters)
+								.then(() => {
 									processFunctionForDrafts();
-								}
-							}
+								})
+								.catch((error: any) => {
+									Log.error("Error while canceling the document", error);
+								});
+						} else {
+							// In case of a forward navigation we silently keep the draft and only
+							// execute the followup function.
+							processFunctionForDrafts();
 						}
+					} else if (EditState.isEditStateDirty()) {
+						// The CreationDateTime and LastChangeDateTime are NOT equal, so we are currently editing
+						// an existing draft and need to distinguish depending on if any changes
+						// have been made in the current editing session or not
+						// Changes have been made in the current editing session so we want
+						// to show the dataloss dialog and let the user decide
+						DataLossOrDraftDiscardHandler.performAfterDiscardorKeepDraft(
+							processFunctionForDrafts,
+							fnCancelFunction,
+							oController,
+							bSkipBindingToView
+						);
+					} else {
+						// The user started editing the existing draft but did not make any changes
+						// in the current editing session, so in this case we do not want
+						// to show the dataloss dialog but just keep the draft
+						processFunctionForDrafts();
 					}
 				} else {
 					fnProcessFunction();