@principles/pd-cli 1.152.12 → 1.152.14

package/tests/commands/plugin-config-resolution-cutover.test.ts

@@ -1,229 +0,0 @@
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import * as fs from 'fs';
-import * as path from 'path';
-import * as os from 'os';
-
-// Mock discoverWorkspaceDefault to prevent real config discovery from interfering
-vi.mock('../../src/services/pd-config-loader.js', async (importOriginal) => {
-  const actual = await importOriginal() as Record<string, unknown>;
-  return {
-    ...actual,
-    discoverWorkspaceDefault: vi.fn().mockReturnValue(null),
-  };
-});
-
-import {
-  resolveRuntimeConfig,
-  isRuntimeConfigError,
-  validateRuntimeConfig,
-  invalidatePainSignalBridge,
-  createPainSignalBridge,
-} from '@principles/core/runtime-v2';
-
-const stubLedger = {
-  readPrincipleSubtree: () => undefined,
-  writePrinciple: () => ({ id: 'test' }) as never,
-  updatePrincipleValueMetrics: () => ({ principleId: 'test' }) as never,
-};
-
-describe('PRI-228: PD-owned config resolution cutover', () => {
-  describe('PD-owned config consumed by runtime entrypoint', () => {
-    let tmpDir: string;
-    let stateDir: string;
-
-    beforeEach(() => {
-      tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pd-pri228-'));
-      stateDir = path.join(tmpDir, '.state');
-      fs.mkdirSync(stateDir, { recursive: true });
-    });
-
-    afterEach(() => {
-      try { fs.rmSync(tmpDir, { recursive: true, force: true }); } catch {}
-    });
-
-    it('resolveRuntimeConfig with explicit workspaceDir resolves pi-ai default', () => {
-      const result = resolveRuntimeConfig(stateDir);
-      expect(isRuntimeConfigError(result)).toBe(false);
-      if (!isRuntimeConfigError(result)) {
-        expect(result.runtimeKind).toBe('pi-ai');
-        expect(result.timeoutMs).toBeGreaterThan(0);
-        expect(result.agentId).toBe('main');
-      }
-    });
-
-    it('resolveRuntimeConfig with openclaw-cli requires explicit openclawMode', () => {
-      const result = resolveRuntimeConfig(stateDir, { requestedRuntimeKind: 'openclaw-cli' });
-      expect(isRuntimeConfigError(result)).toBe(true);
-      if (isRuntimeConfigError(result)) {
-        expect(result.reason).toBe('missing_openclaw_mode');
-        expect(result.nextAction).toBeTruthy();
-      }
-    });
-
-    it('resolveRuntimeConfig with openclaw-cli + openclawLocal resolves correctly', () => {
-      const result = resolveRuntimeConfig(stateDir, {
-        requestedRuntimeKind: 'openclaw-cli',
-        openclawLocal: true,
-      });
-      expect(isRuntimeConfigError(result)).toBe(false);
-      if (!isRuntimeConfigError(result)) {
-        expect(result.runtimeKind).toBe('openclaw-cli');
-        expect(result.openclawMode).toBe('local');
-      }
-    });
-
-    it('resolveRuntimeConfig does not derive config from idle/night state', () => {
-      const result = resolveRuntimeConfig(stateDir);
-      expect(isRuntimeConfigError(result)).toBe(false);
-      if (!isRuntimeConfigError(result)) {
-        expect(Object.keys(result)).not.toContain('idleThreshold');
-        expect(Object.keys(result)).not.toContain('triggerMode');
-        expect(Object.keys(result)).not.toContain('sleepReflection');
-      }
-    });
-  });
-
-  describe('Missing explicit config fails loud', () => {
-    let tmpDir: string;
-    let stateDir: string;
-
-    beforeEach(() => {
-      tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pd-pri228-fail-'));
-      stateDir = path.join(tmpDir, '.state');
-      fs.mkdirSync(stateDir, { recursive: true });
-    });
-
-    afterEach(() => {
-      try { fs.rmSync(tmpDir, { recursive: true, force: true }); } catch {}
-    });
-
-    it('runtime=config without policy returns explicit_config_missing error', () => {
-      const result = resolveRuntimeConfig(stateDir, { requestedRuntimeKind: 'config' });
-      expect(isRuntimeConfigError(result)).toBe(true);
-      if (isRuntimeConfigError(result)) {
-        expect(result.reason).toBe('explicit_config_missing');
-        expect(result.nextAction).toBeTruthy();
-      }
-    });
-
-    it('error result serializes to single parseable JSON with nextAction', () => {
-      const result = resolveRuntimeConfig(stateDir, { requestedRuntimeKind: 'config' });
-      expect(isRuntimeConfigError(result)).toBe(true);
-      if (isRuntimeConfigError(result)) {
-        const json = JSON.stringify(result);
-        const parsed = JSON.parse(json);
-        expect(parsed.ok).toBe(false);
-        expect(parsed.reason).toBeTruthy();
-        expect(parsed.message).toBeTruthy();
-        expect(parsed.nextAction).toBeTruthy();
-      }
-    });
-
-    it('conflicting openclaw mode returns error with nextAction', () => {
-      const result = resolveRuntimeConfig(stateDir, {
-        requestedRuntimeKind: 'openclaw-cli',
-        openclawLocal: true,
-        openclawGateway: true,
-      });
-      expect(isRuntimeConfigError(result)).toBe(true);
-      if (isRuntimeConfigError(result)) {
-        expect(result.reason).toBe('conflicting_openclaw_mode');
-        expect(result.nextAction).toBeTruthy();
-      }
-    });
-
-    it('validateRuntimeConfig throws for openclaw-cli without mode', () => {
-      const config = {
-        runtimeKind: 'openclaw-cli' as const,
-        timeoutMs: 300_000,
-        agentId: 'main',
-      };
-      expect(() => validateRuntimeConfig(config)).not.toThrow();
-    });
-  });
-
-  describe('Cache isolation between runtime modes', () => {
-    const testWsDir = '/test-pri228-cache-isolation';
-    const testStateDir = path.join(testWsDir, '.state');
-
-    beforeEach(() => {
-      invalidatePainSignalBridge(testWsDir);
-    });
-
-    afterEach(() => {
-      invalidatePainSignalBridge(testWsDir);
-    });
-
-    it.skip('pi-ai and openclaw-cli produce different bridge instances', async () => {
-      const piAiConfig = resolveRuntimeConfig(testStateDir);
-      if (isRuntimeConfigError(piAiConfig)) {
-        expect.unreachable('pi-ai config should resolve');
-        return;
-      }
-      const bridge1 = await createPainSignalBridge({
-        workspaceDir: testWsDir,
-        stateDir: testStateDir,
-        ledgerAdapter: stubLedger,
-      });
-      expect(bridge1).toBeDefined();
-
-      const openclawConfig = resolveRuntimeConfig(testStateDir, {
-        requestedRuntimeKind: 'openclaw-cli',
-        openclawLocal: true,
-      });
-      if (isRuntimeConfigError(openclawConfig)) {
-        expect.unreachable('openclaw-cli config should resolve');
-        return;
-      }
-      const bridge2 = await createPainSignalBridge({
-        workspaceDir: testWsDir,
-        stateDir: testStateDir,
-        ledgerAdapter: stubLedger,
-      });
-      expect(bridge2).toBeDefined();
-      expect(bridge1).not.toBe(bridge2);
-    });
-
-    it.skip('invalidatePainSignalBridge with workspace-only clears all modes', async () => {
-      const piAiConfig = resolveRuntimeConfig(testStateDir);
-      if (isRuntimeConfigError(piAiConfig)) return;
-      await createPainSignalBridge({
-        workspaceDir: testWsDir,
-        stateDir: testStateDir,
-        ledgerAdapter: stubLedger,
-      });
-      invalidatePainSignalBridge(testWsDir);
-      const bridgeAfter = await createPainSignalBridge({
-        workspaceDir: testWsDir,
-        stateDir: testStateDir,
-        ledgerAdapter: stubLedger,
-      });
-      expect(bridgeAfter).toBeDefined();
-    });
-  });
-
-  describe('CLI resolveWorkspaceDir gate', () => {
-    it('resolveWorkspaceDir throws when no workspace provided', async () => {
-      const mod = await import('../../src/resolve-workspace.js');
-      delete process.env.PD_WORKSPACE_DIR;
-      expect(() => mod.resolveWorkspaceDir()).toThrow(/No workspace directory configured/);
-    });
-
-    it('resolveWorkspaceDir uses explicit workspace when provided', async () => {
-      const mod = await import('../../src/resolve-workspace.js');
-      const result = mod.resolveWorkspaceDir('/explicit/workspace');
-      expect(result).toBe('/explicit/workspace');
-    });
-
-    it('resolveWorkspaceDir uses PD_WORKSPACE_DIR env when no explicit', async () => {
-      const mod = await import('../../src/resolve-workspace.js');
-      process.env.PD_WORKSPACE_DIR = '/env/workspace';
-      try {
-        const result = mod.resolveWorkspaceDir();
-        expect(result).toBe('/env/workspace');
-      } finally {
-        delete process.env.PD_WORKSPACE_DIR;
-      }
-    });
-  });
-});

package/tests/commands/pri-393-runtime-config-unification.test.ts

@@ -1,443 +0,0 @@
-/**
- * PRI-393: Runtime config unification tests
- *
- * Validates that all MVP mainline execution paths (probe, run-once, diagnose,
- * pain-retry) read from .pd/config.yaml, NOT from .state/workflows.yaml.
- *
- * ERR refs:
- * - EP-02: production path wiring — tests exercise real production entry points
- * - EP-03: fail loud — no silent fallback
- * - EP-07: runtime state source alignment — doctor/probe/run-once agree
- * - EP-09: test reality gap — production schema fixtures
- */
-
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import * as fs from 'node:fs';
-import * as path from 'node:path';
-import * as os from 'node:os';
-import * as yaml from 'js-yaml';
-import {
-  assertMainlineContract,
-  type MainlineSnapshot,
-} from '@principles/core/runtime-v2';
-
-// ── Helpers ────────────────────────────────────────────────────────────────
-
-function mkTmpDir(prefix = 'pri-393-'): string {
-  return fs.mkdtempSync(path.join(os.tmpdir(), prefix));
-}
-
-function rmTmpDir(dir: string): void {
-  try { fs.rmSync(dir, { recursive: true, force: true }); } catch { /* ignore */ }
-}
-
-function writeConfigYaml(workspaceDir: string, content: object): void {
-  const pdDir = path.join(workspaceDir, '.pd');
-  fs.mkdirSync(pdDir, { recursive: true });
-  fs.writeFileSync(
-    path.join(pdDir, 'config.yaml'),
-    yaml.dump(content, { lineWidth: -1 }),
-    'utf8',
-  );
-}
-
-function writeLegacyWorkflowsYaml(workspaceDir: string, content: string): void {
-  const stateDir = path.join(workspaceDir, '.state');
-  fs.mkdirSync(stateDir, { recursive: true });
-  fs.writeFileSync(path.join(stateDir, 'workflows.yaml'), content, 'utf8');
-}
-
-/** Minimal valid .pd/config.yaml with a pi-ai runtime profile for diagnostician. */
-function makeValidConfigYaml(overrides?: { provider?: string; model?: string }): object {
-  return {
-    version: 1,
-    features: {
-      prompt: { enabled: true, category: 'core' },
-      correction_observer: { enabled: false, category: 'quiet' },
-    },
-    runtimeProfiles: {
-      lmstudio: {
-        type: 'pi-ai',
-        provider: overrides?.provider ?? 'lmstudio',
-        model: overrides?.model ?? 'local-model',
-        apiKeyEnv: 'LMSTUDIO_API_KEY',
-        baseUrl: 'http://localhost:1234/v1',
-      },
-    },
-    internalAgents: {
-      defaultRuntime: 'lmstudio',
-      agents: {
-        diagnostician: {
-          enabled: true,
-          runtimeProfile: 'lmstudio',
-        },
-      },
-    },
-  };
-}
-
-// ── Tests ──────────────────────────────────────────────────────────────────
-
-describe('PRI-393: runtime config unification', () => {
-  let tmpDir: string;
-
-  beforeEach(() => {
-    tmpDir = mkTmpDir();
-  });
-
-  afterEach(() => {
-    rmTmpDir(tmpDir);
-  });
-
-  describe('Guard: legacy resolveRuntimeConfig not imported by production commands', () => {
-    it('production command source files do NOT import legacy resolveRuntimeConfig', () => {
-      // Read the source of each production command and verify the import
-      const commandFiles = [
-        'packages/pd-cli/src/commands/runtime.ts',
-        'packages/pd-cli/src/commands/runtime-internalization-run-once.ts',
-        'packages/pd-cli/src/commands/diagnose.ts',
-        'packages/pd-cli/src/commands/pain-retry.ts',
-      ];
-
-      for (const file of commandFiles) {
-        // CWE-22: resolve against the repo root (this test file lives at
-        // packages/pd-cli/tests/commands/) and refuse paths that escape it.
-        const repoRoot = path.resolve(__dirname, '../../..');
-        const fullPath = path.resolve(repoRoot, file);
-        if (!fullPath.startsWith(repoRoot + path.sep)) continue;
-        if (!fs.existsSync(fullPath)) continue;
-        const source = fs.readFileSync(fullPath, 'utf8');
-
-        // Check that resolveRuntimeConfig is NOT imported from @principles/core/runtime-v2
-        // (it may appear in comments or as resolveRuntimeConfigFromPdConfig)
-        // Match the full import block (handles multi-line imports)
-        const importPattern = /import\s*[\s\S]*?@principles\/core\/runtime-v2['";]/g;
-        const importBlocks: string[] = [];
-        let match;
-        while ((match = importPattern.exec(source)) !== null) {
-          importBlocks.push(match[0]);
-        }
-
-        for (const block of importBlocks) {
-          // Allow the canonical resolver family — resolveRuntimeConfigFromPdConfig
-          // (shared diagnostician binding) and resolveRuntimeConfigForAgent (the
-          // PRI-719 per-agent variant) — but NOT bare legacy resolveRuntimeConfig
-          if (block.includes('resolveRuntimeConfig') && !block.includes('resolveRuntimeConfigFromPdConfig') && !block.includes('resolveRuntimeConfigForAgent')) {
-            // This is the legacy import — fail
-            expect.fail(
-              `${file} still imports legacy resolveRuntimeConfig from @principles/core/runtime-v2. ` +
-              `Use resolveRuntimeFromPdConfig() from services/resolve-runtime-from-pd-config.ts instead.`,
-            );
-          }
-        }
-      }
-    });
-  });
-
-  describe('Config source alignment via mainline contract', () => {
-    function makeBaseSnapshot(readiness: Partial<MainlineSnapshot['readiness']>): MainlineSnapshot {
-      return {
-        readiness: {
-          configDoctorProfile: null,
-          runtimeProbeProfile: null,
-          configSource: '.pd/config.yaml',
-          probeConfigSource: '.pd/config.yaml',
-          diagnosticianReady: true,
-          ...readiness,
-        },
-        chain: {
-          painId: null,
-          diagnosisTask: null,
-          diagnosticianArtifact: null,
-          candidate: null,
-          dreamerTask: null,
-          dreamerContext: null,
-          successor: null,
-          principle: null,
-        },
-      };
-    }
-
-    it('violation: doctor and probe use different config sources (drift)', () => {
-      const snapshot = makeBaseSnapshot({
-        configDoctorProfile: 'pi-ai.lmstudio',
-        runtimeProbeProfile: 'pi-ai.sensenova-cn',
-        configSource: '.pd/config.yaml',
-        probeConfigSource: '.state/workflows.yaml',
-      });
-
-      const verdict = assertMainlineContract(snapshot);
-      const alignmentStage = verdict.stages.find((s) => s.stage === 'config_source_alignment');
-
-      expect(alignmentStage).toBeDefined();
-      expect(alignmentStage!.status).toBe('violation');
-      expect(alignmentStage!.reason).toContain('drift');
-      expect(alignmentStage!.nextAction).toContain('.pd/config.yaml');
-    });
-
-    it('violation: profiles match but probe reads from workflows.yaml (coincidental)', () => {
-      const snapshot = makeBaseSnapshot({
-        configDoctorProfile: 'pi-ai.lmstudio',
-        runtimeProbeProfile: 'pi-ai.lmstudio',
-        configSource: '.pd/config.yaml',
-        probeConfigSource: '.state/workflows.yaml',
-      });
-
-      const verdict = assertMainlineContract(snapshot);
-      const alignmentStage = verdict.stages.find((s) => s.stage === 'config_source_alignment');
-
-      expect(alignmentStage).toBeDefined();
-      expect(alignmentStage!.status).toBe('violation');
-      expect(alignmentStage!.reason).toContain('coincidental');
-    });
-
-    it('ok: doctor and probe agree on same profile from .pd/config.yaml', () => {
-      const snapshot = makeBaseSnapshot({
-        configDoctorProfile: 'pi-ai.lmstudio',
-        runtimeProbeProfile: 'pi-ai.lmstudio',
-        configSource: '.pd/config.yaml',
-        probeConfigSource: '.pd/config.yaml',
-      });
-
-      const verdict = assertMainlineContract(snapshot);
-      const alignmentStage = verdict.stages.find((s) => s.stage === 'config_source_alignment');
-
-      expect(alignmentStage).toBeDefined();
-      expect(alignmentStage!.status).toBe('ok');
-      expect(alignmentStage!.reason).toContain('.pd/config.yaml');
-    });
-  });
-
-  describe('resolveRuntimeFromPdConfig reads .pd/config.yaml', () => {
-    it('resolves pi-ai config from .pd/config.yaml', async () => {
-      writeConfigYaml(tmpDir, makeValidConfigYaml());
-
-      // Dynamically import to avoid module resolution issues
-      const { resolveRuntimeFromPdConfig } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const resolved = resolveRuntimeFromPdConfig(tmpDir, { getEnvVar: () => 'test-key' });
-
-      expect(resolved.configSource).toBe('.pd/config.yaml');
-      expect(resolved.result).toBeDefined();
-      // Should not be an error when config is valid
-      const { isRuntimeConfigError: isErr } = await import('@principles/core/runtime-v2');
-      expect(isErr(resolved.result)).toBe(false);
-    });
-
-    it('ignores conflicting .state/workflows.yaml when .pd/config.yaml exists', async () => {
-      // Write .pd/config.yaml with lmstudio
-      writeConfigYaml(tmpDir, makeValidConfigYaml({ provider: 'lmstudio', model: 'local-model' }));
-
-      // Write conflicting .state/workflows.yaml
-      writeLegacyWorkflowsYaml(tmpDir, `version: '1'
-funnels:
-  - workflowId: pd-runtime-v2-diagnosis
-    stages: []
-    policy:
-      runtimeKind: pi-ai
-      provider: sensenova-cn
-      model: deepseek-v4-flash
-      apiKeyEnv: SENSENOVA_API_KEY
-`);
-
-      const { resolveRuntimeFromPdConfig } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const resolved = resolveRuntimeFromPdConfig(tmpDir, { getEnvVar: () => 'test-key' });
-
-      // Should have legacy warning
-      expect(resolved.legacyWarnings.length).toBeGreaterThan(0);
-      expect(resolved.legacyWarnings[0]).toContain('workflows.yaml');
-
-      // Should resolve from .pd/config.yaml, NOT workflows.yaml
-      const { isRuntimeConfigError: isErr } = await import('@principles/core/runtime-v2');
-      if (!isErr(resolved.result)) {
-        expect(resolved.result.provider).not.toBe('sensenova-cn');
-      }
-      expect(resolved.configSource).toBe('.pd/config.yaml');
-    });
-
-    it('fail loud when .pd/config.yaml is malformed', async () => {
-      const pdDir = path.join(tmpDir, '.pd');
-      fs.mkdirSync(pdDir, { recursive: true });
-      fs.writeFileSync(path.join(pdDir, 'config.yaml'), 'version: [unterminated', 'utf8');
-
-      const { resolveRuntimeFromPdConfig } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const { isRuntimeConfigError: isErr } = await import('@principles/core/runtime-v2');
-      const resolved = resolveRuntimeFromPdConfig(tmpDir, { getEnvVar: () => 'test-key' });
-
-      // Malformed config must produce a RuntimeConfigError — never fall back to defaults
-      expect(resolved.configLoadResult.ok).toBe(false);
-      expect(resolved.configSource).toBe('.pd/config.yaml');
-      expect(isErr(resolved.result)).toBe(true);
-      if (isErr(resolved.result)) {
-        expect(resolved.result.reason).toContain('config_malformed');
-        expect(resolved.result.nextAction).toBeTruthy();
-      }
-    });
-  });
-
-  describe('JSON output purity', () => {
-    it('resolveRuntimeFromPdConfig result serializes to valid JSON', async () => {
-      writeConfigYaml(tmpDir, makeValidConfigYaml());
-
-      const { resolveRuntimeFromPdConfig } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const resolved = resolveRuntimeFromPdConfig(tmpDir, { getEnvVar: () => 'test-key' });
-
-      const jsonStr = JSON.stringify(resolved.result);
-      const parsed = JSON.parse(jsonStr);
-      expect(parsed).toBeDefined();
-      expect(typeof parsed).toBe('object');
-    });
-  });
-
-  // ── Boundary Condition Tests ────────────────────────────────────────────────
-
-  describe('resolveRuntimeWithOverrides', () => {
-    it('CLI overrides take precedence over config values', async () => {
-      writeConfigYaml(tmpDir, makeValidConfigYaml({ provider: 'lmstudio', model: 'local-model' }));
-
-      const { resolveRuntimeWithOverrides } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const resolved = resolveRuntimeWithOverrides(tmpDir, {
-        provider: 'override-provider',
-        model: 'override-model',
-      }, () => 'test-key');
-
-      expect(resolved.mergedConfig).not.toBeNull();
-      if (resolved.mergedConfig) {
-        expect(resolved.mergedConfig.provider).toBe('override-provider');
-        expect(resolved.mergedConfig.model).toBe('override-model');
-      }
-    });
-
-    it('returns mergedConfig=null when base config is malformed', async () => {
-      const pdDir = path.join(tmpDir, '.pd');
-      fs.mkdirSync(pdDir, { recursive: true });
-      fs.writeFileSync(path.join(pdDir, 'config.yaml'), 'version: [invalid', 'utf8');
-
-      const { resolveRuntimeWithOverrides } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const resolved = resolveRuntimeWithOverrides(tmpDir, {
-        provider: 'override',
-      }, () => 'test-key');
-
-      expect(resolved.mergedConfig).toBeNull();
-    });
-
-    it('preserves config values when overrides are undefined', async () => {
-      writeConfigYaml(tmpDir, makeValidConfigYaml({ provider: 'lmstudio', model: 'local-model' }));
-
-      const { resolveRuntimeWithOverrides } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const resolved = resolveRuntimeWithOverrides(tmpDir, {
-        provider: undefined,
-        model: undefined,
-      }, () => 'test-key');
-
-      expect(resolved.mergedConfig).not.toBeNull();
-      if (resolved.mergedConfig) {
-        expect(resolved.mergedConfig.provider).toBe('lmstudio');
-        expect(resolved.mergedConfig.model).toBe('local-model');
-      }
-    });
-
-    it('merges numeric overrides correctly', async () => {
-      writeConfigYaml(tmpDir, makeValidConfigYaml());
-
-      const { resolveRuntimeWithOverrides } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const resolved = resolveRuntimeWithOverrides(tmpDir, {
-        maxRetries: 5,
-        timeoutMs: 60000,
-      }, () => 'test-key');
-
-      expect(resolved.mergedConfig).not.toBeNull();
-      if (resolved.mergedConfig) {
-        expect(resolved.mergedConfig.maxRetries).toBe(5);
-        expect(resolved.mergedConfig.timeoutMs).toBe(60000);
-      }
-    });
-  });
-
-  describe('edge cases and error handling', () => {
-    it('handles empty workspace directory gracefully', async () => {
-      // No .pd directory at all
-      const { resolveRuntimeFromPdConfig } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const resolved = resolveRuntimeFromPdConfig(tmpDir, { getEnvVar: () => 'test-key' });
-
-      // Missing config should return defaults (ok=true with source='defaults')
-      expect(resolved.configLoadResult.ok).toBe(true);
-      expect(resolved.configSource).toBe('.pd/config.yaml');
-    });
-
-    it('handles config with missing runtimeProfiles section', async () => {
-      writeConfigYaml(tmpDir, {
-        version: 1,
-        features: {},
-        // Missing runtimeProfiles
-      });
-
-      const { resolveRuntimeFromPdConfig } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const { isRuntimeConfigError } = await import('@principles/core/runtime-v2');
-      const resolved = resolveRuntimeFromPdConfig(tmpDir, { getEnvVar: () => 'test-key' });
-
-      // Missing runtimeProfiles should either load with defaults or produce
-      // a RuntimeConfigError — never silently succeed with wrong config.
-      if (isRuntimeConfigError(resolved.result)) {
-        expect(resolved.result.reason).toBeTruthy();
-        expect(resolved.result.nextAction).toBeTruthy();
-      } else {
-        // If defaults were returned, configLoadResult.ok should be true
-        expect(resolved.configLoadResult.ok).toBe(true);
-      }
-    });
-
-    it('handles config with invalid runtime profile type', async () => {
-      writeConfigYaml(tmpDir, {
-        version: 1,
-        runtimeProfiles: {
-          'bad-profile': {
-            type: 'invalid-type', // Invalid type
-          },
-        },
-        internalAgents: {
-          defaultRuntime: 'bad-profile',
-          agents: { diagnostician: { enabled: true, runtimeProfile: 'bad-profile' } },
-        },
-      });
-
-      const { resolveRuntimeFromPdConfig } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const { isRuntimeConfigError } = await import('@principles/core/runtime-v2');
-      const resolved = resolveRuntimeFromPdConfig(tmpDir, { getEnvVar: () => 'test-key' });
-
-      // Invalid type should be caught — verify external contract, not internal state
-      expect(isRuntimeConfigError(resolved.result)).toBe(true);
-      if (isRuntimeConfigError(resolved.result)) {
-        expect(resolved.result.reason).toBeTruthy();
-        expect(resolved.result.nextAction).toBeTruthy();
-      }
-    });
-
-    it('handles env var returning undefined for apiKeyEnv', async () => {
-      writeConfigYaml(tmpDir, makeValidConfigYaml());
-
-      const { resolveRuntimeFromPdConfig } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const resolved = resolveRuntimeFromPdConfig(tmpDir, { getEnvVar: () => undefined });
-
-      // Should handle undefined env var gracefully
-      expect(resolved.result).toBeDefined();
-    });
-
-    it('handles multiple legacy files detected', async () => {
-      writeConfigYaml(tmpDir, makeValidConfigYaml());
-
-      // Create multiple legacy files
-      const stateDir = path.join(tmpDir, '.state');
-      fs.mkdirSync(stateDir, { recursive: true });
-      fs.writeFileSync(path.join(stateDir, 'workflows.yaml'), 'version: 1', 'utf8');
-
-      const ffDir = path.join(tmpDir, '.pd');
-      fs.writeFileSync(path.join(ffDir, 'feature-flags.yaml'), 'flags: []', 'utf8');
-
-      const { resolveRuntimeFromPdConfig } = await import('../../src/services/resolve-runtime-from-pd-config.js');
-      const resolved = resolveRuntimeFromPdConfig(tmpDir, { getEnvVar: () => 'test-key' });
-
-      expect(resolved.legacyWarnings.length).toBeGreaterThan(0);
-      expect(resolved.configLoadResult.legacyFilesDetected.length).toBeGreaterThanOrEqual(2);
-    });
-  });
-});