@principles/pd-cli 1.152.12 → 1.152.14

package/tests/commands/candidate-show.test.ts

@@ -1,95 +0,0 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
-
-const { mockCandidateShow, mockResolveWorkspaceDir } = vi.hoisted(() => ({
-  mockCandidateShow: vi.fn(),
-  mockResolveWorkspaceDir: vi.fn().mockReturnValue('/fake/workspace'),
-}));
-
-vi.mock('../../src/resolve-workspace.js', () => ({
-  resolveWorkspaceDir: mockResolveWorkspaceDir,
-}));
-
-vi.mock('../../src/commands/candidate.js', () => ({
-  handleCandidateShow: mockCandidateShow,
-  handleCandidateIntake: vi.fn(),
-  handleCandidateRoute: vi.fn(),
-  handleCandidateInternalize: vi.fn(),
-  handleCandidateAudit: vi.fn(),
-  handleCandidateInternalizationBackfill: vi.fn(),
-}));
-
-import { Command } from 'commander';
-
-function createTestProgram(): Command {
-  const program = new Command();
-  program.exitOverride();
-
-  const candidateCmd = program.command('candidate');
-
-  candidateCmd
-    .command('show [candidateId]')
-    .description('Show detail for a single principle candidate')
-    .requiredOption('-w, --workspace <path>', 'Workspace directory')
-    .option('--candidate-id <id>', 'Candidate ID (alternative to positional arg)')
-    .option('--json', 'Output raw JSON')
-    .action(async (candidateId, opts) => {
-      const resolvedId = opts.candidateId ?? candidateId;
-      if (!resolvedId) {
-        throw new Error('candidate ID is required (positional or --candidate-id)');
-      }
-      if (candidateId && opts.candidateId && candidateId !== opts.candidateId) {
-        throw new Error(`conflicting candidate IDs: positional="${candidateId}", --candidate-id="${opts.candidateId}"`);
-      }
-      await mockCandidateShow({ candidateId: resolvedId, ...opts });
-    });
-
-  return program;
-}
-
-describe('candidate show CLI', () => {
-  beforeEach(() => {
-    vi.clearAllMocks();
-    mockCandidateShow.mockResolvedValue(undefined);
-  });
-
-  it('positional candidateId works', async () => {
-    const program = createTestProgram();
-    await program.parseAsync(['node', 'pd', 'candidate', 'show', 'c_123', '-w', '/ws']);
-
-    expect(mockCandidateShow).toHaveBeenCalledWith(
-      expect.objectContaining({ candidateId: 'c_123' }),
-    );
-  });
-
-  it('--candidate-id works', async () => {
-    const program = createTestProgram();
-    await program.parseAsync(['node', 'pd', 'candidate', 'show', '-w', '/ws', '--candidate-id', 'c_456']);
-
-    expect(mockCandidateShow).toHaveBeenCalledWith(
-      expect.objectContaining({ candidateId: 'c_456' }),
-    );
-  });
-
-  it('both positional and --candidate-id with same value works', async () => {
-    const program = createTestProgram();
-    await program.parseAsync(['node', 'pd', 'candidate', 'show', 'c_789', '-w', '/ws', '--candidate-id', 'c_789']);
-
-    expect(mockCandidateShow).toHaveBeenCalledWith(
-      expect.objectContaining({ candidateId: 'c_789' }),
-    );
-  });
-
-  it('conflicting positional and --candidate-id throws error', async () => {
-    const program = createTestProgram();
-    await expect(
-      program.parseAsync(['node', 'pd', 'candidate', 'show', 'c_a', '-w', '/ws', '--candidate-id', 'c_b']),
-    ).rejects.toThrow('conflicting candidate IDs');
-  });
-
-  it('neither positional nor --candidate-id throws error', async () => {
-    const program = createTestProgram();
-    await expect(
-      program.parseAsync(['node', 'pd', 'candidate', 'show', '-w', '/ws']),
-    ).rejects.toThrow('candidate ID is required');
-  });
-});

package/tests/commands/cli-command-tree.test.ts

@@ -1,144 +0,0 @@
-/**
- * CLI command tree structure tests — verify command placement.
- *
- * These tests ensure that commands are registered at the correct path in the CLI tree.
- *
- * Performance: help output is cached per unique command path so that repeated
- * assertions on the same subcommand (e.g. "runtime uat --help") only spawn
- * one child process instead of one per test.
- */
-import { describe, it, expect } from 'vitest';
-import { execFileSync } from 'node:child_process';
-import { getBuiltPdCliPath } from '../helpers/pd-cli-path.js';
-
-const helpCache = new Map<string, string>();
-
-function runPdHelp(args: string[]): string {
-  const key = args.join(' ');
-  const cached = helpCache.get(key);
-  if (cached !== undefined) return cached;
-
-  try {
-    const output = execFileSync('node', [getBuiltPdCliPath(), ...args], {
-      encoding: 'utf8',
-      cwd: process.cwd(),
-    });
-    helpCache.set(key, output);
-    return output;
-  } catch (err: unknown) {
-    if (err && typeof err === 'object' && Object.hasOwn(err, 'stdout')) {
-      const output = String(Reflect.get(err, 'stdout'));
-      helpCache.set(key, output);
-      return output;
-    }
-    throw err;
-  }
-}
-
-describe('CLI command tree structure', () => {
-  it('uat command exists under runtime (pd runtime uat --help)', () => {
-    const output = runPdHelp(['runtime', 'uat', '--help']);
-    expect(output).toContain('--workspace');
-    expect(output).toContain('--count');
-    expect(output).toContain('--min-success-rate');
-    expect(output).toContain('--json');
-  });
-
-  it('uat command description mentions Runtime V2 chain UAT', () => {
-    const output = runPdHelp(['runtime', 'uat', '--help']);
-    expect(output).toContain('UAT');
-  });
-
-  it('runtime subcommand list does NOT include uat (PRI-455: hidden from --help)', () => {
-    const output = runPdHelp(['runtime', '--help']);
-    expect(output).not.toMatch(/uat\s/);
-  });
-
-  it('pruning subcommand list does NOT include uat (pd runtime pruning --help)', () => {
-    const output = runPdHelp(['runtime', 'pruning', '--help']);
-    expect(output).toContain('report');
-    expect(output).toContain('explain');
-    expect(output).toContain('review');
-    expect(output).not.toMatch(/uat\s/);
-  });
-
-  it('health snapshot command exists under runtime health (pd runtime health snapshot --help)', () => {
-    const output = runPdHelp(['runtime', 'health', 'snapshot', '--help']);
-    expect(output).toContain('--workspace');
-    expect(output).toContain('--json');
-  });
-
-  it('runtime subcommand list includes health (pd runtime --help)', () => {
-    const output = runPdHelp(['runtime', '--help']);
-    expect(output).toMatch(/health\s/);
-  });
-
-  it('activation edit command exists under runtime activation (pd runtime activation edit --help)', () => {
-    const output = runPdHelp(['runtime', 'activation', 'edit', '--help']);
-    expect(output).toContain('--approval-id');
-    expect(output).toContain('--new-artifact-id');
-    expect(output).toContain('--edit-reason');
-    expect(output).toContain('--workspace');
-    expect(output).toContain('--json');
-  });
-
-  it('activation subcommand list includes edit (pd runtime activation --help)', () => {
-    const output = runPdHelp(['runtime', 'activation', '--help']);
-    expect(output).toMatch(/edit\s/);
-  });
-
-  it('rulecode command exists with spec/validate/replay subcommands (pd rulecode --help)', () => {
-    const output = runPdHelp(['rulecode', '--help']);
-    expect(output).toContain('spec');
-    expect(output).toContain('validate');
-    expect(output).toContain('replay');
-  });
-
-  it('rulecode spec subcommand has --json and --workspace (pd rulecode spec --help)', () => {
-    const output = runPdHelp(['rulecode', 'spec', '--help']);
-    expect(output).toContain('--json');
-    expect(output).toContain('--workspace');
-  });
-
-  it('rulecode validate subcommand has --code, --code-file, --json (pd rulecode validate --help)', () => {
-    const output = runPdHelp(['rulecode', 'validate', '--help']);
-    expect(output).toContain('--code');
-    expect(output).toContain('--code-file');
-    expect(output).toContain('--json');
-  });
-
-  it('rulecode replay subcommand has --golden-trace (required), --code, --json (pd rulecode replay --help)', () => {
-    const output = runPdHelp(['rulecode', 'replay', '--help']);
-    expect(output).toContain('--golden-trace');
-    expect(output).toContain('--code');
-    expect(output).toContain('--json');
-  });
-
-  it('legacy cleanup subcommand has --dry-run, --apply, --json (pd legacy cleanup --help)', () => {
-    const output = runPdHelp(['legacy', 'cleanup', '--help']);
-    expect(output).toContain('--dry-run');
-    expect(output).toContain('--apply');
-    expect(output).toContain('--json');
-    expect(output).toContain('--workspace');
-  });
-
-  it('legacy cleanup description mentions V1 Artificer artifacts', () => {
-    const output = runPdHelp(['legacy', 'cleanup', '--help']);
-    expect(output).toContain('V1 Artificer');
-  });
-
-  // cli-7-test-wiring (PR #1358 known gap 补齐): retry 是 INV-03 的核心 Owner
-  // 出边,command-tree 注册必须有 wiring 证明,不能只靠 handler 测试。
-  it('internalization retry command exists under runtime internalization (pd runtime internalization retry --help)', () => {
-    const output = runPdHelp(['runtime', 'internalization', 'retry', '--help']);
-    expect(output).toContain('--task');
-    expect(output).toContain('--confirm');
-    expect(output).toContain('--workspace');
-    expect(output).toContain('--json');
-  });
-
-  it('internalization subcommand list includes retry (pd runtime internalization --help)', () => {
-    const output = runPdHelp(['runtime', 'internalization', '--help']);
-    expect(output).toMatch(/retry\s/);
-  });
-});

package/tests/commands/cli-help-snapshot.test.ts

@@ -1,155 +0,0 @@
-/**
- * PRI-455: CLI help snapshot test — pins the visible command set.
- *
- * Asserts that `pd --help` shows only MVP owner-facing commands,
- * and that operator/debug commands are hidden (de-surfaced, not deleted).
- *
- * Hidden commands still work when invoked explicitly — this test only
- * checks --help visibility, not functional behavior.
- */
-import { describe, it, expect } from 'vitest';
-import { execFileSync } from 'node:child_process';
-import { getBuiltPdCliPath } from '../helpers/pd-cli-path.js';
-
-function runPdHelp(args: string[]): string {
-  try {
-    return execFileSync('node', [getBuiltPdCliPath(), ...args], {
-      encoding: 'utf8',
-      cwd: process.cwd(),
-    });
-  } catch (err: unknown) {
-    if (err && typeof err === 'object' && Object.hasOwn(err, 'stdout')) {
-      return String(Reflect.get(err, 'stdout'));
-    }
-    throw err;
-  }
-}
-
-describe('PRI-455: pd --help shows only MVP owner commands', () => {
-  const helpOutput = runPdHelp(['--help']);
-
-  // ── Owner-facing commands that MUST be visible ──────────────────────────
-  const OWNER_COMMANDS = [
-    'pain',          // Step 1: Capture
-    'diagnose',      // Step 2: Diagnose
-    'candidate',     // Step 3: Proposal
-    'console',       // Step 4: Review
-    'activation',    // Step 5-6: Activate & Observe (promoted)
-    'trace',         // Step 6: Observe (promoted)
-    'health',        // Global health
-    'config',        // Onboarding
-    'task',          // Async diagnosis progress
-    'runtime',       // runtime features (MVP-Core flag verification)
-  ];
-
-  for (const cmd of OWNER_COMMANDS) {
-    it(`pd --help shows owner command: ${cmd}`, () => {
-      // Anchor to line beginnings (like the hidden-command check) so the
-      // assertion matches the command list entry, not description text.
-      expect(helpOutput).toMatch(new RegExp(`^\\s+${cmd}\\b`, 'm'));
-    });
-  }
-
-  // ── Operator commands that MUST be hidden from --help ───────────────────
-  const HIDDEN_COMMANDS = [
-    'samples',
-    'evolution',
-    'central',    // MVP-Gone, deleted
-    'trajectory',
-    'history',
-    'context',
-    'legacy',
-    'artifact',
-    'demo',
-    'mvp',
-    'quality',
-    'rulecode',
-  ];
-
-  for (const cmd of HIDDEN_COMMANDS) {
-    it(`pd --help does NOT show operator command: ${cmd}`, () => {
-      expect(helpOutput).not.toMatch(new RegExp(`^\\s+${cmd}\\b`, 'm'));
-    });
-  }
-});
-
-describe('PRI-455: pd runtime --help shows only MVP owner subcommands', () => {
-  const runtimeHelp = runPdHelp(['runtime', '--help']);
-
-  // Owner-facing subcommands under runtime
-  it('runtime --help shows features', () => {
-    expect(runtimeHelp).toMatch(/\bfeatures\b/);
-  });
-
-  // PRI-674: recovery is now owner-facing — it is the only failed-task
-  // recovery re-entry point for an Owner without Console access, so hiding
-  // it made failed diagnostician tasks undiscoverable.
-  it('runtime --help shows recovery', () => {
-    expect(runtimeHelp).toMatch(/^\s+recovery\b/m);
-  });
-
-  // Operator subcommands that should be hidden
-  const HIDDEN_RUNTIME_SUBCOMMANDS = [
-    'canary',
-    'synthetic',
-    'uat',
-    'pruning',
-    'diagnostics',
-    'probe',
-    'flow',
-  ];
-
-  for (const cmd of HIDDEN_RUNTIME_SUBCOMMANDS) {
-    it(`runtime --help does NOT show operator subcommand: ${cmd}`, () => {
-      expect(runtimeHelp).not.toMatch(new RegExp(`^\\s+${cmd}\\b`, 'm'));
-    });
-  }
-});
-
-describe('PRI-455: promoted commands work at top-level', () => {
-  it('pd trace --help shows trace subcommand', () => {
-    const output = runPdHelp(['trace', '--help']);
-    expect(output).toContain('show');
-  });
-
-  it('pd activation --help shows list and deactivate', () => {
-    const output = runPdHelp(['activation', '--help']);
-    expect(output).toContain('list');
-    expect(output).toContain('deactivate');
-  });
-});
-
-describe('PRI-455: hidden commands still function (de-surface, not delete)', () => {
-  it('pd runtime probe --help still works (hidden but callable)', () => {
-    const output = runPdHelp(['runtime', 'probe', '--help']);
-    expect(output).toContain('--workspace');
-    expect(output).toContain('--json');
-  });
-
-  it('pd runtime internalization queue --help still works', () => {
-    const output = runPdHelp(['runtime', 'internalization', 'queue', '--help']);
-    expect(output).toContain('--workspace');
-    expect(output).toContain('--json');
-  });
-
-  it('pd legacy cleanup --help still works (hidden but callable)', () => {
-    const output = runPdHelp(['legacy', 'cleanup', '--help']);
-    expect(output).toContain('--dry-run');
-    expect(output).toContain('--apply');
-  });
-});
-
-describe('pd demo first-principle alias (Fix-24)', () => {
-  // cli-7-test-wiring: verify the alias resolves to the same command as story-a.
-  it('pd demo first-principle --help works and matches story-a', () => {
-    const aliasOutput = runPdHelp(['demo', 'first-principle', '--help']);
-    const storyAOutput = runPdHelp(['demo', 'story-a', '--help']);
-
-    // Both should show the same options
-    expect(aliasOutput).toContain('--workspace');
-    expect(aliasOutput).toContain('--json');
-    expect(aliasOutput).toContain('--channels');
-    // Alias output should be identical to story-a output
-    expect(aliasOutput).toBe(storyAOutput);
-  });
-});

package/tests/commands/cli-skill-contract.test.ts

@@ -1,121 +0,0 @@
-/**
- * PRI-455: SKILL ↔ CLI contract test.
- *
- * Parses SKILL.md templates for `pd <command>` references and verifies
- * that each referenced command path exists in the CLI command tree.
- *
- * This prevents SKILL templates from referencing deleted or renamed commands.
- *
- * Covers BOTH `en` and `zh` skill directories so bilingual template updates
- * are validated. Fails explicitly (does not silently skip) when the expected
- * skills directory is missing — a missing directory is a real contract break.
- */
-import { describe, it, expect } from 'vitest';
-import { execFileSync } from 'node:child_process';
-import { readFileSync, readdirSync, existsSync } from 'node:fs';
-import { join, resolve } from 'node:path';
-import { getBuiltPdCliPath } from '../helpers/pd-cli-path.js';
-
-/**
- * Resolve the skills directory for a given language.
- * Tests run from packages/pd-cli, so the plugin templates live one level up.
- */
-function resolveSkillsDir(lang: 'en' | 'zh'): string {
-  return resolve(
-    process.cwd(),
-    '..',
-    'openclaw-plugin',
-    'templates',
-    'langs',
-    lang,
-    'skills',
-  );
-}
-
-/**
- * Extract `pd <command> [subcommand] ...` patterns from SKILL.md content.
- * Matches lines like:
- *   pd pain record --reason ...
- *   pd runtime probe --json
- *   pd candidate list --workspace ...
- * Returns full command paths (e.g. "pain record", "runtime probe").
- */
-function extractPdCommands(markdown: string): string[] {
-  const commands: string[] = [];
-  // Match `pd <words>` in code blocks and inline code
-  const pdPattern = /`pd\s+([\w-]+(?:\s+[\w-]+)*)/g;
-  let match: RegExpExecArray | null;
-  while ((match = pdPattern.exec(markdown)) !== null) {
-    // Take up to 3 path segments (e.g. "runtime internalization queue")
-    const parts = match[1].split(/\s+/).slice(0, 3);
-    // Filter out flags and options
-    const cleanParts = parts.filter((p) => !p.startsWith('--') && !p.startsWith('<'));
-    if (cleanParts.length > 0) {
-      commands.push(cleanParts.join(' '));
-    }
-  }
-  return [...new Set(commands)];
-}
-
-/**
- * Check if a command path exists by running `pd <path> --help`.
- * Returns true if the command is registered (exit code 0 or help output contains "Usage:").
- */
-function commandExists(commandPath: string): boolean {
-  const args = commandPath.split(' ');
-  try {
-    const output = execFileSync('node', [getBuiltPdCliPath(), ...args, '--help'], {
-      encoding: 'utf8',
-      cwd: process.cwd(),
-      timeout: 10000,
-      stdio: ['pipe', 'pipe', 'pipe'],
-    });
-    return output.includes('Usage:') || output.includes('Options:');
-  } catch {
-    return false;
-  }
-}
-
-// Collect (lang, skill, command) triples across both en and zh.
-// A missing skills directory is a real contract break — fail explicitly.
-const LANGS = ['en', 'zh'] as const;
-const skillCommandPairs: { lang: string; skill: string; command: string }[] = [];
-const missingLangDirs: string[] = [];
-
-for (const lang of LANGS) {
-  const skillsDir = resolveSkillsDir(lang);
-  if (!existsSync(skillsDir)) {
-    missingLangDirs.push(lang);
-    continue;
-  }
-  const skillDirs = readdirSync(skillsDir).filter((dir) =>
-    existsSync(join(skillsDir, dir, 'SKILL.md')),
-  );
-  for (const dir of skillDirs) {
-    const skillPath = join(skillsDir, dir, 'SKILL.md');
-    const content = readFileSync(skillPath, 'utf8');
-    const commands = extractPdCommands(content);
-    for (const cmd of commands) {
-      skillCommandPairs.push({ lang, skill: dir, command: cmd });
-    }
-  }
-}
-
-describe('PRI-455: SKILL ↔ CLI contract', () => {
-  it('both en and zh skills directories exist', () => {
-    // Explicit failure instead of silent skip — a missing directory means
-    // the contract is no longer being validated for that language.
-    expect(missingLangDirs, `missing skills directories: ${missingLangDirs.join(', ')}`).toEqual([]);
-  });
-
-  it('found SKILL files that reference pd commands', () => {
-    expect(skillCommandPairs.length).toBeGreaterThan(0);
-  });
-
-  // Test each SKILL-referenced command exists in the CLI
-  for (const { lang, skill, command } of skillCommandPairs) {
-    it(`[${lang}] SKILL "${skill}" references valid command: pd ${command}`, () => {
-      expect(commandExists(command)).toBe(true);
-    });
-  }
-});