@principles/pd-cli 1.152.12 → 1.152.14

package/tests/commands/runtime-health-snapshot.test.ts

@@ -1,358 +0,0 @@
-/**
- * pd runtime health snapshot CLI unit tests.
- *
- * Tests the CLI adapter layer: validation, OperatorHealthReadModel delegation,
- * JSON/text output formatting, and exit code behavior.
- * OperatorHealthReadModel is mocked — its own contract is tested in principles-core.
- */
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-
-// ── Mock setup ──────────────────────────────────────────────────────────────
-
-const mockSnapshotFn = vi.fn();
-const mockCloseFn = vi.fn().mockResolvedValue(undefined);
-
-vi.mock('../../src/resolve-workspace.js', () => ({
-  resolveWorkspaceDir: vi.fn().mockReturnValue('/fake/workspace'),
-}));
-
-vi.mock('@principles/core/runtime-v2', () => ({
-  OperatorHealthReadModel: vi.fn().mockImplementation(function () {
-    return { getSnapshot: mockSnapshotFn, close: mockCloseFn };
-  }),
-  resolveOutputLanguage: vi.fn().mockReturnValue({ outputLanguage: 'zh-CN' }),
-}));
-
-import { handleRuntimeHealthSnapshot } from '../../src/commands/runtime-health-snapshot.js';
-
-// ── Helpers ─────────────────────────────────────────────────────────────────
-
-const WS = '/fake/workspace';
-
-function healthySnapshot() {
-  return {
-    generatedAt: '2026-05-03T12:00:00.000Z',
-    workspace: WS,
-    painChain: {
-      lastSuccessfulChain: {
-        painId: 'pain_001',
-        taskId: 'task_001',
-        runId: 'run_001',
-        artifactId: 'art_001',
-        candidateIds: ['c1'],
-        ledgerEntryIds: ['l1'],
-        status: 'succeeded',
-        latencyMs: { painToTask: 100 },
-        failureCategory: null,
-        checkedAt: '2026-05-03T12:00:00.000Z',
-        missingLinks: [],
-      },
-      failureCategory: null,
-    },
-    candidateLedger: {
-      auditStatus: 'ok' as const,
-      orphanCandidateCount: 0,
-      missingLedgerCount: 0,
-    },
-    pruning: {
-      watchCount: 0,
-      reviewCount: 0,
-      orphanDerivedCandidateCount: 0,
-    },
-    gfi: {
-      active: null,
-      staleSessionCount: 0,
-      staleGfiRange: null,
-      totalSessionCount: 0,
-      activeSessionCount: 0,
-      generatedAt: '2026-05-03T12:00:00.000Z',
-    },
-    overallStatus: 'healthy' as const,
-    recommendedActions: [],
-    totalTaskCount: 1,
-  };
-}
-
-function mockProcessExit() {
-  return vi.spyOn(process, 'exit').mockImplementation((() => undefined) as () => never);
-}
-
-// ── Tests ───────────────────────────────────────────────────────────────────
-
-describe('handleRuntimeHealthSnapshot', () => {
-  let consoleLogSpy: ReturnType<typeof vi.spyOn>;
-  let consoleErrorSpy: ReturnType<typeof vi.spyOn>;
-
-  beforeEach(() => {
-    vi.clearAllMocks();
-    consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
-    consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
-  });
-
-  afterEach(() => {
-    consoleLogSpy.mockRestore();
-    consoleErrorSpy.mockRestore();
-  });
-
-  // ── Healthy ──────────────────────────────────────────────────────────────
-
-  it('outputs healthy JSON snapshot with all required fields (--json)', async () => {
-    mockSnapshotFn.mockResolvedValue(healthySnapshot());
-
-    await handleRuntimeHealthSnapshot({ workspace: WS, json: true });
-
-    expect(consoleLogSpy).toHaveBeenCalled();
-    const jsonOutput = JSON.parse(consoleLogSpy.mock.calls[0][0]);
-    expect(jsonOutput.generatedAt).toBe('2026-05-03T12:00:00.000Z');
-    expect(jsonOutput.workspace).toBe(WS);
-    expect(jsonOutput.painChain).toBeDefined();
-    expect(jsonOutput.painChain.lastSuccessfulChain).toBeDefined();
-    expect(jsonOutput.candidateLedger.auditStatus).toBe('ok');
-    expect(jsonOutput.pruning.watchCount).toBe(0);
-    expect(jsonOutput.overallStatus).toBe('healthy');
-    expect(jsonOutput.recommendedActions).toEqual([]);
-  });
-
-  it('outputs readable text for healthy snapshot', async () => {
-    mockSnapshotFn.mockResolvedValue(healthySnapshot());
-
-    await handleRuntimeHealthSnapshot({ workspace: WS, json: false });
-
-    const allOutput = consoleLogSpy.mock.calls.map(c => c.join(' ')).join('\n');
-    expect(allOutput).toContain('HEALTHY');
-    expect(allOutput).toContain('No actions recommended');
-  });
-
-  // ── Degraded: candidate audit ────────────────────────────────────────────
-
-  it('reflects candidate audit degraded in overallStatus', async () => {
-    const snapshot = {
-      ...healthySnapshot(),
-      candidateLedger: {
-        auditStatus: 'degraded' as const,
-        orphanCandidateCount: 2,
-        missingLedgerCount: 2,
-      },
-      overallStatus: 'degraded' as const,
-      recommendedActions: [
-        'Run `pd candidate audit --workspace <path> --json` for details.',
-      ],
-    };
-    mockSnapshotFn.mockResolvedValue(snapshot);
-    const exitSpy = mockProcessExit();
-
-    await handleRuntimeHealthSnapshot({ workspace: WS, json: true });
-
-    const jsonOutput = JSON.parse(consoleLogSpy.mock.calls[0][0]);
-    expect(jsonOutput.overallStatus).toBe('degraded');
-    expect(jsonOutput.recommendedActions).toContain(
-      'Run `pd candidate audit --workspace <path> --json` for details.',
-    );
-    expect(process.exitCode).toBe(1);
-
-    exitSpy.mockRestore();
-  });
-
-  // ── Degraded: pruning signals ────────────────────────────────────────────
-
-  it('reflects pruning watch/review signals in recommendedActions', async () => {
-    const snapshot = {
-      ...healthySnapshot(),
-      pruning: {
-        watchCount: 2,
-        reviewCount: 1,
-        orphanDerivedCandidateCount: 0,
-      },
-      overallStatus: 'degraded' as const,
-      recommendedActions: [
-        'Run `pd runtime pruning report --workspace <path> --json` for lifecycle signals.',
-      ],
-    };
-    mockSnapshotFn.mockResolvedValue(snapshot);
-    const exitSpy = mockProcessExit();
-
-    await handleRuntimeHealthSnapshot({ workspace: WS, json: true });
-
-    const jsonOutput = JSON.parse(consoleLogSpy.mock.calls[0][0]);
-    expect(jsonOutput.overallStatus).toBe('degraded');
-    expect(jsonOutput.pruning.watchCount).toBe(2);
-    expect(jsonOutput.recommendedActions).toContain(
-      'Run `pd runtime pruning report --workspace <path> --json` for lifecycle signals.',
-    );
-
-    exitSpy.mockRestore();
-  });
-
-  // ── Degraded: no successful chain ────────────────────────────────────────
-
-  it('recommends UAT baseline when no successful chain exists', async () => {
-    const snapshot = {
-      ...healthySnapshot(),
-      painChain: {
-        lastSuccessfulChain: null,
-        failureCategory: null,
-      },
-      overallStatus: 'degraded' as const,
-      recommendedActions: [
-        'Run `pd runtime uat --workspace <path> --count 3` to establish baseline.',
-      ],
-    };
-    mockSnapshotFn.mockResolvedValue(snapshot);
-    const exitSpy = mockProcessExit();
-
-    await handleRuntimeHealthSnapshot({ workspace: WS, json: true });
-
-    const jsonOutput = JSON.parse(consoleLogSpy.mock.calls[0][0]);
-    expect(jsonOutput.painChain.lastSuccessfulChain).toBeNull();
-    expect(jsonOutput.recommendedActions).toContain(
-      'Run `pd runtime uat --workspace <path> --count 3` to establish baseline.',
-    );
-
-    exitSpy.mockRestore();
-  });
-
-  // ── Error ────────────────────────────────────────────────────────────────
-
-  it('handles error status from missing state.db', async () => {
-    const snapshot = {
-      ...healthySnapshot(),
-      candidateLedger: {
-        auditStatus: 'error' as const,
-        orphanCandidateCount: 0,
-        missingLedgerCount: 0,
-      },
-      overallStatus: 'error' as const,
-      recommendedActions: ['Initialize workspace with `pd pain record`.'],
-    };
-    mockSnapshotFn.mockResolvedValue(snapshot);
-    const exitSpy = mockProcessExit();
-
-    await handleRuntimeHealthSnapshot({ workspace: WS, json: true });
-
-    const jsonOutput = JSON.parse(consoleLogSpy.mock.calls[0][0]);
-    expect(jsonOutput.overallStatus).toBe('error');
-    expect(jsonOutput.candidateLedger.auditStatus).toBe('error');
-    expect(process.exitCode).toBe(1);
-
-    exitSpy.mockRestore();
-  });
-
-  // ── Multiple degraded conditions ─────────────────────────────────────────
-
-  it('accumulates multiple recommendedActions for multiple issues', async () => {
-    const snapshot = {
-      ...healthySnapshot(),
-      painChain: { lastSuccessfulChain: null, failureCategory: null },
-      candidateLedger: {
-        auditStatus: 'degraded' as const,
-        orphanCandidateCount: 2,
-        missingLedgerCount: 2,
-      },
-      pruning: { watchCount: 3, reviewCount: 1, orphanDerivedCandidateCount: 0 },
-      overallStatus: 'degraded' as const,
-      recommendedActions: [
-        'Run `pd candidate audit --workspace <path> --json` for details.',
-        'Run `pd runtime pruning report --workspace <path> --json` for lifecycle signals.',
-        'Run `pd runtime uat --workspace <path> --count 3` to establish baseline.',
-      ],
-    };
-    mockSnapshotFn.mockResolvedValue(snapshot);
-    const exitSpy = mockProcessExit();
-
-    await handleRuntimeHealthSnapshot({ workspace: WS, json: true });
-
-    const jsonOutput = JSON.parse(consoleLogSpy.mock.calls[0][0]);
-    expect(jsonOutput.recommendedActions).toHaveLength(3);
-
-    exitSpy.mockRestore();
-  });
-
-  // ── GFI section (PRI-83) ──────────────────────────────────────────────────
-
-  it('includes gfi section in JSON output with active session data', async () => {
-    const snapshot = {
-      ...healthySnapshot(),
-      gfi: {
-        active: {
-          currentGfi: 42,
-          stage: 'elevated',
-          dominantSource: 'tool_failure',
-          consecutiveErrors: 2,
-          dailyGfiPeak: 55,
-          consumers: {
-            attitudeMode: 'conciliatory',
-            painDiagnosticReason: 'high_gfi',
-          },
-        },
-        staleSessionCount: 1,
-        staleGfiRange: { min: 10, max: 20 },
-        totalSessionCount: 2,
-        activeSessionCount: 1,
-        generatedAt: '2026-05-03T12:00:00.000Z',
-      },
-    };
-    mockSnapshotFn.mockResolvedValue(snapshot);
-
-    await handleRuntimeHealthSnapshot({ workspace: WS, json: true });
-
-    const jsonOutput = JSON.parse(consoleLogSpy.mock.calls[0][0]);
-    expect(jsonOutput.gfi).toBeDefined();
-    expect(jsonOutput.gfi.active).not.toBeNull();
-    expect(jsonOutput.gfi.active.currentGfi).toBe(42);
-    expect(jsonOutput.gfi.active.stage).toBe('elevated');
-    expect(jsonOutput.gfi.active.dominantSource).toBe('tool_failure');
-    expect(jsonOutput.gfi.activeSessionCount).toBe(1);
-    expect(jsonOutput.gfi.staleSessionCount).toBe(1);
-  });
-
-  it('includes compact GFI line in text output', async () => {
-    const snapshot = {
-      ...healthySnapshot(),
-      gfi: {
-        active: {
-          currentGfi: 42,
-          stage: 'elevated',
-          dominantSource: 'tool_failure',
-          consecutiveErrors: 2,
-          dailyGfiPeak: 55,
-          consumers: {
-            attitudeMode: 'conciliatory',
-            painDiagnosticReason: 'high_gfi',
-          },
-        },
-        staleSessionCount: 0,
-        staleGfiRange: null,
-        totalSessionCount: 1,
-        activeSessionCount: 1,
-        generatedAt: '2026-05-03T12:00:00.000Z',
-      },
-    };
-    mockSnapshotFn.mockResolvedValue(snapshot);
-
-    await handleRuntimeHealthSnapshot({ workspace: WS, json: false });
-
-    const allOutput = consoleLogSpy.mock.calls.map(c => c.join(' ')).join('\n');
-    expect(allOutput).toContain('gfi:');
-    expect(allOutput).toContain('elevated');
-    expect(allOutput).toContain('42');
-  });
-
-  it('shows no active sessions in text when gfi.active is null', async () => {
-    mockSnapshotFn.mockResolvedValue(healthySnapshot());
-
-    await handleRuntimeHealthSnapshot({ workspace: WS, json: false });
-
-    const allOutput = consoleLogSpy.mock.calls.map(c => c.join(' ')).join('\n');
-    expect(allOutput).toContain('no active sessions');
-  });
-
-  it('does not mark runtime unhealthy solely for missing GFI data', async () => {
-    mockSnapshotFn.mockResolvedValue(healthySnapshot());
-
-    await handleRuntimeHealthSnapshot({ workspace: WS, json: true });
-
-    const jsonOutput = JSON.parse(consoleLogSpy.mock.calls[0][0]);
-    expect(jsonOutput.gfi.active).toBeNull();
-    expect(jsonOutput.overallStatus).toBe('healthy');
-  });
-});

package/tests/commands/runtime-init-empty-workspace.test.ts

@@ -1,252 +0,0 @@
-/**
- * runtime-init empty-workspace integration tests — verifies real DB initialization.
- *
- * Does NOT mock the DB layer. Uses real better-sqlite3 to create actual database
- * files in a temp workspace, then verifies all expected tables exist.
- *
- * Covers:
- *   - EMPTY-01: initialize empty workspace → all 3 DBs have full schema
- *   - EMPTY-02: idempotency — running twice does not error or lose data
- *
- * Prerequisites: @principles/core and principles-disciple must be built.
- *
- * ERR refs:
- * - rc-7-loop-state-freshness: idempotency test uses fresh workspace each run
- */
-
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
-import * as fs from 'node:fs';
-import * as path from 'node:path';
-import * as os from 'node:os';
-import * as yaml from 'js-yaml';
-import Database from 'better-sqlite3';
-import { validatePdConfig } from '@principles/core/runtime-v2';
-import { buildRuntimeInitOutput } from '../../src/commands/runtime-init.js';
-
-// ── Helpers ─────────────────────────────────────────────────────────────────
-
-function mkTmpDir(): string {
-  return fs.mkdtempSync(path.join(os.tmpdir(), 'pd-runtime-init-empty-'));
-}
-
-function rmTmpDir(dir: string): void {
-  try { fs.rmSync(dir, { recursive: true, force: true }); } catch { /* ignore */ }
-}
-
-function getTableNames(dbPath: string): string[] {
-  const db = new Database(dbPath, { readonly: true });
-  try {
-    const rows = db.prepare(
-      "SELECT name FROM sqlite_master WHERE type='table' AND name NOT LIKE 'sqlite_%' ORDER BY name"
-    ).all() as { name: string }[];
-    return rows.map(r => r.name);
-  } finally {
-    db.close();
-  }
-}
-
-function getIndexNames(dbPath: string): string[] {
-  const db = new Database(dbPath, { readonly: true });
-  try {
-    const rows = db.prepare(
-      "SELECT name FROM sqlite_master WHERE type='index' AND name NOT LIKE 'sqlite_%' ORDER BY name"
-    ).all() as { name: string }[];
-    return rows.map(r => r.name);
-  } finally {
-    db.close();
-  }
-}
-
-// ── Expected schema ─────────────────────────────────────────────────────────
-
-const EXPECTED_STATE_TABLES = [
-  'tasks', 'runs', 'artifacts', 'commits',
-  'principle_candidates', 'pi_artifacts',
-  'approvals', 'activations', 'intent_decisions',
-  'schema_version',
-];
-
-const EXPECTED_TRAJECTORY_TABLES = [
-  'schema_version', 'ingest_checkpoint', 'sessions', 'assistant_turns',
-  'user_turns', 'tool_calls', 'pain_events', 'gate_blocks', 'trust_changes',
-  'principle_events', 'task_outcomes', 'correction_samples', 'sample_reviews',
-  // PRI-790 G2: Stage2 待确认信号的持久队列（observer 周期批量确认的输入）。
-  'signal_confirmations',
-  'exports_audit',
-];
-
-const EXPECTED_TRAJECTORY_INDEXES = [
-  'idx_assistant_turns_session_id',
-  'idx_assistant_turns_created_at',
-  'idx_assistant_turns_provider_model',
-  'idx_user_turns_session_id',
-  'idx_tool_calls_session_id',
-  'idx_tool_calls_created_at',
-  'idx_pain_events_session_id',
-  'idx_pain_events_canonical_pain_id',
-  'idx_correction_samples_review_status',
-  // PRI-790 G2: 队列扫描索引（status + attempts）。
-  'idx_signal_confirmations_status',
-];
-
-// ── Tests ───────────────────────────────────────────────────────────────────
-
-describe('pd runtime init — empty workspace integration', () => {
-  let tmpDir: string;
-
-  beforeEach(() => {
-    tmpDir = mkTmpDir();
-  });
-
-  afterEach(() => {
-    rmTmpDir(tmpDir);
-  });
-
-  // ── EMPTY-01: initialize empty workspace ───────────────────────────────────
-
-  describe('EMPTY-01: initialize empty workspace', () => {
-    it('returns ok=true with 2 initialized databases', () => {
-      const output = buildRuntimeInitOutput(tmpDir, true);
-      expect(output.ok).toBe(true);
-      expect(output.mode).toBe('confirm');
-      expect(output.databases).toHaveLength(2);
-      for (const db of output.databases) {
-        expect(db.status).toBe('initialized');
-      }
-    });
-
-    it('creates state.db with all expected tables', () => {
-      buildRuntimeInitOutput(tmpDir, true);
-      const stateDbPath = path.join(tmpDir, '.pd', 'state.db');
-      expect(fs.existsSync(stateDbPath)).toBe(true);
-      const tables = getTableNames(stateDbPath);
-      for (const expected of EXPECTED_STATE_TABLES) {
-        expect(tables).toContain(expected);
-      }
-    });
-
-    it('creates trajectory.db with all 15 expected tables', () => {
-      buildRuntimeInitOutput(tmpDir, true);
-      const trajDbPath = path.join(tmpDir, '.state', 'trajectory.db');
-      expect(fs.existsSync(trajDbPath)).toBe(true);
-      const tables = getTableNames(trajDbPath);
-      expect(tables).toHaveLength(EXPECTED_TRAJECTORY_TABLES.length);
-      for (const expected of EXPECTED_TRAJECTORY_TABLES) {
-        expect(tables).toContain(expected);
-      }
-    });
-
-    it('creates trajectory.db with all expected indexes', () => {
-      buildRuntimeInitOutput(tmpDir, true);
-      const trajDbPath = path.join(tmpDir, '.state', 'trajectory.db');
-      const indexes = getIndexNames(trajDbPath);
-      for (const expected of EXPECTED_TRAJECTORY_INDEXES) {
-        expect(indexes).toContain(expected);
-      }
-    });
-
-    it('no longer creates subagent_workflows.db (legacy workflow store retired in PRI-737)', () => {
-      buildRuntimeInitOutput(tmpDir, true);
-      const wfDbPath = path.join(tmpDir, '.state', 'subagent_workflows.db');
-      expect(fs.existsSync(wfDbPath)).toBe(false);
-    });
-
-    it('pain_events table has canonical_pain_id and runtime_task_id columns', () => {
-      buildRuntimeInitOutput(tmpDir, true);
-      const trajDbPath = path.join(tmpDir, '.state', 'trajectory.db');
-      const db = new Database(trajDbPath, { readonly: true });
-      try {
-        const cols = db.prepare('PRAGMA table_info(pain_events)').all() as { name: string }[];
-        const colNames = cols.map(c => c.name);
-        expect(colNames).toContain('canonical_pain_id');
-        expect(colNames).toContain('runtime_task_id');
-        expect(colNames).toContain('text');
-      } finally {
-        db.close();
-      }
-    });
-
-    it('no longer creates evolution tables (retired in PRI-770, writer path gone since PRI-737)', () => {
-      buildRuntimeInitOutput(tmpDir, true);
-      const trajDbPath = path.join(tmpDir, '.state', 'trajectory.db');
-      const db = new Database(trajDbPath, { readonly: true });
-      try {
-        const tables = getTableNames(trajDbPath);
-        expect(tables).not.toContain('evolution_tasks');
-        expect(tables).not.toContain('evolution_events');
-        const legacy = db.prepare(
-          "SELECT name FROM sqlite_master WHERE type = 'table' AND name IN ('evolution_tasks','evolution_events')"
-        ).all();
-        expect(legacy).toHaveLength(0);
-      } finally {
-        db.close();
-      }
-    });
-
-    // ── P0: config.yaml scaffolding (Issue 1b) ────────────────────────────────
-
-    it('creates .pd/config.yaml with version 1 and workspace.default set', () => {
-      buildRuntimeInitOutput(tmpDir, true);
-      const configPath = path.join(tmpDir, '.pd', 'config.yaml');
-      expect(fs.existsSync(configPath)).toBe(true);
-      const parsed = yaml.load(fs.readFileSync(configPath, 'utf8'), { schema: yaml.JSON_SCHEMA });
-      const obj = parsed as { version?: unknown; workspace?: { default?: unknown } };
-      expect(obj.version).toBe(1);
-      expect(obj.workspace?.default).toBe(path.resolve(tmpDir));
-    });
-
-    it('generated config.yaml passes validatePdConfig (round-trip)', () => {
-      buildRuntimeInitOutput(tmpDir, true);
-      const configPath = path.join(tmpDir, '.pd', 'config.yaml');
-      const parsed: unknown = yaml.load(fs.readFileSync(configPath, 'utf8'), { schema: yaml.JSON_SCHEMA });
-      const result = validatePdConfig(parsed);
-      expect(result.ok).toBe(true);
-    });
-  });
-
-  // ── EMPTY-02: idempotency ──────────────────────────────────────────────────
-
-  describe('EMPTY-02: idempotency', () => {
-    it('running twice does not error and tables remain intact', () => {
-      // First initialization
-      const output1 = buildRuntimeInitOutput(tmpDir, true);
-      expect(output1.ok).toBe(true);
-
-      // Capture table counts after first init
-      const trajDbPath = path.join(tmpDir, '.state', 'trajectory.db');
-      const tables1 = getTableNames(trajDbPath);
-
-      // Second initialization (should be idempotent)
-      const output2 = buildRuntimeInitOutput(tmpDir, true);
-      expect(output2.ok).toBe(true);
-      expect(output2.databases).toHaveLength(2);
-      for (const db of output2.databases) {
-        expect(db.status).toBe('initialized');
-      }
-
-      // Table set should be unchanged
-      const tables2 = getTableNames(trajDbPath);
-      expect(tables2).toEqual(tables1);
-
-      // config.yaml is preserved: second run reports skipped, content unchanged
-      expect(output2.config?.status).toBe('skipped');
-      const configPath = path.join(tmpDir, '.pd', 'config.yaml');
-      const config1 = fs.readFileSync(configPath, 'utf8');
-      expect(fs.readFileSync(configPath, 'utf8')).toBe(config1);
-    });
-
-    it('dry-run after confirm does not modify existing DBs', () => {
-      // First: confirm mode (real init)
-      buildRuntimeInitOutput(tmpDir, true);
-      const trajDbPath = path.join(tmpDir, '.state', 'trajectory.db');
-      const tablesBefore = getTableNames(trajDbPath);
-
-      // Second: dry-run mode (should not modify)
-      const output = buildRuntimeInitOutput(tmpDir, false);
-      expect(output.mode).toBe('dry-run');
-
-      const tablesAfter = getTableNames(trajDbPath);
-      expect(tablesAfter).toEqual(tablesBefore);
-    });
-  });
-});