@principles/pd-cli 1.152.12 → 1.152.14

package/src/commands/__tests__/runtime-activation-nextaction.test.ts

@@ -1,81 +0,0 @@
-/**
- * Regression test for nextAction CLI hints in `pd activation list`.
- *
- * Bug #1367: `pd activation list` emitted `--confirm` in the deactivate
- * nextAction, but the `deactivate` command has no `--confirm` option
- * (`error: unknown option '--confirm'`).
- *
- * Root cause: the nextAction template was copy-pasted from `promote`
- * (which DOES support --confirm) without adjusting the deactivate variant.
- *
- * Guard: deactivate nextAction must never contain `--confirm`;
- * promote nextAction must always contain `--confirm`.
- */
-
-import { describe, it, expect } from 'vitest';
-import { deriveActivationStatusAndNextAction } from '../runtime-activation.js';
-
-describe('deriveActivationStatusAndNextAction', () => {
-  const base = {
-    deactivatedAt: null,
-    contextVersion: 'v1' as const,
-    v2FlagEnabled: true,
-    activationId: 'act_code_rule-test-123',
-  };
-
-  it('live mode: deactivate nextAction must NOT contain --confirm (bug #1367)', () => {
-    const { status, nextAction } = deriveActivationStatusAndNextAction({
-      ...base,
-      mode: 'live',
-    });
-    expect(status).toBe('active');
-    expect(nextAction).toBeDefined();
-    expect(nextAction).toContain('pd activation deactivate');
-    expect(nextAction).not.toContain('--confirm');
-  });
-
-  it('shadow mode: nextAction requires Owner review instead of advertising direct mutation', () => {
-    const { status, nextAction } = deriveActivationStatusAndNextAction({
-      ...base,
-      mode: 'shadow',
-    });
-    expect(status).toBe('active');
-    expect(nextAction).toBeDefined();
-    expect(nextAction).toBe(
-      'Keep shadow; promotion requires an authenticated Owner decision, immutable evidence bindings, and a passing Promotion Readiness result.',
-    );
-    expect(nextAction).not.toContain('pd activation promote');
-  });
-
-  it('deactivated record: status deactivated, no nextAction', () => {
-    const { status, nextAction } = deriveActivationStatusAndNextAction({
-      ...base,
-      mode: 'live',
-      deactivatedAt: '2026-08-21T00:51:10.026Z',
-    });
-    expect(status).toBe('deactivated');
-    expect(nextAction).toBeUndefined();
-  });
-
-  it('v2 activation with flag off: suspended_by_flag, deactivate hint without --confirm', () => {
-    const { status, nextAction } = deriveActivationStatusAndNextAction({
-      ...base,
-      mode: 'live',
-      contextVersion: 'v2',
-      v2FlagEnabled: false,
-    });
-    expect(status).toBe('suspended_by_flag');
-    expect(nextAction).toBeDefined();
-    expect(nextAction).toContain('pd activation deactivate');
-    expect(nextAction).not.toContain('--confirm');
-  });
-
-  it('unknown mode: active with no nextAction', () => {
-    const { status, nextAction } = deriveActivationStatusAndNextAction({
-      ...base,
-      mode: undefined,
-    });
-    expect(status).toBe('active');
-    expect(nextAction).toBeUndefined();
-  });
-});

package/src/commands/__tests__/runtime-probe-config.test.ts

@@ -1,432 +0,0 @@
-/**
- * PRI-402: pd runtime probe reads .pd/config.yaml for pi-ai config.
- *
- * Tests cover:
- *   - probe reads config from .pd/config.yaml when --workspace is provided
- *   - JSON output includes configSource, runtimeProfileId, runtimeProfileLabel
- *   - explicit --provider overrides config.yaml
- *   - fail-loud JSON when config.yaml is missing or incomplete
- *   - program.parseAsync against real Commander registration (EP-04)
- *
- * ERR refs:
- *   - EP-04 (CLI gate): --json stdout single object, process.exit(1) + return
- *   - EP-03 (fail loud): structured JSON with reason + nextAction on failure
- *   - EP-07 (source alignment): probe and doctor read same config source
- *   - ERR-004 (source alignment): profileId/label must match doctor output
- *   - ERR-021 (handler-only tests): add program.parseAsync tests
- *   - ERR-029 (fail-loud JSON): config missing → structured JSON, not bare error
- */
-
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import { Command } from 'commander';
-import * as fs from 'fs';
-import * as path from 'path';
-import * as os from 'os';
-
-// ─── Mocks ─────────────────────────────────────────────────────────────────
-
-// Mock only probeRuntime so we don't need a real LLM provider.
-// All other core functions (validatePdConfig, computeEffectivePdConfig,
-// resolveAgentRuntimeBinding, etc.) use their real implementations.
-const mockProbeRuntime = vi.fn();
-vi.mock('@principles/core/runtime-v2', async (importOriginal) => {
-  const actual = await importOriginal<Record<string, unknown>>();
-  return {
-    ...actual,
-    probeRuntime: mockProbeRuntime,
-  };
-});
-
-const { handleRuntimeProbe } = await import('../runtime.js');
-
-// ─── Test Setup ─────────────────────────────────────────────────────────────
-
-const capturedStdout: string[] = [];
-const capturedStderr: string[] = [];
-let capturedExitCode: number | null = null;
-
-const originalExit = process.exit;
-const originalLog = console.log;
-const originalError = console.error;
-const originalWarn = console.warn;
-const originalEnv = { ...process.env };
-
-beforeEach(() => {
-  capturedExitCode = null;
-  capturedStdout.length = 0;
-  capturedStderr.length = 0;
-  process.exit = vi.fn(((code?: number) => {
-    capturedExitCode = code ?? 0;
-  }) as typeof process.exit);
-  console.log = vi.fn((...args: unknown[]) => { capturedStdout.push(args.join(' ')); });
-  console.error = vi.fn((...args: unknown[]) => { capturedStderr.push(args.join(' ')); });
-  console.warn = vi.fn(() => { /* capture warnings */ });
-  mockProbeRuntime.mockReset();
-  process.env = { ...originalEnv, LMSTUDIO_API_KEY: 'test-key-for-pri-402', OPENROUTER_API_KEY: 'test-key-for-pri-402' };
-});
-
-afterEach(() => {
-  process.exit = originalExit;
-  console.log = originalLog;
-  console.error = originalError;
-  console.warn = originalWarn;
-  process.env = originalEnv;
-});
-
-// ─── Helper: create temp workspace with .pd/config.yaml ────────────────────
-
-/** Create a scratch workspace with .pd/config.yaml under a unique temp root. */
-function createTempWorkspace(configYaml: string): string {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pd-probe-test-'));
-  const pdDir = path.join(tmpDir, '.pd');
-  fs.mkdirSync(pdDir, { recursive: true });
-  // Replace __WORKSPACE_DIR__ placeholder with actual path
-  const resolvedYaml = configYaml.replace(/__WORKSPACE_DIR__/g, tmpDir.replace(/\\/g, '/'));
-  fs.writeFileSync(path.join(pdDir, 'config.yaml'), resolvedYaml, 'utf-8');
-  return tmpDir;
-}
-
-function cleanupWorkspace(dir: string): void {
-  try {
-    fs.rmSync(dir, { recursive: true, force: true });
-  } catch {
-    // best effort
-  }
-}
-
-const PI_AI_CONFIG_YAML = `
-version: 1
-features:
-  prompt: { category: core, enabled: true }
-  code_tool_hook: { category: core, enabled: true }
-  defer_archive: { category: core, enabled: true }
-workspace:
-  default: __WORKSPACE_DIR__
-internalAgents:
-  defaultRuntime: pi-ai.lmstudio
-  agents:
-    diagnostician:
-      enabled: true
-      runtimeProfile: pi-ai.lmstudio
-    dreamer:
-      enabled: true
-    philosopher:
-      enabled: true
-    scribe:
-      enabled: true
-    artificer:
-      enabled: true
-runtimeProfiles:
-  pi-ai.lmstudio:
-    type: pi-ai
-    provider: lmstudio
-    model: qwen3.6-27b-mtp
-    apiKeyEnv: LMSTUDIO_API_KEY
-    baseUrl: http://localhost:1234/v1
-`;
-
-// ─── Tests: probe reads config from .pd/config.yaml ────────────────────────
-
-describe('PRI-402: probe reads .pd/config.yaml for pi-ai config', () => {
-  it('reads provider/model from config.yaml when --workspace provided without --provider', async () => {
-    const workspace = createTempWorkspace(PI_AI_CONFIG_YAML);
-    try {
-      mockProbeRuntime.mockResolvedValue({
-        runtimeKind: 'pi-ai',
-        provider: 'lmstudio',
-        model: 'qwen3.6-27b-mtp',
-        health: { healthy: true, degraded: false, warnings: [], lastCheckedAt: '2026-01-01T00:00:00Z' },
-        capabilities: { streaming: true },
-      });
-
-      await handleRuntimeProbe({
-        runtime: 'pi-ai',
-        workspace,
-        json: true,
-      });
-
-      // probeRuntime should be called with config.yaml values
-      expect(mockProbeRuntime).toHaveBeenCalled();
-      const callArgs = mockProbeRuntime.mock.calls[0]?.[0];
-      expect(callArgs?.provider).toBe('lmstudio');
-      expect(callArgs?.model).toBe('qwen3.6-27b-mtp');
-      expect(callArgs?.apiKeyEnv).toBe('LMSTUDIO_API_KEY');
-
-      // JSON output should contain configSource, runtimeProfileId, runtimeProfileLabel
-      const output = JSON.parse(capturedStdout.join(''));
-      expect(output.configSource).toBe('.pd/config.yaml');
-      expect(output.runtimeProfileId).toBe('pi-ai.lmstudio');
-      expect(output.runtimeProfileLabel).toBe('pi-ai: lmstudio/qwen3.6-27b-mtp');
-      expect(output.ok).toBe(true);
-    } finally {
-      cleanupWorkspace(workspace);
-    }
-  });
-
-  it('explicit --provider overrides config.yaml value', async () => {
-    const workspace = createTempWorkspace(PI_AI_CONFIG_YAML);
-    try {
-      mockProbeRuntime.mockResolvedValue({
-        runtimeKind: 'pi-ai',
-        provider: 'openrouter',
-        model: 'qwen3.6-27b-mtp',
-        health: { healthy: true, degraded: false, warnings: [], lastCheckedAt: '2026-01-01T00:00:00Z' },
-        capabilities: { streaming: true },
-      });
-
-      await handleRuntimeProbe({
-        runtime: 'pi-ai',
-        workspace,
-        provider: 'openrouter',
-        model: 'anthropic/claude-sonnet-4',
-        apiKeyEnv: 'OPENROUTER_API_KEY',
-        json: true,
-      });
-
-      const callArgs = mockProbeRuntime.mock.calls[0]?.[0];
-      // CLI flags override config.yaml
-      expect(callArgs?.provider).toBe('openrouter');
-      expect(callArgs?.model).toBe('anthropic/claude-sonnet-4');
-      expect(callArgs?.apiKeyEnv).toBe('OPENROUTER_API_KEY');
-
-      // Profile info still comes from config.yaml (EP-07: source alignment)
-      const output = JSON.parse(capturedStdout.join(''));
-      expect(output.configSource).toBe('.pd/config.yaml');
-      expect(output.runtimeProfileId).toBe('pi-ai.lmstudio');
-    } finally {
-      cleanupWorkspace(workspace);
-    }
-  });
-
-  it('fail-loud JSON when config.yaml is missing and no --provider', async () => {
-    const workspace = path.join(os.tmpdir(), `pd-probe-test-missing-${Date.now()}`);
-    fs.mkdirSync(workspace, { recursive: true });
-    // No .pd/config.yaml created
-    try {
-      await handleRuntimeProbe({
-        runtime: 'pi-ai',
-        workspace,
-        json: true,
-      });
-
-      expect(capturedExitCode).toBe(1);
-      const output = JSON.parse(capturedStdout.join(''));
-      expect(output.ok).toBe(false);
-      expect(output.status).toBe('failed');
-      expect(typeof output.reason).toBe('string');
-      expect(typeof output.nextAction).toBe('string');
-      // Single parseable JSON object (EP-04 Rule 1)
-      expect(Array.isArray(output)).toBe(false);
-    } finally {
-      cleanupWorkspace(workspace);
-    }
-  });
-
-  it('fail-loud JSON when provider missing from config.yaml', async () => {
-    const workspace = createTempWorkspace(`
-version: 1
-features:
-  prompt: { category: core, enabled: true }
-  code_tool_hook: { category: core, enabled: true }
-  defer_archive: { category: core, enabled: true }
-workspace:
-  default: __WORKSPACE_DIR__
-internalAgents:
-  defaultRuntime: pi-ai.broken
-  agents:
-    diagnostician:
-      enabled: true
-      runtimeProfile: pi-ai.broken
-runtimeProfiles:
-  pi-ai.broken:
-    type: pi-ai
-    # Missing provider, model, apiKeyEnv
-`);
-    try {
-      await handleRuntimeProbe({
-        runtime: 'pi-ai',
-        workspace,
-        json: true,
-      });
-
-      expect(capturedExitCode).toBe(1);
-      const output = JSON.parse(capturedStdout.join(''));
-      expect(output.ok).toBe(false);
-      expect(output.status).toBe('failed');
-      expect(typeof output.reason).toBe('string');
-      expect(typeof output.nextAction).toBe('string');
-    } finally {
-      cleanupWorkspace(workspace);
-    }
-  });
-
-  it('fail-loud JSON when apiKeyEnv env var is not set', async () => {
-    const workspace = createTempWorkspace(PI_AI_CONFIG_YAML);
-    try {
-      // Remove the API key env var
-      delete process.env.LMSTUDIO_API_KEY;
-
-      await handleRuntimeProbe({
-        runtime: 'pi-ai',
-        workspace,
-        json: true,
-      });
-
-      expect(capturedExitCode).toBe(1);
-      const output = JSON.parse(capturedStdout.join(''));
-      expect(output.ok).toBe(false);
-      // When apiKeyEnv is not set, resolveRuntimeConfigFromPdConfig returns
-      // a config error (not_ready), so the error comes from the config resolution path
-      expect(typeof output.reason).toBe('string');
-      expect(typeof output.nextAction).toBe('string');
-    } finally {
-      cleanupWorkspace(workspace);
-    }
-  });
-
-  it('human-readable output includes Profile and Config lines', async () => {
-    const workspace = createTempWorkspace(PI_AI_CONFIG_YAML);
-    try {
-      mockProbeRuntime.mockResolvedValue({
-        runtimeKind: 'pi-ai',
-        provider: 'lmstudio',
-        model: 'qwen3.6-27b-mtp',
-        health: { healthy: true, degraded: false, warnings: [], lastCheckedAt: '2026-01-01T00:00:00Z' },
-        capabilities: { streaming: true },
-      });
-
-      await handleRuntimeProbe({
-        runtime: 'pi-ai',
-        workspace,
-        json: false,
-      });
-
-      const output = capturedStdout.join('\n');
-      expect(output).toContain('Profile:');
-      expect(output).toContain('pi-ai: lmstudio/qwen3.6-27b-mtp');
-      expect(output).toContain('Config:');
-      expect(output).toContain('.pd/config.yaml');
-    } finally {
-      cleanupWorkspace(workspace);
-    }
-  });
-});
-
-// ─── Tests: program.parseAsync against real Commander registration (EP-04) ──
-
-// Import the real command registration function to test actual production wiring
-const { registerRuntimeProbeCommand } = await import('../runtime.js');
-
-interface CapturedAction {
-  opts: Record<string, unknown> | null;
-}
-
-function attachCapture(cmd: Command, state: CapturedAction): void {
-  // Override the action handler to capture opts without calling the real handler
-  cmd.action((...args: unknown[]) => {
-    // Find the opts object (last non-Command, non-null object arg)
-    let optsArg: Record<string, unknown> | null = null;
-    for (let i = args.length - 1; i >= 0; i--) {
-      const arg: unknown = args[i];
-      if (arg !== null && typeof arg === 'object' && !(arg instanceof Command)) {
-        optsArg = arg as Record<string, unknown>;
-        break;
-      }
-    }
-    state.opts = optsArg ?? {};
-    // Do NOT call original action (would call handleRuntimeProbe which needs real runtime)
-  });
-}
-
-function freshProgram(): Command {
-  const program = new Command();
-  program.name('pd').exitOverride();
-  return program;
-}
-
-describe('PRI-402: probe command flag wiring (EP-04 real registration)', () => {
-  it('registers --runtime as required option via real registration', () => {
-    const program = freshProgram();
-    const runtimeCmd = program.command('runtime');
-    const probeCmd = registerRuntimeProbeCommand(runtimeCmd);
-
-    const runtimeOpt = probeCmd.options.find((o) => o.long === '--runtime');
-    expect(runtimeOpt).toBeDefined();
-    expect(runtimeOpt?.required).toBe(true);
-  });
-
-  it('registers --workspace with -w shorthand via real registration', () => {
-    const program = freshProgram();
-    const runtimeCmd = program.command('runtime');
-    const probeCmd = registerRuntimeProbeCommand(runtimeCmd);
-
-    const wsOpt = probeCmd.options.find((o) => o.short === '-w');
-    expect(wsOpt).toBeDefined();
-    expect(wsOpt?.long).toBe('--workspace');
-  });
-
-  it('parses --runtime pi-ai --workspace <dir> --json correctly via real registration', async () => {
-    const program = freshProgram();
-    const runtimeCmd = program.command('runtime');
-    const probeCmd = registerRuntimeProbeCommand(runtimeCmd);
-    const captured: CapturedAction = { opts: null };
-    attachCapture(probeCmd, captured);
-
-    await program.parseAsync(['node', 'pd', 'runtime', 'probe', '--runtime', 'pi-ai', '--workspace', '/tmp/test', '--json']);
-
-    expect(captured.opts).not.toBeNull();
-    if (!captured.opts) throw new Error('captured.opts is null');
-    expect(captured.opts.runtime).toBe('pi-ai');
-    expect(captured.opts.workspace).toBe('/tmp/test');
-    expect(captured.opts.json).toBe(true);
-  });
-
-  it('parses --runtime config --workspace <dir> correctly via real registration', async () => {
-    const program = freshProgram();
-    const runtimeCmd = program.command('runtime');
-    const probeCmd = registerRuntimeProbeCommand(runtimeCmd);
-    const captured: CapturedAction = { opts: null };
-    attachCapture(probeCmd, captured);
-
-    await program.parseAsync(['node', 'pd', 'runtime', 'probe', '--runtime', 'config', '--workspace', '/tmp/test']);
-
-    expect(captured.opts).not.toBeNull();
-    if (!captured.opts) throw new Error('captured.opts is null');
-    expect(captured.opts.runtime).toBe('config');
-    expect(captured.opts.workspace).toBe('/tmp/test');
-  });
-});
-
-// ─── Tests: resolve-runtime-from-pd-config profile extraction ───────────────
-
-describe('PRI-402: resolveRuntimeWithOverrides returns profile info', () => {
-  it('returns runtimeProfileId and runtimeProfileLabel from config.yaml', async () => {
-    const workspace = createTempWorkspace(PI_AI_CONFIG_YAML);
-    try {
-      const { resolveRuntimeWithOverrides } = await import('../../services/resolve-runtime-from-pd-config.js');
-      const result = resolveRuntimeWithOverrides(workspace, {});
-
-      expect(result.configSource).toBe('.pd/config.yaml');
-      expect(result.runtimeProfileId).toBe('pi-ai.lmstudio');
-      expect(result.runtimeProfileLabel).toBe('pi-ai: lmstudio/qwen3.6-27b-mtp');
-    } finally {
-      cleanupWorkspace(workspace);
-    }
-  });
-
-  it('returns default profile when config.yaml is missing', async () => {
-    const workspace = path.join(os.tmpdir(), `pd-probe-test-noprofile-${Date.now()}`);
-    fs.mkdirSync(workspace, { recursive: true });
-    try {
-      const { resolveRuntimeWithOverrides } = await import('../../services/resolve-runtime-from-pd-config.js');
-      const result = resolveRuntimeWithOverrides(workspace, {});
-
-      // Missing config → defaults, which use openclaw.default as defaultRuntime
-      expect(result.configSource).toBe('.pd/config.yaml');
-      expect(result.runtimeProfileId).toBe('openclaw.default');
-      expect(typeof result.runtimeProfileLabel).toBe('string');
-    } finally {
-      cleanupWorkspace(workspace);
-    }
-  });
-});

package/src/commands/__tests__/telemetry-flag-wiring.test.ts

@@ -1,84 +0,0 @@
-/**
- * pd telemetry — parser-level flag wiring tests (PRI-597, CLI Operator Gate
- * rule 7 / EP-04).
- *
- * Exercises the real Commander tree via registerTelemetryCommand; actions are
- * captured so no handler logic runs.
- */
-
-import { describe, it, expect } from 'vitest';
-import { Command } from 'commander';
-import { registerTelemetryCommand } from '../telemetry.js';
-
-function freshProgram(): Command {
-  const program = new Command();
-  program.name('pd').exitOverride();
-  return program;
-}
-
-function requireCmd(cmd: Command | undefined, name: string): Command {
-  if (cmd === undefined) {
-    throw new Error(`Command '${name}' not found in tree`);
-  }
-  return cmd;
-}
-
-function telemetrySub(name: string): Command {
-  const program = freshProgram();
-  registerTelemetryCommand(program);
-  const telemetry = requireCmd(program.commands.find((c) => c.name() === 'telemetry'), 'telemetry');
-  return requireCmd(telemetry.commands.find((c) => c.name() === name), `telemetry ${name}`);
-}
-
-describe('pd telemetry — command registration', () => {
-  it('registers the telemetry group with all five subcommands', () => {
-    const program = freshProgram();
-    registerTelemetryCommand(program);
-    const telemetry = requireCmd(program.commands.find((c) => c.name() === 'telemetry'), 'telemetry');
-    const subNames = telemetry.commands.map((c) => c.name()).sort();
-    expect(subNames).toEqual(['disable', 'enable', 'preview', 'reset', 'status']);
-  });
-
-  it('status registers --workspace (-w) and --json', () => {
-    const status = telemetrySub('status');
-    expect(status.options.find((o) => o.long === '--workspace')?.short).toBe('-w');
-    expect(status.options.find((o) => o.long === '--json')).toBeDefined();
-  });
-
-  it('enable/disable/reset register the dry-run/confirm pair (cli-4) plus --workspace and --json', () => {
-    for (const name of ['enable', 'disable', 'reset']) {
-      const cmd = telemetrySub(name);
-      expect(cmd.options.find((o) => o.long === '--dry-run'), name).toBeDefined();
-      expect(cmd.options.find((o) => o.long === '--confirm'), name).toBeDefined();
-      expect(cmd.options.find((o) => o.long === '--workspace'), name).toBeDefined();
-      expect(cmd.options.find((o) => o.long === '--json'), name).toBeDefined();
-    }
-  });
-
-  it('preview registers --workspace (-w) and --json', () => {
-    const preview = telemetrySub('preview');
-    expect(preview.options.find((o) => o.long === '--workspace')?.short).toBe('-w');
-    expect(preview.options.find((o) => o.long === '--json')).toBeDefined();
-  });
-
-  it('parser dispatches telemetry enable with --confirm as opts.confirm === true', async () => {
-    const program = freshProgram();
-    registerTelemetryCommand(program);
-    const holder: { opts: Record<string, unknown> | null } = { opts: null };
-    const telemetry = requireCmd(program.commands.find((c) => c.name() === 'telemetry'), 'telemetry');
-    const enable = requireCmd(telemetry.commands.find((c) => c.name() === 'enable'), 'enable');
-    enable.action((...args: unknown[]) => {
-      for (let i = args.length - 1; i >= 0; i--) {
-        const arg = args[i];
-        if (arg !== null && typeof arg === 'object' && !(arg instanceof Command)) {
-          holder.opts = arg as Record<string, unknown>;
-          break;
-        }
-      }
-    });
-    await program.parseAsync(['node', 'pd', 'telemetry', 'enable', '--confirm', '--json']);
-    expect(holder.opts).not.toBeNull();
-    expect(holder.opts?.confirm).toBe(true);
-    expect(holder.opts?.json).toBe(true);
-  });
-});