@principles/pd-cli 1.152.12 → 1.152.13

package/tests/commands/pain-record-session-parser.test.ts

@@ -1,228 +0,0 @@
-/**
- * PRI-642 Scope A — real-Commander integration for `pd pain record --session`.
- *
- * Spawns the BUILT pd CLI (dist/index.js) against a real temp workspace with a
- * real trajectory.db, exercising the actual commander registration and the
- * real typed acquisition path — not the in-process handler with mocks
- * (cli-7-test-wiring; SPEC §13 "Real Commander parser/registration tests for
- * --session and --json").
- */
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
-import { promisify } from 'node:util';
-import Database from 'better-sqlite3';
-import * as fs from 'node:fs';
-import * as path from 'node:path';
-import * as os from 'node:os';
-import { acquireTrajectoryEvidenceFromDb } from '../../src/commands/build-trajectory-evidence.js';
-
-let tmpDir: string;
-
-function createWorkspace(): void {
-  tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pd-pain-record-parser-'));
-  const stateDir = path.join(tmpDir, '.state');
-  fs.mkdirSync(stateDir, { recursive: true });
-
-  const db = new Database(path.join(stateDir, 'trajectory.db'));
-  db.exec("CREATE TABLE IF NOT EXISTS sessions (session_id TEXT PRIMARY KEY, started_at TEXT, updated_at TEXT)");
-  db.exec("CREATE TABLE IF NOT EXISTS assistant_turns (id INTEGER PRIMARY KEY AUTOINCREMENT, session_id TEXT NOT NULL, sanitized_text TEXT, stop_reason TEXT, created_at TEXT NOT NULL)");
-  // PRI-783 lesson recorded on the fixture: user_turns MUST carry
-  // correction_cue — collectEvidenceFromDb SELECTs it, and a missing column
-  // silently degraded the user-turns read into evidence_read_failed, so this
-  // file's 'accepts --session' case never actually exercised a real evidence
-  // read (it vacuously asserted on a refusal).
-  db.exec("CREATE TABLE IF NOT EXISTS user_turns (id INTEGER PRIMARY KEY AUTOINCREMENT, session_id TEXT NOT NULL, raw_excerpt TEXT, correction_detected INTEGER NOT NULL DEFAULT 0, correction_cue TEXT, created_at TEXT NOT NULL)");
-  db.exec("CREATE TABLE IF NOT EXISTS tool_calls (id INTEGER PRIMARY KEY AUTOINCREMENT, session_id TEXT NOT NULL, tool_name TEXT NOT NULL, outcome TEXT NOT NULL, error_type TEXT, exit_code INTEGER, params_json TEXT NOT NULL DEFAULT '{}', result_preview TEXT, created_at TEXT NOT NULL)");
-  db.prepare('INSERT INTO sessions (session_id, started_at, updated_at) VALUES (?, ?, ?)')
-    .run('real-session-1', '2026-01-01T09:00:00Z', '2026-01-01T09:00:00Z');
-  db.prepare('INSERT INTO user_turns (session_id, raw_excerpt, correction_detected, created_at) VALUES (?, ?, ?, ?)')
-    .run('real-session-1', 'Please fix the output format', 1, '2026-01-01T09:59:00Z');
-  db.close();
-}
-
-interface CliRunResult {
-  status: number | null;
-  stdout: string;
-  stderr: string;
-}
-
-/** Resolves and boundary-validates the built pd CLI entry before spawning it. */
-async function resolveBuiltCliEntry(): Promise<string> {
-  const packageRoot = path.resolve(process.cwd());
-  const entry = path.resolve(packageRoot, 'dist', 'index.js');
-  if (!entry.startsWith(`${packageRoot}${path.sep}`) || !fs.statSync(entry).isFile()) {
-    throw new Error(`built pd CLI entry not found or outside the package: ${entry}`);
-  }
-  return entry;
-}
-
-async function runBuiltCli(literalArgv: readonly string[]): Promise<CliRunResult> {
-  const { execFile } = await import('node:child_process');
-  const execFileAsync = promisify(execFile);
-  const entry = await resolveBuiltCliEntry();
-  try {
-    const { stdout } = await execFileAsync(process.execPath, [entry, ...literalArgv], {
-      cwd: tmpDir,
-      timeout: 30000,
-      encoding: 'utf8',
-      env: { ...process.env, PD_WORKSPACE_DIR: tmpDir },
-    });
-    return { status: 0, stdout, stderr: '' };
-  } catch (err) {
-    const e = err as { code?: number; stdout?: string; stderr?: string };
-    return { status: e.code ?? -1, stdout: e.stdout ?? '', stderr: e.stderr ?? '' };
-  }
-}
-
-describe('pd pain record --session (real Commander + real trajectory.db)', () => {
-  beforeEach(() => {
-    createWorkspace();
-  });
-
-  afterEach(() => {
-    try {
-      fs.rmSync(tmpDir, { recursive: true, force: true });
-    } catch {
-      // ignore cleanup errors
-    }
-  });
-
-  it('--help registers and documents --session', async () => {
-    const result = await runBuiltCli(['pain', 'record', '--help']);
-    expect(result.status).toBe(0);
-    expect(result.stdout).toContain('--session');
-  }, 15_000);
-
-  it('PRI-743: --help registers --host with the openclaw|codex contract', async () => {
-    const result = await runBuiltCli(['pain', 'record', '--help']);
-    expect(result.status).toBe(0);
-    expect(result.stdout).toContain('--host <kind>');
-    // Commander wraps help text; normalize whitespace before asserting content.
-    const normalized = result.stdout.replace(/\s+/g, ' ');
-    expect(normalized).toContain('openclaw | codex');
-    expect(normalized).toContain('codex requires the real Codex lineage');
-  }, 15_000);
-
-  it('PRI-743: --help registers the Codex lineage flags used by --host codex', async () => {
-    const result = await runBuiltCli(['pain', 'record', '--help']);
-    expect(result.status).toBe(0);
-    expect(result.stdout).toContain('--rollout-id <id>');
-    expect(result.stdout).toContain('--host-turn-id <id>');
-    expect(result.stdout).toContain('--logical-key <key>');
-  }, 15_000);
-
-  it('PRI-743: --host codex without lineage exits non-zero with codex_lineage_required', async () => {
-    const result = await runBuiltCli([
-      'pain', 'record',
-      '--reason', 'parser test pain',
-      '--host', 'codex',
-      '--workspace', tmpDir,
-      '--json',
-    ]);
-
-    expect(result.status).not.toBe(0);
-    const parsed = JSON.parse(result.stdout.trim()) as Record<string, unknown>;
-    expect(parsed.status).toBe('failed');
-    expect(parsed.reason).toBe('codex_lineage_required');
-    expect(typeof parsed.nextAction).toBe('string');
-  }, 15_000);
-
-  it('PRI-743: an invalid --host value exits non-zero with a single structured JSON object', async () => {
-    const result = await runBuiltCli([
-      'pain', 'record',
-      '--reason', 'parser test pain',
-      '--host', 'claude',
-      '--workspace', tmpDir,
-      '--json',
-    ]);
-
-    expect(result.status).not.toBe(0);
-    const trimmed = result.stdout.trim();
-    const parsed = JSON.parse(trimmed) as Record<string, unknown>;
-    expect(parsed.status).toBe('failed');
-    expect(parsed.reason).toBe('invalid_host_kind');
-    expect(typeof parsed.nextAction).toBe('string');
-  }, 15_000);
-
-  it('fails with a single JSON object and reason session_not_found for a nonexistent session (SPEC 12.1.4)', async () => {
-    const result = await runBuiltCli([
-      'pain', 'record',
-      '--reason', 'parser test pain',
-      '--session', 'no-such-session',
-      '--workspace', tmpDir,
-      '--json',
-    ]);
-
-    // Failed validation exits non-zero.
-    expect(result.status).not.toBe(0);
-    // cli-1: stdout is exactly one JSON object.
-    const trimmed = result.stdout.trim();
-    expect(trimmed.length).toBeGreaterThan(0);
-    const parsed = JSON.parse(trimmed) as Record<string, unknown>;
-    expect(parsed.status).toBe('failed');
-    expect(parsed.reason).toBe('session_not_found');
-    expect(typeof parsed.nextAction).toBe('string');
-  }, 15_000);
-
-  it('accepts --session for a session that exists in the trajectory (real acquisition returns available evidence)', async () => {
-    // The spawned-CLI route is used above for the refusal contracts. The
-    // acceptance route ends in the diagnostician pipeline (out of this file's
-    // scope — the service has its own suite), so the acceptance boundary is
-    // asserted against the REAL acquisition function the CLI delegates to,
-    // over this file's real trajectory.db fixture (cli-7: real parser wiring
-    // is covered by the refusal spawns; real DB semantics here — PRI-783).
-    const stateDir = path.join(tmpDir, '.state');
-    const acquisition = acquireTrajectoryEvidenceFromDb(stateDir, 'real-session-1', tmpDir);
-
-    expect(acquisition.status).toBe('available');
-    if (acquisition.status !== 'available') return;
-    expect(acquisition.entries.length).toBeGreaterThanOrEqual(1);
-    expect(acquisition.entries.some(e => e.sourceRef.startsWith('owner_message:'))).toBe(true);
-  }, 15_000);
-
-  // ── PRI-783 review P1: unverified bindings must refuse, never persist ──────
-
-  it('locks the review P1: --session with a missing trajectory.db refuses and NEVER creates a db containing the fake id', async () => {
-    // Remove the fixture db so the id cannot be verified at all (the shared
-    // createWorkspace always seeds one). The run must fail loud
-    // (trajectory_unavailable) BEFORE any mutation — the observability writer
-    // must not create a trajectory.db and upsert the unverified id into
-    // sessions (self-proving loop).
-    fs.rmSync(path.join(tmpDir, '.state', 'trajectory.db'), { force: true });
-    const result = await runBuiltCli([
-      'pain', 'record',
-      '--reason', 'PRI-783 review P1 lock',
-      '--session', 'fake-unverified-id',
-      '--workspace', tmpDir,
-      '--json',
-    ]);
-
-    expect(result.status).not.toBe(0);
-    const parsed = JSON.parse(result.stdout.trim()) as Record<string, unknown>;
-    expect(parsed.status).toBe('failed');
-    expect(parsed.reason).toBe('trajectory_unavailable');
-    expect(parsed.nextAction).not.toMatch(/pd pain record --session/);
-    // The lock: no trajectory.db was created by this run — the fake id can
-    // never appear in a sessions table.
-    expect(fs.existsSync(path.join(tmpDir, '.state', 'trajectory.db'))).toBe(false);
-  }, 15_000);
-
-  it('real empty session reports empty_trajectory with a VERIFIED binding (the degrade precondition)', async () => {
-    // Gate the degrade path on the real acquisition semantics: a session
-    // row that exists with zero evidence rows is the only unavailable shape
-    // allowed to degrade to a bound submission.
-    const stateDir = path.join(tmpDir, '.state');
-    const db = new Database(path.join(stateDir, 'trajectory.db'));
-    db.prepare('INSERT INTO sessions (session_id, started_at, updated_at) VALUES (?, ?, ?)')
-      .run('real-empty-session', '2026-01-01T08:00:00Z', '2026-01-01T08:00:00Z');
-    db.prepare('INSERT INTO user_turns (session_id, raw_excerpt, correction_detected, correction_cue, created_at) VALUES (?, ?, ?, ?, ?)')
-      .run('real-empty-session', 'ordinary message, not a correction', 0, null, '2026-01-01T08:01:00Z');
-    db.close();
-
-    const acquisition = acquireTrajectoryEvidenceFromDb(stateDir, 'real-empty-session', tmpDir);
-
-    expect(acquisition.status).toBe('unavailable');
-    if (acquisition.status !== 'unavailable') return;
-    expect(acquisition.reasonCode).toBe('empty_trajectory');
-    expect(acquisition.binding).toBe('verified');
-  }, 15_000);
-});