@principles/pd-cli 1.152.12 → 1.152.13

package/src/legacy/legacy-import.ts

@@ -1,179 +0,0 @@
-/**
- * Legacy Compatibility Import — OpenClaw → PD Runtime v2
- *
- * ## Purpose
- *
- * This module is a **compatibility import path only**.
- * It is NOT the authoritative retrieval path for M3 queries.
- *
- * It syncs diagnostician task data from OpenClaw's legacy JSON-based stores
- * into the PD Runtime v2 SQLite store so that `pd trajectory`, `pd history`,
- * and `pd context` commands have data to query against.
- *
- * **Authoritative path**: `workspace/.pd/state.db` (PD-owned SQLite)
- * **This module's role**: migrate legacy `.state/diagnostician_tasks.json` →
- * `workspace/.pd/state.db` (one-way sync, idempotent)
- *
- * ## Sync Sources
- *
- *   - `.state/diagnostician_tasks.json`  →  tasks + runs tables
- *
- * ## Non-Goals
- *
- * This module does NOT:
- * - Query raw OpenClaw `.state/` files for primary retrieval
- * - Serve as the main path for trajectory/history/context commands
- * - Own any PD task semantics
- *
- * ## Usage
- *
- * Call `syncOpenClawWorkspace(workspaceDir, connection)` once to import,
- * then use `pd trajectory locate`, `pd history query`, `pd context build`
- * which read from `workspace/.pd/state.db` directly.
- *
- * Idempotent: safe to call multiple times. Re-syncs latest state on every call.
- */
-import * as fs from 'fs';
-import * as path from 'path';
-import type { SqliteConnection } from '@principles/core';
-
-interface OpenClawDiagnosticianTask {
-  prompt: string;
-  createdAt: string;
-  status: 'pending' | 'completed';
-  reportMissingRetries?: number;
-}
-
-interface OpenClawDiagnosticianStore {
-  tasks: Record<string, OpenClawDiagnosticianTask>;
-}
-
-interface ParsedTaskFields {
-  sessionId: string;
-  painScore: number;
-  painSource: string;
-  painReason: string;
-}
-
-function readDiagnosticianStore(stateDir: string): OpenClawDiagnosticianStore {
-  const filePath = path.join(stateDir, 'diagnostician_tasks.json');
-  if (!fs.existsSync(filePath)) {
-    return { tasks: {} };
-  }
-  try {
-    const raw = fs.readFileSync(filePath, 'utf-8');
-    const parsed = JSON.parse(raw);
-    if (parsed && typeof parsed.tasks === 'object' && parsed.tasks !== null && !Array.isArray(parsed.tasks)) {
-      return parsed as OpenClawDiagnosticianStore;
-    }
-    return { tasks: {} };
-  } catch {
-    return { tasks: {} };
-  }
-}
-
-function parsePrompt(taskId: string, prompt: string): ParsedTaskFields {
-  const sessionId =
-    /\*\*Session ID\*\*:\s*([^\n*]+)/.exec(prompt)?.[1]?.trim() ?? taskId;
-  const painScore =
-    parseInt(/\*\*Pain Score\*\*:\s*(\d+)/.exec(prompt)?.[1] ?? '0', 10);
-  const painSource =
-    /\*\*Source\*\*:\s*([^\n*]+)/.exec(prompt)?.[1]?.trim() ?? 'unknown';
-  const painReason =
-    /\*\*Reason\*\*:\s*([^\n*]+)/.exec(prompt)?.[1]?.trim() ?? '';
-
-  return { sessionId, painScore, painSource, painReason };
-}
-
-function painScoreToSeverity(score: number): string {
-  if (score >= 80) return 'critical';
-  if (score >= 60) return 'high';
-  if (score >= 40) return 'medium';
-  return 'low';
-}
-
-/**
- * Sync all openclaw diagnostician tasks into the PD Runtime v2 SQLite store.
- *
- * For each task in diagnostician_tasks.json:
- *   - Upsert into tasks table (base fields + diagnostic_json blob)
- *   - Upsert a corresponding synthetic run into runs table
- *
- * Idempotent: existing records are updated, not duplicated.
- */
-export async function syncOpenClawWorkspace(
-  workspaceDir: string,
-  connection: SqliteConnection,
-): Promise<{ tasksSynced: number; runsSynced: number }> {
-  const stateDir = path.join(workspaceDir, '.state');
-  const store = readDiagnosticianStore(stateDir);
-
-  const db = connection.getDb();
-  let tasksSynced = 0;
-  let runsSynced = 0;
-
-  const upsertTask = db.prepare(`
-    INSERT INTO tasks (task_id, task_kind, status, created_at, updated_at, attempt_count, max_attempts, diagnostic_json)
-    VALUES (@taskId, 'diagnostician', @status, @createdAt, @updatedAt, 0, 3, @diagnosticJson)
-    ON CONFLICT(task_id) DO UPDATE SET
-      status = @status,
-      updated_at = @updatedAt,
-      diagnostic_json = @diagnosticJson
-  `);
-
-  const upsertRun = db.prepare(`
-    INSERT INTO runs (run_id, task_id, runtime_kind, execution_status, started_at, ended_at, attempt_number, created_at, updated_at)
-    VALUES (@runId, @taskId, 'openclaw', @executionStatus, @startedAt, @endedAt, 1, @createdAt, @updatedAt)
-    ON CONFLICT(run_id) DO UPDATE SET
-      execution_status = @executionStatus,
-      ended_at = @endedAt,
-      updated_at = @updatedAt
-  `);
-
-  const now = new Date().toISOString();
-
-  for (const [taskId, task] of Object.entries(store.tasks)) {
-    const { sessionId, painScore, painSource, painReason } = parsePrompt(taskId, task.prompt);
-
-    const status =
-      task.status === 'pending'
-        ? 'pending'
-        : task.status === 'completed'
-          ? 'succeeded'
-          : 'failed';
-
-    const severity = painScoreToSeverity(painScore);
-    const reasonSummary = painReason.length > 200 ? painReason.substring(0, 197) + '...' : painReason;
-
-    const diagnosticJson = JSON.stringify({
-      workspaceDir,
-      reasonSummary,
-      source: painSource,
-      severity,
-      sessionIdHint: sessionId !== taskId ? sessionId : null,
-    });
-
-    upsertTask.run({
-      taskId,
-      status,
-      createdAt: task.createdAt,
-      updatedAt: now,
-      diagnosticJson,
-    });
-    tasksSynced++;
-
-    const runId = `run_${taskId}_1`;
-    upsertRun.run({
-      runId,
-      taskId,
-      executionStatus: status === 'pending' ? 'queued' : 'succeeded',
-      startedAt: task.createdAt,
-      endedAt: status !== 'pending' ? now : null,
-      createdAt: task.createdAt,
-      updatedAt: now,
-    });
-    runsSynced++;
-  }
-
-  return { tasksSynced, runsSynced };
-}

package/src/legacy/session-history-import.ts

@@ -1,203 +0,0 @@
-/**
- * Session History Import — OpenClaw trajectory.db → PD Runtime v2
- *
- * Reads real conversation history from OpenClaw's trajectory.db and imports
- * assistant_turns, user_turns, and tool_calls into PD-owned runtime-v2 runs table
- * so that `pd history query` and `pd context build` return non-empty results.
- *
- * This is a COMPATIBILITY IMPORT — not authoritative retrieval.
- * Primary retrieval always goes through `.pd/state.db` only.
- */
-import Database from 'better-sqlite3';
-import * as path from 'path';
-
-interface OpenClawTrajectoryDb {
-  getAssistantTurns(sessionId: string): AssistantTurn[];
-  getUserTurns(sessionId: string): UserTurn[];
-  getToolCalls(sessionId: string): ToolCall[];
-  getSessionIds(): string[];
-}
-
-interface AssistantTurn {
-  id: number;
-  session_id: string;
-  run_id: string;
-  provider: string;
-  model: string;
-  sanitized_text: string;
-  created_at: string;
-}
-
-interface UserTurn {
-  id: number;
-  session_id: string;
-  turn_index: number;
-  raw_text: string;
-  created_at: string;
-}
-
-interface ToolCall {
-  id: number;
-  session_id: string;
-  tool_name: string;
-  outcome: string;
-  duration_ms: number | null;
-  exit_code: number | null;
-  error_type: string | null;
-  error_message: string | null;
-  created_at: string;
-}
-
-function openTrajectoryDb(dbPath: string): OpenClawTrajectoryDb {
-  const db = new Database(dbPath, { readonly: true });
-
-  return {
-    getAssistantTurns(sessionId: string): AssistantTurn[] {
-      return db
-        .prepare(
-          'SELECT id, session_id, run_id, provider, model, sanitized_text, created_at ' +
-            'FROM assistant_turns WHERE session_id = ? ORDER BY id ASC',
-        )
-        .all(sessionId) as AssistantTurn[];
-    },
-
-    getUserTurns(sessionId: string): UserTurn[] {
-      return db
-        .prepare(
-          'SELECT id, session_id, turn_index, raw_text, created_at ' +
-            'FROM user_turns WHERE session_id = ? ORDER BY id ASC',
-        )
-        .all(sessionId) as UserTurn[];
-    },
-
-    getToolCalls(sessionId: string): ToolCall[] {
-      return db
-        .prepare(
-          'SELECT id, session_id, tool_name, outcome, duration_ms, exit_code, ' +
-            'error_type, error_message, created_at ' +
-            'FROM tool_calls WHERE session_id = ? ORDER BY id ASC',
-        )
-        .all(sessionId) as ToolCall[];
-    },
-
-    getSessionIds(): string[] {
-      return (
-        db.prepare('SELECT session_id FROM sessions ORDER BY started_at DESC').all() as {
-          session_id: string;
-        }[]
-      ).map((r) => r.session_id);
-    },
-  };
-}
-
-/**
- * Import session history from OpenClaw trajectory.db into PD runtime-v2 runs table.
- *
- * For each task that has a sessionIdHint in its diagnostic_json:
- *   1. Look up the session in trajectory.db
- *   2. Import assistant_turns, user_turns, tool_calls as entries
- *   3. Upsert into runs table with full payload (JSON string)
- *
- * Idempotent: updates existing run records, does not duplicate.
- */
-export async function importSessionHistory(
-  openclawWorkspaceDir: string,
-  pdWorkspaceDir: string,
-  getDb: () => Database.Database,
-): Promise<{ sessionsProcessed: number; entriesImported: number }> {
-  const trajectoryPath = path.join(openclawWorkspaceDir, '.state', 'trajectory.db');
-  const trajectoryDb = openTrajectoryDb(trajectoryPath);
-  const db = getDb();
-
-  // Find all tasks with a sessionIdHint
-  const tasksWithSession = db
-    .prepare(
-      `SELECT task_id, json_extract(diagnostic_json, '$.sessionIdHint') as session_id
-       FROM tasks
-       WHERE json_extract(diagnostic_json, '$.sessionIdHint') IS NOT NULL
-         AND json_extract(diagnostic_json, '$.sessionIdHint') != ''`,
-    )
-    .all() as { task_id: string; session_id: string }[];
-
-  let sessionsProcessed = 0;
-  let entriesImported = 0;
-
-  const upsertRun = db.prepare(`
-    INSERT INTO runs (run_id, task_id, runtime_kind, execution_status, started_at, ended_at,
-      attempt_number, created_at, updated_at, input_payload, output_payload)
-    VALUES (@runId, @taskId, 'openclaw-history', @executionStatus, @startedAt, @endedAt,
-      1, @createdAt, @updatedAt, @inputPayload, @outputPayload)
-    ON CONFLICT(run_id) DO UPDATE SET
-      input_payload = @inputPayload,
-      output_payload = @outputPayload,
-      ended_at = @endedAt,
-      updated_at = @updatedAt
-  `);
-
-  const now = new Date().toISOString();
-
-  for (const { task_id, session_id } of tasksWithSession) {
-    // Verify session exists in trajectory.db
-    const assistantTurns = trajectoryDb.getAssistantTurns(session_id);
-    if (assistantTurns.length === 0) continue;
-
-    const userTurns = trajectoryDb.getUserTurns(session_id);
-    const toolCalls = trajectoryDb.getToolCalls(session_id);
-
-    // Use the latest timestamp from the session as ended_at
-    const [firstTurn] = assistantTurns;
-    const lastTurn = assistantTurns[assistantTurns.length - 1];
-    if (!firstTurn || !lastTurn) continue;
-    const lastTimestamp = lastTurn.created_at;
-
-    // Build input (user turns + tool calls) and output (assistant turns) payloads
-    const inputPayload = JSON.stringify({
-      type: 'session_history',
-      sessionId: session_id,
-      userTurns: userTurns.map((t) => ({
-        turnIndex: t.turn_index,
-        text: t.raw_text,
-        ts: t.created_at,
-      })),
-      toolCalls: toolCalls.map((t) => ({
-        toolName: t.tool_name,
-        outcome: t.outcome,
-        durationMs: t.duration_ms,
-        exitCode: t.exit_code,
-        errorType: t.error_type,
-        errorMessage: t.error_message,
-        ts: t.created_at,
-      })),
-    });
-
-    const outputPayload = JSON.stringify({
-      type: 'assistant_turns',
-      sessionId: session_id,
-      turns: assistantTurns.map((t) => ({
-        provider: t.provider,
-        model: t.model,
-        text: t.sanitized_text,
-        ts: t.created_at,
-      })),
-    });
-
-    const runId = `run_${task_id}_history_1`;
-
-    upsertRun.run({
-      runId,
-      taskId: task_id,
-      executionStatus: 'succeeded',
-      startedAt: firstTurn.created_at,
-      endedAt: lastTimestamp,
-      createdAt: firstTurn.created_at,
-      updatedAt: now,
-      inputPayload,
-      outputPayload,
-    });
-
-    entriesImported += assistantTurns.length + userTurns.length + toolCalls.length;
-    sessionsProcessed++;
-  }
-
-  return { sessionsProcessed, entriesImported };
-}

package/src/resolve-workspace.ts

@@ -1,106 +0,0 @@
-/**
- * Resolve the active workspace directory.
- *
- * Resolution chain (highest priority first):
- * 1. Explicit --workspace flag
- * 2. PD_WORKSPACE_DIR environment variable
- * 3. workspace.default from discovered .pd/config.yaml
- * 4. Throw Error (preserve current behavior for unconfigured setups)
- *
- * When the resolved path differs from workspace.default in config,
- * a warning is emitted to stderr.
- *
- * @throws Error if no workspace directory can be determined.
- */
-
-import * as path from 'path';
-import { discoverWorkspaceDefault } from './services/pd-config-loader.js';
-import { assertSafeDirectoryRoot } from './utils/path-security.js';
-
-/** Environment variable name for workspace directory. */
-export const WORKSPACE_ENV = 'PD_WORKSPACE_DIR';
-
-// ── Internal helpers ────────────────────────────────────────────────────────
-
-/**
- * Normalize a path to forward slashes for cross-platform string comparison.
- *
- * Comparison-only helper: it never resolves against the filesystem and never
- * feeds a filesystem operation, so it intentionally uses `path.normalize`
- * (pure string normalization) instead of `path.resolve`. Callers compare two
- * paths for equality after normalization; the workspace root itself is
- * validated by `assertWorkspaceDirInside` before any IO uses it.
- */
-function normalizePath(p: string): string {
-  return path.normalize(p).replace(/\\/g, '/');
-}
-
-/** Emit workspace warnings to stderr. */
-function emitWarning(msg: string): void {
-  process.stderr.write(`[PD:workspace] WARNING: ${msg}\n`);
-}
-
-/**
- * Validate an operator-supplied workspace root before it is used as an IO
- * root. Delegates to the shared canonical-root validator (empty, parent
- * traversal, filesystem root). Returns nothing; callers keep the original
- * value so downstream resolution semantics are unchanged.
- */
-function assertWorkspaceDirInside(p: string, source: string): void {
-  assertSafeDirectoryRoot(p, source);
-}
-
-/** Emit a warning when an explicit override differs from config default. */
-function emitWarningIfDiffers(
-  override: string,
-  configDefault: string | undefined,
-  discovered: { configPath?: string } | null,
-): void {
-  if (configDefault && normalizePath(override) !== normalizePath(configDefault)) {
-    emitWarning(
-      `"${override}" differs from config default "${configDefault}" ` +
-        `(source: ${discovered?.configPath}). Using explicit override. ` +
-        `Consider updating workspace.default in config.`,
-    );
-  }
-}
-
-// ── Public API ──────────────────────────────────────────────────────────────
-
-/**
- * Resolve the active workspace directory.
- *
- * API surface: `(workspaceDir?: string): string`
- * All 13 command files and 20 test mocks rely on this exact signature.
- */
-export function resolveWorkspaceDir(workspaceDir?: string): string {
-  // Step 1: Discover config-based default (runs always for warning comparison)
-  const discovered = discoverWorkspaceDefault();
-  const configDefault = discovered?.workspaceDefault;
-
-  // Step 2: Check --workspace flag (highest priority)
-  if (workspaceDir) {
-    assertWorkspaceDirInside(workspaceDir, '--workspace');
-    emitWarningIfDiffers(workspaceDir, configDefault, discovered);
-    return workspaceDir;
-  }
-
-  // Step 3: Check PD_WORKSPACE_DIR env var
-  const envWorkspace = process.env.PD_WORKSPACE_DIR?.trim();
-  if (envWorkspace) {
-    assertWorkspaceDirInside(envWorkspace, WORKSPACE_ENV);
-    emitWarningIfDiffers(envWorkspace, configDefault, discovered);
-    return envWorkspace;
-  }
-
-  // Step 4: Use discovered config default
-  if (configDefault) {
-    assertWorkspaceDirInside(configDefault, 'workspace.default');
-    return configDefault;
-  }
-  // Step 5: No resolution possible — throw (preserves current behavior)
-  throw new Error(
-    'No workspace directory configured. Set --workspace <path>, ' +
-    'PD_WORKSPACE_DIR environment variable, or add workspace.default to .pd/config.yaml.',
-  );
-}

package/src/services/__tests__/cli-output.test.ts

@@ -1,130 +0,0 @@
-/**
- * PRI-432: Tests for shared CLI output module.
- *
- * Extracts common output patterns from:
- *   - runtime-features.ts (JSON/text emit + exit code)
- *   - runtime-recovery.ts (dry-run/confirm conflict + JSON/text emit)
- *   - runtime-internalization-integrity-repair.ts (conflict + error catch + JSON/text emit)
- *
- * TDD flow: these tests are RED until cli-output.ts is implemented.
- *
- * ERR refs:
- * - ERR-001 (no any): all types explicit
- * - ERR-005 (no as bypass): no type casts
- * - ERR-009 (fail-loud): emitError returns exit code, does not swallow
- * - ERR-002 (graceful degradation with reason): all error paths include reason + nextAction
- */
-
-import { describe, it, expect, beforeEach, vi } from 'vitest';
-
-const { emitResult, emitFlagConflict, emitError } = await import('../cli-output.js');
-
-describe('cli-output module (PRI-432)', () => {
-  let consoleLogSpy: ReturnType<typeof vi.spyOn>;
-  let consoleErrorSpy: ReturnType<typeof vi.spyOn>;
-
-  beforeEach(() => {
-    vi.clearAllMocks();
-    consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => undefined);
-    consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => undefined);
-  });
-
-  // ── emitResult ──────────────────────────────────────────────────────────
-
-  describe('emitResult', () => {
-    it('emits JSON to stdout when json=true', () => {
-      const output = { status: 'ok', count: 5 };
-      const formatText = (o: typeof output) => `Status: ${o.status}`;
-
-      emitResult(output, { json: true, formatText });
-
-      expect(consoleLogSpy).toHaveBeenCalledTimes(1);
-      const emitted = JSON.parse(consoleLogSpy.mock.calls[0][0] as string);
-      expect(emitted).toEqual(output);
-    });
-
-    it('emits text to stdout when json=false', () => {
-      const output = { status: 'ok', count: 5 };
-      const formatText = (o: typeof output) => `Status: ${o.status}`;
-
-      emitResult(output, { json: false, formatText });
-
-      expect(consoleLogSpy).toHaveBeenCalledWith('Status: ok');
-    });
-
-    it('uses formatText callback for text output', () => {
-      const output = { status: 'failed', reason: 'bad config' };
-      const formatText = (o: typeof output) => `ERROR: ${o.reason}`;
-
-      emitResult(output, { json: false, formatText });
-
-      expect(consoleLogSpy).toHaveBeenCalledWith('ERROR: bad config');
-    });
-  });
-
-  // ── emitFlagConflict ────────────────────────────────────────────────────
-
-  describe('emitFlagConflict', () => {
-    it('emits JSON error to stdout when json=true', () => {
-      const exitCode = emitFlagConflict({ json: true });
-
-      expect(exitCode).toBe(1);
-      expect(consoleLogSpy).toHaveBeenCalledTimes(1);
-      const emitted = JSON.parse(consoleLogSpy.mock.calls[0][0] as string);
-      expect(emitted.ok).toBe(false);
-      expect(emitted.reason).toContain('mutually exclusive');
-      expect(emitted.nextAction).toContain('--dry-run');
-    });
-
-    it('emits text error to stderr when json=false', () => {
-      const exitCode = emitFlagConflict({ json: false });
-
-      expect(exitCode).toBe(1);
-      expect(consoleErrorSpy).toHaveBeenCalledTimes(1);
-      const msg = consoleErrorSpy.mock.calls[0][0] as string;
-      expect(msg).toContain('mutually exclusive');
-    });
-
-    it('always returns exit code 1', () => {
-      expect(emitFlagConflict({ json: true })).toBe(1);
-      expect(emitFlagConflict({ json: false })).toBe(1);
-    });
-  });
-
-  // ── emitError ───────────────────────────────────────────────────────────
-
-  describe('emitError', () => {
-    it('emits JSON error to stdout when json=true', () => {
-      const err = new Error('DB connection failed');
-      const exitCode = emitError(err, { json: true, nextAction: 'Check DB connectivity' });
-
-      expect(exitCode).toBe(1);
-      expect(consoleLogSpy).toHaveBeenCalledTimes(1);
-      const emitted = JSON.parse(consoleLogSpy.mock.calls[0][0] as string);
-      expect(emitted.ok).toBe(false);
-      expect(emitted.reason).toBe('DB connection failed');
-      expect(emitted.nextAction).toBe('Check DB connectivity');
-    });
-
-    it('emits text error to stderr when json=false', () => {
-      const err = new Error('DB connection failed');
-      const exitCode = emitError(err, { json: false, nextAction: 'Check DB connectivity' });
-
-      expect(exitCode).toBe(1);
-      expect(consoleErrorSpy).toHaveBeenCalledWith('Error: DB connection failed');
-    });
-
-    it('handles non-Error throwables via String()', () => {
-      const exitCode = emitError('string error', { json: true, nextAction: 'retry' });
-
-      expect(exitCode).toBe(1);
-      const emitted = JSON.parse(consoleLogSpy.mock.calls[0][0] as string);
-      expect(emitted.reason).toBe('string error');
-    });
-
-    it('always returns exit code 1', () => {
-      expect(emitError(new Error('x'), { json: true, nextAction: 'y' })).toBe(1);
-      expect(emitError(new Error('x'), { json: false, nextAction: 'y' })).toBe(1);
-    });
-  });
-});