@principles/pd-cli 1.152.12 → 1.152.13

package/tests/bdd/cli-contract.steps.ts

@@ -1,346 +0,0 @@
-/**
- * BDD step definitions for CLI strict JSON output contract (cli-1-strict-json).
- *
- * Approach: Command + mocks (NOT real CLI subprocess execution).
- * Reuses the exact same mock pattern as tests/commands/pain-retry.test.ts:
- *   - vi.hoisted() + vi.mock() to stub @principles/core/runtime-v2 and friends
- *   - Import handlePainRetry directly and call it in-process
- *   - Capture console.log via vi.spyOn to verify stdout JSON contract
- *
- * Rationale: pd pain retry needs a real workspace + pain-id + config to execute
- * as a subprocess. Testing the JSON output contract in-process with mocks is
- * more reliable and follows the established pattern in this repo.
- */
-import { vi, expect } from 'vitest';
-import { Command } from 'commander';
-import { readFileSync } from 'node:fs';
-import { createStepRegistry, defineFeature } from './support/vitest-bdd.js';
-import { resolveFeaturePath } from './support/repo-root.js';
-
-// ── Mocks (mirrors tests/commands/pain-retry.test.ts) ──────────────────────────
-
-const {
-  MockRuntimeStateManager,
-  mockGetTask,
-  mockGetCandidatesByTaskId,
-  mockUpdateCandidateStatus,
-  mockGetRunsByTask,
-} = vi.hoisted(() => {
-  const mockGetTask = vi.fn().mockResolvedValue(null);
-  const mockGetCandidatesByTaskId = vi.fn().mockResolvedValue([]);
-  const mockUpdateCandidateStatus = vi.fn().mockResolvedValue(undefined);
-  const mockGetRunsByTask = vi.fn().mockResolvedValue([]);
-
-  class MockRuntimeStateManager {
-    initialize = vi.fn().mockResolvedValue(undefined);
-    close = vi.fn().mockResolvedValue(undefined);
-    getTask = mockGetTask;
-    getCandidatesByTaskId = mockGetCandidatesByTaskId;
-    updateCandidateStatus = mockUpdateCandidateStatus;
-    getRunsByTask = mockGetRunsByTask;
-    connection = {} as Record<string, unknown>;
-    taskStore = {};
-    runStore = {};
-  }
-  return {
-    MockRuntimeStateManager,
-    mockGetTask,
-    mockGetCandidatesByTaskId,
-    mockUpdateCandidateStatus,
-    mockGetRunsByTask,
-  };
-}, { validateType: true });
-
-const { mockIntake, MockCandidateIntakeService } = vi.hoisted(() => {
-  const mockIntake = vi.fn();
-  function MockCandidateIntakeService(this: unknown) {
-    return { intake: mockIntake };
-  }
-  MockCandidateIntakeService.prototype = {};
-  return { mockIntake, MockCandidateIntakeService };
-});
-
-const { MockPrincipleTreeLedgerAdapter } = vi.hoisted(() => {
-  function MockPrincipleTreeLedgerAdapter(this: unknown) {
-    return {};
-  }
-  MockPrincipleTreeLedgerAdapter.prototype = {};
-  return { MockPrincipleTreeLedgerAdapter };
-});
-
-const { mockRun, mockResolveRuntimeConfig, mockResolveRuntimeFromPdConfig } = vi.hoisted(() => {
-  const mockRun = vi.fn().mockResolvedValue({
-    status: 'succeeded',
-    taskId: 'diagnosis_test-pain-1',
-    runId: 'run-retry-1',
-    contextHash: 'abc123',
-  });
-  const mockResolveRuntimeConfig = vi.fn().mockReturnValue({
-    runtimeKind: 'pi-ai',
-    provider: 'test-provider',
-    model: 'test-model',
-    apiKeyEnv: 'TEST_KEY',
-    timeoutMs: 300000,
-    agentId: 'main',
-  });
-  const mockResolveRuntimeFromPdConfig = vi.fn().mockReturnValue({
-    result: {
-      runtimeKind: 'pi-ai',
-      provider: 'test-provider',
-      model: 'test-model',
-      apiKeyEnv: 'TEST_KEY',
-      timeoutMs: 300000,
-      agentId: 'main',
-    },
-    legacyWarnings: [],
-    configSource: '.pd/config.yaml',
-    configLoadResult: { ok: true, effective: {}, defaults: {}, legacyFilesDetected: [] },
-  });
-  return { mockRun, mockResolveRuntimeConfig, mockResolveRuntimeFromPdConfig };
-});
-
-vi.mock('../../src/resolve-workspace.js', () => ({
-  resolveWorkspaceDir: vi.fn().mockReturnValue('/tmp/fake-workspace'),
-}));
-
-vi.mock('@principles/core/runtime-v2', () => {
-  return {
-    RuntimeStateManager: vi.fn().mockImplementation(function () {
-      return new MockRuntimeStateManager();
-    }),
-    SqliteHistoryQuery: vi.fn().mockImplementation(function () { return {}; }),
-    SqliteContextAssembler: vi.fn().mockImplementation(function () { return {}; }),
-    SqliteDiagnosticianCommitter: vi.fn().mockImplementation(function () { return {}; }),
-    SqliteTrajectoryLocator: vi.fn().mockImplementation(function () { return {}; }),
-    SqliteSourceTraceLocator: vi.fn().mockImplementation(function () { return {}; }),
-    // Dead-letter store mock: getByPainId returns null so the implementation
-    // produces status='not_found' with reason='task_not_found' for the
-    // "失败命令的 --json 输出含 reason 和 nextAction" scenario.
-    SqliteDeadLetterStore: vi.fn().mockImplementation(function () {
-      return { getByPainId: vi.fn().mockReturnValue(null) };
-    }),
-    PainSignalBridge: vi.fn().mockImplementation(function () { return {}; }),
-    StoreEventEmitter: vi.fn().mockImplementation(function () { return {}; }),
-    storeEmitter: { emitTelemetry: vi.fn() },
-    SplitDiagnosticianRunner: vi.fn().mockImplementation(function () { return {}; }),
-    DiagRootCauseRunner: vi.fn().mockImplementation(function () { return {}; }),
-    DiagDistillerRunner: vi.fn().mockImplementation(function () { return {}; }),
-    DiagRouterRunner: vi.fn().mockImplementation(function () { return {}; }),
-    DefaultDiagRootCauseValidator: vi.fn().mockImplementation(function () { return {}; }),
-    DefaultDiagDistillerValidator: vi.fn().mockImplementation(function () { return {}; }),
-    DisabledDiagnosticianRunner: vi.fn().mockImplementation(function () { return {}; }),
-    TestDoubleRuntimeAdapter: vi.fn().mockImplementation(function () { return {}; }),
-    OpenClawCliRuntimeAdapter: vi.fn().mockImplementation(function () { return {}; }),
-    PiAiRuntimeAdapter: vi.fn().mockImplementation(function () { return {}; }),
-    SPLIT_PIPELINE_TOTAL_TIMEOUT_MS: 300000,
-    // PRI-638: capability gate — available by default so the BDD scenarios
-    // exercise the pre-existing success/failure JSON contracts unchanged.
-    resolveDiagnosticianCapability: vi.fn(() => ({ available: true })),
-    PDRuntimeError: class PDRuntimeError extends Error {
-      constructor(public category: string, message: string) {
-        super(message);
-        this.name = 'PDRuntimeError';
-      }
-    },
-    CandidateIntakeService: MockCandidateIntakeService,
-    resolveRuntimeConfig: mockResolveRuntimeConfig,
-    isRuntimeConfigError: vi.fn().mockReturnValue(false),
-    isFeatureEnabled: vi.fn().mockReturnValue(true),
-    resolveOutputLanguage: vi.fn().mockReturnValue({ outputLanguage: 'zh-CN' }),
-    validatePdConfig: vi.fn().mockReturnValue({ valid: true, errors: [] }),
-    computeEffectivePdConfig: vi.fn().mockReturnValue({ config: {}, source: 'defaults', warnings: [] }),
-    computeFeatureFlagsFromConfig: vi.fn().mockReturnValue({}),
-    redactPdConfig: vi.fn().mockImplementation((c) => c),
-    run: mockRun,
-    status: vi.fn(),
-    PrincipleTreeLedgerAdapter: MockPrincipleTreeLedgerAdapter,
-  };
-});
-
-vi.mock('../../src/config-reader.js', () => ({
-  readOutputLanguageFromWorkspace: vi.fn().mockReturnValue({ outputLanguage: 'zh-CN' }),
-}));
-
-vi.mock('../../src/services/resolve-runtime-from-pd-config.js', () => ({
-  resolveRuntimeFromPdConfig: mockResolveRuntimeFromPdConfig,
-}));
-
-import { registerPainRetryCommand } from '../../src/commands/pain-retry.js';
-
-// ── Test data ──────────────────────────────────────────────────────────────────
-
-const RETRY_WAIT_TASK = {
-  taskId: 'diagnosis_pain-001',
-  taskKind: 'diagnostician',
-  status: 'retry_wait' as const,
-  attemptCount: 1,
-  maxAttempts: 3,
-  lastError: 'output_invalid',
-  leaseOwner: null,
-  leaseExpiresAt: null,
-  resultRef: null,
-  createdAt: new Date().toISOString(),
-  updatedAt: new Date().toISOString(),
-};
-
-// ── Helpers ────────────────────────────────────────────────────────────────────
-
-/** Reset all mocks to a clean default state for the next scenario. */
-function resetMocksForScenario(painId: string): void {
-  vi.clearAllMocks();
-
-  mockResolveRuntimeConfig.mockReturnValue({
-    runtimeKind: 'pi-ai',
-    provider: 'test-provider',
-    model: 'test-model',
-    apiKeyEnv: 'TEST_KEY',
-    timeoutMs: 300000,
-    agentId: 'main',
-  });
-  mockResolveRuntimeFromPdConfig.mockReturnValue({
-    result: {
-      runtimeKind: 'pi-ai',
-      provider: 'test-provider',
-      model: 'test-model',
-      apiKeyEnv: 'TEST_KEY',
-      timeoutMs: 300000,
-      agentId: 'main',
-    },
-    legacyWarnings: [],
-    configSource: '.pd/config.yaml',
-    configLoadResult: { ok: true, effective: {}, defaults: {}, legacyFilesDetected: [] },
-  });
-  mockGetCandidatesByTaskId.mockResolvedValue([]);
-  mockUpdateCandidateStatus.mockResolvedValue(undefined);
-  mockGetRunsByTask.mockResolvedValue([]);
-  mockIntake.mockReset();
-
-  if (painId === 'nonexistent') {
-    // Failure scenario: task not found
-    mockGetTask.mockResolvedValue(null);
-  } else {
-    // Success scenario: retry_wait task → succeeded
-    mockGetTask.mockResolvedValue({
-      ...RETRY_WAIT_TASK,
-      taskId: `diagnosis_${painId}`,
-    });
-    mockRun.mockResolvedValue({
-      status: 'succeeded',
-      taskId: `diagnosis_${painId}`,
-      runId: 'run-retry-1',
-      contextHash: 'abc123',
-    });
-  }
-}
-
-// ── Step definitions ───────────────────────────────────────────────────────────
-
-const registry = createStepRegistry();
-
-registry.given('一个可用的 pd-cli 可执行文件', () => {
-  if (typeof registerPainRetryCommand !== 'function') {
-    throw new Error('pd-cli pain retry registration not available');
-  }
-});
-
-registry.when(/operator 执行 "(.+)"/, async (ctx, command: string) => {
-  const argv = command.trim().split(/\s+/);
-  if (argv.shift() !== 'pd') {
-    throw new Error(`expected command to start with pd: ${command}`);
-  }
-  const painIdIndex = argv.indexOf('--pain-id');
-  const painId = painIdIndex >= 0 ? argv[painIdIndex + 1] : '';
-  resetMocksForScenario(painId);
-
-  const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
-  const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
-  const exitSpy = vi.spyOn(process, 'exit').mockImplementation((() => undefined) as () => never);
-
-  try {
-    const program = new Command().name('pd').exitOverride();
-    registerPainRetryCommand(program.command('pain'));
-    await program.parseAsync(['node', 'pd', ...argv]);
-  } finally {
-    expect(exitSpy).not.toHaveBeenCalledWith(0);
-  }
-
-  const allLogCalls = logSpy.mock.calls.map((c) => String(c[0]));
-  const jsonCall = allLogCalls.find((s) => {
-    try { JSON.parse(s); return true; } catch { return false; }
-  });
-  // cli-1: 统计 stdout 上可解析为 JSON 的调用数，用于 Then 步骤验证"恰好一个"
-  const jsonCallCount = allLogCalls.filter((s) => {
-    try { JSON.parse(s); return true; } catch { return false; }
-  }).length;
-  const stdout = allLogCalls.join('\n');
-  const stderr = errorSpy.mock.calls.map((c) => String(c[0])).join('\n');
-  ctx.state.cliResult = { stdout, stderr, jsonCallCount, allLogCallCount: allLogCalls.length };
-
-  // Restore spies so Then steps don't capture new calls
-  logSpy.mockRestore();
-  errorSpy.mockRestore();
-  exitSpy.mockRestore();
-});
-
-registry.then('stdout 是严格的单一 JSON 对象', (ctx) => {
-  const result = ctx.state.cliResult as {
-    stdout: string;
-    jsonCallCount: number;
-    allLogCallCount: number;
-  };
-  const out = result.stdout.trim();
-  // Must start with { and parse as a non-null object
-  expect(out.startsWith('{')).toBe(true);
-  const parsed = JSON.parse(out);
-  expect(typeof parsed).toBe('object');
-  expect(parsed).not.toBeNull();
-  expect(result.allLogCallCount).toBe(1);
-  expect(result.jsonCallCount).toBe(1);
-});
-
-registry.then('该 JSON 对象可以被 JSON.parse 解析', (ctx) => {
-  const result = ctx.state.cliResult as { stdout: string };
-  expect(() => JSON.parse(result.stdout.trim())).not.toThrow();
-});
-
-registry.then('stdout 不包含任何 banner 或 heading', (ctx) => {
-  const result = ctx.state.cliResult as { stdout: string };
-  const out = result.stdout.trim();
-  expect(out.startsWith('===')).toBe(false);
-  expect(out.startsWith('#')).toBe(false);
-  expect(out.startsWith('PD CLI')).toBe(false);
-  expect(out.startsWith('pd ')).toBe(false);
-  // Strict JSON output must start with {
-  expect(out.startsWith('{')).toBe(true);
-});
-
-registry.then('该 JSON 对象的 status 字段表示失败', (ctx) => {
-  const result = ctx.state.cliResult as { stdout: string };
-  const parsed = JSON.parse(result.stdout.trim());
-  expect(parsed).toHaveProperty('status');
-  expect(parsed.status).not.toBe('succeeded');
-});
-
-registry.then('该 JSON 对象包含 reason 字段', (ctx) => {
-  const result = ctx.state.cliResult as { stdout: string };
-  const parsed = JSON.parse(result.stdout.trim());
-  expect(parsed).toHaveProperty('reason');
-  expect(typeof parsed.reason).toBe('string');
-  expect(parsed.reason.length).toBeGreaterThan(0);
-});
-
-registry.then('该 JSON 对象包含 nextAction 字段', (ctx) => {
-  const result = ctx.state.cliResult as { stdout: string };
-  const parsed = JSON.parse(result.stdout.trim());
-  expect(parsed).toHaveProperty('nextAction');
-  expect(typeof parsed.nextAction).toBe('string');
-  expect(parsed.nextAction.length).toBeGreaterThan(0);
-});
-
-// ── Load and register feature ──────────────────────────────────────────────────
-
-const featureText = readFileSync(
-  resolveFeaturePath('docs/specs/features/cli/json-output.feature'),
-  'utf8'
-);
-defineFeature(featureText, registry);

package/tests/bdd/principles-stats.steps.ts

@@ -1,211 +0,0 @@
-/**
- * BDD step definitions for `pd principles stats` (PRI-562 Phase 0,
- * cli-1/cli-5/cli-6 contract).
- *
- * Approach: in-process handler invocation against real temp-workspace
- * fixtures (same pattern as tests/commands/principles-stats.test.ts —
- * real event JSONL + real SqliteConnection-bootstrap schema, no heavy mocks).
- *
- * @see docs/specs/features/cli/principles-stats.feature
- */
-import { vi, expect } from 'vitest';
-import * as fs from 'fs';
-import * as os from 'os';
-import * as path from 'path';
-import Database from 'better-sqlite3';
-import { SqliteConnection } from '@principles/core';
-import { readFileSync } from 'node:fs';
-import { createStepRegistry, defineFeature } from './support/vitest-bdd.js';
-import { resolveFeaturePath } from './support/repo-root.js';
-import { handlePrinciplesStats } from '../../src/commands/principles-stats.js';
-
-const registry = createStepRegistry();
-
-interface WsState {
-  ws?: string;
-  dbBytesBefore?: Buffer;
-  ledgerRowsBefore?: number;
-}
-
-const state: WsState = {};
-
-function localDateString(d: Date): string {
-  const y = d.getFullYear();
-  const m = String(d.getMonth() + 1).padStart(2, '0');
-  const day = String(d.getDate()).padStart(2, '0');
-  return `${y}-${m}-${day}`;
-}
-
-let stdoutText = '';
-let stderrText = '';
-let lastExitCode: number | undefined;
-
-function makeFixtureWorkspace(): string {
-  const root = fs.mkdtempSync(path.join(os.tmpdir(), 'pd-principles-bdd-'));
-  const today = localDateString(new Date());
-  const logsDir = path.join(root, '.state', 'logs');
-  fs.mkdirSync(logsDir, { recursive: true });
-  const event = JSON.stringify({
-    ts: Date.now(),
-    date: today,
-    type: 'runtime_v2_prompt_activations_injected',
-    category: 'injected',
-    sessionId: 'bdd-s1',
-    data: {
-      sessionId: 'bdd-s1',
-      principleIds: ['p1', 'p2'],
-      injectedCount: 2,
-      skippedWarnings: [],
-      injectedCharCount: 420,
-      budget: 2000,
-      legacySelectedCount: 1,
-      legacyTotalChars: 300,
-      legacyTruncated: false,
-      v2Truncated: false,
-      crossBlockDuplicateIds: ['p2'],
-    },
-  });
-  fs.writeFileSync(path.join(logsDir, `events_${today}.jsonl`), [event, ''].join('\n'), 'utf8');
-
-  fs.mkdirSync(path.join(root, '.pd'), { recursive: true });
-  const connection = new SqliteConnection({ workspaceDir: root });
-  const db = connection.getDb();
-  const insert = db.prepare(
-    `INSERT INTO principle_applications (principle_id, channel, level, kind, session_id, created_at)
-     VALUES (?, 'prompt', ?, ?, ?, ?)`,
-  );
-  insert.run('p1', 'presence', 'prompt_injected', 'bdd-s1', new Date().toISOString());
-  insert.run('p2', 'presence', 'prompt_injected', 'bdd-s1', new Date().toISOString());
-  insert.run('p2', 'effect', 'self_reported', 'bdd-s1', new Date().toISOString());
-  connection.close();
-  return root;
-}
-
-// ── Given ────────────────────────────────────────────────────────────────────
-
-registry.given('一个可用的 pd-cli 可执行文件', () => {
-  state.ws = undefined;
-});
-
-registry.given('一个包含已知注入事件与回执账本的临时工作区', () => {
-  state.ws = makeFixtureWorkspace();
-  const dbPath = path.join(state.ws, '.pd', 'state.db');
-  state.dbBytesBefore = readFileSync(dbPath);
-  const db = new Database(dbPath, { readonly: true });
-  state.ledgerRowsBefore =
-    (db.prepare('SELECT COUNT(*) AS n FROM principle_applications').get() as { n: number }).n;
-  db.close();
-});
-
-registry.given('一个空的临时工作区', () => {
-  state.ws = fs.mkdtempSync(path.join(os.tmpdir(), 'pd-principles-bdd-empty-'));
-});
-
-// ── When ─────────────────────────────────────────────────────────────────────
-
-registry.when(/operator 执行 "pd principles stats( --json)?"/, async (_ctx, jsonFlag) => {
-  const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
-  const errSpy = vi.spyOn(process.stderr, 'write').mockImplementation(() => true);
-  const originalExitCode = process.exitCode;
-  process.exitCode = undefined;
-  try {
-    await handlePrinciplesStats({ workspace: state.ws, json: !!jsonFlag });
-  } finally {
-    stdoutText = logSpy.mock.calls.map((c) => String(c[0])).join('');
-    stderrText = errSpy.mock.calls.map((c) => String(c[0])).join('');
-    logSpy.mockRestore();
-    errSpy.mockRestore();
-    lastExitCode = process.exitCode;
-    process.exitCode = originalExitCode;
-  }
-});
-
-// ── Then ─────────────────────────────────────────────────────────────────────
-
-registry.then('stdout 是严格的单一 JSON 对象', () => {
-  expect(lastExitCode).toBeUndefined();
-  expect(stderrText).toBe('');
-  expect(stdoutText.trim().startsWith('{')).toBe(true);
-  expect(stdoutText.trim().endsWith('}')).toBe(true);
-});
-
-registry.then('该 JSON 对象可以被 JSON.parse 解析', () => {
-  expect(() => JSON.parse(stdoutText)).not.toThrow();
-});
-
-registry.then('stdout 不包含任何 banner 或 heading', () => {
-  const text = stdoutText.replace(/^\s*\{[\s\S]*\}\s*$/, '');
-  expect(text).toBe('');
-});
-
-function getParsed(): Record<string, unknown> {
-  // rc-1/rc-2: narrow from unknown via runtime guards before touching fields.
-  const parsed: unknown = JSON.parse(stdoutText);
-  if (parsed === null || typeof parsed !== 'object' || Array.isArray(parsed)) {
-    throw new Error(`Expected JSON object in stdout but got: ${typeof parsed}`);
-  }
-  // runtime-contract-exempt: ERR-001 narrowed from unknown via typeof + Array.isArray check above (test-only helper on trusted stdout JSON)
-  return parsed as Record<string, unknown>;
-}
-
-registry.then('该 JSON 对象的 ok 字段为 true', () => {
-  expect(getParsed().ok).toBe(true);
-});
-
-registry.then('该 JSON 对象包含 injections 指标组', () => {
-  expect(typeof getParsed().injections).toBe('object');
-});
-
-registry.then('该 JSON 对象包含 chars 指标组', () => {
-  expect(typeof getParsed().chars).toBe('object');
-});
-
-registry.then('该 JSON 对象包含 duplicates 指标组', () => {
-  expect(typeof getParsed().duplicates).toBe('object');
-});
-
-registry.then('该 JSON 对象包含 applicationCorrelation 指标组', () => {
-  expect(typeof getParsed().applicationCorrelation).toBe('object');
-});
-
-registry.then('数据库未被修改', () => {
-  const dbPath = path.join(state.ws as string, '.pd', 'state.db');
-  expect(readFileSync(dbPath).equals(state.dbBytesBefore)).toBe(true);
-});
-
-registry.then('ledger 未被修改', () => {
-  const db = new Database(path.join(state.ws as string, '.pd', 'state.db'), { readonly: true });
-  const n = (db.prepare('SELECT COUNT(*) AS n FROM principle_applications').get() as { n: number }).n;
-  db.close();
-  expect(n).toBe(state.ledgerRowsBefore);
-});
-
-registry.then('未入队新任务', () => {
-  // Read-only command: no queue writes anywhere. Guarded by the DB-bytes
-  // comparison above; nothing further to assert without a tasks table.
-  expect(state.dbBytesBefore).toBeDefined();
-});
-
-registry.then('未创建后继任务', () => {
-  expect(state.dbBytesBefore).toBeDefined();
-});
-
-registry.then('该 JSON 对象的 status 字段为 "degraded"', () => {
-  expect(getParsed().status).toBe('degraded');
-});
-
-registry.then('该 JSON 对象包含 nextAction 字段', () => {
-  expect(typeof getParsed().nextAction).toBe('string');
-  expect((getParsed().nextAction as string).length).toBeGreaterThan(0);
-});
-
-registry.then('nextAction 说明如何启用 receipt flag 或先产生注入数据', () => {
-  const nextAction = getParsed().nextAction as string;
-  expect(nextAction.includes('.pd/config.yaml') || nextAction.includes('Run PD')).toBe(true);
-});
-
-// ── Define Feature ───────────────────────────────────────────────────────────
-
-const featurePath = resolveFeaturePath('docs/specs/features/cli/principles-stats.feature');
-const featureText = readFileSync(featurePath, 'utf8');
-defineFeature(featureText, registry);