@principles/pd-cli 1.152.12 → 1.152.13

package/tests/commands/runtime-diagnostics-export.test.ts

@@ -1,175 +0,0 @@
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import * as fs from 'fs';
-import * as path from 'path';
-import * as os from 'os';
-
-const mockSchemaCheck = vi.hoisted(() => vi.fn());
-const mockHealthSnapshot = vi.hoisted(() => vi.fn());
-const mockHealthClose = vi.hoisted(() => vi.fn().mockResolvedValue(undefined));
-const mockOrphanCandidates = vi.hoisted(() => vi.fn());
-const mockQueueSnapshot = vi.hoisted(() => vi.fn());
-const mockQueueClose = vi.hoisted(() => vi.fn().mockResolvedValue(undefined));
-const mockAuditConsistency = vi.hoisted(() => vi.fn());
-const mockBuildGfiSnapshot = vi.hoisted(() => vi.fn());
-const mockIntegrityCheck = vi.hoisted(() => vi.fn());
-
-vi.mock('../../src/resolve-workspace.js', () => ({
-  resolveWorkspaceDir: vi.fn().mockReturnValue('/fake/workspace'),
-}));
-
-vi.mock('@principles/core/runtime-v2', () => ({
-  SchemaConformanceReadModel: vi.fn().mockImplementation(function () {
-    return { check: mockSchemaCheck };
-  }),
-  OperatorHealthReadModel: vi.fn().mockImplementation(function () {
-    return { getSnapshot: mockHealthSnapshot, close: mockHealthClose };
-  }),
-  PruningReadModel: vi.fn().mockImplementation(function () {
-    return { getOrphanDerivedCandidates: mockOrphanCandidates };
-  }),
-  createInternalizationQueueReadModel: vi.fn().mockResolvedValue({
-    readModel: { getSnapshot: mockQueueSnapshot },
-    close: mockQueueClose,
-  }),
-  InternalizationChainIntegrityReadModel: vi.fn().mockImplementation(function () {
-    return { check: mockIntegrityCheck };
-  }),
-  auditCandidateLedgerConsistency: mockAuditConsistency,
-  buildGfiWorkspaceSnapshot: mockBuildGfiSnapshot,
-  resolveOutputLanguage: vi.fn().mockReturnValue({ outputLanguage: 'zh-CN' }),
-}));
-
-vi.mock('../../src/commands/runtime-canary.js', () => ({
-  runCanaryChecks: vi.fn().mockResolvedValue({
-    overallStatus: 'healthy',
-    checks: [],
-    recommendedNextActions: [],
-    generatedAt: new Date().toISOString(),
-  }),
-}));
-
-import { exportDiagnosticsBundle } from '../../src/commands/runtime-diagnostics-export.js';
-
-function healthySchemaResult() {
-  return {
-    overallStatus: 'ok' as const,
-    checkedDatabasePath: '/fake/workspace/.pd/state.db',
-    tables: { tasks: { exists: true, missingColumns: [] } },
-    indexes: { missingIndexes: [] },
-    migrationsNeeded: [],
-    generatedAt: new Date().toISOString(),
-  };
-}
-
-function healthyIntegrityResult() {
-  return {
-    overallStatus: 'ok' as const,
-    brokenLinks: [],
-    chainSummaries: { totalCandidates: 0, totalDreamerTasks: 0, totalPhilosopherTasks: 0, totalPIArtifacts: 0, chainsWithBrokenLinks: 0 },
-    generatedAt: new Date().toISOString(),
-  };
-}
-
-describe('exportDiagnosticsBundle', () => {
-  let tempDir: string;
-
-  beforeEach(() => {
-    vi.clearAllMocks();
-    tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'diag-test-'));
-
-    mockSchemaCheck.mockReturnValue(healthySchemaResult());
-    mockHealthSnapshot.mockResolvedValue({ overallStatus: 'healthy', generatedAt: new Date().toISOString() });
-    mockHealthClose.mockResolvedValue(undefined);
-    mockOrphanCandidates.mockReturnValue({ candidates: [], dbReadable: true });
-    mockQueueSnapshot.mockResolvedValue({ pendingCount: 0, readyTasks: [] });
-    mockQueueClose.mockResolvedValue(undefined);
-    mockAuditConsistency.mockResolvedValue({ status: 'ok', consumedCount: 0, orphanCandidateCount: 0, missingLedgerCount: 0 });
-    mockBuildGfiSnapshot.mockReturnValue({ active: null, staleSessionCount: 0, totalSessionCount: 0, activeSessionCount: 0, generatedAt: new Date().toISOString() });
-    mockIntegrityCheck.mockReturnValue(healthyIntegrityResult());
-  });
-
-  afterEach(() => {
-    fs.rmSync(tempDir, { recursive: true, force: true });
-  });
-
-  it('generates bundle with all artifacts', async () => {
-    const outDir = path.join(tempDir, 'snapshots');
-    const manifest = await exportDiagnosticsBundle(tempDir, outDir);
-
-    expect(manifest.artifacts.length).toBeGreaterThanOrEqual(8);
-    expect(manifest.artifacts.every(a => a.status === 'ok')).toBe(true);
-    expect(fs.existsSync(path.join(outDir, 'manifest.json'))).toBe(true);
-    expect(fs.existsSync(path.join(outDir, 'schema-conformance.json'))).toBe(true);
-    expect(fs.existsSync(path.join(outDir, 'canary.json'))).toBe(true);
-  });
-
-  it('still generates manifest when sub-check fails', async () => {
-    mockHealthSnapshot.mockRejectedValue(new Error('DB error'));
-
-    const outDir = path.join(tempDir, 'snapshots');
-    const manifest = await exportDiagnosticsBundle(tempDir, outDir);
-
-    expect(manifest.artifacts.length).toBeGreaterThanOrEqual(8);
-    const failedArtifact = manifest.artifacts.find(a => a.name === 'runtime-health');
-    expect(failedArtifact?.status).toBe('failed');
-    expect(fs.existsSync(path.join(outDir, 'manifest.json'))).toBe(true);
-  });
-
-  it('rejects output path outside workspace', async () => {
-    await expect(
-      exportDiagnosticsBundle(tempDir, '/tmp/outside-workspace'),
-    ).rejects.toThrow('Output path must be within workspace directory');
-  });
-
-  it('rejects sibling path that starts with workspace prefix', async () => {
-    const siblingDir = tempDir + '-backup';
-    await expect(
-      exportDiagnosticsBundle(tempDir, siblingDir),
-    ).rejects.toThrow('Output path must be within workspace directory');
-  });
-
-  it('manifest contains path and status for each artifact', async () => {
-    const outDir = path.join(tempDir, 'snapshots');
-    const manifest = await exportDiagnosticsBundle(tempDir, outDir);
-
-    for (const artifact of manifest.artifacts) {
-      expect(artifact.path).toBeTruthy();
-      expect(artifact.status).toMatch(/^(ok|failed)$/);
-    }
-  });
-
-  it('does not include sensitive env/API key content', async () => {
-    mockSchemaCheck.mockReturnValue({
-      ...healthySchemaResult(),
-      // Redaction test fixture: value need not look like a real secret — the
-      // assertion is that exportDiagnosticsBundle redacts whatever is set.
-      // (String built at runtime so the fixture is not a static credential
-      // literal; the field exists solely to exercise the redaction path.)
-      apiKey: ['redaction-test-', 'fixture-key'].join(''),
-      config: { token: 'plain-test-token-value', safeValue: 'hello' },
-    });
-
-    const outDir = path.join(tempDir, 'snapshots');
-    await exportDiagnosticsBundle(tempDir, outDir);
-
-    const schemaContent = fs.readFileSync(path.join(outDir, 'schema-conformance.json'), 'utf8');
-    const parsed = JSON.parse(schemaContent);
-    expect(parsed.apiKey).toBe('[REDACTED]');
-    expect(parsed.config.token).toBe('[REDACTED]');
-    expect(parsed.config.safeValue).toBe('hello');
-  });
-
-  it('uses createInternalizationQueueReadModel with readonly: true (no RuntimeStateManager)', async () => {
-    const fs = await import('fs');
-    const src = fs.readFileSync(require.resolve('../../src/commands/runtime-diagnostics-export.ts'), 'utf-8');
-    expect(src).not.toContain('RuntimeStateManager');
-    expect(src).toContain('createInternalizationQueueReadModel');
-    expect(src).toMatch(/createInternalizationQueueReadModel\(\{[^}]*readonly:\s*true/);
-  });
-
-  it('calls queue close once on main path', async () => {
-    const outDir = path.join(tempDir, 'snapshots');
-    await exportDiagnosticsBundle(tempDir, outDir);
-    expect(mockQueueClose).toHaveBeenCalledTimes(1);
-  });
-});

package/tests/commands/runtime-features.test.ts

@@ -1,249 +0,0 @@
-/**
- * runtime-features tests — PRI-305
- *
- * Covers:
- *   - JSON purity (single parseable JSON object)
- *   - Missing config → defaults with nextAction
- *   - Malformed config → fail loud with reason and nextAction
- *   - Effective flags from .pd/config.yaml
- *   - No secret output
- *   - CLI handler: --json stdout purity and exit code
- */
-
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import * as fs from 'node:fs';
-import * as path from 'node:path';
-import * as os from 'node:os';
-import * as yaml from 'js-yaml';
-import { buildRuntimeFeaturesStatus, handleRuntimeFeaturesStatus, type RuntimeFeaturesOutput } from '../../src/commands/runtime-features.js';
-
-// ── Helpers ─────────────────────────────────────────────────────────────────
-
-function mkTmpDir(): string {
-  return fs.mkdtempSync(path.join(os.tmpdir(), 'pd-runtime-features-test-'));
-}
-
-function rmTmpDir(dir: string): void {
-  try { fs.rmSync(dir, { recursive: true, force: true }); } catch { /* ignore */ }
-}
-
-function writeConfig(workspaceDir: string, content: string): void {
-  const configDir = path.join(workspaceDir, '.pd');
-  fs.mkdirSync(configDir, { recursive: true });
-  fs.writeFileSync(path.join(configDir, 'config.yaml'), content, 'utf8');
-}
-
-function makeValidConfigYaml(): string {
-  return yaml.dump({
-    version: 1,
-    features: {
-      prompt: { category: 'core', enabled: true },
-      code_tool_hook: { category: 'core', enabled: true },
-      defer_archive: { category: 'core', enabled: true },
-      correction_observer: { category: 'quiet', enabled: false },
-      gfi: { category: 'quiet', enabled: false },
-    },
-    runtimeProfiles: {
-      // Include pd.default (the M9 default) to avoid "profile not found" warnings
-      'pd.default': { type: 'pi-ai', provider: 'anthropic', model: 'claude-3-5-sonnet', apiKeyEnv: 'ANTHROPIC_API_KEY' },
-      'openclaw.default': { type: 'openclaw', source: 'default' },
-    },
-    internalAgents: {
-      defaultRuntime: 'openclaw.default',
-      agents: {
-        diagnostician: { enabled: true },
-        dreamer: { enabled: true },
-        scribe: { enabled: true },
-        artificer: { enabled: true },
-        philosopher: { enabled: false },
-        evaluator: { enabled: false },
-        rolloutReviewer: { enabled: false },
-        correctionObserver: { enabled: false },
-      },
-    },
-    ui: { diagnostics: { mode: 'simple' } },
-  });
-}
-
-// ── JSON purity ──────────────────────────────────────────────────────────────
-
-describe('JSON purity', () => {
-  it('output is a single parseable JSON object', () => {
-    const tmp = mkTmpDir();
-    try {
-      const output = buildRuntimeFeaturesStatus(tmp);
-      const json = JSON.stringify(output, null, 2);
-      const parsed = JSON.parse(json);
-      expect(typeof parsed).toBe('object');
-      expect(parsed).not.toBeNull();
-      expect(Array.isArray(parsed)).toBe(false);
-    } finally { rmTmpDir(tmp); }
-  });
-});
-
-// ── Missing config → defaults ────────────────────────────────────────────────
-
-describe('Missing config → defaults', () => {
-  it('returns status=ok with source=defaults when config file is absent', () => {
-    const tmp = mkTmpDir();
-    try {
-      const output = buildRuntimeFeaturesStatus(tmp);
-      expect(output.status).toBe('ok');
-      expect(output.source).toBe('defaults');
-      expect(output.enabledMvpChannels).toContain('prompt');
-      expect(output.enabledMvpChannels).toContain('code_tool_hook');
-      expect(output.enabledMvpChannels).toContain('defer_archive');
-    } finally { rmTmpDir(tmp); }
-  });
-});
-
-// ── Malformed config → fail loud ────────────────────────────────────────────
-
-describe('Malformed config → fail loud', () => {
-  it('returns status=failed with reason and nextAction for YAML parse error', () => {
-    const tmp = mkTmpDir();
-    writeConfig(tmp, 'version: [unterminated');
-    try {
-      const output = buildRuntimeFeaturesStatus(tmp);
-      expect(output.status).toBe('failed');
-      expect(output.source).toBe('malformed');
-      expect(output.reason).toBeTruthy();
-      expect(output.nextAction).toBeTruthy();
-      expect(output.errors).toBeDefined();
-      expect(output.errors!.length).toBeGreaterThan(0);
-    } finally { rmTmpDir(tmp); }
-  });
-
-  it('returns status=failed for invalid version', () => {
-    const tmp = mkTmpDir();
-    writeConfig(tmp, yaml.dump({ version: 99, features: {}, runtimeProfiles: {}, internalAgents: { defaultRuntime: 'x', agents: {} } }));
-    try {
-      const output = buildRuntimeFeaturesStatus(tmp);
-      expect(output.status).toBe('failed');
-      expect(output.source).toBe('malformed');
-    } finally { rmTmpDir(tmp); }
-  });
-});
-
-// ── Valid config → effective flags ───────────────────────────────────────────
-
-describe('Valid config → effective flags', () => {
-  it('returns status=ok with source=user_config for valid config', () => {
-    const tmp = mkTmpDir();
-    writeConfig(tmp, makeValidConfigYaml());
-    try {
-      const output = buildRuntimeFeaturesStatus(tmp);
-      expect(output.status).toBe('ok');
-      expect(output.source).toBe('user_config');
-      expect(output.enabledMvpChannels).toContain('prompt');
-    } finally { rmTmpDir(tmp); }
-  });
-
-  it('shows all feature flags with category and enabled status', () => {
-    const tmp = mkTmpDir();
-    writeConfig(tmp, makeValidConfigYaml());
-    try {
-      const output = buildRuntimeFeaturesStatus(tmp);
-      expect(output.features.length).toBeGreaterThan(0);
-      const promptFlag = output.features.find(f => f.id === 'prompt');
-      expect(promptFlag).toBeDefined();
-      expect(promptFlag!.category).toBe('core');
-      expect(promptFlag!.enabled).toBe(true);
-    } finally { rmTmpDir(tmp); }
-  });
-
-  it('counts enabled and disabled correctly', () => {
-    const tmp = mkTmpDir();
-    writeConfig(tmp, makeValidConfigYaml());
-    try {
-      const output = buildRuntimeFeaturesStatus(tmp);
-      expect(output.totalFlags).toBeGreaterThan(0);
-      expect(output.enabledCount + output.disabledCount).toBe(output.totalFlags);
-    } finally { rmTmpDir(tmp); }
-  });
-});
-
-// ── No secret output ─────────────────────────────────────────────────────────
-
-describe('No secret output', () => {
-  it('output never contains raw API key values', () => {
-    const tmp = mkTmpDir();
-    writeConfig(tmp, makeValidConfigYaml());
-    try {
-      const output = buildRuntimeFeaturesStatus(tmp);
-      const json = JSON.stringify(output);
-      expect(json).not.toContain('sk-ant-');
-      expect(json).not.toContain('"apiKey"');
-      expect(json).not.toContain('"gatewayToken"');
-    } finally { rmTmpDir(tmp); }
-  });
-});
-
-// ── CLI handler: --json stdout purity and exit code ──────────────────────────
-
-describe('CLI handler: --json stdout purity and exit code', () => {
-  let stdoutSpy: ReturnType<typeof vi.spyOn>;
-  let originalExitCode: number | undefined;
-
-  beforeEach(() => {
-    stdoutSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
-    originalExitCode = process.exitCode;
-    process.exitCode = undefined;
-  });
-
-  afterEach(() => {
-    stdoutSpy.mockRestore();
-    process.exitCode = originalExitCode;
-  });
-
-  it('--json outputs exactly one parseable JSON object to stdout', async () => {
-    const tmp = mkTmpDir();
-    try {
-      await handleRuntimeFeaturesStatus({ workspace: tmp, json: true });
-      expect(stdoutSpy).toHaveBeenCalledTimes(1);
-      const output = stdoutSpy.mock.calls[0][0] as string;
-      const parsed = JSON.parse(output);
-      expect(typeof parsed).toBe('object');
-      expect(parsed).not.toBeNull();
-      expect(Array.isArray(parsed)).toBe(false);
-      // Verify key fields exist
-      expect(parsed).toHaveProperty('status');
-      expect(parsed).toHaveProperty('source');
-      expect(parsed).toHaveProperty('features');
-    } finally { rmTmpDir(tmp); }
-  });
-
-  it('--json sets process.exitCode=1 on failed status', async () => {
-    const tmp = mkTmpDir();
-    writeConfig(tmp, 'version: [unterminated');
-    try {
-      await handleRuntimeFeaturesStatus({ workspace: tmp, json: true });
-      expect(process.exitCode).toBe(1);
-      // Verify the JSON output still parses
-      const output = stdoutSpy.mock.calls[0][0] as string;
-      const parsed = JSON.parse(output);
-      expect(parsed.status).toBe('failed');
-      expect(parsed.reason).toBeTruthy();
-      expect(parsed.nextAction).toBeTruthy();
-    } finally { rmTmpDir(tmp); }
-  });
-
-  it('--json does not set exitCode=1 on ok status', async () => {
-    const tmp = mkTmpDir();
-    try {
-      await handleRuntimeFeaturesStatus({ workspace: tmp, json: true });
-      expect(process.exitCode).toBeUndefined();
-    } finally { rmTmpDir(tmp); }
-  });
-
-  it('--json output contains no extra stdout lines (no banners, headers)', async () => {
-    const tmp = mkTmpDir();
-    try {
-      await handleRuntimeFeaturesStatus({ workspace: tmp, json: true });
-      expect(stdoutSpy).toHaveBeenCalledTimes(1);
-      const output = stdoutSpy.mock.calls[0][0] as string;
-      // Must parse as single JSON object — no leading/trailing non-JSON
-      expect(() => JSON.parse(output)).not.toThrow();
-    } finally { rmTmpDir(tmp); }
-  });
-});