@pellux/goodvibes-tui 0.18.11 → 0.18.13

package/src/mcp/client.ts

@@ -1,383 +0,0 @@
-/**
- * McpClient — connects to a single MCP server process via stdio JSON-RPC 2.0.
- *
- * Protocol: newline-delimited JSON (each message is one JSON line on stdout/stdin).
- * Progressive loading: listTools() returns names + descriptions only.
- * getToolSchema() fetches full inputSchema on demand and caches it.
- */
-import { logger } from '@pellux/goodvibes-sdk/platform/utils/logger';
-import { VERSION } from '../version.ts';
-import type { McpServerConfig } from '@pellux/goodvibes-sdk/platform/mcp/config';
-import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils/error-display';
-
-export interface McpProcessSpec {
-  command: string;
-  args?: string[];
-  env?: Record<string, string>;
-  cwd?: string;
-  summary?: string;
-  sandboxSessionId?: string;
-}
-
-export interface McpToolInfo {
-  name: string;
-  description: string;
-}
-
-export interface McpToolSchema extends McpToolInfo {
-  inputSchema: Record<string, unknown>;
-}
-
-interface JsonRpcRequest {
-  jsonrpc: '2.0';
-  id: number;
-  method: string;
-  params?: unknown;
-}
-
-interface JsonRpcResponse {
-  jsonrpc: '2.0';
-  id: number;
-  result?: unknown;
-  error?: { code: number; message: string; data?: unknown };
-}
-
-interface PendingRequest {
-  resolve: (value: unknown) => void;
-  reject: (reason: unknown) => void;
-  timer: ReturnType<typeof setTimeout>;
-}
-
-const DEFAULT_TIMEOUT_MS = 30_000;
-const PING_TIMEOUT_MS = 5_000;
-const RESTART_DELAY_MS = 2_000;
-const MAX_RESTART_ATTEMPTS = 3;
-
-export class McpClient {
-  private proc: ReturnType<typeof Bun.spawn> | null = null;
-  private nextId = 1;
-  private pendingRequests = new Map<number, PendingRequest>();
-  private buffer = '';
-  private readLoopRunning = false;
-  private restartCount = 0;
-  private initialized = false;
-
-  /** Cache: tool name → full schema (populated lazily on first callTool) */
-  private schemaCache = new Map<string, McpToolSchema>();
-
-  /** Minimal tool info loaded at connect time (name + description only) */
-  private toolInfoCache: McpToolInfo[] | null = null;
-
-  constructor(
-    private config: McpServerConfig,
-    private options?: { timeout?: number; processSpec?: McpProcessSpec },
-  ) {}
-
-  get name(): string {
-    return this.config.name;
-  }
-
-  get isConnected(): boolean {
-    if (!this.proc) return false;
-    try {
-      return (this.proc as { exitCode: number | null }).exitCode === null;
-    } catch {
-      return false;
-    }
-  }
-
-  /**
-   * connect — Start the server process and perform MCP handshake (initialize).
-   * After connect, listTools() is available.
-   */
-  async connect(): Promise<void> {
-    if (this.proc && this.isConnected) return;
-    await this._startProcess();
-    await this._initialize();
-  }
-
-  /**
-   * listTools — Return tool names and descriptions (progressive loading).
-   * Full schemas are NOT fetched here; call getToolSchema() to get them.
-   */
-  async listTools(): Promise<McpToolInfo[]> {
-    if (!this.isConnected) {
-      throw new Error(`McpClient(${this.config.name}): not connected`);
-    }
-    if (this.toolInfoCache) return this.toolInfoCache;
-
-    const result = await this._request<{ tools: Array<{ name: string; description?: string }> }>('tools/list');
-    this.toolInfoCache = (result.tools ?? []).map((t) => ({
-      name: t.name,
-      description: t.description ?? '',
-    }));
-    return this.toolInfoCache;
-  }
-
-  /**
-   * getToolSchema — Fetch full JSON schema for a tool (lazy, cached).
-   * MCP protocol provides full schemas in tools/list; we cache them on first access.
-   */
-  async getToolSchema(toolName: string): Promise<McpToolSchema | null> {
-    if (this.schemaCache.has(toolName)) {
-      return this.schemaCache.get(toolName)!;
-    }
-
-    if (!this.isConnected) {
-      throw new Error(`McpClient(${this.config.name}): not connected`);
-    }
-
-    // Fetch all tools with full schemas and cache them all at once
-    const result = await this._request<{
-      tools: Array<{ name: string; description?: string; inputSchema?: Record<string, unknown> }>;
-    }>('tools/list');
-
-    for (const t of result.tools ?? []) {
-      this.schemaCache.set(t.name, {
-        name: t.name,
-        description: t.description ?? '',
-        inputSchema: t.inputSchema ?? { type: 'object', properties: {} },
-      });
-    }
-
-    return this.schemaCache.get(toolName) ?? null;
-  }
-
-  /**
-   * callTool — Execute a tool on the MCP server.
-   * Fetches full schema on first use (if not already cached).
-   */
-  async callTool(toolName: string, args: Record<string, unknown>): Promise<unknown> {
-    if (!this.isConnected) {
-      throw new Error(`McpClient(${this.config.name}): not connected`);
-    }
-    // Ensure schema is cached on first use
-    if (!this.schemaCache.has(toolName)) {
-      await this.getToolSchema(toolName);
-    }
-    return this._request('tools/call', { name: toolName, arguments: args });
-  }
-
-  /**
-   * disconnect — Stop the server process and clean up.
-   */
-  async disconnect(): Promise<void> {
-    if (!this.proc) return;
-    // Reject all pending requests
-    for (const [, pending] of this.pendingRequests) {
-      clearTimeout(pending.timer);
-      pending.reject(new Error(`McpClient(${this.config.name}): disconnected`));
-    }
-    this.pendingRequests.clear();
-
-    try {
-      (this.proc.stdin as import('bun').FileSink).end();
-      this.proc.kill();
-      await this.proc.exited;
-    } catch {
-      // Ignore shutdown errors
-    } finally {
-      this.proc = null;
-      this.buffer = '';
-      this.readLoopRunning = false;
-      this.initialized = false;
-    }
-  }
-
-  // ---------------------------------------------------------------------------
-  // Private helpers
-  // ---------------------------------------------------------------------------
-
-  private async _startProcess(): Promise<void> {
-    const processSpec = this.options?.processSpec;
-    const cmd = processSpec?.command ?? this.config.command;
-    const args = processSpec?.args ?? this.config.args ?? [];
-    const env = { ...process.env, ...(this.config.env ?? {}), ...(processSpec?.env ?? {}) };
-    const cwd = processSpec?.cwd;
-
-    try {
-      this.proc = Bun.spawn([cmd, ...args], {
-        stdin: 'pipe',
-        stdout: 'pipe',
-        stderr: 'pipe',
-        env,
-        ...(cwd ? { cwd } : {}),
-      });
-      this.buffer = '';
-      this.restartCount = 0;
-      this._startReadLoop();
-    } catch (err) {
-      logger.error('McpClient: failed to start process', { server: this.config.name, err: summarizeError(err) });
-      this.proc = null;
-      throw new Error(`McpClient(${this.config.name}): failed to start: ${summarizeError(err)}`);
-    }
-  }
-
-  /** Perform MCP initialize handshake. */
-  private async _initialize(): Promise<void> {
-    if (this.initialized) return;
-    try {
-      await this._request('initialize', {
-        protocolVersion: '2024-11-05',
-        capabilities: {},
-        clientInfo: { name: 'goodvibes-tui', version: VERSION },
-      });
-      this._notify('notifications/initialized', {});
-      this.initialized = true;
-    } catch (err) {
-      logger.error('McpClient: initialize handshake failed', { server: this.config.name, err: summarizeError(err) });
-      throw err;
-    }
-  }
-
-  /** Send a JSON-RPC request; returns the result. */
-  private _request<T = unknown>(method: string, params?: unknown): Promise<T> {
-    if (!this.proc) {
-      return Promise.reject(new Error(`McpClient(${this.config.name}): not running`));
-    }
-
-    const id = this.nextId++;
-    const msg: JsonRpcRequest = { jsonrpc: '2.0', id, method, params };
-    const line = JSON.stringify(msg) + '\n';
-    const timeoutMs = this.options?.timeout ?? DEFAULT_TIMEOUT_MS;
-
-    return new Promise<T>((resolve, reject) => {
-      const timer = setTimeout(() => {
-        this.pendingRequests.delete(id);
-        reject(new Error(`McpClient(${this.config.name}): request '${method}' timed out after ${timeoutMs}ms`));
-      }, timeoutMs);
-
-      this.pendingRequests.set(id, {
-        resolve: resolve as (value: unknown) => void,
-        reject,
-        timer,
-      });
-
-      try {
-        (this.proc!.stdin as import('bun').FileSink).write(line);
-      } catch (err) {
-        clearTimeout(timer);
-        this.pendingRequests.delete(id);
-        reject(new Error(`McpClient(${this.config.name}): write failed: ${summarizeError(err)}`));
-      }
-    });
-  }
-
-  /** Send a JSON-RPC notification (no response expected). */
-  private _notify(method: string, params?: unknown): void {
-    if (!this.proc || !this.isConnected) return;
-    try {
-      const msg = { jsonrpc: '2.0', method, params };
-      (this.proc.stdin as import('bun').FileSink).write(JSON.stringify(msg) + '\n');
-    } catch (err) {
-      logger.debug('McpClient: failed to send notification', { method, err: summarizeError(err) });
-    }
-  }
-
-  private _startReadLoop(): void {
-    if (this.readLoopRunning || !this.proc) return;
-    this.readLoopRunning = true;
-
-    const proc = this.proc;
-    const decoder = new TextDecoder();
-
-    (async () => {
-      try {
-        const reader = (proc.stdout as ReadableStream<Uint8Array>).getReader();
-        while (true) {
-          const { done, value } = await reader.read();
-          if (done) break;
-          this.buffer += decoder.decode(value, { stream: true });
-          this._processBuffer();
-        }
-      } catch (err) {
-        logger.debug('McpClient: stdout read loop ended', { server: this.config.name, err: summarizeError(err) });
-      } finally {
-        this.readLoopRunning = false;
-        // Reject remaining pending requests
-        for (const [, pending] of this.pendingRequests) {
-          clearTimeout(pending.timer);
-          pending.reject(new Error(`McpClient(${this.config.name}): process exited unexpectedly`));
-        }
-        this.pendingRequests.clear();
-
-        // Auto-restart if process crashed and we haven't exceeded retry limit
-        if (this.restartCount < MAX_RESTART_ATTEMPTS) {
-          this._scheduleRestart();
-        } else {
-          logger.info('McpClient: exceeded max restart attempts', { server: this.config.name });
-        }
-      }
-    })();
-  }
-
-  private _processBuffer(): void {
-    let newlineIdx: number;
-    while ((newlineIdx = this.buffer.indexOf('\n')) !== -1) {
-      const line = this.buffer.slice(0, newlineIdx).trim();
-      this.buffer = this.buffer.slice(newlineIdx + 1);
-      if (!line) continue;
-      this._dispatchLine(line);
-    }
-  }
-
-  private _dispatchLine(line: string): void {
-    let msg: unknown;
-    try {
-      msg = JSON.parse(line);
-    } catch (err) {
-      logger.debug('McpClient: failed to parse JSON line', { server: this.config.name, err: summarizeError(err), line: line.slice(0, 200) });
-      return;
-    }
-
-    if (typeof msg !== 'object' || msg === null) return;
-
-    const response = msg as JsonRpcResponse;
-    if ('id' in response && typeof response.id === 'number') {
-      const pending = this.pendingRequests.get(response.id);
-      if (pending) {
-        clearTimeout(pending.timer);
-        this.pendingRequests.delete(response.id);
-        if (response.error) {
-          pending.reject(new Error(`McpClient(${this.config.name}) RPC error ${response.error.code}: ${response.error.message}`));
-        } else {
-          pending.resolve(response.result);
-        }
-      }
-    }
-    // Notifications (no id or id=null) are silently ignored
-  }
-
-  private _scheduleRestart(): void {
-    this.restartCount++;
-    const delay = RESTART_DELAY_MS * this.restartCount;
-    logger.info('McpClient: scheduling restart', { server: this.config.name, attempt: this.restartCount, delayMs: delay });
-
-    setTimeout(async () => {
-      if (this.proc && this.isConnected) return; // Already restarted by something else
-      try {
-        await this._startProcess();
-        await this._initialize();
-        // Invalidate tool cache so it's re-fetched after restart
-        this.toolInfoCache = null;
-        logger.info('McpClient: restart successful', { server: this.config.name });
-      } catch (err) {
-        logger.error('McpClient: restart failed', { server: this.config.name, err: summarizeError(err) });
-      }
-    }, delay);
-  }
-
-  /**
-   * ping — Send a ping to check if server is healthy.
-   * Returns true if server responds within PING_TIMEOUT_MS.
-   */
-  async ping(): Promise<boolean> {
-    if (!this.isConnected) return false;
-    try {
-      await this._request('ping', {});
-      return true;
-    } catch {
-      return false;
-    }
-  }
-}

package/src/mcp/index.ts

@@ -1,12 +0,0 @@
-export { McpRegistry } from '@pellux/goodvibes-sdk/platform/mcp/registry';
-export type { RegisteredTool } from '@pellux/goodvibes-sdk/platform/mcp/registry';
-export { createMcpApi } from '@pellux/goodvibes-sdk/platform/mcp/mcp-api';
-export type {
-  McpApi,
-  McpApiRegistry,
-  McpSandboxBindingRecord,
-  McpServerRecord,
-  McpServerSecurityRecord,
-} from '@pellux/goodvibes-sdk/platform/mcp/mcp-api';
-export { loadMcpConfig } from '@pellux/goodvibes-sdk/platform/mcp/config';
-export type { McpConfig, McpConfigRoots, McpServerConfig } from '@pellux/goodvibes-sdk/platform/mcp/config';

package/src/mcp/mcp-api.ts

@@ -1,90 +0,0 @@
-import type { RegisteredTool } from '@pellux/goodvibes-sdk/platform/mcp/registry';
-import type { McpDecisionRecord, McpServerRole, McpTrustMode, QuarantineReason, SchemaFreshness } from '@pellux/goodvibes-sdk/platform/runtime/mcp/types';
-
-export interface McpServerRecord {
-  readonly name: string;
-  readonly connected: boolean;
-}
-
-export interface McpServerSecurityRecord {
-  readonly name: string;
-  readonly connected: boolean;
-  readonly role: McpServerRole;
-  readonly trustMode: McpTrustMode;
-  readonly allowedPaths: readonly string[];
-  readonly allowedHosts: readonly string[];
-  readonly schemaFreshness: SchemaFreshness;
-  readonly quarantineReason?: QuarantineReason;
-  readonly quarantineDetail?: string;
-  readonly quarantineApprovedBy?: string;
-}
-
-export interface McpSandboxBindingRecord {
-  readonly name: string;
-  readonly sessionId?: string;
-  readonly profileId?: 'mcp-shared' | 'mcp-per-server';
-  readonly state?: import('@pellux/goodvibes-sdk/platform/runtime/sandbox/types').SandboxSessionState;
-  readonly backend?: import('@pellux/goodvibes-sdk/platform/runtime/sandbox/types').SandboxResolvedBackend | import('@pellux/goodvibes-sdk/platform/runtime/sandbox/types').SandboxVmBackend;
-  readonly startupStatus?: 'verified' | 'planned' | 'failed';
-}
-
-export interface McpApi {
-  listServerNames(): readonly string[];
-  listServers(): readonly McpServerRecord[];
-  listServerSecurity(): readonly McpServerSecurityRecord[];
-  listSandboxBindings(): readonly McpSandboxBindingRecord[];
-  listRecentSecurityDecisions(limit?: number): readonly McpDecisionRecord[];
-  listAllTools(): Promise<readonly RegisteredTool[]>;
-  setServerTrustMode(serverName: string, mode: McpTrustMode): void;
-  setServerRole(serverName: string, role: McpServerRole): void;
-  quarantineSchema(serverName: string, reason: QuarantineReason, detail?: string): void;
-  approveSchemaQuarantine(serverName: string, operatorId: string): void;
-}
-
-export interface McpApiRegistry {
-  readonly serverNames: readonly string[];
-  listServers(): readonly McpServerRecord[];
-  listServerSecurity(): readonly McpServerSecurityRecord[];
-  listServerSandboxBindings(): readonly McpSandboxBindingRecord[];
-  listRecentSecurityDecisions(limit?: number): readonly McpDecisionRecord[];
-  listAllTools(): Promise<readonly RegisteredTool[]>;
-  setServerTrustMode(serverName: string, mode: McpTrustMode): void;
-  setServerRole(serverName: string, role: McpServerRole): void;
-  quarantineSchema(serverName: string, reason: QuarantineReason, detail?: string): void;
-  approveSchemaQuarantine(serverName: string, operatorId: string): void;
-}
-
-export function createMcpApi(registry: McpApiRegistry): McpApi {
-  return {
-    listServerNames(): readonly string[] {
-      return registry.serverNames;
-    },
-    listServers(): readonly McpServerRecord[] {
-      return registry.listServers();
-    },
-    listServerSecurity() {
-      return registry.listServerSecurity();
-    },
-    listSandboxBindings() {
-      return registry.listServerSandboxBindings();
-    },
-    listRecentSecurityDecisions(limit = 8) {
-      return registry.listRecentSecurityDecisions(limit);
-    },
-    listAllTools() {
-      return registry.listAllTools();
-    },
-    setServerTrustMode(serverName, mode) {
-      registry.setServerTrustMode(serverName, mode);
-    },
-    setServerRole(serverName, role) {
-      registry.setServerRole(serverName, role);
-    },
-    quarantineSchema(serverName, reason, detail) {
-      registry.quarantineSchema(serverName, reason, detail);
-    },
-    approveSchemaQuarantine(serverName, operatorId) {
-      registry.approveSchemaQuarantine(serverName, operatorId);
-    },
-  };
-}

package/src/mcp/registry.ts

@@ -1 +0,0 @@
-export * from '@pellux/goodvibes-sdk/platform/mcp/registry';