@pellux/goodvibes-tui 0.18.11 → 0.18.13

package/CHANGELOG.md

@@ -4,6 +4,78 @@ All notable changes to GoodVibes TUI.
 
 ---
 
+## [0.18.13] — 2026-04-16
+
+### SDK/TUI Boundary Separation
+
+Major cleanup of the SDK/TUI boundary. The TUI is now a thin rendering/input/wiring layer built on `@pellux/goodvibes-sdk@0.18.29`. Thousands of lines of duplicated, forked, and dead code have been removed and replaced with SDK imports.
+
+#### Dead Code Removed
+
+- Deleted 4 dead daemon files that nothing imported (`facade.ts`, `facade-composition.ts`, `surface-policy.ts`, `types.ts`) — 1,291 lines removed
+- Deleted 2 dead UI read-model files (`ui-read-models-core.ts`, `ui-read-models-operations.ts`) — the barrel already delegates to SDK
+
+#### Forks Replaced with SDK Imports
+
+- Replaced `src/core/orchestrator.ts` (736 lines) with a 3-line re-export from SDK — the SDK's Orchestrator already includes `getSpinner()`
+- Replaced `src/plugins/loader.ts` (305 lines) with re-exports from SDK — the SDK now supports `additionalDirectories` and `entryDefault` options
+- Replaced `src/tools/index.ts` (187 lines) with re-export of SDK's `registerAllTools`
+- Replaced `src/config/subscription-providers.ts` (128 lines) with `export *` from SDK
+- Replaced `src/config/index.ts` API key functions with re-exports from SDK's new `config/api-keys.ts`
+- Replaced `src/permissions/prompt.ts` type definitions with imports from SDK — kept `PermissionPromptUI` class (TUI-specific rendering)
+- Replaced 4 store/runtime duplicate files with SDK re-exports (conversation domain, permissions domain, conversation reducers, lifecycle reducers)
+
+#### ConversationManager Refactored
+
+- Refactored `src/core/conversation.ts` from a 776-line standalone class to a ~450-line subclass extending SDK's `ConversationManager`
+- Removed all duplicated message management methods (CRUD, branching, persistence, compaction, undo/redo) — now inherited from SDK
+- Defined `TuiBlockMeta extends BlockMeta` with rendering fields (`blockIndex`, `startLine`, `lineCount`, `collapseKey`)
+- Kept all TUI-specific rendering methods (history buffer, block registry, collapse state, display navigation)
+
+#### Health Monitoring Renamed
+
+- Renamed `panelHealthMonitor` to `componentHealthMonitor` throughout the TUI to align with SDK 0.18.29's generic naming
+- Updated 20 files across runtime, panels, diagnostics, bootstrap, and tests
+- Added deprecated `Panel*` type aliases for backward compatibility
+
+#### RuntimeState Aligned with SDK
+
+- Updated `store/state.ts` to use SDK's `surfacePerf: SurfacePerfDomainState` instead of `uiPerf: UiPerfDomainState`
+- Updated `store/selectors/index.ts` to match SDK's selector shape
+- Health monitoring perf files rewritten as SDK re-export shims
+
+#### Clipboard Split
+
+- Created `src/utils/clipboard.ts` with TUI-specific OSC 52 `copyToClipboard` function
+- Platform clipboard paste functions remain in SDK
+
+### Verification
+
+- Full typecheck passes: `bun x tsc --noEmit` — 0 errors
+- Updated to `@pellux/goodvibes-sdk@0.18.29`
+
+## [0.18.12] — 2026-04-15
+
+### SDK `0.18.28` Session-Persistence Boundary Fix
+
+- Updated `goodvibes-tui` to consume the published canonical SDK line at `@pellux/goodvibes-sdk@0.18.28`
+- Pulled in the SDK fix that threads `surfaceRoot` through the last-session pointer and crash-recovery helpers instead of silently falling back to the shared `.goodvibes/...` tree
+- This closes the remaining TUI session-storage boundary leak that could still split a TUI-owned session across `.goodvibes/tui/...` and the unscoped shared root even after the broader SDK cutover
+
+### TUI Validation Tail Cleanup
+
+- Moved the remaining session, template, picker, plugin, bootstrap-service, and related test temp roots onto the repo-local `.test-tmp/...` path instead of `os.tmpdir()`, removing the local quota failures that were still breaking the TUI validation pass
+- Updated the shell-control cutover gate to assert against the current TUI production surfaces and the intentional removal of old local platform files instead of reading deleted pre-cutover paths
+- Removed the stale typed-emission allowlist entry for `src/runtime/health/effect-handlers.ts` after that file was deleted during the SDK cutover, so the enforcement gate now reflects the live tree again
+
+### Verification
+
+- Full typecheck passes: `bun x tsc --noEmit --pretty false`
+- Full test runner passes: `bun run test` (`437` files passed / `0` failed)
+- Architecture gate passes: `bun run architecture:check`
+- Build passes: `bun run build`
+- Targeted cutover regression band passes against the published SDK `0.18.28`
+
 ## [0.18.11] — 2026-04-15
 
 ### Version Boundary Cleanup

package/README.md

@@ -2,7 +2,7 @@
 
 [![CI](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml/badge.svg)](https://github.com/mgd34msu/goodvibes-tui/actions/workflows/ci.yml)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
-[![Version](https://img.shields.io/badge/version-0.18.11-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
+[![Version](https://img.shields.io/badge/version-0.18.13-blue.svg)](https://github.com/mgd34msu/goodvibes-tui)
 
 A terminal-native AI coding, operations, automation, knowledge, and integration console with a typed runtime, omnichannel surfaces, structured memory/knowledge, and a raw ANSI renderer.
 

package/docs/foundation-artifacts/operator-contract.json

@@ -3,7 +3,7 @@
   "product": {
     "id": "goodvibes",
     "surface": "operator",
-    "version": "0.18.11"
+    "version": "0.18.29"
   },
   "auth": {
     "modes": [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pellux/goodvibes-tui",
-  "version": "0.18.11",
+  "version": "0.18.13",
   "description": "Terminal-native GoodVibes product for coding, operations, automation, knowledge, channels, and daemon-backed control-plane workflows.",
   "type": "module",
   "main": "src/main.ts",
@@ -88,7 +88,7 @@
     "@anthropic-ai/vertex-sdk": "^0.16.0",
     "@ast-grep/napi": "^0.42.0",
     "@aws/bedrock-token-generator": "^1.1.0",
-    "@pellux/goodvibes-sdk": "0.18.26",
+    "@pellux/goodvibes-sdk": "0.18.29",
     "bash-language-server": "^5.6.0",
     "fuse.js": "^7.1.0",
     "graphql": "^16.13.2",

package/src/config/index.ts

@@ -15,7 +15,6 @@ export { ConfigError } from '@pellux/goodvibes-sdk/platform/types/errors';
 import { readFileSync } from 'fs';
 import { ConfigManager } from '@pellux/goodvibes-sdk/platform/config/manager';
 import type { GoodVibesConfig } from '@pellux/goodvibes-sdk/platform/config/schema';
-import { SecretsManager } from './secrets.ts';
 import { logger } from '@pellux/goodvibes-sdk/platform/utils/logger';
 import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils/error-display';
 
@@ -54,140 +53,4 @@ export function getConfiguredSystemPrompt(configManager: Pick<ConfigManager, 'ge
   }
 }
 
-export function getConfiguredApiKeys(): Record<string, string> {
-  return loadEnvApiKeys();
-}
-
-function loadEnvApiKeys(): Record<string, string> {
-  const keys: Record<string, string> = {};
-  const mapping: Record<string, string> = {
-    openai: 'OPENAI_API_KEY',
-    anthropic: 'ANTHROPIC_API_KEY',
-    gemini: 'GEMINI_API_KEY',
-    inceptionlabs: 'INCEPTION_API_KEY',
-    openrouter: 'OPENROUTER_API_KEY',
-    aihubmix: 'AIHUBMIX_API_KEY',
-    groq: 'GROQ_API_KEY',
-    cerebras: 'CEREBRAS_API_KEY',
-    mistral: 'MISTRAL_API_KEY',
-    'ollama-cloud': 'OLLAMA_CLOUD_API_KEY',
-    // Note: also checked as OLLAMA_API_KEY below
-    huggingface: 'HF_API_KEY',
-    nvidia: 'NVIDIA_API_KEY',
-    llm7: 'LLM7_API_KEY',
-    deepseek: 'DEEPSEEK_API_KEY',
-    fireworks: 'FIREWORKS_API_KEY',
-    'github-copilot': 'COPILOT_GITHUB_TOKEN',
-    'microsoft-foundry': 'AZURE_OPENAI_API_KEY',
-    minimax: 'MINIMAX_API_KEY',
-    moonshot: 'MOONSHOT_API_KEY',
-    qianfan: 'QIANFAN_API_KEY',
-    qwen: 'QWEN_API_KEY',
-    sglang: 'SGLANG_API_KEY',
-    stepfun: 'STEPFUN_API_KEY',
-    together: 'TOGETHER_API_KEY',
-    venice: 'VENICE_API_KEY',
-    volcengine: 'VOLCANO_ENGINE_API_KEY',
-    xai: 'XAI_API_KEY',
-    xiaomi: 'XIAOMI_API_KEY',
-    zai: 'ZAI_API_KEY',
-    'cloudflare-ai-gateway': 'CLOUDFLARE_AI_GATEWAY_API_KEY',
-    'vercel-ai-gateway': 'AI_GATEWAY_API_KEY',
-    litellm: 'LITELLM_API_KEY',
-    'copilot-proxy': 'COPILOT_PROXY_API_KEY',
-  };
-  for (const [prov, envVar] of Object.entries(mapping)) {
-    let value = process.env[envVar];
-    // Fallback env var names
-    if (!value && prov === 'gemini') value = process.env['GOOGLE_API_KEY'] ?? process.env['GOOGLE_GEMINI_API_KEY'];
-    if (!value && prov === 'openai') value = process.env['OPENAI_KEY'];
-    if (!value && prov === 'anthropic') value = process.env['CLAUDE_API_KEY'];
-    if (!value && prov === 'ollama-cloud') value = process.env['OLLAMA_API_KEY'];
-    if (!value && prov === 'huggingface') value = process.env['HUGGINGFACE_API_KEY'] ?? process.env['HF_TOKEN'];
-    if (!value && prov === 'github-copilot') value = process.env['GH_TOKEN'] ?? process.env['GITHUB_TOKEN'];
-    if (!value && prov === 'qwen') value = process.env['DASHSCOPE_API_KEY'] ?? process.env['MODELSTUDIO_API_KEY'];
-    if (!value && prov === 'zai') value = process.env['Z_AI_API_KEY'];
-    if (value) keys[prov] = value;
-  }
-  return keys;
-}
-
-/**
- * resolveApiKeys — three-tier async resolution for all provider API keys.
- *
- * Resolution order per key:
- *   1. Environment variable (process.env)
- *   2. SecretsManager hierarchy-aware stores (secure preferred, plaintext policy-aware)
- *   3. Omitted from result (null → skip)
- *
- * Returns a map of provider → apiKey for all providers where a key is found.
- */
-export async function resolveApiKeys(
-  secrets: Pick<SecretsManager, 'get'>,
-): Promise<Record<string, string>> {
-  const mapping: Array<{ prov: string; envVars: string[] }> = [
-    { prov: 'openai',       envVars: ['OPENAI_API_KEY', 'OPENAI_KEY'] },
-    { prov: 'anthropic',    envVars: ['ANTHROPIC_API_KEY', 'CLAUDE_API_KEY'] },
-    { prov: 'gemini',       envVars: ['GEMINI_API_KEY', 'GOOGLE_API_KEY', 'GOOGLE_GEMINI_API_KEY'] },
-    { prov: 'inceptionlabs', envVars: ['INCEPTION_API_KEY'] },
-    { prov: 'openrouter',    envVars: ['OPENROUTER_API_KEY'] },
-    { prov: 'aihubmix',     envVars: ['AIHUBMIX_API_KEY'] },
-    { prov: 'groq',          envVars: ['GROQ_API_KEY'] },
-    { prov: 'cerebras',      envVars: ['CEREBRAS_API_KEY'] },
-    { prov: 'mistral',       envVars: ['MISTRAL_API_KEY'] },
-    { prov: 'ollama-cloud',  envVars: ['OLLAMA_CLOUD_API_KEY', 'OLLAMA_API_KEY'] },
-    { prov: 'huggingface',   envVars: ['HF_API_KEY', 'HUGGINGFACE_API_KEY', 'HF_TOKEN'] },
-    { prov: 'nvidia',        envVars: ['NVIDIA_API_KEY'] },
-    { prov: 'llm7',          envVars: ['LLM7_API_KEY'] },
-    { prov: 'deepseek',      envVars: ['DEEPSEEK_API_KEY'] },
-    { prov: 'fireworks',     envVars: ['FIREWORKS_API_KEY'] },
-    { prov: 'github-copilot', envVars: ['COPILOT_GITHUB_TOKEN', 'GH_TOKEN', 'GITHUB_TOKEN'] },
-    { prov: 'microsoft-foundry', envVars: ['AZURE_OPENAI_API_KEY'] },
-    { prov: 'minimax',       envVars: ['MINIMAX_API_KEY'] },
-    { prov: 'moonshot',      envVars: ['MOONSHOT_API_KEY'] },
-    { prov: 'qianfan',       envVars: ['QIANFAN_API_KEY'] },
-    { prov: 'qwen',          envVars: ['QWEN_API_KEY', 'DASHSCOPE_API_KEY', 'MODELSTUDIO_API_KEY'] },
-    { prov: 'sglang',        envVars: ['SGLANG_API_KEY'] },
-    { prov: 'stepfun',       envVars: ['STEPFUN_API_KEY'] },
-    { prov: 'together',      envVars: ['TOGETHER_API_KEY'] },
-    { prov: 'venice',        envVars: ['VENICE_API_KEY'] },
-    { prov: 'volcengine',    envVars: ['VOLCANO_ENGINE_API_KEY'] },
-    { prov: 'xai',           envVars: ['XAI_API_KEY'] },
-    { prov: 'xiaomi',        envVars: ['XIAOMI_API_KEY'] },
-    { prov: 'zai',           envVars: ['ZAI_API_KEY', 'Z_AI_API_KEY'] },
-    { prov: 'cloudflare-ai-gateway', envVars: ['CLOUDFLARE_AI_GATEWAY_API_KEY'] },
-    { prov: 'vercel-ai-gateway', envVars: ['AI_GATEWAY_API_KEY'] },
-    { prov: 'litellm',       envVars: ['LITELLM_API_KEY'] },
-    { prov: 'copilot-proxy', envVars: ['COPILOT_PROXY_API_KEY'] },
-  ];
-
-  const result: Record<string, string> = {};
-
-  for (const { prov, envVars } of mapping) {
-    // Tier 1: environment variables
-    let value: string | null = null;
-    for (const envVar of envVars) {
-      if (process.env[envVar]) {
-        value = process.env[envVar]!;
-        break;
-      }
-    }
-
-    // Tier 2: SecretsManager hierarchy-aware secure/plaintext stores
-    if (value === null) {
-      for (const envVar of envVars) {
-        const stored = await secrets.get(envVar);
-        if (stored !== null) {
-          value = stored;
-          break;
-        }
-      }
-    }
-
-    if (value !== null) {
-      result[prov] = value;
-    }
-  }
-
-  return result;
-}
+export { getConfiguredApiKeys, resolveApiKeys } from '@pellux/goodvibes-sdk/platform/config/api-keys';

package/src/config/subscription-providers.ts

@@ -1,127 +1 @@
-import type { OAuthProviderConfig } from '@pellux/goodvibes-sdk/platform/config/subscriptions';
-import type { ServiceConfig } from './service-registry.ts';
-
-export interface BuiltinSubscriptionProvider {
-  readonly provider: string;
-  readonly displayName: string;
-  readonly authType: 'oauth';
-  readonly tokenKey: string;
-  readonly providerId: string;
-  readonly oauth: OAuthProviderConfig;
-  readonly notes: readonly string[];
-}
-
-export interface AvailableSubscriptionProvider {
-  readonly provider: string;
-  readonly displayName: string;
-  readonly source: 'builtin' | 'service';
-  readonly oauth: OAuthProviderConfig;
-  readonly tokenKey: string;
-  readonly providerId: string;
-  readonly notes: readonly string[];
-}
-
-const OPENAI_SUBSCRIPTION_PROVIDER: BuiltinSubscriptionProvider = {
-  provider: 'openai',
-  displayName: 'OpenAI Codex',
-  authType: 'oauth',
-  tokenKey: 'OPENAI_API_KEY',
-  providerId: 'openai',
-  oauth: {
-    authUrl: 'https://auth.openai.com/oauth/authorize',
-    tokenUrl: 'https://auth.openai.com/oauth/token',
-    clientId: 'app_EMoamEEZ73f0CkXaXp7hrann',
-    redirectUri: 'http://localhost:1455/auth/callback',
-    scopes: ['openid', 'profile', 'email', 'offline_access'],
-    usePkce: true,
-    tokenRequestEncoding: 'form',
-    refreshRequestEncoding: 'form',
-    overrideAmbientApiKeys: false,
-    authParams: {
-      id_token_add_organizations: 'true',
-      codex_cli_simplified_flow: 'true',
-      originator: 'pi',
-    },
-    localCallback: {
-      host: 'localhost',
-      port: 1455,
-      path: '/auth/callback',
-      autoComplete: true,
-    },
-  },
-  notes: [
-    'Built-in OpenAI Codex / ChatGPT subscription login path.',
-    'Uses the Codex/ChatGPT OAuth flow rather than the standard OpenAI API-key path.',
-  ],
-};
-
-const BUILTIN_SUBSCRIPTION_PROVIDERS: Record<string, BuiltinSubscriptionProvider> = {
-  openai: OPENAI_SUBSCRIPTION_PROVIDER,
-};
-
-export function listBuiltinSubscriptionProviders(): BuiltinSubscriptionProvider[] {
-  return Object.values(BUILTIN_SUBSCRIPTION_PROVIDERS)
-    .slice()
-    .sort((a, b) => a.provider.localeCompare(b.provider));
-}
-
-export function getBuiltinSubscriptionProvider(provider: string): BuiltinSubscriptionProvider | null {
-  return BUILTIN_SUBSCRIPTION_PROVIDERS[provider] ?? null;
-}
-
-export function getSubscriptionProviderConfig(
-  provider: string,
-  serviceConfig?: ServiceConfig | null,
-): { oauth: OAuthProviderConfig; source: 'service' | 'builtin'; tokenKey: string; providerId: string } | null {
-  if (serviceConfig?.authType === 'oauth' && serviceConfig.oauth) {
-    return {
-      oauth: serviceConfig.oauth,
-      source: 'service',
-      tokenKey: serviceConfig.tokenKey,
-      providerId: serviceConfig.providerId ?? serviceConfig.name,
-    };
-  }
-
-  const builtin = getBuiltinSubscriptionProvider(provider);
-  if (!builtin) return null;
-  return {
-    oauth: builtin.oauth,
-    source: 'builtin',
-    tokenKey: builtin.tokenKey,
-    providerId: builtin.providerId,
-  };
-}
-
-export function listAvailableSubscriptionProviders(
-  services: Record<string, ServiceConfig>,
-): AvailableSubscriptionProvider[] {
-  const providers = new Map<string, AvailableSubscriptionProvider>();
-
-  for (const builtin of listBuiltinSubscriptionProviders()) {
-    providers.set(builtin.provider, {
-      provider: builtin.provider,
-      displayName: builtin.displayName,
-      source: 'builtin',
-      oauth: builtin.oauth,
-      tokenKey: builtin.tokenKey,
-      providerId: builtin.providerId,
-      notes: builtin.notes,
-    });
-  }
-
-  for (const service of Object.values(services)) {
-    if (service.authType !== 'oauth' || !service.oauth) continue;
-    const provider = service.providerId ?? service.name;
-    providers.set(provider, {
-      provider,
-      displayName: service.name,
-      source: 'service',
-      oauth: service.oauth,
-      tokenKey: service.tokenKey,
-      providerId: provider,
-      notes: ['Configured through .goodvibes/tui/services.json'],
-    });
-  }
-
-  return [...providers.values()].sort((a, b) => a.provider.localeCompare(b.provider));
-}
+export * from '@pellux/goodvibes-sdk/platform/config/subscription-providers';

package/src/core/conversation-rendering.ts

@@ -3,16 +3,16 @@ import { renderMarkdown, renderMarkdownTracked } from '../renderer/markdown.ts';
 import { renderToolCallBlock } from '../renderer/tool-call.ts';
 import { renderThinkingBlock } from '../renderer/thinking.ts';
 import { renderSystemMessage } from '../renderer/system-message.ts';
-import { createEmptyLine, type Line, type Cell } from '@pellux/goodvibes-sdk/platform/types/grid';
-import { getSplashLines, type SplashOptions } from '@pellux/goodvibes-sdk/platform/utils/splash-lines';
-import { interpolateColor, getDisplayWidth, wrapText } from '@pellux/goodvibes-sdk/platform/utils/terminal-width';
+import { createEmptyLine, type Line, type Cell } from '../types/grid.ts';
+import { getSplashLines, type SplashOptions } from '../utils/splash-lines.ts';
+import { interpolateColor, getDisplayWidth, wrapText } from '../utils/terminal-width.ts';
 import { LAYOUT } from '../renderer/layout.ts';
 import type { ConfigManager } from '@pellux/goodvibes-sdk/platform/config/manager';
 import { renderConversationCollapsedFragment, renderConversationEventLine } from '../renderer/conversation-surface.ts';
 import { GLYPHS } from '../renderer/ui-primitives.ts';
 import type { BlockMeta, ConversationMessageSnapshot } from './conversation';
-import { parseDiffForApply } from './conversation-diff';
-import { extractUserDisplayText } from './conversation-utils';
+import { parseDiffForApply } from '@pellux/goodvibes-sdk/platform/core/conversation-diff';
+import { extractUserDisplayText } from '@pellux/goodvibes-sdk/platform/core/conversation-utils';
 
 type Message = ConversationMessageSnapshot;