@pellux/goodvibes-tui 0.18.11 → 0.18.13

package/src/hooks/dispatcher.ts

@@ -1,414 +0,0 @@
-import { readFileSync, statSync } from 'fs';
-import { dirname } from 'path';
-import type { HookDefinition, HookChain, HookEvent, HookResult } from '@pellux/goodvibes-sdk/platform/hooks/types';
-import { matchesEventPath, matchesMatcher } from '@pellux/goodvibes-sdk/platform/hooks/matcher';
-import { getHookPointContract } from '@pellux/goodvibes-sdk/platform/hooks/contracts';
-import { HookActivityTracker } from '@pellux/goodvibes-sdk/platform/hooks/activity';
-import { logger } from '@pellux/goodvibes-sdk/platform/utils/logger';
-import type { HooksConfig } from '@pellux/goodvibes-sdk/platform/hooks/types';
-import type { AgentManager } from '@pellux/goodvibes-sdk/platform/tools/agent/index';
-import type { ToolLLM } from '@pellux/goodvibes-sdk/platform/config/tool-llm';
-import * as commandRunner from '@pellux/goodvibes-sdk/platform/hooks/runners/command';
-import * as promptRunner from '@pellux/goodvibes-sdk/platform/hooks/runners/prompt';
-import * as agentRunner from '@pellux/goodvibes-sdk/platform/hooks/runners/agent';
-import * as httpRunner from '@pellux/goodvibes-sdk/platform/hooks/runners/http';
-import * as tsRunner from '@pellux/goodvibes-sdk/platform/hooks/runners/typescript';
-import { fireTriggers } from '@pellux/goodvibes-sdk/platform/workflow/trigger-executor';
-import type { TriggerManagerLike } from '@pellux/goodvibes-sdk/platform/workflow/trigger-executor';
-import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils/error-display';
-
-type HookRunnerDeps = {
-  readonly agentManager?: Pick<AgentManager, 'spawn' | 'getStatus' | 'cancel'>;
-  readonly toolLLM?: Pick<ToolLLM, 'chat'>;
-  readonly projectRoot?: string;
-};
-
-/** Global timeout: if cumulative hook time exceeds this, skip remaining */
-const GLOBAL_TIMEOUT_MS = 120_000;
-
-function runHook(
-  hook: HookDefinition,
-  event: HookEvent,
-  deps: HookRunnerDeps,
-  hooksBaseDirectory: string | null,
-): Promise<HookResult> {
-  switch (hook.type) {
-    case 'command': return commandRunner.run(hook, event);
-    case 'prompt': return promptRunner.run(hook, event, deps.toolLLM ?? null);
-    case 'agent':
-      if (!deps.agentManager) {
-        return Promise.resolve({ ok: false, error: 'agent hook runner is not configured in this runtime' });
-      }
-      return agentRunner.run(hook, event, deps.agentManager);
-    case 'http': return httpRunner.run(hook, event);
-    case 'ts': {
-      const projectRoot = deps.projectRoot ?? hooksBaseDirectory;
-      if (!projectRoot) {
-        return Promise.resolve({ ok: false, error: 'ts hook runner requires an explicit project root' });
-      }
-      return tsRunner.run(hook, event, projectRoot);
-    }
-    default:
-      return Promise.resolve({ ok: false, error: `unknown hook type: ${(hook as HookDefinition).type}` });
-  }
-}
-
-export class HookDispatcher {
-  private hooks = new Map<string, HookDefinition[]>();
-  private chains: HookChain[] = [];
-  private triggerManager: TriggerManagerLike | null = null;
-  private hooksBaseDirectory: string | null = null;
-  private readonly runnerDeps: HookRunnerDeps;
-  private readonly activityTracker: HookActivityTracker;
-
-  constructor(runnerDeps: HookRunnerDeps = {}, activityTracker: HookActivityTracker = new HookActivityTracker()) {
-    this.runnerDeps = runnerDeps;
-    this.activityTracker = activityTracker;
-  }
-
-  /** Attach a TriggerManager so hook events automatically fire matching triggers. */
-  setTriggerManager(tm: TriggerManagerLike | null): void {
-    this.triggerManager = tm;
-  }
-
-  /** Load hooks from hooks.json file */
-  loadFromFile(filePath: string): void {
-    this.hooksBaseDirectory = dirname(filePath);
-    try {
-      // Warn if hooks.json is world-writable — it is a trust boundary.
-      try {
-        const st = statSync(filePath);
-        // st.mode & 0o002 is the world-writable bit
-        if ((st.mode & 0o002) !== 0) {
-          logger.info(
-            'HookDispatcher: hooks.json is world-writable — only load trusted hooks files',
-            { filePath },
-          );
-        }
-      } catch {
-        // Stat failure is non-fatal; proceed with load
-      }
-
-      const raw = readFileSync(filePath, 'utf-8');
-      const parsed = JSON.parse(raw) as Record<string, unknown>;
-
-      const VALID_HOOK_TYPES = new Set(['command', 'prompt', 'agent', 'http', 'ts']);
-
-      // Validate and load hooks
-      if (parsed.hooks !== undefined) {
-        if (typeof parsed.hooks !== 'object' || parsed.hooks === null || Array.isArray(parsed.hooks)) {
-          logger.info('HookDispatcher: hooks.json "hooks" field must be an object, skipping', { filePath });
-        } else {
-          for (const [pattern, defs] of Object.entries(parsed.hooks as Record<string, unknown>)) {
-            if (!Array.isArray(defs)) {
-              logger.info('HookDispatcher: hook pattern value must be an array, skipping', { filePath, pattern });
-              continue;
-            }
-            for (const def of defs as unknown[]) {
-              if (typeof def !== 'object' || def === null) {
-                logger.info('HookDispatcher: hook definition must be an object, skipping', { filePath, pattern });
-                continue;
-              }
-              const d = def as Record<string, unknown>;
-              if (typeof d.type !== 'string' || !VALID_HOOK_TYPES.has(d.type)) {
-                logger.info('HookDispatcher: hook missing valid "type" field, skipping', { filePath, pattern, type: d.type });
-                continue;
-              }
-              if (typeof d.match !== 'string') {
-                logger.info('HookDispatcher: hook missing "match" field, skipping', { filePath, pattern });
-                continue;
-              }
-              this.register(pattern, d as unknown as import('@pellux/goodvibes-sdk/platform/hooks/types').HookDefinition);
-            }
-          }
-        }
-      }
-
-      // Validate and load chains
-      if (parsed.chains !== undefined) {
-        if (!Array.isArray(parsed.chains)) {
-          logger.info('HookDispatcher: hooks.json "chains" field must be an array, skipping', { filePath });
-        } else {
-          for (const chain of parsed.chains as unknown[]) {
-            if (typeof chain !== 'object' || chain === null) {
-              logger.info('HookDispatcher: chain entry must be an object, skipping', { filePath });
-              continue;
-            }
-            const c = chain as Record<string, unknown>;
-            if (typeof c.name !== 'string') {
-              logger.info('HookDispatcher: chain missing "name" field, skipping', { filePath });
-              continue;
-            }
-            if (!Array.isArray(c.steps)) {
-              logger.info('HookDispatcher: chain missing "steps" array, skipping', { filePath, name: c.name });
-              continue;
-            }
-            if (typeof c.action !== 'object' || c.action === null) {
-              logger.info('HookDispatcher: chain missing "action" object, skipping', { filePath, name: c.name });
-              continue;
-            }
-            const action = c.action as Record<string, unknown>;
-            if (typeof action.type !== 'string' || !VALID_HOOK_TYPES.has(action.type)) {
-              logger.info('HookDispatcher: chain action missing valid "type" field, skipping', { filePath, name: c.name });
-              continue;
-            }
-            if (typeof action.match !== 'string') {
-              logger.info('HookDispatcher: chain action missing "match" field, skipping', { filePath, name: c.name });
-              continue;
-            }
-            this.registerChain(c as unknown as import('@pellux/goodvibes-sdk/platform/hooks/types').HookChain);
-          }
-        }
-      }
-    } catch (err) {
-      logger.error('HookDispatcher: failed to load hooks file', {
-        filePath,
-        error: summarizeError(err),
-      });
-    }
-  }
-
-  /** Register a hook programmatically */
-  register(eventPattern: string, hook: HookDefinition): void {
-    const existing = this.hooks.get(eventPattern);
-    if (existing) {
-      existing.push(hook);
-    } else {
-      this.hooks.set(eventPattern, [hook]);
-    }
-  }
-
-  /** Register a chain programmatically */
-  registerChain(chain: HookChain): void {
-    this.chains.push(chain);
-  }
-
-  /**
-   * Fire an event and run all matching hooks.
-   *
-   * All matching hooks run sequentially. For Pre phase, the first deny sets
-   * the aggregated decision; subsequent hooks still execute (for
-   * logging/auditing) but their deny decisions don't change the outcome.
-   * For all hooks: additionalContext strings are concatenated.
-   * Once hooks are auto-removed after first execution.
-   * Async hooks fire and forget.
-   */
-  async fire(event: HookEvent): Promise<HookResult> {
-    const contract = getHookPointContract(event.path);
-    const matchingEntries: Array<{ pattern: string; hook: HookDefinition }> = [];
-
-    for (const [pattern, defs] of this.hooks.entries()) {
-      if (matchesEventPath(pattern, event.path)) {
-        for (const hook of defs) {
-          const specificValue = event.specific;
-          if (matchesMatcher(hook.matcher, specificValue)) {
-            matchingEntries.push({ pattern, hook });
-          }
-        }
-      }
-    }
-
-    if (matchingEntries.length === 0) {
-      return { ok: true };
-    }
-
-    const aggregated: HookResult = { ok: true };
-    const contextParts: string[] = [];
-    let updatedInput: Record<string, unknown> | undefined;
-    const onceToRemove: Array<{ pattern: string; hook: HookDefinition }> = [];
-    const startTime = Date.now();
-
-    for (const { pattern, hook } of matchingEntries) {
-      // Global timeout check
-      if (Date.now() - startTime > GLOBAL_TIMEOUT_MS) {
-        logger.error('HookDispatcher: global timeout exceeded, skipping remaining hooks', {
-          path: event.path,
-        });
-        break;
-      }
-
-      // Async hooks fire and forget
-      if (hook.async) {
-        const asyncStart = Date.now();
-        runHook(hook, event, this.runnerDeps, this.hooksBaseDirectory)
-          .then((result) => {
-            this.activityTracker.record(event, {
-              pattern,
-              hookName: hook.name,
-              hookType: hook.type,
-              result,
-              durationMs: Date.now() - asyncStart,
-              async: true,
-            });
-          })
-          .catch((err) => {
-            const message = summarizeError(err);
-            logger.error('HookDispatcher: async hook error', {
-              path: event.path,
-              error: message,
-            });
-            this.activityTracker.record(event, {
-              pattern,
-              hookName: hook.name,
-              hookType: hook.type,
-              result: { ok: false, error: message },
-              durationMs: Date.now() - asyncStart,
-              async: true,
-            });
-          });
-        if (hook.once) onceToRemove.push({ pattern, hook });
-        continue;
-      }
-
-      let result: HookResult;
-      const hookStart = Date.now();
-      try {
-        result = await runHook(hook, event, this.runnerDeps, this.hooksBaseDirectory);
-      } catch (err) {
-        const message = summarizeError(err);
-        logger.error('HookDispatcher: hook threw unexpectedly', {
-          path: event.path,
-          error: message,
-        });
-        result = { ok: false, error: message };
-      }
-      this.activityTracker.record(event, {
-        pattern,
-        hookName: hook.name,
-        hookType: hook.type,
-        result,
-        durationMs: Date.now() - hookStart,
-        async: false,
-      });
-
-      if (hook.once) onceToRemove.push({ pattern, hook });
-
-      if (!result.ok) {
-        aggregated.ok = false;
-        if (!aggregated.error) aggregated.error = result.error;
-      }
-
-      // For Pre hooks: first deny wins
-      if ((contract?.canDeny ?? event.phase === 'Pre') && result.decision === 'deny') {
-        if (aggregated.decision !== 'deny') {
-          aggregated.decision = 'deny';
-          aggregated.reason = result.reason;
-        }
-      } else if (result.decision && (contract?.canDeny ?? event.phase === 'Pre') && aggregated.decision !== 'deny') {
-        aggregated.decision = result.decision;
-        if (result.reason) aggregated.reason = result.reason;
-      }
-
-      // Last updatedInput wins
-      if (result.updatedInput && (contract?.canMutateInput ?? true)) {
-        updatedInput = result.updatedInput;
-      }
-
-      if (result.additionalContext && (contract?.canInjectContext ?? true)) {
-        contextParts.push(result.additionalContext);
-      }
-    }
-
-    // Remove once hooks
-    for (const { pattern, hook } of onceToRemove) {
-      const defs = this.hooks.get(pattern);
-      if (defs) {
-        const idx = defs.indexOf(hook);
-        if (idx !== -1) defs.splice(idx, 1);
-        if (defs.length === 0) this.hooks.delete(pattern);
-      }
-    }
-
-    if (updatedInput) aggregated.updatedInput = updatedInput;
-    if (contextParts.length > 0) aggregated.additionalContext = contextParts.join('\n');
-
-    // Fire matching triggers (fire-and-forget)
-    if (this.triggerManager) {
-      fireTriggers(event, this.triggerManager).catch((err) => {
-        logger.debug('HookDispatcher: trigger fire error', {
-          path: event.path,
-          error: summarizeError(err),
-        });
-      });
-    }
-
-    return aggregated;
-  }
-
-  /** Get all registered hooks (for debugging/inspection) */
-  getHooks(): Map<string, HookDefinition[]> {
-    return new Map(this.hooks);
-  }
-
-  /** Get all registered chains */
-  getChains(): HookChain[] {
-    return [...this.chains];
-  }
-
-  /** Remove all hooks (for testing) */
-  clear(): void {
-    this.hooks.clear();
-    this.chains = [];
-  }
-
-  /**
-   * List all registered hooks as a flat array with their event pattern included.
-   */
-  listHooks(): Array<{ pattern: string; hook: HookDefinition }> {
-    const result: Array<{ pattern: string; hook: HookDefinition }> = [];
-    for (const [pattern, defs] of this.hooks.entries()) {
-      for (const hook of defs) {
-        result.push({ pattern, hook });
-      }
-    }
-    return result;
-  }
-
-  /**
-   * Enable a named hook (sets enabled: true).
-   * Returns true if found, false if no hook with that name exists.
-   */
-  enableHook(name: string): boolean {
-    for (const defs of this.hooks.values()) {
-      for (const hook of defs) {
-        if (hook.name === name) {
-          hook.enabled = true;
-          return true;
-        }
-      }
-    }
-    return false;
-  }
-
-  /**
-   * Disable a named hook (sets enabled: false).
-   * Returns true if found, false if no hook with that name exists.
-   */
-  disableHook(name: string): boolean {
-    for (const defs of this.hooks.values()) {
-      for (const hook of defs) {
-        if (hook.name === name) {
-          hook.enabled = false;
-          return true;
-        }
-      }
-    }
-    return false;
-  }
-
-  /**
-   * Remove a named hook from the registry.
-   * Returns true if removed, false if not found.
-   */
-  unregister(name: string): boolean {
-    for (const [pattern, defs] of this.hooks.entries()) {
-      const idx = defs.findIndex((h) => h.name === name);
-      if (idx !== -1) {
-        defs.splice(idx, 1);
-        if (defs.length === 0) this.hooks.delete(pattern);
-        return true;
-      }
-    }
-    return false;
-  }
-}

package/src/hooks/hook-api.ts

@@ -1,170 +0,0 @@
-import type { HookPointContract } from '@pellux/goodvibes-sdk/platform/hooks/contracts';
-import type { HookChain, HookDefinition, HookType } from '@pellux/goodvibes-sdk/platform/hooks/types';
-import type {
-  HookAuthoringAction,
-  HookConfigInspection,
-  HookSimulationResult,
-} from '@pellux/goodvibes-sdk/platform/hooks/workbench';
-
-export interface HookContractRecord extends HookPointContract {}
-
-export interface HookWorkbenchApi {
-  getFilePath(): string;
-  listManagedHooks(): Array<{ pattern: string; hook: HookDefinition }>;
-  listManagedChains(): HookChain[];
-  listRecentActions(limit?: number): HookAuthoringAction[];
-  load(path?: string): void;
-  reload(path?: string): Promise<void>;
-  scaffoldHook(name: string, match: string, type: HookType): Promise<HookDefinition>;
-  scaffoldChain(name: string, matches: readonly string[]): Promise<HookChain>;
-  remove(name: string): Promise<boolean>;
-  toggle(name: string, enabled: boolean): Promise<boolean>;
-  simulate(eventPath: string, payload?: Record<string, unknown>): HookSimulationResult;
-  inspect(path: string): HookConfigInspection;
-  export(path: string): Promise<string>;
-  import(path: string, strategy?: 'merge' | 'replace'): Promise<void>;
-}
-
-export interface HookApiDispatcher {
-  listHooks(): Array<{ pattern: string; hook: HookDefinition }>;
-  listChains(): HookChain[];
-}
-
-export interface HookApiWorkbenchRuntime {
-  getHooksFilePath(): string;
-  listManagedHooks(): Array<{ pattern: string; hook: HookDefinition }>;
-  listManagedChains(): HookChain[];
-  listRecentActions(limit?: number): HookAuthoringAction[];
-  loadManagedConfig(path?: string): void;
-  loadAndApplyManagedHooks(path?: string): Promise<void>;
-  scaffoldHook(name: string, match: string, type: HookType): HookDefinition;
-  scaffoldChain(name: string, matches: readonly string[]): HookChain;
-  removeManagedEntry(name: string): boolean;
-  toggleManagedHook(name: string, enabled: boolean): boolean;
-  simulate(eventPath: string, payload?: Record<string, unknown>): HookSimulationResult;
-  inspectManagedConfig(path: string): HookConfigInspection;
-  exportManagedConfig(path: string): Promise<string>;
-  importManagedConfig(path: string, strategy?: 'merge' | 'replace'): void;
-  saveManagedConfig(path?: string): Promise<void>;
-}
-
-export interface HookContractSource {
-  listContracts(): readonly HookPointContract[];
-}
-
-export interface HookApi {
-  contracts(filter?: string): readonly HookContractRecord[];
-  dispatcher: {
-    listHooks(): Array<{ pattern: string; hook: HookDefinition }>;
-    listChains(): HookChain[];
-  };
-  workbench: HookWorkbenchApi;
-}
-
-export interface CreateHookApiOptions {
-  readonly dispatcher: HookApiDispatcher;
-  readonly workbench: HookApiWorkbenchRuntime;
-  readonly listContracts: HookContractSource['listContracts'];
-}
-
-function normalizeFilter(filter: string | undefined): string | null {
-  const value = filter?.trim().toLowerCase();
-  return value && value.length > 0 ? value : null;
-}
-
-export function createHookApi(options: CreateHookApiOptions): HookApi {
-  return {
-    contracts(filter?: string): readonly HookContractRecord[] {
-      const query = normalizeFilter(filter);
-      const contracts = options.listContracts();
-      if (!query) {
-        return contracts;
-      }
-      return contracts.filter((contract) => (
-        contract.pattern.toLowerCase().includes(query)
-        || contract.description.toLowerCase().includes(query)
-        || contract.authority.toLowerCase().includes(query)
-        || contract.executionMode.toLowerCase().includes(query)
-      ));
-    },
-    dispatcher: {
-      listHooks(): Array<{ pattern: string; hook: HookDefinition }> {
-        return options.dispatcher.listHooks();
-      },
-      listChains(): HookChain[] {
-        return options.dispatcher.listChains();
-      },
-    },
-    workbench: {
-      getFilePath(): string {
-        return options.workbench.getHooksFilePath();
-      },
-      listManagedHooks(): Array<{ pattern: string; hook: HookDefinition }> {
-        return options.workbench.listManagedHooks();
-      },
-      listManagedChains(): HookChain[] {
-        return options.workbench.listManagedChains();
-      },
-      listRecentActions(limit = 8): HookAuthoringAction[] {
-        return options.workbench.listRecentActions(limit);
-      },
-      load(path?: string): void {
-        options.workbench.loadManagedConfig(path);
-      },
-      reload(path?: string): Promise<void> {
-        return options.workbench.loadAndApplyManagedHooks(path);
-      },
-      async scaffoldHook(name: string, match: string, type: HookType): Promise<HookDefinition> {
-        options.workbench.loadManagedConfig();
-        const hook = options.workbench.scaffoldHook(name, match, type);
-        await options.workbench.saveManagedConfig();
-        await options.workbench.loadAndApplyManagedHooks();
-        return hook;
-      },
-      async scaffoldChain(name: string, matches: readonly string[]): Promise<HookChain> {
-        options.workbench.loadManagedConfig();
-        const chain = options.workbench.scaffoldChain(name, matches);
-        await options.workbench.saveManagedConfig();
-        await options.workbench.loadAndApplyManagedHooks();
-        return chain;
-      },
-      async remove(name: string): Promise<boolean> {
-        options.workbench.loadManagedConfig();
-        const removed = options.workbench.removeManagedEntry(name);
-        if (!removed) {
-          return false;
-        }
-        await options.workbench.saveManagedConfig();
-        await options.workbench.loadAndApplyManagedHooks();
-        return true;
-      },
-      async toggle(name: string, enabled: boolean): Promise<boolean> {
-        options.workbench.loadManagedConfig();
-        const changed = options.workbench.toggleManagedHook(name, enabled);
-        if (!changed) {
-          return false;
-        }
-        await options.workbench.saveManagedConfig();
-        await options.workbench.loadAndApplyManagedHooks();
-        return true;
-      },
-      simulate(eventPath: string, payload: Record<string, unknown> = {}): HookSimulationResult {
-        options.workbench.loadManagedConfig();
-        return options.workbench.simulate(eventPath, payload);
-      },
-      inspect(path: string): HookConfigInspection {
-        return options.workbench.inspectManagedConfig(path);
-      },
-      export(path: string): Promise<string> {
-        options.workbench.loadManagedConfig();
-        return options.workbench.exportManagedConfig(path);
-      },
-      async import(path: string, strategy: 'merge' | 'replace' = 'merge'): Promise<void> {
-        options.workbench.loadManagedConfig();
-        options.workbench.importManagedConfig(path, strategy);
-        await options.workbench.saveManagedConfig();
-        await options.workbench.loadAndApplyManagedHooks();
-      },
-    },
-  };
-}

package/src/hooks/index.ts

@@ -1,48 +0,0 @@
-export { HookDispatcher } from '@pellux/goodvibes-sdk/platform/hooks/dispatcher';
-export { ChainEngine } from '@pellux/goodvibes-sdk/platform/hooks/chain-engine';
-export { HookActivityTracker } from '@pellux/goodvibes-sdk/platform/hooks/activity';
-export { HookWorkbench, createHookWorkbench } from '@pellux/goodvibes-sdk/platform/hooks/workbench';
-export { createHookApi } from '@pellux/goodvibes-sdk/platform/hooks/hook-api';
-export type {
-  CreateHookApiOptions,
-  HookApi,
-  HookApiDispatcher,
-  HookApiWorkbenchRuntime,
-  HookContractRecord,
-  HookContractSource,
-  HookWorkbenchApi,
-} from '@pellux/goodvibes-sdk/platform/hooks/hook-api';
-export type {
-  HookPhase,
-  HookCategory,
-  HookEventPath,
-  HookEvent,
-  HookResult,
-  HookType,
-  HookDefinition,
-  ChainStep,
-  HookChain,
-  HooksConfig,
-} from '@pellux/goodvibes-sdk/platform/hooks/types';
-export type { HookActivityRecord } from '@pellux/goodvibes-sdk/platform/hooks/activity';
-export type { HookAuthoringAction, HookConfigInspection, HookSimulationResult } from '@pellux/goodvibes-sdk/platform/hooks/workbench';
-export type { HookExecutionMode, HookAuthority, HookPointContract } from '@pellux/goodvibes-sdk/platform/hooks/contracts';
-import type { AgentManager } from '@pellux/goodvibes-sdk/platform/tools/agent/index';
-export {
-  listHookPointContracts,
-  getHookPointContract,
-  parseHookPath,
-} from '@pellux/goodvibes-sdk/platform/hooks/contracts';
-
-import { HookActivityTracker } from '@pellux/goodvibes-sdk/platform/hooks/activity';
-import { HookDispatcher } from '@pellux/goodvibes-sdk/platform/hooks/dispatcher';
-
-export function createHookDispatcher(config: {
-  readonly agentManager?: Pick<AgentManager, 'spawn' | 'getStatus' | 'cancel'>;
-  readonly activityTracker?: HookActivityTracker;
-} = {}): HookDispatcher {
-  return new HookDispatcher(
-    { agentManager: config.agentManager },
-    config.activityTracker,
-  );
-}