@pellux/goodvibes-agent 0.1.117 → 1.0.0

package/src/runtime/onboarding/apply-file-helpers.ts

@@ -0,0 +1,66 @@
+import { existsSync, mkdirSync, readFileSync, unlinkSync, writeFileSync } from 'node:fs';
+import { dirname } from 'node:path';
+
+export type RollbackAction = () => Promise<void> | void;
+
+export function isPlainObject(value: unknown): value is Record<string, unknown> {
+  return typeof value === 'object' && value !== null && !Array.isArray(value);
+}
+
+export function readJsonObject(path: string): Record<string, unknown> {
+  if (!existsSync(path)) return {};
+  const parsed = JSON.parse(readFileSync(path, 'utf-8')) as unknown;
+  if (!isPlainObject(parsed)) throw new Error(`Expected an object JSON payload at ${path}.`);
+  return parsed;
+}
+
+export function writeJsonObject(path: string, payload: Record<string, unknown>): void {
+  mkdirSync(dirname(path), { recursive: true });
+  writeFileSync(path, `${JSON.stringify(payload, null, 2)}\n`, 'utf-8');
+}
+
+export function setNestedValue(root: Record<string, unknown>, key: string, value: unknown): Record<string, unknown> {
+  const parts = key.split('.');
+  const next = structuredClone(root);
+  let cursor: Record<string, unknown> = next;
+
+  for (let index = 0; index < parts.length - 1; index += 1) {
+    const part = parts[index]!;
+    let existing = cursor[part];
+    if (!isPlainObject(existing)) {
+      existing = {};
+      cursor[part] = existing;
+    }
+    cursor = existing as Record<string, unknown>;
+  }
+
+  cursor[parts[parts.length - 1]!] = structuredClone(value);
+  return next;
+}
+
+export function restoreFile(path: string, previous: string | null, reload?: () => void): void {
+  if (previous === null) {
+    if (existsSync(path)) unlinkSync(path);
+  } else {
+    mkdirSync(dirname(path), { recursive: true });
+    writeFileSync(path, previous, 'utf-8');
+  }
+  reload?.();
+}
+
+export function snapshotFileRollback(path: string, reload?: () => void): RollbackAction {
+  const previous = existsSync(path) ? readFileSync(path, 'utf-8') : null;
+  return () => restoreFile(path, previous, reload);
+}
+
+export async function runRollbacks(rollbacks: readonly RollbackAction[]): Promise<readonly string[]> {
+  const errors: string[] = [];
+  for (const rollback of [...rollbacks].reverse()) {
+    try {
+      await rollback();
+    } catch (error) {
+      errors.push(error instanceof Error ? error.message : String(error));
+    }
+  }
+  return errors;
+}

package/src/runtime/onboarding/apply.ts

@@ -1,5 +1,4 @@
-import { existsSync, mkdirSync, readFileSync, rmSync, unlinkSync, writeFileSync } from 'node:fs';
-import { dirname } from 'node:path';
+import { existsSync, readFileSync, rmSync } from 'node:fs';
 import { isSecretRefInput } from '@pellux/goodvibes-sdk/platform/config';
 import { CONFIG_SCHEMA, DEFAULT_CONFIG } from '../../config/index.ts';
 import {
@@ -10,10 +9,16 @@ import {
   resolveAgentRuntimeProfileHome,
   setAgentRuntimeProfileSelection,
 } from '../../agent/runtime-profile.ts';
+import { AgentNoteRegistry } from '../../agent/note-registry.ts';
 import { AgentPersonaRegistry, assertNoSecretLikeText } from '../../agent/persona-registry.ts';
 import { AgentRoutineRegistry } from '../../agent/routine-registry.ts';
 import { AgentSkillRegistry } from '../../agent/skill-registry.ts';
-import type { FeatureFlagConfigKey } from '../surface-feature-flags.ts';
+import {
+  isFeatureFlagConfigKey,
+  mergeFeatureFlagConfigValue,
+  readFeatureFlagConfigValue,
+  type FeatureFlagConfigKey,
+} from '../surface-feature-flags.ts';
 import {
   getOnboardingRuntimeStatePath,
   readOnboardingRuntimeState,
@@ -29,72 +34,12 @@ import type {
   OnboardingApplyRequest,
   OnboardingApplyResult,
 } from './types.ts';
+import { isPlainObject, readJsonObject, restoreFile, runRollbacks, setNestedValue, snapshotFileRollback, writeJsonObject, type RollbackAction } from './apply-file-helpers.ts';
 
 function getNow(deps: Pick<OnboardingApplyDependencies, 'clock'>): number {
   return deps.clock?.() ?? Date.now();
 }
 
-function isPlainObject(value: unknown): value is Record<string, unknown> {
-  return typeof value === 'object' && value !== null && !Array.isArray(value);
-}
-
-function readJsonObject(path: string): Record<string, unknown> {
-  if (!existsSync(path)) return {};
-  const parsed = JSON.parse(readFileSync(path, 'utf-8')) as unknown;
-  if (!isPlainObject(parsed)) throw new Error(`Expected an object JSON payload at ${path}.`);
-  return parsed;
-}
-
-function writeJsonObject(path: string, payload: Record<string, unknown>): void {
-  mkdirSync(dirname(path), { recursive: true });
-  writeFileSync(path, `${JSON.stringify(payload, null, 2)}\n`, 'utf-8');
-}
-
-function setNestedValue(root: Record<string, unknown>, key: string, value: unknown): Record<string, unknown> {
-  const parts = key.split('.');
-  const next = structuredClone(root);
-  let cursor: Record<string, unknown> = next;
-
-  for (let index = 0; index < parts.length - 1; index += 1) {
-    const part = parts[index]!;
-    const existing = cursor[part];
-    if (!isPlainObject(existing)) cursor[part] = {};
-    cursor = cursor[part] as Record<string, unknown>;
-  }
-
-  cursor[parts[parts.length - 1]!] = structuredClone(value);
-  return next;
-}
-
-type RollbackAction = () => Promise<void> | void;
-
-function restoreFile(path: string, previous: string | null, reload?: () => void): void {
-  if (previous === null) {
-    if (existsSync(path)) unlinkSync(path);
-  } else {
-    mkdirSync(dirname(path), { recursive: true });
-    writeFileSync(path, previous, 'utf-8');
-  }
-  reload?.();
-}
-
-function snapshotFileRollback(path: string, reload?: () => void): RollbackAction {
-  const previous = existsSync(path) ? readFileSync(path, 'utf-8') : null;
-  return () => restoreFile(path, previous, reload);
-}
-
-async function runRollbacks(rollbacks: readonly RollbackAction[]): Promise<readonly string[]> {
-  const errors: string[] = [];
-  for (const rollback of [...rollbacks].reverse()) {
-    try {
-      await rollback();
-    } catch (error) {
-      errors.push(error instanceof Error ? error.message : String(error));
-    }
-  }
-  return errors;
-}
-
 function isGoodVibesSecretReferenceValue(value: string): boolean {
   const normalized = value.trim();
   return normalized.startsWith('goodvibes://secrets/') && isSecretRefInput(normalized);
@@ -105,10 +50,6 @@ function isMalformedGoodVibesSecretReferenceValue(value: string): boolean {
   return normalized.startsWith('goodvibes://') && !isGoodVibesSecretReferenceValue(normalized);
 }
 
-function isFeatureFlagConfigKey(key: string): key is FeatureFlagConfigKey {
-  return key === 'featureFlags' || key.startsWith('featureFlags.');
-}
-
 function validateFeatureFlagConfigValue(operation: Extract<OnboardingApplyOperation, { kind: 'set-config' }>): boolean {
   if (!isFeatureFlagConfigKey(operation.key)) return false;
 
@@ -143,7 +84,7 @@ function validateConfigValue(operation: Extract<OnboardingApplyOperation, { kind
     const defaultValue = operation.key.split('.').reduce<unknown>((cursor, part) => (
       isPlainObject(cursor) ? cursor[part] : undefined
     ), DEFAULT_CONFIG);
-    if (defaultValue === undefined) throw new Error(`Unknown config key: ${operation.key}`);
+    if (defaultValue === undefined) throw new Error(`Unknown config key ${operation.key}`);
     if (typeof defaultValue === 'boolean' && typeof operation.value !== 'boolean') {
       throw new Error(`Config key ${operation.key} expects a boolean value.`);
     }
@@ -170,11 +111,11 @@ function validateConfigValue(operation: Extract<OnboardingApplyOperation, { kind
   }
 
   if (schema.type === 'enum' && schema.enumValues && stringValue !== null && !schema.enumValues.includes(stringValue)) {
-    throw new Error(`Invalid value for ${operation.key}: ${String(operation.value)}.`);
+    throw new Error(`Invalid value for ${operation.key} ${String(operation.value)}.`);
   }
 
   if (schema.validate && !schema.validate(operation.value)) {
-    throw new Error(`Invalid value for ${operation.key}: ${String(operation.value)}.`);
+    throw new Error(`Invalid value for ${operation.key} ${String(operation.value)}.`);
   }
 }
 
@@ -287,6 +228,21 @@ function validateCreateLocalRoutineOperation(
   if (duplicate) throw new Error(`Routine already exists: ${duplicate.id}`);
 }
 
+function validateCreateLocalNoteOperation(
+  deps: OnboardingApplyDependencies,
+  operation: Extract<OnboardingApplyOperation, { kind: 'create-local-note' }>,
+): void {
+  const registry = AgentNoteRegistry.fromShellPaths(deps.shellPaths);
+  const title = operation.title.trim();
+  const body = operation.body.trim();
+  const tags = operation.tags ?? [];
+  if (!title) throw new Error('Note title is required.');
+  if (!body) throw new Error('Note body is required.');
+  assertNoSecretLikeText([title, body, ...tags]);
+  const duplicate = registry.get(title);
+  if (duplicate) throw new Error(`Note already exists: ${duplicate.id}`);
+}
+
 function applyConfigOperation(
   deps: OnboardingApplyDependencies,
   operation: Extract<OnboardingApplyOperation, { kind: 'set-config' }>,
@@ -306,7 +262,11 @@ function applyConfigOperation(
     };
   }
 
-  deps.config.setDynamic(operation.key as never, operation.value);
+  if (isFeatureFlagConfigKey(operation.key)) {
+    mergeFeatureFlagConfigValue(deps.config, operation.key, operation.value);
+  } else {
+    deps.config.setDynamic(operation.key, operation.value);
+  }
   return {
     kind: operation.kind,
     summary: `Updated ${operation.key} in global onboarding settings.`,
@@ -359,9 +319,15 @@ async function buildRollbackAction(
       );
     }
 
-    const previous = deps.config.get(operation.key as never);
+    const previous = isFeatureFlagConfigKey(operation.key)
+      ? readFeatureFlagConfigValue(deps.config, operation.key)
+      : deps.config.get(operation.key);
     return () => {
-      deps.config.setDynamic(operation.key as never, previous);
+      if (isFeatureFlagConfigKey(operation.key)) {
+        mergeFeatureFlagConfigValue(deps.config, operation.key, previous ?? 'disabled');
+      } else {
+        deps.config.setDynamic(operation.key, previous);
+      }
     };
   }
 
@@ -392,6 +358,11 @@ async function buildRollbackAction(
     return snapshotFileRollback(path);
   }
 
+  if (operation.kind === 'create-local-note') {
+    const registry = AgentNoteRegistry.fromShellPaths(deps.shellPaths);
+    return snapshotFileRollback(registry.snapshot().path);
+  }
+
   if (operation.kind === 'create-local-persona') {
     const registry = AgentPersonaRegistry.fromShellPaths(deps.shellPaths);
     return snapshotFileRollback(registry.snapshot().path);
@@ -457,7 +428,7 @@ function applySelectAgentProfileOperation(
   const selection = setAgentRuntimeProfileSelection(deps.shellPaths.homeDirectory, operation.name);
   return {
     kind: operation.kind,
-    summary: `Selected Agent profile ${selection.id} for future launches.`,
+    summary: `Selected Agent profile ${selection.id} for later plain goodvibes-agent runs.`,
   };
 }
 
@@ -476,7 +447,7 @@ function applyCreateLocalPersonaOperation(
   if (operation.activate !== false) registry.setActive(persona.id);
   return {
     kind: operation.kind,
-    summary: `Created local Agent persona ${persona.id}.`,
+    summary: `Created Agent-local persona ${persona.id}.`,
   };
 }
 
@@ -494,7 +465,7 @@ function applyCreateLocalSkillOperation(
   });
   return {
     kind: operation.kind,
-    summary: `Created local Agent skill ${skill.id}.`,
+    summary: `Created Agent-local skill ${skill.id}.`,
   };
 }
 
@@ -512,7 +483,24 @@ function applyCreateLocalRoutineOperation(
   });
   return {
     kind: operation.kind,
-    summary: `Created local Agent routine ${routine.id}.`,
+    summary: `Created Agent-local routine ${routine.id}.`,
+  };
+}
+
+function applyCreateLocalNoteOperation(
+  deps: OnboardingApplyDependencies,
+  operation: Extract<OnboardingApplyOperation, { kind: 'create-local-note' }>,
+): OnboardingAppliedOperation {
+  const note = AgentNoteRegistry.fromShellPaths(deps.shellPaths).create({
+    title: operation.title,
+    body: operation.body,
+    tags: operation.tags ?? [],
+    source: 'user',
+    provenance: 'onboarding',
+  });
+  return {
+    kind: operation.kind,
+    summary: `Created Agent-local note ${note.id}.`,
   };
 }
 
@@ -530,7 +518,8 @@ function orderApplyOperations(
   const agentProfileOperations = operations.filter((operation) => operation.kind === 'create-agent-profile');
   const agentProfileSelectionOperations = operations.filter((operation) => operation.kind === 'select-agent-profile');
   const localBehaviorOperations = operations.filter((operation) => (
-    operation.kind === 'create-local-persona'
+    operation.kind === 'create-local-note'
+    || operation.kind === 'create-local-persona'
     || operation.kind === 'create-local-skill'
     || operation.kind === 'create-local-routine'
   ));
@@ -602,6 +591,11 @@ function prevalidateApplyRequest(
         continue;
       }
 
+      if (operation.kind === 'create-local-note') {
+        validateCreateLocalNoteOperation(deps, operation);
+        continue;
+      }
+
       if (operation.kind === 'create-local-skill') {
         validateCreateLocalSkillOperation(deps, operation);
         continue;
@@ -632,6 +626,7 @@ function getVerificationFailureKind(itemId: string): OnboardingApplyOperation['k
   if (itemId.startsWith('acknowledge:')) return 'acknowledge';
   if (itemId.startsWith('agent-profile:')) return 'create-agent-profile';
   if (itemId.startsWith('selected-agent-profile:')) return 'select-agent-profile';
+  if (itemId.startsWith('local-note:')) return 'create-local-note';
   if (itemId.startsWith('local-persona:')) return 'create-local-persona';
   if (itemId.startsWith('local-skill:')) return 'create-local-skill';
   if (itemId.startsWith('local-routine:')) return 'create-local-routine';
@@ -703,6 +698,12 @@ export async function applyOnboardingRequest(
           continue;
         }
 
+        if (operation.kind === 'create-local-note') {
+          applied.push(applyCreateLocalNoteOperation(deps, operation));
+          rollbacks.push(rollback);
+          continue;
+        }
+
         if (operation.kind === 'create-local-skill') {
           applied.push(applyCreateLocalSkillOperation(deps, operation));
           rollbacks.push(rollback);

package/src/runtime/onboarding/derivation.ts

@@ -83,7 +83,7 @@ function isDeepEqual(left: unknown, right: unknown): boolean {
     const rightEntries = Object.entries(right);
     if (leftEntries.length !== rightEntries.length) return false;
 
-    return leftEntries.every(([key, value]) => isDeepEqual(value, (right as Record<string, unknown>)[key]));
+    return leftEntries.every(([key, value]) => isDeepEqual(value, Reflect.get(right, key)));
   }
 
   return false;
@@ -250,7 +250,7 @@ function describeLocalBehavior(snapshot: OnboardingSnapshotState): string {
       ...discovery.routines.names,
     ].slice(0, 4);
     const sampleText = samples.length > 0 ? ` Found: ${samples.join(', ')}.` : '';
-    return `Import ${discoveredCount} discovered Agent persona/skill/routine file(s) from local Agent folders before creating blank behavior.${sampleText}`;
+    return `Import ${discoveredCount} discovered Agent persona/skill/routine file(s) from Agent-local folders before creating blank behavior.${sampleText}`;
   }
 
   if (!hasLocalBehaviorCustomization(snapshot)) {
@@ -288,7 +288,7 @@ function describeAutomationReview(snapshot: OnboardingSnapshotState): string {
 }
 
 function describeTuiDelegation(): string {
-  return 'Delegate explicit build, fix, implementation, and review work to GoodVibes TUI; WRFC is requested only when the user explicitly asks for it.';
+  return 'Delegate explicit build, fix, implementation, and review work to GoodVibes TUI; delegated review is requested only when the user explicitly asks for it.';
 }
 
 function getAcknowledgementAccepted(
@@ -391,10 +391,7 @@ export function deriveStep1CapabilityFlags(
   };
 }
 
-export function deriveStep1_5NetworkMode(
-  bindSettings: Pick<OnboardingSnapshotState, 'bindSettings'>['bindSettings'],
-): OnboardingNetworkMode {
-  void bindSettings;
+export function deriveStep1_5NetworkMode(): OnboardingNetworkMode {
   return 'local-network-default';
 }
 
@@ -488,7 +485,7 @@ export function deriveOnboardingStepState(
 ): OnboardingStepDerivationState {
   return {
     step1Capabilities: deriveStep1Capabilities(snapshot),
-    step1_5NetworkMode: deriveStep1_5NetworkMode(snapshot.bindSettings),
+    step1_5NetworkMode: deriveStep1_5NetworkMode(),
     reopenEditAcknowledgements: deriveReopenEditAcknowledgementState(snapshot),
   };
 }

package/src/runtime/onboarding/snapshot.ts

@@ -35,15 +35,7 @@ function buildConfigSnapshot(
       llmProvider: config.get('tools.llmProvider'),
       llmModel: config.get('tools.llmModel'),
     },
-    danger: config.getCategory('danger'),
-    controlPlane: config.getCategory('controlPlane'),
-    httpListener: config.getCategory('httpListener'),
-    web: config.getCategory('web'),
-    network: config.getCategory('network'),
     surfaces: config.getCategory('surfaces'),
-    service: config.getCategory('service'),
-    featureFlags: config.getCategory('featureFlags'),
-    batch: config.getCategory('batch'),
   };
 }
 
@@ -389,13 +381,6 @@ export async function collectOnboardingSnapshot(
     auth: {
       snapshot: authSnapshotResult.value,
     },
-    bindSettings: {
-      daemonEnabled: Boolean(config.danger.daemon),
-      httpListenerEnabled: Boolean(config.danger.httpListener),
-      controlPlane: config.controlPlane,
-      httpListener: config.httpListener,
-      web: config.web,
-    },
     surfaces: {
       configuredEnabledKinds: buildConfiguredSurfaceKinds(config.surfaces),
       records: sortSurfaceRecords(surfaceResult.value),

package/src/runtime/onboarding/types.ts

@@ -40,15 +40,7 @@ export interface OnboardingConfigSnapshot {
   readonly permissions: GoodVibesConfig['permissions'];
   readonly helper: GoodVibesConfig['helper'];
   readonly tools: Pick<GoodVibesConfig['tools'], 'llmEnabled' | 'llmProvider' | 'llmModel'>;
-  readonly danger: GoodVibesConfig['danger'];
-  readonly controlPlane: GoodVibesConfig['controlPlane'];
-  readonly httpListener: GoodVibesConfig['httpListener'];
-  readonly web: GoodVibesConfig['web'];
-  readonly network: GoodVibesConfig['network'];
   readonly surfaces: GoodVibesConfig['surfaces'];
-  readonly service: GoodVibesConfig['service'];
-  readonly featureFlags: GoodVibesConfig['featureFlags'];
-  readonly batch: GoodVibesConfig['batch'];
 }
 
 export interface OnboardingProviderRoutingSnapshot {
@@ -102,14 +94,6 @@ export interface OnboardingAuthSnapshot {
   readonly snapshot: LocalAuthSnapshot;
 }
 
-export interface OnboardingBindSettingsSnapshot {
-  readonly daemonEnabled: boolean;
-  readonly httpListenerEnabled: boolean;
-  readonly controlPlane: GoodVibesConfig['controlPlane'];
-  readonly httpListener: GoodVibesConfig['httpListener'];
-  readonly web: GoodVibesConfig['web'];
-}
-
 export interface OnboardingSurfaceRecord {
   readonly id: string;
   readonly kind: string;
@@ -187,7 +171,6 @@ export interface OnboardingSnapshotState {
   readonly subscriptions: OnboardingSubscriptionsSnapshot;
   readonly secrets: OnboardingSecretsSnapshot;
   readonly auth: OnboardingAuthSnapshot;
-  readonly bindSettings: OnboardingBindSettingsSnapshot;
   readonly surfaces: OnboardingSurfacesSnapshot;
   readonly providerAccounts: OnboardingProviderAccountsSnapshot | null;
   readonly localBehaviorDiscovery: AgentBehaviorDiscoverySnapshot;
@@ -276,6 +259,12 @@ export type OnboardingApplyOperation =
       readonly kind: 'select-agent-profile';
       readonly name: string;
     }
+  | {
+      readonly kind: 'create-local-note';
+      readonly title: string;
+      readonly body: string;
+      readonly tags?: readonly string[];
+    }
   | {
       readonly kind: 'create-local-persona';
       readonly name: string;
@@ -408,7 +397,7 @@ export interface OnboardingSnapshotDependencies {
 
 export interface OnboardingApplyDependencies {
   readonly clock?: () => number;
-  readonly config: Pick<ConfigManager, 'get' | 'getRaw' | 'load' | 'setDynamic'>;
+  readonly config: Pick<ConfigManager, 'get' | 'getCategory' | 'getRaw' | 'load' | 'mergeCategory' | 'setDynamic'>;
   readonly secrets?: Pick<SecretsManager, 'delete' | 'get' | 'inspect' | 'set'>;
   readonly auth?: Pick<UserAuthManager, 'inspect'>;
   readonly shellPaths: OnboardingShellPaths;
@@ -417,7 +406,7 @@ export interface OnboardingApplyDependencies {
 
 export interface OnboardingVerificationDependencies {
   readonly clock?: () => number;
-  readonly config: Pick<ConfigManager, 'get'>;
+  readonly config: Pick<ConfigManager, 'get' | 'getCategory'>;
   readonly secrets?: Pick<SecretsManager, 'get'>;
   readonly auth?: Pick<UserAuthManager, 'inspect'>;
   readonly shellPaths: OnboardingShellPaths;

package/src/runtime/onboarding/verify.ts

@@ -1,10 +1,12 @@
 import { existsSync } from 'node:fs';
 import { join } from 'node:path';
 import { isSecretRefInput } from '@pellux/goodvibes-sdk/platform/config';
+import { AgentNoteRegistry } from '../../agent/note-registry.ts';
 import { AgentPersonaRegistry } from '../../agent/persona-registry.ts';
 import { AgentRoutineRegistry } from '../../agent/routine-registry.ts';
 import { readAgentRuntimeProfileSelection, resolveAgentRuntimeProfileHome } from '../../agent/runtime-profile.ts';
 import { AgentSkillRegistry } from '../../agent/skill-registry.ts';
+import { isFeatureFlagConfigKey, readFeatureFlagConfigValue } from '../surface-feature-flags.ts';
 import { readOnboardingRuntimeState } from './state.ts';
 import type {
   OnboardingApplyOperation,
@@ -34,7 +36,7 @@ function isDeepEqual(left: unknown, right: unknown): boolean {
     const rightEntries = Object.entries(right);
     if (leftEntries.length !== rightEntries.length) return false;
 
-    return leftEntries.every(([key, value]) => isDeepEqual(value, (right as Record<string, unknown>)[key]));
+    return leftEntries.every(([key, value]) => isDeepEqual(value, Reflect.get(right, key)));
   }
 
   return false;
@@ -49,7 +51,9 @@ function verifyConfigOperation(
   deps: OnboardingVerificationDependencies,
   operation: Extract<OnboardingApplyOperation, { kind: 'set-config' }>,
 ): OnboardingVerificationItem {
-  const actual = deps.config.get(operation.key as never);
+  const actual = isFeatureFlagConfigKey(operation.key)
+    ? readFeatureFlagConfigValue(deps.config, operation.key)
+    : deps.config.get(operation.key);
   const ok = isDeepEqual(actual, operation.value);
 
   return {
@@ -158,8 +162,8 @@ function verifySelectAgentProfileOperation(
     id: `selected-agent-profile:${resolution.id}`,
     status: ok ? 'pass' : 'fail',
     message: ok
-      ? `${resolution.id} Agent profile is selected for future launches.`
-      : `${resolution.id} Agent profile is not selected for future launches.`,
+      ? `${resolution.id} Agent profile is selected for later plain goodvibes-agent runs.`
+      : `${resolution.id} Agent profile is not selected for later plain goodvibes-agent runs.`,
     target: resolution.id,
   };
 }
@@ -177,8 +181,8 @@ function verifyCreateLocalPersonaOperation(
     id: `local-persona:${target}`,
     status: ok ? 'pass' : 'fail',
     message: ok
-      ? `${target} local Agent persona exists${operation.activate === false ? '' : ' and is active'}.`
-      : `${target} local Agent persona was not created${operation.activate === false ? '' : ' or activated'}.`,
+      ? `${target} Agent-local persona exists${operation.activate === false ? '' : ' and is active'}.`
+      : `${target} Agent-local persona was not created${operation.activate === false ? '' : ' or activated'}.`,
     target,
   };
 }
@@ -195,8 +199,8 @@ function verifyCreateLocalSkillOperation(
     id: `local-skill:${target}`,
     status: ok ? 'pass' : 'fail',
     message: ok
-      ? `${target} local Agent skill exists${operation.enabled === false ? '' : ' and is enabled'}.`
-      : `${target} local Agent skill was not created${operation.enabled === false ? '' : ' or enabled'}.`,
+      ? `${target} Agent-local skill exists${operation.enabled === false ? '' : ' and is enabled'}.`
+      : `${target} Agent-local skill was not created${operation.enabled === false ? '' : ' or enabled'}.`,
     target,
   };
 }
@@ -213,8 +217,25 @@ function verifyCreateLocalRoutineOperation(
     id: `local-routine:${target}`,
     status: ok ? 'pass' : 'fail',
     message: ok
-      ? `${target} local Agent routine exists${operation.enabled === false ? '' : ' and is enabled'}.`
-      : `${target} local Agent routine was not created${operation.enabled === false ? '' : ' or enabled'}.`,
+      ? `${target} Agent-local routine exists${operation.enabled === false ? '' : ' and is enabled'}.`
+      : `${target} Agent-local routine was not created${operation.enabled === false ? '' : ' or enabled'}.`,
+    target,
+  };
+}
+
+function verifyCreateLocalNoteOperation(
+  deps: OnboardingVerificationDependencies,
+  operation: Extract<OnboardingApplyOperation, { kind: 'create-local-note' }>,
+): OnboardingVerificationItem {
+  const note = AgentNoteRegistry.fromShellPaths(deps.shellPaths).get(operation.title);
+  const ok = note !== null && note.body.trim() === operation.body.trim();
+  const target = note?.id ?? operation.title.trim();
+  return {
+    id: `local-note:${target}`,
+    status: ok ? 'pass' : 'fail',
+    message: ok
+      ? `${target} Agent-local note exists.`
+      : `${target} Agent-local note was not created.`,
     target,
   };
 }
@@ -229,6 +250,7 @@ async function verifyOperation(
   if (operation.kind === 'acknowledge') return verifyAcknowledgementOperation(deps, operation);
   if (operation.kind === 'create-agent-profile') return verifyCreateAgentProfileOperation(deps, operation);
   if (operation.kind === 'select-agent-profile') return verifySelectAgentProfileOperation(deps, operation);
+  if (operation.kind === 'create-local-note') return verifyCreateLocalNoteOperation(deps, operation);
   if (operation.kind === 'create-local-persona') return verifyCreateLocalPersonaOperation(deps, operation);
   if (operation.kind === 'create-local-skill') return verifyCreateLocalSkillOperation(deps, operation);
   return verifyCreateLocalRoutineOperation(deps, operation);

package/src/runtime/operator-token-cleanup.ts

@@ -16,7 +16,7 @@ import { join } from 'node:path';
  * Return the list of absolute operator-tokens.json paths the TUI may have written
  * at legacy (pre-0.21.28) workspace-scoped locations under `workingDirectory`.
  *
- * The canonical, current-SDK location is `<daemonHomeDir>/operator-tokens.json`;
+ * The canonical, current-SDK location is `<connectedHostTokenDir>/operator-tokens.json`;
  * this helper is strictly for legacy-cleanup candidates.
  */
 export function workspaceOperatorTokenCandidates(workingDirectory: string): readonly string[] {