@pellux/goodvibes-agent 0.1.117 → 1.0.0

package/src/input/commands/health-runtime.ts

@@ -1,13 +1,13 @@
 import { ServiceRegistry } from '@pellux/goodvibes-sdk/platform/config';
 import { evaluateSessionMaintenance, formatSessionMaintenanceLines } from '@/runtime/index.ts';
 import { estimateConversationTokens } from '@pellux/goodvibes-sdk/platform/core';
-import type { CommandRegistry } from '../command-registry.ts';
+import type { CommandContext, CommandRegistry } from '../command-registry.ts';
 import { buildSetupReviewSnapshot } from './local-setup-review.ts';
-import { buildProviderAccountSnapshot } from '@/runtime/index.ts';
+import { buildProviderAccountSnapshot } from '../../panels/provider-account-snapshot.ts';
 import { getSettingsControlPlaneSnapshot } from '@/runtime/index.ts';
 import { checkRecoveryFile, readLastSessionPointer } from '@/runtime/index.ts';
 import {
-  requireOperatorClient,
+  requireProvider,
   requireProviderApi,
   requireReadModels,
   requireSecretsManager,
@@ -16,6 +16,33 @@ import {
   requireSessionMemoryStore,
 } from './runtime-services.ts';
 
+async function loadProviderAccountSnapshot(ctx: CommandContext) {
+  return await buildProviderAccountSnapshot({
+    providerModels: requireProvider(ctx).providerRegistry,
+    services: requireServiceRegistry(ctx),
+    subscriptions: requireSubscriptionManager(ctx),
+    environment: {
+      hasEnvironmentVariable: (name: string) => Boolean(process.env[name]),
+    },
+  });
+}
+
+type HealthReadModels = ReturnType<typeof requireReadModels>;
+type HealthRemoteSnapshot = ReturnType<HealthReadModels['remote']['getSnapshot']>;
+type HealthRemoteSession = HealthRemoteSnapshot['supervisor']['sessions'][number];
+type HealthMcpSnapshot = ReturnType<HealthReadModels['mcp']['getSnapshot']>;
+type HealthMcpServer = HealthMcpSnapshot['servers'][number];
+type HealthStatusValue =
+  | HealthRemoteSession['transportState']
+  | HealthRemoteSession['heartbeat']['status']
+  | HealthMcpServer['status']
+  | HealthMcpServer['schemaFreshness'];
+
+function formatHealthStatusValue(value: HealthStatusValue): string {
+  if (value === 'quarantined') return 'needs review';
+  return value.replace(/[_-]+/g, ' ');
+}
+
 export function registerHealthRuntimeCommands(registry: CommandRegistry): void {
   registry.register({
     name: 'health',
@@ -26,26 +53,26 @@ export function registerHealthRuntimeCommands(registry: CommandRegistry): void {
       const sub = (args[0] ?? 'review').toLowerCase();
 
       if (sub === 'open' || sub === 'panel') {
-        ctx.print('Health panels are not part of the Agent workspace. Use /health review.');
+        ctx.print('Open Agent Workspace -> Home -> Review health for the workspace view, or run /health review for the compact command output.');
         return;
       }
 
       if (sub === 'provider') {
         const providerApi = requireProviderApi(ctx);
         const currentModel = await providerApi.getCurrentModel().catch(() => null);
-        const accounts = await requireOperatorClient(ctx).providers.accountSnapshot();
+        const accounts = await loadProviderAccountSnapshot(ctx);
         ctx.print([
-          'Health Review: Provider',
-          `  selected model: ${currentModel?.registryKey ?? 'unknown'}`,
-          `  providers: ${providerApi.listProviderIds().length}`,
-          `  configured accounts: ${accounts.configuredCount}`,
-          `  account issues: ${accounts.issueCount}`,
+          'Health Review Provider',
+          `  selected model ${currentModel?.registryKey ?? 'unknown'}`,
+          `  providers ${providerApi.listProviderIds().length}`,
+          `  configured accounts ${accounts.configuredCount}`,
+          `  account issues ${accounts.issueCount}`,
           ...(accounts.issueCount > 0
-            ? accounts.providers.flatMap((provider) => provider.issues.map((issue) => `  ${provider.providerId}: ${issue}`))
+            ? accounts.providers.flatMap((provider) => provider.issues.map((issue) => `  ${provider.providerId} ${issue}`))
             : ['  no provider account issues detected']),
-          '  next: /model',
-          '  next: /provider',
-          '  next: /accounts review',
+          '  next /model',
+          '  next /provider',
+          '  next /accounts review',
         ].join('\n'));
         return;
       }
@@ -61,32 +88,31 @@ export function registerHealthRuntimeCommands(registry: CommandRegistry): void {
           .filter((inspection): inspection is NonNullable<typeof inspection> => inspection !== null)
           .flatMap((inspection) => {
             const findings: string[] = [];
-            if (!inspection.hasPrimaryCredential) findings.push(`${inspection.config.name}: missing primary credential`);
-            if (inspection.config.authType === 'basic' && !inspection.hasPasswordCredential) findings.push(`${inspection.config.name}: missing password credential`);
-            if (!inspection.config.baseUrl) findings.push(`${inspection.config.name}: no baseUrl configured`);
+            if (!inspection.hasPrimaryCredential) findings.push(`${inspection.config.name} missing primary credential`);
+            if (inspection.config.authType === 'basic' && !inspection.hasPasswordCredential) findings.push(`${inspection.config.name} missing password credential`);
+            if (!inspection.config.baseUrl) findings.push(`${inspection.config.name} no baseUrl configured`);
             return findings;
           });
         ctx.print([
-          'Health Review: Connected Host Integrations',
-          `  configured integrations: ${keys.length}`,
-          `  issues: ${issues.length}`,
+          'Health Review Connected Host Integrations',
+          `  configured integrations ${keys.length}`,
+          `  issues ${issues.length}`,
           ...(issues.length > 0 ? issues.map((issue) => `  ${issue}`) : ['  all configured host integrations passed readiness checks']),
         ].join('\n'));
         return;
       }
 
       if (sub === 'accounts') {
-        const operatorClient = requireOperatorClient(ctx);
-        const accounts = await operatorClient.providers.accountSnapshot();
+        const accounts = await loadProviderAccountSnapshot(ctx);
         ctx.print([
-          'Health Review: Accounts',
-          `  providers: ${accounts.providers.length}`,
-          `  configured: ${accounts.configuredCount}`,
-          `  issues: ${accounts.issueCount}`,
+          'Health Review Accounts',
+          `  providers ${accounts.providers.length}`,
+          `  configured ${accounts.configuredCount}`,
+          `  issues ${accounts.issueCount}`,
           ...accounts.providers.flatMap((provider) => {
             const findings = [
-              ...provider.issues.map((issue) => `  ${provider.providerId}: ${issue}`),
-              ...(provider.fallbackRisk ? [`  ${provider.providerId}: ${provider.fallbackRisk}`] : []),
+              ...provider.issues.map((issue) => `  ${provider.providerId} ${issue}`),
+              ...(provider.fallbackRisk ? [`  ${provider.providerId} ${provider.fallbackRisk}`] : []),
             ];
             return findings;
           }),
@@ -97,13 +123,13 @@ export function registerHealthRuntimeCommands(registry: CommandRegistry): void {
       if (sub === 'auth') {
         const auth = readModels.localAuth.getSnapshot();
         ctx.print([
-          'Health Review: Connected-Host Auth',
-          '  owner: connected GoodVibes host',
-          `  compatibility users visible: ${auth.userCount}`,
-          `  compatibility sessions visible: ${auth.sessionCount}`,
-          `  bootstrap file signal: ${auth.bootstrapCredentialPresent ? 'present' : 'cleared'}`,
-          '  Agent action: review provider/subscription auth only; do not mutate connected-host auth users or bootstrap credentials.',
-          ...(auth.bootstrapCredentialPresent ? ['  issue: bootstrap cleanup belongs outside Agent'] : []),
+          'Health Review Connected Host Auth',
+          '  owner connected GoodVibes host',
+          `  compatibility users visible ${auth.userCount}`,
+          `  compatibility sessions visible ${auth.sessionCount}`,
+          `  bootstrap file signal ${auth.bootstrapCredentialPresent ? 'present' : 'cleared'}`,
+          '  Agent action review provider/subscription auth only; do not mutate connected-host auth users or bootstrap credentials.',
+          ...(auth.bootstrapCredentialPresent ? ['  issue bootstrap cleanup belongs outside Agent'] : []),
         ].join('\n'));
         return;
       }
@@ -113,19 +139,19 @@ export function registerHealthRuntimeCommands(registry: CommandRegistry): void {
         const issues: string[] = [];
         if (settings.conflictCount > 0) issues.push(`${settings.conflictCount} conflicting setting import(s) need review`);
         if (settings.recentFailureCount > 0) issues.push(`${settings.recentFailureCount} recent sync/managed failure(s) recorded`);
-        if (settings.hasStagedManagedBundle) issues.push('staged managed bundle is awaiting apply or rollback');
+        if (settings.hasStagedManagedBundle) issues.push('pending managed settings bundle is awaiting apply or rollback');
         if (settings.managedLockCount > 0) issues.push(`${settings.managedLockCount} managed lock(s) currently enforced`);
         ctx.print([
-          'Health Review: Settings',
-          `  available: ${settings.available ? 'yes' : 'no'}`,
-          `  managed locks: ${settings.managedLockCount}`,
-          `  conflicts: ${settings.conflictCount}`,
-          `  recent failures: ${settings.recentFailureCount}`,
-          `  staged bundle: ${settings.hasStagedManagedBundle ? 'present' : 'none'}`,
-          ...(issues.length > 0 ? issues.map((issue) => `  issue: ${issue}`) : ['  no active settings-control issues detected']),
-          '  next: /settings',
-          '  next: /config <key>',
-          '  next: /health repair settings',
+          'Health Review Settings',
+          `  available ${settings.available ? 'yes' : 'no'}`,
+          `  managed locks ${settings.managedLockCount}`,
+          `  conflicts ${settings.conflictCount}`,
+          `  recent failures ${settings.recentFailureCount}`,
+          `  pending managed bundle ${settings.hasStagedManagedBundle ? 'present' : 'none'}`,
+          ...(issues.length > 0 ? issues.map((issue) => `  issue ${issue}`) : ['  no active settings-control issues detected']),
+          '  next /settings',
+          '  next /config <key>',
+          '  next /health repair settings',
         ].join('\n'));
         return;
       }
@@ -135,24 +161,24 @@ export function registerHealthRuntimeCommands(registry: CommandRegistry): void {
         const issues = snapshot.sessions.flatMap((session) => {
           const lines: string[] = [];
           if (session.transportState === 'degraded' || session.transportState === 'reconnecting' || session.transportState === 'terminal_failure') {
-            lines.push(`${session.runnerId}: transport=${session.transportState}`);
+            lines.push(`${session.runnerId} transport ${formatHealthStatusValue(session.transportState)}`);
           }
           if (session.heartbeat.status !== 'fresh') {
-            lines.push(`${session.runnerId}: heartbeat=${session.heartbeat.status}`);
+            lines.push(`${session.runnerId} heartbeat ${formatHealthStatusValue(session.heartbeat.status)}`);
           }
           if (session.lastError) {
-            lines.push(`${session.runnerId}: ${session.lastError}`);
+            lines.push(`${session.runnerId} ${session.lastError}`);
           }
           return lines;
         });
         ctx.print([
-          'Health Review: Remote',
-          `  sessions: ${snapshot.sessions.length}`,
-          `  active connections: ${snapshot.activeConnections}`,
-          `  degraded: ${snapshot.degradedConnections}`,
-          ...(issues.length > 0 ? issues.map((issue) => `  issue: ${issue}`) : ['  no active remote recovery issues detected']),
-          '  next: /delegate <build/fix/review task> for explicit TUI build work',
-          '  next: repair remote worker state outside Agent',
+          'Health Review Remote',
+          `  sessions ${snapshot.sessions.length}`,
+          `  active connections ${snapshot.activeConnections}`,
+          `  degraded ${snapshot.degradedConnections}`,
+          ...(issues.length > 0 ? issues.map((issue) => `  issue ${issue}`) : ['  no active remote recovery issues detected']),
+          '  next /delegate <build/fix/review task> for explicit TUI build work',
+          '  next repair remote build-host state outside Agent',
         ].join('\n'));
         return;
       }
@@ -162,27 +188,27 @@ export function registerHealthRuntimeCommands(registry: CommandRegistry): void {
         const issues = mcp.servers.flatMap((server) => {
           const lines: string[] = [];
           if (server.status !== 'connected' && server.status !== 'configured') {
-            lines.push(`${server.name}: status=${server.status}`);
+            lines.push(`${server.name} status ${formatHealthStatusValue(server.status)}`);
           }
           if (server.schemaFreshness !== 'fresh') {
-            lines.push(`${server.name}: schema=${server.schemaFreshness}`);
+            lines.push(`${server.name} tool-definition review ${formatHealthStatusValue(server.schemaFreshness)}`);
           }
           if (server.lastError) {
-            lines.push(`${server.name}: ${server.lastError}`);
+            lines.push(`${server.name} ${server.lastError}`);
           }
           return lines;
         });
         ctx.print([
-          'Health Review: MCP',
-          `  servers: ${mcp.servers.length}`,
-          `  connected: ${mcp.connectedServerNames.length}`,
-          `  tools: ${mcp.availableToolCount}`,
-          `  total calls: ${mcp.totalCalls}`,
-          `  total errors: ${mcp.totalErrors}`,
-          ...(issues.length > 0 ? issues.map((issue) => `  issue: ${issue}`) : ['  no active MCP lifecycle issues detected']),
-          '  next: /mcp review',
-          '  next: /mcp auth-review',
-          '  next: /mcp repair',
+          'Health Review MCP',
+          `  servers ${mcp.servers.length}`,
+          `  connected ${mcp.connectedServerNames.length}`,
+          `  tools ${mcp.availableToolCount}`,
+          `  total calls ${mcp.totalCalls}`,
+          `  total errors ${mcp.totalErrors}`,
+          ...(issues.length > 0 ? issues.map((issue) => `  issue ${issue}`) : ['  no active MCP lifecycle issues detected']),
+          '  next /mcp review',
+          '  next /mcp auth-review',
+          '  next /mcp repair',
         ].join('\n'));
         return;
       }
@@ -195,14 +221,14 @@ export function registerHealthRuntimeCommands(registry: CommandRegistry): void {
         if (continuity.recoveryFilePresent) issues.push(`recovery file present for ${continuity.sessionId || '(unknown session)'}`);
         if (returnMode === 'off') issues.push('return-context summaries are disabled');
         ctx.print([
-          'Health Review: Continuity',
-          `  return context mode: ${returnMode}`,
-          `  last session pointer: ${continuity.lastSessionPointer ?? 'none'}`,
-          `  recovery file: ${continuity.recoveryFilePresent ? 'present' : 'clear'}`,
-          ...(continuity.returnContext ? [`  recovery activity: ${continuity.returnContext.activityLabel}`, `  recovery status: ${continuity.returnContext.statusLabel}`] : []),
-          ...(issues.length > 0 ? issues.map((issue) => `  issue: ${issue}`) : ['  no active session continuity issues detected']),
-          '  next: /session list',
-          '  next: /session hotspots',
+          'Health Review Continuity',
+          `  return context mode ${returnMode}`,
+          `  last session pointer ${continuity.lastSessionPointer ?? 'none'}`,
+          `  recovery file ${continuity.recoveryFilePresent ? 'present' : 'clear'}`,
+          ...(continuity.returnContext ? [`  recovery activity ${continuity.returnContext.activityLabel}`, `  recovery status ${continuity.returnContext.statusLabel}`] : []),
+          ...(issues.length > 0 ? issues.map((issue) => `  issue ${issue}`) : ['  no active session continuity issues detected']),
+          '  next /session list',
+          '  next /session hotspots',
         ].join('\n'));
         return;
       }
@@ -223,7 +249,7 @@ export function registerHealthRuntimeCommands(registry: CommandRegistry): void {
           session: session.session,
         });
         ctx.print([
-          'Health Review: Maintenance',
+          'Health Review Maintenance',
           ...formatSessionMaintenanceLines(maintenance, 'guided'),
         ].join('\n'));
         return;
@@ -234,58 +260,58 @@ export function registerHealthRuntimeCommands(registry: CommandRegistry): void {
         const lines = ['Health Repair'];
         if (domain === 'settings') {
           const settings = getSettingsControlPlaneSnapshot(ctx.platform.configManager);
-          lines.push('  domain: settings');
+          lines.push('  domain settings');
           lines.push(...(
             settings.conflicts.length > 0
               ? ['  /settings', '  /config <key>', '  host-owned managed setting repair stays external']
               : ['  no active settings repair actions suggested']
           ));
-          lines.push('  verify: /health settings');
+          lines.push('  verify /health settings');
         } else if (domain === 'auth') {
-          lines.push('  domain: auth');
+          lines.push('  domain auth');
           lines.push('  /auth review');
           lines.push('  /provider');
           lines.push('  /subscription providers');
-          lines.push('  connected-host auth users/bootstrap cleanup: manage outside Agent');
-          lines.push('  verify: /health auth');
+          lines.push('  connected host auth users/bootstrap cleanup manage outside Agent');
+          lines.push('  verify /health auth');
         } else if (domain === 'accounts') {
-          lines.push('  domain: accounts');
+          lines.push('  domain accounts');
           lines.push('  /accounts review');
           lines.push('  /accounts routes <provider>');
           lines.push('  /accounts repair <provider>');
           lines.push('  /auth show <provider>');
-          lines.push('  verify: /health accounts');
+          lines.push('  verify /health accounts');
         } else if (domain === 'host' || domain === 'services') {
-          lines.push('  domain: host');
+          lines.push('  domain host');
           lines.push('  /health host');
           lines.push('  connected host repair belongs outside Agent');
-          lines.push('  verify: /health host');
+          lines.push('  verify /health host');
         } else if (domain === 'remote') {
-          lines.push('  domain: remote');
+          lines.push('  domain remote');
           lines.push('  /delegate <build/fix/review task> for explicit TUI build work');
-          lines.push('  remote runner setup and recovery belong outside Agent');
-          lines.push('  verify: /health remote');
+          lines.push('  remote build-host setup and recovery belong outside Agent');
+          lines.push('  verify /health remote');
         } else if (domain === 'mcp') {
-          lines.push('  domain: mcp');
+          lines.push('  domain mcp');
           lines.push('  /mcp review');
           lines.push('  /mcp auth-review');
           lines.push('  /mcp repair [server]');
-          lines.push('  verify: /health mcp');
+          lines.push('  verify /health mcp');
         } else if (domain === 'continuity') {
-          lines.push('  domain: continuity');
+          lines.push('  domain continuity');
           lines.push('  /session list');
           lines.push('  /session resume <id>');
           lines.push('  /session hotspots');
-          lines.push('  verify: /health continuity');
+          lines.push('  verify /health continuity');
         } else if (domain === 'maintenance') {
-          lines.push('  domain: maintenance');
+          lines.push('  domain maintenance');
           lines.push('  /health maintenance');
           lines.push('  /mode');
           lines.push('  /compact');
-          lines.push('  verify: /health maintenance');
+          lines.push('  verify /health maintenance');
         } else {
-          lines.push('  domains: settings, auth, accounts, host, remote, mcp, continuity, maintenance');
-          lines.push('  use: /health repair <domain>');
+          lines.push('  domains settings, auth, accounts, host, remote, mcp, continuity, maintenance');
+          lines.push('  use /health repair <domain>');
         }
         ctx.print(lines.join('\n'));
         return;
@@ -308,15 +334,14 @@ export function registerHealthRuntimeCommands(registry: CommandRegistry): void {
       });
 
       const snapshot = await buildSetupReviewSnapshot(ctx);
-      const operatorClient = requireOperatorClient(ctx);
-      const accountSnapshot = await operatorClient.providers.accountSnapshot();
+      const accountSnapshot = await loadProviderAccountSnapshot(ctx);
       const settingsSnapshot = getSettingsControlPlaneSnapshot(ctx.platform.configManager);
       if (sub === 'setup') {
         ctx.print([
-          'Health Review: Setup',
-          ...snapshot.issues.map((issue) => `  [${issue.severity.toUpperCase()}] ${issue.area}: ${issue.message}`),
-          ...(snapshot.serviceIssues.length > 0
-            ? ['', '  Connected host integration issues:', ...snapshot.serviceIssues.map((issue) => `    - ${issue}`)]
+          'Health Review Setup',
+          ...snapshot.issues.map((issue) => `  [${issue.severity.toUpperCase()}] ${issue.area} ${issue.message}`),
+          ...(snapshot.hostIntegrationIssues.length > 0
+            ? ['', '  Connected host integration issues', ...snapshot.hostIntegrationIssues.map((issue) => `    - ${issue}`)]
             : []),
         ].join('\n'));
         return;
@@ -324,19 +349,19 @@ export function registerHealthRuntimeCommands(registry: CommandRegistry): void {
 
       ctx.print([
         'Health Review',
-        `  session: ${snapshot.sessionId}`,
-        `  setup issues: ${snapshot.issues.length}`,
-        `  host integration issues: ${snapshot.serviceIssues.length}`,
-        `  active subscriptions: ${snapshot.activeSubscriptionCount}`,
-        `  account issues: ${accountSnapshot.issueCount}`,
-        `  settings conflicts: ${settingsSnapshot.conflicts.length}`,
-        `  managed locks: ${settingsSnapshot.managedLockCount}`,
-        `  connected-host auth owner: outside Agent`,
+        `  session ${snapshot.sessionId}`,
+        `  setup issues ${snapshot.issues.length}`,
+        `  host integration issues ${snapshot.hostIntegrationIssues.length}`,
+        `  active subscriptions ${snapshot.activeSubscriptionCount}`,
+        `  account issues ${accountSnapshot.issueCount}`,
+        `  settings conflicts ${settingsSnapshot.conflicts.length}`,
+        `  managed locks ${settingsSnapshot.managedLockCount}`,
+        `  connected host auth owner outside Agent`,
         ...formatSessionMaintenanceLines(maintenance, 'guided').map((line) => `  ${line}`),
-        ...(snapshot.issues.length > 0 ? ['', ...snapshot.issues.map((issue) => `  [${issue.severity.toUpperCase()}] ${issue.area}: ${issue.message}`)] : []),
-        ...(snapshot.serviceIssues.length > 0 ? ['', ...snapshot.serviceIssues.map((issue) => `  host integration: ${issue}`)] : []),
+        ...(snapshot.issues.length > 0 ? ['', ...snapshot.issues.map((issue) => `  [${issue.severity.toUpperCase()}] ${issue.area} ${issue.message}`)] : []),
+        ...(snapshot.hostIntegrationIssues.length > 0 ? ['', ...snapshot.hostIntegrationIssues.map((issue) => `  host integration ${issue}`)] : []),
         '',
-        'Next steps:',
+        'Next steps',
         '  /health review',
         '  /health host',
         '  /health accounts',