@pellux/goodvibes-agent 0.1.117 → 1.0.0

package/src/renderer/context-inspector.ts

@@ -3,6 +3,45 @@ import { ModalFactory } from './modal-factory.ts';
 import type { ConversationManager } from '../core/conversation';
 import { getOverlayContentBudget, getOverlaySurfaceMetrics, getStableOverlayContentRows } from './overlay-viewport.ts';
 
+const CONTEXT_INSPECTOR_TITLE = 'Context Inspector';
+const CONTEXT_INSPECTOR_EMPTY_MESSAGE = 'No messages in conversation yet.';
+const CONTEXT_INSPECTOR_CLOSE_HINTS = ['[Esc] Close'];
+const CONTEXT_INSPECTOR_CONTEXT_HINTS = ['[*] >10% of context', '[Esc] Close'];
+const CONTEXT_INSPECTOR_FULL_WARNING = 'WARNING: context is 80%+ full. Open Agent Workspace -> Conversation -> Compact conversation.';
+const CONTEXT_INSPECTOR_COMPACT_GUIDANCE = 'Open Agent Workspace -> Conversation -> Compact conversation to summarise and reduce context size.';
+
+function contextInspectorTotalText(
+  totalTokens: string,
+  messageCount: string | number,
+  capacity: string | null = null,
+): string {
+  const capacityStr = capacity ? `  |  Capacity: ${totalTokens} / ${capacity}` : '';
+  return `Total: ~${totalTokens} tokens (${messageCount} messages)${capacityStr}`;
+}
+
+function contextInspectorOlderMessagesText(count: string | number): string {
+  return `(${count} older messages not shown)`;
+}
+
+function contextInspectorCompactionHintText(count: string | number, percent: string): string {
+  const suffix = typeof count === 'number' && count === 1 ? '' : 's';
+  return `Compaction hint: ${count} message${suffix} use ${percent} of context.`;
+}
+
+export function renderContextInspectorPackageText(): string {
+  return [
+    CONTEXT_INSPECTOR_TITLE,
+    CONTEXT_INSPECTOR_EMPTY_MESSAGE,
+    contextInspectorTotalText('<tokens>', '<messages>', '<window> (<percent>)'),
+    CONTEXT_INSPECTOR_FULL_WARNING,
+    contextInspectorOlderMessagesText('<count>'),
+    contextInspectorCompactionHintText('<count>', '<percent>'),
+    CONTEXT_INSPECTOR_COMPACT_GUIDANCE,
+    ...CONTEXT_INSPECTOR_CLOSE_HINTS,
+    ...CONTEXT_INSPECTOR_CONTEXT_HINTS,
+  ].join('\n');
+}
+
 // ─── ContextInspectorModal ────────────────────────────────────────────────────
 
 /**
@@ -67,14 +106,14 @@ export function renderContextInspector(
 
   if (messages.length === 0) {
     return ModalFactory.createModal({
-      title: 'Context Inspector',
+      title: CONTEXT_INSPECTOR_TITLE,
       width: metrics.boxWidth,
       margin: metrics.margin,
       targetContentRows,
       sections: [
-        { type: 'text', content: 'No messages in conversation yet.' },
+        { type: 'text', content: CONTEXT_INSPECTOR_EMPTY_MESSAGE },
       ],
-      hints: ['[Esc] Close'],
+      hints: CONTEXT_INSPECTOR_CLOSE_HINTS,
     }, width);
   }
 
@@ -139,19 +178,17 @@ export function renderContextInspector(
   const sections: import('./modal-factory.ts').ModalSection[] = [];
 
   // Summary header
-  const capacityStr = contextWindow > 0
-    ? `  |  Capacity: ${fmtN(totalTokens)} / ${fmtN(contextWindow)} (${fmtPct(totalTokens / contextWindow)})`
-    : '';
+  const capacityStr = contextWindow > 0 ? `${fmtN(contextWindow)} (${fmtPct(totalTokens / contextWindow)})` : null;
   sections.push({
     type: 'text',
-    content: `Total: ~${fmtN(totalTokens)} tokens (${messages.length} messages)${capacityStr}`,
+    content: contextInspectorTotalText(fmtN(totalTokens), messages.length, capacityStr),
     style: { bold: true },
   });
 
   if (contextWindow > 0 && totalTokens / contextWindow >= 0.80) {
     sections.push({
       type: 'text',
-      content: 'WARNING: context is 80%+ full. Run /compact to free space.',
+      content: CONTEXT_INSPECTOR_FULL_WARNING,
       style: { fg: '#ff9900', bold: true },
     });
   }
@@ -169,7 +206,7 @@ export function renderContextInspector(
   if (startOffset > 0) {
     sections.push({
       type: 'text',
-      content: `(${startOffset} older messages not shown)`,
+      content: contextInspectorOlderMessagesText(startOffset),
       style: { dim: true },
     });
   }
@@ -198,22 +235,22 @@ export function renderContextInspector(
     );
     sections.push({
       type: 'text',
-      content: `Compaction hint: ${largeMsgs.length} message${largeMsgs.length > 1 ? 's' : ''} use ${largePct} of context.`,
+      content: contextInspectorCompactionHintText(largeMsgs.length, largePct),
       style: { fg: '#00ffcc' },
     });
     sections.push({
       type: 'text',
-      content: 'Run /compact to summarise and reduce context size.',
+      content: CONTEXT_INSPECTOR_COMPACT_GUIDANCE,
       style: { dim: true },
     });
   }
 
   return ModalFactory.createModal({
-    title: 'Context Inspector',
+    title: CONTEXT_INSPECTOR_TITLE,
     width: metrics.boxWidth,
     margin: metrics.margin,
     targetContentRows,
     sections,
-    hints: ['[*] >10% of context', '[Esc] Close'],
+    hints: CONTEXT_INSPECTOR_CONTEXT_HINTS,
   }, width);
 }

package/src/renderer/diff.ts

@@ -31,7 +31,7 @@ export class DiffEngine {
     for (let y = 0; y < newBuffer.height; y++) {
       // Skip rows that were not written in either the old or new buffer.
       // If neither side touched the row, both must match the prior frame:
-      // old row was never written this frame (clean) and new row is also
+      // old row had no write this frame (clean) and new row is also
       // clean, so the on-screen content is still correct. No diff needed.
       const newDirty = newBuffer.dirtyRows[y] ?? false;
       const oldDirty = oldBuffer ? (oldBuffer.dirtyRows[y] ?? false) : true;

package/src/renderer/file-picker-overlay.ts

@@ -11,6 +11,20 @@ import {
 } from './overlay-box.ts';
 import { getOverlaySurfaceMetrics } from './overlay-viewport.ts';
 
+const FILE_PICKER_TITLE = 'Select File';
+const FILE_PICKER_SEARCH_PREFIX = '@ ';
+const FILE_PICKER_EMPTY_MESSAGE = 'No matching files';
+const FILE_PICKER_HINTS = '[Up/Down] Navigate  [/] Search  [Enter] Select  [Esc] Cancel';
+
+export function renderFilePickerPackageText(): string {
+  return [
+    FILE_PICKER_TITLE,
+    FILE_PICKER_SEARCH_PREFIX.trim(),
+    FILE_PICKER_EMPTY_MESSAGE,
+    FILE_PICKER_HINTS,
+  ].join('\n');
+}
+
 /**
  * Render the file picker modal as Line[] for overlay in the viewport.
  * Shows a bordered box with fuzzy-matched file results.
@@ -37,13 +51,13 @@ export function renderFilePickerOverlay(
 
   // Title bar
   const titleLine = createOverlayFilledBorderLine(width, layout, OVERLAY_GLYPHS.topLeft, OVERLAY_GLYPHS.horizontal, OVERLAY_GLYPHS.topRight, borderFg, DEFAULT_OVERLAY_PALETTE.titleBg);
-  putOverlayText(titleLine, layout.margin + 2, layout.width - 4, 'Select File', { fg: titleFg, bold: true });
+  putOverlayText(titleLine, layout.margin + 2, layout.width - 4, FILE_PICKER_TITLE, { fg: titleFg, bold: true });
   lines.push(titleLine);
 
   // Search input
   const queryDisplay = picker.query || '';
   const searchLine = createOverlayContentLine(width, layout, borderFg, DEFAULT_OVERLAY_PALETTE.inputBg);
-  const searchPrefix = '@ ';
+  const searchPrefix = FILE_PICKER_SEARCH_PREFIX;
   const queryText = fitDisplay(`${queryDisplay}${picker.searchFocused ? OVERLAY_GLYPHS.cursor : ''}`, Math.max(0, contentW - getDisplayWidth(searchPrefix)));
   putOverlayText(searchLine, layout.margin + 2, getDisplayWidth(searchPrefix), searchPrefix, { fg: picker.searchFocused ? bodyFg : mutedFg });
   putOverlayText(searchLine, layout.margin + 2 + getDisplayWidth(searchPrefix), contentW - getDisplayWidth(searchPrefix), queryText, { fg: picker.query.length > 0 || picker.searchFocused ? bodyFg : mutedFg });
@@ -54,8 +68,8 @@ export function renderFilePickerOverlay(
 
   // Results
   if (picker.results.length === 0) {
-      const noResults = createOverlayContentLine(width, layout, borderFg, DEFAULT_OVERLAY_PALETTE.bodyBg);
-    putOverlayText(noResults, layout.margin + 2, contentW, fitDisplay('No matching files', contentW), { fg: '244', dim: true });
+    const noResults = createOverlayContentLine(width, layout, borderFg, DEFAULT_OVERLAY_PALETTE.bodyBg);
+    putOverlayText(noResults, layout.margin + 2, contentW, fitDisplay(FILE_PICKER_EMPTY_MESSAGE, contentW), { fg: '244', dim: true });
     lines.push(noResults);
   } else {
     const maxVisible = metrics.contentRows;
@@ -92,9 +106,8 @@ export function renderFilePickerOverlay(
   }
 
   // Bottom border with hints
-  const hints = '[Up/Down] Navigate  [/] Search  [Enter] Select  [Esc] Cancel';
   const bottomLine = createOverlayFilledBorderLine(width, layout, OVERLAY_GLYPHS.bottomLeft, OVERLAY_GLYPHS.horizontal, OVERLAY_GLYPHS.bottomRight, borderFg, DEFAULT_OVERLAY_PALETTE.sectionBg);
-  putOverlayText(bottomLine, layout.margin + 2, layout.width - 4, truncateDisplay(hints, layout.width - 4), { fg: mutedFg, dim: true });
+  putOverlayText(bottomLine, layout.margin + 2, layout.width - 4, truncateDisplay(FILE_PICKER_HINTS, layout.width - 4), { fg: mutedFg, dim: true });
   lines.push(bottomLine);
 
   return lines;

package/src/renderer/help-overlay.ts

@@ -12,6 +12,105 @@ import { getOverlaySurfaceMetrics } from './overlay-viewport.ts';
 import { getVisibleWindow } from './surface-layout.ts';
 import { logger } from '@pellux/goodvibes-sdk/platform/utils';
 
+const FEATURED_HELP_COMMANDS: Array<[name: string, argHint: string, desc: string]> = [
+  ['agent',        '',           'Open workspace; press / there to search every action'],
+  ['agent',        'setup',      'Open setup workspace for local behavior, channels, and voice'],
+  ['agent',        'knowledge',  'Open isolated Agent Knowledge workspace actions'],
+  ['agent',        'voice-media', 'Open voice, image, browser, and media workspace actions'],
+  ['setup',        '',           'Open Agent setup with current settings preloaded'],
+  ['knowledge',    'status',     'Inspect isolated Agent Knowledge readiness'],
+  ['memory',       '',           'Manage Agent-local memory records'],
+  ['personas',     '',           'Manage serial Agent operating personas'],
+  ['skills',       '',           'Manage Agent-local skills and bundles'],
+  ['routines',     '',           'Manage reusable main-conversation routines'],
+  ['workplan',     '',           'Inspect shared work-plan state'],
+  ['approval',     '',           'Review and explicitly act on approvals'],
+  ['automation',   '',           'Run confirmed connected-host automation actions'],
+  ['schedule',     'remind',     'Create confirmed reminders or inspect schedules'],
+  ['delegate',     '',           'Explicitly hand build/fix/review work to GoodVibes TUI'],
+  ['mcp',          '',           'Inspect MCP servers and tool readiness'],
+  ['provider',     '',           'Choose provider or model family'],
+  ['model',        '',           'Select the active model route'],
+  ['subscription', '',           'Review provider logins and subscriptions'],
+  ['secrets',      '',           'Manage secret references without printing values'],
+  ['bundle',       'inspect',    'Inspect Agent support bundles from the TUI'],
+  ['compat',       '',           'Inspect connected-host and Agent Knowledge compatibility'],
+  ['health',       '',           'Run Agent runtime and setup diagnostics'],
+];
+
+const HELP_OVERLAY_STATIC_TEXT = [
+  'Core Navigation',
+  'Scroll / history recall',
+  'Scroll by full page',
+  'Search conversation (Ctrl+F)',
+  'Prompt And Editing',
+  'Submit message',
+  'Insert newline',
+  'Paste (image priority)',
+  'Undo / redo',
+  'Overlays And Workspace',
+  'Toggle help',
+  'Full keyboard shortcuts',
+  'Open the Agent operator workspace',
+  'Search all Agent workspace actions',
+  'Open selected action or form',
+  'Quick Start',
+  'Available Slash Commands',
+  'More Commands',
+  'Essentials',
+  'Show this help overlay',
+  'Keyboard shortcut reference',
+  'Select LLM model',
+  'Clear conversation',
+] as const;
+
+const SHORTCUT_OVERLAY_STATIC_TEXT = [
+  'Navigation',
+  'Scroll / history recall',
+  'Scroll by full page',
+  'Jump to start / end of line',
+  'Search conversation',
+  'Scroll conversation or hovered panel',
+  'Editing',
+  'Submit message',
+  'Insert newline',
+  'Open file picker',
+  'Slash command mode',
+  'Paste (image priority)',
+  'Undo / redo',
+  'Clear prompt',
+  'Delete word backward',
+  'Kill to end of line',
+  'Move to start of line',
+  'Next error / line end',
+  'Actions',
+  'Collapse/expand block',
+  'Bookmark block',
+  'Copy block to clipboard',
+  'Block file save disabled; copy or export',
+  'Copy selection',
+  'Process monitor',
+  'Help overlay',
+  'Exit',
+  'Workspace',
+  'Swap focus between input and active Agent workspace',
+  'Open the Agent operator workspace',
+  'Cycle Agent workspace category forward',
+  'Cycle Agent workspace category backward',
+  'Config: /keybindings to list and customize',
+] as const;
+
+export function renderHelpOverlayPackageText(): string {
+  return [
+    ...HELP_OVERLAY_STATIC_TEXT,
+    ...FEATURED_HELP_COMMANDS.flatMap(([name, argHint, desc]) => [
+      argHint ? `/${name} ${argHint}` : `/${name}`,
+      desc,
+    ]),
+    ...SHORTCUT_OVERLAY_STATIC_TEXT,
+  ].join('\n');
+}
+
 function toModalSections(rows: readonly string[]): import('./modal-factory.ts').ModalSection[] {
   return rows.map((row) => {
     if (row === '') return { type: 'spacer' as const };
@@ -62,37 +161,11 @@ export function renderHelpOverlay(
     `  ${'?'.padEnd(20)}  Toggle help`,
     `  ${'/shortcuts'.padEnd(20)}  Full keyboard shortcuts`,
     `  ${kb('panel-picker').padEnd(20)}  Open the Agent operator workspace`,
+    `  ${'Workspace /'.padEnd(20)}  Search all Agent workspace actions`,
+    `  ${'Workspace Enter'.padEnd(20)}  Open selected action or form`,
     '',
   ];
 
-  // Featured commands shown in the Quick Start section.
-  // Each entry is [commandName, subcommandOrArgHint, description].
-  // Commands not registered in the live registry are omitted at render time.
-  const FEATURED_COMMANDS: Array<[name: string, argHint: string, desc: string]> = [
-    ['agent',        '',           'Open the Agent operator workspace'],
-    ['agent',        'setup',      'Open setup, local behavior, channel, and voice workspaces'],
-    ['agent',        'knowledge',  'Open isolated Agent Knowledge workflows'],
-    ['agent',        'voice-media', 'Open voice, image, browser, and media setup'],
-    ['setup',        '',           'Open Agent setup with current settings preloaded'],
-    ['knowledge',    'status',     'Inspect isolated Agent Knowledge readiness'],
-    ['memory',       '',           'Manage local Agent memory records'],
-    ['personas',     '',           'Manage serial Agent operating personas'],
-    ['agent-skills', '',           'Manage local Agent skills and bundles'],
-    ['routines',     '',           'Manage reusable main-conversation routines'],
-    ['workplan',     '',           'Inspect shared work-plan state'],
-    ['approval',     '',           'Review and explicitly act on approvals'],
-    ['schedule',     'remind',     'Create confirmed reminders or inspect schedules'],
-    ['delegate',     '',           'Explicitly hand build/fix/review work to GoodVibes TUI'],
-    ['mcp',          '',           'Inspect MCP servers and tool readiness'],
-    ['provider',     '',           'Choose provider or model family'],
-    ['model',        '',           'Select the active model route'],
-    ['subscription', '',           'Review provider logins and subscriptions'],
-    ['secrets',      '',           'Manage secret references without printing values'],
-    ['bundle',       'inspect',    'Inspect Agent support bundles from the TUI'],
-    ['compat',       '',           'Inspect connected-host and Agent Knowledge compatibility'],
-    ['health',       '',           'Run Agent runtime and setup diagnostics'],
-  ];
-
   // Build command rows from featured list, filtering out unregistered commands.
   function featuredRow(name: string, argHint: string, desc: string): string {
     const invocation = argHint ? `/${name} ${argHint}` : `/${name}`;
@@ -101,7 +174,7 @@ export function renderHelpOverlay(
 
   const quickStartRows: string[] = [];
   try {
-    for (const [name, argHint, desc] of FEATURED_COMMANDS) {
+    for (const [name, argHint, desc] of FEATURED_HELP_COMMANDS) {
       if (!hasCommand(name)) continue; // omit if not in live registry
       quickStartRows.push(featuredRow(name, argHint, desc));
     }
@@ -110,7 +183,7 @@ export function renderHelpOverlay(
     // unfiltered quick-start list so /help remains reachable.
     logger.warn(`[help-overlay] registry traversal error during command filter; using unfiltered list: ${err}`);
     quickStartRows.length = 0;
-    for (const [name, argHint, desc] of FEATURED_COMMANDS) {
+    for (const [name, argHint, desc] of FEATURED_HELP_COMMANDS) {
       quickStartRows.push(featuredRow(name, argHint, desc));
     }
   }
@@ -128,7 +201,7 @@ export function renderHelpOverlay(
       'knowledge',
       'memory',
       'personas',
-      'agent-skills',
+      'skills',
       'routines',
       'workplan',
       'approval',
@@ -261,8 +334,8 @@ export function renderShortcutsOverlay(
     '  ' + '\u2500'.repeat(40),
     row('Tab', 'Swap focus between input and active Agent workspace'),
     row(kb('panel-picker'), 'Open the Agent operator workspace'),
-    row(kb('panel-tab-next'), 'Reserved for future Agent workspace tabs'),
-    row(kb('panel-tab-prev'), 'Reserved for future Agent workspace tabs'),
+    row(kb('panel-tab-next'), 'Cycle Agent workspace category forward'),
+    row(kb('panel-tab-prev'), 'Cycle Agent workspace category backward'),
     '',
     `  Config: /keybindings to list and customize`,
   ];

package/src/renderer/history-search-overlay.ts

@@ -3,6 +3,22 @@ import { getDisplayWidth } from '../utils/terminal-width.ts';
 import type { HistorySearch } from '../input/input-history.ts';
 import { createBottomBarLine, writeBottomBarText } from './bottom-bar.ts';
 
+const HISTORY_SEARCH_PREFIX = '(reverse-i-search)`';
+const HISTORY_SEARCH_FAILED_PREFIX = '(failed reverse-i-search)`';
+const HISTORY_SEARCH_QUERY_SUFFIX = "': ";
+
+function historySearchLabel(prefix: string, query: string): string {
+  return prefix + query + HISTORY_SEARCH_QUERY_SUFFIX;
+}
+
+export function renderHistorySearchOverlayPackageText(): string {
+  return [
+    historySearchLabel(HISTORY_SEARCH_PREFIX, '<query>'),
+    historySearchLabel(HISTORY_SEARCH_FAILED_PREFIX, '<query>'),
+    '<matched-command-text>',
+  ].join('\n');
+}
+
 /**
  * Truncate `text` to at most `maxWidth` display columns, then pad with spaces
  * to exactly `maxWidth` columns. CJK/emoji wide characters count as 2 columns.
@@ -42,13 +58,12 @@ export function renderHistorySearchOverlay(
   const noMatch = historySearch.query.length > 0 && !hasMatch;
 
   const prefix = noMatch
-    ? '(failed reverse-i-search)`'
-    : '(reverse-i-search)`';
-  const queryPart = historySearch.query + "': ";
+    ? HISTORY_SEARCH_FAILED_PREFIX
+    : HISTORY_SEARCH_PREFIX;
   const matchText = hasMatch ? match?.entry ?? '' : '';
 
   // Build the display string
-  const label = prefix + queryPart;
+  const label = historySearchLabel(prefix, historySearch.query);
   const full = truncateToWidth(label + matchText, width);
 
   const line = createBottomBarLine(width, { fg: '#000000', bg: '#00ffcc' });

package/src/renderer/live-tail-modal.ts

@@ -4,6 +4,28 @@ import type { ProcessManager } from '@pellux/goodvibes-sdk/platform/tools';
 import type { ProcessEntry } from './process-modal.ts';
 import { getOverlaySurfaceMetrics, getStableOverlayContentRows } from './overlay-viewport.ts';
 
+const LIVE_TAIL_PROCESS_TAG = '[exec]';
+const LIVE_TAIL_EMPTY_OUTPUT = '(no output yet)';
+const LIVE_TAIL_SCROLL_HINT = '[Up/Down] Scroll';
+const LIVE_TAIL_HINTS = [LIVE_TAIL_SCROLL_HINT, '[k] Stop process', '[Esc] Back'];
+
+function liveTailTitle(label: string): string {
+  return `${LIVE_TAIL_PROCESS_TAG} ${label}`;
+}
+
+function liveTailScrollInfo(start: string | number, end: string | number, total: string | number): string {
+  return `  Lines ${start}-${end} of ${total}  ${LIVE_TAIL_SCROLL_HINT}`;
+}
+
+export function renderLiveTailModalPackageText(): string {
+  return [
+    liveTailTitle('<process>'),
+    LIVE_TAIL_EMPTY_OUTPUT,
+    liveTailScrollInfo('<start>', '<end>', '<total>'),
+    ...LIVE_TAIL_HINTS,
+  ].join('\n');
+}
+
 export interface LiveTailModalDeps {
   readonly processManager: Pick<ProcessManager, 'stop' | 'getOutput'>;
 }
@@ -45,7 +67,7 @@ export class LiveTailModal {
     const output = this.deps.processManager.getOutput(this.entry.id);
     if (!output) return '';
     const combined = [output.stdout, output.stderr].filter(Boolean).join('\n').trim();
-    return combined || '(no output yet)';
+    return combined || LIVE_TAIL_EMPTY_OUTPUT;
   }
 }
 
@@ -74,9 +96,9 @@ export function renderLiveTailModal(
   const visibleLines = allLines.slice(startIdx, endIdx);
 
   const maxLabelW = Math.max(20, width - 30);
-  const title = `[exec] ${entry.label.slice(0, maxLabelW)}`;
+  const title = liveTailTitle(entry.label.slice(0, maxLabelW));
   const scrollInfo = totalLines > maxOutputLines
-    ? `  Lines ${startIdx + 1}-${Math.min(endIdx, totalLines)} of ${totalLines}  [Up/Down] Scroll`
+    ? liveTailScrollInfo(startIdx + 1, Math.min(endIdx, totalLines), totalLines)
     : '';
 
   const sections: import('./modal-factory.ts').ModalSection[] = [];
@@ -84,7 +106,7 @@ export function renderLiveTailModal(
     sections.push({ type: 'text', content: scrollInfo });
     sections.push({ type: 'separator' });
   }
-  sections.push({ type: 'text', content: visibleLines.join('\n') || '(no output yet)' });
+  sections.push({ type: 'text', content: visibleLines.join('\n') || LIVE_TAIL_EMPTY_OUTPUT });
 
   return ModalFactory.createModal({
     title,
@@ -92,6 +114,6 @@ export function renderLiveTailModal(
     margin: 2,
     targetContentRows,
     sections,
-    hints: ['[Up/Down] Scroll', '[k] Stop process', '[Esc] Back'],
+    hints: LIVE_TAIL_HINTS,
   }, width);
 }