@pellux/goodvibes-agent 0.1.117 → 1.0.0

package/src/cli/config-overrides.ts

@@ -1,4 +1,4 @@
-import type { ConfigKey, ConfigManager, ConfigSetting, GoodVibesConfig, PersistedFlagState } from '../config/index.ts';
+import type { ConfigKey, ConfigManager, ConfigSetting, PersistedFlagState } from '../config/index.ts';
 import { CONFIG_SCHEMA, ConfigError } from '../config/index.ts';
 import type { GoodVibesCliCommand, GoodVibesCliFlags } from './types.ts';
 import { RUNTIME_ENDPOINT_CONFIG_KEYS, hostModeForHostname } from './endpoints.ts';
@@ -8,6 +8,31 @@ const CONFIG_SCHEMA_BY_KEY = new Map<string, ConfigSetting>(
   CONFIG_SCHEMA.map((setting) => [setting.key, setting]),
 );
 
+type RuntimeOnlyConfigManager = {
+  readonly config: Record<string, unknown>;
+};
+
+function mutableConfig(configManager: ConfigManager): Record<string, unknown> {
+  return (configManager as unknown as RuntimeOnlyConfigManager).config;
+}
+
+function setRuntimeOnlyConfigValue(configManager: ConfigManager, key: ConfigKey, value: unknown): void {
+  const parts = key.split('.');
+  let cursor = mutableConfig(configManager);
+  for (const part of parts.slice(0, -1)) {
+    const next = cursor[part];
+    if (!next || typeof next !== 'object' || Array.isArray(next)) {
+      throw new ConfigError(`Unknown config key: ${key}`);
+    }
+    cursor = next as Record<string, unknown>;
+  }
+  const leaf = parts.at(-1);
+  if (!leaf || !(leaf in cursor)) {
+    throw new ConfigError(`Unknown config key: ${key}`);
+  }
+  cursor[leaf] = value;
+}
+
 function parseConfigOverrideValue(value: string): unknown {
   const trimmed = value.trim();
   if (trimmed.length === 0) return '';
@@ -53,45 +78,22 @@ function parseRuntimeUrl(rawValue: string, source: string): { readonly host: str
   return { host: url.hostname, port };
 }
 
-function getRuntimeConfig(configManager: ConfigManager): GoodVibesConfig {
-  const mutable = configManager as unknown as { config?: GoodVibesConfig };
-  if (!mutable.config || typeof mutable.config !== 'object') {
-    throw new ConfigError('ConfigManager runtime config is not available for CLI overrides.');
-  }
-  return mutable.config;
-}
-
 function validateConfigValue(setting: ConfigSetting, value: unknown): void {
   if (setting.type === 'boolean' && typeof value !== 'boolean') {
-    throw new ConfigError(`Invalid value for ${setting.key}: expected boolean.`);
+    throw new ConfigError(`Invalid value for ${setting.key}. Expected boolean.`);
   }
   if (setting.type === 'number' && (typeof value !== 'number' || !Number.isFinite(value))) {
-    throw new ConfigError(`Invalid value for ${setting.key}: expected number.`);
+    throw new ConfigError(`Invalid value for ${setting.key}. Expected number.`);
   }
   if (setting.type === 'string' && typeof value !== 'string') {
-    throw new ConfigError(`Invalid value for ${setting.key}: expected string.`);
+    throw new ConfigError(`Invalid value for ${setting.key}. Expected string.`);
   }
   if (setting.type === 'enum' && setting.enumValues && !setting.enumValues.includes(String(value))) {
-    throw new ConfigError(`Invalid value for ${setting.key}: "${String(value)}". Allowed: ${setting.enumValues.join(', ')}`);
+    throw new ConfigError(`Invalid value for ${setting.key} "${String(value)}". Allowed values ${setting.enumValues.join(', ')}.`);
   }
   if (setting.validate && !setting.validate(value)) {
-    throw new ConfigError(`Invalid value for ${setting.key}: ${String(value)}`);
-  }
-}
-
-function setNestedConfigValue(config: GoodVibesConfig, key: ConfigKey, value: unknown): void {
-  const parts = key.split('.');
-  let cursor: unknown = config;
-  for (const part of parts.slice(0, -1)) {
-    if (cursor == null || typeof cursor !== 'object' || !(part in cursor)) {
-      throw new ConfigError(`Invalid config path: section '${part}' does not exist`);
-    }
-    cursor = (cursor as Record<string, unknown>)[part];
-  }
-  if (cursor == null || typeof cursor !== 'object') {
-    throw new ConfigError(`Invalid config path: section '${parts.slice(0, -1).join('.')}' does not exist`);
+    throw new ConfigError(`Invalid value for ${setting.key} ${String(value)}`);
   }
-  (cursor as Record<string, unknown>)[parts[parts.length - 1]!] = value;
 }
 
 export function applyRuntimeConfigValue(configManager: ConfigManager, key: ConfigKey, value: unknown): void {
@@ -100,7 +102,7 @@ export function applyRuntimeConfigValue(configManager: ConfigManager, key: Confi
     throw new ConfigError(`Unknown config key: ${key}`);
   }
   validateConfigValue(setting, value);
-  setNestedConfigValue(getRuntimeConfig(configManager), key, value);
+  setRuntimeOnlyConfigValue(configManager, key, value);
 }
 
 export function applyRuntimeConfigOverrides(
@@ -119,7 +121,7 @@ export function applyRuntimeConfigOverrides(
     try {
       applyRuntimeConfigValue(configManager, key, parseConfigOverrideValue(rawValue));
     } catch (error) {
-      errors.push(error instanceof Error ? `Invalid --config ${override}: ${error.message}` : `Invalid --config ${override}`);
+      errors.push(error instanceof Error ? `Invalid --config ${override}. ${error.message}` : `Invalid --config ${override}`);
     }
   }
   return errors;
@@ -149,15 +151,14 @@ export function applyRuntimeFeatureFlagOverrides(
   },
 ): void {
   if (options.enableFeatures.length === 0 && options.disableFeatures.length === 0) return;
-  const config = getRuntimeConfig(configManager);
-  const flags = { ...config.featureFlags };
+  const flags = { ...configManager.getCategory('featureFlags') };
   for (const feature of options.enableFeatures) {
     flags[feature] = 'enabled' satisfies PersistedFlagState;
   }
   for (const feature of options.disableFeatures) {
     flags[feature] = 'disabled' satisfies PersistedFlagState;
   }
-  config.featureFlags = flags;
+  mutableConfig(configManager).featureFlags = flags;
 }
 
 export function applyRuntimeEndpointFlagOverrides(
@@ -174,7 +175,7 @@ export function applyRuntimeEndpointFlagOverrides(
       applyRuntimeConfigValue(configManager, keys.host, flags.hostname);
     } catch (error) {
       errors.push(error instanceof Error
-        ? `Invalid --hostname ${flags.hostname}: ${error.message}`
+        ? `Invalid --hostname ${flags.hostname}. ${error.message}`
         : `Invalid --hostname ${flags.hostname}`);
     }
   }
@@ -184,7 +185,7 @@ export function applyRuntimeEndpointFlagOverrides(
       applyRuntimeConfigValue(configManager, keys.port, flags.port);
     } catch (error) {
       errors.push(error instanceof Error
-        ? `Invalid --port ${flags.port}: ${error.message}`
+        ? `Invalid --port ${flags.port}. ${error.message}`
         : `Invalid --port ${flags.port}`);
     }
   }

package/src/cli/external-runtime.ts

@@ -26,7 +26,7 @@ export interface CliExternalRuntimeSnapshot {
   readonly agentKnowledge: {
     readonly route: '/api/goodvibes-agent/knowledge/status';
     readonly ready: boolean;
-    readonly kind: 'ok' | 'auth_required' | 'daemon_unavailable' | 'version_mismatch' | 'route_unavailable' | 'runtime_error';
+    readonly kind: 'ok' | 'auth_required' | 'connected_host_unavailable' | 'version_mismatch' | 'connected_host_route_unavailable' | 'connected_host_error';
     readonly statusCode: number | null;
   };
   readonly error: string | null;
@@ -112,7 +112,7 @@ export async function inspectCliExternalRuntime(
         agentKnowledge: {
           route,
           ready: false,
-          kind: status.status === 401 ? 'auth_required' : 'daemon_unavailable',
+          kind: status.status === 401 ? 'auth_required' : 'connected_host_unavailable',
           statusCode: status.status,
         },
         error: typeof status.body === 'string' ? status.body : `HTTP ${status.status}`,
@@ -169,7 +169,13 @@ export async function inspectCliExternalRuntime(
       agentKnowledge: {
         route,
         ready: knowledge.ok,
-        kind: knowledge.ok ? 'ok' : knowledge.status === 401 ? 'auth_required' : knowledge.status === 404 ? 'route_unavailable' : 'runtime_error',
+        kind: knowledge.ok
+          ? 'ok'
+          : knowledge.status === 401
+            ? 'auth_required'
+            : knowledge.status === 404
+              ? 'connected_host_route_unavailable'
+              : 'connected_host_error',
         statusCode: knowledge.status,
       },
       error: knowledge.ok ? null : typeof knowledge.body === 'string' ? knowledge.body : `HTTP ${knowledge.status}`,
@@ -186,7 +192,7 @@ export async function inspectCliExternalRuntime(
       agentKnowledge: {
         route,
         ready: false,
-        kind: 'daemon_unavailable',
+        kind: 'connected_host_unavailable',
         statusCode: null,
       },
       error: summarizeError(error),

package/src/cli/help.ts

@@ -37,7 +37,8 @@ export function renderGoodVibesHelp(binary = 'goodvibes-agent'): string {
     '  /setup                    Open setup/config flows',
     '  /model                    Choose provider and model',
     '  /knowledge                Use isolated Agent Knowledge',
-    '  /personas, /skills        Tune local Agent behavior',
+    '  /notes                    Open Agent-local scratchpad notes',
+    '  /personas, /skills        Tune Agent-local behavior',
     '  /routines                 Run local routines in the main conversation',
     '  /schedule remind          Create confirmed reminders or inspect schedules',
     '  /delegate                 Explicitly hand build/fix/review work to GoodVibes TUI',
@@ -56,7 +57,7 @@ export function renderGoodVibesHelp(binary = 'goodvibes-agent'): string {
     '  routines                   Inspect local routines and explicitly promote one to a connected schedule',
     '  auth                       Inspect Agent auth posture and connection token state',
     '  compat                     Inspect Agent SDK pin, connected host version, and Agent Knowledge route readiness',
-    '  knowledge                  Use isolated Agent Knowledge/Wiki routes',
+    '  knowledge                  Use isolated Agent Knowledge routes',
     '  ask|search                 Shortcuts for isolated Agent Knowledge ask/search',
     '  delegate                   Explicitly delegate build/fix/review work to GoodVibes TUI',
     '  subscription               Start/finish/logout provider subscription sessions',
@@ -115,7 +116,7 @@ export function renderGoodVibesHelp(binary = 'goodvibes-agent'): string {
     `  ${binary} knowledge ask "What is GoodVibes Agent?"`,
     `  ${binary} ask "What is GoodVibes Agent?"`,
     `  ${binary} search "release checklist"`,
-    `  ${binary} delegate --wrfc "fix the failing tests in ~/work/project"`,
+    `  ${binary} delegate --review "fix the failing tests in ~/work/project"`,
     `  ${binary} subscription providers`,
     `  ${binary} subscription login openai start --open`,
     `  ${binary} pair`,
@@ -177,7 +178,7 @@ const COMMAND_HELP: Record<string, CommandHelp> = {
       'personas stale <id> <reason>',
       'personas delete <id> --yes',
     ],
-    summary: 'Manage Agent-local personas for the serial main conversation. Personas do not spawn worker agents.',
+    summary: 'Manage Agent-local personas for the serial main conversation. Personas do not create separate Agent jobs.',
     examples: [
       'personas list',
       'personas discover',
@@ -236,7 +237,7 @@ const COMMAND_HELP: Record<string, CommandHelp> = {
       'memory handoff-inspect <path>',
       'memory vector [status|doctor|rebuild]',
     ],
-    summary: 'Manage Agent-owned durable memory. This uses the Agent memory store only; it never falls back to default Knowledge/Wiki or non-Agent knowledge segments.',
+    summary: 'Manage Agent-owned durable memory. This uses the Agent memory store only; it never falls back to default knowledge or non-Agent knowledge segments.',
     examples: [
       'memory list',
       'memory add fact "Prefers concise morning briefings" --scope project --tags preference',
@@ -305,7 +306,7 @@ const COMMAND_HELP: Record<string, CommandHelp> = {
       'knowledge import-browser-history [--browsers chrome,firefox] [--sources history,bookmark] --yes',
       'knowledge reindex --yes',
     ],
-    summary: 'Call isolated Agent Knowledge/Wiki routes under /api/goodvibes-agent/knowledge. No default wiki or non-Agent fallback.',
+    summary: 'Call isolated Agent Knowledge routes under /api/goodvibes-agent/knowledge. No default knowledge or non-Agent fallback.',
     examples: [
       'knowledge status',
       'knowledge ask "What is GoodVibes Agent?"',
@@ -322,20 +323,20 @@ const COMMAND_HELP: Record<string, CommandHelp> = {
   },
   ask: {
     usage: ['ask <question> [--limit <n>] [--mode concise|standard|detailed]'],
-    summary: 'Shortcut for isolated Agent Knowledge ask. This never queries default Knowledge/Wiki or non-Agent knowledge.',
+    summary: 'Shortcut for isolated Agent Knowledge ask. This never queries default knowledge or non-Agent knowledge.',
     examples: ['ask "What is GoodVibes Agent?"', 'ask "release checklist" --mode concise'],
   },
   search: {
     usage: ['search <query> [--limit <n>]'],
-    summary: 'Shortcut for isolated Agent Knowledge search. This never queries default Knowledge/Wiki or non-Agent knowledge.',
+    summary: 'Shortcut for isolated Agent Knowledge search. This never queries default knowledge or non-Agent knowledge.',
     examples: ['search "release checklist"', 'search "operator workspace" --limit 5'],
   },
   delegate: {
-    usage: ['delegate [--wrfc] <build/fix/review task>'],
-    summary: 'Create one shared-session task request for GoodVibes TUI. WRFC is requested only with --wrfc.',
+    usage: ['delegate [--review] <build/fix/review task>'],
+    summary: 'Create one shared-session task request for GoodVibes TUI. Delegated review is requested with --review.',
     examples: [
       'delegate "fix the failing tests in this repo"',
-      'delegate --wrfc "implement the settings screen and review it"',
+      'delegate --review "implement the settings screen and review it"',
     ],
   },
   subscription: {
@@ -377,7 +378,9 @@ const COMMAND_HELP: Record<string, CommandHelp> = {
 
 const HELP_ALIASES: Record<string, string> = {
   exec: 'run',
+  e: 'run',
   onboarding: 'setup',
+  compatibility: 'compat',
   provider: 'providers',
   model: 'models',
   profile: 'profiles',
@@ -385,19 +388,34 @@ const HELP_ALIASES: Record<string, string> = {
   skill: 'skills',
   'agent-skills': 'skills',
   memories: 'memory',
+  routine: 'routines',
+  know: 'knowledge',
+  kb: 'knowledge',
+  find: 'search',
+  build: 'delegate',
   subscriptions: 'subscription',
   secret: 'secrets',
   session: 'sessions',
   task: 'tasks',
+  bundles: 'bundle',
   qrcode: 'pair',
   qr: 'pair',
+  completions: 'completion',
 };
 
+export function listGoodVibesHelpTopics(): readonly string[] {
+  return Object.keys(COMMAND_HELP).sort();
+}
+
 function normalizeHelpTopic(topic: string): string {
   const normalized = topic.trim().toLowerCase();
   return HELP_ALIASES[normalized] ?? normalized;
 }
 
+export function hasGoodVibesCommandHelp(topic: string): boolean {
+  return COMMAND_HELP[normalizeHelpTopic(topic)] !== undefined;
+}
+
 export function renderGoodVibesCommandHelp(topic: string, binary = 'goodvibes-agent'): string {
   const normalized = normalizeHelpTopic(topic);
   const help = COMMAND_HELP[normalized];