@openui5/sap.ui.rta 1.144.0 → 1.146.0

package/src/sap/ui/rta/plugin/annotations/AnnotationChangeDialogController.js

@@ -15,8 +15,7 @@ sap.ui.define([
 	"sap/ui/layout/form/FormElement",
 	"sap/ui/model/Filter",
 	"sap/ui/model/FilterOperator",
-	"sap/ui/rta/plugin/annotations/AnnotationTypes",
-	"sap/ui/rta/Utils"
+	"sap/ui/rta/plugin/annotations/AnnotationTypes"
 ], function(
 	Input,
 	Label,
@@ -28,8 +27,7 @@ sap.ui.define([
 	FormElement,
 	Filter,
 	FilterOperator,
-	AnnotationTypes,
-	RtaUtils
+	AnnotationTypes
 ) {
 	"use strict";
 
@@ -37,7 +35,7 @@ sap.ui.define([
 	 * @class Controller for the AnnotationChangeDialog.
 	 * @extends sap.ui.core.mvc.Controller
 	 * @author SAP SE
-	 * @version 1.144.0
+	 * @version 1.146.0
 	 * @constructor
 	 * @since 1.132
 	 * @private
@@ -51,21 +49,17 @@ sap.ui.define([
 		});
 	};
 
-	AnnotationChangeDialogController.prototype.formatDocumentationUrl = function() {
-		const oDocumentationUrls = {
-			btpUrl: "https://help.sap.com/docs/ui5-flexibility-for-key-users/ui5-flexibility-for-key-users/making-ui-changes",
-			s4HanaCloudUrl: "https://help.sap.com/docs/SAP_S4HANA_CLOUD/4fc8d03390c342da8a60f8ee387bca1a/54270a390b194c3e97be2424592c3352.html",
-			s4HanaOnPremUrl: "https://help.sap.com/docs/ABAP_PLATFORM_NEW/a7b390faab1140c087b8926571e942b7/54270a390b194c3e97be2424592c3352.html"
-		};
-
-		return RtaUtils.getSystemSpecificDocumentationUrl(oDocumentationUrls);
-	};
-
 	AnnotationChangeDialogController.prototype.filterProperties = function(sQuery, bEquals) {
 		const aFilters = [];
 		if (sQuery && sQuery.length > 0) {
-			const filter = new Filter("label", bEquals ? FilterOperator.EQ : FilterOperator.Contains, sQuery);
-			aFilters.push(filter);
+			const sOperator = bEquals ? FilterOperator.EQ : FilterOperator.Contains;
+			const oLabelFilter = new Filter("label", sOperator, sQuery);
+			const oValueFilter = new Filter("currentValue", sOperator, sQuery);
+			const oCombinedFilter = new Filter({
+				filters: [oLabelFilter, oValueFilter],
+				and: false
+			});
+			aFilters.push(oCombinedFilter);
 		}
 
 		const oList = Element.getElementById("sapUiRtaChangeAnnotationDialog_propertyList");

package/src/sap/ui/rta/plugin/annotations/AnnotationPlugin.js

@@ -105,7 +105,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.144.0
+	 * @version 1.146.0
 	 * @constructor
 	 * @private
 	 * @since 1.132
@@ -130,7 +130,7 @@ sap.ui.define([
 
 	/**
 	 * @param {sap.ui.dt.ElementOverlay} oElementOverlay - Overlay to be checked for editable
-	 * @returns {boolean} True if it's editable
+	 * @returns {boolean} <code>true</code> if it's editable
 	 * @private
 	 */
 	AnnotationPlugin.prototype._isEditable = function(oElementOverlay) {
@@ -159,7 +159,7 @@ sap.ui.define([
 	 * @public
 	 */
 	AnnotationPlugin.prototype.isEnabled = function(aElementOverlays) {
-		if (aElementOverlays.length !== 1) {
+		if (!this.isAvailable(aElementOverlays) || aElementOverlays.length !== 1) {
 			return false;
 		}
 
@@ -186,9 +186,10 @@ sap.ui.define([
 	 *
 	 * @param {sap.ui.dt.ElementOverlay[]} aElementOverlays - Target Overlays of the action
 	 * @param {object} oAction - The action object defined in the designtime
+	 * @param {string} sKey - Key of the action, used to display the specific documentation link
 	 * @return {Promise} Resolves with the creation of the commands
 	 */
-	AnnotationPlugin.prototype.handler = async function(aElementOverlays, oAction) {
+	AnnotationPlugin.prototype.handler = async function(aElementOverlays, oAction, sKey) {
 		const oElementOverlay = aElementOverlays[0];
 		const oElement = oElementOverlay.getElement();
 
@@ -201,7 +202,8 @@ sap.ui.define([
 				annotation: oAction.annotation,
 				description: oAction.description,
 				singleRename: oAction.singleRename,
-				controlBasedRenameChangeType: oAction.controlBasedRenameChangeType
+				controlBasedRenameChangeType: oAction.controlBasedRenameChangeType,
+				featureKey: sKey
 			});
 
 			if (aAnnotationChanges.length) {
@@ -272,7 +274,7 @@ sap.ui.define([
 							typeof oAction.isEnabled === "function" && oAction.isEnabled(aElementOverlays[0].getElement())
 							|| (oAction.isEnabled !== false) && this.isEnabled(aElementOverlays)
 						),
-						handler: this.handler.bind(this, aElementOverlays, oAction),
+						handler: this.handler.bind(this, aElementOverlays, oAction, sKey),
 						additionalInfo: this._getAdditionalInfo(oResponsibleElementOverlay, oAction)
 					});
 				}

package/src/sap/ui/rta/plugin/annotations/DocumentedAnnotationChanges.js

@@ -0,0 +1,14 @@
+
+/*!
+ * OpenUI5
+ * (c) Copyright 2026 SAP SE or an SAP affiliate company.
+ * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
+ */
+sap.ui.define([], function() {
+	"use strict";
+
+	return {
+		Rename: "rename",
+		TextArrangement: "textArrangement"
+	};
+});

package/src/sap/ui/rta/plugin/iframe/AddIFrame.js

@@ -5,21 +5,23 @@
  */
 
 sap.ui.define([
-	"sap/ui/core/Lib",
-	"sap/ui/rta/plugin/BaseCreate",
-	"sap/ui/fl/Utils",
-	"sap/ui/dt/Util",
 	"sap/base/util/uid",
 	"sap/ui/core/IconPool",
-	"sap/ui/rta/plugin/iframe/AddIFrameDialog"
+	"sap/ui/core/Lib",
+	"sap/ui/dt/Util",
+	"sap/ui/fl/util/CancelError",
+	"sap/ui/fl/Utils",
+	"sap/ui/rta/plugin/iframe/AddIFrameDialog",
+	"sap/ui/rta/plugin/BaseCreate"
 ], function(
-	Lib,
-	BaseCreate,
-	FlexUtils,
-	DtUtil,
 	uid,
 	IconPool,
-	AddIFrameDialog
+	Lib,
+	DtUtil,
+	CancelError,
+	FlexUtils,
+	AddIFrameDialog,
+	BaseCreate
 ) {
 	"use strict";
 
@@ -89,7 +91,7 @@ sap.ui.define([
 		})
 		.then(function(mSettings) {
 			if (!mSettings) {
-				return Promise.reject(); // Cancel
+				throw new CancelError();
 			}
 			mSettings.index = iIndex;
 			mSettings.aggregation = oAction.aggregation;
@@ -119,7 +121,7 @@ sap.ui.define([
 	 * @class The AddIFrame allows trigger AddIFrame operations on the overlay.
 	 * @extends sap.ui.rta.plugin.BaseCreate
 	 * @author SAP SE
-	 * @version 1.144.0
+	 * @version 1.146.0
 	 * @constructor
 	 * @private
 	 * @since 1.75

package/src/sap/ui/rta/plugin/iframe/AddIFrameDialog.fragment.xml

@@ -73,6 +73,7 @@
 							valueState="{= !!${dialogInfo>/frameUrlError/value} ? 'Error' : 'None'}"
 							valueStateText="{dialogInfo>/frameUrlError/value}"
 							validateFieldGroup="onValidateUrl"
+							liveChange="onUrlLiveChange"
 							rows="{= !!${dialogInfo>/showParameters/value} ? 8 : 1 }"
 							growingMaxLines="8"
 							width="100%"
@@ -193,9 +194,9 @@
 							id="sapUiRtaAddIFrameDialog_PreviewButton"
 							class="sapUiRtaAddIFrameDialogPreviewButton"
 							press="onPreviewPress"
-							enabled="{= !${dialogInfo>/frameUrlError/value} && (${dialogInfo>/previousFrameUrl/value} !== ${dialogInfo>/frameUrl/value} || ${dialogInfo>/settingsUpdate/value})}"
+							enabled="{= !${dialogInfo>/frameUrlError/value} && ${dialogInfo>/frameUrl/value} !== '' && (${dialogInfo>/previousFrameUrl/value} !== ${dialogInfo>/frameUrl/value} || ${dialogInfo>/settingsUpdate/value})}"
 							icon="{=${dialogInfo>/previousFrameUrl/value} ? 'sap-icon://refresh' : null }"
-							type="{= !${dialogInfo>/frameUrlError/value} && (${dialogInfo>/previousFrameUrl/value} !== ${dialogInfo>/frameUrl/value} || ${dialogInfo>/settingsUpdate/value}) ? 'Emphasized' : 'Default' }"
+							type="{= !${dialogInfo>/frameUrlError/value} && ${dialogInfo>/frameUrl/value} !== '' && (${dialogInfo>/previousFrameUrl/value} !== ${dialogInfo>/frameUrl/value} || ${dialogInfo>/settingsUpdate/value}) ? 'Emphasized' : 'Default' }"
 							/>
 					</HBox>
 					<VBox id="sapUiRtaAddIFrameDialog_PreviewLinkVBox" class="sapUiRtaAddIFrameDialogContainer sapUiTinyMarginTop" renderType="Bare">
@@ -258,7 +259,7 @@
 								adjustLabelSpan="false"
 								singleContainerFullSize="false"
 								ariaLabelledBy="sapUiRtaAddIFrameDialog_WidthLabel"
-								columnsXL="2" columnsL="2" columnsM="2" columnsS="2"
+								columnsXL="2" columnsL="2" columnsM="2"
 								labelSpanXL="2" labelSpanL="2" labelSpanM="2" labelSpanS="4"
 								emptySpanXL="2" emptySpanL="2" emptySpanM="2" emptySpanS="0"
 						>
@@ -301,7 +302,7 @@
 							adjustLabelSpan="false"
 							singleContainerFullSize="false"
 							ariaLabelledBy="sapUiRtaAddIFrameDialog_HeightLabel"
-							columnsXL="2" columnsL="2" columnsM="2" columnsS="2"
+							columnsXL="2" columnsL="2" columnsM="2"
 							labelSpanXL="2" labelSpanL="2" labelSpanM="2" labelSpanS="4"
 							emptySpanXL="2" emptySpanL="2" emptySpanM="2" emptySpanS="0"
 						>
@@ -374,95 +375,15 @@
 										href="https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#sandbox"/>
 								</link>
 							</MessageStrip>
-							<form:Form editable="true">
-								<form:layout>
-									<form:ResponsiveGridLayout
-										id="sapUiRtaAddIFrameDialog_SandboxPropertiesForm"
-										adjustLabelSpan="false" singleContainerFullSize="false"
-										labelSpanXL="6" labelSpanL="6" labelSpanM="6" labelSpanS="12"
-										columnsXL="2" columnsL="2" columnsM="2"/>
-									</form:layout>
-										<form:FormContainer>
-											<form:FormElement label="allow-forms">
-												<Switch
-													change="onSwitchChange"
-													id="sapUiRtaAddIFrameDialog_allowFormsSwitch"
-													customTextOn=" "
-													customTextOff=" "
-													state="{dialogInfo>/advancedSettings/value/allowForms}" />
-											</form:FormElement>
-											<form:FormElement label="allow-scripts">
-												<Switch
-													change="onSwitchChange"
-													id="sapUiRtaAddIFrameDialog_allowScriptsSwitch"
-													customTextOn=" "
-													customTextOff=" "
-													state="{dialogInfo>/advancedSettings/value/allowScripts}" />
-											</form:FormElement>
-											<form:FormElement label="allow-same-origin">
-												<Switch
-													change="onSwitchChange"
-													id="sapUiRtaAddIFrameDialog_allowSameOriginSwitch"
-													customTextOn=" "
-													customTextOff=" "
-													state="{dialogInfo>/advancedSettings/value/allowSameOrigin}" />
-											</form:FormElement>
-											<form:FormElement label="allow-popups">
-												<Switch
-													change="onSwitchChange"
-													id="sapUiRtaAddIFrameDialog_allowPopupsSwitch"
-													customTextOn=" "
-													customTextOff=" "
-													state="{dialogInfo>/advancedSettings/value/allowPopups}" />
-											</form:FormElement>
-											<form:FormElement label="allow-modals">
-												<Switch
-													change="onSwitchChange"
-													id="sapUiRtaAddIFrameDialog_allowModalsSwitch"
-													customTextOn=" "
-													customTextOff=" "
-													state="{dialogInfo>/advancedSettings/value/allowModals}" />
-											</form:FormElement>
-										</form:FormContainer>
-										<form:FormContainer>
-											<form:FormElement label="allow-top-navigation">
-												<Switch
-													change="onSwitchChange"
-													id="sapUiRtaAddIFrameDialog_allowTopNavigationSwitch"
-													customTextOn=" "
-													customTextOff=" "
-													state="{dialogInfo>/advancedSettings/value/allowTopNavigation}" />
-											</form:FormElement>
-											<form:FormElement label="allow-downloads">
-												<Switch
-													change="onSwitchChange"
-													id="sapUiRtaAddIFrameDialog_allowDownloadsSwitch"
-													customTextOn=" "
-													customTextOff=" "
-													state="{dialogInfo>/advancedSettings/value/allowDownloads}" />
-											</form:FormElement>
-											<form:FormElement>
-												<Label
-													id="sapUiRtaAddIFrameDialog_AddAdditionalParametersLabel"
-													class="sapUiSmallMarginTop"
-													text="{i18n>IFRAME_ADDIFRAME_ADD_ADDITIONAL_SANDBOX_PARAMETERS_LABEL}"
-													labelFor="sapUiRtaAddIFrameDialog_AddAdditionalParametersInput" />
-											</form:FormElement>
-											<form:FormElement>
-												<MultiInput
-													id="sapUiRtaAddIFrameDialog_AddAdditionalParametersInput"
-													placeholder="{i18n>IFRAME_ADDIFRAME_ADD_ADDITIONAL_SANDBOX_PARAMETERS_PLACEHOLDER}"
-													showValueHelp="false"
-													tokenUpdate="onTokenUpdate"
-													tokens="{dialogInfo>/advancedSettings/value/additionalSandboxParameters}"
-													ariaLabelledBy="sapUiRtaAddIFrameDialog_AddAdditionalParametersLabel">
-													<tokens>
-														<Token text="{dialogInfo>}" key="{dialogInfo>}"/>
-													</tokens>
-												</MultiInput>
-									</form:FormElement>
-								</form:FormContainer>
-							</form:Form>
+							<layout:Grid
+								id="sapUiRtaAddIFrameDialog_SandboxPropertiesGrid"
+								defaultSpan="XL6 L6 M6 S12"
+								hSpacing="1"
+								vSpacing="1"
+								content="{
+									path: 'dialogInfo>/advancedSettingsConfig',
+									factory: '.createAdvancedSettingsControl'
+								}"/>
 						</content>
 					</Panel>
 				</layout:Grid>
@@ -480,7 +401,7 @@
 				type="Emphasized"
 				text="{i18n>IFRAME_ADDIFRAME_DIALOG_BUTTON_SAVE}"
 				press="onSavePress"
-				enabled="{= !!${dialogInfo>/areAllFieldsValid}}"
+				enabled="{= !!${dialogInfo>/saveEnabled} }"
 			/>
 		</beginButton>
 		<endButton>

package/src/sap/ui/rta/plugin/iframe/AddIFrameDialog.js

@@ -31,8 +31,19 @@ sap.ui.define([
 	"use strict";
 
 	// shortcut for sap.ui.core.ValueState
-	var { ValueState } = coreLibrary;
-	var _oTextResources = Lib.getResourceBundleFor("sap.ui.rta");
+	const { ValueState } = coreLibrary;
+	const _oTextResources = Lib.getResourceBundleFor("sap.ui.rta");
+
+	const _aAdvancedSettings = [
+		{ key: "allowForms", label: "allow-forms" },
+		{ key: "allowScripts", label: "allow-scripts" },
+		{ key: "allowSameOrigin", label: "allow-same-origin" },
+		{ key: "allowPopups", label: "allow-popups" },
+		{ key: "allowModals", label: "allow-modals" },
+		{ key: "allowTopNavigation", label: "allow-top-navigation" },
+		{ key: "allowDownloads", label: "allow-downloads" },
+		{ key: "additionalSandboxParameters", isMultiInput: true }
+	];
 
 	function createJSONModel(bSetUpdateTitle, bAsContainer, sFrameWidthValue, sFrameHeightValue, oAdvancedSettings) {
 		var sSelectAdditionalTextPercent = bAsContainer
@@ -76,16 +87,23 @@ sap.ui.define([
 			frameHeightUnit: {
 				value: "vh"
 			},
+			// The URL entered by the user (without resolving bindings)
 			frameUrl: {
 				value: "",
 				valueState: ValueState.None
 			},
+			// URL value when the dialog was opened (without resolving bindings), to detect changes for update
+			initialFrameUrl: {
+				value: ""
+			},
+			// URL value when the last preview was generated (with resolved bindings), to control the preview button state
 			previousFrameUrl: {
 				value: ""
 			},
 			frameUrlError: {
 				value: undefined
 			},
+			// URL used for the iframe preview (with resolved bindings)
 			previewUrl: { value: "" },
 			parameters: { value: [] },
 			unitsOfWidthMeasure: [{
@@ -117,6 +135,7 @@ sap.ui.define([
 					...oAdvancedSettings
 				}
 			},
+			advancedSettingsConfig: _aAdvancedSettings,
 			settingsUpdate: {
 				value: false
 			},
@@ -132,7 +151,7 @@ sap.ui.define([
 	 * @class Context - Dialog for IFrame settings in Runtime Authoring
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.144.0
+	 * @version 1.146.0
 	 * @constructor
 	 * @private
 	 * @since 1.78