@openui5/sap.ui.rta 1.139.0 → 1.141.0

package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsAnalyzer.js

@@ -9,6 +9,7 @@ sap.ui.define([
 	"sap/base/util/ObjectPath",
 	"sap/ui/core/util/reflection/JsControlTreeModifier",
 	"sap/ui/dt/ElementUtil",
+	"sap/ui/dt/OverlayRegistry",
 	"sap/ui/fl/apply/api/DelegateMediatorAPI",
 	"sap/ui/rta/util/BindingsExtractor"
 ], function(
@@ -16,6 +17,7 @@ sap.ui.define([
 	ObjectPath,
 	JsControlTreeModifier,
 	ElementUtil,
+	OverlayRegistry,
 	DelegateMediatorAPI,
 	BindingsExtractor
 ) {
@@ -136,13 +138,24 @@ sap.ui.define([
 		};
 	}
 
+	function getLabel(oElement, mAction) {
+		const oOverlay = OverlayRegistry.getOverlay(oElement);
+		// Try different label sources in the following order:
+		// 1) Action.getLabel
+		// 2) DTMetadata.getLabel
+		// 3) The fallbacks in ElementUtil.getLabelForElement
+		return (mAction.getLabel || !oOverlay)
+			? ElementUtil.getLabelForElement(oElement, mAction.getLabel)
+			: oOverlay.getDesignTimeMetadata().getLabel(oElement);
+	}
+
 	function elementToAdditionalElementInfo(mData) {
 		const oElement = mData.element;
-		const mAction = mData.action;
+		const sLabel = getLabel(oElement, mData.action);
 		return {
 			selected: false,
-			label: oElement.__label || ElementUtil.getLabelForElement(oElement, mAction.getLabel),
-			tooltip: oElement.__tooltip || ElementUtil.getLabelForElement(oElement, mAction.getLabel) || oElement.__bindingPath,
+			label: oElement.__label || sLabel,
+			tooltip: oElement.__tooltip || sLabel || oElement.__bindingPath,
 			parentPropertyName: oElement.__parentPropertyName ? oElement.__parentPropertyName : "",
 			duplicateName: oElement.__duplicateName ? oElement.__duplicateName : false,
 			originalLabel: oElement.__renamedLabel && oElement.__label !== oElement.__originalLabel ? oElement.__originalLabel : "",
@@ -431,8 +444,7 @@ sap.ui.define([
 			aInvisibleElements.forEach(function(mInvisibleElement) {
 				const oInvisibleElement = mInvisibleElement.element;
 				const mRevealAction = mInvisibleElement.action;
-
-				oInvisibleElement.__label = ElementUtil.getLabelForElement(oInvisibleElement, mRevealAction.getLabel);
+				oInvisibleElement.__label = getLabel(oInvisibleElement, mRevealAction);
 
 				const bIncludeElement = enhanceByMetadata(
 					oElement, sAggregationName, mInvisibleElement, mActions, aRepresentedProperties, aProperties

package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsPlugin.js

@@ -119,7 +119,7 @@ sap.ui.define([
 	 * @class The plugin allows to add additional elements that exist either hidden in the UI or in the OData service
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @constructor
 	 * @private
 	 * @since 1.44

package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsUtils.js

@@ -17,7 +17,7 @@ sap.ui.define([
 	 * Helper object containing methods for the AdditionalElements plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 * @since 1.94
 	 */

package/src/sap/ui/rta/plugin/additionalElements/CommandBuilder.js

@@ -25,7 +25,7 @@ sap.ui.define([
 	 * Helper object to build the RTA commands resulting from the AdditionalElements Plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 * @since 1.94
 	 */

package/src/sap/ui/rta/plugin/annotations/AnnotationChangeDialog.js

@@ -29,7 +29,7 @@ sap.ui.define([
 	 * @class Constructor for a new sap.ui.rta.plugin.annotations.AnnotationChangeDialog.
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @constructor
 	 * @since 1.132
 	 * @private

package/src/sap/ui/rta/plugin/annotations/AnnotationChangeDialogController.js

@@ -35,7 +35,7 @@ sap.ui.define([
 	 * @class Controller for the AnnotationChangeDialog.
 	 * @extends sap.ui.core.mvc.Controller
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @constructor
 	 * @since 1.132
 	 * @private

package/src/sap/ui/rta/plugin/annotations/AnnotationPlugin.js

@@ -105,7 +105,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @constructor
 	 * @private
 	 * @since 1.132

package/src/sap/ui/rta/plugin/iframe/AddIFrame.js

@@ -119,7 +119,7 @@ sap.ui.define([
 	 * @class The AddIFrame allows trigger AddIFrame operations on the overlay.
 	 * @extends sap.ui.rta.plugin.BaseCreate
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @constructor
 	 * @private
 	 * @since 1.75

package/src/sap/ui/rta/plugin/iframe/AddIFrameDialog.js

@@ -123,7 +123,7 @@ sap.ui.define([
 	 * @class Context - Dialog for IFrame settings in Runtime Authoring
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @constructor
 	 * @private
 	 * @since 1.78

package/src/sap/ui/rta/plugin/rename/Rename.js

@@ -28,7 +28,7 @@ sap.ui.define([
 	 * @extends sap.ui.rta.plugin.Plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/plugin/rename/RenameDialog.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @class Constructor for a new sap.ui.rta.plugin.rename.RenameDialog.
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @constructor
 	 * @since 1.136
 	 * @private
@@ -64,12 +64,7 @@ sap.ui.define([
 		}
 		const oOverlay = mPropertyBag.overlay;
 		const oElement = oOverlay.getElement();
-		const oDesignTimeMetadata = oOverlay.getDesignTimeMetadata();
-		const oEditableControlDomRef = oDesignTimeMetadata.getAssociatedDomRef(oElement, mPropertyBag.domRef);
-		if (typeof mPropertyBag.action.getTextMutators === "function") {
-			return mPropertyBag.action.getTextMutators(oElement).getText();
-		}
-		return oEditableControlDomRef.textContent;
+		return oOverlay.getDesignTimeMetadata().getLabel(oElement);
 	}
 
 	/**

package/src/sap/ui/rta/service/Action.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 * @name sap.ui.rta.service.Action
 	 * @author SAP SE
 	 * @since 1.58
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 * @ui5-restricted
 	 *

package/src/sap/ui/rta/service/ControllerExtension.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @name sap.ui.rta.service.ControllerExtension
 	 * @author SAP SE
 	 * @since 1.58
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 * @ui5-restricted
 	*/

package/src/sap/ui/rta/service/Outline.js

@@ -43,7 +43,7 @@ sap.ui.define([
 	 * @name sap.ui.rta.service.Outline
 	 * @author SAP SE
 	 * @since 1.56
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 * @ui5-restricted
 	 */

package/src/sap/ui/rta/service/Property.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @name sap.ui.rta.service.Property
 	 * @author SAP SE
 	 * @since 1.58
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 * @ui5-restricted
 	*/

package/src/sap/ui/rta/service/Selection.js

@@ -14,7 +14,7 @@ sap.ui.define(function() {
 	 * @name sap.ui.rta.service.Selection
 	 * @author SAP SE
 	 * @since 1.58
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 * @ui5-restricted
 	*/

package/src/sap/ui/rta/service/SupportTools.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @name sap.ui.rta.service.SupportTools
 	 * @author SAP SE
 	 * @since 1.106
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 * @ui5-restricted
 	 */

package/src/sap/ui/rta/toolbar/Adaptation.js

@@ -67,7 +67,7 @@ sap.ui.define([
 	 * @extends sap.ui.rta.toolbar.Base
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/Base.js

@@ -7,21 +7,21 @@
 sap.ui.define([
 	"sap/m/HBox",
 	"sap/ui/core/Element",
-	"sap/ui/core/StaticArea",
 	"sap/ui/core/Lib",
+	"sap/ui/core/StaticArea",
 	"sap/ui/dt/util/ZIndexManager",
 	"sap/ui/model/resource/ResourceModel",
-	"sap/ui/rta/util/Animation",
-	"./BaseRenderer"
+	"sap/ui/rta/toolbar/BaseRenderer",
+	"sap/ui/rta/util/Animation"
 ], function(
 	HBox,
 	Element,
-	StaticArea,
 	Lib,
+	StaticArea,
 	ZIndexManager,
 	ResourceModel,
-	Animation,
-	BaseRenderer
+	BaseRenderer,
+	Animation
 ) {
 	"use strict";
 
@@ -33,7 +33,7 @@ sap.ui.define([
 	 * @extends sap.m.HBox
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/Fiori.js

@@ -5,18 +5,18 @@
  */
 
 sap.ui.define([
-	"sap/m/Image",
-	"./Adaptation",
-	"../Utils",
 	"sap/base/Log",
-	"sap/ui/rta/toolbar/AdaptationRenderer"
+	"sap/m/Image",
+	"sap/ui/rta/toolbar/Adaptation",
+	"sap/ui/rta/toolbar/AdaptationRenderer",
+	"sap/ui/rta/Utils"
 ],
 function(
+	Log,
 	Image,
 	Adaptation,
-	Utils,
-	Log,
-	AdaptationRenderer
+	AdaptationRenderer,
+	Utils
 ) {
 	"use strict";
 
@@ -34,7 +34,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/FioriLike.js

@@ -5,7 +5,7 @@
  */
 
 sap.ui.define([
-	"./Adaptation",
+	"sap/ui/rta/toolbar/Adaptation",
 	"sap/ui/rta/toolbar/AdaptationRenderer"
 ],
 function(
@@ -22,7 +22,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/OverflowToolbarButton.js

@@ -23,7 +23,7 @@ sap.ui.define([
 	 * @extends sap.m.OverflowToolbarButton
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/Standalone.js

@@ -5,8 +5,8 @@
  */
 
 sap.ui.define([
-	"./Adaptation",
-	"./AdaptationRenderer"
+	"sap/ui/rta/toolbar/Adaptation",
+	"sap/ui/rta/toolbar/AdaptationRenderer"
 ],
 function(
 	Adaptation,
@@ -22,7 +22,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/contextBased/SaveAsAdaptation.js

@@ -45,7 +45,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/translation/Translation.js

@@ -53,7 +53,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/versioning/Versioning.js

@@ -38,7 +38,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/util/PluginManager.js

@@ -64,7 +64,7 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PluginManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @constructor
 	 * @private
 	 * @since 1.86

package/src/sap/ui/rta/util/PopupManager.js

@@ -75,7 +75,7 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PopupManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @constructor
 	 * @private
 	 * @since 1.48
@@ -491,8 +491,8 @@ sap.ui.define([
 					&& this.getRta()._oDesignTime) {
 					this.getRta()._oDesignTime.removeRootElement(oPopupElement);
 				}
-				// remove the Modal state from the map
-				this._oModalState.delete(oPopupElement.oPopup);
+				// remove the Modal state from the map (can be undefined if RTA has just been stopped)
+				this._oModalState?.delete(oPopupElement.oPopup);
 				// PopupManager internal method
 				this.fireClose(oPopupElement);
 			}

package/src/sap/ui/rta/util/ReloadManager.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @namespace sap.ui.rta.util.ReloadManager
 	 * @alias sap.ui.rta.util.ReloadManager
 	 * @since 1.104
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 * @ui5-restricted
 	 */

package/src/sap/ui/rta/util/ServiceEventBus.js

@@ -18,7 +18,7 @@ sap.ui.define([
 	 *
 	 * @extends sap.ui.core.EventBus
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 * @since 1.56.0
 	 * @alias sap.ui.rta.util.ServiceEventBus

package/src/sap/ui/rta/util/ServiceManager.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 *
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @constructor
 	 * @private
 	 * @since 1.121

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicator.js

@@ -11,14 +11,14 @@ sap.ui.define([
 	"sap/ui/core/Fragment",
 	"sap/ui/core/Lib",
 	"sap/ui/core/StaticArea",
+	"sap/ui/dt/OverlayRegistry",
 	"sap/ui/events/KeyCodes",
-	"sap/ui/fl/util/resolveBinding",
 	"sap/ui/fl/Utils",
 	"sap/ui/model/json/JSONModel",
 	"sap/ui/rta/util/changeVisualization/commands/getCommandVisualization",
 	"sap/ui/rta/util/changeVisualization/ChangeCategories",
 	"sap/ui/rta/util/changeVisualization/ChangeVisualizationUtils",
-	"sap/ui/dt/OverlayRegistry"
+	"sap/ui/rta/util/changeVisualization/resolveBinding"
 ], function(
 	DateFormat,
 	Control,
@@ -26,14 +26,14 @@ sap.ui.define([
 	Fragment,
 	Lib,
 	StaticArea,
+	OverlayRegistry,
 	KeyCodes,
-	resolveBinding,
 	FlUtils,
 	JSONModel,
 	getCommandVisualization,
 	ChangeCategories,
 	ChangeVisualizationUtils,
-	OverlayRegistry
+	resolveBinding
 ) {
 	"use strict";
 
@@ -46,7 +46,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicator
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 */
 	const ChangeIndicator = Control.extend("sap.ui.rta.util.changeVisualization.ChangeIndicator", {
@@ -401,7 +401,7 @@ sap.ui.define([
 	};
 
 	ChangeIndicator.prototype._onKeyDown = function(oEvent) {
-		if (oEvent.keyCode === KeyCodes.ENTER) {
+		if (oEvent.keyCode === KeyCodes.ENTER || oEvent.keyCode === KeyCodes.SPACE) {
 			this._onSelect(oEvent);
 		}
 

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorRegistry.js

@@ -37,7 +37,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry
 	 * @author SAP SE
 	 * @since 1.86.0
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 */
 	const ChangeIndicatorRegistry = ManagedObject.extend("sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry", {

package/src/sap/ui/rta/util/changeVisualization/ChangeVisualization.js

@@ -84,7 +84,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeVisualization
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @private
 	 */
 	const ChangeVisualization = Control.extend("sap.ui.rta.util.changeVisualization.ChangeVisualization", {

package/src/sap/ui/rta/util/changeVisualization/resolveBinding.js

@@ -0,0 +1,79 @@
+/*!
+ * OpenUI5
+ * (c) Copyright 2025 SAP SE or an SAP affiliate company.
+ * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
+ */
+sap.ui.define([
+	"sap/ui/base/BindingInfo",
+	"sap/ui/base/ManagedObject",
+	"sap/ui/fl/Utils"
+], function(
+	BindingInfo,
+	ManagedObject,
+	FlUtils
+) {
+	"use strict";
+
+	// Helper class to resolve bindings
+	var HelperControl = ManagedObject.extend("sap.ui.rta.util.changeVisualization.HelperControl", {
+		metadata: {
+			library: "sap.ui.rta",
+			properties: {
+				resolved: {
+					type: "any"
+				}
+			}
+		}
+	});
+
+	/**
+	 * Resolves bindings synchronously by copying model and binding context information
+	 * from a given reference control.
+	 *
+	 * @param {object|string} vValue - Binding string or binding object
+	 * @param {sap.ui.core.Control} oReferenceControl - Control to copy binding information from
+	 * @returns {any} - Resolved value
+	 *
+	 * @function
+	 * @author SAP SE
+	 * @version 1.141.0
+	 * @alias sap.ui.rta.util.ChangeVisualization.resolveBinding
+	 * @since 1.140
+	 * @private
+	 * @ui5-restricted sap.ui.rta
+	 */
+	return function(vValue, oReferenceControl) {
+		const oView = FlUtils.getViewForControl(oReferenceControl);
+		const oController = oView && oView.getController();
+		if (!FlUtils.isBinding(vValue, oController)) {
+			return undefined;
+		}
+		const oBindingInfo = typeof vValue === "string"
+			? BindingInfo.parse(vValue, oController)
+			: { ...vValue };
+
+		if (!oBindingInfo) {
+			return undefined;
+		}
+
+		const oHelperControl = new HelperControl();
+
+		const aParts = oBindingInfo.parts || [oBindingInfo];
+		aParts.forEach(function(oBindingPart) {
+			const sModelName = oBindingPart.model;
+			if (sModelName) {
+				oHelperControl.setModel(oReferenceControl.getModel(sModelName), sModelName);
+				oHelperControl.setBindingContext(oReferenceControl.getBindingContext(sModelName), sModelName);
+			} else {
+				oHelperControl.setModel(oReferenceControl.getModel());
+				oHelperControl.setBindingContext(oReferenceControl.getBindingContext());
+			}
+		});
+
+		oHelperControl.bindProperty("resolved", oBindingInfo);
+		const vResolvedValue = oHelperControl.getResolved();
+		oHelperControl.destroy();
+
+		return vResolvedValue;
+	};
+});

package/src/sap/ui/rta/util/guidedTour/GuidedTour.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @class Constructor for a new sap.ui.rta.util.guidedTour.GuidedTour
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @constructor
 	 * @since 1.136
 	 * @private

package/src/sap/ui/rta/util/guidedTour/content/GeneralTour.js

@@ -180,7 +180,7 @@ sap.ui.define([
 				title: oTextResources.getText("TIT_TOUR_GENERAL_STEP_CONTEXT_BASED_ADAPTATIONS_TITLE"),
 				description: oTextResources.getText("TXT_TOUR_GENERAL_STEP_CONTEXT_BASED_ADAPTATIONS_DESCRIPTION"),
 				listContent: [],
-				markerSelector: "sapUIRta_toolbar_fragment--sapUiRta_contextBasedAdaptationsButton"
+				markerSelector: "sapUIRta_toolbar_fragment--sapUiRta_contextBasedAdaptationMenu"
 			},
 			{
 				title: oTextResources.getText("TIT_TOUR_GENERAL_STEP_FEEDBACK_BUTTON_TITLE"),

package/src/sap/ui/rta/util/whatsNew/WhatsNew.js

@@ -31,7 +31,7 @@ sap.ui.define([
 	 * @class Constructor for a new sap.ui.rta.util.whatsNew.WhatsNew
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.139.0
+	 * @version 1.141.0
 	 * @constructor
 	 * @since 1.129
 	 * @private