@openui5/sap.ui.rta 1.109.0 → 1.111.0

package/src/sap/ui/rta/toolbar/contextBased/SaveAsAdaptation.js

@@ -0,0 +1,225 @@
+/*!
+ * OpenUI5
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
+ * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
+ */
+
+sap.ui.define([
+	"sap/ui/base/ManagedObject",
+	"sap/base/Log",
+	"sap/base/strings/formatMessage",
+	"sap/ui/core/Fragment",
+	"sap/ui/core/ValueState",
+	"sap/ui/fl/Layer",
+	"sap/ui/fl/write/api/ContextBasedAdaptationsAPI",
+	"sap/ui/fl/write/api/ContextSharingAPI",
+	"sap/ui/rta/Utils",
+	"sap/ui/model/Binding",
+	"sap/ui/model/json/JSONModel"
+], function(
+	ManagedObject,
+	Log,
+	formatMessage,
+	Fragment,
+	ValueState,
+	Layer,
+	ContextBasedAdaptationsAPI,
+	ContextSharingAPI,
+	Utils,
+	Binding,
+	JSONModel
+) {
+	"use strict";
+
+	/**
+	 * Controller for the <code>sap.ui.rta.toolbar.contextBased.SaveAsAdaptation</code> controls.
+	 * Contains implementation of context-based-adaptation functionality.
+	 *
+	 * @class
+	 *
+	 * @author SAP SE
+	 * @version 1.111.0
+	 *
+	 * @constructor
+	 * @private
+	 * @since 1.110
+	 * @alias sap.ui.rta.toolbar.contextBased.SaveAsAdaptation
+	 */
+	var SaveAsAdaptation = ManagedObject.extend("sap.ui.rta.toolbar.contextBased.SaveAsAdaptation", {
+		metadata: {
+			properties: {
+				toolbar: {
+					type: "any" // "sap.ui.rta.toolbar.Base"
+				}
+			}
+		},
+		constructor: function() {
+			ManagedObject.prototype.constructor.apply(this, arguments);
+			this.oTextResources = this.getToolbar().getTextResources();
+		}
+	});
+
+	SaveAsAdaptation.prototype.openAddAdaptationDialog = function(sLayer) {
+		if (!this._oAddAdaptationDialogPromise) {
+			this._oAddAdaptationDialogPromise = Fragment.load({
+				name: "sap.ui.rta.toolbar.contextBased.SaveAsAdaptationDialog",
+				id: this.getToolbar().getId() + "_fragment--sapUiRta_addAdaptationDialog",
+				controller: {
+					onAdaptationTitleChange: onAdaptationTitleChange.bind(this),
+					onSaveAsAdaptation: onSaveAsAdaptation.bind(this),
+					onCancelAdaptationDialog: onCancelAdaptationDialog.bind(this),
+					onPriorityChange: onPriorityChange.bind(this)
+				}
+			}).then(function(oDialog) {
+				this._oAddAdaptationDialog = oDialog;
+				this._oAddAdaptationDialog.attachBeforeClose(clearComponent.bind(this));
+				oDialog.addStyleClass(Utils.getRtaStyleClassName());
+				this.getToolbar().addDependent(this._oAddAdaptationDialog);
+			}.bind(this));
+		} else {
+			this.getToolbar().getControl("addAdaptationDialog--saveAdaptation-title-input").setValue("");
+		}
+		return this._oAddAdaptationDialogPromise.then(function() {
+			return createContextSharingComponent.call(this, sLayer);
+		}.bind(this)).then(function() {
+			var oRtaInformation = this.getToolbar().getRtaInformation();
+			return ContextBasedAdaptationsAPI.load({
+				control: oRtaInformation.rootControl, layer: oRtaInformation.flexSettings.layer
+			});
+		}.bind(this)).catch(function(oError) {
+			Log.error(oError.stack);
+			this.oAdaptationsModel = new JSONModel({ adaptations: [] });
+			return this.oAdaptationsModel;
+		}.bind(this)).then(function(oAdaptationsModel) {
+			this.oAdaptationsModel = oAdaptationsModel;
+			return openDialog.call(this, oAdaptationsModel);
+		}.bind(this));
+	};
+
+	// ------ open dialog -----
+	function openDialog(oAdaptationsModel) {
+		formatPriorityText.call(this, oAdaptationsModel.getData());
+		return this._oAddAdaptationDialog.open();
+	}
+
+	// ------ formatting ------
+	function formatPriorityText(oAdaptationsModelData) {
+		var aItems = [{ key: 0, title: this.oTextResources.getText("TXT_SELECT_FIRST_PRIO") }];
+		var sPriorityTextTemplate = this.oTextResources.getText("TXT_SELECT_PRIO");
+		oAdaptationsModelData.adaptations.forEach(function(oAdaptation, iIndex) {
+			aItems.push({
+				key: (iIndex + 1).toString(),
+				title: formatMessage(sPriorityTextTemplate, [oAdaptation.title, iIndex + 2])
+			});
+		});
+		this.oPrioritySelectionModel = new JSONModel({
+			selected: this.oTextResources.getText("TXT_SELECT_FIRST_PRIO"),
+			priority: aItems
+		});
+		this._oAddAdaptationDialog.setModel(this.oPrioritySelectionModel, "prioritySelectionModel");
+	}
+
+	function onAdaptationTitleChange() {
+		enableSaveAsButton.call(this);
+	}
+
+	function onCancelAdaptationDialog() {
+		this._oAddAdaptationDialog.close();
+	}
+
+	function onSaveAsAdaptation() {
+		var oContextBasedAdaptation = {};
+		oContextBasedAdaptation.title = getAdaptationTitle.call(this);
+		oContextBasedAdaptation.contexts = this._oContextComponentInstance.getSelectedContexts();
+		oContextBasedAdaptation.priority = getAdaptationPriority.call(this);
+		var oRtaInformation = this.getToolbar().getRtaInformation();
+		ContextBasedAdaptationsAPI.create({
+			control: oRtaInformation.rootControl,
+			layer: oRtaInformation.flexSettings.layer,
+			contextBasedAdaptation: oContextBasedAdaptation
+		}).catch(function(oError) {
+			Log.error(oError.stack);
+			var sMessage = "MSG_LREP_TRANSFER_ERROR";
+			var oOptions = { titleKey: "SAC_DIALOG_HEADER" };
+			oOptions.details = oError.userMessage;
+			Utils.showMessageBox("error", sMessage, oOptions);
+		});
+		this._oAddAdaptationDialog.close();
+	}
+
+	function onPriorityChange(oEvent) {
+		this.sPriority = oEvent.getParameters().selectedItem.getProperty("key");
+	}
+
+
+	function checkAdaptationsNameConstraints() {
+		// check for empty adaptations title
+		if (this._oAddAdaptationDialog && this._oAddAdaptationDialog.isOpen()) {
+			var oInputField = this.getToolbar().getControl("addAdaptationDialog--saveAdaptation-title-input");
+			var iAdaptationTitleLength = oInputField.getValue().trim().length;
+			var iMaxTitleLength = 100;
+			if (iAdaptationTitleLength === 0) {
+				oInputField.setValueState(ValueState.Error);
+				oInputField.setValueStateText(this.oTextResources.getText("TXT_CTX_ERROR_EMPTY_TITLE"));
+			} else if (iAdaptationTitleLength > iMaxTitleLength) {
+				oInputField.setValueState(ValueState.Error);
+				oInputField.setValueStateText(this.oTextResources.getText("TXT_CTX_ERROR_MAX_LEN", [
+					iMaxTitleLength
+				]));
+			} else if (iAdaptationTitleLength > 0) {
+				// check for duplicates
+				var iIndexOfDuplicate = this.oAdaptationsModel.getProperty("/adaptations").findIndex(function(adaptation) {
+					if (adaptation.title.trim().toLowerCase() === oInputField.getValue().trim().toLowerCase()) {
+						return true;
+					}
+					return false;
+				});
+				if (iIndexOfDuplicate > -1) {
+					oInputField.setValueState(ValueState.Error);
+					oInputField.setValueStateText(this.oTextResources.getText("TXT_CTX_ERROR_DUPLICATE_TITLE"));
+				} else {
+					oInputField.setValueState(ValueState.None);
+					oInputField.setValueStateText(null);
+				}
+			}
+		}
+	}
+
+	function createContextSharingComponent(sLayer) {
+		var mPropertyBag = { layer: sLayer || Layer.CUSTOMER };
+		return ContextSharingAPI.createComponent(mPropertyBag).then(function(oContextSharingComponent) {
+			this._oContextComponent = oContextSharingComponent;
+			this._oContextComponentInstance = oContextSharingComponent.getComponentInstance();
+			this._oContextComponentInstance.resetSelectedContexts();
+			this._oAddAdaptationDialog.addContent(this._oContextComponent);
+			var oSelectedContextsModel = this._oContextComponentInstance.getSelectedContextsModel();
+			this.oSelectedContextsBinding = new Binding(oSelectedContextsModel, "/", oSelectedContextsModel.getContext("/"));
+			this.oSelectedContextsBinding.attachChange(enableSaveAsButton.bind(this));
+			this._oContextComponentInstance.showMessageStrip(false);
+		}.bind(this));
+	}
+
+	function getAdaptationTitle() {
+		var oInputField = this.getToolbar().getControl("addAdaptationDialog--saveAdaptation-title-input");
+		return oInputField ? oInputField.getValue().trim() : "";
+	}
+
+	function getAdaptationPriority() {
+		return Number(this.sPriority) || 0;
+	}
+
+	function enableSaveAsButton() {
+		checkAdaptationsNameConstraints.call(this);
+		var oInputField = this.getToolbar().getControl("addAdaptationDialog--saveAdaptation-title-input");
+		var bEnable = oInputField.getValueState() === ValueState.None && this._oContextComponentInstance.getSelectedContexts().role.length > 0;
+		this.getToolbar().getControl("addAdaptationDialog--saveAdaptation-saveButton").setEnabled(bEnable);
+	}
+
+	function clearComponent() {
+		if (this._oContextComponentInstance) {
+			this._oContextComponentInstance.showMessageStrip(true);
+			this._oContextComponentInstance.resetSelectedContexts();
+		}
+	}
+	return SaveAsAdaptation;
+});

package/src/sap/ui/rta/toolbar/contextBased/{SaveAsContextBasedAdaptationDialog.fragment.xml → SaveAsAdaptationDialog.fragment.xml}

@@ -6,14 +6,14 @@
 		resizable="true"
 		draggable="true"
 		title="{i18n>SAC_DIALOG_HEADER}">
-		<Panel id="saveContextBasedAdaptation-information-panel">
+		<Panel id="saveAdaptation-information-panel">
 			<Toolbar id="toolbar">
 				<Label id="label"
 					text="Information"
 					design="Bold">
 				</Label>
 			</Toolbar>
-			<form:Form id="saveContextBasedAdaptation-form"
+			<form:Form id="saveAdaptation-form"
 				editable="true">
 				<form:layout>
 					<form:ResponsiveGridLayout labelSpanXL="3"
@@ -34,13 +34,13 @@
 					<form:formElements>
 						<form:FormElement >
 							<form:label>
-								<Label id="saveContextBasedAdaptation-title-label"
+								<Label id="saveAdaptation-title-label"
 									text="{i18n>APP_DIALOG_TITLE_TEXT}"
 									textAlign="Left"
 									required="true">
 								</Label>
 							</form:label>
-							<Input id="saveContextBasedAdaptation-title-input"
+							<Input id="saveAdaptation-title-input"
 								value="{/title}"
 								valueLiveUpdate="true"
 								liveChange=".onAdaptationTitleChange"
@@ -49,31 +49,35 @@
 						</form:FormElement>
 						<form:FormElement >
 							<form:label>
-								<Label id="saveContextBasedAdaptation-rank-label"
+								<Label id="saveAdaptation-rank-label"
 									text="{i18n>CLM_HEADER_PRIORITY}"
 									textAlign="Left"
 									required="true">
 								</Label>
 							</form:label>
-							<Select id="saveContextBasedAdaptation-rank-select"
-								selectedKey="{/selected}">
-							</Select>
+								<Select
+									id="saveAdaptation-rank-select"
+									forceSelection="true"
+									selectedKey="{prioritySelectionModel>/selected}"
+									items="{prioritySelectionModel>/priority}"
+									change=".onPriorityChange">
+									<core:Item key="{prioritySelectionModel>key}" text="{prioritySelectionModel>title}" />
+								</Select>
 						</form:FormElement>
 					</form:formElements>
 				</form:FormContainer>
 			</form:Form>
 		</Panel>
 		<beginButton>
-			<Button id="saveContextBasedAdaptation-saveButton"
+			<Button id="saveAdaptation-saveButton"
 				type="Emphasized"
-				text="{i18n>APP_VARIANT_DIALOG_SAVE}"
-				press=".onSaveAsContextBasedAdaptation"/>
+				text="{i18n>APP_CTX_DIALOG_SAVE}"
+				press=".onSaveAsAdaptation"/>
 		</beginButton>
 		<endButton>
-			<Button id="saveContextBasedAdaptation-cancelButton"
-				type="Emphasized"
-				text="{i18n>SAVE_AS_APP_VARIANT_DIALOG_CANCEL}"
-				press=".onCancelContextBasedAdaptationDialog"/>
+			<Button id="saveAdaptation-cancelButton"
+				text="{i18n>APP_CTX_DIALOG_CANCEL}"
+				press=".onCancelAdaptationDialog"/>
 		</endButton>
 	</Dialog>
 </core:FragmentDefinition>

package/src/sap/ui/rta/toolbar/translation/Translation.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
@@ -49,7 +49,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.109.0
+	 * @version 1.111.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/versioning/Versioning.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
@@ -36,7 +36,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.109.0
+	 * @version 1.111.0
 	 *
 	 * @constructor
 	 * @private
@@ -131,7 +131,7 @@ sap.ui.define([
 		return new GroupHeaderListItem({
 			title: oGroup.key ? this.oTextResources.getText("TIT_VERSION_HISTORY_PUBLISHED") : this.oTextResources.getText("TIT_VERSION_HISTORY_UNPUBLISHED"),
 			upperCase: false,
-			visible: this.getToolbar().getModel("controls").getProperty("/publishVisible")
+			visible: this.getToolbar().getModel("versions").getProperty("/publishVersionVisible")
 		}).addStyleClass("sapUiRtaVersionHistoryGrouping").addStyleClass("sapUiRtaVersionHistory");
 	}
 
@@ -214,7 +214,7 @@ sap.ui.define([
 		return this._oVersionHistoryDialogPromise.then(function(oVersionsDialog) {
 			if (!oVersionsDialog.isOpen()) {
 				oVersionsDialog.openBy(oVersionButton);
-				if (this.getToolbar().getModel("controls").getProperty("/publishVisible")) {
+				if (this.getToolbar().getModel("versions").getProperty("/publishVersionVisible")) {
 					var oList = this.getToolbar().getControl("versionHistoryDialog--versionList");
 					var oSorter = new Sorter({
 						path: "isPublished",

package/src/sap/ui/rta/util/Animation.js

@@ -1,33 +1,29 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
 sap.ui.define([
-	"sap/ui/thirdparty/jquery"
 ],
-function(jQuery) {
+function() {
 	"use strict";
 
 	var module = {};
 
 	/**
 	 * CSS Transition helper
-	 * @param {jQuery} $element - jQuery element(s)
+	 * @param {HTMLElement} oElement - Element
 	 * @param {Function} fnCallback - The function should start animation process (e.g. by adding class to the element)
 	 * @return {Promise} Returns a Promise performing the animation
 	 */
-	module.waitTransition = function ($element, fnCallback) {
-		if (!($element instanceof jQuery)) {
-			throw new Error('$element should be wrapped into jQuery object');
-		}
+	module.waitTransition = function (oElement, fnCallback) {
 		if (typeof fnCallback !== "function") {
 			throw new Error('fnCallback should be a function');
 		}
 
 		return new Promise(function (fnResolve) {
-			$element.one('transitionend', fnResolve);
+			oElement.addEventListener('transitionend', fnResolve, {once: true});
 
 			// perform animation in the next animation frame, normally 16-17ms later.
 			var iTimestampInitial;

package/src/sap/ui/rta/util/BindingsExtractor.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 

package/src/sap/ui/rta/util/PluginManager.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 sap.ui.define([
@@ -68,7 +68,7 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PluginManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.109.0
+	 * @version 1.111.0
 	 * @constructor
 	 * @private
 	 * @since 1.86

package/src/sap/ui/rta/util/PopupManager.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
@@ -42,7 +42,7 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PopupManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.109.0
+	 * @version 1.111.0
 	 * @constructor
 	 * @private
 	 * @since 1.48

package/src/sap/ui/rta/util/ReloadManager.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @namespace sap.ui.rta.util.ReloadManager
 	 * @alias sap.ui.rta.util.ReloadManager
 	 * @since 1.104
-	 * @version 1.109.0
+	 * @version 1.111.0
 	 * @private
 	 * @ui5-restricted
 	 */

package/src/sap/ui/rta/util/ServiceEventBus.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
@@ -19,7 +19,7 @@ function(
 	 *
 	 * @extends sap.ui.core.EventBus
 	 * @author SAP SE
-	 * @version 1.109.0
+	 * @version 1.111.0
 	 * @private
 	 * @since 1.56.0
 	 * @alias sap.ui.rta.util.ServiceEventBus

package/src/sap/ui/rta/util/StylesLoader.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 

package/src/sap/ui/rta/util/UrlParser.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 

package/src/sap/ui/rta/util/adaptationStarter.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 sap.ui.define([

package/src/sap/ui/rta/util/changeVisualization/ChangeCategories.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicator.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
@@ -40,7 +40,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicator
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.109.0
+	 * @version 1.111.0
 	 * @private
 	 */
 	var ChangeIndicator = Control.extend("sap.ui.rta.util.changeVisualization.ChangeIndicator", {
@@ -129,11 +129,9 @@ sap.ui.define([
 		constructor: function() {
 			this._oDetailModel = new JSONModel();
 			this._oDetailModel.setDefaultBindingMode("OneWay");
-
-			Control.prototype.constructor.apply(this, arguments);
-
 			this._fnHoverTrue = this._toggleHoverStyleClasses.bind(this, true);
 			this._fnHoverFalse = this._toggleHoverStyleClasses.bind(this, false);
+			Control.prototype.constructor.apply(this, arguments);
 			// is needed to prevent that multiple events listeners are attached
 			// to the same overlay because setVisible is called multiple times
 			this._bEventAttachedToElement = false;
@@ -300,7 +298,7 @@ sap.ui.define([
 	};
 
 	ChangeIndicator.prototype.onAfterRendering = function() {
-		var oOverlay = Core.getElementById(this.getOverlayId());
+		var oOverlay = Core.byId(this.getOverlayId());
 		if (oOverlay) {
 			// Attach to the overlay
 			oOverlay.getDomRef().appendChild(this.getDomRef());

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorCategorySelection.fragment.xml

@@ -26,7 +26,7 @@
 			text="{visualizationModel>/popupInfoMessage}"
 			type="Information"
 			showIcon="true"
-			visible="{= ${visualizationModel>/hiddenChanges}.length > 0 }">
+			visible="{= ${visualizationModel>/sortedChanges/relevantHiddenChanges}.length > 0 }">
 			<link>
 				<Link text="{i18n>BUT_CHANGEVISUALIZATION_LEARNMORE}"
 					target="_blank"

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorRegistry.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
@@ -39,7 +39,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry
 	 * @author SAP SE
 	 * @since 1.86.0
-	 * @version 1.109.0
+	 * @version 1.111.0
 	 * @private
 	 */
 	var ChangeIndicatorRegistry = ManagedObject.extend("sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry", {
@@ -145,6 +145,18 @@ sap.ui.define([
 		return oChangeIndicators;
 	};
 
+	ChangeIndicatorRegistry.prototype.getRelevantChangesWithSelector = function () {
+		var oSelectors = this.getSelectorsWithRegisteredChanges();
+		var aRelevantChanges = [];
+		Object.keys(oSelectors).forEach(function(sSelectorId) {
+			var aRelevantChangesForSelector = oSelectors[sSelectorId].filter(function (oChange) {
+				return !oChange.dependent;
+			});
+			aRelevantChanges = aRelevantChanges.concat(aRelevantChangesForSelector);
+		});
+		return aRelevantChanges;
+	};
+
 	/**
 	 * Returns the registered change indicator for the given element ID.
 	 *
@@ -195,7 +207,7 @@ sap.ui.define([
 			}
 
 			if (oChange.getState() === "NEW") {
-				aChangeStates = [ChangeStates.DIRTY, ChangeStates.DRAFT];
+				aChangeStates = ChangeStates.getDraftAndDirtyStates();
 			} else if (aDraftChangesList && aDraftChangesList.includes(oChange.getId())) {
 				aChangeStates = [ChangeStates.DRAFT];
 			} else {
@@ -311,5 +323,17 @@ sap.ui.define([
 		}.bind(this));
 	};
 
+	/**
+	 * Removes changes without any displayElementIds from the registry so the change can be re-registered and
+	 * the visualizationInfo is updated => if an element is inside a dialog which hasnt been opened yet
+	 */
+	ChangeIndicatorRegistry.prototype.removeRegisteredChangesWithoutVizInfo = function () {
+		this.getAllRegisteredChanges().forEach(function(oChange) {
+			if (oChange.visualizationInfo && oChange.visualizationInfo.displayElementIds.length === 0) {
+				this.removeRegisteredChange(oChange.change.getId());
+			}
+		}.bind(this));
+	};
+
 	return ChangeIndicatorRegistry;
 });

package/src/sap/ui/rta/util/changeVisualization/ChangeStates.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
@@ -20,7 +20,7 @@ sap.ui.define([
 	 *
 	 * @returns {array} Array of change states.
 	 */
-	ChangeStates.getDraftState = function() {
+	ChangeStates.getDraftAndDirtyStates = function() {
 		return [this.DRAFT, this.DIRTY];
 	};