@openparachute/agent 0.1.2 → 0.2.2

package/src/web/routes/channels.ts

@@ -1,311 +0,0 @@
-/**
- * /api/channels — channel-wire CRUD for the /channels page.
- *
- * The wire-shape <-> DB-shape translator now lives in
- * `src/channels/api-translator.ts` (paraclaw#123) and is shared with the
- * MCP `*-channel-wire` tools. See that module's docblock for the enum
- * translation contract and the paraclaw#94/#122 motivation.
- *
- * This route file owns only the HTTP transport: routing, json/error
- * helpers, the mg/:id messaging-group detail block, and the per-MGA join
- * query. Validation + Db <-> Api translation come from the shared module.
- *
- * DELETE is a straight pass-through to deleteMessagingGroupAgent — the
- * agent_destinations row created at wire time is left in place; deleting
- * destinations is a separate concern.
- */
-import http from 'node:http';
-
-import {
-  ALL_MESSAGES_PATTERN_SENTINEL,
-  type ApiEngageMode,
-  type ApiIgnoredMessagePolicy,
-  type ApiSenderScope,
-  apiToDbPatch,
-  type ChannelWireView,
-  dbToApiEngage,
-  dbToApiIgnoredPolicy,
-  dbToApiSenderScope,
-  rowToView,
-  validatePatchInput,
-  type WireJoinRow,
-} from '../../channels/api-translator.js';
-import { getAgentGroup } from '../../db/agent-groups.js';
-import { getDb } from '../../db/connection.js';
-import {
-  deleteMessagingGroupAgent,
-  getMessagingGroup,
-  getMessagingGroupAgent,
-  updateMessagingGroup,
-  updateMessagingGroupAgent,
-} from '../../db/messaging-groups.js';
-import { log } from '../../log.js';
-import type { MessagingGroup, MessagingGroupAgent, UnknownSenderPolicy } from '../../types.js';
-
-function listAllWires(): ChannelWireView[] {
-  const rows = getDb()
-    .prepare<WireJoinRow>(
-      `SELECT mga.*,
-              mg.channel_type AS mg_channel_type,
-              mg.platform_id  AS mg_platform_id,
-              mg.name         AS mg_name,
-              ag.folder       AS ag_folder,
-              ag.name         AS ag_name
-         FROM messaging_group_agents mga
-         JOIN messaging_groups mg ON mg.id = mga.messaging_group_id
-         JOIN agent_groups ag     ON ag.id = mga.agent_group_id
-        ORDER BY mga.created_at DESC`,
-    )
-    .all();
-  return rows.map(rowToView);
-}
-
-function getOneWireView(id: string): ChannelWireView | null {
-  const mga = getMessagingGroupAgent(id);
-  if (!mga) return null;
-  const mg = getMessagingGroup(mga.messaging_group_id);
-  const ag = getAgentGroup(mga.agent_group_id);
-  if (!mg || !ag) return null;
-  return rowToView({
-    ...mga,
-    mg_channel_type: mg.channel_type,
-    mg_platform_id: mg.platform_id,
-    mg_name: mg.name,
-    ag_folder: ag.folder,
-    ag_name: ag.name,
-  });
-}
-
-const json = (res: http.ServerResponse, status: number, body: unknown): void => {
-  res.writeHead(status, { 'content-type': 'application/json' });
-  res.end(JSON.stringify(body));
-};
-
-const error = (res: http.ServerResponse, status: number, message: string): void =>
-  json(res, status, { error: message });
-
-async function readJsonBody<T>(req: http.IncomingMessage): Promise<T> {
-  const chunks: Buffer[] = [];
-  for await (const chunk of req) chunks.push(chunk as Buffer);
-  if (chunks.length === 0) return {} as T;
-  return JSON.parse(Buffer.concat(chunks).toString('utf8')) as T;
-}
-
-// ─── /api/channels/mg/:id — per-MG detail + policy editor ──────────────
-//
-// Path is namespaced under `mg/` so it can't collide with `/api/channels/:mga-id`
-// when an mg-id and an mga-id happen to share a prefix or shape (both are
-// uuids today, but the disambiguation is a contract for future schemas).
-// Each MGA wire row already carries its parent `messagingGroupId`, so the
-// list page links the detail with the value it already has — no extra
-// resolve step.
-
-export interface WiredAgentSummary {
-  /** mga.id — primary key for the per-MGA detail page in PR3. */
-  messagingGroupAgentId: string;
-  agentGroupId: string;
-  agentGroupFolder: string;
-  agentGroupName: string;
-  /** Snapshot of MGA fields useful for the read-only summary on the detail page. */
-  engageMode: ApiEngageMode;
-  engagePattern: string | null;
-  senderScope: ApiSenderScope;
-  ignoredMessagePolicy: ApiIgnoredMessagePolicy;
-  priority: number;
-  createdAt: string;
-}
-
-export interface MessagingGroupDetailView {
-  id: string;
-  channelType: string;
-  platformId: string;
-  /** MG's `name` column — null when the operator hasn't set one. */
-  displayName: string | null;
-  isGroup: boolean;
-  unknownSenderPolicy: UnknownSenderPolicy;
-  /** ISO when the owner explicitly denied this channel; null otherwise. */
-  deniedAt: string | null;
-  createdAt: string;
-  wiredAgents: WiredAgentSummary[];
-}
-
-interface AgentJoinRow extends MessagingGroupAgent {
-  ag_folder: string;
-  ag_name: string;
-}
-
-export function getMessagingGroupDetail(id: string): MessagingGroupDetailView | null {
-  const mg = getMessagingGroup(id);
-  if (!mg) return null;
-  const rows = getDb()
-    .prepare<AgentJoinRow>(
-      `SELECT mga.*, ag.folder AS ag_folder, ag.name AS ag_name
-         FROM messaging_group_agents mga
-         JOIN agent_groups ag ON ag.id = mga.agent_group_id
-        WHERE mga.messaging_group_id = ?
-        ORDER BY mga.priority DESC, mga.created_at ASC`,
-    )
-    .all(id);
-  return mgToDetailView(
-    mg,
-    rows.map((row) => ({
-      messagingGroupAgentId: row.id,
-      agentGroupId: row.agent_group_id,
-      agentGroupFolder: row.ag_folder,
-      agentGroupName: row.ag_name,
-      engageMode: dbToApiEngage(row.engage_mode, row.engage_pattern),
-      engagePattern:
-        row.engage_mode === 'pattern' && row.engage_pattern !== ALL_MESSAGES_PATTERN_SENTINEL
-          ? row.engage_pattern
-          : null,
-      senderScope: dbToApiSenderScope(row.sender_scope),
-      ignoredMessagePolicy: dbToApiIgnoredPolicy(row.ignored_message_policy),
-      priority: row.priority,
-      createdAt: row.created_at,
-    })),
-  );
-}
-
-function mgToDetailView(mg: MessagingGroup, wiredAgents: WiredAgentSummary[]): MessagingGroupDetailView {
-  return {
-    id: mg.id,
-    channelType: mg.channel_type,
-    platformId: mg.platform_id,
-    displayName: mg.name,
-    isGroup: mg.is_group === 1,
-    unknownSenderPolicy: mg.unknown_sender_policy,
-    deniedAt: mg.denied_at ?? null,
-    createdAt: mg.created_at,
-    wiredAgents,
-  };
-}
-
-const VALID_UNKNOWN_SENDER_POLICIES: UnknownSenderPolicy[] = ['strict', 'request_approval', 'public'];
-
-interface MgPatchInput {
-  unknownSenderPolicy: UnknownSenderPolicy;
-}
-
-function validateMgPatchInput(body: unknown): { ok: true; input: MgPatchInput } | { ok: false; reason: string } {
-  if (!body || typeof body !== 'object') return { ok: false, reason: 'body must be an object' };
-  const b = body as Record<string, unknown>;
-  if (!('unknownSenderPolicy' in b)) {
-    return { ok: false, reason: 'unknownSenderPolicy is required' };
-  }
-  if (!VALID_UNKNOWN_SENDER_POLICIES.includes(b.unknownSenderPolicy as UnknownSenderPolicy)) {
-    return { ok: false, reason: `invalid unknownSenderPolicy: ${String(b.unknownSenderPolicy)}` };
-  }
-  return { ok: true, input: { unknownSenderPolicy: b.unknownSenderPolicy as UnknownSenderPolicy } };
-}
-
-export interface ChannelsRouteContext {
-  pathname: string;
-  method: string;
-  req: http.IncomingMessage;
-  res: http.ServerResponse;
-}
-
-export async function handleChannelsRoute(ctx: ChannelsRouteContext): Promise<boolean> {
-  const { pathname, method, req, res } = ctx;
-
-  if (pathname === '/api/channels' && method === 'GET') {
-    json(res, 200, { wires: listAllWires() });
-    return true;
-  }
-
-  // /api/channels/mg/:id — GET (detail) or PATCH (policy edit). Must dispatch
-  // ahead of /api/channels/:id so the literal `mg` segment doesn't get
-  // mis-parsed as an mga-id.
-  const mgMatch = pathname.match(/^\/api\/channels\/mg\/([^/]+)$/);
-  if (mgMatch) {
-    const id = decodeURIComponent(mgMatch[1]);
-    const detail = getMessagingGroupDetail(id);
-    if (!detail) {
-      error(res, 404, `messaging group not found: ${id}`);
-      return true;
-    }
-    if (method === 'GET') {
-      json(res, 200, { messagingGroup: detail });
-      return true;
-    }
-    if (method === 'PATCH') {
-      let body: unknown;
-      try {
-        body = await readJsonBody<unknown>(req);
-      } catch {
-        error(res, 400, 'invalid JSON body');
-        return true;
-      }
-      const validated = validateMgPatchInput(body);
-      if (!validated.ok) {
-        error(res, 400, validated.reason);
-        return true;
-      }
-      updateMessagingGroup(id, { unknown_sender_policy: validated.input.unknownSenderPolicy });
-      log.info('messaging group policy updated via web', {
-        id,
-        unknownSenderPolicy: validated.input.unknownSenderPolicy,
-      });
-      // Same connection, same tx, same row — the post-update re-fetch can't
-      // return null without the row being concurrently deleted, which is not
-      // a state this surface needs to guard against.
-      json(res, 200, { messagingGroup: getMessagingGroupDetail(id)! });
-      return true;
-    }
-    error(res, 405, `method not allowed on ${pathname}: ${method}`);
-    return true;
-  }
-
-  // /api/channels/mga/:id — GET (wire detail), PATCH (routing rules edit),
-  // or DELETE (unwire). The `mga/` segment matches the `mg/` convention from
-  // the messaging-group detail block above; `mga` = messaging_group_agent =
-  // one wire row.
-  const mgaMatch = pathname.match(/^\/api\/channels\/mga\/([^/]+)$/);
-  if (mgaMatch) {
-    const id = decodeURIComponent(mgaMatch[1]);
-    const current = getMessagingGroupAgent(id);
-    if (!current) {
-      error(res, 404, `channel wire not found: ${id}`);
-      return true;
-    }
-
-    if (method === 'GET') {
-      json(res, 200, { wire: getOneWireView(id)! });
-      return true;
-    }
-
-    if (method === 'PATCH') {
-      let body: unknown;
-      try {
-        body = await readJsonBody<unknown>(req);
-      } catch {
-        error(res, 400, 'invalid JSON body');
-        return true;
-      }
-      const validated = validatePatchInput(body);
-      if (!validated.ok) {
-        error(res, 400, validated.reason);
-        return true;
-      }
-      const dbPatch = apiToDbPatch(validated.input, current);
-      updateMessagingGroupAgent(id, dbPatch);
-      log.info('channel wire updated via web', { id, fields: Object.keys(dbPatch) });
-      // Same connection, same row — see channels.ts mg/:id PATCH for the
-      // non-null-assertion rationale.
-      json(res, 200, { wire: getOneWireView(id)! });
-      return true;
-    }
-
-    if (method === 'DELETE') {
-      deleteMessagingGroupAgent(id);
-      log.info('channel wire deleted via web', { id });
-      json(res, 200, { id, deleted: true });
-      return true;
-    }
-
-    error(res, 405, `method not allowed on ${pathname}: ${method}`);
-    return true;
-  }
-
-  return false;
-}

package/src/web/routes/oauth-providers.ts

@@ -1,42 +0,0 @@
-/**
- * /api/oauth/providers — read-only provider registry.
- *
- * The UI's "add integration" picker is data-driven off this list rather
- * than hard-coding provider slugs in the SPA bundle. New providers
- * registered in `src/oauth/providers/index.ts` automatically surface
- * here. No secrets, no per-account state — just the registry shape.
- */
-import http from 'node:http';
-
-import { listProviders } from '../../oauth/providers/index.js';
-
-interface ProviderView {
-  slug: string;
-  displayName: string;
-  defaultScopes: string;
-}
-
-const json = (res: http.ServerResponse, status: number, body: unknown): void => {
-  res.writeHead(status, { 'content-type': 'application/json' });
-  res.end(JSON.stringify(body));
-};
-
-export interface OauthProvidersRouteContext {
-  pathname: string;
-  method: string;
-  res: http.ServerResponse;
-}
-
-export function handleOauthProvidersRoute(ctx: OauthProvidersRouteContext): boolean {
-  const { pathname, method, res } = ctx;
-  if (pathname === '/api/oauth/providers' && method === 'GET') {
-    const providers: ProviderView[] = listProviders().map((p) => ({
-      slug: p.slug,
-      displayName: p.displayName,
-      defaultScopes: p.defaultScopes,
-    }));
-    json(res, 200, { providers });
-    return true;
-  }
-  return false;
-}

package/src/web/routes/secrets.test.ts

@@ -1,220 +0,0 @@
-/**
- * HTTP-boundary tests for the secrets route — currently focused on the
- * staleness probe added with paraclaw#103. The mutation surfaces (POST,
- * DELETE, /assignments) are exercised by `src/secrets/secrets.test.ts` at
- * the helper level; this file complements that with the route dispatcher.
- *
- * Auth gating (`agent:read` for GET, `agent:admin` for mutation) lives in
- * `src/web/server.ts` upstream of `handleSecretsRoute`, so 401/403 cases
- * belong to `auth.test.ts` rather than the route layer — the handler is
- * never reached without a passing scope check. We assert the handler's
- * own contract here (status, body shape, 404 for missing rows).
- */
-import http from 'node:http';
-import crypto from 'crypto';
-
-import { afterEach, beforeEach, describe, expect, it } from 'vitest';
-
-import { getDb } from '../../db/connection.js';
-import { closeDb, initTestDb, runMigrations } from '../../db/index.js';
-import { _setMasterKeyForTest } from '../../secrets/master-key.js';
-import { addAssignment, putSecret } from '../../secrets/index.js';
-import { handleSecretsRoute, listInjectableSecretsForGroupView } from './secrets.js';
-
-beforeEach(() => {
-  const db = initTestDb();
-  runMigrations(db);
-  _setMasterKeyForTest(crypto.randomBytes(32));
-});
-
-afterEach(() => {
-  closeDb();
-});
-
-interface FakeResponse {
-  statusCode: number;
-  body: unknown;
-  res: http.ServerResponse;
-}
-
-function fakeRes(): FakeResponse {
-  const captured: FakeResponse = {
-    statusCode: 0,
-    body: undefined,
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    res: undefined as any,
-  };
-  const res = {
-    writeHead(status: number) {
-      captured.statusCode = status;
-    },
-    end(chunk: string) {
-      try {
-        captured.body = chunk ? JSON.parse(chunk) : undefined;
-      } catch {
-        captured.body = chunk;
-      }
-    },
-  } as unknown as http.ServerResponse;
-  captured.res = res;
-  return captured;
-}
-
-function fakeReq(): http.IncomingMessage {
-  return Object.assign(Object.create(null), {
-    [Symbol.asyncIterator]: async function* () {},
-  }) as http.IncomingMessage;
-}
-
-function seedAgentGroup(id: string, secretMode: 'all' | 'selective' = 'selective') {
-  getDb()
-    .prepare(
-      `INSERT INTO agent_groups (id, folder, name, secret_mode, created_at)
-       VALUES (?, ?, ?, ?, datetime('now'))`,
-    )
-    .run(id, id, id, secretMode);
-}
-
-function seedSession(sessionId: string, agentGroupId: string, createdAt: string) {
-  getDb()
-    .prepare(
-      `INSERT INTO sessions
-         (id, agent_group_id, messaging_group_id, thread_id, agent_provider, status, container_status, last_active, created_at)
-       VALUES (?, ?, NULL, NULL, NULL, 'active', 'running', NULL, ?)`,
-    )
-    .run(sessionId, agentGroupId, createdAt);
-}
-
-function bumpSecretUpdatedAt(secretId: string, updatedAt: string) {
-  getDb().prepare(`UPDATE secrets SET updated_at = ? WHERE id = ?`).run(updatedAt, secretId);
-}
-
-describe('GET /api/secrets/:id/stale-sessions', () => {
-  it('returns 200 with the secret metadata + the stale-session list', async () => {
-    seedAgentGroup('group-a', 'selective');
-    // Session spawned at t=10, secret bumped to t=20 — session is stale.
-    seedSession('sess-1', 'group-a', '2026-01-01T00:00:10.000Z');
-    const sid = putSecret('TOKEN', 'v');
-    addAssignment(sid, 'group-a');
-    bumpSecretUpdatedAt(sid, '2026-01-01T00:00:20.000Z');
-
-    const cap = fakeRes();
-    const handled = await handleSecretsRoute({
-      pathname: `/api/secrets/${sid}/stale-sessions`,
-      method: 'GET',
-      url: new URL(`https://x/api/secrets/${sid}/stale-sessions`),
-      req: fakeReq(),
-      res: cap.res,
-    });
-
-    expect(handled).toBe(true);
-    expect(cap.statusCode).toBe(200);
-    expect(cap.body).toMatchObject({
-      secretId: sid,
-      secretUpdatedAt: '2026-01-01T00:00:20.000Z',
-      staleSessions: [
-        {
-          sessionId: 'sess-1',
-          agentGroupId: 'group-a',
-          agentGroupName: 'group-a',
-          agentGroupFolder: 'group-a',
-          sessionCreatedAt: '2026-01-01T00:00:10.000Z',
-          secretUpdatedAt: '2026-01-01T00:00:20.000Z',
-        },
-      ],
-    });
-  });
-
-  it('returns 200 with an empty staleSessions array when nothing is stale', async () => {
-    seedAgentGroup('group-a', 'selective');
-    // Session spawned AFTER the secret update — not stale.
-    const sid = putSecret('TOKEN', 'v');
-    addAssignment(sid, 'group-a');
-    bumpSecretUpdatedAt(sid, '2026-01-01T00:00:10.000Z');
-    seedSession('sess-fresh', 'group-a', '2026-01-01T00:00:20.000Z');
-
-    const cap = fakeRes();
-    await handleSecretsRoute({
-      pathname: `/api/secrets/${sid}/stale-sessions`,
-      method: 'GET',
-      url: new URL(`https://x/api/secrets/${sid}/stale-sessions`),
-      req: fakeReq(),
-      res: cap.res,
-    });
-
-    expect(cap.statusCode).toBe(200);
-    expect(cap.body).toMatchObject({ secretId: sid, staleSessions: [] });
-  });
-
-  it('returns 404 for an unknown secret id', async () => {
-    const cap = fakeRes();
-    const handled = await handleSecretsRoute({
-      pathname: '/api/secrets/does-not-exist/stale-sessions',
-      method: 'GET',
-      url: new URL('https://x/api/secrets/does-not-exist/stale-sessions'),
-      req: fakeReq(),
-      res: cap.res,
-    });
-
-    expect(handled).toBe(true);
-    expect(cap.statusCode).toBe(404);
-    expect(cap.body).toMatchObject({ error: expect.stringContaining('does-not-exist') });
-  });
-
-  it('falls through (returns false) on non-GET methods so the dispatcher can keep looking', async () => {
-    const cap = fakeRes();
-    const handled = await handleSecretsRoute({
-      pathname: '/api/secrets/anything/stale-sessions',
-      method: 'POST',
-      url: new URL('https://x/api/secrets/anything/stale-sessions'),
-      req: fakeReq(),
-      res: cap.res,
-    });
-    expect(handled).toBe(false);
-  });
-});
-
-describe('listInjectableSecretsForGroupView (paraclaw#104)', () => {
-  it('projects scoped/assigned/global rows into the wire shape', () => {
-    seedAgentGroup('group-x', 'all');
-    const scopedId = putSecret('SCOPED', 'v', { agent_group_id: 'group-x' });
-    const assignedId = putSecret('ASSIGNED', 'v');
-    addAssignment(assignedId, 'group-x');
-    const globalId = putSecret('GLOBAL', 'v');
-
-    const view = listInjectableSecretsForGroupView('group-x');
-    const byName = new Map(view.map((r) => [r.name, r]));
-
-    expect(byName.get('SCOPED')).toMatchObject({
-      id: scopedId,
-      name: 'SCOPED',
-      kind: 'generic',
-      agentGroupId: 'group-x',
-      scope: 'scoped',
-    });
-    expect(byName.get('ASSIGNED')).toMatchObject({
-      id: assignedId,
-      agentGroupId: null,
-      scope: 'assigned',
-    });
-    expect(byName.get('GLOBAL')).toMatchObject({
-      id: globalId,
-      agentGroupId: null,
-      scope: 'global',
-    });
-
-    // Wire shape is camelCase, never the snake_case DB row.
-    for (const row of view) {
-      expect(row).not.toHaveProperty('agent_group_id');
-      expect(row).not.toHaveProperty('value_encrypted');
-      expect(row).toHaveProperty('createdAt');
-      expect(row).toHaveProperty('updatedAt');
-    }
-  });
-
-  it('returns [] for a group whose secret_mode is selective with no assignments', () => {
-    seedAgentGroup('empty', 'selective');
-    putSecret('GLOBAL', 'v');
-    expect(listInjectableSecretsForGroupView('empty')).toEqual([]);
-  });
-});