@openparachute/agent 0.1.2 → 0.2.2

package/src/channels/telegram-pairing.test.ts

@@ -1,254 +0,0 @@
-import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
-import fs from 'fs';
-import path from 'path';
-import os from 'os';
-
-vi.mock('../log.js', () => ({ log: { info: vi.fn(), warn: vi.fn(), error: vi.fn(), debug: vi.fn() } }));
-
-import {
-  createPairing,
-  tryConsume,
-  getStatus,
-  getPairing,
-  waitForPairing,
-  extractCode,
-  extractAddressedText,
-  _setStorePathForTest,
-  _resetForTest,
-} from './telegram-pairing.js';
-
-let tmpDir: string;
-
-beforeEach(() => {
-  tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'tg-pair-'));
-  _setStorePathForTest(path.join(tmpDir, 'pairings.json'));
-});
-
-afterEach(() => {
-  _resetForTest();
-  _setStorePathForTest(null);
-  fs.rmSync(tmpDir, { recursive: true, force: true });
-});
-
-describe('extractAddressedText', () => {
-  it('strips @botname prefix', () => {
-    expect(extractAddressedText('@nanobot 1234', 'nanobot')).toBe('1234');
-  });
-  it('is case-insensitive', () => {
-    expect(extractAddressedText('@NanoBot hello', 'nanobot')).toBe('hello');
-  });
-  it('returns null when not addressed', () => {
-    expect(extractAddressedText('hello 1234', 'nanobot')).toBeNull();
-  });
-  it('returns null when address is mid-text', () => {
-    expect(extractAddressedText('hi @nanobot 1234', 'nanobot')).toBeNull();
-  });
-});
-
-describe('extractCode', () => {
-  it('accepts a bare 4-digit code', () => {
-    expect(extractCode('0349', 'nanobot')).toBe('0349');
-  });
-  it('accepts 4-digit code after @botname', () => {
-    expect(extractCode('@nanobot 0042', 'nanobot')).toBe('0042');
-  });
-  it('rejects non-4-digit numbers', () => {
-    expect(extractCode('@nanobot 12345', 'nanobot')).toBeNull();
-    expect(extractCode('@nanobot 12', 'nanobot')).toBeNull();
-    expect(extractCode('12345', 'nanobot')).toBeNull();
-  });
-  it('rejects loose matches with surrounding text', () => {
-    expect(extractCode('my pin is 0349', 'nanobot')).toBeNull();
-    expect(extractCode('0349 thanks', 'nanobot')).toBeNull();
-  });
-});
-
-describe('createPairing', () => {
-  it('generates a 4-digit code', async () => {
-    const r = await createPairing('main');
-    expect(r.code).toMatch(/^\d{4}$/);
-    expect(r.status).toBe('pending');
-  });
-
-  it('does not collide with active codes', async () => {
-    // Use distinct intents per pairing — `createPairing('main')` invalidates
-    // the previous pending 'main' so only one stays active at a time, which
-    // means the collision-avoidance loop is never actually exercised. With
-    // distinct intents all N stay pending and `generateCode` has to dodge
-    // every one. (Using a single intent with 20 iterations was a birthday-
-    // paradox flake — ~2% collision rate across 10k codes.)
-    const codes = new Set<string>();
-    for (let i = 0; i < 20; i++) {
-      const r = await createPairing({ kind: 'wire-to', folder: `g-${i}` });
-      expect(codes.has(r.code)).toBe(false);
-      codes.add(r.code);
-    }
-  });
-});
-
-describe('tryConsume', () => {
-  it('matches and marks consumed', async () => {
-    const r = await createPairing('main');
-    const consumed = await tryConsume({
-      text: `@nanobot ${r.code}`,
-      botUsername: 'nanobot',
-      platformId: 'telegram:123',
-      isGroup: false,
-      adminUserId: 'u1',
-    });
-    expect(consumed).not.toBeNull();
-    expect(consumed!.status).toBe('consumed');
-    expect(consumed!.consumed?.platformId).toBe('telegram:123');
-    expect(consumed!.consumed?.adminUserId).toBe('u1');
-    expect(getStatus(r.code)).toBe('consumed');
-  });
-
-  it('returns null on no match (silent drop)', async () => {
-    await createPairing('main');
-    const out = await tryConsume({
-      text: '@nanobot 9999',
-      botUsername: 'nanobot',
-      platformId: 'x',
-      isGroup: false,
-    });
-    expect(out).toBeNull();
-  });
-
-  it('matches a bare code without @botname addressing', async () => {
-    const r = await createPairing('main');
-    const out = await tryConsume({
-      text: r.code,
-      botUsername: 'nanobot',
-      platformId: 'x',
-      isGroup: false,
-    });
-    expect(out).not.toBeNull();
-    expect(out!.status).toBe('consumed');
-  });
-
-  it('cannot be consumed twice', async () => {
-    const r = await createPairing('main');
-    await tryConsume({ text: `@b ${r.code}`, botUsername: 'b', platformId: 'p', isGroup: false });
-    const second = await tryConsume({ text: `@b ${r.code}`, botUsername: 'b', platformId: 'p', isGroup: false });
-    expect(second).toBeNull();
-  });
-
-  it('cannot consume an invalidated pairing', async () => {
-    const r = await createPairing('main');
-    // Invalidate by sending a wrong code
-    await tryConsume({ text: '9999', botUsername: 'b', platformId: 'p', isGroup: false });
-    const out = await tryConsume({ text: `@b ${r.code}`, botUsername: 'b', platformId: 'p', isGroup: false });
-    expect(out).toBeNull();
-    expect(getStatus(r.code)).toBe('invalidated');
-  });
-});
-
-describe('getStatus', () => {
-  it('returns unknown for missing codes', () => {
-    expect(getStatus('0000')).toBe('unknown');
-  });
-});
-
-describe('waitForPairing', () => {
-  it('resolves when consumed', async () => {
-    const r = await createPairing('main');
-    const p = waitForPairing(r.code, { pollMs: 50 });
-    setTimeout(() => {
-      tryConsume({ text: `@b ${r.code}`, botUsername: 'b', platformId: 'tg:1', isGroup: true, name: 'Group' });
-    }, 100);
-    const consumed = await p;
-    expect(consumed.status).toBe('consumed');
-    expect(consumed.consumed?.name).toBe('Group');
-  });
-
-  it('rejects on invalidation', async () => {
-    const r = await createPairing('main');
-    const waiter = waitForPairing(r.code, { pollMs: 30 });
-    setTimeout(() => {
-      tryConsume({ text: '0000', botUsername: 'b', platformId: 'tg:1', isGroup: false });
-    }, 60);
-    await expect(waiter).rejects.toThrow(/invalidated/);
-  });
-});
-
-describe('replace-by-default', () => {
-  it('supersedes an existing pending pairing with the same intent', async () => {
-    const first = await createPairing('main');
-    const second = await createPairing('main');
-    expect(getStatus(first.code)).toBe('invalidated');
-    expect(getStatus(second.code)).toBe('pending');
-  });
-
-  it('does not supersede pairings with a different intent', async () => {
-    const a = await createPairing({ kind: 'wire-to', folder: 'work' });
-    const b = await createPairing({ kind: 'wire-to', folder: 'side' });
-    expect(getStatus(a.code)).toBe('pending');
-    expect(getStatus(b.code)).toBe('pending');
-  });
-
-  it('causes waitForPairing on the old code to reject as invalidated', async () => {
-    const first = await createPairing('main');
-    const waiter = waitForPairing(first.code, { pollMs: 30 });
-    await new Promise((r) => setTimeout(r, 50));
-    await createPairing('main');
-    await expect(waiter).rejects.toThrow(/invalidated/);
-  });
-});
-
-describe('attempt tracking', () => {
-  it('fires onAttempt for a wrong code, invalidates the pairing, and rejects the waiter', async () => {
-    const r = await createPairing('main');
-    const attempts: string[] = [];
-    const waiter = waitForPairing(r.code, {
-      pollMs: 30,
-      onAttempt: (a) => attempts.push(a.candidate),
-    });
-    setTimeout(() => {
-      tryConsume({ text: '9999', botUsername: 'b', platformId: 'tg:1', isGroup: false });
-    }, 60);
-    await expect(waiter).rejects.toThrow(/invalidated by wrong code \(9999\)/);
-    expect(attempts).toEqual(['9999']);
-    expect(getStatus(r.code)).toBe('invalidated');
-  });
-
-  it('a correct code consumes without firing onAttempt', async () => {
-    const r = await createPairing('main');
-    const attempts: string[] = [];
-    const waiter = waitForPairing(r.code, {
-      pollMs: 30,
-      onAttempt: (a) => attempts.push(a.candidate),
-    });
-    setTimeout(() => {
-      tryConsume({ text: r.code, botUsername: 'b', platformId: 'tg:1', isGroup: false });
-    }, 60);
-    const consumed = await waiter;
-    expect(consumed.status).toBe('consumed');
-    expect(attempts).toEqual([]);
-  });
-
-  it('ignores non-code messages and keeps the pairing pending', async () => {
-    const r = await createPairing('main');
-    await tryConsume({ text: 'hello there', botUsername: 'b', platformId: 'p', isGroup: false });
-    const after = getPairing(r.code);
-    expect(after?.status).toBe('pending');
-    expect(after?.attempts ?? []).toHaveLength(0);
-  });
-
-  it('a second code attempt after invalidation does not match', async () => {
-    const r = await createPairing('main');
-    await tryConsume({ text: '9999', botUsername: 'b', platformId: 'p', isGroup: false });
-    const retry = await tryConsume({ text: r.code, botUsername: 'b', platformId: 'p', isGroup: false });
-    expect(retry).toBeNull();
-  });
-});
-
-describe('intent passthrough', () => {
-  it('preserves wire-to and new-agent intents', async () => {
-    const a = await createPairing({ kind: 'wire-to', folder: 'work' });
-    const b = await createPairing({ kind: 'new-agent', folder: 'side' });
-    const ca = await tryConsume({ text: `@b ${a.code}`, botUsername: 'b', platformId: 'p1', isGroup: true });
-    const cb = await tryConsume({ text: `@b ${b.code}`, botUsername: 'b', platformId: 'p2', isGroup: true });
-    expect(ca!.intent).toEqual({ kind: 'wire-to', folder: 'work' });
-    expect(cb!.intent).toEqual({ kind: 'new-agent', folder: 'side' });
-  });
-});

package/src/channels/telegram-pairing.ts

@@ -1,339 +0,0 @@
-/**
- * Telegram pairing — proves the operator owns the chat they're registering.
- *
- * BotFather hands out tokens with no user binding, so anyone who guesses the
- * bot's username can DM it. Pairing closes that gap: setup creates a one-time
- * 4-digit code and the operator echoes it back from the chat they want to
- * register. The message must be exactly the 4 digits (optionally prefixed by
- * `@botname ` for groups with privacy ON) — arbitrary messages that happen to
- * contain a 4-digit number do NOT match. The inbound interceptor in
- * telegram.ts matches the code, records the chat, upserts the paired user,
- * and (if no owner exists yet) promotes them to owner — all before the
- * message ever reaches the router.
- *
- * Storage is a JSON file at data/telegram-pairings.json — single-process,
- * read-modify-write under an in-process mutex.
- */
-import fs from 'fs';
-import path from 'path';
-
-import { DATA_DIR } from '../config.js';
-import { log } from '../log.js';
-
-export type PairingIntent = 'main' | { kind: 'wire-to'; folder: string } | { kind: 'new-agent'; folder: string };
-export type PairingStatus = 'pending' | 'consumed' | 'invalidated' | 'unknown';
-
-export interface ConsumedDetails {
-  platformId: string;
-  isGroup: boolean;
-  name: string | null;
-  adminUserId: string | null;
-  consumedAt: string;
-}
-
-export interface PairingAttempt {
-  candidate: string;
-  platformId: string;
-  at: string;
-  matched: boolean;
-}
-
-export interface PairingRecord {
-  code: string;
-  intent: PairingIntent;
-  createdAt: string;
-  status: Exclude<PairingStatus, 'unknown'>;
-  consumed?: ConsumedDetails;
-  /** Recent pairing attempts observed while this record was pending. Capped. */
-  attempts?: PairingAttempt[];
-}
-
-const MAX_ATTEMPTS_PER_RECORD = 10;
-
-function intentEquals(a: PairingIntent, b: PairingIntent): boolean {
-  if (a === 'main' || b === 'main') return a === b;
-  return a.kind === b.kind && a.folder === b.folder;
-}
-
-interface Store {
-  pairings: PairingRecord[];
-}
-
-/** Pairing codes do not expire — they are consumed on match or invalidated by wrong guesses. */
-const FILE_NAME = 'telegram-pairings.json';
-
-let storePathOverride: string | null = null;
-export function _setStorePathForTest(p: string | null): void {
-  storePathOverride = p;
-}
-
-function storePath(): string {
-  return storePathOverride ?? path.join(DATA_DIR, FILE_NAME);
-}
-
-let mutex: Promise<unknown> = Promise.resolve();
-function withLock<T>(fn: () => Promise<T> | T): Promise<T> {
-  const next = mutex.then(() => fn());
-  mutex = next.catch(() => {});
-  return next;
-}
-
-function readStore(): Store {
-  try {
-    const raw = fs.readFileSync(storePath(), 'utf8');
-    const parsed = JSON.parse(raw) as Store;
-    if (!Array.isArray(parsed.pairings)) return { pairings: [] };
-    return parsed;
-  } catch {
-    return { pairings: [] };
-  }
-}
-
-function writeStore(store: Store): void {
-  const p = storePath();
-  fs.mkdirSync(path.dirname(p), { recursive: true });
-  const tmp = `${p}.tmp`;
-  fs.writeFileSync(tmp, JSON.stringify(store, null, 2));
-  fs.renameSync(tmp, p);
-}
-
-/** Clean up old consumed/invalidated records (keep last 50). */
-function sweep(store: Store): boolean {
-  if (store.pairings.length <= 50) return false;
-  store.pairings = store.pairings.slice(-50);
-  return true;
-}
-
-function generateCode(active: Set<string>): string {
-  // 4-digit numeric, zero-padded. 10k space, fine for one-at-a-time intents.
-  for (let i = 0; i < 50; i++) {
-    const code = Math.floor(Math.random() * 10000)
-      .toString()
-      .padStart(4, '0');
-    if (!active.has(code)) return code;
-  }
-  throw new Error('Could not allocate a free pairing code (too many active).');
-}
-
-export async function createPairing(intent: PairingIntent): Promise<PairingRecord> {
-  return withLock(() => {
-    const store = readStore();
-    sweep(store);
-    // Replace-by-default: a new pairing for an intent supersedes any existing
-    // pending pairing for the same intent. Old waitForPairing calls observe
-    // `invalidated` and exit on their own.
-    for (const r of store.pairings) {
-      if (r.status === 'pending' && intentEquals(r.intent, intent)) {
-        r.status = 'invalidated';
-        log.info('Pairing superseded by new request', { code: r.code, intent });
-      }
-    }
-    const active = new Set(store.pairings.filter((r) => r.status === 'pending').map((r) => r.code));
-    const record: PairingRecord = {
-      code: generateCode(active),
-      intent,
-      createdAt: new Date().toISOString(),
-      status: 'pending',
-    };
-    store.pairings.push(record);
-    writeStore(store);
-    log.info('Pairing created', { code: record.code, intent });
-    return record;
-  });
-}
-
-export interface ConsumeInput {
-  text: string;
-  botUsername: string;
-  platformId: string;
-  isGroup: boolean;
-  name?: string | null;
-  adminUserId?: string | null;
-}
-
-/** Strip leading @botname and return the trimmed remainder, or null if not addressed. */
-export function extractAddressedText(text: string, botUsername: string): string | null {
-  const trimmed = text.trim();
-  const re = new RegExp(`^@${botUsername.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\$&')}\\b`, 'i');
-  const m = trimmed.match(re);
-  if (!m) return null;
-  return trimmed.slice(m[0].length).trim();
-}
-
-/**
- * Extract a pairing code from an inbound message. The message must be exactly
- * 4 digits (optionally prefixed by `@botname `) — loose matches like
- * "my pin is 1234" are rejected to avoid false positives from chatter.
- */
-export function extractCode(text: string, botUsername: string): string | null {
-  const addressed = extractAddressedText(text, botUsername);
-  const candidate = (addressed !== null ? addressed : text).trim();
-  const m = candidate.match(/^(\d{4})$/);
-  return m ? m[1] : null;
-}
-
-/**
- * Try to match an inbound message against a pending pairing. On match,
- * marks the pairing consumed atomically and returns the record. Returns
- * null on no match or expiry (silent drop).
- */
-export async function tryConsume(input: ConsumeInput): Promise<PairingRecord | null> {
-  const code = extractCode(input.text, input.botUsername);
-  if (!code) return null;
-  return withLock(() => {
-    const store = readStore();
-    const now = Date.now();
-    sweep(store);
-    const record = store.pairings.find((r) => r.code === code && r.status === 'pending');
-    if (!record) {
-      // Miss: record the attempt on every currently-pending record so each
-      // waitForPairing caller can surface it as user feedback.
-      const attempt: PairingAttempt = {
-        candidate: code,
-        platformId: input.platformId,
-        at: new Date(now).toISOString(),
-        matched: false,
-      };
-      let recorded = false;
-      for (const r of store.pairings) {
-        if (r.status !== 'pending') continue;
-        r.attempts = [...(r.attempts ?? []), attempt].slice(-MAX_ATTEMPTS_PER_RECORD);
-        // One attempt per code. A wrong guess invalidates the pairing
-        // immediately — pair-telegram observes the `invalidated` signal and
-        // auto-issues a fresh code (up to a retry cap).
-        r.status = 'invalidated';
-        recorded = true;
-      }
-      writeStore(store);
-      if (recorded) {
-        log.info('Pairing invalidated by wrong attempt', { candidate: code, platformId: input.platformId });
-      }
-      return null;
-    }
-    record.status = 'consumed';
-    record.consumed = {
-      platformId: input.platformId,
-      isGroup: input.isGroup,
-      name: input.name ?? null,
-      adminUserId: input.adminUserId ?? null,
-      consumedAt: new Date(now).toISOString(),
-    };
-    record.attempts = [
-      ...(record.attempts ?? []),
-      { candidate: code, platformId: input.platformId, at: new Date(now).toISOString(), matched: true },
-    ].slice(-MAX_ATTEMPTS_PER_RECORD);
-    writeStore(store);
-    log.info('Pairing consumed', { code, platformId: input.platformId, intent: record.intent });
-    return record;
-  });
-}
-
-export function getStatus(code: string): PairingStatus {
-  const store = readStore();
-  sweep(store);
-  const r = store.pairings.find((p) => p.code === code);
-  if (!r) return 'unknown';
-  return r.status;
-}
-
-export function getPairing(code: string): PairingRecord | null {
-  const store = readStore();
-  sweep(store);
-  return store.pairings.find((p) => p.code === code) ?? null;
-}
-
-export interface WaitForPairingOptions {
-  /** Polling interval as a fallback when fs.watch misses an event. */
-  pollMs?: number;
-  /** Fires once per new attempt recorded against this pairing (misses only). */
-  onAttempt?: (attempt: PairingAttempt) => void;
-}
-
-/**
- * Resolve when the pairing is consumed; reject when it is invalidated
- * (wrong code guess). Waits indefinitely — codes do not expire.
- * Uses fs.watch as the primary signal with a slow poll fallback.
- */
-export async function waitForPairing(code: string, opts: WaitForPairingOptions = {}): Promise<PairingRecord> {
-  const pollMs = opts.pollMs ?? 1000;
-  const initial = getPairing(code);
-  if (!initial) throw new Error(`Unknown pairing code: ${code}`);
-
-  return new Promise<PairingRecord>((resolve, reject) => {
-    let watcher: fs.FSWatcher | null = null;
-    let interval: NodeJS.Timeout | null = null;
-    let settled = false;
-
-    const cleanup = () => {
-      settled = true;
-      if (watcher)
-        try {
-          watcher.close();
-        } catch {
-          /* ignore */
-        }
-      if (interval) clearInterval(interval);
-    };
-
-    let seenAttempts = 0;
-    const check = () => {
-      if (settled) return;
-      const r = getPairing(code);
-      if (!r) {
-        cleanup();
-        reject(new Error(`Pairing ${code} disappeared`));
-        return;
-      }
-      // Surface any new miss attempts since the last tick. Only fire for
-      // misses — matches are signaled by `status === 'consumed'` below.
-      if (opts.onAttempt && r.attempts) {
-        for (let i = seenAttempts; i < r.attempts.length; i++) {
-          const a = r.attempts[i];
-          if (!a.matched) {
-            try {
-              opts.onAttempt(a);
-            } catch {
-              /* ignore */
-            }
-          }
-        }
-        seenAttempts = r.attempts.length;
-      }
-      if (r.status === 'consumed') {
-        cleanup();
-        resolve(r);
-        return;
-      }
-      if (r.status === 'invalidated') {
-        cleanup();
-        const lastMiss = r.attempts
-          ?.slice()
-          .reverse()
-          .find((a) => !a.matched);
-        reject(new Error(`Pairing ${code} invalidated by wrong code${lastMiss ? ` (${lastMiss.candidate})` : ''}`));
-        return;
-      }
-    };
-
-    try {
-      const dir = path.dirname(storePath());
-      fs.mkdirSync(dir, { recursive: true });
-      watcher = fs.watch(dir, (_event, fname) => {
-        if (!fname || fname.toString().startsWith(path.basename(storePath()))) check();
-      });
-    } catch {
-      // fs.watch unsupported — poll-only is fine
-    }
-    interval = setInterval(check, pollMs);
-    check();
-  });
-}
-
-/** Test helper — wipe the store. */
-export function _resetForTest(): void {
-  try {
-    fs.unlinkSync(storePath());
-  } catch {
-    // ignore
-  }
-}