@openparachute/agent 0.1.2 → 0.2.2

package/src/web/routes/approvals.ts

@@ -1,185 +0,0 @@
-/**
- * /api/approvals — list + decide on pending agent approvals.
- *
- * Surfaces the queue of human-consent-required actions agents have requested
- * (install_packages, add_mcp_server, …). The same queue today is also drained
- * by chat-card responses that come through the channel adapters; this route
- * is a parallel surface that lets the operator approve from the web UI
- * without waiting on a DM round-trip.
- *
- * Filtering: only `status='pending'` rows are listed, and `kind='question'`
- * (inline UX prompts from the interactive module) is excluded — those land
- * in their own card UI surface, not the admin approvals queue.
- *
- * Decide flow: synthesize the same `ResponsePayload` the chat-card path
- * produces and call `handleApprovalsResponse`. That dispatcher updates the
- * row status, deletes it, runs the registered action handler, and notifies
- * the agent — same code path the chat path uses, no behavioural divergence.
- */
-import http from 'node:http';
-
-import { getAgentGroup } from '../../db/agent-groups.js';
-import { getApproval, listPendingApprovals as listPendingApprovalsDb } from '../../db/sessions.js';
-import { handleApprovalsResponse } from '../../modules/approvals/response-handler.js';
-import { log } from '../../log.js';
-import type { ActionApprovalBody, Approval } from '../../types.js';
-import type { HubJwtClaims } from '../auth.js';
-
-interface ApprovalView {
-  id: string;
-  agentGroupId: string;
-  agentGroupName: string | null;
-  kind: string;
-  actionPayload: Record<string, unknown>;
-  status: 'pending' | 'approved' | 'rejected' | 'expired';
-  requestedAt: string;
-  decidedAt: string | null;
-  requestedBy: string;
-}
-
-function approvalToView(approval: Approval): ApprovalView | null {
-  if (!approval.agent_group_id) return null;
-  let agentGroupName: string | null = null;
-  try {
-    const group = getAgentGroup(approval.agent_group_id);
-    if (group) agentGroupName = group.name;
-  } catch {
-    // getAgentGroup throws on missing FK; tolerate it for a graceful list view.
-  }
-
-  const body = approval.body as ActionApprovalBody;
-  const actionPayload = (body.payload ?? {}) as Record<string, unknown>;
-
-  const status =
-    (['pending', 'approved', 'rejected', 'expired'] as const).find((s) => s === approval.status) ?? 'pending';
-
-  return {
-    id: approval.id,
-    agentGroupId: approval.agent_group_id,
-    agentGroupName,
-    kind: approval.kind,
-    actionPayload,
-    status,
-    requestedAt: approval.created_at,
-    decidedAt: approval.decided_at,
-    requestedBy: approval.session_id ?? '',
-  };
-}
-
-function listAdminApprovals(): ApprovalView[] {
-  const rows = listPendingApprovalsDb({ excludeKinds: ['question'] });
-  return rows.flatMap((r) => {
-    const view = approvalToView(r);
-    return view ? [view] : [];
-  });
-}
-
-function getOneApprovalView(approvalId: string): ApprovalView | null {
-  const approval = getApproval(approvalId);
-  if (!approval) return null;
-  if (approval.kind === 'question') return null;
-  return approvalToView(approval);
-}
-
-interface DecideBody {
-  decision?: 'approve' | 'reject';
-}
-
-const json = (res: http.ServerResponse, status: number, body: unknown): void => {
-  res.writeHead(status, { 'content-type': 'application/json' });
-  res.end(JSON.stringify(body));
-};
-
-const error = (res: http.ServerResponse, status: number, message: string): void =>
-  json(res, status, { error: message });
-
-async function readJsonBody<T>(req: http.IncomingMessage): Promise<T> {
-  const chunks: Buffer[] = [];
-  for await (const chunk of req) chunks.push(chunk as Buffer);
-  if (chunks.length === 0) return {} as T;
-  return JSON.parse(Buffer.concat(chunks).toString('utf8')) as T;
-}
-
-export interface ApprovalsRouteContext {
-  pathname: string;
-  method: string;
-  req: http.IncomingMessage;
-  res: http.ServerResponse;
-  /** JWT claims of the requestor — `sub` is recorded as the deciding userId. */
-  claims: HubJwtClaims;
-}
-
-export async function handleApprovalsRoute(ctx: ApprovalsRouteContext): Promise<boolean> {
-  const { pathname, method, req, res, claims } = ctx;
-
-  if (pathname === '/api/approvals' && method === 'GET') {
-    const approvals = listAdminApprovals();
-    json(res, 200, { approvals });
-    return true;
-  }
-
-  // POST /api/approvals/:id/decide
-  const decideMatch = pathname.match(/^\/api\/approvals\/([^/]+)\/decide$/);
-  if (decideMatch && method === 'POST') {
-    const approvalId = decodeURIComponent(decideMatch[1]);
-    let body: DecideBody;
-    try {
-      body = await readJsonBody<DecideBody>(req);
-    } catch {
-      error(res, 400, 'invalid JSON body');
-      return true;
-    }
-    if (body.decision !== 'approve' && body.decision !== 'reject') {
-      error(res, 400, `decision must be 'approve' or 'reject', got: ${String(body.decision)}`);
-      return true;
-    }
-
-    // Check the row exists + is pending before dispatching. handleApprovalsResponse
-    // returns false if the row is missing; we want a clearer 404 + a clearer
-    // 409 if the operator is acting on a row that someone else already decided.
-    const before = getOneApprovalView(approvalId);
-    if (!before) {
-      error(res, 404, `approval not found: ${approvalId}`);
-      return true;
-    }
-    if (before.status !== 'pending') {
-      error(res, 409, `approval already ${before.status}`);
-      return true;
-    }
-
-    // The chat-card path passes the channel/platform/thread of the card
-    // delivery; from the web we synthesize neutral values. The dispatcher
-    // doesn't use them for module-action approvals — it only inspects
-    // questionId + value (+ userId for audit logging).
-    const handled = await handleApprovalsResponse({
-      questionId: approvalId,
-      value: body.decision,
-      userId: claims.sub,
-      channelType: 'web',
-      platformId: 'parachute-agent-web',
-      threadId: null,
-    });
-    if (!handled) {
-      // handleApprovalsResponse only returns false when the row genuinely
-      // doesn't exist — but we already verified it does, so this is a
-      // race with a chat-card decision. Surface it as a 409 to match the
-      // already-decided case.
-      error(res, 409, 'approval was decided by another path before our update landed');
-      return true;
-    }
-    log.info('approval decided via web', { approvalId, decision: body.decision, userId: claims.sub });
-
-    // After a decision the row is deleted by the dispatcher — synthesize
-    // the post-decision view so the UI can update its list without
-    // another round-trip. status reflects the decision; decidedAt is now.
-    const after: ApprovalView = {
-      ...before,
-      status: body.decision === 'approve' ? 'approved' : 'rejected',
-      decidedAt: new Date().toISOString(),
-    };
-    json(res, 200, { approval: after });
-    return true;
-  }
-
-  return false;
-}

package/src/web/routes/apps.ts

@@ -1,434 +0,0 @@
-/**
- * /api/apps — OAuth integrations surface.
- *
- *   GET / PUT / DELETE /api/apps/:provider/config       BYOC client config
- *   POST            /api/apps/:provider/authorize       mint redirect URL
- *   GET             /api/apps/:provider/callback        token exchange
- *   GET             /api/apps                            list connections
- *   GET             /api/apps/:id                        single connection
- *   DELETE          /api/apps/:id                        revoke + delete
- *   GET / PUT       /api/apps/:id/agents                 manage allowlist
- *
- * Encrypted columns (`client_secret`, `access_token`, `refresh_token`)
- * are NEVER returned through any of these endpoints. The view shapes
- * below shape DB rows into camelCase JSON without the secret fields.
- *
- * Operator setup: register `${origin}${mount}/api/apps/<provider>/callback`
- * as an authorized redirect URI in the provider's OAuth client console.
- * `${mount}` is `PARACHUTE_AGENT_WEB_MOUNT` (e.g. `/agent` when fronted by
- * the Parachute hub), empty when parachute-agent serves at the origin root.
- * The origin is derived from `req.headers.host` (or
- * `PARACHUTE_AGENT_WEB_ORIGIN` if set, for tunneled deployments). Legacy
- * `PARACLAW_WEB_*` names accepted through 0.1.x with a one-shot warning.
- */
-import http from 'node:http';
-
-import {
-  type AgentForConnection,
-  countAgentsByConnection,
-  listAgentsForConnection,
-  setAgentsForConnection,
-} from '../../oauth/agent-app-connections.js';
-import {
-  type AppConfigRow,
-  deleteAppConfig,
-  getAppConfig,
-  getAppConfigWithSecret,
-  putAppConfig,
-} from '../../oauth/app-configs.js';
-import {
-  type AppConnectionRow,
-  deleteAppConnection,
-  getAppConnection,
-  getAppConnectionWithTokens,
-  listAppConnections,
-  upsertAppConnection,
-} from '../../oauth/app-connections.js';
-import { buildAuthorizeUrl, exchangeCode, fetchUserinfo, revokeToken } from '../../oauth/flow.js';
-import { getProvider } from '../../oauth/providers/index.js';
-import { consumeState, mintState } from '../../oauth/state-store.js';
-import { log } from '../../log.js';
-import { readEnvWithLegacy } from '../../env.js';
-
-interface AppConfigView {
-  id: string;
-  provider: string;
-  clientId: string;
-  scopesDefault: string;
-  hasSecret: true;
-  createdAt: string;
-  updatedAt: string;
-}
-
-interface AppConnectionView {
-  id: string;
-  provider: string;
-  appConfigId: string;
-  accountEmail: string | null;
-  accountId: string;
-  scopesGranted: string;
-  expiresAt: string | null;
-  label: string;
-  agentGroupCount: number;
-  createdAt: string;
-  updatedAt: string;
-}
-
-interface AgentAssignmentView {
-  agentGroupId: string;
-  agentGroupFolder: string;
-  agentGroupName: string;
-  createdAt: string;
-}
-
-function configToView(r: AppConfigRow): AppConfigView {
-  return {
-    id: r.id,
-    provider: r.provider,
-    clientId: r.client_id,
-    scopesDefault: r.scopes_default,
-    hasSecret: true,
-    createdAt: r.created_at,
-    updatedAt: r.updated_at,
-  };
-}
-
-function connectionToView(r: AppConnectionRow, agentGroupCount: number): AppConnectionView {
-  return {
-    id: r.id,
-    provider: r.provider,
-    appConfigId: r.app_config_id,
-    accountEmail: r.account_email,
-    accountId: r.account_id,
-    scopesGranted: r.scopes_granted,
-    expiresAt: r.expires_at,
-    label: r.label,
-    agentGroupCount,
-    createdAt: r.created_at,
-    updatedAt: r.updated_at,
-  };
-}
-
-function agentToView(r: AgentForConnection): AgentAssignmentView {
-  return {
-    agentGroupId: r.agent_group_id,
-    agentGroupFolder: r.agent_group_folder,
-    agentGroupName: r.agent_group_name,
-    createdAt: r.created_at,
-  };
-}
-
-const json = (res: http.ServerResponse, status: number, body: unknown): void => {
-  res.writeHead(status, { 'content-type': 'application/json' });
-  res.end(JSON.stringify(body));
-};
-
-const error = (res: http.ServerResponse, status: number, message: string): void =>
-  json(res, status, { error: message });
-
-const redirect = (res: http.ServerResponse, location: string): void => {
-  res.writeHead(302, { location });
-  res.end();
-};
-
-async function readJsonBody<T>(req: http.IncomingMessage): Promise<T> {
-  const chunks: Buffer[] = [];
-  for await (const chunk of req) chunks.push(chunk as Buffer);
-  if (chunks.length === 0) return {} as T;
-  return JSON.parse(Buffer.concat(chunks).toString('utf8')) as T;
-}
-
-function originFromReq(req: http.IncomingMessage): string {
-  const env = readEnvWithLegacy('PARACHUTE_AGENT_WEB_ORIGIN', 'PARACLAW_WEB_ORIGIN');
-  if (env) return env.replace(/\/$/, '');
-  const host = req.headers.host ?? 'localhost:1944';
-  const proto = (req.headers['x-forwarded-proto'] as string | undefined) ?? 'http';
-  return `${proto}://${host}`;
-}
-
-function callbackUri(req: http.IncomingMessage, providerSlug: string): string {
-  // Must include PARACHUTE_AGENT_WEB_MOUNT (e.g. `/agent`) when the daemon
-  // is fronted at a path prefix — otherwise the provider redirects the
-  // browser to ${origin}/api/... which 404s on the hub. Authorize +
-  // token-exchange use this same string, so the operator-registered
-  // redirect_uri in the provider console must match.
-  const mount = (readEnvWithLegacy('PARACHUTE_AGENT_WEB_MOUNT', 'PARACLAW_WEB_MOUNT') ?? '').replace(/\/$/, '');
-  return `${originFromReq(req)}${mount}/api/apps/${providerSlug}/callback`;
-}
-
-export interface AppsRouteContext {
-  pathname: string;
-  method: string;
-  url: URL;
-  req: http.IncomingMessage;
-  res: http.ServerResponse;
-}
-
-const CONFIG_RE = /^\/api\/apps\/([^/]+)\/config$/;
-const AUTHORIZE_RE = /^\/api\/apps\/([^/]+)\/authorize$/;
-const CALLBACK_RE = /^\/api\/apps\/([^/]+)\/callback$/;
-const AGENTS_RE = /^\/api\/apps\/([^/]+)\/agents$/;
-const ID_RE = /^\/api\/apps\/([^/]+)$/;
-
-export async function handleAppsRoute(ctx: AppsRouteContext): Promise<boolean> {
-  const { pathname, method, url, req, res } = ctx;
-
-  // List connections (no tokens, no secrets).
-  if (pathname === '/api/apps' && method === 'GET') {
-    const rows = listAppConnections();
-    const counts = countAgentsByConnection();
-    json(res, 200, {
-      connections: rows.map((r) => connectionToView(r, counts.get(r.id) ?? 0)),
-    });
-    return true;
-  }
-
-  const cfgMatch = pathname.match(CONFIG_RE);
-  if (cfgMatch) {
-    const provider = decodeURIComponent(cfgMatch[1]);
-    if (!getProvider(provider)) {
-      error(res, 404, `unknown provider: ${provider}`);
-      return true;
-    }
-    if (method === 'GET') {
-      const row = getAppConfig(provider);
-      if (!row) {
-        error(res, 404, `no config for provider: ${provider}`);
-        return true;
-      }
-      json(res, 200, { config: configToView(row) });
-      return true;
-    }
-    if (method === 'PUT') {
-      let body: { clientId?: string; clientSecret?: string; scopesDefault?: string };
-      try {
-        body = await readJsonBody(req);
-      } catch {
-        error(res, 400, 'invalid JSON body');
-        return true;
-      }
-      const clientId = (body.clientId ?? '').trim();
-      const clientSecret = body.clientSecret ?? '';
-      if (!clientId) {
-        error(res, 400, 'clientId is required');
-        return true;
-      }
-      if (!clientSecret) {
-        error(res, 400, 'clientSecret is required');
-        return true;
-      }
-      putAppConfig(provider, {
-        client_id: clientId,
-        client_secret: clientSecret,
-        scopes_default: body.scopesDefault ?? '',
-      });
-      const row = getAppConfig(provider);
-      if (!row) {
-        error(res, 500, 'config disappeared between write and read');
-        return true;
-      }
-      json(res, 200, { config: configToView(row) });
-      return true;
-    }
-    if (method === 'DELETE') {
-      const ok = deleteAppConfig(provider);
-      if (!ok) {
-        error(res, 404, `no config for provider: ${provider}`);
-        return true;
-      }
-      json(res, 200, { provider, deleted: true });
-      return true;
-    }
-  }
-
-  const authMatch = pathname.match(AUTHORIZE_RE);
-  if (authMatch && method === 'POST') {
-    const providerSlug = decodeURIComponent(authMatch[1]);
-    const provider = getProvider(providerSlug);
-    if (!provider) {
-      error(res, 404, `unknown provider: ${providerSlug}`);
-      return true;
-    }
-    const cfg = getAppConfig(providerSlug);
-    if (!cfg) {
-      error(res, 409, `provider ${providerSlug} has no client config — PUT /api/apps/${providerSlug}/config first`);
-      return true;
-    }
-    let body: { agentGroupId?: string | null; scopes?: string };
-    try {
-      body = await readJsonBody(req);
-    } catch {
-      error(res, 400, 'invalid JSON body');
-      return true;
-    }
-    const redirectUri = callbackUri(req, providerSlug);
-    const state = mintState({
-      provider: providerSlug,
-      agentGroupId: body.agentGroupId ?? null,
-      redirectUri,
-    });
-    const authorizeUrl = buildAuthorizeUrl({
-      provider,
-      clientId: cfg.client_id,
-      scopes: body.scopes || cfg.scopes_default || provider.defaultScopes,
-      state,
-      redirectUri,
-    });
-    json(res, 200, { authorizeUrl, state });
-    return true;
-  }
-
-  const cbMatch = pathname.match(CALLBACK_RE);
-  if (cbMatch && method === 'GET') {
-    const providerSlug = decodeURIComponent(cbMatch[1]);
-    const provider = getProvider(providerSlug);
-    if (!provider) {
-      error(res, 404, `unknown provider: ${providerSlug}`);
-      return true;
-    }
-    const code = url.searchParams.get('code');
-    const state = url.searchParams.get('state');
-    const oauthError = url.searchParams.get('error');
-    if (oauthError) {
-      error(res, 400, `provider returned error: ${oauthError}`);
-      return true;
-    }
-    if (!code || !state) {
-      error(res, 400, 'missing code or state');
-      return true;
-    }
-    const stateCtx = consumeState(state);
-    if (!stateCtx) {
-      error(res, 400, 'invalid or expired state');
-      return true;
-    }
-    if (stateCtx.provider !== providerSlug) {
-      error(res, 400, 'state/provider mismatch');
-      return true;
-    }
-    const cfg = getAppConfigWithSecret(providerSlug);
-    if (!cfg) {
-      error(res, 409, `provider ${providerSlug} has no client config`);
-      return true;
-    }
-    let tokens;
-    try {
-      tokens = await exchangeCode({
-        provider,
-        clientId: cfg.client_id,
-        clientSecret: cfg.client_secret,
-        code,
-        redirectUri: stateCtx.redirectUri,
-      });
-    } catch (err) {
-      error(res, 502, err instanceof Error ? err.message : String(err));
-      return true;
-    }
-    let userinfo: unknown;
-    try {
-      userinfo = await fetchUserinfo({ provider, accessToken: tokens.access_token });
-    } catch (err) {
-      error(res, 502, err instanceof Error ? err.message : String(err));
-      return true;
-    }
-    let extracted;
-    try {
-      extracted = provider.extractAccount(userinfo);
-    } catch (err) {
-      error(res, 502, err instanceof Error ? err.message : String(err));
-      return true;
-    }
-    const expiresAt = tokens.expires_in ? new Date(Date.now() + tokens.expires_in * 1000).toISOString() : null;
-    const connectionId = upsertAppConnection({
-      app_config_id: cfg.id,
-      provider: providerSlug,
-      account_id: extracted.accountId,
-      account_email: extracted.accountEmail,
-      access_token: tokens.access_token,
-      refresh_token: tokens.refresh_token ?? null,
-      scopes_granted: tokens.scope ?? '',
-      expires_at: expiresAt,
-      label: extracted.label,
-      metadata_json: tokens.id_token ? JSON.stringify({ id_token: tokens.id_token }) : null,
-    });
-    if (stateCtx.agentGroupId) {
-      try {
-        const existing = listAgentsForConnection(connectionId).map((a) => a.agent_group_id);
-        if (!existing.includes(stateCtx.agentGroupId)) {
-          setAgentsForConnection(connectionId, [...existing, stateCtx.agentGroupId]);
-        }
-      } catch (err) {
-        log.warn('oauth callback: failed to attach agent', {
-          connectionId,
-          agentGroupId: stateCtx.agentGroupId,
-          err: err instanceof Error ? err.message : String(err),
-        });
-      }
-    }
-    // Redirect back to the SPA. We don't know the SPA's deep-link;
-    // the operator's UI handles `/apps?connected=<id>`. Fall back to
-    // root if the mount-prefix env isn't set.
-    const mount = (readEnvWithLegacy('PARACHUTE_AGENT_WEB_MOUNT', 'PARACLAW_WEB_MOUNT') ?? '').replace(/\/$/, '');
-    redirect(res, `${originFromReq(req)}${mount}/apps?connected=${connectionId}`);
-    return true;
-  }
-
-  const agentsMatch = pathname.match(AGENTS_RE);
-  if (agentsMatch) {
-    const id = decodeURIComponent(agentsMatch[1]);
-    if (!getAppConnection(id)) {
-      error(res, 404, `connection not found: ${id}`);
-      return true;
-    }
-    if (method === 'GET') {
-      json(res, 200, { agents: listAgentsForConnection(id).map(agentToView) });
-      return true;
-    }
-    if (method === 'PUT') {
-      let body: { agentGroupIds?: string[] };
-      try {
-        body = await readJsonBody(req);
-      } catch {
-        error(res, 400, 'invalid JSON body');
-        return true;
-      }
-      if (!Array.isArray(body.agentGroupIds)) {
-        error(res, 400, 'agentGroupIds must be a string[]');
-        return true;
-      }
-      setAgentsForConnection(id, body.agentGroupIds);
-      json(res, 200, { agents: listAgentsForConnection(id).map(agentToView) });
-      return true;
-    }
-  }
-
-  const idMatch = pathname.match(ID_RE);
-  if (idMatch) {
-    const id = decodeURIComponent(idMatch[1]);
-    const row = getAppConnection(id);
-    if (!row) {
-      error(res, 404, `connection not found: ${id}`);
-      return true;
-    }
-    if (method === 'GET') {
-      const counts = countAgentsByConnection();
-      json(res, 200, { connection: connectionToView(row, counts.get(row.id) ?? 0) });
-      return true;
-    }
-    if (method === 'DELETE') {
-      const provider = getProvider(row.provider);
-      if (provider) {
-        const withTokens = getAppConnectionWithTokens(id);
-        if (withTokens) {
-          // Best-effort revocation; never blocks local delete.
-          await revokeToken({ provider, accessToken: withTokens.access_token });
-        }
-      }
-      deleteAppConnection(id);
-      json(res, 200, { id, deleted: true });
-      return true;
-    }
-  }
-
-  return false;
-}