@oneuptime/common 12.0.7 → 12.0.9

package/build/dist/UI/Components/Workflow/RunStatusWatcher.js

@@ -0,0 +1,76 @@
+/*
+ * Pure helpers behind the builder's "what happened to the run I just started"
+ * strip.
+ *
+ * Triggering a run from the builder used to end at a modal saying the workflow
+ * had been scheduled and that the Logs tab would know more. That left the one
+ * question the builder actually has — did it work — to a different page, a
+ * table, and a text blob. The runner does not hand back a log id at enqueue
+ * time (RunWorkflow creates the WorkflowLog itself once it picks the job up),
+ * so the builder watches for the run instead of being told about it.
+ *
+ * The logic that decides when to stop watching lives here, separate from the
+ * page, because it is the part worth testing.
+ */
+import WorkflowStatus from "../../../Types/Workflow/WorkflowStatus";
+/**
+ * Statuses a run never moves on from. Waiting is not one of them — a Sleep
+ * step parks a run for as long as it likes and it carries on afterwards.
+ */
+const TERMINAL_STATUSES = [
+    WorkflowStatus.Success,
+    WorkflowStatus.Error,
+    WorkflowStatus.Timeout,
+    WorkflowStatus.WorkflowCountExceeded,
+];
+export const isTerminalRunStatus = (status) => {
+    if (!status) {
+        return false;
+    }
+    return TERMINAL_STATUSES.includes(status);
+};
+export const isFailedRunStatus = (status) => {
+    return (status === WorkflowStatus.Error ||
+        status === WorkflowStatus.Timeout ||
+        status === WorkflowStatus.WorkflowCountExceeded);
+};
+/*
+ * How long to keep watching. A run that suspends on a Sleep step can outlive
+ * any sensible watch, so the strip stops following it and points at the Logs
+ * tab rather than polling for hours.
+ */
+export const MAX_RUN_WATCH_POLLS = 60;
+export const RUN_WATCH_POLL_INTERVAL_MS = 2000;
+/**
+ * What the strip should say, and whether to keep looking.
+ */
+export const decideRunWatch = (params) => {
+    if (params.pollCount >= MAX_RUN_WATCH_POLLS) {
+        return {
+            shouldContinue: false,
+            message: "This run is taking a while. Open the Logs tab to follow it from there.",
+        };
+    }
+    if (!params.run) {
+        return { shouldContinue: true, message: "Starting run…" };
+    }
+    if (isTerminalRunStatus(params.run.status)) {
+        return {
+            shouldContinue: false,
+            message: isFailedRunStatus(params.run.status)
+                ? `Run ${params.run.status.toLowerCase()}. Open the run log to see why.`
+                : "Run finished successfully.",
+        };
+    }
+    if (params.run.status === WorkflowStatus.Waiting) {
+        return {
+            shouldContinue: false,
+            message: "This run is sleeping and will carry on by itself. Follow it in the Logs tab.",
+        };
+    }
+    return {
+        shouldContinue: true,
+        message: `Run ${params.run.status.toLowerCase()}…`,
+    };
+};
+//# sourceMappingURL=RunStatusWatcher.js.map

package/build/dist/UI/Components/Workflow/RunStatusWatcher.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"RunStatusWatcher.js","sourceRoot":"","sources":["../../../../../UI/Components/Workflow/RunStatusWatcher.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG;AAEH,OAAO,cAAc,MAAM,wCAAwC,CAAC;AAEpE;;;GAGG;AACH,MAAM,iBAAiB,GAA0B;IAC/C,cAAc,CAAC,OAAO;IACtB,cAAc,CAAC,KAAK;IACpB,cAAc,CAAC,OAAO;IACtB,cAAc,CAAC,qBAAqB;CACrC,CAAC;AAMF,MAAM,CAAC,MAAM,mBAAmB,GAAgC,CAC9D,MAAyC,EAChC,EAAE;IACX,IAAI,CAAC,MAAM,EAAE,CAAC;QACZ,OAAO,KAAK,CAAC;IACf,CAAC;IAED,OAAO,iBAAiB,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC;AAC5C,CAAC,CAAC;AAMF,MAAM,CAAC,MAAM,iBAAiB,GAA8B,CAC1D,MAAyC,EAChC,EAAE;IACX,OAAO,CACL,MAAM,KAAK,cAAc,CAAC,KAAK;QAC/B,MAAM,KAAK,cAAc,CAAC,OAAO;QACjC,MAAM,KAAK,cAAc,CAAC,qBAAqB,CAChD,CAAC;AACJ,CAAC,CAAC;AAEF;;;;GAIG;AACH,MAAM,CAAC,MAAM,mBAAmB,GAAW,EAAE,CAAC;AAC9C,MAAM,CAAC,MAAM,0BAA0B,GAAW,IAAI,CAAC;AAmBvD;;GAEG;AACH,MAAM,CAAC,MAAM,cAAc,GAA2B,CAAC,MAGtD,EAAoB,EAAE;IACrB,IAAI,MAAM,CAAC,SAAS,IAAI,mBAAmB,EAAE,CAAC;QAC5C,OAAO;YACL,cAAc,EAAE,KAAK;YACrB,OAAO,EACL,wEAAwE;SAC3E,CAAC;IACJ,CAAC;IAED,IAAI,CAAC,MAAM,CAAC,GAAG,EAAE,CAAC;QAChB,OAAO,EAAE,cAAc,EAAE,IAAI,EAAE,OAAO,EAAE,eAAe,EAAE,CAAC;IAC5D,CAAC;IAED,IAAI,mBAAmB,CAAC,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC;QAC3C,OAAO;YACL,cAAc,EAAE,KAAK;YACrB,OAAO,EAAE,iBAAiB,CAAC,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC;gBAC3C,CAAC,CAAC,OAAO,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,WAAW,EAAE,gCAAgC;gBACxE,CAAC,CAAC,4BAA4B;SACjC,CAAC;IACJ,CAAC;IAED,IAAI,MAAM,CAAC,GAAG,CAAC,MAAM,KAAK,cAAc,CAAC,OAAO,EAAE,CAAC;QACjD,OAAO;YACL,cAAc,EAAE,KAAK;YACrB,OAAO,EACL,8EAA8E;SACjF,CAAC;IACJ,CAAC;IAED,OAAO;QACL,cAAc,EAAE,IAAI;QACpB,OAAO,EAAE,OAAO,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,WAAW,EAAE,GAAG;KACnD,CAAC;AACJ,CAAC,CAAC"}

package/build/dist/UI/Components/Workflow/StepTraceViewer.js

@@ -0,0 +1,76 @@
+/*
+ * A workflow run, read as the list of steps it actually took.
+ *
+ * The raw log is still there and still useful — it carries the component's own
+ * log lines and the warnings the runner emits — but "what did this step
+ * receive, what did it return, and where did it go next" is a question about
+ * structure, and answering it by scanning a newline-joined blob was the whole
+ * problem.
+ */
+import Icon from "../Icon/Icon";
+import IconProp from "../../../Types/Icon/IconProp";
+import { WorkflowStepStatus, } from "../../../Types/Workflow/StepTrace";
+import React, { useState } from "react";
+export const formatStepDuration = (durationInMs) => {
+    if (durationInMs < 1000) {
+        return `${durationInMs}ms`;
+    }
+    if (durationInMs < 60000) {
+        return `${(durationInMs / 1000).toFixed(1)}s`;
+    }
+    const minutes = Math.floor(durationInMs / 60000);
+    const seconds = Math.round((durationInMs % 60000) / 1000);
+    return `${minutes}m ${seconds}s`;
+};
+const ValueBlock = (props) => {
+    const keys = Object.keys(props.values || {});
+    return (React.createElement("div", null,
+        React.createElement("p", { className: "text-[11px] font-semibold uppercase tracking-wider text-gray-500 mb-1" }, props.title),
+        keys.length === 0 ? (React.createElement("p", { className: "text-sm text-gray-400" }, "None")) : (React.createElement("dl", { className: "space-y-1" }, keys.map((key) => {
+            const value = props.values[key];
+            const text = typeof value === "string"
+                ? value
+                : JSON.stringify(value, null, 2);
+            return (React.createElement("div", { key: key, className: "text-sm" },
+                React.createElement("dt", { className: "text-gray-500 font-medium" }, key),
+                React.createElement("dd", { className: "text-gray-800 font-mono text-xs whitespace-pre-wrap break-all" }, text)));
+        })))));
+};
+const StepRow = (props) => {
+    const [isOpen, setIsOpen] = useState(props.step.status === WorkflowStepStatus.Error);
+    const isError = props.step.status === WorkflowStepStatus.Error;
+    return (React.createElement("div", { className: `rounded-md border ${isError ? "border-red-200 bg-red-50" : "border-gray-200 bg-white"}` },
+        React.createElement("button", { type: "button", "aria-expanded": isOpen, className: "w-full text-left p-3 flex items-center gap-3 cursor-pointer", onClick: () => {
+                setIsOpen(!isOpen);
+            } },
+            React.createElement("span", { className: "text-xs text-gray-400 w-5 shrink-0" }, props.index + 1),
+            React.createElement(Icon, { icon: isError ? IconProp.Alert : IconProp.CheckCircle, className: `h-4 w-4 shrink-0 ${isError ? "text-red-500" : "text-green-500"}` }),
+            React.createElement("span", { className: "flex-1 min-w-0" },
+                React.createElement("span", { className: "block text-sm font-medium text-gray-900 truncate" }, props.step.title),
+                React.createElement("span", { className: "block text-xs text-gray-500 truncate" }, props.step.componentId)),
+            React.createElement("span", { className: "text-xs text-gray-500 shrink-0" }, formatStepDuration(props.step.durationInMs)),
+            props.step.executedPort && (React.createElement("span", { className: "text-xs text-gray-500 shrink-0 hidden sm:inline" },
+                "\u2192 ",
+                props.step.executedPort))),
+        isOpen && (React.createElement("div", { className: "border-t border-gray-200 p-3 space-y-3" },
+            props.step.errorMessage && (React.createElement("p", { className: "text-sm text-red-700" }, props.step.errorMessage)),
+            React.createElement(ValueBlock, { title: "Received", values: props.step.argumentValues }),
+            React.createElement(ValueBlock, { title: "Returned", values: props.step.returnValues })))));
+};
+const StepTraceViewer = (props) => {
+    var _a;
+    const steps = ((_a = props.trace) === null || _a === void 0 ? void 0 : _a.steps) || [];
+    if (steps.length === 0) {
+        return (React.createElement("p", { className: "text-sm text-gray-500" }, "This run has no recorded steps. Runs from before step recording was added show only their full log."));
+    }
+    return (React.createElement("div", { className: "space-y-2" },
+        props.trace.truncated && (React.createElement("p", { className: "text-sm text-amber-700" },
+            "Only the last ",
+            steps.length,
+            " steps of this run were kept.")),
+        steps.map((step, index) => {
+            return React.createElement(StepRow, { key: index, step: step, index: index });
+        })));
+};
+export default StepTraceViewer;
+//# sourceMappingURL=StepTraceViewer.js.map

package/build/dist/UI/Components/Workflow/StepTraceViewer.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"StepTraceViewer.js","sourceRoot":"","sources":["../../../../../UI/Components/Workflow/StepTraceViewer.tsx"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAEH,OAAO,IAAI,MAAM,cAAc,CAAC;AAChC,OAAO,QAAQ,MAAM,8BAA8B,CAAC;AAEpD,OAAO,EACL,kBAAkB,GAGnB,MAAM,mCAAmC,CAAC;AAC3C,OAAO,KAAK,EAAE,EAAmC,QAAQ,EAAE,MAAM,OAAO,CAAC;AAQzE,MAAM,CAAC,MAAM,kBAAkB,GAA2B,CACxD,YAAoB,EACZ,EAAE;IACV,IAAI,YAAY,GAAG,IAAI,EAAE,CAAC;QACxB,OAAO,GAAG,YAAY,IAAI,CAAC;IAC7B,CAAC;IAED,IAAI,YAAY,GAAG,KAAK,EAAE,CAAC;QACzB,OAAO,GAAG,CAAC,YAAY,GAAG,IAAI,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,GAAG,CAAC;IAChD,CAAC;IAED,MAAM,OAAO,GAAW,IAAI,CAAC,KAAK,CAAC,YAAY,GAAG,KAAK,CAAC,CAAC;IACzD,MAAM,OAAO,GAAW,IAAI,CAAC,KAAK,CAAC,CAAC,YAAY,GAAG,KAAK,CAAC,GAAG,IAAI,CAAC,CAAC;IAElE,OAAO,GAAG,OAAO,KAAK,OAAO,GAAG,CAAC;AACnC,CAAC,CAAC;AAOF,MAAM,UAAU,GAAuC,CACrD,KAAsB,EACR,EAAE;IAChB,MAAM,IAAI,GAAkB,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC;IAE5D,OAAO,CACL;QACE,2BAAG,SAAS,EAAC,uEAAuE,IACjF,KAAK,CAAC,KAAK,CACV;QACH,IAAI,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,CACnB,2BAAG,SAAS,EAAC,uBAAuB,WAAS,CAC9C,CAAC,CAAC,CAAC,CACF,4BAAI,SAAS,EAAC,WAAW,IACtB,IAAI,CAAC,GAAG,CAAC,CAAC,GAAW,EAAE,EAAE;YACxB,MAAM,KAAK,GAAY,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;YACzC,MAAM,IAAI,GACR,OAAO,KAAK,KAAK,QAAQ;gBACvB,CAAC,CAAC,KAAK;gBACP,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC;YAErC,OAAO,CACL,6BAAK,GAAG,EAAE,GAAG,EAAE,SAAS,EAAC,SAAS;gBAChC,4BAAI,SAAS,EAAC,2BAA2B,IAAE,GAAG,CAAM;gBACpD,4BAAI,SAAS,EAAC,+DAA+D,IAC1E,IAAI,CACF,CACD,CACP,CAAC;QACJ,CAAC,CAAC,CACC,CACN,CACG,CACP,CAAC;AACJ,CAAC,CAAC;AAOF,MAAM,OAAO,GAAoC,CAC/C,KAAmB,EACL,EAAE;IAChB,MAAM,CAAC,MAAM,EAAE,SAAS,CAAC,GAAG,QAAQ,CAClC,KAAK,CAAC,IAAI,CAAC,MAAM,KAAK,kBAAkB,CAAC,KAAK,CAC/C,CAAC;IAEF,MAAM,OAAO,GAAY,KAAK,CAAC,IAAI,CAAC,MAAM,KAAK,kBAAkB,CAAC,KAAK,CAAC;IAExE,OAAO,CACL,6BACE,SAAS,EAAE,qBACT,OAAO,CAAC,CAAC,CAAC,0BAA0B,CAAC,CAAC,CAAC,0BACzC,EAAE;QAEF,gCACE,IAAI,EAAC,QAAQ,mBACE,MAAM,EACrB,SAAS,EAAC,6DAA6D,EACvE,OAAO,EAAE,GAAG,EAAE;gBACZ,SAAS,CAAC,CAAC,MAAM,CAAC,CAAC;YACrB,CAAC;YAED,8BAAM,SAAS,EAAC,oCAAoC,IACjD,KAAK,CAAC,KAAK,GAAG,CAAC,CACX;YAEP,oBAAC,IAAI,IACH,IAAI,EAAE,OAAO,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,QAAQ,CAAC,WAAW,EACrD,SAAS,EAAE,oBACT,OAAO,CAAC,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC,gBAC7B,EAAE,GACF;YAEF,8BAAM,SAAS,EAAC,gBAAgB;gBAC9B,8BAAM,SAAS,EAAC,kDAAkD,IAC/D,KAAK,CAAC,IAAI,CAAC,KAAK,CACZ;gBACP,8BAAM,SAAS,EAAC,sCAAsC,IACnD,KAAK,CAAC,IAAI,CAAC,WAAW,CAClB,CACF;YAEP,8BAAM,SAAS,EAAC,gCAAgC,IAC7C,kBAAkB,CAAC,KAAK,CAAC,IAAI,CAAC,YAAY,CAAC,CACvC;YAEN,KAAK,CAAC,IAAI,CAAC,YAAY,IAAI,CAC1B,8BAAM,SAAS,EAAC,iDAAiD;;gBAC5D,KAAK,CAAC,IAAI,CAAC,YAAY,CACrB,CACR,CACM;QAER,MAAM,IAAI,CACT,6BAAK,SAAS,EAAC,wCAAwC;YACpD,KAAK,CAAC,IAAI,CAAC,YAAY,IAAI,CAC1B,2BAAG,SAAS,EAAC,sBAAsB,IAAE,KAAK,CAAC,IAAI,CAAC,YAAY,CAAK,CAClE;YACD,oBAAC,UAAU,IAAC,KAAK,EAAC,UAAU,EAAC,MAAM,EAAE,KAAK,CAAC,IAAI,CAAC,cAAc,GAAI;YAClE,oBAAC,UAAU,IAAC,KAAK,EAAC,UAAU,EAAC,MAAM,EAAE,KAAK,CAAC,IAAI,CAAC,YAAY,GAAI,CAC5D,CACP,CACG,CACP,CAAC;AACJ,CAAC,CAAC;AAEF,MAAM,eAAe,GAAsC,CACzD,KAAqB,EACP,EAAE;;IAChB,MAAM,KAAK,GAAkC,CAAA,MAAA,KAAK,CAAC,KAAK,0CAAE,KAAK,KAAI,EAAE,CAAC;IAEtE,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACvB,OAAO,CACL,2BAAG,SAAS,EAAC,uBAAuB,0GAGhC,CACL,CAAC;IACJ,CAAC;IAED,OAAO,CACL,6BAAK,SAAS,EAAC,WAAW;QACvB,KAAK,CAAC,KAAK,CAAC,SAAS,IAAI,CACxB,2BAAG,SAAS,EAAC,wBAAwB;;YACpB,KAAK,CAAC,MAAM;4CACzB,CACL;QAEA,KAAK,CAAC,GAAG,CAAC,CAAC,IAA4B,EAAE,KAAa,EAAE,EAAE;YACzD,OAAO,oBAAC,OAAO,IAAC,GAAG,EAAE,KAAK,EAAE,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,KAAK,GAAI,CAAC;QAC3D,CAAC,CAAC,CACE,CACP,CAAC;AACJ,CAAC,CAAC;AAEF,eAAe,eAAe,CAAC"}

package/build/dist/UI/Components/Workflow/UseRunWatch.js

@@ -0,0 +1,123 @@
+/*
+ * Following the run the builder just started, until it settles.
+ *
+ * RunStatusWatcher decides what to say and when to stop; this is the part that
+ * holds a timer, a generation counter and the run's log, and it lives here
+ * rather than in the page so it can be exercised through a real component
+ * lifecycle. Fetching is injected: the page knows how to ask the API for a
+ * run, and the hook only cares that asking returns one.
+ */
+import { RUN_WATCH_POLL_INTERVAL_MS, decideRunWatch, isFailedRunStatus, } from "./RunStatusWatcher";
+import { emptyTrace, } from "../../../Types/Workflow/StepTrace";
+import { useEffect, useRef, useState } from "react";
+const useRunWatch = (params) => {
+    const [message, setMessage] = useState(null);
+    const [hasFailed, setHasFailed] = useState(false);
+    const [isWatching, setIsWatching] = useState(false);
+    const [logs, setLogs] = useState("");
+    const [stepTrace, setStepTrace] = useState(emptyTrace());
+    /*
+     * The page rebuilds its fetch function on every render. Reading it through a
+     * ref keeps a poll that is already in flight from being pinned to the
+     * function it started with.
+     */
+    const fetchLatestRun = useRef(params.fetchLatestRun);
+    useEffect(() => {
+        fetchLatestRun.current = params.fetchLatestRun;
+    }, [params.fetchLatestRun]);
+    const pollTimer = useRef(null);
+    const runIdBeforeTrigger = useRef(null);
+    /*
+     * Which watch a poll belongs to. A poll is a pending promise, so starting a
+     * second run while the first is mid-request leaves that request in flight —
+     * it comes back, and without this would report on the wrong run and schedule
+     * a second chain of timers alongside the new one.
+     */
+    const watchGeneration = useRef(0);
+    const isMounted = useRef(true);
+    useEffect(() => {
+        isMounted.current = true;
+        return () => {
+            isMounted.current = false;
+            if (pollTimer.current) {
+                clearTimeout(pollTimer.current);
+                pollTimer.current = null;
+            }
+        };
+    }, []);
+    const pollRun = async (pollCount, generation) => {
+        let run = null;
+        try {
+            run = await fetchLatestRun.current();
+        }
+        catch (_a) {
+            /*
+             * A failed poll is not a failed run. Keep watching — the next poll may
+             * well succeed, and the Logs tab is the fallback either way.
+             */
+            run = null;
+        }
+        // This watch was replaced or the page went away while we were asking.
+        if (!isMounted.current || generation !== watchGeneration.current) {
+            return;
+        }
+        // Not our run yet: the worker has not created its log.
+        if (run && run.runId === runIdBeforeTrigger.current) {
+            run = null;
+        }
+        if (run) {
+            setLogs(run.logs);
+            setStepTrace(run.stepTrace);
+        }
+        const decision = decideRunWatch({
+            run: run,
+            pollCount: pollCount,
+        });
+        setMessage(decision.message);
+        setHasFailed(isFailedRunStatus(run === null || run === void 0 ? void 0 : run.status));
+        if (!decision.shouldContinue) {
+            setIsWatching(false);
+            return;
+        }
+        pollTimer.current = setTimeout(() => {
+            void pollRun(pollCount + 1, generation);
+        }, RUN_WATCH_POLL_INTERVAL_MS);
+    };
+    const captureRunBeforeTrigger = async () => {
+        try {
+            const existing = await fetchLatestRun.current();
+            runIdBeforeTrigger.current = existing ? existing.runId : null;
+        }
+        catch (_a) {
+            /*
+             * Without a baseline the first run we see counts as ours. That is the
+             * kinder failure: showing the previous run beats showing nothing.
+             */
+            runIdBeforeTrigger.current = null;
+        }
+    };
+    const startWatchingRun = () => {
+        if (pollTimer.current) {
+            clearTimeout(pollTimer.current);
+            pollTimer.current = null;
+        }
+        watchGeneration.current = watchGeneration.current + 1;
+        setHasFailed(false);
+        setMessage("Starting run…");
+        setLogs("");
+        setStepTrace(emptyTrace());
+        setIsWatching(true);
+        void pollRun(0, watchGeneration.current);
+    };
+    return {
+        message: message,
+        hasFailed: hasFailed,
+        isWatching: isWatching,
+        logs: logs,
+        stepTrace: stepTrace,
+        captureRunBeforeTrigger: captureRunBeforeTrigger,
+        startWatchingRun: startWatchingRun,
+    };
+};
+export default useRunWatch;
+//# sourceMappingURL=UseRunWatch.js.map

package/build/dist/UI/Components/Workflow/UseRunWatch.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"UseRunWatch.js","sourceRoot":"","sources":["../../../../../UI/Components/Workflow/UseRunWatch.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAEH,OAAO,EACL,0BAA0B,EAG1B,cAAc,EACd,iBAAiB,GAClB,MAAM,oBAAoB,CAAC;AAC5B,OAAO,EAEL,UAAU,GACX,MAAM,mCAAmC,CAAC;AAC3C,OAAc,EAAE,SAAS,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,OAAO,CAAC;AAyC3D,MAAM,WAAW,GAAwB,CACvC,MAAyB,EACN,EAAE;IACrB,MAAM,CAAC,OAAO,EAAE,UAAU,CAAC,GAAG,QAAQ,CAAgB,IAAI,CAAC,CAAC;IAC5D,MAAM,CAAC,SAAS,EAAE,YAAY,CAAC,GAAG,QAAQ,CAAU,KAAK,CAAC,CAAC;IAC3D,MAAM,CAAC,UAAU,EAAE,aAAa,CAAC,GAAG,QAAQ,CAAU,KAAK,CAAC,CAAC;IAC7D,MAAM,CAAC,IAAI,EAAE,OAAO,CAAC,GAAG,QAAQ,CAAS,EAAE,CAAC,CAAC;IAC7C,MAAM,CAAC,SAAS,EAAE,YAAY,CAAC,GAAG,QAAQ,CAAoB,UAAU,EAAE,CAAC,CAAC;IAE5E;;;;OAIG;IACH,MAAM,cAAc,GAClB,MAAM,CAAyB,MAAM,CAAC,cAAc,CAAC,CAAC;IAExD,SAAS,CAAC,GAAG,EAAE;QACb,cAAc,CAAC,OAAO,GAAG,MAAM,CAAC,cAAc,CAAC;IACjD,CAAC,EAAE,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,CAAC;IAE5B,MAAM,SAAS,GAEH,MAAM,CAAuC,IAAI,CAAC,CAAC;IAE/D,MAAM,kBAAkB,GAA0C,MAAM,CAEtE,IAAI,CAAC,CAAC;IAER;;;;;OAKG;IACH,MAAM,eAAe,GAAmC,MAAM,CAAS,CAAC,CAAC,CAAC;IAE1E,MAAM,SAAS,GAAoC,MAAM,CAAU,IAAI,CAAC,CAAC;IAEzE,SAAS,CAAC,GAAG,EAAE;QACb,SAAS,CAAC,OAAO,GAAG,IAAI,CAAC;QAEzB,OAAO,GAAG,EAAE;YACV,SAAS,CAAC,OAAO,GAAG,KAAK,CAAC;YAE1B,IAAI,SAAS,CAAC,OAAO,EAAE,CAAC;gBACtB,YAAY,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC;gBAChC,SAAS,CAAC,OAAO,GAAG,IAAI,CAAC;YAC3B,CAAC;QACH,CAAC,CAAC;IACJ,CAAC,EAAE,EAAE,CAAC,CAAC;IAOP,MAAM,OAAO,GAAoB,KAAK,EACpC,SAAiB,EACjB,UAAkB,EACH,EAAE;QACjB,IAAI,GAAG,GAA4B,IAAI,CAAC;QAExC,IAAI,CAAC;YACH,GAAG,GAAG,MAAM,cAAc,CAAC,OAAO,EAAE,CAAC;QACvC,CAAC;QAAC,WAAM,CAAC;YACP;;;eAGG;YACH,GAAG,GAAG,IAAI,CAAC;QACb,CAAC;QAED,sEAAsE;QACtE,IAAI,CAAC,SAAS,CAAC,OAAO,IAAI,UAAU,KAAK,eAAe,CAAC,OAAO,EAAE,CAAC;YACjE,OAAO;QACT,CAAC;QAED,uDAAuD;QACvD,IAAI,GAAG,IAAI,GAAG,CAAC,KAAK,KAAK,kBAAkB,CAAC,OAAO,EAAE,CAAC;YACpD,GAAG,GAAG,IAAI,CAAC;QACb,CAAC;QAED,IAAI,GAAG,EAAE,CAAC;YACR,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;YAClB,YAAY,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;QAC9B,CAAC;QAED,MAAM,QAAQ,GAAqB,cAAc,CAAC;YAChD,GAAG,EAAE,GAAG;YACR,SAAS,EAAE,SAAS;SACrB,CAAC,CAAC;QAEH,UAAU,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC;QAC7B,YAAY,CAAC,iBAAiB,CAAC,GAAG,aAAH,GAAG,uBAAH,GAAG,CAAE,MAAM,CAAC,CAAC,CAAC;QAE7C,IAAI,CAAC,QAAQ,CAAC,cAAc,EAAE,CAAC;YAC7B,aAAa,CAAC,KAAK,CAAC,CAAC;YACrB,OAAO;QACT,CAAC;QAED,SAAS,CAAC,OAAO,GAAG,UAAU,CAAC,GAAG,EAAE;YAClC,KAAK,OAAO,CAAC,SAAS,GAAG,CAAC,EAAE,UAAU,CAAC,CAAC;QAC1C,CAAC,EAAE,0BAA0B,CAAC,CAAC;IACjC,CAAC,CAAC;IAEF,MAAM,uBAAuB,GAC3B,KAAK,IAAmB,EAAE;QACxB,IAAI,CAAC;YACH,MAAM,QAAQ,GACZ,MAAM,cAAc,CAAC,OAAO,EAAE,CAAC;YACjC,kBAAkB,CAAC,OAAO,GAAG,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,CAAC;QAChE,CAAC;QAAC,WAAM,CAAC;YACP;;;eAGG;YACH,kBAAkB,CAAC,OAAO,GAAG,IAAI,CAAC;QACpC,CAAC;IACH,CAAC,CAAC;IAEJ,MAAM,gBAAgB,GAAe,GAAS,EAAE;QAC9C,IAAI,SAAS,CAAC,OAAO,EAAE,CAAC;YACtB,YAAY,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC;YAChC,SAAS,CAAC,OAAO,GAAG,IAAI,CAAC;QAC3B,CAAC;QAED,eAAe,CAAC,OAAO,GAAG,eAAe,CAAC,OAAO,GAAG,CAAC,CAAC;QAEtD,YAAY,CAAC,KAAK,CAAC,CAAC;QACpB,UAAU,CAAC,eAAe,CAAC,CAAC;QAC5B,OAAO,CAAC,EAAE,CAAC,CAAC;QACZ,YAAY,CAAC,UAAU,EAAE,CAAC,CAAC;QAC3B,aAAa,CAAC,IAAI,CAAC,CAAC;QAEpB,KAAK,OAAO,CAAC,CAAC,EAAE,eAAe,CAAC,OAAO,CAAC,CAAC;IAC3C,CAAC,CAAC;IAEF,OAAO;QACL,OAAO,EAAE,OAAO;QAChB,SAAS,EAAE,SAAS;QACpB,UAAU,EAAE,UAAU;QACtB,IAAI,EAAE,IAAI;QACV,SAAS,EAAE,SAAS;QACpB,uBAAuB,EAAE,uBAAuB;QAChD,gBAAgB,EAAE,gBAAgB;KACnC,CAAC;AACJ,CAAC,CAAC;AAEF,eAAe,WAAW,CAAC"}

package/build/dist/UI/Components/Workflow/Utils.js

@@ -1,5 +1,6 @@
 import FormFieldSchemaType from "../Forms/Types/FormFieldSchemaType";
 import IconProp from "../../../Types/Icon/IconProp";
+import JSONFunctions from "../../../Types/JSONFunctions";
 import { ComponentInputType, } from "../../../Types/Workflow/Component";
 import Components, { Categories } from "../../../Types/Workflow/Components";
 import BaseModelComponentFactory from "../../../Types/Workflow/Components/BaseModel";
@@ -19,6 +20,63 @@ export const loadComponentsAndCategories = () => {
     }
     return { components: initComponents, categories: initCategories };
 };
+/**
+ * The key/value view of a StringDictionary argument, or null when the value
+ * cannot be shown that way and belongs in the JSON editor instead.
+ *
+ * Editable as rows:
+ *   - nothing yet (a new component)
+ *   - an object of primitives, whether stored as an object (written by the row
+ *     editor) or as a JSON string (written by the old JSON editor, and by
+ *     every workflow that already exists)
+ *
+ * Not editable as rows, so left in the JSON editor:
+ *   - a whole-field template such as {{local.components.x.returnValues.headers}},
+ *     which substitutes an entire object at run time and is not JSON as written
+ *   - text that does not parse, which is exactly the case where the builder
+ *     most needs to see and fix what they typed
+ *   - nested objects or arrays, which the row editor cannot represent and would
+ *     therefore quietly discard
+ */
+export const parseStringDictionaryValue = (argValue) => {
+    if (argValue === null || argValue === undefined || argValue === "") {
+        return {};
+    }
+    let candidate = argValue;
+    if (typeof candidate === "string") {
+        if (candidate.trim() === "") {
+            return {};
+        }
+        /*
+         * JSONFunctions.parse is JSON5, which is what the components themselves use
+         * on these values (ApiComponentUtils.sanitizeArgs). Parsing more strictly
+         * here than the runtime does would push a value that works today into the
+         * JSON editor for no reason.
+         */
+        try {
+            candidate = JSONFunctions.parse(candidate);
+        }
+        catch (_a) {
+            return null;
+        }
+    }
+    if (typeof candidate !== "object" ||
+        candidate === null ||
+        Array.isArray(candidate)) {
+        return null;
+    }
+    const entries = candidate;
+    for (const key of Object.keys(entries)) {
+        const value = entries[key];
+        const isPrimitive = typeof value === "string" ||
+            typeof value === "number" ||
+            typeof value === "boolean";
+        if (!isPrimitive) {
+            return null;
+        }
+    }
+    return entries;
+};
 export const componentInputTypeToFormFieldType = (componentInputType, argValue) => {
     // first priority.
     if (componentInputType === ComponentInputType.BaseModel) {
@@ -61,9 +119,23 @@ export const componentInputTypeToFormFieldType = (componentInputType, argValue)
             fieldType: FormFieldSchemaType.JSON,
         };
     }
+    /*
+     * A dictionary of strings is a list of key/value pairs — request headers,
+     * query params — and asking someone to hand-write the braces and commas
+     * for that is where a good share of workflow JSON mistakes come from. Give
+     * it the key/value row editor instead.
+     *
+     * Values written before this change are JSON strings, and a value can also
+     * be something the row editor cannot represent (a whole-field
+     * {{...}} substitution, or nested objects). parseStringDictionaryValue
+     * decides; anything it cannot represent stays in the JSON editor, so no
+     * existing value is ever silently dropped on the floor.
+     */
     if (componentInputType === ComponentInputType.StringDictionary) {
         return {
-            fieldType: FormFieldSchemaType.JSON,
+            fieldType: parseStringDictionaryValue(argValue) === null
+                ? FormFieldSchemaType.JSON
+                : FormFieldSchemaType.Dictionary,
         };
     }
     if (componentInputType === ComponentInputType.LongText) {

package/build/dist/UI/Components/Workflow/Utils.js.map

@@ -1 +1 @@
-{"version":3,"file":"Utils.js","sourceRoot":"","sources":["../../../../../UI/Components/Workflow/Utils.ts"],"names":[],"mappings":"AACA,OAAO,mBAAmB,MAAM,oCAAoC,CAAC;AACrE,OAAO,QAAQ,MAAM,8BAA8B,CAAC;AACpD,OAA0B,EAExB,kBAAkB,GACnB,MAAM,mCAAmC,CAAC;AAC3C,OAAO,UAAU,EAAE,EAAE,UAAU,EAAE,MAAM,oCAAoC,CAAC;AAC5E,OAAO,yBAAyB,MAAM,8CAA8C,CAAC;AACrF,OAAO,QAAQ,MAAM,sCAAsC,CAAC;AAC5D,OAAO,EACL,iBAAiB,EACjB,kBAAkB,GACnB,MAAM,8CAA8C,CAAC;AAOtD,MAAM,CAAC,MAAM,2BAA2B,GACtC,GAGE,EAAE;IACF,IAAI,cAAc,GAA6B,EAAE,CAAC;IAClD,MAAM,cAAc,GAA6B,CAAC,GAAG,UAAU,CAAC,CAAC;IAEjE,cAAc,GAAG,cAAc,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC;IAEnD,KAAK,MAAM,KAAK,IAAI,QAAQ,EAAE,CAAC;QAC7B,cAAc,GAAG,cAAc,CAAC,MAAM,CACpC,yBAAyB,CAAC,aAAa,CAAC,IAAI,KAAK,EAAE,CAAC,CACrD,CAAC;QACF,cAAc,CAAC,IAAI,CAAC;YAClB,IAAI,EAAE,IAAI,KAAK,EAAE,CAAC,YAAY,IAAI,OAAO;YACzC,WAAW,EAAE,iBACX,IAAI,KAAK,EAAE,CAAC,YACd,oBAAoB;YACpB,IAAI,EAAE,IAAI,KAAK,EAAE,CAAC,IAAI,IAAI,QAAQ,CAAC,QAAQ;SAC5C,CAAC,CAAC;IACL,CAAC;IAED,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,UAAU,EAAE,cAAc,EAAE,CAAC;AACpE,CAAC,CAAC;AAUJ,MAAM,CAAC,MAAM,iCAAiC,GAC5C,CACE,kBAAsC,EACtC,QAAiB,EAIjB,EAAE;IACF,kBAAkB;IAElB,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,SAAS,EAAE,CAAC;QACxD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,cAAc,EAAE,CAAC;QAC7D,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,IAAI,EAAE,CAAC;QACnD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,SAAS,EAAE,CAAC;QACxD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,QAAQ,EAAE,CAAC;QACvD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;SACxC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,UAAU,EAAE,CAAC;QACzD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,UAAU;SAC1C,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,KAAK,EAAE,CAAC;QACpD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,MAAM,EAAE,CAAC;QACrD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,gBAAgB,EAAE,CAAC;QAC/D,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,QAAQ,EAAE,CAAC;QACvD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;SACxC,CAAC;IACJ,CAAC;IAED,mBAAmB;IAEnB,IAAI,OAAO,QAAQ,KAAK,QAAQ,IAAI,QAAQ,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC;QAC5D,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;YACnC,eAAe,EAAE,EAAE;SACpB,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,OAAO,EAAE,CAAC;QACtD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,MAAM;YACrC,eAAe,EAAE,EAAE;SACpB,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,IAAI,EAAE,CAAC;QACnD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;YACnC,eAAe,EAAE,EAAE;SACpB,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,OAAO,EAAE,CAAC;QACtD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;YACvC,eAAe,EAAE;gBACf;oBACE,KAAK,EAAE,cAAc;oBACrB,KAAK,EAAE,WAAW;iBACnB;gBACD;oBACE,KAAK,EAAE,kBAAkB;oBACzB,KAAK,EAAE,cAAc;iBACtB;gBACD;oBACE,KAAK,EAAE,YAAY;oBACnB,KAAK,EAAE,WAAW;iBACnB;gBACD;oBACE,KAAK,EAAE,WAAW;oBAClB,KAAK,EAAE,WAAW;iBACnB;gBACD;oBACE,KAAK,EAAE,YAAY;oBACnB,KAAK,EAAE,WAAW;iBACnB;gBACD;oBACE,KAAK,EAAE,aAAa;oBACpB,KAAK,EAAE,WAAW;iBACnB;gBACD;oBACE,KAAK,EAAE,oBAAoB;oBAC3B,KAAK,EAAE,aAAa;iBACrB;gBACD;oBACE,KAAK,EAAE,kBAAkB;oBACzB,KAAK,EAAE,aAAa;iBACrB;aACF;SACF,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,QAAQ,EAAE,CAAC;QACvD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;YACvC,eAAe,EAAE;gBACf;oBACE,KAAK,EAAE,UAAU;oBACjB,KAAK,EAAE,iBAAiB,CAAC,OAAO;iBACjC;gBACD;oBACE,KAAK,EAAE,cAAc;oBACrB,KAAK,EAAE,iBAAiB,CAAC,UAAU;iBACpC;gBACD;oBACE,KAAK,EAAE,cAAc;oBACrB,KAAK,EAAE,iBAAiB,CAAC,WAAW;iBACrC;gBACD;oBACE,KAAK,EAAE,WAAW;oBAClB,KAAK,EAAE,iBAAiB,CAAC,QAAQ;iBAClC;gBACD;oBACE,KAAK,EAAE,uBAAuB;oBAC9B,KAAK,EAAE,iBAAiB,CAAC,oBAAoB;iBAC9C;gBACD;oBACE,KAAK,EAAE,oBAAoB;oBAC3B,KAAK,EAAE,iBAAiB,CAAC,iBAAiB;iBAC3C;gBACD;oBACE,KAAK,EAAE,UAAU;oBACjB,KAAK,EAAE,iBAAiB,CAAC,QAAQ;iBAClC;gBACD;oBACE,KAAK,EAAE,kBAAkB;oBACzB,KAAK,EAAE,iBAAiB,CAAC,cAAc;iBACxC;gBACD;oBACE,KAAK,EAAE,aAAa;oBACpB,KAAK,EAAE,iBAAiB,CAAC,UAAU;iBACpC;gBACD;oBACE,KAAK,EAAE,WAAW;oBAClB,KAAK,EAAE,iBAAiB,CAAC,QAAQ;iBAClC;aACF;SACF,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,cAAc,EAAE,CAAC;QAC7D;;;WAGG;QACH,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;YACvC,eAAe,EAAE,EAAE;SACpB,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,SAAS,EAAE,CAAC;QACxD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;YACvC,eAAe,EAAE;gBACf;oBACE,KAAK,EAAE,MAAM;oBACb,KAAK,EAAE,kBAAkB,CAAC,IAAI;iBAC/B;gBACD;oBACE,KAAK,EAAE,SAAS;oBAChB,KAAK,EAAE,kBAAkB,CAAC,OAAO;iBAClC;gBACD;oBACE,KAAK,EAAE,QAAQ;oBACf,KAAK,EAAE,kBAAkB,CAAC,MAAM;iBACjC;gBACD;oBACE,KAAK,EAAE,MAAM;oBACb,KAAK,EAAE,kBAAkB,CAAC,IAAI;iBAC/B;gBACD;oBACE,KAAK,EAAE,WAAW;oBAClB,KAAK,EAAE,kBAAkB,CAAC,SAAS;iBACpC;aACF;SACF,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,IAAI,EAAE,CAAC;QACnD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,QAAQ,EAAE,CAAC;QACvD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;SACxC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,OAAO,EAAE,CAAC;QACtD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,MAAM;SACtC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,KAAK,EAAE,CAAC;QACpD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,KAAK;SACrC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,MAAM,EAAE,CAAC;QACrD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,MAAM;SACtC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,QAAQ,EAAE,CAAC;QACvD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;SACxC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,GAAG,EAAE,CAAC;QAClD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,GAAG;SACnC,CAAC;IACJ,CAAC;IAED,OAAO;QACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;QACnC,eAAe,EAAE,EAAE;KACpB,CAAC;AACJ,CAAC,CAAC"}
+{"version":3,"file":"Utils.js","sourceRoot":"","sources":["../../../../../UI/Components/Workflow/Utils.ts"],"names":[],"mappings":"AACA,OAAO,mBAAmB,MAAM,oCAAoC,CAAC;AACrE,OAAO,QAAQ,MAAM,8BAA8B,CAAC;AAEpD,OAAO,aAAa,MAAM,8BAA8B,CAAC;AACzD,OAA0B,EAExB,kBAAkB,GACnB,MAAM,mCAAmC,CAAC;AAC3C,OAAO,UAAU,EAAE,EAAE,UAAU,EAAE,MAAM,oCAAoC,CAAC;AAC5E,OAAO,yBAAyB,MAAM,8CAA8C,CAAC;AACrF,OAAO,QAAQ,MAAM,sCAAsC,CAAC;AAC5D,OAAO,EACL,iBAAiB,EACjB,kBAAkB,GACnB,MAAM,8CAA8C,CAAC;AAOtD,MAAM,CAAC,MAAM,2BAA2B,GACtC,GAGE,EAAE;IACF,IAAI,cAAc,GAA6B,EAAE,CAAC;IAClD,MAAM,cAAc,GAA6B,CAAC,GAAG,UAAU,CAAC,CAAC;IAEjE,cAAc,GAAG,cAAc,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC;IAEnD,KAAK,MAAM,KAAK,IAAI,QAAQ,EAAE,CAAC;QAC7B,cAAc,GAAG,cAAc,CAAC,MAAM,CACpC,yBAAyB,CAAC,aAAa,CAAC,IAAI,KAAK,EAAE,CAAC,CACrD,CAAC;QACF,cAAc,CAAC,IAAI,CAAC;YAClB,IAAI,EAAE,IAAI,KAAK,EAAE,CAAC,YAAY,IAAI,OAAO;YACzC,WAAW,EAAE,iBACX,IAAI,KAAK,EAAE,CAAC,YACd,oBAAoB;YACpB,IAAI,EAAE,IAAI,KAAK,EAAE,CAAC,IAAI,IAAI,QAAQ,CAAC,QAAQ;SAC5C,CAAC,CAAC;IACL,CAAC;IAED,OAAO,EAAE,UAAU,EAAE,cAAc,EAAE,UAAU,EAAE,cAAc,EAAE,CAAC;AACpE,CAAC,CAAC;AAMJ;;;;;;;;;;;;;;;;;GAiBG;AACH,MAAM,CAAC,MAAM,0BAA0B,GAAuC,CAC5E,QAAiB,EACE,EAAE;IACrB,IAAI,QAAQ,KAAK,IAAI,IAAI,QAAQ,KAAK,SAAS,IAAI,QAAQ,KAAK,EAAE,EAAE,CAAC;QACnE,OAAO,EAAE,CAAC;IACZ,CAAC;IAED,IAAI,SAAS,GAAY,QAAQ,CAAC;IAElC,IAAI,OAAO,SAAS,KAAK,QAAQ,EAAE,CAAC;QAClC,IAAI,SAAS,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE,CAAC;YAC5B,OAAO,EAAE,CAAC;QACZ,CAAC;QAED;;;;;WAKG;QACH,IAAI,CAAC;YACH,SAAS,GAAG,aAAa,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC;QAC7C,CAAC;QAAC,WAAM,CAAC;YACP,OAAO,IAAI,CAAC;QACd,CAAC;IACH,CAAC;IAED,IACE,OAAO,SAAS,KAAK,QAAQ;QAC7B,SAAS,KAAK,IAAI;QAClB,KAAK,CAAC,OAAO,CAAC,SAAS,CAAC,EACxB,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IAED,MAAM,OAAO,GAAe,SAAuB,CAAC;IAEpD,KAAK,MAAM,GAAG,IAAI,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC;QACvC,MAAM,KAAK,GAAY,OAAO,CAAC,GAAG,CAAC,CAAC;QAEpC,MAAM,WAAW,GACf,OAAO,KAAK,KAAK,QAAQ;YACzB,OAAO,KAAK,KAAK,QAAQ;YACzB,OAAO,KAAK,KAAK,SAAS,CAAC;QAE7B,IAAI,CAAC,WAAW,EAAE,CAAC;YACjB,OAAO,IAAI,CAAC;QACd,CAAC;IACH,CAAC;IAED,OAAO,OAAO,CAAC;AACjB,CAAC,CAAC;AAUF,MAAM,CAAC,MAAM,iCAAiC,GAC5C,CACE,kBAAsC,EACtC,QAAiB,EAIjB,EAAE;IACF,kBAAkB;IAElB,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,SAAS,EAAE,CAAC;QACxD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,cAAc,EAAE,CAAC;QAC7D,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,IAAI,EAAE,CAAC;QACnD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,SAAS,EAAE,CAAC;QACxD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,QAAQ,EAAE,CAAC;QACvD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;SACxC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,UAAU,EAAE,CAAC;QACzD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,UAAU;SAC1C,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,KAAK,EAAE,CAAC;QACpD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,MAAM,EAAE,CAAC;QACrD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED;;;;;;;;;;;OAWG;IACH,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,gBAAgB,EAAE,CAAC;QAC/D,OAAO;YACL,SAAS,EACP,0BAA0B,CAAC,QAAQ,CAAC,KAAK,IAAI;gBAC3C,CAAC,CAAC,mBAAmB,CAAC,IAAI;gBAC1B,CAAC,CAAC,mBAAmB,CAAC,UAAU;SACrC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,QAAQ,EAAE,CAAC;QACvD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;SACxC,CAAC;IACJ,CAAC;IAED,mBAAmB;IAEnB,IAAI,OAAO,QAAQ,KAAK,QAAQ,IAAI,QAAQ,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC;QAC5D,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;YACnC,eAAe,EAAE,EAAE;SACpB,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,OAAO,EAAE,CAAC;QACtD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,MAAM;YACrC,eAAe,EAAE,EAAE;SACpB,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,IAAI,EAAE,CAAC;QACnD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;YACnC,eAAe,EAAE,EAAE;SACpB,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,OAAO,EAAE,CAAC;QACtD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;YACvC,eAAe,EAAE;gBACf;oBACE,KAAK,EAAE,cAAc;oBACrB,KAAK,EAAE,WAAW;iBACnB;gBACD;oBACE,KAAK,EAAE,kBAAkB;oBACzB,KAAK,EAAE,cAAc;iBACtB;gBACD;oBACE,KAAK,EAAE,YAAY;oBACnB,KAAK,EAAE,WAAW;iBACnB;gBACD;oBACE,KAAK,EAAE,WAAW;oBAClB,KAAK,EAAE,WAAW;iBACnB;gBACD;oBACE,KAAK,EAAE,YAAY;oBACnB,KAAK,EAAE,WAAW;iBACnB;gBACD;oBACE,KAAK,EAAE,aAAa;oBACpB,KAAK,EAAE,WAAW;iBACnB;gBACD;oBACE,KAAK,EAAE,oBAAoB;oBAC3B,KAAK,EAAE,aAAa;iBACrB;gBACD;oBACE,KAAK,EAAE,kBAAkB;oBACzB,KAAK,EAAE,aAAa;iBACrB;aACF;SACF,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,QAAQ,EAAE,CAAC;QACvD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;YACvC,eAAe,EAAE;gBACf;oBACE,KAAK,EAAE,UAAU;oBACjB,KAAK,EAAE,iBAAiB,CAAC,OAAO;iBACjC;gBACD;oBACE,KAAK,EAAE,cAAc;oBACrB,KAAK,EAAE,iBAAiB,CAAC,UAAU;iBACpC;gBACD;oBACE,KAAK,EAAE,cAAc;oBACrB,KAAK,EAAE,iBAAiB,CAAC,WAAW;iBACrC;gBACD;oBACE,KAAK,EAAE,WAAW;oBAClB,KAAK,EAAE,iBAAiB,CAAC,QAAQ;iBAClC;gBACD;oBACE,KAAK,EAAE,uBAAuB;oBAC9B,KAAK,EAAE,iBAAiB,CAAC,oBAAoB;iBAC9C;gBACD;oBACE,KAAK,EAAE,oBAAoB;oBAC3B,KAAK,EAAE,iBAAiB,CAAC,iBAAiB;iBAC3C;gBACD;oBACE,KAAK,EAAE,UAAU;oBACjB,KAAK,EAAE,iBAAiB,CAAC,QAAQ;iBAClC;gBACD;oBACE,KAAK,EAAE,kBAAkB;oBACzB,KAAK,EAAE,iBAAiB,CAAC,cAAc;iBACxC;gBACD;oBACE,KAAK,EAAE,aAAa;oBACpB,KAAK,EAAE,iBAAiB,CAAC,UAAU;iBACpC;gBACD;oBACE,KAAK,EAAE,WAAW;oBAClB,KAAK,EAAE,iBAAiB,CAAC,QAAQ;iBAClC;aACF;SACF,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,cAAc,EAAE,CAAC;QAC7D;;;WAGG;QACH,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;YACvC,eAAe,EAAE,EAAE;SACpB,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,SAAS,EAAE,CAAC;QACxD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;YACvC,eAAe,EAAE;gBACf;oBACE,KAAK,EAAE,MAAM;oBACb,KAAK,EAAE,kBAAkB,CAAC,IAAI;iBAC/B;gBACD;oBACE,KAAK,EAAE,SAAS;oBAChB,KAAK,EAAE,kBAAkB,CAAC,OAAO;iBAClC;gBACD;oBACE,KAAK,EAAE,QAAQ;oBACf,KAAK,EAAE,kBAAkB,CAAC,MAAM;iBACjC;gBACD;oBACE,KAAK,EAAE,MAAM;oBACb,KAAK,EAAE,kBAAkB,CAAC,IAAI;iBAC/B;gBACD;oBACE,KAAK,EAAE,WAAW;oBAClB,KAAK,EAAE,kBAAkB,CAAC,SAAS;iBACpC;aACF;SACF,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,IAAI,EAAE,CAAC;QACnD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;SACpC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,QAAQ,EAAE,CAAC;QACvD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;SACxC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,OAAO,EAAE,CAAC;QACtD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,MAAM;SACtC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,KAAK,EAAE,CAAC;QACpD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,KAAK;SACrC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,MAAM,EAAE,CAAC;QACrD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,MAAM;SACtC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,QAAQ,EAAE,CAAC;QACvD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,QAAQ;SACxC,CAAC;IACJ,CAAC;IAED,IAAI,kBAAkB,KAAK,kBAAkB,CAAC,GAAG,EAAE,CAAC;QAClD,OAAO;YACL,SAAS,EAAE,mBAAmB,CAAC,GAAG;SACnC,CAAC;IACJ,CAAC;IAED,OAAO;QACL,SAAS,EAAE,mBAAmB,CAAC,IAAI;QACnC,eAAe,EAAE,EAAE;KACpB,CAAC;AACJ,CAAC,CAAC"}

package/build/dist/UI/Components/Workflow/VariableModal.js

@@ -1,6 +1,7 @@
 import ModelListModal from "../ModelListModal/ModelListModal";
 import EqualToOrNull from "../../../Types/BaseDatabase/EqualToOrNull";
 import WorkflowVariable from "../../../Models/DatabaseModels/WorkflowVariable";
+import { globalVariableReference, variableReference, } from "../../../Types/Workflow/TemplateSyntax";
 import React from "react";
 const VariableModal = (props) => {
     return (React.createElement(ModelListModal, { modalTitle: "Select a variable", query: {
@@ -19,10 +20,10 @@ const VariableModal = (props) => {
         }, onClose: props.onClose, onSave: (variables) => {
             var _a, _b, _c;
             if ((_a = variables[0]) === null || _a === void 0 ? void 0 : _a.workflowId) {
-                props.onSave(`{{local.variables.${(_b = variables[0]) === null || _b === void 0 ? void 0 : _b.name}}}`);
+                props.onSave(variableReference(((_b = variables[0]) === null || _b === void 0 ? void 0 : _b.name) || ""));
             }
             else {
-                props.onSave(`{{global.variables.${(_c = variables[0]) === null || _c === void 0 ? void 0 : _c.name}}}`);
+                props.onSave(globalVariableReference(((_c = variables[0]) === null || _c === void 0 ? void 0 : _c.name) || ""));
             }
         } }));
 };

package/build/dist/UI/Components/Workflow/VariableModal.js.map

@@ -1 +1 @@
-{"version":3,"file":"VariableModal.js","sourceRoot":"","sources":["../../../../../UI/Components/Workflow/VariableModal.tsx"],"names":[],"mappings":"AAAA,OAAO,cAAc,MAAM,kCAAkC,CAAC;AAC9D,OAAO,aAAa,MAAM,2CAA2C,CAAC;AAEtE,OAAO,gBAAgB,MAAM,iDAAiD,CAAC;AAC/E,OAAO,KAA0C,MAAM,OAAO,CAAC;AAQ/D,MAAM,aAAa,GAAsC,CACvD,KAAqB,EACP,EAAE;IAChB,OAAO,CACL,oBAAC,cAAc,IACb,UAAU,EAAC,mBAAmB,EAC9B,KAAK,EAAE;YACL,UAAU,EAAE,IAAI,aAAa,CAAC,KAAK,CAAC,UAAU,CAAC,QAAQ,EAAE,CAAC;SAC3D,EACD,eAAe,EAAE,IAAI,EACrB,cAAc,EAAC,qEAAqE,EACpF,gBAAgB,EAAC,wDAAwD,EACzE,UAAU,EAAC,MAAM,EACjB,gBAAgB,EAAC,aAAa,EAC9B,WAAW,EAAE,CAAC,IAAsB,EAAE,EAAE;YACtC,IAAI,YAAY,GAAW,iBAAiB,CAAC;YAE7C,IAAI,IAAI,CAAC,UAAU,EAAE,CAAC;gBACpB,YAAY,GAAG,yBAAyB,CAAC;YAC3C,CAAC;YAED,OAAO,2BAAG,SAAS,EAAC,4BAA4B,IAAE,YAAY,CAAK,CAAC;QACtE,CAAC,EACD,SAAS,EAAE,gBAAgB,EAC3B,MAAM,EAAE;YACN,GAAG,EAAE,IAAI;YACT,IAAI,EAAE,IAAI;YACV,WAAW,EAAE,IAAI;YACjB,UAAU,EAAE,IAAI;SACjB,EACD,OAAO,EAAE,KAAK,CAAC,OAAO,EACtB,MAAM,EAAE,CAAC,SAAkC,EAAE,EAAE;;YAC7C,IAAI,MAAA,SAAS,CAAC,CAAC,CAAC,0CAAE,UAAU,EAAE,CAAC;gBAC7B,KAAK,CAAC,MAAM,CAAC,qBAAqB,MAAA,SAAS,CAAC,CAAC,CAAC,0CAAE,IAAI,IAAI,CAAC,CAAC;YAC5D,CAAC;iBAAM,CAAC;gBACN,KAAK,CAAC,MAAM,CAAC,sBAAsB,MAAA,SAAS,CAAC,CAAC,CAAC,0CAAE,IAAI,IAAI,CAAC,CAAC;YAC7D,CAAC;QACH,CAAC,GACD,CACH,CAAC;AACJ,CAAC,CAAC;AAEF,eAAe,aAAa,CAAC"}
+{"version":3,"file":"VariableModal.js","sourceRoot":"","sources":["../../../../../UI/Components/Workflow/VariableModal.tsx"],"names":[],"mappings":"AAAA,OAAO,cAAc,MAAM,kCAAkC,CAAC;AAC9D,OAAO,aAAa,MAAM,2CAA2C,CAAC;AAEtE,OAAO,gBAAgB,MAAM,iDAAiD,CAAC;AAC/E,OAAO,EACL,uBAAuB,EACvB,iBAAiB,GAClB,MAAM,wCAAwC,CAAC;AAChD,OAAO,KAA0C,MAAM,OAAO,CAAC;AAQ/D,MAAM,aAAa,GAAsC,CACvD,KAAqB,EACP,EAAE;IAChB,OAAO,CACL,oBAAC,cAAc,IACb,UAAU,EAAC,mBAAmB,EAC9B,KAAK,EAAE;YACL,UAAU,EAAE,IAAI,aAAa,CAAC,KAAK,CAAC,UAAU,CAAC,QAAQ,EAAE,CAAC;SAC3D,EACD,eAAe,EAAE,IAAI,EACrB,cAAc,EAAC,qEAAqE,EACpF,gBAAgB,EAAC,wDAAwD,EACzE,UAAU,EAAC,MAAM,EACjB,gBAAgB,EAAC,aAAa,EAC9B,WAAW,EAAE,CAAC,IAAsB,EAAE,EAAE;YACtC,IAAI,YAAY,GAAW,iBAAiB,CAAC;YAE7C,IAAI,IAAI,CAAC,UAAU,EAAE,CAAC;gBACpB,YAAY,GAAG,yBAAyB,CAAC;YAC3C,CAAC;YAED,OAAO,2BAAG,SAAS,EAAC,4BAA4B,IAAE,YAAY,CAAK,CAAC;QACtE,CAAC,EACD,SAAS,EAAE,gBAAgB,EAC3B,MAAM,EAAE;YACN,GAAG,EAAE,IAAI;YACT,IAAI,EAAE,IAAI;YACV,WAAW,EAAE,IAAI;YACjB,UAAU,EAAE,IAAI;SACjB,EACD,OAAO,EAAE,KAAK,CAAC,OAAO,EACtB,MAAM,EAAE,CAAC,SAAkC,EAAE,EAAE;;YAC7C,IAAI,MAAA,SAAS,CAAC,CAAC,CAAC,0CAAE,UAAU,EAAE,CAAC;gBAC7B,KAAK,CAAC,MAAM,CAAC,iBAAiB,CAAC,CAAA,MAAA,SAAS,CAAC,CAAC,CAAC,0CAAE,IAAI,KAAI,EAAE,CAAC,CAAC,CAAC;YAC5D,CAAC;iBAAM,CAAC;gBACN,KAAK,CAAC,MAAM,CAAC,uBAAuB,CAAC,CAAA,MAAA,SAAS,CAAC,CAAC,CAAC,0CAAE,IAAI,KAAI,EAAE,CAAC,CAAC,CAAC;YAClE,CAAC;QACH,CAAC,GACD,CACH,CAAC;AACJ,CAAC,CAAC;AAEF,eAAe,aAAa,CAAC"}

package/build/dist/UI/Components/Workflow/Workflow.js

@@ -2,11 +2,13 @@ import WorkflowComponent from "./Component";
 import ComponentSettingsModal from "./ComponentSettingsModal";
 import ComponentsModal from "./ComponentsModal";
 import RunModal from "./RunModal";
+import { lintWorkflowGraph, } from "./GraphLint";
+import { findStepNodeToOpen } from "./GraphLintSummary";
 import { loadComponentsAndCategories } from "./Utils";
 import IconProp from "../../../Types/Icon/IconProp";
 import ObjectID from "../../../Types/ObjectID";
 import { ComponentType, NodeType, } from "../../../Types/Workflow/Component";
-import React, { useCallback, useEffect, useRef, useState, } from "react";
+import React, { useCallback, useEffect, useMemo, useRef, useState, } from "react";
 import ReactFlow, { Background, BackgroundVariant, Controls, MarkerType, MiniMap, addEdge, getConnectedEdges, updateEdge, useEdgesState, useNodesState, } from "reactflow";
 // 👇 you need to import the reactflow styles
 import "reactflow/dist/style.css";
@@ -146,6 +148,56 @@ const Workflow = (props) => {
             props.onWorkflowUpdated(nodes, edges);
         }
     }, [nodes, edges]);
+    /*
+     * Static checks over the graph, recomputed as it is edited.
+     *
+     * The results are deliberately NOT written back into node state. Node data is
+     * what gets persisted (Builder.saveGraph sends node.data verbatim, minus
+     * metadata), so storing lint output there would save today's warnings into
+     * the workflow itself and show them again on reload even once they were
+     * fixed. Deriving a separate array for rendering keeps the saved graph clean.
+     */
+    const lintResult = useMemo(() => {
+        return lintWorkflowGraph({
+            nodes: nodes,
+            edges: edges,
+        });
+    }, [nodes, edges]);
+    useEffect(() => {
+        var _a;
+        (_a = props.onLintResultChange) === null || _a === void 0 ? void 0 : _a.call(props, lintResult);
+    }, [lintResult]);
+    /*
+     * Opening a step from outside the canvas — the issues panel naming the node
+     * it is complaining about. A node that has since been deleted simply opens
+     * nothing; the request is still acknowledged so the page does not sit
+     * waiting for a step that no longer exists.
+     */
+    useEffect(() => {
+        var _a;
+        if (!props.openStepForNodeId) {
+            return;
+        }
+        const nodeToOpen = findStepNodeToOpen({
+            nodes: nodes,
+            nodeId: props.openStepForNodeId,
+        });
+        if (nodeToOpen) {
+            setSelectedNodeData(nodeToOpen.data);
+            setShowComponentSettingsModal(true);
+        }
+        (_a = props.onStepOpened) === null || _a === void 0 ? void 0 : _a.call(props);
+    }, [props.openStepForNodeId]);
+    const nodesToRender = useMemo(() => {
+        return nodes.map((node) => {
+            const error = lintResult.errorsByNodeId[node.id] || "";
+            // Same object when there is nothing to say, so react-flow can bail early.
+            if (!error && !node.data.error) {
+                return node;
+            }
+            return Object.assign(Object.assign({}, node), { data: Object.assign(Object.assign({}, node.data), { error: error }) });
+        });
+    }, [nodes, lintResult]);
     const proOptions = { hideAttribution: true };
     const onConnect = useCallback((params) => {
         return setEdges((eds) => {
@@ -309,7 +361,7 @@ const Workflow = (props) => {
             stroke-dasharray: 5 5 !important;
           }
         `),
-        React.createElement(ReactFlow, { nodes: nodes, edges: edges, fitView: true, onEdgeClick: () => {
+        React.createElement(ReactFlow, { nodes: nodesToRender, edges: edges, fitView: true, onEdgeClick: () => {
                 refreshEdges();
             }, onNodeClick: () => {
                 refreshEdges();
@@ -349,22 +401,55 @@ const Workflow = (props) => {
                 setShowTriggersModal(false);
                 addToGraph(component);
             } })),
-        showComponentSettingsModal && selectedNodeData && (React.createElement(ComponentSettingsModal, { graphComponents: nodes.map((node) => {
+        showComponentSettingsModal && selectedNodeData && (React.createElement(ComponentSettingsModal
+        /*
+         * Placeholder nodes are excluded here rather than defended against
+         * downstream. The "click here to add trigger" node carries a partial
+         * metadata object — no returnValues, no arguments, an empty id — and
+         * passing it on made every consumer responsible for knowing that.
+         */
+        , { 
+            /*
+             * Placeholder nodes are excluded here rather than defended against
+             * downstream. The "click here to add trigger" node carries a partial
+             * metadata object — no returnValues, no arguments, an empty id — and
+             * passing it on made every consumer responsible for knowing that.
+             */
+            graphComponents: nodes
+                .map((node) => {
                 return node.data;
+            })
+                .filter((data) => {
+                return data.nodeType !== NodeType.PlaceholderNode;
             }), workflowId: props.workflowId, webhookSecretKey: props.webhookSecretKey, component: selectedNodeData, title: selectedNodeData && selectedNodeData.metadata.title
                 ? selectedNodeData.metadata.title
                 : "Component Properties", onDelete: (component) => {
                 deleteNode(component.id);
-            }, description: selectedNodeData && selectedNodeData.metadata.description
+            }, 
+            /*
+             * Triggers have nothing to run on their own — they are the thing
+             * that starts a run, so "run just this step" is meaningless for one.
+             */
+            onRunStep: props.onRunStep &&
+                selectedNodeData.componentType !== ComponentType.Trigger
+                ? props.onRunStep
+                : undefined, description: selectedNodeData && selectedNodeData.metadata.description
                 ? selectedNodeData.metadata.description
                 : "Edit Component Properties and variables here.", onClose: () => {
                 setShowComponentSettingsModal(false);
             }, onSave: (componentData) => {
-                // Update the node.
+                /*
+                 * The settings modal was opened from the rendered node, so what
+                 * comes back carries whatever lint message was on it. Clear that
+                 * before it reaches node state — state is what gets saved, and a
+                 * message about today's mistake has no business being written into
+                 * the workflow.
+                 */
+                const dataToStore = Object.assign(Object.assign({}, componentData), { error: "" });
                 setNodes((nds) => {
                     return nds.map((n) => {
-                        if (n.data.internalId === componentData.internalId) {
-                            n.data = componentData;
+                        if (n.data.internalId === dataToStore.internalId) {
+                            n.data = dataToStore;
                         }
                         return n;
                     });