@oneuptime/common 12.0.34 → 13.0.1

package/Tests/Server/Utils/Monitor/MonitorCriteriaMessageBuilderUnits.test.ts

@@ -116,9 +116,9 @@ describe("MonitorCriteriaMessageBuilder — metric unit labelling", () => {
       });
 
     // Observed value carries the unit.
-    expect(message).toContain("latest 0.06 sec");
-    expect(message).toContain("min 0.06 sec");
-    expect(message).toContain("max 0.06 sec");
+    expect(message).toContain("latest 60 ms");
+    expect(message).toContain("min 60 ms");
+    expect(message).toContain("max 60 ms");
     // Threshold in the expectation clause carries the same unit.
     expect(message).toContain("greater than 5 sec");
   });
@@ -150,11 +150,20 @@ describe("MonitorCriteriaMessageBuilder — metric unit labelling", () => {
         matchMessage: null,
       });
 
-    expect(message).toContain("latest 0.50 sec");
+    expect(message).toContain("latest 500 ms");
     expect(message).toContain("greater than 2 sec");
   });
 
-  test("omits the unit for dimensionless ratio metrics (native unit '1')", () => {
+  /*
+   * A ratio metric carries OTel's dimensionless "1" over samples that are
+   * fractions in [0, 1]. Printing "0.06 1" is meaningless and printing a
+   * bare "0.06" reads as 0.06% when the value is 6%.
+   *
+   * The fired-alert email has rendered this as "6.00%" since CompareCriteria
+   * adopted MetricValueFormatter; this line — the monitor's own evaluation
+   * log for the SAME sample — used to say "0.06". Both now agree.
+   */
+  test("renders a dimensionless ratio metric as the percentage it means", () => {
     const criteriaFilter: CriteriaFilter = {
       checkOn: CheckOn.MetricValue,
       filterType: FilterType.GreaterThan,
@@ -179,12 +188,50 @@ describe("MonitorCriteriaMessageBuilder — metric unit labelling", () => {
         matchMessage: null,
       });
 
-    expect(message).toContain("latest 0.06");
-    // No stray "0.06 1" and no unit on the threshold.
+    expect(message).toContain("latest 6.00%");
+    // Never the dimensionless marker, and never the unscaled fraction.
     expect(message).not.toContain("0.06 1");
-    expect(message).toContain("greater than 0.9");
+    expect(message).not.toContain("latest 0.06");
+    // The threshold is scaled the same way, so the two halves agree.
+    expect(message).toContain("greater than 90.00%");
     expect(message).not.toContain("greater than 0.9 1");
   });
+
+  /*
+   * The control for the rule above: "1" is only a percentage when the
+   * metric NAME says the value is a fraction. A counter carrying "1" —
+   * cumulative layout shift is the canonical one — keeps its bare number.
+   */
+  test("a non-fraction metric carrying '1' keeps its bare number", () => {
+    const criteriaFilter: CriteriaFilter = {
+      checkOn: CheckOn.MetricValue,
+      filterType: FilterType.GreaterThan,
+      value: "0.25",
+      metricMonitorOptions: {
+        metricAlias: "a",
+        metricAggregationType: EvaluateOverTimeType.Average,
+      },
+    };
+
+    const inputs: ReturnType<typeof buildInputs> = buildInputs({
+      metricNativeUnit: "1",
+      metricName: "browser.cumulative_layout_shift",
+      sampleValues: [0.31],
+      criteriaFilter,
+    });
+
+    const message: string =
+      MonitorCriteriaMessageBuilder.buildCriteriaFilterMessage({
+        ...inputs,
+        didMeetCriteria: false,
+        matchMessage: null,
+      });
+
+    expect(message).toContain("latest 0.31");
+    expect(message).not.toContain("0.31 1");
+    expect(message).not.toContain("31.00%");
+    expect(message).toContain("greater than 0.25");
+  });
 });
 
 /*
@@ -221,7 +268,7 @@ describe("MonitorCriteriaMessageBuilder.buildCriteriaFilterMessage — Evaluatio
       });
 
     expect(message).toBe(
-      "Metric Value (a) recorded latest 0.06 sec (min 0.06 sec, max 0.06 sec) across 3 data points. (expected to be greater than 5 sec using average).",
+      "Metric Value (a) recorded latest 60 ms (min 60 ms, max 60 ms) across 3 data points. (expected to be greater than 5 sec using average).",
     );
   });
 
@@ -251,10 +298,10 @@ describe("MonitorCriteriaMessageBuilder.buildCriteriaFilterMessage — Evaluatio
       });
 
     expect(message).toBe(
-      "Metric Value (a) recorded latest 10.00 sec (min 8.00 sec, max 12.00 sec) across 3 data points. (expected to be less than 5 sec using average).",
+      "Metric Value (a) recorded latest 10 sec (min 8 sec, max 12 sec) across 3 data points. (expected to be less than 5 sec using average).",
     );
     // The unit rides both the observed value and the "less than N unit" clause.
-    expect(message).toContain("latest 10.00 sec");
+    expect(message).toContain("latest 10 sec");
     expect(message).toContain("less than 5 sec");
   });
 
@@ -286,7 +333,7 @@ describe("MonitorCriteriaMessageBuilder.buildCriteriaFilterMessage — Evaluatio
       });
 
     expect(message).toBe(
-      "Metric Value (a) recorded latest 3.50 sec (min 1.50 sec, max 3.50 sec) across 3 data points. (expected to be greater than 2 sec using maximum value).",
+      "Metric Value (a) recorded latest 3.5 sec (min 1.5 sec, max 3.5 sec) across 3 data points. (expected to be greater than 2 sec using maximum value).",
     );
     // The raw ms magnitudes never leak into the rendered line.
     expect(message).not.toContain("1500");
@@ -329,14 +376,14 @@ describe("MonitorCriteriaMessageBuilder.buildCriteriaFilterMessage — Evaluatio
      * observed value and the threshold, even though "1.00" appears in the text.
      */
     expect(message).toBe(
-      "Metric Value (a) recorded latest 1.00 (min 0.95, max 1.00) across 3 data points. (expected to be greater than 0.9 using average).",
+      "Metric Value (a) recorded latest 100.00% (min 95.00%, max 100.00%) across 3 data points. (expected to be greater than 90.00% using average).",
     );
     /*
      * Neither the value nor the threshold carries a unit: each number is
      * immediately followed by punctuation/wording, never a " 1" unit suffix.
      */
-    expect(message).toContain("latest 1.00 (min 0.95, max 1.00)");
-    expect(message).toContain("greater than 0.9 using average");
+    expect(message).toContain("latest 100.00% (min 95.00%, max 100.00%)");
+    expect(message).toContain("greater than 90.00% using average");
   });
 
   /*
@@ -375,11 +422,11 @@ describe("MonitorCriteriaMessageBuilder.buildCriteriaFilterMessage — Evaluatio
       });
 
     expect(message).toBe(
-      "Metric Value (a) recorded latest 6.00 % across 1 data point. (expected to be greater than 90 % using average).",
+      "Metric Value (a) recorded latest 6.00% across 1 data point. (expected to be greater than 90.00% using average).",
     );
     // Both the converted observed value and the threshold carry the "%" unit.
-    expect(message).toContain("latest 6.00 %");
-    expect(message).toContain("greater than 90 %");
+    expect(message).toContain("latest 6.00%");
+    expect(message).toContain("greater than 90.00%");
     // The raw fraction magnitude never leaks into the rendered line.
     expect(message).not.toContain("0.06");
     // Singular grammar for the lone sample — no "(min .., max ..)" clause.
@@ -488,7 +535,7 @@ describe("MonitorCriteriaMessageBuilder.buildCriteriaFilterMessage — Evaluatio
       });
 
     expect(message).toBe(
-      "Metric Value (a) recorded latest 7.00 sec across 1 data point. (expected to be greater than 5 sec using average).",
+      "Metric Value (a) recorded latest 7 sec across 1 data point. (expected to be greater than 5 sec using average).",
     );
     // Singular grammar, and no "(min .., max ..)" clause for a lone sample.
     expect(message).toContain("across 1 data point.");
@@ -522,7 +569,7 @@ describe("MonitorCriteriaMessageBuilder.buildCriteriaFilterMessage — Evaluatio
       });
 
     expect(message).toBe(
-      "Metric Value (a) recorded latest 100.00 ms (min 100.00 ms, max 100.00 ms) across 3 data points. (expected to equal 100 ms using average).",
+      "Metric Value (a) recorded latest 100 ms (min 100 ms, max 100 ms) across 3 data points. (expected to equal 100 ms using average).",
     );
   });
 
@@ -552,7 +599,7 @@ describe("MonitorCriteriaMessageBuilder.buildCriteriaFilterMessage — Evaluatio
       });
 
     expect(message).toBe(
-      "Metric Value (a) recorded latest 70.00 ms (min 55.00 ms, max 70.00 ms) across 3 data points. (expected to be greater than or equal to 50 ms using maximum value).",
+      "Metric Value (a) recorded latest 70 ms (min 55 ms, max 70 ms) across 3 data points. (expected to be greater than or equal to 50 ms using maximum value).",
     );
   });
 

package/Tests/Server/Utils/Monitor/MonitorCriteriaObservationBuilderUnits.test.ts

@@ -318,7 +318,7 @@ describe("MonitorCriteriaObservationBuilder.describeFilterObservation — metric
       MonitorCriteriaObservationBuilder.describeFilterObservation(inputs);
 
     expect(observation).toBe(
-      "Metric Value (a) recorded latest 0.06 sec (min 0.06 sec, max 0.06 sec) across 3 data points.",
+      "Metric Value (a) recorded latest 60 ms (min 60 ms, max 60 ms) across 3 data points.",
     );
   });
 
@@ -339,7 +339,7 @@ describe("MonitorCriteriaObservationBuilder.describeFilterObservation — metric
       MonitorCriteriaObservationBuilder.describeFilterObservation(inputs);
 
     expect(observation).toBe(
-      "Metric Value (a) recorded latest 60.00 ms (min 40.00 ms, max 60.00 ms) across 2 data points.",
+      "Metric Value (a) recorded latest 60 ms (min 40 ms, max 60 ms) across 2 data points.",
     );
   });
 
@@ -364,9 +364,9 @@ describe("MonitorCriteriaObservationBuilder.describeFilterObservation — metric
       MonitorCriteriaObservationBuilder.describeFilterObservation(inputs);
 
     expect(observation).toBe(
-      "Metric Value (a) recorded latest 2.50 sec across 1 data point.",
+      "Metric Value (a) recorded latest 2.5 sec across 1 data point.",
     );
-    expect(observation).toContain("2.50 sec");
+    expect(observation).toContain("2.5 sec");
   });
 
   /*
@@ -389,9 +389,9 @@ describe("MonitorCriteriaObservationBuilder.describeFilterObservation — metric
       MonitorCriteriaObservationBuilder.describeFilterObservation(inputs);
 
     expect(observation).toBe(
-      "Metric Value (a) recorded latest 2.50 GB across 1 data point.",
+      "Metric Value (a) recorded latest 2.5 GB across 1 data point.",
     );
-    expect(observation).toContain("2.50 GB");
+    expect(observation).toContain("2.5 GB");
   });
 
   /*
@@ -413,13 +413,30 @@ describe("MonitorCriteriaObservationBuilder.describeFilterObservation — metric
     const observation: string | null =
       MonitorCriteriaObservationBuilder.describeFilterObservation(inputs);
 
+    /*
+     * The user mislabelled a millisecond metric as megabytes. The
+     * conversion still no-ops — ms and MB are different families — so the
+     * SAMPLE is untouched at 5000, and the renderer then takes the label
+     * at its word and reads 5000 MB out as "5 GB". Every string this
+     * sentence can produce is wrong, because the configuration is; what
+     * this test pins is that the mislabelling is passed through rather
+     * than silently repaired.
+     */
     expect(observation).toBe(
-      "Metric Value (a) recorded latest 5000.00 MB across 1 data point.",
+      "Metric Value (a) recorded latest 5 GB across 1 data point.",
     );
-    // Unconverted value passed through.
-    expect(observation).toContain("5000.00");
-    // But labelled with the (incompatible) threshold unit.
-    expect(observation).toContain("MB");
+    expect(observation).toContain("5 GB");
+    /*
+     * Still reported in the threshold unit's FAMILY — the label the user
+     * chose won, which is the behaviour this test guards. It reads "GB"
+     * rather than "MB" only because the ladder rescales within that family;
+     * the alternative would be to drop the user's unit when it looks
+     * incompatible, which would hide the misconfiguration entirely.
+     */
+    expect(observation).not.toContain("ms");
+    expect(
+      MonitorCriteriaObservationBuilder.getMetricValueDisplayUnit(inputs),
+    ).toBe("MB");
   });
 
   /*
@@ -486,7 +503,7 @@ describe("MonitorCriteriaObservationBuilder.describeFilterObservation — metric
       MonitorCriteriaObservationBuilder.describeFilterObservation(inputs);
 
     expect(observation).toBe(
-      "Metric Value (a) recorded latest 60.00 ms (min 40.00 ms, max 60.00 ms) across 2 data points.",
+      "Metric Value (a) recorded latest 60 ms (min 40 ms, max 60 ms) across 2 data points.",
     );
   });
 
@@ -532,7 +549,7 @@ describe("MonitorCriteriaObservationBuilder.describeFilterObservation — metric
       MonitorCriteriaObservationBuilder.describeFilterObservation(inputs);
 
     expect(observation).toBe(
-      "Metric Value (b) recorded latest 3.00 sec (min 1.00 sec, max 3.00 sec) across 3 data points.",
+      "Metric Value (b) recorded latest 3 sec (min 1 sec, max 3 sec) across 3 data points.",
     );
     // The a-series (ms, 40/60) must not leak in.
     expect(observation).not.toContain("(a)");
@@ -562,7 +579,7 @@ describe("MonitorCriteriaObservationBuilder.describeFilterObservation — metric
       MonitorCriteriaObservationBuilder.describeFilterObservation(inputs);
 
     expect(observation).toBe(
-      "Metric Value (a) recorded latest 6.00 % across 1 data point.",
+      "Metric Value (a) recorded latest 6.00% across 1 data point.",
     );
 
     const unit: string | undefined =
@@ -630,7 +647,7 @@ describe("MonitorCriteriaObservationBuilder.describeFilterObservation — metric
       MonitorCriteriaObservationBuilder.describeFilterObservation(inputs);
 
     expect(observation).toBe(
-      "Metric Value (c) recorded latest 2.50 sec (min 1.50 sec, max 2.50 sec) across 2 data points.",
+      "Metric Value (c) recorded latest 2.5 sec (min 1.5 sec, max 2.5 sec) across 2 data points.",
     );
     // The formula alias, not the base query, is summarized.
     expect(observation).toContain("(c)");
@@ -659,9 +676,9 @@ describe("MonitorCriteriaObservationBuilder.describeFilterObservation — metric
       MonitorCriteriaObservationBuilder.describeFilterObservation(inputs);
 
     expect(observation).toBe(
-      "Metric Value (a) recorded latest 1.50 gbit across 1 data point.",
+      "Metric Value (a) recorded latest 1.5 Gbit across 1 data point.",
     );
-    expect(observation).toContain("1.50 gbit");
+    expect(observation).toContain("1.5 Gbit");
   });
 
   /*
@@ -686,10 +703,10 @@ describe("MonitorCriteriaObservationBuilder.describeFilterObservation — metric
       MonitorCriteriaObservationBuilder.describeFilterObservation(inputs);
 
     expect(observation).toBe(
-      "Metric Value (a) recorded latest 5.00 sec across 1 data point.",
+      "Metric Value (a) recorded latest 5 sec across 1 data point.",
     );
     // Unconverted value, but labelled with the threshold unit.
-    expect(observation).toContain("5.00 sec");
+    expect(observation).toContain("5 sec");
   });
 });
 

package/Tests/Server/Utils/Monitor/MonitorDependencySuppressionCreatorSkip.test.ts

@@ -220,6 +220,7 @@ describe("Dependency-suppression skip block in the alert / incident creators", (
         kubernetesClusterIds: [],
         serviceIds: [],
         proxmoxClusterIds: [],
+        vmwareVCenterIds: [],
         cephClusterIds: [],
         dockerSwarmClusterIds: [],
         iotFleetIds: [],

package/Tests/Server/Utils/Monitor/MonitorIncidentResourceLinking.test.ts

@@ -22,6 +22,7 @@ import NetworkDeviceOwnerUserService from "../../../../Server/Services/NetworkDe
 import PodmanHostService from "../../../../Server/Services/PodmanHostService";
 import ProxmoxClusterService from "../../../../Server/Services/ProxmoxClusterService";
 import ServiceService from "../../../../Server/Services/ServiceService";
+import VMwareVCenterService from "../../../../Server/Services/VMwareVCenterService";
 import ProjectScopedReferenceValidator from "../../../../Server/Utils/Database/ProjectScopedReferenceValidator";
 import MonitorResourceContextUtil from "../../../../Server/Utils/Monitor/MonitorResourceContext";
 import { SeriesResolvedResourceIds } from "../../../../Server/Utils/Monitor/SeriesResourceLinker";
@@ -127,7 +128,7 @@ function idsOn(
 }
 
 /*
- * The nine-relation shape MonitorResourceContext resolves from the
+ * The ten-relation shape MonitorResourceContext resolves from the
  * monitor's own step config. Tests stub the util and hand back one of
  * these, spreading over it to name only the relations under test.
  */
@@ -139,6 +140,7 @@ function emptyResourceContext(): SeriesResolvedResourceIds {
     kubernetesClusterIds: [],
     serviceIds: [],
     proxmoxClusterIds: [],
+    vmwareVCenterIds: [],
     cephClusterIds: [],
     dockerSwarmClusterIds: [],
     iotFleetIds: [],
@@ -154,6 +156,7 @@ describe("Incidents link the resources their series identifies", () => {
   let dockerHostRows: Array<{ _id: string }> = [];
   let podmanHostRows: Array<{ _id: string }> = [];
   let proxmoxClusterRows: Array<{ _id: string }> = [];
+  let vmwareVCenterRows: Array<{ _id: string }> = [];
   let cephClusterRows: Array<{ _id: string }> = [];
   let dockerSwarmClusterRows: Array<{ _id: string }> = [];
   let iotFleetRows: Array<{ _id: string }> = [];
@@ -169,6 +172,7 @@ describe("Incidents link the resources their series identifies", () => {
     dockerHostRows = [];
     podmanHostRows = [];
     proxmoxClusterRows = [];
+    vmwareVCenterRows = [];
     cephClusterRows = [];
     dockerSwarmClusterRows = [];
     iotFleetRows = [];
@@ -212,6 +216,9 @@ describe("Incidents link the resources their series identifies", () => {
     jest.spyOn(ProxmoxClusterService, "findBy").mockImplementation(async () => {
       return proxmoxClusterRows as never;
     });
+    jest.spyOn(VMwareVCenterService, "findBy").mockImplementation(async () => {
+      return vmwareVCenterRows as never;
+    });
     jest.spyOn(CephClusterService, "findBy").mockImplementation(async () => {
       return cephClusterRows as never;
     });
@@ -355,6 +362,7 @@ describe("Incidents link the resources their series identifies", () => {
     dockerHostRows = [{ _id: "docker-1" }];
     podmanHostRows = [{ _id: "podman-1" }];
     proxmoxClusterRows = [{ _id: "pve-1" }];
+    vmwareVCenterRows = [{ _id: "vcsa-1" }];
     cephClusterRows = [{ _id: "ceph-1" }];
     dockerSwarmClusterRows = [{ _id: "swarm-1" }];
     iotFleetRows = [{ _id: "fleet-1" }];
@@ -374,6 +382,7 @@ describe("Incidents link the resources their series identifies", () => {
             "oneuptime.docker.host.name": "docker-box",
             "oneuptime.podman.host.name": "podman-box",
             "proxmox.cluster.name": "pve",
+            "vmware.vcenter.name": "vcsa",
             "ceph.cluster.name": "ceph",
             "docker.swarm.cluster.name": "swarm",
             "iot.fleet.name": "fleet",
@@ -392,6 +401,7 @@ describe("Incidents link the resources their series identifies", () => {
     expect(idsOn(incident.dockerHosts)).toEqual(["docker-1"]);
     expect(idsOn(incident.podmanHosts)).toEqual(["podman-1"]);
     expect(idsOn(incident.proxmoxClusters)).toEqual(["pve-1"]);
+    expect(idsOn(incident.vmwareVCenters)).toEqual(["vcsa-1"]);
     expect(idsOn(incident.cephClusters)).toEqual(["ceph-1"]);
     expect(idsOn(incident.dockerSwarmClusters)).toEqual(["swarm-1"]);
     expect(idsOn(incident.iotFleets)).toEqual(["fleet-1"]);
@@ -482,6 +492,55 @@ describe("Incidents link the resources their series identifies", () => {
     ]);
   });
 
+  it("merges the monitor's step-config vCenter with the one the series names", async () => {
+    vmwareVCenterRows = [{ _id: "vcsa-from-label" }];
+    resourceContext = {
+      ...emptyResourceContext(),
+      vmwareVCenterIds: ["vcsa-from-step-config"],
+    };
+
+    await MonitorIncident.criteriaMetCreateIncidentsAndUpdateMonitorStatus({
+      criteriaInstance: criteriaInstance(),
+      monitor: monitor(),
+      dataToProcess: dataToProcess,
+      rootCause: "Host CPU utilization is above 90%",
+      autoResolveCriteriaInstanceIdIncidentIdsDictionary: NO_AUTO_RESOLVE,
+      matchesPerSeries: [
+        series({ "resource.vmware.vcenter.name": "vcsa" }, "fp-1"),
+      ],
+      props: {},
+    });
+
+    expect(idsOn(createdIncidents[0]!.vmwareVCenters).sort()).toEqual([
+      "vcsa-from-label",
+      "vcsa-from-step-config",
+    ]);
+  });
+
+  it("still attaches the step-config vCenter to an ungrouped incident", async () => {
+    /*
+     * The shipped VMware templates group by the vSphere object's own
+     * attribute, never by the vCenter, so the vCenter link on their
+     * incidents comes ONLY from the step config path.
+     */
+    resourceContext = {
+      ...emptyResourceContext(),
+      vmwareVCenterIds: ["vcsa-1"],
+    };
+
+    await MonitorIncident.criteriaMetCreateIncidentsAndUpdateMonitorStatus({
+      criteriaInstance: criteriaInstance(),
+      monitor: monitor(),
+      dataToProcess: dataToProcess,
+      rootCause: "Datastore capacity is above 90%",
+      autoResolveCriteriaInstanceIdIncidentIdsDictionary: NO_AUTO_RESOLVE,
+      props: {},
+    });
+
+    expect(idsOn(createdIncidents[0]!.vmwareVCenters)).toEqual(["vcsa-1"]);
+    expect(VMwareVCenterService.findBy).not.toHaveBeenCalled();
+  });
+
   it("links the service an ungrouped metric monitor is scoped to", async () => {
     /*
      * THE REPORTED BUG. The alert twin of this came from a Metrics monitor whose only

package/Tests/Server/Utils/Monitor/MonitorMaintenanceSuppression.test.ts

@@ -14,6 +14,7 @@ function emptyMaintained(): MaintainedResourceKeys {
     podmanHosts: { ids: new Set<string>(), names: new Set<string>() },
     kubernetesClusters: { ids: new Set<string>(), names: new Set<string>() },
     proxmoxClusters: { ids: new Set<string>(), names: new Set<string>() },
+    vmwareVCenters: { ids: new Set<string>(), names: new Set<string>() },
     cephClusters: { ids: new Set<string>(), names: new Set<string>() },
     dockerSwarmClusters: { ids: new Set<string>(), names: new Set<string>() },
     iotFleets: { ids: new Set<string>(), names: new Set<string>() },
@@ -108,6 +109,37 @@ describe("SeriesResourceLabels", () => {
       expect(refs.cephClusterNames).toEqual(["ceph-1"]);
     });
 
+    it("maps vmware vcenter name keys (prefixed and unprefixed)", () => {
+      const refs: SeriesResourceRefs = SeriesResourceLabels.extractResourceRefs(
+        {
+          "resource.vmware.vcenter.name": "vcsa-1",
+        },
+      );
+      expect(refs.vmwareVCenterNames).toEqual(["vcsa-1"]);
+
+      const refsUnprefixed: SeriesResourceRefs =
+        SeriesResourceLabels.extractResourceRefs({
+          "vmware.vcenter.name": "vcsa-2",
+        });
+      expect(refsUnprefixed.vmwareVCenterNames).toEqual(["vcsa-2"]);
+    });
+
+    it("does not read a vSphere object attribute as the vCenter identity", () => {
+      /*
+       * The shipped VMware templates group by `resource.vcenter.host.name`
+       * / `resource.vcenter.vm.name`; those name an ESXi host or a VM,
+       * not the vCenter, and must never resolve to a VMwareVCenter row.
+       */
+      const refs: SeriesResourceRefs = SeriesResourceLabels.extractResourceRefs(
+        {
+          "resource.vcenter.host.name": "esx-01",
+          "resource.vcenter.vm.name": "web-01",
+          "resource.vcenter.cluster.name": "prod-cluster",
+        },
+      );
+      expect(refs.vmwareVCenterNames).toEqual([]);
+    });
+
     it("maps iot fleet name keys (prefixed and unprefixed)", () => {
       const refs: SeriesResourceRefs = SeriesResourceLabels.extractResourceRefs(
         {
@@ -237,6 +269,34 @@ describe("MonitorMaintenanceSuppression.getSuppressedFingerprintsForMaintainedRe
     expect(Array.from(result)).toEqual(["fpSwarm"]);
   });
 
+  it("suppresses a vmware series whose vCenter is under maintenance", () => {
+    /*
+     * Same contract for vCenters: a user-built monitor grouped by
+     * `vmware.vcenter.name` must go quiet while the vCenter is attached
+     * to an ongoing maintenance window. The shipped templates group by
+     * host / VM / datastore instead and rely on the step-config path.
+     */
+    const maintained: MaintainedResourceKeys = emptyMaintained();
+    maintained.vmwareVCenters.names.add("vcsa-prod");
+
+    const result: Set<string> =
+      MonitorMaintenanceSuppression.getSuppressedFingerprintsForMaintainedResources(
+        {
+          matchesPerSeries: [
+            series("fpVCenter", {
+              "resource.vmware.vcenter.name": "vcsa-prod",
+            }),
+            series("fpClear", {
+              "resource.vmware.vcenter.name": "vcsa-staging",
+            }),
+          ],
+          maintained,
+        },
+      );
+
+    expect(Array.from(result)).toEqual(["fpVCenter"]);
+  });
+
   it("does not cross-match resource types that happen to share a name", () => {
     /*
      * A service named the same string as the breaching host must not