@monoes/monograph 1.5.3 → 1.5.4

package/.monodesign/hook.cache.json

@@ -1 +1 @@
-{"version":1,"sessions":{"62fe2928-1ed6-4654-a303-ff71d4053f57":{"updatedAt":1784847189578,"files":{"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/export/html.ts":{"editCount":3,"findings":["layout-transition:173"]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/cli/skill-gen.ts":{"editCount":2,"findings":[]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/analysis/cycles.ts":{"editCount":1,"findings":[]}}},"b97c41cc-6633-49a9-ba65-aedb55adb9d9":{"updatedAt":1784880311251,"files":{"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/pipeline/phases/wildcard-phase.ts":{"editCount":1,"findings":[]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/pipeline/orchestrator.ts":{"editCount":2,"findings":[]}}}}}
+{"version":1,"sessions":{"62fe2928-1ed6-4654-a303-ff71d4053f57":{"updatedAt":1784847189578,"files":{"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/export/html.ts":{"editCount":3,"findings":["layout-transition:173"]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/cli/skill-gen.ts":{"editCount":2,"findings":[]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/analysis/cycles.ts":{"editCount":1,"findings":[]}}},"b97c41cc-6633-49a9-ba65-aedb55adb9d9":{"updatedAt":1784880311251,"files":{"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/pipeline/phases/wildcard-phase.ts":{"editCount":1,"findings":[]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/pipeline/orchestrator.ts":{"editCount":2,"findings":[]}}},"fcdece6b-3b21-49a2-9d95-5460a6b8862d":{"updatedAt":1784978043785,"files":{"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/graph/statistics.ts":{"editCount":1,"findings":[]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/cli/src/mcp-tools/hive-mind-tools.ts":{"editCount":1,"findings":[]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/cli/eval-server.ts":{"editCount":2,"findings":[]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/vitest.config.ts":{"editCount":1,"findings":[]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/cli/src/__tests__/monograph-tools-real-index.test.ts":{"editCount":1,"findings":[]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/pipeline/phases/call-site-extractors.ts":{"editCount":1,"findings":[]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/src/pipeline/phases/scope-resolution.ts":{"editCount":4,"findings":[]},"/Volumes/media/projects/monoes/monomind/packages/@monomind/monograph/__tests__/integration/call-attribution.test.ts":{"editCount":1,"findings":[]}}}}}

package/__tests__/integration/call-attribution.test.ts

@@ -0,0 +1,116 @@
+/**
+ * CALLS edges must be attributed to the function containing the call, not to
+ * the containing file.
+ *
+ * Attributing them to the file gave every function an inbound CALLS edge from
+ * its own file purely for being declared there, which silently disabled
+ * dead-export detection: `detectDeadCodeNodes` rejects any candidate with an
+ * inbound CALLS/IMPORTS/REFERENCES/RE_EXPORTS edge, and that self-edge always
+ * matched. Measured on the monomind repo before the fix: 9,672 of 9,672 CALLS
+ * edges originated from a File node, 1,942 of 1,951 exported functions carried
+ * a self-file edge, and 1,107 had it as their only inbound edge — while the
+ * tool reported a single dead-code candidate.
+ *
+ * Calls at module top level are genuinely file-scoped and must keep a File
+ * source, so this pins both directions.
+ */
+import { tmpdir } from 'os';
+import { join } from 'path';
+import { mkdirSync, writeFileSync, rmSync } from 'fs';
+import { buildAsync } from '../../src/pipeline/orchestrator.js';
+import { openDb, closeDb } from '../../src/storage/db.js';
+import { detectDeadCodeNodes } from '../../src/graph/dead-code.js';
+import type { Database } from 'better-sqlite3';
+
+const tmpRepo = join(tmpdir(), `monograph-call-attribution-${Date.now()}`);
+let db: Database;
+
+beforeAll(async () => {
+  mkdirSync(join(tmpRepo, 'src'), { recursive: true });
+
+  writeFileSync(join(tmpRepo, 'src', 'util.ts'), 'export function helper(n: string): string { return `hi ${n}`; }\n');
+
+  // greet() calls helper() from inside a method — must be attributed to greet.
+  // neverCalledAnywhere is exported and called by nobody.
+  writeFileSync(
+    join(tmpRepo, 'src', 'service.ts'),
+    [
+      "import { helper } from './util.js';",
+      'export class UserService {',
+      '  constructor(private readonly name: string) {}',
+      '  greet(): string { return helper(this.name); }',
+      '}',
+      'export function neverCalledAnywhere(): number { return 42; }',
+      '',
+    ].join('\n'),
+  );
+
+  // Calls at module top level — legitimately file-scoped.
+  writeFileSync(
+    join(tmpRepo, 'src', 'main.ts'),
+    [
+      "import { UserService } from './service.js';",
+      "const s = new UserService('a');",
+      'console.log(s.greet());',
+      '',
+    ].join('\n'),
+  );
+
+  await buildAsync(tmpRepo, { codeOnly: true, force: true });
+  db = openDb(join(tmpRepo, '.monomind', 'monograph.db'));
+}, 60000);
+
+afterAll(() => {
+  if (db) closeDb(db);
+  rmSync(tmpRepo, { recursive: true, force: true });
+});
+
+function callSources(targetName: string): Array<{ label: string; name: string }> {
+  return db
+    .prepare(
+      `SELECT s.label, s.name FROM edges e
+         JOIN nodes s ON e.source_id = s.id
+         JOIN nodes t ON e.target_id = t.id
+        WHERE e.relation = 'CALLS' AND t.name = ?`,
+    )
+    .all(targetName) as Array<{ label: string; name: string }>;
+}
+
+describe('CALLS edge attribution', () => {
+  it('attributes a call inside a method to that method', () => {
+    const sources = callSources('helper');
+    expect(sources.length).toBeGreaterThan(0);
+    expect(sources.some(s => s.label === 'Method' && s.name === 'greet')).toBe(true);
+  });
+
+  it('does not attribute a call to the file merely containing the callee', () => {
+    // `helper` is declared in util.ts. util.ts must not "call" it.
+    expect(callSources('helper').some(s => s.label === 'File' && s.name === 'util.ts')).toBe(false);
+  });
+
+  it('keeps module-top-level calls attributed to the file', () => {
+    // main.ts calls s.greet() and `new UserService()` at top level.
+    const row = db
+      .prepare(
+        `SELECT COUNT(*) c FROM edges e JOIN nodes s ON e.source_id = s.id
+          WHERE e.relation = 'CALLS' AND s.label = 'File' AND s.name = 'main.ts'`,
+      )
+      .get() as { c: number };
+    expect(row.c).toBeGreaterThan(0);
+  });
+
+  it('leaves an uncalled exported function with no inbound CALLS edge', () => {
+    expect(callSources('neverCalledAnywhere').length).toBe(0);
+  });
+
+  it('lets dead-code detection find a genuinely uncalled export', () => {
+    expect(detectDeadCodeNodes(db).map(n => n.name)).toContain('neverCalledAnywhere');
+  });
+
+  it('still records the calls that really happen', () => {
+    // The fix must move attribution, not drop edges: greet->helper and the two
+    // top-level calls in main.ts should all survive.
+    const total = db.prepare("SELECT COUNT(*) c FROM edges WHERE relation = 'CALLS'").get() as { c: number };
+    expect(total.c).toBeGreaterThanOrEqual(3);
+  });
+});

package/coverage/base.css

@@ -0,0 +1,224 @@
+body, html {
+  margin:0; padding: 0;
+  height: 100%;
+}
+body {
+    font-family: Helvetica Neue, Helvetica, Arial;
+    font-size: 14px;
+    color:#333;
+}
+.small { font-size: 12px; }
+*, *:after, *:before {
+  -webkit-box-sizing:border-box;
+     -moz-box-sizing:border-box;
+          box-sizing:border-box;
+  }
+h1 { font-size: 20px; margin: 0;}
+h2 { font-size: 14px; }
+pre {
+    font: 12px/1.4 Consolas, "Liberation Mono", Menlo, Courier, monospace;
+    margin: 0;
+    padding: 0;
+    -moz-tab-size: 2;
+    -o-tab-size:  2;
+    tab-size: 2;
+}
+a { color:#0074D9; text-decoration:none; }
+a:hover { text-decoration:underline; }
+.strong { font-weight: bold; }
+.space-top1 { padding: 10px 0 0 0; }
+.pad2y { padding: 20px 0; }
+.pad1y { padding: 10px 0; }
+.pad2x { padding: 0 20px; }
+.pad2 { padding: 20px; }
+.pad1 { padding: 10px; }
+.space-left2 { padding-left:55px; }
+.space-right2 { padding-right:20px; }
+.center { text-align:center; }
+.clearfix { display:block; }
+.clearfix:after {
+  content:'';
+  display:block;
+  height:0;
+  clear:both;
+  visibility:hidden;
+  }
+.fl { float: left; }
+@media only screen and (max-width:640px) {
+  .col3 { width:100%; max-width:100%; }
+  .hide-mobile { display:none!important; }
+}
+
+.quiet {
+  color: #7f7f7f;
+  color: rgba(0,0,0,0.5);
+}
+.quiet a { opacity: 0.7; }
+
+.fraction {
+  font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace;
+  font-size: 10px;
+  color: #555;
+  background: #E8E8E8;
+  padding: 4px 5px;
+  border-radius: 3px;
+  vertical-align: middle;
+}
+
+div.path a:link, div.path a:visited { color: #333; }
+table.coverage {
+  border-collapse: collapse;
+  margin: 10px 0 0 0;
+  padding: 0;
+}
+
+table.coverage td {
+  margin: 0;
+  padding: 0;
+  vertical-align: top;
+}
+table.coverage td.line-count {
+    text-align: right;
+    padding: 0 5px 0 20px;
+}
+table.coverage td.line-coverage {
+    text-align: right;
+    padding-right: 10px;
+    min-width:20px;
+}
+
+table.coverage td span.cline-any {
+    display: inline-block;
+    padding: 0 5px;
+    width: 100%;
+}
+.missing-if-branch {
+    display: inline-block;
+    margin-right: 5px;
+    border-radius: 3px;
+    position: relative;
+    padding: 0 4px;
+    background: #333;
+    color: yellow;
+}
+
+.skip-if-branch {
+    display: none;
+    margin-right: 10px;
+    position: relative;
+    padding: 0 4px;
+    background: #ccc;
+    color: white;
+}
+.missing-if-branch .typ, .skip-if-branch .typ {
+    color: inherit !important;
+}
+.coverage-summary {
+  border-collapse: collapse;
+  width: 100%;
+}
+.coverage-summary tr { border-bottom: 1px solid #bbb; }
+.keyline-all { border: 1px solid #ddd; }
+.coverage-summary td, .coverage-summary th { padding: 10px; }
+.coverage-summary tbody { border: 1px solid #bbb; }
+.coverage-summary td { border-right: 1px solid #bbb; }
+.coverage-summary td:last-child { border-right: none; }
+.coverage-summary th {
+  text-align: left;
+  font-weight: normal;
+  white-space: nowrap;
+}
+.coverage-summary th.file { border-right: none !important; }
+.coverage-summary th.pct { }
+.coverage-summary th.pic,
+.coverage-summary th.abs,
+.coverage-summary td.pct,
+.coverage-summary td.abs { text-align: right; }
+.coverage-summary td.file { white-space: nowrap;  }
+.coverage-summary td.pic { min-width: 120px !important;  }
+.coverage-summary tfoot td { }
+
+.coverage-summary .sorter {
+    height: 10px;
+    width: 7px;
+    display: inline-block;
+    margin-left: 0.5em;
+    background: url(sort-arrow-sprite.png) no-repeat scroll 0 0 transparent;
+}
+.coverage-summary .sorted .sorter {
+    background-position: 0 -20px;
+}
+.coverage-summary .sorted-desc .sorter {
+    background-position: 0 -10px;
+}
+.status-line {  height: 10px; }
+/* yellow */
+.cbranch-no { background: yellow !important; color: #111; }
+/* dark red */
+.red.solid, .status-line.low, .low .cover-fill { background:#C21F39 }
+.low .chart { border:1px solid #C21F39 }
+.highlighted,
+.highlighted .cstat-no, .highlighted .fstat-no, .highlighted .cbranch-no{
+  background: #C21F39 !important;
+}
+/* medium red */
+.cstat-no, .fstat-no, .cbranch-no, .cbranch-no { background:#F6C6CE }
+/* light red */
+.low, .cline-no { background:#FCE1E5 }
+/* light green */
+.high, .cline-yes { background:rgb(230,245,208) }
+/* medium green */
+.cstat-yes { background:rgb(161,215,106) }
+/* dark green */
+.status-line.high, .high .cover-fill { background:rgb(77,146,33) }
+.high .chart { border:1px solid rgb(77,146,33) }
+/* dark yellow (gold) */
+.status-line.medium, .medium .cover-fill { background: #f9cd0b; }
+.medium .chart { border:1px solid #f9cd0b; }
+/* light yellow */
+.medium { background: #fff4c2; }
+
+.cstat-skip { background: #ddd; color: #111; }
+.fstat-skip { background: #ddd; color: #111 !important; }
+.cbranch-skip { background: #ddd !important; color: #111; }
+
+span.cline-neutral { background: #eaeaea; }
+
+.coverage-summary td.empty {
+    opacity: .5;
+    padding-top: 4px;
+    padding-bottom: 4px;
+    line-height: 1;
+    color: #888;
+}
+
+.cover-fill, .cover-empty {
+  display:inline-block;
+  height: 12px;
+}
+.chart {
+  line-height: 0;
+}
+.cover-empty {
+    background: white;
+}
+.cover-full {
+    border-right: none !important;
+}
+pre.prettyprint {
+    border: none !important;
+    padding: 0 !important;
+    margin: 0 !important;
+}
+.com { color: #999 !important; }
+.ignore-none { color: #999; font-weight: normal; }
+
+.wrapper {
+  min-height: 100%;
+  height: auto !important;
+  height: 100%;
+  margin: 0 auto -48px;
+}
+.footer, .push {
+  height: 48px;
+}

package/coverage/block-navigation.js

@@ -0,0 +1,87 @@
+/* eslint-disable */
+var jumpToCode = (function init() {
+    // Classes of code we would like to highlight in the file view
+    var missingCoverageClasses = ['.cbranch-no', '.cstat-no', '.fstat-no'];
+
+    // Elements to highlight in the file listing view
+    var fileListingElements = ['td.pct.low'];
+
+    // We don't want to select elements that are direct descendants of another match
+    var notSelector = ':not(' + missingCoverageClasses.join('):not(') + ') > '; // becomes `:not(a):not(b) > `
+
+    // Selector that finds elements on the page to which we can jump
+    var selector =
+        fileListingElements.join(', ') +
+        ', ' +
+        notSelector +
+        missingCoverageClasses.join(', ' + notSelector); // becomes `:not(a):not(b) > a, :not(a):not(b) > b`
+
+    // The NodeList of matching elements
+    var missingCoverageElements = document.querySelectorAll(selector);
+
+    var currentIndex;
+
+    function toggleClass(index) {
+        missingCoverageElements
+            .item(currentIndex)
+            .classList.remove('highlighted');
+        missingCoverageElements.item(index).classList.add('highlighted');
+    }
+
+    function makeCurrent(index) {
+        toggleClass(index);
+        currentIndex = index;
+        missingCoverageElements.item(index).scrollIntoView({
+            behavior: 'smooth',
+            block: 'center',
+            inline: 'center'
+        });
+    }
+
+    function goToPrevious() {
+        var nextIndex = 0;
+        if (typeof currentIndex !== 'number' || currentIndex === 0) {
+            nextIndex = missingCoverageElements.length - 1;
+        } else if (missingCoverageElements.length > 1) {
+            nextIndex = currentIndex - 1;
+        }
+
+        makeCurrent(nextIndex);
+    }
+
+    function goToNext() {
+        var nextIndex = 0;
+
+        if (
+            typeof currentIndex === 'number' &&
+            currentIndex < missingCoverageElements.length - 1
+        ) {
+            nextIndex = currentIndex + 1;
+        }
+
+        makeCurrent(nextIndex);
+    }
+
+    return function jump(event) {
+        if (
+            document.getElementById('fileSearch') === document.activeElement &&
+            document.activeElement != null
+        ) {
+            // if we're currently focused on the search input, we don't want to navigate
+            return;
+        }
+
+        switch (event.which) {
+            case 78: // n
+            case 74: // j
+                goToNext();
+                break;
+            case 66: // b
+            case 75: // k
+            case 80: // p
+                goToPrevious();
+                break;
+        }
+    };
+})();
+window.addEventListener('keydown', jumpToCode);