@mohasinac/appkit 4.13.1 → 4.15.0

package/dist/features/scams/constants/scammer-status-display.js

@@ -0,0 +1,79 @@
+/*
+ * WHY: "How does a scammer status look and read" had FOUR hand-written answers
+ *      and they had already diverged in a way that shipped a real defect:
+ *
+ *        · `AdminScammersView.STATUS_BADGE`   — Record<string, string>
+ *        · `AdminScammerEditorView.STATUS_COLOR` — Record<string, string>
+ *        · `AdminScammerEditorView.STATUS_OPTIONS` — a literal label list
+ *        · `ADMIN_SCAMMER_STATUS_TABS`        — the filter chips
+ *
+ *      Both colour maps carried the SAME broken `removed` entry:
+ *
+ *          "bg-[…surface] text-[…muted] bg-[…surface-elevated] text-[…muted]"
+ *
+ *      — two backgrounds and two inks on one element. Tailwind emits all four
+ *      and the winner is decided by stylesheet order, not by position in the
+ *      class string, so which background actually painted was not what either
+ *      map said. One bug, two copies: the Duplication Framework's bug-fix
+ *      multiplier, which is what makes this a consolidate rather than a
+ *      third copy.
+ *
+ * WHAT: One display module beside the union it describes.
+ *
+ * ## Everything here is keyed `Record<ScammerStatus, …>`
+ *
+ * Not `Record<string, …>`. A status added to the union without a label or a
+ * badge is then a COMPILE error rather than a row that silently renders with
+ * the fallback styling of a status it is not — which is precisely how the
+ * loose maps hid the broken `removed` entry.
+ *
+ * EXPORTS:
+ *   SCAMMER_STATUS_LABEL, SCAMMER_STATUS_BADGE, SCAMMER_STATUS_OPTIONS,
+ *   toScammerStatus
+ *
+ * @tag domain:scams
+ * @tag layer:constants
+ * @tag pattern:none
+ * @tag access:isomorphic
+ * @tag consumers:AdminScammersView,AdminScammerEditorView
+ * @tag sideEffects:none
+ */
+import { ScammerStatusValues } from "../schemas/firestore";
+/** Human-readable label. Replaces two `.replace(/_/g, " ")` call sites, which
+ *  rendered "pending review" — mechanically correct, and not a written label. */
+export const SCAMMER_STATUS_LABEL = {
+    pending_review: "Pending review",
+    verified: "Verified",
+    rejected: "Rejected",
+    removed: "Removed",
+};
+/**
+ * Inline-chip styling. Every entry is a `bg-{status}-surface` + `text-{status}`
+ * pair per Recurrent Root Cause #67 — the two tokens invert together with the
+ * theme, which a literal `text-white` would not.
+ *
+ * `removed` is the neutral case: it has no status colour because it is not a
+ * status outcome, it is a withdrawal. ONE background, ONE ink.
+ */
+export const SCAMMER_STATUS_BADGE = {
+    pending_review: "bg-warning-surface text-warning",
+    verified: "bg-success-surface text-success",
+    rejected: "bg-error-surface text-error",
+    removed: "bg-[var(--appkit-color-surface-elevated)] text-[var(--appkit-color-text-muted)]",
+};
+/** Dropdown options, derived from the union so one cannot go missing. */
+export const SCAMMER_STATUS_OPTIONS = Object.values(ScammerStatusValues).map((value) => ({ value, label: SCAMMER_STATUS_LABEL[value] }));
+/**
+ * Narrow an unknown API value to a real status.
+ *
+ * The list view used `toStringValue(item.status, "pending_review")`, which
+ * produces a `string` — so an unrecognised value flowed on as if it were a
+ * status and every consumer fell back to the pending styling. This maps
+ * anything unrecognised to `pending_review` explicitly, and the return type
+ * says so.
+ */
+export function toScammerStatus(value) {
+    return Object.values(ScammerStatusValues).includes(value)
+        ? value
+        : ScammerStatusValues.PENDING_REVIEW;
+}

package/dist/features/search/schemas/index.d.ts

@@ -26,22 +26,22 @@ export declare const searchProductItemSchema: z.ZodObject<{
     slug: string;
     currency?: string | undefined;
     status?: string | undefined;
+    price?: number | undefined;
+    mainImage?: string | undefined;
     featured?: boolean | undefined;
     listingType?: "standard" | "auction" | "pre-order" | "prize-draw" | "bundle" | undefined;
     isPromoted?: boolean | undefined;
-    price?: number | undefined;
-    mainImage?: string | undefined;
 }, {
     id: string;
     title: string;
     slug: string;
     currency?: string | undefined;
     status?: string | undefined;
+    price?: number | undefined;
+    mainImage?: string | undefined;
     featured?: boolean | undefined;
     listingType?: "standard" | "auction" | "pre-order" | "prize-draw" | "bundle" | undefined;
     isPromoted?: boolean | undefined;
-    price?: number | undefined;
-    mainImage?: string | undefined;
 }>;
 /**
  * Form/query schema for a search request.

package/dist/features/seller/actions/offer-actions.js

@@ -14,7 +14,11 @@ import { storeRepository } from "../../stores/repository/store.repository";
 import { cartRepository } from "../../cart/repository/cart.repository";
 import { maskOfferForSeller } from "../../../security";
 import { ERROR_MESSAGES, AuthorizationError, ValidationError, NotFoundError, OFFER_ERROR_CODES, } from "../../../errors";
+import { siteSettingsRepository } from "../../admin/repository/site-settings.repository";
+import { canMakeOffer } from "../../../_internal/shared/listing-types/capabilities";
+import { normalizeListingType } from "../../products/utils/listing-type";
 import { OfferStatusValues } from "../schemas";
+import { DEFAULT_MIN_OFFER_PERCENT, minOfferAmount, } from "../../../_internal/shared/features/offers/config";
 /**
  * How long an accepted offer stays claimable at its locked price. Shared by the
  * seller-accept path, the buyer-accepts-counter path, and the expiry sweep so
@@ -26,14 +30,33 @@ const ERR_NOT_AUTHORISED = "Not authorized";
 // --- Buyer: Make an Offer --------------------------------------------------
 export async function makeOffer(userId, userEmail, input) {
     const { productId, offerAmount, buyerNote } = input;
+    /**
+     * Three independent gates, checked in widening-to-narrowing order. Only
+     * `makeOffer` is guarded — switching the site flag off must stop NEW offers
+     * without stranding in-flight ones, so accept/decline/counter/withdraw and
+     * `checkoutOffer` deliberately stay open.
+     */
+    const settings = await siteSettingsRepository.getSingleton().catch(() => null);
+    if (settings?.featureFlags?.offers === false) {
+        throw new ValidationError(ERROR_MESSAGES.OFFER.DISABLED, {
+            code: OFFER_ERROR_CODES.DISABLED,
+        });
+    }
     const product = await productRepository.findById(productId);
     if (!product)
         throw new NotFoundError(ERROR_MESSAGES.PRODUCT.NOT_FOUND);
+    // Some listing types cannot be negotiated at all — an auction already has
+    // bidding, a prize-draw sells fixed-price entries. This was never checked, so
+    // an offer could be (and in seed data was) attached to an auction, producing
+    // a cart line that claims `listingType: "standard"` in the offer lane.
+    if (!canMakeOffer(normalizeListingType(product))) {
+        throw new ValidationError("Offers aren't available for this kind of listing.");
+    }
     if (!product.allowOffers)
         throw new ValidationError("This product does not accept offers.");
-    const minAllowed = Math.ceil(product.price * ((product.minOfferPercent ?? 70) / 100) * 100) / 100;
+    const minAllowed = minOfferAmount(product.price, product.minOfferPercent);
     if (offerAmount < minAllowed)
-        throw new ValidationError(`Minimum offer is ₹${minAllowed} (${product.minOfferPercent ?? 70}% of listing price).`);
+        throw new ValidationError(`Minimum offer is ₹${minAllowed} (${product.minOfferPercent ?? DEFAULT_MIN_OFFER_PERCENT}% of listing price).`);
     if (offerAmount >= product.price)
         throw new ValidationError("Your offer must be below the listed price. Use Add to Cart instead.");
     const offerCount = await offerRepository.countByBuyerAndProduct(userId, productId, product.updatedAt);
@@ -187,7 +210,24 @@ export async function counterOfferByBuyer(userId, userEmail, input) {
     const offerCount = await offerRepository.countByBuyerAndProduct(userId, offer.productId, product.updatedAt);
     if (offerCount >= 3)
         throw new ValidationError(ERROR_MESSAGES.OFFER.LIMIT_REACHED);
-    await offerRepository.withdraw(offerId);
+    // ── Create BEFORE superseding. Order matters. ───────────────────────────
+    //
+    // This used to `withdraw()` first and `create()` second. If `create` threw —
+    // a validation slip, a Firestore blip — the buyer's live counter was ALREADY
+    // withdrawn, no replacement existed, the negotiation was dead, and one of
+    // their three offer slots had been burnt for nothing.
+    //
+    // Reversed, the worst failure is a transient extra pending offer, which
+    // `hasActiveOffer` and the expiry sweep both already handle.
+    //
+    // The chain fields are what make a multi-round negotiation readable at all:
+    // `previousOfferId` used to exist ONLY inside the serverLogger call below
+    // and never reached Firestore, so three rounds were three unrelated
+    // documents. `chainRootOfferId` is denormalised onto every round so a list
+    // row can render "Round 2" with zero extra reads, and `findChain` stays a
+    // single-field equality served by the automatic index.
+    const chainRoot = offer.chainRootOfferId ?? offer.id;
+    const nextRound = (offer.counterRound ?? 1) + 1;
     const newOffer = await offerRepository.create({
         productId: offer.productId,
         productTitle: offer.productTitle,
@@ -202,7 +242,18 @@ export async function counterOfferByBuyer(userId, userEmail, input) {
         listedPrice: offer.listedPrice,
         currency: offer.currency,
         buyerNote,
+        // NOT carrying `sellerNote` forward: it would render as "Seller note" on
+        // the new round, making the seller look like they had already answered a
+        // counter they have never seen. Round N-1 keeps its own note and is now
+        // reachable via `previousOfferId`.
+        previousOfferId: offer.id,
+        chainRootOfferId: chainRoot,
+        counterRound: nextRound,
     });
+    // Now supersede the old round — one write, one history entry. A `withdrawn`
+    // document carrying `supersededByOfferId` renders as *Superseded* (neutral),
+    // not *Withdrawn* (negative): the buyer did not walk away, they countered.
+    await offerRepository.withdraw(offerId, newOffer.id, { actor: { uid: userId, role: "buyer" } }, offer);
     const buyerCounterStore = offer.storeId ? await storeRepository.findById(offer.storeId) : null;
     if (buyerCounterStore?.ownerId)
         await sendNotification({
@@ -214,12 +265,14 @@ export async function counterOfferByBuyer(userId, userEmail, input) {
             relatedId: newOffer.id,
             relatedType: "offer",
         });
+    // `previousOfferId` is no longer logged as its only record — it is a
+    // persisted field on `newOffer` now. A log line is not a data model.
     serverLogger.info("counterOfferByBuyer", {
-        previousOfferId: offerId,
         newOfferId: newOffer.id,
         buyerUid: userId,
         productId: offer.productId,
         counterAmount,
+        counterRound: nextRound,
     });
     return newOffer;
 }

package/dist/features/seller/components/OfferPhaseTimeline.d.ts

@@ -0,0 +1,59 @@
+/**
+ * OfferPhaseTimeline — the offer-shaped wrapper around `<StatusTimeline>`.
+ *
+ * An offer is an order with more phases in front of it, so it shares the rail
+ * and supplies only its own vocabulary:
+ *
+ *   made → countered → accepted → paid
+ *   with declined / withdrawn / expired as the terminal-negative branch
+ *
+ * ## `superseded` is a RENDER KEY, never an OfferStatus
+ *
+ * A document that is `withdrawn` **and** carries `supersededByOfferId` is not
+ * a walk-away — the buyer countered, and the negotiation continued into the
+ * next round. It renders neutral ("Superseded"), not negative ("Withdrawn").
+ *
+ * Deliberately NOT an eighth `OfferStatus` value: `ADMIN_OFFER_STATUS_TABS`
+ * would then gain a chip that matches zero stored rows, which is exactly the
+ * defect `audit-filter-tab-enums` exists to catch.
+ *
+ * ## Back-compat
+ *
+ * Offers written before `statusHistory` existed have none. Branch B derives
+ * what it can from the scalars — and `expired` gets **no date at all**,
+ * because `expireMany` never wrote one. `updatedAt` is "last write of any
+ * kind" and `expiresAt` is a deadline, not an event; using either would be a
+ * fabricated timestamp.
+ */
+import { type TimelineEntry } from "../../status-history/components/StatusTimeline";
+/** One round of a negotiation, as returned by the API. */
+export interface OfferChainRound {
+    id: string;
+    counterRound: number;
+    status: string;
+    offerAmount: number;
+    counterAmount?: number;
+    superseded: boolean;
+    createdAt: string;
+    respondedAt?: string;
+    sellerNote?: string;
+    buyerNote?: string;
+}
+export interface OfferPhaseTimelineProps {
+    status: string;
+    timeline?: TimelineEntry[];
+    timelineTruncated?: number;
+    superseded?: boolean;
+    createdAt?: string;
+    respondedAt?: string;
+    acceptedAt?: string;
+    paidAt?: string;
+    /**
+     * Earlier rounds, oldest first. Concatenated ahead of this offer's own
+     * steps into ONE rail, each introduced by a "Round N" divider — a
+     * negotiation reads as one story, not N disconnected cards.
+     */
+    chain?: OfferChainRound[];
+    className?: string;
+}
+export declare function OfferPhaseTimeline({ status, timeline, timelineTruncated, superseded, createdAt, respondedAt, acceptedAt, paidAt, chain, className, }: OfferPhaseTimelineProps): import("react").JSX.Element;

package/dist/features/seller/components/OfferPhaseTimeline.js

@@ -0,0 +1,107 @@
+"use client";
+import { jsx as _jsx } from "react/jsx-runtime";
+/**
+ * OfferPhaseTimeline — the offer-shaped wrapper around `<StatusTimeline>`.
+ *
+ * An offer is an order with more phases in front of it, so it shares the rail
+ * and supplies only its own vocabulary:
+ *
+ *   made → countered → accepted → paid
+ *   with declined / withdrawn / expired as the terminal-negative branch
+ *
+ * ## `superseded` is a RENDER KEY, never an OfferStatus
+ *
+ * A document that is `withdrawn` **and** carries `supersededByOfferId` is not
+ * a walk-away — the buyer countered, and the negotiation continued into the
+ * next round. It renders neutral ("Superseded"), not negative ("Withdrawn").
+ *
+ * Deliberately NOT an eighth `OfferStatus` value: `ADMIN_OFFER_STATUS_TABS`
+ * would then gain a chip that matches zero stored rows, which is exactly the
+ * defect `audit-filter-tab-enums` exists to catch.
+ *
+ * ## Back-compat
+ *
+ * Offers written before `statusHistory` existed have none. Branch B derives
+ * what it can from the scalars — and `expired` gets **no date at all**,
+ * because `expireMany` never wrote one. `updatedAt` is "last write of any
+ * kind" and `expiresAt` is a deadline, not an event; using either would be a
+ * fabricated timestamp.
+ */
+import { StatusTimeline, stepsFromEntries, } from "../../status-history/components/StatusTimeline";
+const PHASE_LABELS = {
+    pending: "Offer made",
+    countered: "Countered",
+    accepted: "Accepted",
+    paid: "Paid",
+    declined: "Declined",
+    withdrawn: "Withdrawn",
+    expired: "Expired",
+    superseded: "Superseded",
+};
+const NEGATIVE = new Set(["declined", "withdrawn", "expired"]);
+const labelFor = (status) => PHASE_LABELS[status] ?? status;
+const isNegative = (status) => NEGATIVE.has(status);
+/** Branch B — scalars only, for offers with no recorded history. */
+function buildLegacySteps(o) {
+    const steps = [
+        { key: "pending", label: PHASE_LABELS.pending, date: o.createdAt },
+    ];
+    const s = (o.status ?? "").toLowerCase();
+    if (s === "countered") {
+        steps.push({ key: "countered", label: PHASE_LABELS.countered, date: o.respondedAt });
+    }
+    if (s === "accepted" || s === "paid") {
+        steps.push({
+            key: "accepted",
+            label: PHASE_LABELS.accepted,
+            date: o.acceptedAt ?? o.respondedAt,
+        });
+    }
+    if (s === "paid") {
+        steps.push({ key: "paid", label: PHASE_LABELS.paid, date: o.paidAt });
+    }
+    if (s === "declined") {
+        steps.push({ key: "declined", label: PHASE_LABELS.declined, date: o.respondedAt, negative: true });
+    }
+    if (s === "withdrawn") {
+        steps.push(o.superseded
+            ? { key: "superseded", label: PHASE_LABELS.superseded, date: o.respondedAt, muted: true }
+            : { key: "withdrawn", label: PHASE_LABELS.withdrawn, date: o.respondedAt, negative: true });
+    }
+    if (s === "expired") {
+        // No date, on purpose. `expireMany` never wrote one before W2.
+        steps.push({ key: "expired", label: PHASE_LABELS.expired, negative: true });
+    }
+    return steps;
+}
+/** Re-key a withdrawn+superseded step so it reads neutral, not negative. */
+function applySupersede(steps, superseded) {
+    if (!superseded)
+        return steps;
+    return steps.map((s) => s.key === "withdrawn"
+        ? { ...s, key: "superseded", label: PHASE_LABELS.superseded, negative: false, muted: true }
+        : s);
+}
+export function OfferPhaseTimeline({ status, timeline, timelineTruncated, superseded = false, createdAt, respondedAt, acceptedAt, paidAt, chain, className = "", }) {
+    const own = applySupersede(stepsFromEntries(timeline, labelFor, isNegative).length
+        ? stepsFromEntries(timeline, labelFor, isNegative)
+        : buildLegacySteps({ status, createdAt, respondedAt, acceptedAt, paidAt, superseded }), superseded);
+    const priorRounds = (chain ?? []).filter((r) => r.id !== undefined);
+    const hasChain = priorRounds.length > 1;
+    const steps = hasChain
+        ? priorRounds.flatMap((round, idx) => {
+            const roundSteps = applySupersede(buildLegacySteps({
+                status: round.status,
+                createdAt: round.createdAt,
+                respondedAt: round.respondedAt,
+                superseded: round.superseded,
+            }), round.superseded);
+            return roundSteps.map((s, i) => ({
+                ...s,
+                roundLabel: i === 0 ? `Round ${round.counterRound || idx + 1}` : undefined,
+                note: i === roundSteps.length - 1 ? (round.sellerNote ?? round.buyerNote) : undefined,
+            }));
+        })
+        : own;
+    return (_jsx(StatusTimeline, { title: hasChain ? "Negotiation" : "Offer history", steps: steps, truncatedCount: timelineTruncated, emptyLabel: "No offer history yet", className: className }));
+}

package/dist/features/seller/components/SellerArtView.js

@@ -14,6 +14,8 @@ import { ROUTES } from "../../../constants/index";
 import { toRecordArray, toRelativeDate, toCurrency, toStringValue, } from "../../admin/hooks/useAdminListingData";
 import { DataListingView } from "../../admin/components/DataListingView";
 import { SELLER_BULK_ACTIONS, ROW_ACTION_META } from "../../products/constants/action-defs";
+import { useAvailabilityScope } from "../../products/hooks/useAvailabilityScope";
+const LISTING_TYPES = ["art"];
 const COLUMNS = [
     { key: "title", header: "Listing", render: (row) => _jsx(Text, { size: "sm", weight: "medium", children: row.title }) },
     { key: "price", header: "Price", render: (row) => _jsx(Text, { className: "tabular-nums", size: "sm", children: row.price }) },
@@ -57,6 +59,7 @@ export function SellerArtView({ onCreateClick, onEditClick, onDelete, onBulkDele
         else
             window.location.href = String(ROUTES.STORE.ART_NEW);
     }, [onCreateClick]);
+    const scope = useAvailabilityScope(LISTING_TYPES);
     const config = {
         portal: "seller",
         title: "Art",
@@ -87,6 +90,8 @@ export function SellerArtView({ onCreateClick, onEditClick, onDelete, onBulkDele
         }),
         getTotal: (response, mappedRows) => typeof response.meta?.total === "number" ? response.meta.total : mappedRows.length,
         buildFilters: () => "listingType==art",
+        buildExtraParams: () => scope.extraParams,
+        renderAboveContent: scope.renderAboveContent,
         primaryAction: { label: "New Art Print", onClick: () => handleCreate() },
         // Mirrors the "Edit" row action below so table rows and cards both navigate on click.
         onRowClick: (row) => handleEdit(row.id),

package/dist/features/seller/components/SellerAuctionsView.js

@@ -4,23 +4,22 @@ import { sieveFilter, SIEVE_OP } from "@mohasinac/appkit/client";
 import { sortBy } from "@mohasinac/appkit/client";
 import React, { useState, useCallback } from "react";
 import { useEntityDelete } from "../../../react/hooks/useEntityDelete";
-import { useUrlTable } from "../../../react/hooks/useUrlTable";
 import { ConfirmDeleteModal, FilterChipGroup, ListingLayout, RowActionMenu } from "../../../ui";
 import { SELLER_ENDPOINTS } from "../../../constants/api-endpoints";
-import { TABLE_KEYS } from "../../../constants/table-keys";
 import { SELLER_AUCTION_STATUS_TABS } from "../../admin/constants/filter-tabs";
 import { ACTIONS } from "../../../_internal/shared/actions/action-registry";
 import { ROUTES } from "../../../constants";
 import { toRecordArray, toRelativeDate, toCurrency, toStringValue, } from "../../admin/hooks/useAdminListingData";
 import { DataListingView } from "../../admin/components/DataListingView";
 import { SELLER_BULK_ACTIONS, ROW_ACTION_META } from "../../products/constants/action-defs";
+import { useAvailabilityScope } from "../../products/hooks/useAvailabilityScope";
+const AUCTION_TYPES = ["auction"];
 export function SellerAuctionsView({ children, onEditClick, onDelete, onBulkDelete, ...props }) {
     // Independent of DataListingView's own internal useUrlTable() — both read
     // and write the same URL, useUrlTable has no local state, so they stay in
     // sync (same pattern SellerProductsView already uses for its "Show sold"
     // toggle).
-    const toggleTable = useUrlTable({});
-    const showEnded = toggleTable.get(TABLE_KEYS.SHOW_ENDED) === "true";
+    const scope = useAvailabilityScope(AUCTION_TYPES);
     const [deleteTargetId, setDeleteTargetId] = useState(null);
     const { deletingId, handleDelete: performDelete } = useEntityDelete({
         endpoint: SELLER_ENDPOINTS.PRODUCT_BY_ID,
@@ -46,7 +45,7 @@ export function SellerAuctionsView({ children, onEditClick, onDelete, onBulkDele
         title: "Auctions",
         searchPlaceholder: "Search auctions by product name",
         emptyLabel: "No auctions found",
-        filterKeys: ["status", TABLE_KEYS.SHOW_ENDED],
+        filterKeys: ["status"],
         defaultSort: sortBy("auctionEndDate", "ASC"),
         queryKey: ["seller", "auctions", "listing"],
         endpoint: SELLER_ENDPOINTS.AUCTIONS,
@@ -73,21 +72,20 @@ export function SellerAuctionsView({ children, onEditClick, onDelete, onBulkDele
         buildFilters: (state) => {
             // Previously missing entirely — the seller Auctions tab silently
             // listed the entire seller catalog, not just auctions.
+            //
+            // The hide-ended clause that used to live here is gone: it hard-coded
+            // `auctionEndDate >= now`, which is an INEQUALITY pushed straight into
+            // Firestore alongside whichever sort the toolbar happened to be on —
+            // the FAILED_PRECONDITION shape of Root Cause #59. The scope param now
+            // carries it, and `listPublicProducts` decides whether it can be pushed
+            // down or has to be applied over a bounded fetch.
             const parts = ["listingType==auction"];
             if (state.status && state.status !== "All")
                 parts.push(sieveFilter("status", SIEVE_OP.EQ, state.status));
-            if (state[TABLE_KEYS.SHOW_ENDED] !== "true") {
-                parts.push(sieveFilter("auctionEndDate", SIEVE_OP.GTE, new Date().toISOString()));
-            }
             return parts.join(",");
         },
-        toggles: [
-            {
-                label: "Show ended",
-                active: showEnded,
-                onChange: (next) => toggleTable.set(TABLE_KEYS.SHOW_ENDED, next ? "true" : ""),
-            },
-        ],
+        buildExtraParams: () => scope.extraParams,
+        renderAboveContent: scope.renderAboveContent,
         // Rule #7: bulk-action array sourced from the SELLER_BULK_ACTIONS preset.
         buildBulkActions: onBulkDelete
             ? (selection) => SELLER_BULK_ACTIONS.auctions.map((id) => ({

package/dist/features/seller/components/SellerBidsView.js

@@ -1,10 +1,11 @@
 "use client";
-import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
+import { jsx as _jsx, jsxs as _jsxs, Fragment as _Fragment } from "react/jsx-runtime";
 import { normalizeError } from "../../../errors/normalize";
 import { SIEVE_OP, Stack, sieveFilter } from "@mohasinac/appkit/client";
 import { sortBy } from "@mohasinac/appkit/client";
 import { useState, useCallback } from "react";
-import { Badge, Button, Div, FilterChipGroup, Span, Text, useToast } from "../../../ui";
+import { Badge, Button, Div, FilterChipGroup, RecordDetailModal, Span, Text, useToast } from "../../../ui";
+import { buildBidDetailFields, bidStatusBadge } from "../../auctions/components/bid-detail-fields";
 import { SELLER_ENDPOINTS } from "../../../constants/api-endpoints";
 import { ACTIONS } from "../../../_internal/shared/actions/action-registry";
 import { buildBulkAction } from "../../../_internal/shared/actions/bulk-helpers";
@@ -29,6 +30,7 @@ const STATUS_BADGE = {
     cancelled: "danger",
 };
 export function SellerBidsView({ endpoint = SELLER_ENDPOINTS.BIDS }) {
+    const [detail, setDetail] = useState(null);
     const { showToast } = useToast();
     const [collapsedGroups, setCollapsedGroups] = useState(new Set());
     const toggleGroup = (id) => setCollapsedGroups((s) => {
@@ -130,9 +132,14 @@ export function SellerBidsView({ endpoint = SELLER_ENDPOINTS.BIDS }) {
             }
             return (_jsx(Stack, { gap: "3", children: groupedRows.map((group) => {
                     const collapsed = collapsedGroups.has(group.id);
-                    return (_jsxs(Div, { className: "border border-[var(--appkit-color-border)] bg-[var(--appkit-color-surface)]", rounded: "lg", children: [_jsxs(Button, { variant: "ghost", type: "button", onClick: () => toggleGroup(group.id), justify: "between", paddingX: "md", paddingY: "y-xs-tall", textSize: "sm", weight: "semibold", textColor: "default", className: "w-full hover:bg-[var(--appkit-color-surface-raised)]", children: [_jsxs(Span, { className: "truncate", children: [group.title, " ", _jsxs(Span, { size: "xs", weight: "normal", className: "text-[var(--appkit-color-text-muted)]", children: ["\u00B7 ", group.bids.length, " bid", group.bids.length === 1 ? "" : "s"] })] }), _jsx(Span, { "aria-hidden": true, className: "text-[var(--appkit-color-text-muted)]", children: collapsed ? "▸" : "▾" })] }), !collapsed && (_jsx(Div, { className: "border-t border-[var(--appkit-color-border)]", children: _jsx(DataTable, { rows: group.bids, columns: columns, isLoading: false, emptyLabel: "", selectedIds: new Set(selection.selectedIds), onToggleSelect: selection.toggleSelect }) }))] }, group.id));
+                    return (_jsxs(Div, { className: "border border-[var(--appkit-color-border)] bg-[var(--appkit-color-surface)]", rounded: "lg", children: [_jsxs(Button, { variant: "ghost", type: "button", onClick: () => toggleGroup(group.id), justify: "between", paddingX: "md", paddingY: "y-xs-tall", textSize: "sm", weight: "semibold", textColor: "default", className: "w-full hover:bg-[var(--appkit-color-surface-raised)]", children: [_jsxs(Span, { className: "truncate", children: [group.title, " ", _jsxs(Span, { size: "xs", weight: "normal", className: "text-[var(--appkit-color-text-muted)]", children: ["\u00B7 ", group.bids.length, " bid", group.bids.length === 1 ? "" : "s"] })] }), _jsx(Span, { "aria-hidden": true, className: "text-[var(--appkit-color-text-muted)]", children: collapsed ? "▸" : "▾" })] }), !collapsed && (_jsx(Div, { className: "border-t border-[var(--appkit-color-border)]", children: _jsx(DataTable, { rows: group.bids, columns: columns, isLoading: false, emptyLabel: "", selectedIds: new Set(selection.selectedIds), onToggleSelect: selection.toggleSelect, 
+                                    // Without this the row could be selected and bulk-acted
+                                    // on but never opened — a seller could cancel a bid they
+                                    // had no way to read (Root Cause #56).
+                                    onRowClick: (row) => setDetail(row) }) }))] }, group.id));
                 }) }));
         },
     };
-    return _jsx(DataListingView, { config: config });
+    const detailBadge = detail ? bidStatusBadge(detail.status) : null;
+    return (_jsxs(_Fragment, { children: [_jsx(DataListingView, { config: config }), _jsx(RecordDetailModal, { isOpen: detail !== null, onClose: () => setDetail(null), title: detail?.productTitle || "Bid", badges: detailBadge ? [{ label: detailBadge.label }] : undefined, fields: detail ? buildBidDetailFields(detail, "seller") : undefined })] }));
 }

package/dist/features/seller/components/SellerClassifiedView.js

@@ -10,6 +10,8 @@ import { ROUTES } from "../../../constants/index";
 import { toRecordArray, toRelativeDate, toCurrency, toStringValue, } from "../../admin/hooks/useAdminListingData";
 import { DataListingView } from "../../admin/components/DataListingView";
 import { SELLER_BULK_ACTIONS, ROW_ACTION_META } from "../../products/constants/action-defs";
+import { useAvailabilityScope } from "../../products/hooks/useAvailabilityScope";
+const LISTING_TYPES = ["classified"];
 const COLUMNS = [
     { key: "title", header: "Listing", render: (row) => _jsx(Text, { size: "sm", weight: "medium", children: row.title }) },
     { key: "price", header: "Price", render: (row) => _jsx(Text, { className: "tabular-nums", size: "sm", children: row.price }) },
@@ -58,6 +60,7 @@ export function SellerClassifiedView({ onCreateClick, onEditClick, onDelete, onB
         else
             window.location.href = String(ROUTES.STORE.CLASSIFIED_NEW);
     }, [onCreateClick]);
+    const scope = useAvailabilityScope(LISTING_TYPES);
     const config = {
         portal: "seller",
         title: "Classified",
@@ -92,6 +95,8 @@ export function SellerClassifiedView({ onCreateClick, onEditClick, onDelete, onB
             ? response.meta.total
             : mappedRows.length,
         buildFilters: () => "listingType==classified",
+        buildExtraParams: () => scope.extraParams,
+        renderAboveContent: scope.renderAboveContent,
         primaryAction: { label: "New Classified", onClick: () => handleCreate() },
         // Mirrors the "Edit" row action below so table rows and cards both navigate on click.
         onRowClick: (row) => handleEdit(row.id),

package/dist/features/seller/components/SellerCouponEditorView.js

@@ -5,6 +5,8 @@ import { Badge, Button, Checkbox, Div, Form, Heading, IconButton, Input, Label,
 import { ProductInlineSelect } from "./ProductInlineSelect";
 import { CategoryInlineSelect } from "./CategoryInlineSelect";
 import { normalizeError } from "../../../errors/normalize";
+import { FormErrorSummary, applyZodIssues } from "../../../ui/forms";
+import { sellerCouponFormSchema } from "../schemas/coupon-form";
 const __O = {
     hidden: "overflow-hidden",
 };
@@ -39,22 +41,20 @@ export function SellerCouponEditorView({ couponId, initial, onSave, onCancel, })
     const [saving, setSaving] = useState(false);
     const [error, setError] = useState(null);
     const set = (key, value) => setDraft((d) => ({ ...d, [key]: value }));
-    const handleSubmit = async (e) => {
+    const handleSubmit = async (e, setFieldError) => {
         e.preventDefault();
-        if (!draft.code.trim()) {
-            setError("Coupon code is required");
-            return;
-        }
-        if (draft.type !== "free_shipping" && !draft.value) {
-            setError("Discount value is required");
-            return;
-        }
-        if (!draft.startDate || !draft.endDate) {
-            setError("Start and end dates are required");
-            return;
-        }
-        if (draft.startDate > draft.endDate) {
-            setError("Start date must be before end date");
+        // Replaces four hand-rolled `if` checks that covered presence and date
+        // order and nothing else — a 500% percentage discount, a non-numeric
+        // value, a negative minimum spend and a per-customer limit above the
+        // total all passed. Errors now land on the field, not in one banner.
+        const parsed = sellerCouponFormSchema.safeParse(draft);
+        if (!parsed.success) {
+            if (setFieldError) {
+                applyZodIssues(parsed.error.issues, setFieldError);
+            }
+            else {
+                setError(parsed.error.issues[0]?.message ?? "Please check the form.");
+            }
             return;
         }
         setError(null);
@@ -71,11 +71,11 @@ export function SellerCouponEditorView({ couponId, initial, onSave, onCancel, })
         }
     };
     const isEdit = Boolean(couponId);
-    return (_jsx(Form, { onSubmit: handleSubmit, noValidate: true, children: _jsxs(Stack, { gap: "none", className: `max-w-lg mx-auto border border-[var(--appkit-color-border)] bg-[var(--appkit-color-surface)] ${__O.hidden}`, rounded: "xl", shadow: "sm", children: [_jsx(Div, { className: "h-[3px] w-full [background:linear-gradient(to_right,var(--appkit-color-primary-700)_0%,var(--appkit-color-cobalt)_55%,var(--appkit-color-secondary-400)_100%)]", "aria-hidden": "true" }), _jsx(Div, { border: "bottom", paddingY: "y-md-lg", padding: "x-lg", children: _jsxs(Row, { justify: "between", gap: "3", children: [_jsx(Heading, { level: 2, className: "text-[var(--appkit-color-text)]", size: "lg", weight: "semibold", children: isEdit ? "Edit Coupon" : "Create Coupon" }), isEdit && (_jsx(Badge, { variant: draft.isActive ? "success" : "default", children: draft.isActive ? "Active" : "Inactive" }))] }) }), _jsxs(Stack, { gap: "5", padding: "lg", children: [error && (_jsx(Div, { textSize: "sm", className: "border border-error/20", color: "error", surface: "danger-surface", padding: "inline", rounded: "lg", children: error })), _jsx(Input, { label: "Coupon Code", value: draft.code, onChange: (e) => set("code", e.target.value.toUpperCase().replace(/\s+/g, "")), placeholder: "e.g. WELCOME10", required: true, disabled: isEdit, helperText: isEdit ? "Code cannot be changed after creation" : "Customers enter this at checkout" }), _jsx(Select, { label: "Discount Type", value: draft.type, options: TYPE_OPTIONS, onChange: (e) => set("type", e.target.value) }), draft.type !== "free_shipping" && (_jsx(Input, { label: draft.type === "percentage" ? "Discount Percentage (%)" : "Discount Amount (₹)", type: "number", min: 1, max: draft.type === "percentage" ? 100 : undefined, value: draft.value, onChange: (e) => set("value", e.target.value), placeholder: draft.type === "percentage" ? "e.g. 10" : "e.g. 50", required: true, helperText: draft.type === "percentage"
+    return (_jsx(Form, { schema: sellerCouponFormSchema, onSubmit: (e) => e.preventDefault(), children: ({ setFieldError }) => (_jsxs(Stack, { gap: "none", className: `max-w-lg mx-auto border border-[var(--appkit-color-border)] bg-[var(--appkit-color-surface)] ${__O.hidden}`, rounded: "xl", shadow: "sm", children: [_jsx(Div, { className: "h-[3px] w-full [background:linear-gradient(to_right,var(--appkit-color-primary-700)_0%,var(--appkit-color-cobalt)_55%,var(--appkit-color-secondary-400)_100%)]", "aria-hidden": "true" }), _jsx(Div, { border: "bottom", paddingY: "y-md-lg", padding: "x-lg", children: _jsxs(Row, { justify: "between", gap: "3", children: [_jsx(Heading, { level: 2, className: "text-[var(--appkit-color-text)]", size: "lg", weight: "semibold", children: isEdit ? "Edit Coupon" : "Create Coupon" }), isEdit && (_jsx(Badge, { variant: draft.isActive ? "success" : "default", children: draft.isActive ? "Active" : "Inactive" }))] }) }), _jsxs(Stack, { gap: "5", padding: "lg", children: [_jsx(FormErrorSummary, {}), error && (_jsx(Div, { textSize: "sm", className: "border border-error/20", color: "error", surface: "danger-surface", padding: "inline", rounded: "lg", children: error })), _jsx(Input, { label: "Coupon Code", value: draft.code, onChange: (e) => set("code", e.target.value.toUpperCase().replace(/\s+/g, "")), placeholder: "e.g. WELCOME10", required: true, disabled: isEdit, helperText: isEdit ? "Code cannot be changed after creation" : "Customers enter this at checkout" }), _jsx(Select, { label: "Discount Type", value: draft.type, options: TYPE_OPTIONS, onChange: (e) => set("type", e.target.value) }), draft.type !== "free_shipping" && (_jsx(Input, { label: draft.type === "percentage" ? "Discount Percentage (%)" : "Discount Amount (₹)", type: "number", min: 1, max: draft.type === "percentage" ? 100 : undefined, value: draft.value, onChange: (e) => set("value", e.target.value), placeholder: draft.type === "percentage" ? "e.g. 10" : "e.g. 50", required: true, helperText: draft.type === "percentage"
                                 ? "Enter a value between 1 and 100"
                                 : "Fixed rupee discount applied to the order" })), draft.type === "percentage" && (_jsx(Input, { label: "Max Discount Cap (\u20B9, optional)", type: "number", min: 0, value: draft.maxDiscount, onChange: (e) => set("maxDiscount", e.target.value), placeholder: "Leave blank for no cap", helperText: "Maximum rupee discount regardless of percentage" })), _jsx(Input, { label: "Minimum Order Amount (\u20B9, optional)", type: "number", min: 0, value: draft.minPurchase, onChange: (e) => set("minPurchase", e.target.value), placeholder: "Leave blank for no minimum" }), _jsxs(Div, { children: [_jsx(Text, { size: "sm", className: CLS_SECTION_LABEL, children: "Usage Limits" }), _jsxs(Div, { layout: "grid", gap: "3", className: "grid-cols-2", children: [_jsx(Input, { label: "Total Uses", type: "number", min: 0, value: draft.totalLimit, onChange: (e) => set("totalLimit", e.target.value), placeholder: "0 = unlimited" }), _jsx(Input, { label: "Per Customer", type: "number", min: 0, value: draft.perUserLimit, onChange: (e) => set("perUserLimit", e.target.value), placeholder: "0 = unlimited" })] })] }), _jsxs(Div, { children: [_jsx(Text, { size: "sm", className: CLS_SECTION_LABEL, children: "Validity Period" }), _jsxs(Div, { layout: "grid", gap: "3", className: "grid-cols-2", children: [_jsx(Input, { label: "Start Date", type: "date", value: draft.startDate, onChange: (e) => set("startDate", e.target.value), required: true }), _jsx(Input, { label: "End Date", type: "date", value: draft.endDate, onChange: (e) => set("endDate", e.target.value), required: true })] })] }), _jsxs(Div, { children: [_jsx(Text, { size: "sm", className: CLS_SECTION_LABEL, children: "Applicability (optional)" }), _jsxs(Stack, { gap: "sm", children: [_jsxs(Div, { children: [_jsx(Text, { size: "xs", className: "mb-1 text-[var(--appkit-color-text-secondary)]", children: "Applicable products" }), _jsx(ProductInlineSelect, { scope: "store", multiple: true, value: draft.applicableProducts, onChange: (v) => set("applicableProducts", v), placeholder: "Restrict to specific products\u2026" })] }), _jsxs(Div, { children: [_jsx(Text, { size: "xs", className: "mb-1 text-[var(--appkit-color-text-secondary)]", children: "Applicable categories" }), _jsx(CategoryInlineSelect, { value: "", onChange: (id) => {
                                                         if (!id || draft.applicableCategories.includes(id))
                                                             return;
                                                         set("applicableCategories", [...draft.applicableCategories, id]);
-                                                    }, placeholder: "Add a category\u2026" }), draft.applicableCategories.length > 0 && (_jsx(Row, { wrap: true, gap: "sm", padding: "t-xs", children: draft.applicableCategories.map((cid) => (_jsxs(Span, { layout: "inline-flex", gap: "xs", border: "strong", padding: "pill-sm", rounded: "full", surface: "muted", color: "primary", size: "xs", children: [cid, _jsx(IconButton, { type: "button", "aria-label": `Remove ${cid}`, variant: "ghost", className: "text-[var(--appkit-color-text-muted)] hover:text-[var(--appkit-color-text)]", onClick: () => set("applicableCategories", draft.applicableCategories.filter((c) => c !== cid)), children: "\u00D7" })] }, cid))) }))] }), _jsx(Text, { size: "xs", className: "text-[var(--appkit-color-text-secondary)]", children: "Leave both empty to apply the coupon to every product in your store." })] })] }), _jsx(Row, { className: "border border-[var(--appkit-color-border)] dark:border-[var(--appkit-color-border-dark)]", padding: "inline", align: "center", gap: "3", rounded: "lg", children: _jsxs(Label, { layout: "flex", gap: "lg", className: "cursor-pointer w-full", children: [_jsx(Checkbox, { bare: true, checked: draft.isActive, onChange: (e) => set("isActive", e.target.checked), className: "h-4 w-4 rounded border-[var(--appkit-color-border)] text-[var(--appkit-color-primary)] focus:ring-[var(--appkit-color-primary)]" }), _jsxs(Div, { className: "flex-1 min-w-0", children: [_jsx(Text, { size: "sm", className: "text-[var(--appkit-color-text-primary)]", weight: "medium", children: "Active" }), _jsx(Text, { size: "xs", className: "text-[var(--appkit-color-text-secondary)]", children: "Customers can apply this coupon at checkout" })] })] }) })] }), _jsx(Div, { className: "border-t border-[var(--appkit-color-border)]", padding: "inlineLg", children: _jsxs(Row, { justify: "end", gap: "3", children: [onCancel && (_jsx(Button, { type: "button", variant: "outline", onClick: onCancel, disabled: saving, children: "Cancel" })), _jsx(Button, { type: "submit", isLoading: saving, disabled: saving, children: isEdit ? "Save Changes" : "Create Coupon" })] }) })] }) }));
+                                                    }, placeholder: "Add a category\u2026" }), draft.applicableCategories.length > 0 && (_jsx(Row, { wrap: true, gap: "sm", padding: "t-xs", children: draft.applicableCategories.map((cid) => (_jsxs(Span, { layout: "inline-flex", gap: "xs", border: "strong", padding: "pill-sm", rounded: "full", surface: "muted", color: "primary", size: "xs", children: [cid, _jsx(IconButton, { type: "button", "aria-label": `Remove ${cid}`, variant: "ghost", className: "text-[var(--appkit-color-text-muted)] hover:text-[var(--appkit-color-text)]", onClick: () => set("applicableCategories", draft.applicableCategories.filter((c) => c !== cid)), children: "\u00D7" })] }, cid))) }))] }), _jsx(Text, { size: "xs", className: "text-[var(--appkit-color-text-secondary)]", children: "Leave both empty to apply the coupon to every product in your store." })] })] }), _jsx(Row, { className: "border border-[var(--appkit-color-border)] dark:border-[var(--appkit-color-border-dark)]", padding: "inline", align: "center", gap: "3", rounded: "lg", children: _jsxs(Label, { layout: "flex", gap: "lg", className: "cursor-pointer w-full", children: [_jsx(Checkbox, { bare: true, checked: draft.isActive, onChange: (e) => set("isActive", e.target.checked), className: "h-4 w-4 rounded border-[var(--appkit-color-border)] text-[var(--appkit-color-primary)] focus:ring-[var(--appkit-color-primary)]" }), _jsxs(Div, { className: "flex-1 min-w-0", children: [_jsx(Text, { size: "sm", className: "text-[var(--appkit-color-text-primary)]", weight: "medium", children: "Active" }), _jsx(Text, { size: "xs", className: "text-[var(--appkit-color-text-secondary)]", children: "Customers can apply this coupon at checkout" })] })] }) })] }), _jsx(Div, { className: "border-t border-[var(--appkit-color-border)]", padding: "inlineLg", children: _jsxs(Row, { justify: "end", gap: "3", children: [onCancel && (_jsx(Button, { type: "button", variant: "outline", onClick: onCancel, disabled: saving, children: "Cancel" })), _jsx(Button, { type: "submit", isLoading: saving, disabled: saving, onClick: (e) => void handleSubmit(e, setFieldError), children: isEdit ? "Save Changes" : "Create Coupon" })] }) })] })) }));
 }