@mohasinac/appkit 4.13.1 → 4.15.0

package/dist/features/pre-orders/components/PreOrdersIndexListing.js

@@ -21,6 +21,9 @@ import { useBulkSelection } from "../../../react/hooks/useBulkSelection";
 import { TABLE_KEYS, VIEW_MODE } from "../../../constants/table-keys";
 import { PREORDER_SORT_OPTIONS } from "../../products/constants/sieve";
 import { useBottomActions } from "../../layout";
+import { AVAILABILITY_VALUES } from "../../../constants/field-names";
+import { AvailabilityTabs } from "../../products/components/AvailabilityTabs";
+const PRE_ORDER_LISTING_TYPES = ["pre-order"];
 const __P = {
     p3: "p-[var(--appkit-space-3)]",
 };
@@ -36,7 +39,8 @@ export function PreOrdersIndexListing({ initialData, categorySlug, brandName })
     const [searchInput, setSearchInput] = useState(table.get(TABLE_KEYS.QUERY) || "");
     const [filterOpen, setFilterOpen] = useState(false);
     const [compareIds, setCompareIds] = useState([]);
-    const showClosed = table.get(TABLE_KEYS.SHOW_CLOSED) === "true";
+    const availability = table.get(TABLE_KEYS.AVAILABILITY) ||
+        AVAILABILITY_VALUES.AVAILABLE;
     const [view, setView] = useState(table.get(TABLE_KEYS.VIEW) || VIEW_MODE.GRID);
     const localCart = useGuestCart();
     const localWishlist = useGuestWishlist();
@@ -54,11 +58,11 @@ export function PreOrdersIndexListing({ initialData, categorySlug, brandName })
         setFilterOpen(false);
     }, [onFilterApply]);
     const resetAll = useCallback(() => {
-        onResetAll({ [TABLE_KEYS.QUERY]: "", [TABLE_KEYS.SORT]: "", [TABLE_KEYS.SHOW_CLOSED]: "" });
+        onResetAll({ [TABLE_KEYS.QUERY]: "", [TABLE_KEYS.SORT]: "", [TABLE_KEYS.AVAILABILITY]: "" });
         setSearchInput("");
     }, [onResetAll]);
     const hasActiveState = !!table.get(TABLE_KEYS.QUERY) ||
-        table.get(TABLE_KEYS.SHOW_CLOSED) === "true" ||
+        availability !== AVAILABILITY_VALUES.AVAILABLE ||
         table.get(TABLE_KEYS.SORT) !== DEFAULT_SORT ||
         filterActiveCount > 0;
     const params = {
@@ -76,9 +80,12 @@ export function PreOrdersIndexListing({ initialData, categorySlug, brandName })
         page: table.getNumber(TABLE_KEYS.PAGE, 1),
         perPage: table.getNumber(TABLE_KEYS.PAGE_SIZE, 24),
         listingType: "pre-order",
-        // Hide out-of-stock pre-orders by default. Uses stockQuantity>0 (always-present field).
-        // Quota over-sign is intentional — never block pre-orders by availability.
-        inStock: showClosed ? undefined : true,
+        // "Closed" for a pre-order means its allocation filled, which the shared
+        // per-type predicate resolves from preOrderCurrentCount vs
+        // preOrderMaxQuantity. This used to be a bare stockQuantity>0, which is
+        // a DIFFERENT question and disagreed with what /products asked of the
+        // same rows.
+        availability,
     };
     const { products: preOrders, totalPages, page, isLoading } = useProducts(params, { initialData });
     const commitSearch = useCallback(() => {
@@ -175,9 +182,7 @@ export function PreOrdersIndexListing({ initialData, categorySlug, brandName })
                     },
                 },
             ] } } : {});
-    return (_jsxs(Div, { className: "min-h-screen", children: [_jsx(ListingToolbar, { filterCount: filterActiveCount, onFiltersClick: openFilters, searchValue: searchInput, searchPlaceholder: "Search pre-orders...", onSearchChange: setSearchInput, onSearchCommit: commitSearch, onSearchKeyDown: handleSearchKeyDown, sortValue: table.get(TABLE_KEYS.SORT) || DEFAULT_SORT, sortOptions: PREORDER_SORT_OPTIONS, onSortChange: (v) => { table.set(TABLE_KEYS.SORT, v); }, view: view, onViewChange: handleViewToggle, onResetAll: resetAll, hasActiveState: hasActiveState, bulkMode: selection.isSelecting, bulkSelectedCount: selection.selectedCount, bulkTotalCount: preOrders.length, onBulkSelectAll: selection.toggleAll, onBulkClear: selection.clearSelection, toggles: [
-                    { label: "Show closed", active: showClosed, onChange: (next) => table.set(TABLE_KEYS.SHOW_CLOSED, next ? "true" : "") },
-                ] }), _jsx(BulkActionBar, { selectedCount: selection.selectedCount, onClearSelection: selection.clearSelection, actions: [
+    return (_jsxs(Div, { className: "min-h-screen", children: [_jsx(ListingToolbar, { filterCount: filterActiveCount, onFiltersClick: openFilters, searchValue: searchInput, searchPlaceholder: "Search pre-orders...", onSearchChange: setSearchInput, onSearchCommit: commitSearch, onSearchKeyDown: handleSearchKeyDown, sortValue: table.get(TABLE_KEYS.SORT) || DEFAULT_SORT, sortOptions: PREORDER_SORT_OPTIONS, onSortChange: (v) => { table.set(TABLE_KEYS.SORT, v); }, view: view, onViewChange: handleViewToggle, onResetAll: resetAll, hasActiveState: hasActiveState, bulkMode: selection.isSelecting, bulkSelectedCount: selection.selectedCount, bulkTotalCount: preOrders.length, onBulkSelectAll: selection.toggleAll, onBulkClear: selection.clearSelection }), _jsx(Div, { padding: "y-sm", children: _jsx(AvailabilityTabs, { types: PRE_ORDER_LISTING_TYPES }) }), _jsx(BulkActionBar, { selectedCount: selection.selectedCount, onClearSelection: selection.clearSelection, actions: [
                     {
                         id: ACTION_ID.ADD_TO_CART,
                         label: ACTION_META[ACTION_ID.ADD_TO_CART].label,

package/dist/features/pre-orders/components/PreOrdersListView.js

@@ -2,19 +2,20 @@ import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
 import { Container, Main, Heading, Section } from "../../../ui";
 import { AdSlot } from "../../homepage/components/AdSlot";
 import { PreOrdersIndexListing } from "./PreOrdersIndexListing";
-import { listPublicProducts, parsePublicProductParams, } from "../../../_internal/server/features/products/list-public";
+import { listPublicProducts, parsePublicProductParams, defaultAvailabilityForListingTypes, } from "../../../_internal/server/features/products/list-public";
 const PRE_ORDER_LISTING_TYPES = ["pre-order"];
 const DEFAULT_PAGE_SIZE = 24;
 const DEFAULT_SORT = "-createdAt";
 export async function PreOrdersListView({ searchParams = {} }) {
-    // Shared with /api/products. `hideSoldByDefault` covers this page's
-    // "Show closed" toggle — the stockQuantity predicate runs in memory over a
-    // bounded fetch because the default sort is createdAt, not stockQuantity.
+    // Shared with /api/products, and derived rather than hardcoded. This view
+    // carried a literal `hideSoldByDefault: true` until 2026-08-24 even though
+    // pre-order's registered hide-default is "closed" — so /pre-orders and
+    // /products disagreed about what "closed" meant for the same rows.
     const result = await listPublicProducts(parsePublicProductParams(searchParams, {
         listingTypes: PRE_ORDER_LISTING_TYPES,
         pageSize: DEFAULT_PAGE_SIZE,
         sorts: DEFAULT_SORT,
-        hideSoldByDefault: true,
+        ...defaultAvailabilityForListingTypes(PRE_ORDER_LISTING_TYPES),
     }));
     return (_jsx(Main, { children: _jsx(Section, { padding: "y-2xl", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 1, className: "mb-8", color: "primary", size: "3xl", weight: "semibold", children: "Pre-Orders" }), _jsx(AdSlot, { id: "listing-sidebar-top", className: "mb-6" }), _jsx(PreOrdersIndexListing, { initialData: result ?? undefined }), _jsx(AdSlot, { id: "listing-sidebar-bottom", className: "mt-8" })] }) }) }));
 }

package/dist/features/pre-orders/schemas/index.d.ts

@@ -79,6 +79,7 @@ export declare const preorderItemSchema: z.ZodObject<{
     createdAt?: string | undefined;
     active?: boolean | undefined;
     images?: string[] | undefined;
+    isFeatured?: boolean | undefined;
     media?: {
         type: "video" | "image" | "file";
         url: string;
@@ -88,7 +89,6 @@ export declare const preorderItemSchema: z.ZodObject<{
         youtubeId?: string | undefined;
         duration?: number | undefined;
     }[] | undefined;
-    isFeatured?: boolean | undefined;
     franchise?: string | undefined;
     preorderShipDate?: string | undefined;
 }>;

package/dist/features/products/actions/product-actions.d.ts

@@ -16,10 +16,24 @@ export type ProductListResult = FirebaseSieveResult<ProductDocument>;
 export declare function listProducts(params?: ProductListActionParams): Promise<ProductListResult>;
 export declare function getProductById(id: string): Promise<ProductDocument | null>;
 export declare function getFeaturedProducts(pageSize?: number): Promise<ProductListResult>;
+/**
+ * The soonest-ending LIVE auctions.
+ *
+ * This used to be `listingType==auction,status==published` sorted
+ * `auctionEndDate ASC` with no lower bound — and ascending order front-loads
+ * the OLDEST end dates, so the homepage's "Live Auctions" strip led with the
+ * most-expired lots in the catalogue. Nothing about it was flagged as wrong
+ * because an ended auction still renders as a perfectly normal card.
+ *
+ * One listing type, sorted by the same field the scope filters on, means
+ * `listPublicProducts` pushes `auctionEndDate >= now` into Firestore rather
+ * than filtering a bounded window in memory.
+ */
 export declare function getFeaturedAuctions(pageSize?: number): Promise<ProductListResult>;
 export declare function getLatestProducts(pageSize?: number): Promise<ProductListResult>;
 export declare function getLatestAuctions(pageSize?: number): Promise<ProductListResult>;
 export declare function listAuctions(params?: ProductListActionParams): Promise<ProductListResult>;
+/** Pre-orders still accepting orders, soonest delivery first. */
 export declare function getFeaturedPreOrders(pageSize?: number): Promise<ProductListResult>;
 export declare function getLatestPreOrders(pageSize?: number): Promise<ProductListResult>;
 export declare function listPreOrders(params?: ProductListActionParams): Promise<ProductListResult>;

package/dist/features/products/actions/product-actions.js

@@ -1,5 +1,7 @@
 import { sieveAnd, sieveFilter, SIEVE_OP } from "@mohasinac/appkit";
 import { sortBy } from "@mohasinac/appkit";
+import { listPublicProducts } from "../../../_internal/server/features/products/list-public";
+import { AVAILABILITY_VALUES, PRODUCT_FIELDS } from "../../../constants/field-names";
 import { productRepository } from "../repository/products.repository";
 import { ProductStatusValues } from "../schemas";
 /**
@@ -34,21 +36,55 @@ export async function listProducts(params = {}) {
 export async function getProductById(id) {
     return productRepository.findById(id);
 }
+/**
+ * `PublicProductListResult` → the `FirebaseSieveResult<ProductDocument>` shape
+ * these helpers have always returned, so their ~15 call sites (including the
+ * six server-action wrappers in `src/actions/product.actions.ts` and their
+ * tests) are unchanged by the switch to the shared query.
+ */
+function toListResult(result, pageSize) {
+    if (!result) {
+        return { items: [], total: 0, page: 1, pageSize, totalPages: 0, hasMore: false };
+    }
+    return {
+        items: result.items,
+        total: result.total,
+        page: result.page,
+        pageSize: result.pageSize,
+        totalPages: result.totalPages,
+        hasMore: result.hasMore,
+    };
+}
 export async function getFeaturedProducts(pageSize = 8) {
-    return productRepository.list({
-        filters: sieveAnd(sieveFilter("featured", SIEVE_OP.EQ, "true"), PUBLISHED_CLAUSE),
+    return toListResult(await listPublicProducts({
+        featured: true,
+        availability: AVAILABILITY_VALUES.AVAILABLE,
         sorts: sortBy("createdAt", "DESC"),
         page: 1,
         pageSize,
-    });
+    }), pageSize);
 }
+/**
+ * The soonest-ending LIVE auctions.
+ *
+ * This used to be `listingType==auction,status==published` sorted
+ * `auctionEndDate ASC` with no lower bound — and ascending order front-loads
+ * the OLDEST end dates, so the homepage's "Live Auctions" strip led with the
+ * most-expired lots in the catalogue. Nothing about it was flagged as wrong
+ * because an ended auction still renders as a perfectly normal card.
+ *
+ * One listing type, sorted by the same field the scope filters on, means
+ * `listPublicProducts` pushes `auctionEndDate >= now` into Firestore rather
+ * than filtering a bounded window in memory.
+ */
 export async function getFeaturedAuctions(pageSize = 6) {
-    return productRepository.list({
-        filters: AUCTIONS_PUBLISHED,
-        sorts: sortBy("auctionEndDate", "ASC"),
+    return toListResult(await listPublicProducts({
+        listingTypes: [PRODUCT_FIELDS.LISTING_TYPE_VALUES.AUCTION],
+        availability: AVAILABILITY_VALUES.AVAILABLE,
+        sorts: sortBy(PRODUCT_FIELDS.AUCTION_END_DATE, "ASC"),
         page: 1,
         pageSize,
-    });
+    }), pageSize);
 }
 export async function getLatestProducts(pageSize = 12) {
     return productRepository.list({
@@ -75,13 +111,15 @@ export async function listAuctions(params = {}) {
         pageSize,
     });
 }
+/** Pre-orders still accepting orders, soonest delivery first. */
 export async function getFeaturedPreOrders(pageSize = 6) {
-    return productRepository.list({
-        filters: PREORDERS_PUBLISHED,
-        sorts: sortBy("preOrderDeliveryDate", "ASC"),
+    return toListResult(await listPublicProducts({
+        listingTypes: [PRODUCT_FIELDS.LISTING_TYPE_VALUES.PRE_ORDER],
+        availability: AVAILABILITY_VALUES.AVAILABLE,
+        sorts: sortBy(PRODUCT_FIELDS.PRE_ORDER_DELIVERY_DATE, "ASC"),
         page: 1,
         pageSize,
-    });
+    }), pageSize);
 }
 export async function getLatestPreOrders(pageSize = 12) {
     return productRepository.list({

package/dist/features/products/api/route.d.ts

@@ -13,6 +13,18 @@
  * resolved from `getProviders().db.getRepository("products")`.
  */
 import { NextResponse } from "next/server.js";
+/**
+ * Delegates to `listPublicProducts` — the single implementation shared with
+ * every SSR listing view and with the reference consumer's own route.
+ *
+ * It used to be an independent copy: its own `buildFilters`, its own
+ * `validateSieveFilters`, and its own filter allowlist that omitted
+ * `auctionEndDate` / `preOrderDeliveryDate` / `prizeRevealStatus` — so on this
+ * path an ended auction could not be filtered out even by a caller that asked
+ * for it, and an `inStock=true` became a raw `stockQuantity>0` pushed straight
+ * into Firestore, the FAILED_PRECONDITION shape Root Cause #59 documents.
+ * Two implementations of one query is the drift itself; there is now one.
+ */
 export declare function GET(request: Request): Promise<NextResponse>;
 export declare const POST: (request: Request, context?: {
     params: Promise<Record<string, string>>;

package/dist/features/products/api/route.js

@@ -19,6 +19,7 @@ import { createRouteHandler } from "../../../next";
 import { mediaFieldSchema } from "../../media/types/index";
 import { printMetaSchema } from "../schemas/index";
 import { sanitizeProductsForPublic } from "../utils/sanitize";
+import { listPublicProducts, parsePublicProductParams, } from "../../../_internal/server/features/products/list-public";
 import { normalizeError } from "../../../errors/normalize";
 // --- Mutation schemas ---------------------------------------------------------
 // Minimal schemas for secured mutations — consumer apps can extend as needed.
@@ -49,8 +50,11 @@ const productMutateSchema = z
     sellerName: z.string().optional(),
     sellerEmail: z.string().email().optional(),
     slug: z.string().optional(),
+    // `bundle` is deliberately absent: SB-UNI-D moved bundles onto
+    // `categories` as a categoryType, so a product written with that value
+    // would match no listing-type query anywhere.
     listingType: z
-        .enum(["standard", "auction", "pre-order", "prize-draw", "bundle", "classified", "digital-code", "live", "art", "stickers"])
+        .enum(["standard", "auction", "pre-order", "prize-draw", "classified", "digital-code", "live", "art", "stickers"])
         .optional(),
     media: z.array(mediaFieldSchema).optional(),
 })
@@ -59,114 +63,52 @@ const productMutateSchema = z
 function param(url, key) {
     return url.searchParams.get(key);
 }
-function numParam(url, key, fallback) {
-    const v = url.searchParams.get(key);
-    const n = v !== null ? Number(v) : NaN;
-    return Number.isFinite(n) ? n : fallback;
-}
-/** Public fields callers may filter on via the ?filters= param. */
-const SAFE_PRODUCT_FILTER_FIELDS = new Set([
-    "status",
-    "category",
-    "brand",
-    "condition",
-    "storeId",
-    "title",
-    "price",
-    "listingType",
-    "featured",
-    "isPromoted",
-    "stockQuantity",
-    "availableQuantity",
-    "tags",
-]);
+// --- GET /api/products --------------------------------------------------------
 /**
- * Validates a raw Sieve filter string against an allowlist of safe fields.
- * Drops any clause whose field name is not in the allowlist.
+ * Delegates to `listPublicProducts` — the single implementation shared with
+ * every SSR listing view and with the reference consumer's own route.
+ *
+ * It used to be an independent copy: its own `buildFilters`, its own
+ * `validateSieveFilters`, and its own filter allowlist that omitted
+ * `auctionEndDate` / `preOrderDeliveryDate` / `prizeRevealStatus` — so on this
+ * path an ended auction could not be filtered out even by a caller that asked
+ * for it, and an `inStock=true` became a raw `stockQuantity>0` pushed straight
+ * into Firestore, the FAILED_PRECONDITION shape Root Cause #59 documents.
+ * Two implementations of one query is the drift itself; there is now one.
  */
-function validateSieveFilters(raw, allowedFields) {
-    return raw
-        .split(",")
-        .map((c) => c.trim())
-        .filter((c) => {
-        const m = c.match(/^([^<>=!@]+)\s*(?:==|!=|<=|>=|<|>|@=\*?)/);
-        return m ? allowedFields.has(m[1].trim()) : false;
-    })
-        .join(",");
-}
-function buildFilters(url) {
-    const parts = [];
-    const status = param(url, "status");
-    if (status)
-        parts.push(`status==${status}`);
-    const category = param(url, "category");
-    if (category)
-        parts.push(`category==${category}`);
-    const brand = param(url, "brand");
-    if (brand)
-        parts.push(`brand==${brand}`);
-    const condition = param(url, "condition");
-    if (condition)
-        parts.push(`condition==${condition}`);
-    const storeId = param(url, "storeId");
-    if (storeId)
-        parts.push(`storeId==${storeId}`);
-    const q = param(url, "q");
-    if (q)
-        parts.push(`title@=*${q}`);
-    const minPrice = param(url, "minPrice");
-    if (minPrice !== null && !Number.isNaN(Number(minPrice)))
-        parts.push(`price>=${minPrice}`);
-    const maxPrice = param(url, "maxPrice");
-    if (maxPrice !== null && !Number.isNaN(Number(maxPrice)))
-        parts.push(`price<=${maxPrice}`);
-    const inStock = param(url, "inStock");
-    if (inStock === "true")
-        parts.push("stockQuantity>0");
-    // SB1-G — canonical discriminator. Public URL accepts only ?listingType=X.
-    const listingTypeParam = param(url, "listingType");
-    if (listingTypeParam) {
-        parts.push(`listingType==${listingTypeParam}`);
-    }
-    const featured = param(url, "featured");
-    if (featured === "true")
-        parts.push("featured==true");
-    // Merge validated Sieve filters — only safe public fields allowed
-    const raw = param(url, "filters");
-    if (raw) {
-        const safe = validateSieveFilters(raw, SAFE_PRODUCT_FILTER_FIELDS);
-        if (safe)
-            parts.push(safe);
-    }
-    return parts.join(",");
-}
-// --- GET /api/products --------------------------------------------------------
 export async function GET(request) {
     try {
         const url = new URL(request.url);
-        const page = numParam(url, "page", 1);
-        const pageSize = numParam(url, "pageSize", 20);
-        const sort = param(url, "sorts") ?? param(url, "sort") ?? "-createdAt";
-        const filters = buildFilters(url);
-        const { db } = getProviders();
-        if (!db) {
-            return NextResponse.json({ success: false, error: "Database provider not registered" }, { status: 503 });
+        const listingTypeParam = param(url, "listingType");
+        const requestedTypes = (listingTypeParam ?? "").split("|").filter(Boolean);
+        const result = await listPublicProducts(parsePublicProductParams(url.searchParams, {
+            listingTypes: requestedTypes.length > 0 ? requestedTypes : undefined,
+        }));
+        if (!result) {
+            // Already logged loudly by listPublicProducts. Surfaced as an explicit
+            // warning rather than a bare empty page, so a broken query stays
+            // distinguishable from an empty catalogue.
+            return NextResponse.json({
+                success: true,
+                data: {
+                    items: [],
+                    total: 0,
+                    page: 1,
+                    pageSize: 0,
+                    totalPages: 0,
+                    hasMore: false,
+                    warning: "Product search is temporarily unavailable.",
+                },
+            });
         }
-        const repo = db.getRepository("products");
-        const result = await repo.findAll({
-            filters,
-            sort,
-            page,
-            perPage: pageSize,
-        });
-        const totalPages = Math.max(1, Math.ceil(result.total / pageSize));
         const body = {
-            items: sanitizeProductsForPublic(result.data),
+            items: sanitizeProductsForPublic(result.items),
             total: result.total,
             page: result.page,
-            pageSize,
-            totalPages,
-            hasMore: result.page < totalPages,
+            pageSize: result.pageSize,
+            totalPages: result.totalPages,
+            hasMore: result.hasMore,
+            truncated: result.truncated,
         };
         const response = NextResponse.json({ success: true, data: body });
         response.headers.set("Cache-Control", "public, max-age=60, s-maxage=120, stale-while-revalidate=60");

package/dist/features/products/components/ArtStickersListView.js

@@ -5,7 +5,7 @@ import { ProductsIndexListing } from "./ProductsIndexListing";
 import { PRODUCT_FIELDS } from "../../../constants/field-names";
 import { sortBy } from "../../../constants/sort";
 import { ART_STICKERS_TYPE_FILTER_TABS, ART_STICKERS_LISTING_TYPES, } from "../constants/listing-tabs";
-import { listPublicProducts, parsePublicProductParams, defaultTogglesForListingTypes, } from "../../../_internal/server/features/products/list-public";
+import { listPublicProducts, parsePublicProductParams, defaultAvailabilityForListingTypes, } from "../../../_internal/server/features/products/list-public";
 const DEFAULT_PAGE_SIZE = 24;
 const DEFAULT_SORT = sortBy(PRODUCT_FIELDS.CREATED_AT);
 export async function ArtStickersListView({ searchParams = {} }) {
@@ -18,7 +18,7 @@ export async function ArtStickersListView({ searchParams = {} }) {
         sorts: DEFAULT_SORT,
         // Derived, so this page and ProductsIndexListing can never disagree
         // about the default view (Root Cause #30).
-        ...defaultTogglesForListingTypes(ART_STICKERS_LISTING_TYPES),
+        ...defaultAvailabilityForListingTypes(ART_STICKERS_LISTING_TYPES),
     }));
     return (_jsxs(Main, { children: [_jsx(Section, { border: "bottom-subtle", paddingY: "b-md", padding: "t-xl", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 1, size: "3xl", weight: "bold", color: "primary", children: "Art & Stickers" }), _jsx(Text, { className: "mt-1", color: "muted", size: "sm", children: "Original art prints and sticker packs from independent sellers" })] }) }), _jsxs(Container, { size: "xl", padding: "x-md", children: [_jsx(AdSlot, { id: "listing-sidebar-top", className: "mb-4 mt-4" }), _jsx(ProductsIndexListing, { initialData: result ?? null, listingTypes: ART_STICKERS_LISTING_TYPES, typeTabs: ART_STICKERS_TYPE_FILTER_TABS, searchPlaceholder: "Search art & stickers..." }), _jsx(AdSlot, { id: "listing-sidebar-bottom", className: "mt-8" })] })] }));
 }

package/dist/features/products/components/AuctionsIndexListing.js

@@ -17,6 +17,8 @@ import { useAuthGate } from "../../../react/hooks/useAuthGate";
 import { ACTION_ID } from "../constants/action-defs";
 import { AUCTION_PUBLIC_SORT_OPTIONS } from "../constants/sieve";
 import { useBottomActions } from "../../layout";
+import { AVAILABILITY_VALUES } from "../../../constants/field-names";
+import { AvailabilityTabs } from "./AvailabilityTabs";
 const __P = {
     p3: "p-[var(--appkit-space-3)]",
 };
@@ -24,6 +26,7 @@ const __O = {
     hidden: "overflow-hidden",
 };
 const DEFAULT_SORT = AUCTION_PUBLIC_SORT_OPTIONS[0].value;
+const AUCTION_LISTING_TYPES = ["auction"];
 const FILTER_KEYS = [TABLE_KEYS.CATEGORY, TABLE_KEYS.BRAND, TABLE_KEYS.MIN_BID, TABLE_KEYS.MAX_BID, TABLE_KEYS.STORE_ID, TABLE_KEYS.DATE_FROM, TABLE_KEYS.DATE_TO];
 export function AuctionsIndexListing({ initialData, categorySlug, brandName }) {
     const table = useUrlTable({ defaults: { pageSize: "24", sort: DEFAULT_SORT } });
@@ -31,7 +34,8 @@ export function AuctionsIndexListing({ initialData, categorySlug, brandName }) {
     const { requireAuth, modalOpen, modalMessage, closeModal } = useAuthGate();
     const [searchInput, setSearchInput] = useState(table.get(TABLE_KEYS.QUERY) || "");
     const [filterOpen, setFilterOpen] = useState(false);
-    const showEnded = table.get(TABLE_KEYS.SHOW_ENDED) === "true";
+    const availability = table.get(TABLE_KEYS.AVAILABILITY) ||
+        AVAILABILITY_VALUES.AVAILABLE;
     const [view, setView] = useState(table.get(TABLE_KEYS.VIEW) || VIEW_MODE.GRID);
     const localWishlist = useGuestWishlist();
     const wishlistedIds = new Set(localWishlist.items.filter((i) => i.type === "auction").map((i) => i.itemId));
@@ -48,11 +52,11 @@ export function AuctionsIndexListing({ initialData, categorySlug, brandName }) {
         setFilterOpen(false);
     }, [onFilterApply]);
     const resetAll = useCallback(() => {
-        onResetAll({ [TABLE_KEYS.QUERY]: "", [TABLE_KEYS.SORT]: "", [TABLE_KEYS.SHOW_ENDED]: "" });
+        onResetAll({ [TABLE_KEYS.QUERY]: "", [TABLE_KEYS.SORT]: "", [TABLE_KEYS.AVAILABILITY]: "" });
         setSearchInput("");
     }, [onResetAll]);
     const hasActiveState = !!table.get(TABLE_KEYS.QUERY) ||
-        table.get(TABLE_KEYS.SHOW_ENDED) === "true" ||
+        availability !== AVAILABILITY_VALUES.AVAILABLE ||
         table.get(TABLE_KEYS.SORT) !== DEFAULT_SORT ||
         filterActiveCount > 0;
     const params = {
@@ -63,16 +67,16 @@ export function AuctionsIndexListing({ initialData, categorySlug, brandName }) {
         minBid: table.get(TABLE_KEYS.MIN_BID) ? Number(table.get(TABLE_KEYS.MIN_BID)) : undefined,
         maxBid: table.get(TABLE_KEYS.MAX_BID) ? Number(table.get(TABLE_KEYS.MAX_BID)) : undefined,
         storeId: table.get(TABLE_KEYS.STORE_ID) || undefined,
-        // When showEnded is false (default), force dateFrom=now so only live auctions appear.
-        // When showEnded is true, respect the filter-drawer value (or show all if none set).
-        dateFrom: showEnded
-            ? (table.get(TABLE_KEYS.DATE_FROM) || undefined)
-            : new Date().toISOString(),
+        // Now purely the drawer's own end-date window. It used to double as the
+        // hide-ended mechanism, which meant the drawer facet and the toggle fought
+        // over one param; the scope tab owns that decision instead.
+        dateFrom: table.get(TABLE_KEYS.DATE_FROM) || undefined,
         dateTo: table.get(TABLE_KEYS.DATE_TO) || undefined,
         sort: table.get(TABLE_KEYS.SORT) || DEFAULT_SORT,
         page: table.getNumber(TABLE_KEYS.PAGE, 1),
         perPage: table.getNumber(TABLE_KEYS.PAGE_SIZE, 24),
         listingType: "auction",
+        availability,
     };
     const { products: auctions, totalPages, page, isLoading } = useProducts(params, { initialData });
     const selection = useBulkSelection({ items: auctions, keyExtractor: (a) => a.id });
@@ -131,9 +135,7 @@ export function AuctionsIndexListing({ initialData, categorySlug, brandName }) {
                     },
                 },
             ] } } : {});
-    return (_jsxs(Div, { className: "min-h-screen", children: [_jsx(ListingToolbar, { filterCount: filterActiveCount, onFiltersClick: openFilters, searchValue: searchInput, searchPlaceholder: "Search auctions...", onSearchChange: setSearchInput, onSearchCommit: commitSearch, onSearchKeyDown: handleSearchKeyDown, sortValue: table.get(TABLE_KEYS.SORT) || DEFAULT_SORT, sortOptions: AUCTION_PUBLIC_SORT_OPTIONS, onSortChange: (v) => { table.set(TABLE_KEYS.SORT, v); }, view: view, onViewChange: handleViewToggle, onResetAll: resetAll, hasActiveState: hasActiveState, bulkMode: selection.isSelecting, bulkSelectedCount: selection.selectedCount, bulkTotalCount: auctions.length, onBulkSelectAll: selection.toggleAll, onBulkClear: selection.clearSelection, toggles: [
-                    { label: "Show ended", active: showEnded, onChange: (next) => table.set(TABLE_KEYS.SHOW_ENDED, next ? "true" : "") },
-                ] }), _jsx(BulkActionBar, { selectedCount: selection.selectedCount, onClearSelection: selection.clearSelection, actions: [
+    return (_jsxs(Div, { className: "min-h-screen", children: [_jsx(ListingToolbar, { filterCount: filterActiveCount, onFiltersClick: openFilters, searchValue: searchInput, searchPlaceholder: "Search auctions...", onSearchChange: setSearchInput, onSearchCommit: commitSearch, onSearchKeyDown: handleSearchKeyDown, sortValue: table.get(TABLE_KEYS.SORT) || DEFAULT_SORT, sortOptions: AUCTION_PUBLIC_SORT_OPTIONS, onSortChange: (v) => { table.set(TABLE_KEYS.SORT, v); }, view: view, onViewChange: handleViewToggle, onResetAll: resetAll, hasActiveState: hasActiveState, bulkMode: selection.isSelecting, bulkSelectedCount: selection.selectedCount, bulkTotalCount: auctions.length, onBulkSelectAll: selection.toggleAll, onBulkClear: selection.clearSelection }), _jsx(Div, { padding: "y-sm", children: _jsx(AvailabilityTabs, { types: AUCTION_LISTING_TYPES }) }), _jsx(BulkActionBar, { selectedCount: selection.selectedCount, onClearSelection: selection.clearSelection, actions: [
                     {
                         id: ACTION_ID.WATCH_AUCTION,
                         label: "Add to Watchlist",

package/dist/features/products/components/AvailabilityTabs.d.ts

@@ -0,0 +1,11 @@
+import React from "react";
+import type { ListingType } from "../types";
+export interface AvailabilityTabsProps {
+    /**
+     * The listing types the surface spans. Drives the middle tab's wording only
+     * — the scope itself means the same thing for every type.
+     */
+    types: readonly ListingType[];
+    className?: string;
+}
+export declare function AvailabilityTabs({ types, className }: AvailabilityTabsProps): React.JSX.Element;

package/dist/features/products/components/AvailabilityTabs.js

@@ -0,0 +1,47 @@
+"use client";
+import { jsx as _jsx } from "react/jsx-runtime";
+/*
+ * WHY: Every listing surface used to carry a "Show sold" / "Show ended" /
+ *      "Show closed" pill that WIDENED the list — flipping it mixed dead rows
+ *      into the live ones, so there was no way to browse the archive on its
+ *      own, and no way to be sure the default view was clean. Three URL
+ *      spellings of one intent had also accumulated, and each listing page
+ *      hand-built its own toggle array, so the label and the SSR default
+ *      drifted apart per page.
+ *
+ * WHAT: One three-tab scope bar — Available / <Sold & Ended> / All — shared by
+ *       the public browse pages, the store tabs, the category and brand
+ *       panels, and the admin/seller dashboards. The middle label is DERIVED
+ *       from each listing type's `hideDefault`, so /auctions reads "Ended",
+ *       /art reads "Sold", and /products reads "Sold & Ended".
+ *
+ * EXPORTS: AvailabilityTabs, AvailabilityTabsProps
+ *
+ * @tag domain:products
+ * @tag layer:ui
+ * @tag pattern:none
+ * @tag access:client
+ * @tag consumers:ProductsIndexListing,AuctionsIndexListing,PreOrdersIndexListing,PrizeDrawsIndexListing,Store*Listing,CategoryProductsListing,Seller*View,Admin*View
+ * @tag sideEffects:url-mutation
+ */
+import { useMemo } from "react";
+import { Tabs, TabsList, TabsTrigger } from "../../../ui";
+import { useUrlTable } from "../../../react/hooks/useUrlTable";
+import { TABLE_KEYS } from "../../../constants/table-keys";
+import { AVAILABILITY_VALUES } from "../../../constants/field-names";
+import { availabilityTabsFor } from "../../../_internal/shared/listing-types/_registry";
+export function AvailabilityTabs({ types, className }) {
+    const table = useUrlTable();
+    const tabs = useMemo(() => availabilityTabsFor(types), [types]);
+    // An absent param is the Available scope — the same default every SSR
+    // filter-builder resolves through `defaultAvailabilityForListingTypes`.
+    // Reading a different default here is precisely how SSR and the first
+    // refetch end up permanently disagreeing (Root Cause #30).
+    const active = table.get(TABLE_KEYS.AVAILABILITY) || AVAILABILITY_VALUES.AVAILABLE;
+    return (_jsx(Tabs, { value: active, 
+        // A single `set`, never followed by `setPage`. `useUrlTable.set` already
+        // resets the page for any key outside NON_RESETTING_KEYS, and a
+        // follow-up call would read stale searchParams and overwrite this one
+        // (Root Cause #13).
+        onChange: (next) => table.set(TABLE_KEYS.AVAILABILITY, next), className: className, children: _jsx(TabsList, { children: tabs.map((tab) => (_jsx(TabsTrigger, { value: tab.id, children: tab.label }, tab.id))) }) }));
+}

package/dist/features/products/components/GroupSettingsPanel.js

@@ -235,7 +235,11 @@ export function GroupSettingsPanel({ productId, productSlug, groupId, isGroupPar
                     setOpen(next);
                     if (next && isGroupParent && children === null)
                         loadChildren();
-                }, paddingX: "none", paddingY: "xs", justify: "between", className: "w-full text-left group", "aria-expanded": open, children: [_jsx(Heading, { level: 3, size: "sm", weight: "semibold", color: "muted", children: "Group Settings" }), _jsx(Span, { size: "xs", className: "group-hover:text-[var(--appkit-color-text-muted)] dark:group-hover:text-[var(--appkit-color-text-faint)] transition-colors", color: "faint", children: open ? "▲" : "▼" })] }), open && (_jsxs(Stack, { gap: "sm", className: `mt-3 ${__P.p4}`, surface: "muted", rounded: "lg", border: "default", children: [!groupId && !groupParentSlug && (_jsxs(Stack, { gap: "xs", children: [_jsx(Text, { size: "xs", color: "muted", children: "Group related listings together \u2014 e.g. a set, bundle, or multi-part item. Parts can be sold individually but shown together." }), _jsx(Button, { type: "button", variant: "secondary", size: "sm", onClick: startGroup, isLoading: loading, children: "Start a group" })] })), isGroupParent && groupId && (_jsxs(Stack, { gap: "md", children: [_jsxs(FormShellContext.Provider, { value: titleShellCtx, children: [_jsxs(Row, { align: "start", gap: "sm", wrap: true, children: [_jsx(Div, { className: "flex-1 min-w-[200px]", children: _jsx(FormField, { name: "groupTitle", label: "Group title", type: "text", value: editTitle, onChange: setEditTitle, placeholder: "e.g. Human Toy Complete Set" }) }), _jsx(Div, { padding: "t-lg", children: _jsx(Button, { type: "button", variant: "secondary", size: "sm", onClick: saveTitle, isLoading: loading, children: "Save title" }) })] }), _jsx(FormErrorSummary, {})] }), _jsxs(Div, { children: [_jsxs(Text, { className: "mb-2", color: "muted", size: "xs", weight: "semibold", children: ["Members (", childSlugsCount + 1, " \u2014 including this listing)"] }), loading && !children ? (_jsx(Text, { size: "xs", color: "faint", children: "Loading\u2026" })) : (_jsxs(Div, { className: "divide-y divide-zinc-100 divide-[var(--appkit-color-border-subtle)]", children: [_jsxs(Row, { align: "center", gap: "sm", padding: "y-xs", children: [_jsx(Span, { padding: "pill-2xs", weight: "semibold", className: "bg-[var(--appkit-color-primary)]/10 text-[var(--appkit-color-primary)] text-[10px]", rounded: "default", children: "Parent" }), _jsx(Text, { className: "flex-1", color: "primary", size: "sm", children: productSlug })] }), (children ?? []).filter((c) => c.id !== productId).map((child) => (_jsxs(Row, { align: "center", gap: "sm", padding: "y-xs", children: [child.images?.[0] ? (_jsx(Div, { className: "relative w-8 h-8 flex-shrink-0 border border-[var(--appkit-color-border)]", rounded: "full", overflow: "hidden", children: _jsx(MediaImage, { src: child.images[0], alt: child.title, size: "thumbnail" }) })) : (_jsx(Div, { className: "w-8 h-8", surface: "subtle", rounded: "full" })), _jsx(Text, { className: "flex-1 truncate", color: "primary", size: "sm", children: child.title }), _jsx(Button, { type: "button", variant: "ghost", size: "sm", onClick: () => requestUnlinkChild(child.id), isLoading: loading, className: `${CLS_DELETE_LINK} text-[length:var(--appkit-text-xs)]`, children: "Unlink" })] }, child.id)))] }))] }), _jsxs(Row, { gap: "sm", wrap: true, children: [_jsx(Button, { type: "button", variant: "secondary", size: "sm", onClick: () => setShowAddModal(true), children: "Add child listing" }), _jsx(Button, { type: "button", variant: "ghost", size: "sm", onClick: requestDissolveGroup, isLoading: loading, className: CLS_DELETE_LINK, children: "Dissolve group" })] })] })), !isGroupParent && groupParentSlug && (_jsxs(Stack, { gap: "xs", children: [_jsxs(Text, { size: "sm", color: "muted", children: ["Part of:", " ", _jsx(Span, { weight: "medium", color: "primary", children: groupTitle ?? groupParentSlug })] }), _jsxs(Text, { size: "xs", color: "muted", children: ["Parent listing: ", _jsx(Code, { className: "font-mono", children: groupParentSlug })] }), _jsx(Button, { type: "button", variant: "ghost", size: "sm", onClick: requestLeaveGroup, isLoading: loading, className: `${CLS_DELETE_LINK} w-fit`, children: "Leave group" })] }))] })), (groupChildSlugs?.length ?? 0) >= 4 ? (_jsx(SideDrawer, { isOpen: showAddModal, onClose: () => setShowAddModal(false), title: "Add child listing", children: _jsx(AddChildContent, { addTab: addTab, setAddTab: setAddTab, createForm: createForm, setCreateForm: setCreateForm, productSlug: productSlug, storeProductsEndpoint: storeProductsEndpoint, linkTargets: linkTargets, setLinkTargets: setLinkTargets, onAddCreate: addCreateChild, onAddLink: addLinkChild, loading: loading }) })) : (_jsx(Modal, { open: showAddModal, onClose: () => setShowAddModal(false), title: "Add child listing", size: "lg", children: _jsx(AddChildContent, { addTab: addTab, setAddTab: setAddTab, createForm: createForm, setCreateForm: setCreateForm, productSlug: productSlug, storeProductsEndpoint: storeProductsEndpoint, linkTargets: linkTargets, setLinkTargets: setLinkTargets, onAddCreate: addCreateChild, onAddLink: addLinkChild, loading: loading }) })), confirmAction && (_jsx(ConfirmDeleteModal, { isOpen: true, title: confirmAction.title, message: confirmAction.message, onConfirm: confirmAction.onConfirm, onClose: () => setConfirmAction(null), isDeleting: loading }))] }));
+                }, paddingX: "none", paddingY: "xs", justify: "between", className: "w-full text-left group", "aria-expanded": open, children: [_jsx(Heading, { level: 3, size: "sm", weight: "semibold", color: "muted", children: "Group Settings" }), _jsx(Span, { size: "xs", className: "group-hover:text-[var(--appkit-color-text-muted)] dark:group-hover:text-[var(--appkit-color-text-faint)] transition-colors", color: "faint", children: open ? "▲" : "▼" })] }), open && (_jsxs(Stack, { gap: "sm", className: `mt-3 ${__P.p4}`, surface: "muted", rounded: "lg", border: "default", children: [!groupId && !groupParentSlug && (_jsxs(Stack, { gap: "xs", children: [_jsx(Text, { size: "xs", color: "muted", children: "Group related listings together \u2014 e.g. a set, bundle, or multi-part item. Parts can be sold individually but shown together." }), _jsx(Button, { type: "button", variant: "secondary", size: "sm", onClick: startGroup, isLoading: loading, children: "Start a group" })] })), isGroupParent && groupId && (_jsxs(Stack, { gap: "md", children: [_jsxs(FormShellContext.Provider, { value: titleShellCtx, children: [_jsxs(Row, { align: "start", gap: "sm", wrap: true, children: [_jsx(Div, { className: "flex-1 min-w-[200px]", children: _jsx(FormField, { name: "groupTitle", label: "Group title", type: "text", value: editTitle, onChange: setEditTitle, placeholder: "e.g. Human Toy Complete Set" }) }), _jsx(Div, { padding: "t-lg", children: _jsx(Button, { type: "button", variant: "secondary", size: "sm", onClick: saveTitle, isLoading: loading, children: "Save title" }) })] }), _jsx(FormErrorSummary, {})] }), _jsxs(Div, { children: [_jsxs(Text, { className: "mb-2", color: "muted", size: "xs", weight: "semibold", children: ["Members (", childSlugsCount + 1, " \u2014 including this listing)"] }), loading && !children ? (_jsx(Text, { size: "xs", color: "faint", children: "Loading\u2026" })) : (_jsxs(Div, { className: "divide-y divide-zinc-100 divide-[var(--appkit-color-border-subtle)]", children: [_jsxs(Row, { align: "center", gap: "sm", padding: "y-xs", children: [_jsx(Span, { padding: "pill-2xs", weight: "semibold", className: "bg-[var(--appkit-color-primary)]/10 text-[var(--appkit-color-primary)] text-[10px]", rounded: "default", children: "Parent" }), _jsx(Text, { className: "flex-1", color: "primary", size: "sm", children: productSlug })] }), (children ?? []).filter((c) => c.id !== productId).map((child) => (_jsxs(Row, { align: "center", gap: "sm", padding: "y-xs", children: [child.images?.[0] ? (_jsx(Div, { className: "relative w-8 h-8 flex-shrink-0 border border-[var(--appkit-color-border)]", rounded: "full", overflow: "hidden", children: _jsx(MediaImage, { src: child.images[0], alt: child.title, size: "thumbnail" }) })) : (_jsx(Div, { className: "w-8 h-8", surface: "subtle", rounded: "full" })), _jsx(Text, { className: "flex-1 truncate", color: "primary", size: "sm", children: child.title }), _jsx(Button, { type: "button", variant: "ghost", size: "sm", onClick: () => requestUnlinkChild(child.id), isLoading: loading, className: `${CLS_DELETE_LINK} text-[length:var(--appkit-text-xs)]`, children: "Unlink" })] }, child.id)))] }))] }), _jsxs(Row, { gap: "sm", wrap: true, children: [_jsx(Button, { type: "button", variant: "secondary", size: "sm", onClick: () => setShowAddModal(true), children: "Add child listing" }), _jsx(Button, { type: "button", variant: "ghost", size: "sm", onClick: requestDissolveGroup, isLoading: loading, className: CLS_DELETE_LINK, children: "Dissolve group" })] })] })), !isGroupParent && groupParentSlug && (_jsxs(Stack, { gap: "xs", children: [_jsxs(Text, { size: "sm", color: "muted", children: ["Part of:", " ", _jsx(Span, { weight: "medium", color: "primary", children: groupTitle ?? groupParentSlug })] }), _jsxs(Text, { size: "xs", color: "muted", children: ["Parent listing: ", _jsx(Code, { className: "font-mono", children: groupParentSlug })] }), _jsx(Button, { type: "button", variant: "ghost", size: "sm", onClick: requestLeaveGroup, isLoading: loading, className: `${CLS_DELETE_LINK} w-fit`, children: "Leave group" })] }))] })), (() => {
+                const content = (_jsx(AddChildContent, { addTab: addTab, setAddTab: setAddTab, createForm: createForm, setCreateForm: setCreateForm, productSlug: productSlug, storeProductsEndpoint: storeProductsEndpoint, linkTargets: linkTargets, setLinkTargets: setLinkTargets, onAddCreate: addCreateChild, onAddLink: addLinkChild, loading: loading }));
+                const close = () => setShowAddModal(false);
+                return (groupChildSlugs?.length ?? 0) >= 4 ? (_jsx(SideDrawer, { isOpen: showAddModal, onClose: close, title: "Add child listing", children: content })) : (_jsx(Modal, { open: showAddModal, onClose: close, title: "Add child listing", size: "lg", children: content }));
+            })(), confirmAction && (_jsx(ConfirmDeleteModal, { isOpen: true, title: confirmAction.title, message: confirmAction.message, onConfirm: confirmAction.onConfirm, onClose: () => setConfirmAction(null), isDeleting: loading }))] }));
 }
 function AddChildContent({ addTab, setAddTab, createForm, setCreateForm, productSlug, storeProductsEndpoint, linkTargets, setLinkTargets, onAddCreate, onAddLink, loading, }) {
     const { shellCtx, validate } = useFormShellState(createChildSchema);