@mohasinac/appkit 4.13.1 → 4.15.0

package/dist/features/products/components/ProductsIndexPageView.js

@@ -7,28 +7,25 @@ import { PRODUCT_FIELDS } from "../../../constants/field-names";
 import { TABLE_KEYS } from "../../../constants/table-keys";
 import { sortBy } from "../../../constants/sort";
 import { GENERIC_PRODUCT_LISTING_TYPES } from "../constants/listing-tabs";
-import { listPublicProducts, parsePublicProductParams, defaultTogglesForListingTypes, } from "../../../_internal/server/features/products/list-public";
+import { listPublicProducts, parsePublicProductParams, defaultAvailabilityForListingTypes, } from "../../../_internal/server/features/products/list-public";
 import { parseSelectedListingTypes } from "../utils/listing-type";
 const DEFAULT_PAGE_SIZE = 24;
 const DEFAULT_SORT = sortBy(PRODUCT_FIELDS.CREATED_AT);
 export async function ProductsIndexPageView({ searchParams = {} }) {
-    // The "Show sold" / "Show ended" defaults depend on WHICH types are in play,
-    // and this page now spans all nine. Both sides derive them from the same
-    // helper — a hardcoded `hideSoldByDefault: true` here would disagree with
-    // the client the moment the user ticks Auctions, and `staleTime: Infinity`
-    // would freeze that disagreement (Root Cause #30).
+    // The availability scope is derived from the same helper the client reads
+    // its default from — a hardcoded default here would disagree with the
+    // client, and `staleTime: Infinity` would freeze that disagreement
+    // (Root Cause #30).
     const raw = searchParams[TABLE_KEYS.LISTING_TYPE];
     const selectedTypes = parseSelectedListingTypes(Array.isArray(raw) ? raw[0] : raw);
     const effectiveTypes = selectedTypes.length > 0 ? selectedTypes : GENERIC_PRODUCT_LISTING_TYPES;
-    const { hideSoldByDefault, hideEndedByDefault } = defaultTogglesForListingTypes(effectiveTypes);
     // See ArtStickersListView — one shared filter implementation with
     // /api/products, so SSR and the client refetch agree by construction.
     const products = await listPublicProducts(parsePublicProductParams(searchParams, {
         listingTypes: GENERIC_PRODUCT_LISTING_TYPES,
         pageSize: DEFAULT_PAGE_SIZE,
         sorts: DEFAULT_SORT,
-        hideSoldByDefault,
-        hideEndedByDefault,
+        ...defaultAvailabilityForListingTypes(effectiveTypes),
     }));
     return (_jsxs(Main, { children: [_jsx(Section, { border: "bottom-subtle", paddingY: "b-md", padding: "t-xl", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 1, size: "3xl", weight: "bold", color: "primary", children: "Products" }), _jsx(Text, { className: "mt-1", color: "muted", size: "sm", children: "Discover amazing products and deals" }), _jsx(Div, { className: "mt-3", children: _jsx(TextLink, { variant: "bare", href: String(ROUTES.PUBLIC.AUCTIONS), rounded: "full", paddingX: "sm", paddingY: "2xs", size: "xs", weight: "medium", layout: "inline-flex", align: "center", gap: "sm", className: "border border-primary/30 bg-primary/10 text-primary-700 dark:text-primary-400 hover:bg-primary/15 transition-colors", children: "\uD83C\uDFF7\uFE0F Looking for unique deals? Browse Auctions \u2192" }) })] }) }), _jsxs(Container, { size: "xl", padding: "x-md", children: [_jsx(AdSlot, { id: "listing-sidebar-top", className: "mb-4 mt-4" }), _jsx(ProductsIndexListing, { initialData: products }), _jsx(AdSlot, { id: "listing-sidebar-bottom", className: "mt-8" })] })] }));
 }

package/dist/features/products/components/index.d.ts

@@ -21,6 +21,8 @@ export { MarketplaceBundleCard } from "./MarketplaceBundleCard";
 export type { MarketplaceBundleCardProps, MarketplaceBundleCardData, MarketplaceBundleCardLabels, } from "./MarketplaceBundleCard";
 export { PrizeDrawsIndexListing } from "./PrizeDrawsIndexListing";
 export type { PrizeDrawsIndexListingProps } from "./PrizeDrawsIndexListing";
+export { AvailabilityTabs } from "./AvailabilityTabs";
+export type { AvailabilityTabsProps } from "./AvailabilityTabs";
 export { PrizeDrawEntryActions } from "./PrizeDrawEntryActions";
 export type { PrizeDrawEntryActionsProps } from "./PrizeDrawEntryActions";
 export { ProductFeaturesSelector } from "./ProductFeaturesSelector";
@@ -46,8 +48,6 @@ export { BidHistory } from "./BidHistory";
 export type { BidHistoryProps, BidHistoryEntry } from "./BidHistory";
 export { PlaceBidForm } from "./PlaceBidForm";
 export type { PlaceBidFormProps } from "./PlaceBidForm";
-export { MakeOfferForm } from "./MakeOfferForm";
-export type { MakeOfferFormProps } from "./MakeOfferForm";
 export { MakeOfferButton } from "./MakeOfferButton";
 export type { MakeOfferButtonProps } from "./MakeOfferButton";
 export { RelatedProducts } from "./RelatedProducts";

package/dist/features/products/components/index.js

@@ -10,6 +10,7 @@ export { PrizeDrawWinnerMappingView } from "./PrizeDrawWinnerMappingView";
 export { MarketplacePrizeDrawCard } from "./MarketplacePrizeDrawCard";
 export { MarketplaceBundleCard } from "./MarketplaceBundleCard";
 export { PrizeDrawsIndexListing } from "./PrizeDrawsIndexListing";
+export { AvailabilityTabs } from "./AvailabilityTabs";
 // PrizeDrawsListingView + PrizeDrawDetailPageView are server components that
 // import productRepository (→ firebase-admin). Re-exporting them from this
 // client-mixed barrel pulls firebase-admin into client bundles via webpack/
@@ -28,7 +29,6 @@ export { ProductInfo } from "./ProductInfo";
 export { ProductTabs } from "./ProductTabs";
 export { BidHistory } from "./BidHistory";
 export { PlaceBidForm } from "./PlaceBidForm";
-export { MakeOfferForm } from "./MakeOfferForm";
 export { MakeOfferButton } from "./MakeOfferButton";
 export { RelatedProducts } from "./RelatedProducts";
 export { ProductGalleryClient } from "./ProductGalleryClient";

package/dist/features/products/config/listing-type-listing-config.d.ts

@@ -1,4 +1,5 @@
 import type { JsonArray } from "../../../schemas/types";
+import type { AvailabilityScope } from "../hooks/useAvailabilityScope";
 import type { ListingType } from "../types";
 import type { ListingViewConfig } from "../../admin/components/DataListingView";
 export interface ListingTypeListingRow {
@@ -10,14 +11,33 @@ export interface ListingTypeListingRow {
     image?: string;
 }
 interface ListingTypeListingResponse {
+    /** Admin route shape. */
     items?: JsonArray;
     total?: number;
+    /** Seller route shape. */
+    products?: JsonArray;
+    meta?: {
+        total?: number;
+    };
 }
 export interface BuildListingTypeListingOptions {
     /** Override the page heading; defaults to the type's registered plural label. */
     title?: string;
     searchPlaceholder?: string;
     emptyLabel?: string;
+    /**
+     * Which dashboard this config is for. `"seller"` swaps the endpoint and the
+     * row href for the store-scoped equivalents; the store identity itself is
+     * resolved server-side from the session, never passed here.
+     */
+    portal?: "admin" | "seller";
+    /**
+     * The availability scope, from `useAvailabilityScope(...)` in the calling
+     * component. Passed in rather than called here because this is a plain
+     * factory function, not a component — a hook call would break the rules of
+     * hooks the moment a caller invoked it conditionally.
+     */
+    scope?: AvailabilityScope;
 }
 /**
  * Admin browse config for one listing type.

package/dist/features/products/config/listing-type-listing-config.js

@@ -25,7 +25,7 @@
 import { SIEVE_OP, sieveAnd, sieveFilter } from "../../../utils/sieve-builder";
 import { sortBy } from "../../../constants/sort";
 import { PRODUCT_FIELDS } from "../../../constants/field-names";
-import { ADMIN_ENDPOINTS } from "../../../constants/api-endpoints";
+import { ADMIN_ENDPOINTS, SELLER_ENDPOINTS } from "../../../constants/api-endpoints";
 import { ROUTES } from "../../../next/routing/route-map";
 import { pluginFor } from "../../../_internal/shared/listing-types/_registry";
 import { toRecordArray, toRelativeDate, toCurrency, toStringValue, } from "../../admin/hooks/useAdminListingData";
@@ -40,19 +40,23 @@ import { toRecordArray, toRelativeDate, toCurrency, toStringValue, } from "../..
 export function buildListingTypeListingConfig(type, opts = {}) {
     const plugin = pluginFor(type);
     const label = opts.title ?? plugin.pluralLabel;
+    const portal = opts.portal ?? "admin";
+    const isSeller = portal === "seller";
     return {
-        portal: "admin",
+        portal,
         title: label,
         searchPlaceholder: opts.searchPlaceholder ?? `Search ${label.toLowerCase()} by name or seller`,
         emptyLabel: opts.emptyLabel ?? `No ${label.toLowerCase()} listings`,
         filterKeys: ["status"],
         defaultSort: sortBy(PRODUCT_FIELDS.CREATED_AT),
-        // Keyed on the canonical type so two types can never share a cache entry.
-        queryKey: ["admin", "listing-type", type],
-        endpoint: ADMIN_ENDPOINTS.PRODUCTS,
+        // Keyed on the canonical type AND the portal so an admin's all-stores list
+        // and a seller's own-store list can never share a cache entry.
+        queryKey: [portal, "listing-type", type],
+        endpoint: isSeller ? SELLER_ENDPOINTS.PRODUCTS : ADMIN_ENDPOINTS.PRODUCTS,
         // The type's own sort set, not a copy-pasted three-option array.
         sortOptions: [...plugin.sortOptions],
-        mapRows: (response) => toRecordArray(response.items).map((item, index) => ({
+        // The seller route returns `{ products }`, the admin route `{ items }`.
+        mapRows: (response) => toRecordArray(response.items ?? response.products).map((item, index) => ({
             id: toStringValue(item.id, `${type}-${index}`),
             primary: toStringValue(item.title ?? item.productTitle, "Untitled listing"),
             secondary: [
@@ -63,12 +67,20 @@ export function buildListingTypeListingConfig(type, opts = {}) {
             updatedAt: toRelativeDate(item.updatedAt ?? item.createdAt),
             image: toStringValue(item.mainImage, "") || undefined,
         })),
-        getTotal: (response, mappedRows) => typeof response.total === "number" ? response.total : mappedRows.length,
+        getTotal: (response, mappedRows) => typeof response.total === "number"
+            ? response.total
+            : typeof response.meta?.total === "number"
+                ? response.meta.total
+                : mappedRows.length,
         buildFilters: (state) => sieveAnd(sieveFilter(PRODUCT_FIELDS.LISTING_TYPE, SIEVE_OP.EQ, type), state.status && state.status !== "All"
             ? sieveFilter(PRODUCT_FIELDS.STATUS, SIEVE_OP.EQ, state.status)
             : "") || undefined,
-        // These are products filtered by listingType — reuse the real admin
-        // product editor rather than leaving rows non-navigable.
-        rowHrefTemplate: String(ROUTES.ADMIN.PRODUCTS_EDIT("{id}")),
+        // The availability scope, when the caller supplies one. Optional so the
+        // factory stays usable from a non-component context.
+        buildExtraParams: opts.scope ? () => opts.scope.extraParams : undefined,
+        renderAboveContent: opts.scope?.renderAboveContent,
+        // These are products filtered by listingType — reuse the real product
+        // editor rather than leaving rows non-navigable.
+        rowHrefTemplate: String(isSeller ? ROUTES.STORE.PRODUCTS_EDIT("{id}") : ROUTES.ADMIN.PRODUCTS_EDIT("{id}")),
     };
 }

package/dist/features/products/constants/action-defs.d.ts

@@ -192,6 +192,7 @@ export declare const ADMIN_ROW_ACTIONS: {
     readonly blog: readonly ["row-view", "row-edit", "row-publish", "row-draft", "row-delete"];
     readonly faqs: readonly ["row-edit", "row-archive", "row-delete"];
     readonly bids: readonly ["row-view", "row-cancel"];
+    readonly offers: readonly ["row-view", "row-cancel"];
     readonly notifications: readonly ["row-resend", "row-delete"];
     readonly sessions: readonly ["row-revoke"];
     readonly bundles: readonly ["row-view", "row-edit", "row-activate", "row-deactivate", "row-delete"];
@@ -356,6 +357,7 @@ export declare const ADMIN_BULK_ACTIONS: {
     readonly blog: readonly ["row-publish", "row-draft", "row-delete"];
     readonly faqs: readonly ["row-archive", "row-delete"];
     readonly bids: readonly ["row-cancel"];
+    readonly offers: readonly ["row-cancel"];
     readonly notifications: readonly ["row-mark-read", "row-delete"];
     readonly sessions: readonly ["row-revoke"];
     readonly payouts: readonly ["row-mark-paid"];

package/dist/features/products/constants/action-defs.js

@@ -255,6 +255,11 @@ export const ADMIN_ROW_ACTIONS = {
     blog: [ROW_ACTION_ID.VIEW, ROW_ACTION_ID.EDIT, ROW_ACTION_ID.PUBLISH, ROW_ACTION_ID.DRAFT, ROW_ACTION_ID.DELETE],
     faqs: [ROW_ACTION_ID.EDIT, ROW_ACTION_ID.ARCHIVE, ROW_ACTION_ID.DELETE],
     bids: [ROW_ACTION_ID.VIEW, ROW_ACTION_ID.CANCEL],
+    // View + Cancel only, deliberately. Admin does NOT get accept/counter/reject
+    // (which the seller preset below has) — negotiating a price on a seller's
+    // behalf is an authority nobody asked for. Admin's job here is to read the
+    // record and kill a bad one.
+    offers: [ROW_ACTION_ID.VIEW, ROW_ACTION_ID.CANCEL],
     notifications: [ROW_ACTION_ID.RESEND, ROW_ACTION_ID.DELETE],
     sessions: [ROW_ACTION_ID.REVOKE],
     bundles: [ROW_ACTION_ID.VIEW, ROW_ACTION_ID.EDIT, ROW_ACTION_ID.ACTIVATE, ROW_ACTION_ID.DEACTIVATE, ROW_ACTION_ID.DELETE],
@@ -521,6 +526,7 @@ export const ADMIN_BULK_ACTIONS = {
     blog: [ROW_ACTION_ID.PUBLISH, ROW_ACTION_ID.DRAFT, ROW_ACTION_ID.DELETE],
     faqs: [ROW_ACTION_ID.ARCHIVE, ROW_ACTION_ID.DELETE],
     bids: [ROW_ACTION_ID.CANCEL],
+    offers: [ROW_ACTION_ID.CANCEL],
     notifications: [ROW_ACTION_ID.MARK_READ, ROW_ACTION_ID.DELETE],
     sessions: [ROW_ACTION_ID.REVOKE],
     payouts: [ROW_ACTION_ID.MARK_PAID],

package/dist/features/products/hooks/useAvailabilityScope.d.ts

@@ -0,0 +1,13 @@
+import React from "react";
+import { type AvailabilityFilter } from "../../../constants/field-names";
+import type { ListingType } from "../types";
+export interface AvailabilityScope {
+    availability: AvailabilityFilter;
+    /** Spread into `ListingViewConfig.buildExtraParams`'s return value. */
+    extraParams: {
+        availability: AvailabilityFilter;
+    };
+    /** Assign to `ListingViewConfig.renderAboveContent`. */
+    renderAboveContent: () => React.ReactNode;
+}
+export declare function useAvailabilityScope(types: readonly ListingType[]): AvailabilityScope;

package/dist/features/products/hooks/useAvailabilityScope.js

@@ -0,0 +1,19 @@
+"use client";
+import { jsx as _jsx } from "react/jsx-runtime";
+import { useUrlTable } from "../../../react/hooks/useUrlTable";
+import { TABLE_KEYS } from "../../../constants/table-keys";
+import { AVAILABILITY_VALUES } from "../../../constants/field-names";
+import { AvailabilityTabs } from "../components/AvailabilityTabs";
+export function useAvailabilityScope(types) {
+    // A second, independent `useUrlTable()` against the same URL as
+    // DataListingView's own instance. Safe by design — the hook holds no local
+    // state, so both instances read the same searchParams and stay in sync.
+    const table = useUrlTable();
+    const availability = table.get(TABLE_KEYS.AVAILABILITY) ||
+        AVAILABILITY_VALUES.AVAILABLE;
+    return {
+        availability,
+        extraParams: { availability },
+        renderAboveContent: () => _jsx(AvailabilityTabs, { types: types }),
+    };
+}

package/dist/features/products/hooks/useProducts.d.ts

@@ -26,6 +26,11 @@ export declare function useProducts<T extends ProductItem = ProductItem>(params?
     totalPages: number;
     page: number;
     hasMore: boolean;
+    /**
+     * A bounded fetch hit its ceiling, so `total` is a floor. Render it as
+     * "50+", never as an exact count, and never derive a final page from it.
+     */
+    truncated: boolean;
     isLoading: boolean;
     error: Error | null;
     warning: string | undefined;

package/dist/features/products/hooks/useProducts.js

@@ -21,8 +21,14 @@ export function useProducts(params = {}, opts) {
         sp.set("minPrice", String(params.minPrice));
     if (params.maxPrice !== undefined)
         sp.set("maxPrice", String(params.maxPrice));
-    if (params.inStock !== undefined)
-        sp.set("inStock", String(params.inStock));
+    // ALWAYS sent when the caller has a scope, including the default
+    // "available". `/api/products` leaves `availability` unset (= all) so that
+    // non-browse callers are unaffected — which means a browse component that
+    // stopped sending it would filter on the SSR paint and NOT on the refetch,
+    // and `staleTime: Infinity` would freeze that disagreement (Root Cause #30).
+    // `audit-listing-filter-parity` asserts every listing component sends it.
+    if (params.availability)
+        sp.set("availability", params.availability);
     // SB1-G Phase 4 — canonical `listingType` URL param only.
     if (params.listingType !== undefined)
         sp.set("listingType", params.listingType);
@@ -87,6 +93,11 @@ export function useProducts(params = {}, opts) {
         totalPages: query.data?.totalPages ?? 1,
         page: query.data?.page ?? 1,
         hasMore: query.data?.hasMore ?? false,
+        /**
+         * A bounded fetch hit its ceiling, so `total` is a floor. Render it as
+         * "50+", never as an exact count, and never derive a final page from it.
+         */
+        truncated: query.data?.truncated ?? false,
         isLoading: query.isLoading,
         error: query.error,
         warning,

package/dist/features/products/repository/products.repository.d.ts

@@ -35,14 +35,12 @@ export declare class ProductRepository extends BaseRepository<ProductDocument> {
     listByIds(ids: string[]): Promise<ProductDocument[]>;
     findAuctions(): Promise<ProductDocument[]>;
     findPreOrders(): Promise<ProductDocument[]>;
-    findActivePreOrders(): Promise<ProductDocument[]>;
     findPromoted(): Promise<ProductDocument[]>;
     updateProduct(productId: string, data: ProductUpdateInput): Promise<ProductDocument>;
     updateAvailableQuantity(productId: string, quantity: number): Promise<void>;
     updateBid(productId: string, bidAmount: number, bidCount: number): Promise<void>;
     findAvailable(): Promise<ProductDocument[]>;
     findByGroupId(groupId: string): Promise<ProductDocument[]>;
-    findActiveAuctions(): Promise<ProductDocument[]>;
     startGroup(productId: string, slug: string): Promise<void>;
     updateGroupTitle(productId: string, groupTitle: string): Promise<void>;
     dissolveGroup(groupId: string): Promise<void>;
@@ -329,12 +327,43 @@ export declare class ProductRepository extends BaseRepository<ProductDocument> {
      * is called from — Vercel routes, listingProcessor, server-action views.
      */
     static readonly FILTER_ALIASES: SieveFilterAliases;
+    /**
+     * Firestore's ceiling for `array-contains-any` / `in` comparison values.
+     * Exceeding it throws `INVALID_ARGUMENT`, and every caller of `list()` wraps
+     * the call in `.catch(() => null)`, so the throw would surface as a silently
+     * empty page rather than an error (Root Cause #59).
+     */
+    private static readonly MAX_ARRAY_CONTAINS_ANY;
+    /**
+     * Shared scope construction for `list()` and `countBy*()` — both must narrow
+     * by exactly the same store/status/category/search predicates or a tab's
+     * count would disagree with the rows behind it.
+     */
+    private buildScopedQuery;
     list(model: SieveModel, opts?: {
         storeId?: string;
         status?: string;
         categoriesIn?: string[];
         search?: string;
     }): Promise<FirebaseSieveResult<ProductDocument>>;
+    /**
+     * How many products of each listing type exist within a scope — the numbers
+     * behind every listing-type tab bar and filter chip group.
+     *
+     * `types` entries are passed through verbatim, so a pipe-joined OR-group
+     * (`"art|stickers"`, the combined Art & Stickers tab) is counted as one
+     * bucket, matching how the tab itself queries.
+     *
+     * A type whose count query fails maps to `undefined`, not 0 — callers hide a
+     * tab at zero, and a swallowed failure reading as "none exist" would hide a
+     * tab holding real inventory (Root Cause #59).
+     */
+    countByListingTypes(types: readonly string[], opts?: {
+        storeId?: string;
+        status?: string;
+        categoriesIn?: string[];
+        brandName?: string;
+    }): Promise<Record<string, number | undefined>>;
     incrementViewCount(productId: string): Promise<void>;
     /**
      * Cloud Functions: find published auctions whose end date has already passed.

package/dist/features/products/repository/products.repository.js

@@ -206,15 +206,6 @@ export class ProductRepository extends BaseRepository {
     async findPreOrders() {
         return this.findBy(PRODUCT_FIELDS.LISTING_TYPE, LISTING_TYPE_VALUES.PRE_ORDER);
     }
-    async findActivePreOrders() {
-        const now = new Date();
-        const snapshot = await this.db
-            .collection(this.collection)
-            .where(PRODUCT_FIELDS.LISTING_TYPE, "==", LISTING_TYPE_VALUES.PRE_ORDER)
-            .where(PRODUCT_FIELDS.PRE_ORDER_DELIVERY_DATE, ">=", now)
-            .get();
-        return snapshot.docs.map((doc) => this.mapDoc(doc));
-    }
     async findPromoted() {
         return this.findBy(PRODUCT_FIELDS.IS_PROMOTED, true);
     }
@@ -255,15 +246,6 @@ export class ProductRepository extends BaseRepository {
             .get();
         return snapshot.docs.map((doc) => this.mapDoc(doc));
     }
-    async findActiveAuctions() {
-        const now = new Date();
-        const snapshot = await this.db
-            .collection(this.collection)
-            .where(PRODUCT_FIELDS.LISTING_TYPE, "==", LISTING_TYPE_VALUES.AUCTION)
-            .where(PRODUCT_FIELDS.AUCTION_END_DATE, ">=", now)
-            .get();
-        return snapshot.docs.map((doc) => this.mapDoc(doc));
-    }
     async startGroup(productId, slug) {
         await this.getCollection().doc(productId).update({
             groupId: slug,
@@ -358,8 +340,19 @@ export class ProductRepository extends BaseRepository {
         this.cacheInvalidateForId(id);
         return super.delete(id);
     }
-    async list(model, opts) {
+    /**
+     * Shared scope construction for `list()` and `countBy*()` — both must narrow
+     * by exactly the same store/status/category/search predicates or a tab's
+     * count would disagree with the rows behind it.
+     */
+    buildScopedQuery(opts) {
         let baseQuery = this.getCollection();
+        if (opts?.brandName) {
+            // The free-text display name, NOT brandSlug — BrandDetailPageView filters
+            // products this way, so a count keyed on brandSlug would disagree with
+            // the rows the tab goes on to show.
+            baseQuery = baseQuery.where(PRODUCT_FIELDS.BRAND, "==", opts.brandName);
+        }
         if (opts?.status) {
             baseQuery = baseQuery.where(PRODUCT_FIELDS.STATUS, "==", opts.status);
         }
@@ -377,15 +370,47 @@ export class ProductRepository extends BaseRepository {
             baseQuery = baseQuery.where(PRODUCT_FIELDS.SEARCH_TOKENS, "array-contains-any", searchTokens);
         }
         if (searchTokens.length === 0 && opts?.categoriesIn && opts.categoriesIn.length > 0) {
-            baseQuery = baseQuery.where(PRODUCT_FIELDS.CATEGORY_SLUGS, "array-contains-any", opts.categoriesIn);
+            let categoriesIn = opts.categoriesIn;
+            if (categoriesIn.length > ProductRepository.MAX_ARRAY_CONTAINS_ANY) {
+                // Products carry their FULL ancestor chain in `categorySlugs`, so a
+                // category page only ever needs to pass its own id — a list this long
+                // means a caller is still expanding descendants. Truncating keeps the
+                // query legal (an over-long list throws INVALID_ARGUMENT, which every
+                // caller's `.catch(() => null)` would turn into a blank page), and the
+                // warning names the real bug instead of hiding it.
+                serverLogger.warn(`productRepository: categoriesIn had ${categoriesIn.length} values, above Firestore's ${ProductRepository.MAX_ARRAY_CONTAINS_ANY} limit — truncating. Pass only the category's own id; products are tagged with their full ancestor chain.`);
+                categoriesIn = categoriesIn.slice(0, ProductRepository.MAX_ARRAY_CONTAINS_ANY);
+            }
+            baseQuery = baseQuery.where(PRODUCT_FIELDS.CATEGORY_SLUGS, "array-contains-any", categoriesIn);
         }
+        return baseQuery;
+    }
+    async list(model, opts) {
         return this.sieveQuery(model, ProductRepository.SIEVE_FIELDS, {
-            baseQuery,
+            baseQuery: this.buildScopedQuery(opts),
             defaultPageSize: 20,
             maxPageSize: 100,
             aliases: ProductRepository.FILTER_ALIASES,
         });
     }
+    /**
+     * How many products of each listing type exist within a scope — the numbers
+     * behind every listing-type tab bar and filter chip group.
+     *
+     * `types` entries are passed through verbatim, so a pipe-joined OR-group
+     * (`"art|stickers"`, the combined Art & Stickers tab) is counted as one
+     * bucket, matching how the tab itself queries.
+     *
+     * A type whose count query fails maps to `undefined`, not 0 — callers hide a
+     * tab at zero, and a swallowed failure reading as "none exist" would hide a
+     * tab holding real inventory (Root Cause #59).
+     */
+    async countByListingTypes(types, opts) {
+        return this.facetCounts(PRODUCT_FIELDS.LISTING_TYPE, types, ProductRepository.SIEVE_FIELDS, {
+            baseQuery: this.buildScopedQuery(opts),
+            aliases: ProductRepository.FILTER_ALIASES,
+        });
+    }
     async incrementViewCount(productId) {
         try {
             await this.db
@@ -672,4 +697,11 @@ ProductRepository.FILTER_ALIASES = {
         ].join(",");
     },
 };
+/**
+ * Firestore's ceiling for `array-contains-any` / `in` comparison values.
+ * Exceeding it throws `INVALID_ARGUMENT`, and every caller of `list()` wraps
+ * the call in `.catch(() => null)`, so the throw would surface as a silently
+ * empty page rather than an error (Root Cause #59).
+ */
+ProductRepository.MAX_ARRAY_CONTAINS_ANY = 30;
 export const productRepository = new ProductRepository();

package/dist/features/products/schemas/firestore.d.ts

@@ -178,7 +178,21 @@ export interface ProductDocument extends BaseDocument {
     auctionExtensionMinutes?: number;
     auctionOriginalEndDate?: Date;
     auctionShippingPaidBy?: "seller" | "winner";
-    buyItNowPrice?: number;
+    /**
+     * True once anybody has bid. Written by `placeBid`, never reset.
+     *
+     * It no longer gates Buy Now. The original SB-UNI-H design copied eBay's rule
+     * — BIN vanishes the moment the first bid lands — which in practice hid the
+     * button on nearly every real auction (3 of 4 seeded BIN fixtures had it
+     * hidden), while the PDP went on advertising the BIN *price* right above the
+     * missing button. Availability is now `buyNowPrice > currentBid`, via
+     * `isBuyNowAvailable()`; this field survives as a plain filterable fact about
+     * the auction.
+     *
+     * (A `buyItNowPrice` field used to sit alongside this one, documented as THE
+     * BIN price while every consumer actually read `buyNowPrice` above. Deleted
+     * 2026-08-24 — it had no readers and had already caused one seed-data bug.)
+     */
     bidsHaveStarted?: boolean;
     grading?: ProductGrading;
     card?: ProductCardMetadata;
@@ -369,8 +383,8 @@ export declare const ProductStatusValues: {
 export declare const PRODUCT_COLLECTION: "products";
 export declare const PRODUCT_INDEXED_FIELDS: readonly ["storeId", "status", "category", "featured", "listingType", "isPromoted", "isOnSale", "isSold", "searchTokens", "createdAt", "barcodeId"];
 export declare const DEFAULT_PRODUCT_DATA: Partial<ProductDocument>;
-export declare const PRODUCT_PUBLIC_FIELDS: readonly ["id", "title", "description", "category", "subcategory", "brand", "price", "currency", "stockQuantity", "availableQuantity", "images", "status", "storeName", "featured", "tags", "specifications", "features", "shippingInfo", "returnPolicy", "listingType", "auctionEndDate", "startingBid", "currentBid", "bidCount", "reservePrice", "buyNowPrice", "minBidIncrement", "autoExtendable", "auctionExtensionMinutes", "auctionShippingPaidBy", "buyItNowPrice", "bidsHaveStarted", "grading", "card", "classified", "digitalCode", "liveItem", "catalogProductId", "preOrderDeliveryDate", "preOrderDepositPercent", "preOrderDepositAmount", "preOrderMaxQuantity", "preOrderCurrentCount", "preOrderProductionStatus", "preOrderCancellable", "condition", "insurance", "insuranceCost", "shippingPaidBy", "isPromoted", "isOnSale", "isSold", "slug", "seoTitle", "seoDescription", "seoKeywords", "viewCount", "customFields", "customSections", "sublistingCategoryId", "groupId", "isGroupParent", "groupParentSlug", "groupChildSlugs", "groupTitle", "createdAt"];
-export declare const PRODUCT_UPDATABLE_FIELDS: readonly ["title", "description", "category", "subcategory", "brand", "price", "stockQuantity", "images", "status", "tags", "specifications", "features", "shippingInfo", "returnPolicy", "pickupAddressId", "condition", "insurance", "shippingPaidBy", "autoExtendable", "auctionExtensionMinutes", "auctionShippingPaidBy", "reservePrice", "buyNowPrice", "minBidIncrement", "buyItNowPrice", "bidsHaveStarted", "grading", "card", "classified", "digitalCode", "liveItem", "catalogProductId", "listingType", "preOrderDeliveryDate", "preOrderDepositPercent", "preOrderDepositAmount", "preOrderMaxQuantity", "preOrderProductionStatus", "preOrderCancellable", "isOnSale", "isSold", "allowShipBeforeEmiComplete", "printMeta", "seoTitle", "seoDescription", "seoKeywords", "customFields", "customSections", "sublistingCategoryId", "groupId", "isGroupParent", "groupParentSlug", "groupChildSlugs", "groupTitle", "barcodeId"];
+export declare const PRODUCT_PUBLIC_FIELDS: readonly ["allowOffers", "minOfferPercent", "id", "title", "description", "category", "subcategory", "brand", "price", "currency", "stockQuantity", "availableQuantity", "images", "status", "storeName", "featured", "tags", "specifications", "features", "shippingInfo", "returnPolicy", "listingType", "auctionEndDate", "startingBid", "currentBid", "bidCount", "reservePrice", "buyNowPrice", "minBidIncrement", "autoExtendable", "auctionExtensionMinutes", "auctionShippingPaidBy", "bidsHaveStarted", "grading", "card", "classified", "digitalCode", "liveItem", "catalogProductId", "preOrderDeliveryDate", "preOrderDepositPercent", "preOrderDepositAmount", "preOrderMaxQuantity", "preOrderCurrentCount", "preOrderProductionStatus", "preOrderCancellable", "condition", "insurance", "insuranceCost", "shippingPaidBy", "isPromoted", "isOnSale", "isSold", "slug", "seoTitle", "seoDescription", "seoKeywords", "viewCount", "customFields", "customSections", "sublistingCategoryId", "groupId", "isGroupParent", "groupParentSlug", "groupChildSlugs", "groupTitle", "createdAt"];
+export declare const PRODUCT_UPDATABLE_FIELDS: readonly ["title", "description", "category", "subcategory", "brand", "price", "stockQuantity", "images", "status", "tags", "specifications", "features", "shippingInfo", "returnPolicy", "pickupAddressId", "condition", "insurance", "shippingPaidBy", "autoExtendable", "auctionExtensionMinutes", "auctionShippingPaidBy", "reservePrice", "buyNowPrice", "minBidIncrement", "bidsHaveStarted", "grading", "card", "classified", "digitalCode", "liveItem", "catalogProductId", "listingType", "preOrderDeliveryDate", "preOrderDepositPercent", "preOrderDepositAmount", "preOrderMaxQuantity", "preOrderProductionStatus", "preOrderCancellable", "isOnSale", "isSold", "allowShipBeforeEmiComplete", "printMeta", "seoTitle", "seoDescription", "seoKeywords", "customFields", "customSections", "sublistingCategoryId", "groupId", "isGroupParent", "groupParentSlug", "groupChildSlugs", "groupTitle", "barcodeId"];
 export type ProductCreateInput = Omit<ProductDocument, "id" | "createdAt" | "updatedAt" | "availableQuantity" | "bidCount" | "currentBid" | "auctionOriginalEndDate">;
 export type ProductUpdateInput = Partial<Pick<ProductDocument, (typeof PRODUCT_UPDATABLE_FIELDS)[number]>>;
 export type ProductAdminUpdateInput = Partial<Omit<ProductDocument, "id" | "createdAt">>;

package/dist/features/products/schemas/firestore.js

@@ -46,6 +46,13 @@ export const DEFAULT_PRODUCT_DATA = {
     auctionShippingPaidBy: "winner",
 };
 export const PRODUCT_PUBLIC_FIELDS = [
+    // Public-facing offer signals: the card grid renders a "Taking Offers" pill
+    // from `allowOffers`, and the detail-page form seeds its minimum from
+    // `minOfferPercent`. Listed here prophylactically — this array currently has
+    // no consumers, so their absence was not a live bug, but it would become one
+    // the moment something starts projecting through it.
+    "allowOffers",
+    "minOfferPercent",
     "id",
     "title",
     "description",
@@ -77,7 +84,6 @@ export const PRODUCT_PUBLIC_FIELDS = [
     "auctionExtensionMinutes",
     "auctionShippingPaidBy",
     // SB-UNI-H 2026-05-13 — eBay hybrid BIN.
-    "buyItNowPrice",
     "bidsHaveStarted",
     // SB-UNI-G 2026-05-13 — TCGPlayer grading + card metadata.
     "grading",
@@ -143,7 +149,6 @@ export const PRODUCT_UPDATABLE_FIELDS = [
     "buyNowPrice",
     "minBidIncrement",
     // SB-UNI-H 2026-05-13 — eBay hybrid BIN updatable.
-    "buyItNowPrice",
     "bidsHaveStarted",
     // SB-UNI-G 2026-05-13 — TCGPlayer grading + card metadata updatable.
     "grading",