@mohasinac/appkit 4.13.1 → 4.15.0

package/dist/_internal/server/features/products/data.js

@@ -11,6 +11,8 @@ import { normalizeError } from "../../../../errors/normalize";
 import { serverLogger } from "../../../../monitoring/server-logger";
 import { PRODUCT_COLLECTION } from "../../../../features/products/schemas/firestore";
 import { PRODUCTS_SITEMAP_LIMIT } from "../../../shared/features/products/config";
+import { isListingRowAvailable } from "../../../shared/listing-types/_registry";
+import { isPubliclyVisible } from "../../../shared/listing-types/availability";
 import { PRODUCT_FIELDS } from "../../../../constants/field-names";
 import { SIEVE_OP, sieveAnd, sieveFilter, sortBy } from "../../../../utils/sieve-builder";
 import { REVIEW_FIELDS } from "../../../../constants/field-names";
@@ -151,47 +153,23 @@ const RELATED_QUERY_PAGE_SIZE = 9;
 const RELATED_DISPLAY_LIMIT = 8;
 /** Firestore doc → card-grid shape. Shared by every related/similar-items carousel. */
 /**
- * Excludes the current product plus any listing-type-specific "invalid to
- * surface as related" state: sold/archived/out-of-stock/draft, ended
- * auctions, closed prize-draws, sold-out pre-orders, depleted digital-code
- * pools.
+ * Excludes the current product, anything not publicly visible, and anything
+ * no longer available — ended auctions, closed prize-draws, filled pre-orders,
+ * depleted code pools, sold-out stock.
+ *
+ * This used to be a private `isValidRelatedItem` here, and it was the only
+ * per-type availability predicate in the codebase — which meant it was also
+ * the only place three bugs could hide: it read `codesAvailable` at the top
+ * level when the schema nests it under `digitalCode.codesAvailable` (so that
+ * branch never fired), it excluded `status` values ("sold", "out_of_stock",
+ * "discontinued") that are not members of the real `ProductStatus` union, and
+ * it had no branch at all for classified / live / art / stickers. It now
+ * shares one definition with the listing query and the homepage.
  */
-function isValidRelatedItem(r, currentProductId, now) {
-    if (r.id === currentProductId)
-        return false;
-    const s = r.status;
-    if (s && ["sold", "out_of_stock", "archived", "discontinued", "draft"].includes(s))
-        return false;
-    if (r.isSold === true)
-        return false;
-    if (r.availableQuantity === 0)
-        return false;
-    if (r.listingType === "auction" && r.auctionEndDate) {
-        const end = r.auctionEndDate;
-        const endDate = typeof end.toDate === "function"
-            ? end.toDate()
-            : end instanceof Date
-                ? end
-                : new Date(String(end));
-        if (endDate <= now)
-            return false;
-    }
-    if (r.listingType === "prize-draw" && r.prizeRevealStatus === "closed")
-        return false;
-    if (r.listingType === "pre-order" &&
-        typeof r.preOrderMaxQuantity === "number" &&
-        typeof r.preOrderCurrentCount === "number" &&
-        r.preOrderCurrentCount >= r.preOrderMaxQuantity) {
-        return false;
-    }
-    if (r.listingType === "digital-code" && r.codesAvailable === 0)
-        return false;
-    return true;
-}
 function toRelatedItems(docs, currentProductId) {
     const now = new Date();
     return docs
-        .filter((r) => isValidRelatedItem(r, currentProductId, now))
+        .filter((r) => r.id !== currentProductId && isPubliclyVisible(r) && isListingRowAvailable(r, now))
         .slice(0, RELATED_DISPLAY_LIMIT)
         .map(toProductItem);
 }

package/dist/_internal/server/features/products/index.d.ts

@@ -1,5 +1,5 @@
 export { getProductForDetail, getReviewsForProduct, listSitemapProducts, type SitemapProduct, computeRelatedItems, toProductItem, toReview, getReviewItemsForProduct, getReviewPageForProduct, type RelatedItemsResult, } from "./data";
-export { listPublicProducts, parsePublicProductParams, PUBLIC_PRODUCT_MAX_PAGE_SIZE, type PublicProductListInput, type PublicProductListResult, type PublicProductListOptions, type PublicProductExecutor, type PublicProductQuery, type ExecutorResult, } from "./list-public";
+export { listPublicProducts, parsePublicProductParams, defaultAvailabilityForListingTypes, PUBLIC_PRODUCT_MAX_PAGE_SIZE, ANY_STATUS, type PublicProductListInput, type PublicProductListResult, type PublicProductListOptions, type PublicProductExecutor, type PublicProductQuery, type ExecutorResult, } from "./list-public";
 export { assertProductOwnership, assertStatusTransition, assertInStock, effectivePrice, isAvailableForPurchase, } from "./service";
 export { createProductAction, createAuctionAction, createPreOrderAction, updateProductAction, deleteProductAction, setProductStatusAction, setProductFeaturedAction, } from "./actions";
 export { PRODUCTS_PAGE_SIZE, PRODUCTS_FEATURED_LIMIT, PRODUCTS_RELATED_LIMIT, PRODUCTS_SITEMAP_LIMIT } from "../../../shared/features/products/config";

package/dist/_internal/server/features/products/index.js

@@ -1,5 +1,5 @@
 export { getProductForDetail, getReviewsForProduct, listSitemapProducts, computeRelatedItems, toProductItem, toReview, getReviewItemsForProduct, getReviewPageForProduct, } from "./data";
-export { listPublicProducts, parsePublicProductParams, PUBLIC_PRODUCT_MAX_PAGE_SIZE, } from "./list-public";
+export { listPublicProducts, parsePublicProductParams, defaultAvailabilityForListingTypes, PUBLIC_PRODUCT_MAX_PAGE_SIZE, ANY_STATUS, } from "./list-public";
 export { assertProductOwnership, assertStatusTransition, assertInStock, effectivePrice, isAvailableForPurchase, } from "./service";
 export { createProductAction, createAuctionAction, createPreOrderAction, updateProductAction, deleteProductAction, setProductStatusAction, setProductFeaturedAction, } from "./actions";
 export { PRODUCTS_PAGE_SIZE, PRODUCTS_FEATURED_LIMIT, PRODUCTS_RELATED_LIMIT, PRODUCTS_SITEMAP_LIMIT } from "../../../shared/features/products/config";

package/dist/_internal/server/features/products/list-public.d.ts

@@ -1,8 +1,16 @@
 import type { JsonValue } from "../../../../schemas/types";
+import { type AvailabilityFilter } from "../../../../constants/field-names";
 /** Vercel Hobby Fluid Compute ceiling (CLAUDE.md Rule #6) — never fetch more at once. */
 export declare const PUBLIC_PRODUCT_MAX_PAGE_SIZE = 50;
 /**
- * Which "Show X" defaults apply to a set of listing types.
+ * `status` sentinel meaning "every publication state". Only the authenticated
+ * admin/seller dashboards may pass it — a public surface that did would leak
+ * drafts. A sentinel rather than `status: undefined` because undefined already
+ * means "use the safe default", and conflating the two is how a leak ships.
+ */
+export declare const ANY_STATUS = "__any__";
+/**
+ * The availability scope a listing surface starts in.
  *
  * THE POINT OF THIS FUNCTION is that SSR and the client refetch call the SAME
  * implementation. `staleTime: Infinity` freezes SSR `initialData` forever, so
@@ -11,14 +19,14 @@ export declare const PUBLIC_PRODUCT_MAX_PAGE_SIZE = 50;
  * them is wrong — permanently (Root Cause #30). Two mirrored literals is
  * exactly how that bug is written; one shared function is how it isn't.
  *
- * `/products` now spans all nine listing types, which makes this load-bearing
- * rather than theoretical: a mixed set includes both sold-out-able types
- * (products, art) and time-boxed ones (auctions, pre-orders, prize draws), so
- * BOTH toggles can apply at once.
+ * It is a constant today rather than a per-type decision — every listing
+ * surface opens on what a shopper can actually buy. It stays a function
+ * because that is the seam a surface would override through, and because
+ * `audit-listing-filter-parity` asserts on this name to prove every SSR view
+ * derives its default rather than hard-coding one (two of them used to).
  */
-export declare function defaultTogglesForListingTypes(types: readonly string[] | undefined): {
-    hideSoldByDefault: boolean;
-    hideEndedByDefault: boolean;
+export declare function defaultAvailabilityForListingTypes(_types?: readonly string[]): {
+    availability: AvailabilityFilter;
 };
 /**
  * A product document as it comes back from either executor. Deliberately
@@ -39,6 +47,12 @@ export interface PublicProductListInput {
     /** Pipe-joined multi-select (`new|used`) — emitted as an OR-group, never as AND. */
     condition?: string;
     storeId?: string;
+    /**
+     * Publication status. Defaults to `published`. Pass `ANY_STATUS` for the
+     * admin/seller dashboards, which exist precisely to show drafts, in-review
+     * and archived rows — that is what lets them share this implementation
+     * instead of hand-rolling a fourth filter builder.
+     */
     status?: string;
     minPrice?: string;
     maxPrice?: string;
@@ -61,8 +75,12 @@ export interface PublicProductListInput {
     typeFacets?: Record<string, string>;
     preOrderProductionStatus?: string;
     prizeRevealStatus?: string;
-    /** Hide sold-out rows. Applied in memory — never pushed into Firestore. */
-    inStock?: boolean;
+    /**
+     * Which availability scope to return. Defaults to `all` so non-browse
+     * callers (related items, search, homepage helpers that opt in explicitly)
+     * are unaffected. Browse surfaces pass `available`.
+     */
+    availability?: AvailabilityFilter;
     dateFrom?: string;
     dateTo?: string;
     /** Pre-validated raw Sieve string (callers must safelist fields themselves). */
@@ -80,6 +98,14 @@ export interface PublicProductListResult {
     totalPages: number;
     hasMore: boolean;
     cursor: string | null;
+    /**
+     * A bounded fetch saturated its ceiling, so `total` is a FLOOR, not a count.
+     * Callers must render it as "50+", never as an exact figure, and must not
+     * compute a final page number from it. Before this existed, the in-memory
+     * path reported the size of its own 50-row window as the size of the result
+     * set — a claim that is simply false past the ceiling.
+     */
+    truncated: boolean;
     /** The Sieve string actually sent to Firestore — surfaced for debugging. */
     filters: string;
     sorts: string;
@@ -113,6 +139,12 @@ export interface PublicProductListOptions {
      * the fetch. Callers that can read siteSettings pass `enabledListingTypes(...)`.
      */
     enabledListingTypes?: ReadonlySet<string>;
+    /**
+     * The instant "now" refers to. Defaults to the wall clock; injectable so a
+     * fan-out's several queries all resolve `"NOW"` to the SAME timestamp, and
+     * so tests can pin it.
+     */
+    now?: Date;
 }
 /**
  * Read the shared public-listing query params. SSR views hand in Next's
@@ -124,17 +156,11 @@ export declare function parsePublicProductParams(params: URLSearchParams | Recor
     pageSize?: number;
     sorts?: string;
     /**
-     * Public browse pages hide sold-out rows until the user flips "Show sold".
-     * The API route leaves this off so non-browse callers (related items,
-     * homepage sections) keep their current behaviour.
-     */
-    hideSoldByDefault?: boolean;
-    /**
-     * Auctions / pre-orders hide already-ended rows until "Show ended" is on,
-     * by defaulting `dateFrom` to now. Must mirror the paired client listing
-     * component exactly or the SSR paint and the refetch disagree.
+     * The scope to use when the URL names none. Browse surfaces pass
+     * `available` via `defaultAvailabilityForListingTypes`; the API route
+     * leaves it undefined so non-browse callers keep seeing everything.
      */
-    hideEndedByDefault?: boolean;
+    availability?: AvailabilityFilter;
 }): PublicProductListInput;
 export declare function listPublicProducts(input: PublicProductListInput, opts?: PublicProductListOptions): Promise<PublicProductListResult | null>;
 /**