@luma.gl/webgl 8.6.0-alpha.1 → 8.6.0-alpha.2

package/src/device/webgl-device.ts

@@ -0,0 +1,406 @@
+// luma.gl, MIT license
+import {Device, DeviceInfo, DeviceLimits, log} from '@luma.gl/api';
+import {polyfillContext} from '../context/polyfill/polyfill-context';
+import {trackContextState} from '../context/state-tracker/track-context-state';
+import { ContextState } from '../context/context/context-state';
+import {getDevicePixelRatio, setDevicePixelRatio} from '../context/context/device-pixels';
+import {createBrowserContext} from '../context/context/create-context';
+import {getCanvas} from '../context/context/get-canvas';
+import {isWebGL, isWebGL2} from '../context/context/webgl-checks';
+import {getDeviceInfo} from './get-device-info';
+import {getDeviceFeatures, Feature} from './device-features';
+import {getDeviceLimits, getWebGLLimits, WebGLLimits} from './device-limits';
+
+// WebGL classes
+import type {BufferProps, ShaderProps} from '@luma.gl/api';
+import WEBGLBuffer from '../classes/webgl-buffer';
+import {WEBGLShader} from '../classes/webgl-shader';
+import Texture2D, {Texture2DProps} from '../classes/texture-2d';
+import type {default as Framebuffer} from '../classes/framebuffer';
+import type {default as VertexArrayObject} from '../classes/vertex-array-object';
+
+/** WebGLDevice options */
+export type WebGLDeviceProps = {
+  canvas?: HTMLCanvasElement | OffscreenCanvas | string; // A canvas element or a canvas string id
+  width?: number /** width is only used when creating a new canvas */;
+  height?: number /** height is only used when creating a new canvas */;
+  // Attach to existing context
+  gl?: WebGLRenderingContext | WebGL2RenderingContext;
+  // COMMON CONTEXT PARAMETERS
+  webgl2?: boolean; // Set to false to not create a WebGL2 context (force webgl1)
+  webgl1?: boolean; // set to false to not create a WebGL1 context (fails if webgl2 not available)
+  manageState?: boolean; // Set to false to disable WebGL state management instrumentation
+  debug?: boolean; // Instrument context (at the expense of performance)
+  break?: Array<any>; // TODO: types
+  onContextLost?: (event: Event) => void;
+  onContextRestored?: (event: Event) => void;
+  // BROWSER CONTEXT PARAMETERS
+  alpha?: boolean; // Default render target has an alpha buffer.
+  depth?: boolean; // Default render target has a depth buffer of at least 16 bits.
+  stencil?: boolean; // Default render target has a stencil buffer of at least 8 bits.
+  antialias?: boolean; // Boolean that indicates whether or not to perform anti-aliasing.
+  premultipliedAlpha?: boolean; // Boolean that indicates that the page compositor will assume the drawing buffer contains colors with pre-multiplied alpha.
+  preserveDrawingBuffer?: boolean; // Default render target buffers will not be automatically cleared and will preserve their values until cleared or overwritten
+  failIfMajorPerformanceCaveat?: boolean; // Do not create if the system performance is low.
+};
+
+const DEFAULT_DEVICE_PROPS: Required<WebGLDeviceProps> = {
+  canvas: undefined, // A canvas element or a canvas string id
+  gl: undefined,
+  webgl2: true, // Attempt to create a WebGL2 context
+  webgl1: true, // Attempt to create a WebGL1 context (false to fail if webgl2 not available)
+  manageState: true,
+  width: 800, // width are height are only used by headless gl
+  height: 600,
+  debug: false, // Instrument context (at the expense of performance)
+  break: undefined,
+  onContextLost: () => console.error('WebGL context lost'),
+  onContextRestored: () => console.info('WebGL context restored'),
+
+  alpha: undefined,
+  depth: undefined,
+  stencil: undefined,
+  antialias: undefined,
+  premultipliedAlpha: undefined,
+  preserveDrawingBuffer: undefined,
+  failIfMajorPerformanceCaveat: undefined
+};
+
+// TODO use weakmap instead of modifying context
+const glToContextMap = new WeakMap<WebGLRenderingContext | WebGL2RenderingContext, WebGLDevice>();
+
+export function getWebGLDevice(gl: WebGLRenderingContext | WebGL2RenderingContext): WebGLDevice | undefined {
+  return glToContextMap.get(gl);
+}
+
+let counter = 0;
+
+/** WebGPU style Device API for a WebGL context */
+export default class WebGLDevice extends Device implements ContextState {
+  // WebGPU style API
+
+  /** A set like interface to test features */
+  readonly features: Set<Feature>;
+  readonly limits: DeviceLimits;
+  readonly info: DeviceInfo;
+
+  /** Promise that rejects when context is lost */
+  readonly lost: Promise<string>;
+
+  // Common API
+  props: Required<WebGLDeviceProps>;
+  userData: {[key: string]: any};
+
+  // WebGL specific API
+  readonly isWebGL2: boolean;
+  readonly gl: WebGLRenderingContext;
+  readonly gl2: WebGL2RenderingContext;
+  /** Is this device attached to an offscreen context */
+  readonly offScreen: boolean = false;
+
+  readonly webglFeatures: Set<string>;
+  readonly webglLimits: WebGLLimits;
+
+  defaultFramebuffer?: Framebuffer;
+  defaultVertexArray?: VertexArrayObject;
+
+  // State used by luma.gl classes
+  _state: 'uninitialized' | 'initializing' | 'initialized' = 'uninitialized';
+  readonly _canvasSizeInfo = {clientWidth: 0, clientHeight: 0, devicePixelRatio: 1};
+  readonly _extensions: Record<string, any> = {};
+  _polyfilled: boolean = false;
+
+  /**
+   * 
+   */
+  static fromContext(gl: WebGLRenderingContext): WebGLDevice {
+    // @ts-expect-error
+    return gl.device as WebGLDevice;
+  }
+
+  /**
+   * Get a device instance from a GL context
+   * Creates and instruments the device if not already created
+   * @param gl
+   * @returns
+   */
+  static attach(
+    gl: Device | WebGLRenderingContext | WebGL2RenderingContext,
+    props?: WebGLDeviceProps
+  ): WebGLDevice {
+    if (gl instanceof WebGLDevice) {
+      return gl;
+    }  
+    if (!isWebGL(gl)) {
+      throw new Error('Invalid WebGLRenderingContext');
+    }
+    return new WebGLDevice({...props, gl: gl as WebGLRenderingContext});
+  }
+
+
+  constructor(props: WebGLDeviceProps) {
+    super();
+    
+    this.props = {...DEFAULT_DEVICE_PROPS, ...props};
+
+    // If attaching to an already attached context, return the attached device
+    // @ts-expect-error device is attached to context
+    const device: WebGLDevice | undefined = this.props.gl?.device;
+    if (device) {
+      if (device._state !== 'initialized') {
+        log.error('recursive context');
+        throw new Error('recursive context');
+      }
+      return device;
+    }
+
+    this.offScreen =
+      typeof OffscreenCanvas !== 'undefined' &&
+      props.canvas instanceof OffscreenCanvas;
+
+    // Create an instrument context
+    this.gl = (this.props.gl || this._createContext(props)) as WebGLRenderingContext;
+    this.gl2 = this.gl as WebGL2RenderingContext;
+    this.isWebGL2 = isWebGL2(this.gl);
+    this._state = 'initializing';
+    // Avoid multiple instrumentations
+    // @ts-expect-error
+    if (this.gl.device) {
+      log.error('device already created');
+      throw new Error('device already created'); // ASSERT this device;
+    }
+    // @ts-expect-error
+    this.gl.device = this;
+    // @ts-ignore
+    this.gl._version = typeof WebGL2RenderingContext !== 'undefined' && this.gl instanceof WebGL2RenderingContext ? 2 : 1;
+    // TODO - move to weak map indexing
+    glToContextMap.set(this.gl, this);
+
+    // Luma Device fields
+    this.info = getDeviceInfo(this.gl);
+    // Log some debug info about the newly created context
+    // @ts-expect-error device is attached to context
+    const debug = this.gl.debug ? ' debug' : '';
+    const webGL = isWebGL2(this.gl) ? 'WebGL2' : 'WebGL1';
+    log.group(0, `${webGL}${debug} context: ${this.info.vendor}, ${this.info.renderer}`)();
+
+    polyfillContext(this.gl);
+    log.probe(0, 'polyfilled context')();
+
+    // Install context state tracking
+    trackContextState(this.gl, {
+      copyState: false,
+      log: (...args) => log.log(1, ...args)()
+    });
+    log.probe(0, 'instrumented context')();
+
+    // WebGPU Device fields
+    this.features = getDeviceFeatures(this.gl);
+    log.probe(0, `queried device features ${counter}`)();
+    this.limits = getDeviceLimits(this.gl);
+    log.probe(0, 'queried device limits')();
+
+    // Add seer integration - TODO - currently removed
+
+    // WEBGL specific fields
+    this.webglLimits = getWebGLLimits(this.gl);
+    log.probe(0, 'queried webgl limits')();
+
+    // Add debug instrumentation to the context
+    // if (isBrowser() && props.debug) {
+    //   // @ts-ignore
+    //   const {makeDebugContext} = global;
+    //   if (!makeDebugContext) {
+    //     log.warn('WebGL debug mode not activated. import "@luma.gl/debug" to enable.')();
+    //   } else {
+    //     // @ts-ignore
+    //     this.gl = global.makeDebugContext(this.gl, props);
+    //     this.gl2 = this.gl as WebGL2RenderingContext;
+    //     // Debug forces log level to at least 1
+    //     log.level = Math.max(log.level, 1);
+    //   }
+    // }
+
+    log.groupEnd(0)();
+    this._state = 'initialized';
+  }
+
+  /**
+   * Destroys the context
+   * @note Has no effect for browser contexts, there is no browser API for destroying contexts
+   */
+  destroy() {
+    let ext = this.gl.getExtension('STACKGL_destroy_context');
+    if (ext) {
+      ext.destroy();
+    }
+    // ext = this.gl.getExtension('WEBGL_lose_context');
+    // if (ext) {
+    //   // TODO - disconnect context lost callbacks?
+    //   ext.loseContext();
+    // }
+  }
+
+  // WEBGL SPECIFIC METHODS
+
+  /**
+   * Resize the canvas' drawing buffer.
+   *
+   * Can match the canvas CSS size, and optionally also consider devicePixelRatio
+   * Can be called every frame
+   *
+   * Regardless of size, the drawing buffer will always be scaled to the viewport, but
+   * for best visual results, usually set to either:
+   *  canvas CSS width x canvas CSS height
+   *  canvas CSS width * devicePixelRatio x canvas CSS height * devicePixelRatio
+   * See http://webgl2fundamentals.org/webgl/lessons/webgl-resizing-the-canvas.html
+   */
+  resize(options?: {width?: number; height?: number; useDevicePixels?: boolean | number}): void {
+    // Resize browser context .
+    if (this.gl.canvas) {
+      const devicePixelRatio = getDevicePixelRatio(options?.useDevicePixels);
+      setDevicePixelRatio(this.gl, devicePixelRatio, options);
+      return;
+    }
+
+    // Resize headless gl context
+    const ext = this.gl.getExtension('STACKGL_resize_drawingbuffer');
+    if (ext && options && `width` in options && `height` in options) {
+      ext.resize(options.width, options.height);
+    }
+  }
+
+  _createBuffer(props: BufferProps): WEBGLBuffer {
+    return new WEBGLBuffer(this.gl, props);
+  }
+
+  createTexture(props: Texture2DProps): Texture2D {
+    return new Texture2D(this.gl, props);
+  }
+
+  createShader(props: ShaderProps): WEBGLShader {
+    return new WEBGLShader(this.gl, props);
+  }
+
+  /**
+   * Offscreen Canvas Support: Commit the frame
+   * https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/commit
+   * Chrome's offscreen canvas does not require gl.commit
+   */
+  commit(): void {
+    // @ts-expect-error gl.commit is not officially part of WebGLRenderingContext
+    if (this.offScreen && this.gl.commit) {
+      // @ts-expect-error gl.commit is not officially part of WebGLRenderingContext
+      this.gl.commit();
+    }
+  }
+
+  // PRIVATE METHODS
+
+  /**
+   * Creates a context giving access to the WebGL API
+   */
+  _createContext(options?: WebGLDeviceProps): WebGLRenderingContext {
+    const {width, height, canvas} = this.props;
+    // Get or create a canvas
+    const targetCanvas = getCanvas({canvas, width, height});
+    // Create a WebGL context in the canvas
+    return createBrowserContext(targetCanvas, options);
+  }
+}
+
+/*
+import {
+  isWebGL, isWebGL2,
+  createGLContext,
+  instrumentGLContext,
+  getContextDebugInfo,
+  resizeGLContext
+} from '@luma.gl/gltools';
+
+// prettier-ignore
+import {
+  Device, DeviceInfo, DeviceLimits,
+  Buffer, BufferProps
+} from '@luma.gl/api';
+
+import {getWebGLDeviceInfo} from '../converters/webgl-device-info';
+import {getWebGLLimits} from '../converters/webgl-limits';
+import {getWebGLFeatures} from '../converters/webgl-features';
+
+export default class WEBGLDevice implements Device {
+  readonly handle: WebGLRenderingContext;
+  readonly gl: WebGLRenderingContext;
+  readonly gl2: WebGL2RenderingContext | null;
+  readonly canvas: HTMLCanvasElement;
+
+  static isSupported(options: {canvas?: HTMLCanvasElement}): boolean {
+    const {canvas} = options;
+    let gl;
+    try {
+      gl = canvas && canvas.getContext("webgl");
+      gl = gl && canvas && canvas.getContext("experimental-webgl");
+    } catch (x) {
+      gl = null;
+    }
+    return Boolean(gl);
+  }
+
+  constructor(props = {}) {
+    const {canvas, swapChainFormat = "bgra8unorm"} = props;
+
+    const gl = createGLContext(props);
+    this.handle =
+    this.gl = gl;
+    this.gl2 = gl instanceof WebGL2RenderingContext ? gl : null;
+    this.canvas = canvas;
+  }
+
+  resize(width, height) {
+    resizeGLContext(this.gl);
+  }
+
+  getInfo(): DeviceInfo {
+    return getWebGLDeviceInfo(this.gl);
+  }
+
+  getLimits(): DeviceLimits {
+    return getWebGLLimits(this.gl, this.gl2);
+  }
+
+  getFeatures(): string[] {
+    return getWebGLFeatures(this.gl);
+  }
+
+  createBuffer(props: WebGPUBufferProps): WEBGLBuffer {
+    return new WEBGLBuffer(this.gl2 || this.gl, props);
+  }
+
+  createTexture(props: WebGPUTextureProps): WEBGLTexture {
+    return new WEBGLTexture(this, props);
+  }
+
+  createSampler(props: WebGPUSamplerProps): WEBGLSampler {
+    return new WEBGLSampler(this, props);
+  }
+
+  createShader(props: WebGPUShaderProps): WEBGLShader {
+    return new WEBGLShader(this, props);
+  }
+
+  createRenderPipeline(props: WebGPURenderPipelineProps): WEBGLPipeline {
+    return new WEBGLRenderPipeline(this, props);
+  }
+
+  createComputePipeline(props: WebGPUComputePipelineProps): WebGPUPipeline {
+    return new WebGPUComputePipeline(this, props);
+  }
+
+
+  // PRIVATE
+
+  _startFrame() {}
+
+  _endFrame() {}
+}
+*/

package/src/index.ts

@@ -5,7 +5,11 @@
 // Higher level abstractions can be built on these classes
 
 // Initialize any global state
-export {lumaStats} from './init';
+import './init';
+
+// export type {WebGLDeviceProps, WebGLDeviceInfo, WebGPUDeviceLimits} from './lib/webgl-device';
+export type {WebGLDeviceProps} from './device/webgl-device';
+export {default as WebGLDevice, getWebGLDevice} from './device/webgl-device';
 
 // UTILS
 export {requestAnimationFrame, cancelAnimationFrame} from './webgl-utils/request-animation-frame';
@@ -13,24 +17,26 @@ export {requestAnimationFrame, cancelAnimationFrame} from './webgl-utils/request
 // WebGL Functions
 export {cloneTextureFrom} from './webgl-utils/texture-utils';
 export {getKeyValue, getKey} from './webgl-utils/constants-to-keys';
-export {getContextInfo, getGLContextInfo, getContextLimits} from './features/limits';
-export {FEATURES} from './features/webgl-features-table';
-export {hasFeature, hasFeatures, getFeatures} from './features/features';
-export {default as canCompileGLGSExtension} from './features/check-glsl-extension';
 
 // WebGL Helper Classes
 export {default as Accessor} from './classes/accessor';
 
 // WebGL1 classes
-// export type {BufferProps} from './api/buffer';
+export type {BufferProps} from '@luma.gl/api';
 export {default as Buffer} from './classes/webgl-buffer';
-export {default as Texture2D, Texture2DProps} from './classes/texture-2d';
-export {default as TextureCube, TextureCubeProps} from './classes/texture-cube';
+export type {Texture2DProps} from './classes/texture-2d';
+export {default as Texture2D} from './classes/texture-2d';
+export type {TextureCubeProps} from './classes/texture-cube';
+export {default as TextureCube} from './classes/texture-cube';
 
-export {Shader, VertexShader, FragmentShader, ShaderProps} from './classes/webgl-shader';
-export {default as Program, ProgramProps} from './classes/program';
-export {default as Framebuffer, FramebufferProps} from './classes/framebuffer';
-export {default as Renderbuffer, RenderbufferProps} from './classes/renderbuffer';
+export type {ShaderProps} from './classes/webgl-shader';
+export {Shader, VertexShader, FragmentShader} from './classes/webgl-shader';
+export type {ProgramProps} from './classes/program';
+export {default as Program} from './classes/program';
+export type {FramebufferProps} from './classes/framebuffer';
+export {default as Framebuffer} from './classes/framebuffer';
+export type {RenderbufferProps} from './classes/renderbuffer';
+export {default as Renderbuffer} from './classes/renderbuffer';
 
 export {clear, clearBuffer} from './classes/clear';
 
@@ -45,21 +51,54 @@ export {
 } from './classes/copy-and-blit';
 
 // WebGL2 classes & Extensions
-export {default as Query, QueryProps} from './classes/query';
-export {default as Texture3D, Texture3DProps} from './classes/texture-3d';
-export {default as TransformFeedback, TransformFeedbackProps} from './classes/transform-feedback';
-export {default as VertexArrayObject, VertexArrayObjectProps} from './classes/vertex-array-object';
-export {default as VertexArray, VertexArrayProps} from './classes/vertex-array';
+export type {QueryProps} from './classes/query';
+export {default as Query} from './classes/query';
+export type {Texture3DProps} from './classes/texture-3d';
+export {default as Texture3D} from './classes/texture-3d';
+export type {TransformFeedbackProps} from './classes/transform-feedback';
+export {default as TransformFeedback} from './classes/transform-feedback';
+export type {VertexArrayObjectProps} from './classes/vertex-array-object';
+export {default as VertexArrayObject} from './classes/vertex-array-object';
+export type {VertexArrayProps} from './classes/vertex-array';
+export {default as VertexArray} from './classes/vertex-array';
 export {default as UniformBufferLayout} from './classes/uniform-buffer-layout';
 
 // experimental WebGL exports
 
-export {setPathPrefix, loadFile, loadImage} from './utils/load-file';
-
 // UTILS
-export {log} from '@luma.gl/gltools';
-export {default as assert} from './utils/assert';
-export {uid, isObjectEmpty} from './utils/utils';
+export {
+  isWebGL,
+  isWebGL2,
+  getWebGL2Context,
+  assertWebGLContext,
+  assertWebGL2Context
+} from './context/context/webgl-checks';
+
+// Device ratio
+export {cssToDeviceRatio, cssToDevicePixels} from './context/context/device-pixels';
+
+// Unified parameter API
+
+export type {GLParameters} from './context/parameters/webgl-parameters';
+export {
+  getParameters,
+  setParameters,
+  resetParameters
+} from './context/parameters/unified-parameter-api';
+
+export {
+  withParameters
+} from './context/state-tracker/with-parameters';
+
+// State tracking
+export {
+  trackContextState,
+  pushContextState,
+  popContextState
+} from './context/state-tracker/track-context-state';
+
+// Polyfills (supports a subset of WebGL2 APIs on WebGL1 contexts)
+export {polyfillContext} from './context/polyfill/polyfill-context';
 
 // INTERNAL
 export {parseUniformName, getUniformSetter} from './classes/uniforms';
@@ -67,6 +106,21 @@ export {getDebugTableForUniforms} from './debug/debug-uniforms';
 export {getDebugTableForVertexArray} from './debug/debug-vertex-array';
 export {getDebugTableForProgramConfiguration} from './debug/debug-program-configuration';
 
+// DEPRECATED
+
+// Deprecated re-exports
+export {lumaStats} from './init';
+export {log, assert, uid, isObjectEmpty} from '@luma.gl/api';
+export {setPathPrefix, loadFile, loadImage} from '@luma.gl/api';
+
+
+// export {
+//   getContextInfo, getGLContextInfo, getContextLimits,
+//   FEATURES,
+//   getFeatures,
+//   canCompileGLGSExtension
+// } from '@luma.gl/gltools';
+
 // REMOVED in v8.6
 // getShaderInfo,
 // getShaderName

package/src/init.ts

@@ -1,9 +1,10 @@
-import {log} from '@luma.gl/gltools';
-import {isBrowser, global} from 'probe.gl/env';
-import {lumaStats} from '@luma.gl/api';
+import {log} from '@luma.gl/api';
+import {isBrowser} from '@probe.gl/env';
+import {luma, lumaStats} from '@luma.gl/api';
+import WebGLDevice from './device/webgl-device';
 
 // Version detection using babel plugin
-// @ts-ignore
+// @ts-expect-error
 const VERSION = typeof __VERSION__ !== 'undefined' ? __VERSION__ : 'untranspiled source';
 
 const STARTUP_MESSAGE = 'set luma.log.level=1 (or higher) to trace rendering';
@@ -11,16 +12,18 @@ const STARTUP_MESSAGE = 'set luma.log.level=1 (or higher) to trace rendering';
 // 0: none, 1: minimal, 2: verbose, 3: attribute/uniforms, 4: gl logs
 // luma.log.break[], set to gl funcs, luma.log.profile[] set to model names`;
 
-if (global.luma && global.luma.VERSION !== VERSION) {
-  throw new Error(`luma.gl - multiple VERSIONs detected: ${global.luma.VERSION} vs ${VERSION}`);
+if (globalThis.luma && globalThis.luma.VERSION !== VERSION) {
+  throw new Error(`luma.gl - multiple VERSIONs detected: ${globalThis.luma.VERSION} vs ${VERSION}`);
 }
 
-if (!global.luma) {
+if (!globalThis.luma) {
+  luma.registerDevices([WebGLDevice]);
+
   if (isBrowser()) {
     log.log(1, `luma.gl ${VERSION} - ${STARTUP_MESSAGE}`)();
   }
 
-  global.luma = global.luma || {
+  globalThis.luma = globalThis.luma || {
     VERSION,
     version: VERSION,
     log,
@@ -42,4 +45,4 @@ if (!global.luma) {
 }
 
 export {lumaStats};
-export default global.luma;
+export default globalThis.luma;

package/src/types.ts

@@ -5,4 +5,4 @@ export type AccessorObject = {
   divisor?: number;
   offset?: number;
   stride?: number;
-};
+};

package/src/webgl-utils/attribute-utils.ts

@@ -1,4 +1,4 @@
-import {assert} from '../utils';
+import {assert} from '@luma.gl/api';
 
 const GL_BYTE = 0x1400;
 const GL_UNSIGNED_BYTE = 0x1401;

package/src/webgl-utils/constants-to-keys.ts

@@ -1,4 +1,4 @@
-import {assert} from '../utils';
+import {assert} from '@luma.gl/api';
 
 // Resolve a WebGL enumeration name (returns itself if already a number)
 export function getKeyValue(gl, name) {

package/src/webgl-utils/format-utils.ts

@@ -1,5 +1,5 @@
+import {assert} from '@luma.gl/api';
 import GL from '@luma.gl/constants';
-import {assert} from '../utils';
 
 // Returns number of components in a specific readPixels WebGL format
 export function glFormatToComponents(format) {

package/src/{features/check-old-ie.ts → webgl-utils/is-old-ie.ts}

@@ -1,7 +1,7 @@
 // opts allows user agent to be overridden for testing
-export default function isOldIE(opts = {}) {
-  const navigator = (typeof window !== 'undefined' && window.navigator) || {};
-  // @ts-ignore
+export function isOldIE(opts = {}) {
+  const navigator = typeof window !== 'undefined' ? window.navigator || {} : {};
+  // @ts-expect-error
   const userAgent = opts.userAgent || navigator.userAgent || '';
   // We only care about older versions of IE (IE 11 and below). Newer versions of IE (Edge)
   // have much better web standards support.

package/src/webgl-utils/{texture-utils.js → texture-utils.ts}

@@ -1,14 +1,16 @@
 // TODO: Two subdirectories must not depend on each other (classes vs utils)!
+import {assert} from '@luma.gl/api';
+import GL from '@luma.gl/constants';
+import Texture from '../classes/texture';
 import Texture2D from '../classes/texture-2d';
 import TextureCube from '../classes/texture-cube';
 import Texture3D from '../classes/texture-3d';
-import Framebuffer from '../classes/framebuffer';
-import GL from '@luma.gl/constants';
-import {assert} from '../utils';
+import Framebuffer, {FramebufferProps} from '../classes/framebuffer';
+
+type TextureType = Texture2D | TextureCube | Texture3D;
 
-// Clone a new texture object from a reference texture object.
-/** @type {import('./texture-utils').cloneTextureFrom} */
-export function cloneTextureFrom(refTexture, overrides) {
+/** Clone a new texture object from a reference texture object. */
+export function cloneTextureFrom<T extends TextureType>(refTexture: T, overrides?: any): T {
   assert(
     refTexture instanceof Texture2D ||
       refTexture instanceof TextureCube ||
@@ -37,10 +39,11 @@ export function cloneTextureFrom(refTexture, overrides) {
   return new TextureType(gl, textureOptions);
 }
 
-// Wraps a given texture into a framebuffer object, that can be further used
-// to read data from the texture object.
-/** @type {import('./texture-utils').toFramebuffer} */
-export function toFramebuffer(texture, opts) {
+/**
+ * Wraps a given texture into a framebuffer object, that can be further used
+ * to read data from the texture object.
+ */ 
+export function toFramebuffer(texture: Texture, opts?: FramebufferProps): Framebuffer {
   const {gl, width, height, id} = texture;
   const framebuffer = new Framebuffer(
     gl,