@heyai-rules/pilo-masterkit 1.2.2 → 3.1.0

package/.agent/workflows/cpp-build.md

@@ -1,173 +1,173 @@
----
-description: Fix C++ build errors, CMake issues, and linker problems incrementally. Invokes the cpp-build-resolver agent for minimal, surgical fixes.
----
-
-# C++ Build and Fix
-
-This command invokes the **cpp-build-resolver** agent to incrementally fix C++ build errors with minimal changes.
-
-## What This Command Does
-
-1. **Run Diagnostics**: Execute `cmake --build`, `clang-tidy`, `cppcheck`
-2. **Parse Errors**: Group by file and sort by severity
-3. **Fix Incrementally**: One error at a time
-4. **Verify Each Fix**: Re-run build after each change
-5. **Report Summary**: Show what was fixed and what remains
-
-## When to Use
-
-Use `/cpp-build` when:
-- `cmake --build build` fails with errors
-- Linker errors (undefined references, multiple definitions)
-- Template instantiation failures
-- Include/dependency issues
-- After pulling changes that break the build
-
-## Diagnostic Commands Run
-
-```bash
-# CMake configure
-cmake -B build -S .
-
-# Build
-cmake --build build 2>&1 | head -100
-
-# Static analysis (if available)
-clang-tidy src/*.cpp -- -std=c++17
-cppcheck --enable=all src/
-```
-
-## Example Session
-
-```text
-User: /cpp-build
-
-Agent:
-# C++ Build Resolution
-
-## Initial Diagnostics
-
-```bash
-$ cmake --build build
-src/service/user.cpp:25:15: error: use of undeclared identifier 'UserRepository'
-src/handler/api.cpp:42:9: error: no matching function for call to 'process'
-src/handler/api.cpp:58:1: error: non-void function does not return a value
-```
-
-Errors found: 3
-
-## Fix 1: Undeclared Identifier
-
-File: src/service/user.cpp:25
-Error: use of undeclared identifier 'UserRepository'
-Cause: Missing include
-
-```cpp
-// Added include
-#include "repository/user_repository.hpp"
-```
-
-```bash
-$ cmake --build build
-# 2 errors remaining
-```
-
-## Fix 2: No Matching Function
-
-File: src/handler/api.cpp:42
-Error: no matching function for call to 'process'
-
-```cpp
-// Changed
-process(params.get("count"));
-// To
-process(std::stoi(params.get("count")));
-```
-
-```bash
-$ cmake --build build
-# 1 error remaining
-```
-
-## Fix 3: Missing Return
-
-File: src/handler/api.cpp:58
-Error: non-void function does not return a value
-
-```cpp
-std::optional<User> getUser(const std::string& id) {
-    if (id.empty()) {
-        return std::nullopt;
-    }
-    auto user = findUser(id);
-    // Added missing return
-    return user;
-}
-```
-
-```bash
-$ cmake --build build
-# Build successful!
-```
-
-## Final Verification
-
-```bash
-$ ctest --test-dir build --output-on-failure
-Test project build
-    1/5 Test #1: unit_tests ........   Passed    0.02 sec
-    2/5 Test #2: integration_tests    Passed    0.15 sec
-All tests passed.
-```
-
-## Summary
-
-| Metric | Count |
-|--------|-------|
-| Build errors fixed | 3 |
-| Linker errors fixed | 0 |
-| Files modified | 2 |
-| Remaining issues | 0 |
-
-Build Status: ✅ SUCCESS
-```
-
-## Common Errors Fixed
-
-| Error | Typical Fix |
-|-------|-------------|
-| `undeclared identifier` | Add `#include` or fix typo |
-| `no matching function` | Fix argument types or add overload |
-| `undefined reference` | Link library or add implementation |
-| `multiple definition` | Use `inline` or move to .cpp |
-| `incomplete type` | Replace forward decl with `#include` |
-| `no member named X` | Fix member name or include |
-| `cannot convert X to Y` | Add appropriate cast |
-| `CMake Error` | Fix CMakeLists.txt configuration |
-
-## Fix Strategy
-
-1. **Compilation errors first** - Code must compile
-2. **Linker errors second** - Resolve undefined references
-3. **Warnings third** - Fix with `-Wall -Wextra`
-4. **One fix at a time** - Verify each change
-5. **Minimal changes** - Don't refactor, just fix
-
-## Stop Conditions
-
-The agent will stop and report if:
-- Same error persists after 3 attempts
-- Fix introduces more errors
-- Requires architectural changes
-- Missing external dependencies
-
-## Related Commands
-
-- `/cpp-test` - Run tests after build succeeds
-- `/cpp-review` - Review code quality
-- `/verify` - Full verification loop
-
-## Related
-
-- Agent: `agents/cpp-build-resolver.md`
-- Skill: `skills/cpp-coding-standards/`
+---
+description: Fix C++ build errors, CMake issues, and linker problems incrementally. Invokes the cpp-build-resolver agent for minimal, surgical fixes.
+---
+
+# C++ Build and Fix
+
+This command invokes the **cpp-build-resolver** agent to incrementally fix C++ build errors with minimal changes.
+
+## What This Command Does
+
+1. **Run Diagnostics**: Execute `cmake --build`, `clang-tidy`, `cppcheck`
+2. **Parse Errors**: Group by file and sort by severity
+3. **Fix Incrementally**: One error at a time
+4. **Verify Each Fix**: Re-run build after each change
+5. **Report Summary**: Show what was fixed and what remains
+
+## When to Use
+
+Use `/cpp-build` when:
+- `cmake --build build` fails with errors
+- Linker errors (undefined references, multiple definitions)
+- Template instantiation failures
+- Include/dependency issues
+- After pulling changes that break the build
+
+## Diagnostic Commands Run
+
+```bash
+# CMake configure
+cmake -B build -S .
+
+# Build
+cmake --build build 2>&1 | head -100
+
+# Static analysis (if available)
+clang-tidy src/*.cpp -- -std=c++17
+cppcheck --enable=all src/
+```
+
+## Example Session
+
+```text
+User: /cpp-build
+
+Agent:
+# C++ Build Resolution
+
+## Initial Diagnostics
+
+```bash
+$ cmake --build build
+src/service/user.cpp:25:15: error: use of undeclared identifier 'UserRepository'
+src/handler/api.cpp:42:9: error: no matching function for call to 'process'
+src/handler/api.cpp:58:1: error: non-void function does not return a value
+```
+
+Errors found: 3
+
+## Fix 1: Undeclared Identifier
+
+File: src/service/user.cpp:25
+Error: use of undeclared identifier 'UserRepository'
+Cause: Missing include
+
+```cpp
+// Added include
+#include "repository/user_repository.hpp"
+```
+
+```bash
+$ cmake --build build
+# 2 errors remaining
+```
+
+## Fix 2: No Matching Function
+
+File: src/handler/api.cpp:42
+Error: no matching function for call to 'process'
+
+```cpp
+// Changed
+process(params.get("count"));
+// To
+process(std::stoi(params.get("count")));
+```
+
+```bash
+$ cmake --build build
+# 1 error remaining
+```
+
+## Fix 3: Missing Return
+
+File: src/handler/api.cpp:58
+Error: non-void function does not return a value
+
+```cpp
+std::optional<User> getUser(const std::string& id) {
+    if (id.empty()) {
+        return std::nullopt;
+    }
+    auto user = findUser(id);
+    // Added missing return
+    return user;
+}
+```
+
+```bash
+$ cmake --build build
+# Build successful!
+```
+
+## Final Verification
+
+```bash
+$ ctest --test-dir build --output-on-failure
+Test project build
+    1/5 Test #1: unit_tests ........   Passed    0.02 sec
+    2/5 Test #2: integration_tests    Passed    0.15 sec
+All tests passed.
+```
+
+## Summary
+
+| Metric | Count |
+|--------|-------|
+| Build errors fixed | 3 |
+| Linker errors fixed | 0 |
+| Files modified | 2 |
+| Remaining issues | 0 |
+
+Build Status: PASS: SUCCESS
+```
+
+## Common Errors Fixed
+
+| Error | Typical Fix |
+|-------|-------------|
+| `undeclared identifier` | Add `#include` or fix typo |
+| `no matching function` | Fix argument types or add overload |
+| `undefined reference` | Link library or add implementation |
+| `multiple definition` | Use `inline` or move to .cpp |
+| `incomplete type` | Replace forward decl with `#include` |
+| `no member named X` | Fix member name or include |
+| `cannot convert X to Y` | Add appropriate cast |
+| `CMake Error` | Fix CMakeLists.txt configuration |
+
+## Fix Strategy
+
+1. **Compilation errors first** - Code must compile
+2. **Linker errors second** - Resolve undefined references
+3. **Warnings third** - Fix with `-Wall -Wextra`
+4. **One fix at a time** - Verify each change
+5. **Minimal changes** - Don't refactor, just fix
+
+## Stop Conditions
+
+The agent will stop and report if:
+- Same error persists after 3 attempts
+- Fix introduces more errors
+- Requires architectural changes
+- Missing external dependencies
+
+## Related Commands
+
+- `/cpp-test` - Run tests after build succeeds
+- `/cpp-review` - Review code quality
+- `/verify` - Full verification loop
+
+## Related
+
+- Agent: `agents/cpp-build-resolver.md`
+- Skill: `skills/cpp-coding-standards/`

package/.agent/workflows/cpp-review.md

@@ -1,132 +1,132 @@
----
-description: Comprehensive C++ code review for memory safety, modern C++ idioms, concurrency, and security. Invokes the cpp-reviewer agent.
----
-
-# C++ Code Review
-
-This command invokes the **cpp-reviewer** agent for comprehensive C++-specific code review.
-
-## What This Command Does
-
-1. **Identify C++ Changes**: Find modified `.cpp`, `.hpp`, `.cc`, `.h` files via `git diff`
-2. **Run Static Analysis**: Execute `clang-tidy` and `cppcheck`
-3. **Memory Safety Scan**: Check for raw new/delete, buffer overflows, use-after-free
-4. **Concurrency Review**: Analyze thread safety, mutex usage, data races
-5. **Modern C++ Check**: Verify code follows C++17/20 conventions and best practices
-6. **Generate Report**: Categorize issues by severity
-
-## When to Use
-
-Use `/cpp-review` when:
-- After writing or modifying C++ code
-- Before committing C++ changes
-- Reviewing pull requests with C++ code
-- Onboarding to a new C++ codebase
-- Checking for memory safety issues
-
-## Review Categories
-
-### CRITICAL (Must Fix)
-- Raw `new`/`delete` without RAII
-- Buffer overflows and use-after-free
-- Data races without synchronization
-- Command injection via `system()`
-- Uninitialized variable reads
-- Null pointer dereferences
-
-### HIGH (Should Fix)
-- Rule of Five violations
-- Missing `std::lock_guard` / `std::scoped_lock`
-- Detached threads without proper lifetime management
-- C-style casts instead of `static_cast`/`dynamic_cast`
-- Missing `const` correctness
-
-### MEDIUM (Consider)
-- Unnecessary copies (pass by value instead of `const&`)
-- Missing `reserve()` on known-size containers
-- `using namespace std;` in headers
-- Missing `[[nodiscard]]` on important return values
-- Overly complex template metaprogramming
-
-## Automated Checks Run
-
-```bash
-# Static analysis
-clang-tidy --checks='*,-llvmlibc-*' src/*.cpp -- -std=c++17
-
-# Additional analysis
-cppcheck --enable=all --suppress=missingIncludeSystem src/
-
-# Build with warnings
-cmake --build build -- -Wall -Wextra -Wpedantic
-```
-
-## Example Usage
-
-```text
-User: /cpp-review
-
-Agent:
-# C++ Code Review Report
-
-## Files Reviewed
-- src/handler/user.cpp (modified)
-- src/service/auth.cpp (modified)
-
-## Static Analysis Results
-✓ clang-tidy: 2 warnings
-✓ cppcheck: No issues
-
-## Issues Found
-
-[CRITICAL] Memory Leak
-File: src/service/auth.cpp:45
-Issue: Raw `new` without matching `delete`
-```cpp
-auto* session = new Session(userId);  // Memory leak!
-cache[userId] = session;
-```
-Fix: Use `std::unique_ptr`
-```cpp
-auto session = std::make_unique<Session>(userId);
-cache[userId] = std::move(session);
-```
-
-[HIGH] Missing const Reference
-File: src/handler/user.cpp:28
-Issue: Large object passed by value
-```cpp
-void processUser(User user) {  // Unnecessary copy
-```
-Fix: Pass by const reference
-```cpp
-void processUser(const User& user) {
-```
-
-## Summary
-- CRITICAL: 1
-- HIGH: 1
-- MEDIUM: 0
-
-Recommendation: ❌ Block merge until CRITICAL issue is fixed
-```
-
-## Approval Criteria
-
-| Status | Condition |
-|--------|-----------|
-| ✅ Approve | No CRITICAL or HIGH issues |
-| ⚠️ Warning | Only MEDIUM issues (merge with caution) |
-| ❌ Block | CRITICAL or HIGH issues found |
-
-## Integration with Other Commands
-
-- Use `/cpp-test` first to ensure tests pass
-- Use `/cpp-build` if build errors occur
-- Use `/cpp-review` before committing
-- Use `/code-review` for non-C++ specific concerns
-
-## Related
-
-- Agent: `agents/cpp-reviewer.md`
-- Skills: `skills/cpp-coding-standards/`, `skills/cpp-testing/`
+---
+description: Comprehensive C++ code review for memory safety, modern C++ idioms, concurrency, and security. Invokes the cpp-reviewer agent.
+---
+
+# C++ Code Review
+
+This command invokes the **cpp-reviewer** agent for comprehensive C++-specific code review.
+
+## What This Command Does
+
+1. **Identify C++ Changes**: Find modified `.cpp`, `.hpp`, `.cc`, `.h` files via `git diff`
+2. **Run Static Analysis**: Execute `clang-tidy` and `cppcheck`
+3. **Memory Safety Scan**: Check for raw new/delete, buffer overflows, use-after-free
+4. **Concurrency Review**: Analyze thread safety, mutex usage, data races
+5. **Modern C++ Check**: Verify code follows C++17/20 conventions and best practices
+6. **Generate Report**: Categorize issues by severity
+
+## When to Use
+
+Use `/cpp-review` when:
+- After writing or modifying C++ code
+- Before committing C++ changes
+- Reviewing pull requests with C++ code
+- Onboarding to a new C++ codebase
+- Checking for memory safety issues
+
+## Review Categories
+
+### CRITICAL (Must Fix)
+- Raw `new`/`delete` without RAII
+- Buffer overflows and use-after-free
+- Data races without synchronization
+- Command injection via `system()`
+- Uninitialized variable reads
+- Null pointer dereferences
+
+### HIGH (Should Fix)
+- Rule of Five violations
+- Missing `std::lock_guard` / `std::scoped_lock`
+- Detached threads without proper lifetime management
+- C-style casts instead of `static_cast`/`dynamic_cast`
+- Missing `const` correctness
+
+### MEDIUM (Consider)
+- Unnecessary copies (pass by value instead of `const&`)
+- Missing `reserve()` on known-size containers
+- `using namespace std;` in headers
+- Missing `[[nodiscard]]` on important return values
+- Overly complex template metaprogramming
+
+## Automated Checks Run
+
+```bash
+# Static analysis
+clang-tidy --checks='*,-llvmlibc-*' src/*.cpp -- -std=c++17
+
+# Additional analysis
+cppcheck --enable=all --suppress=missingIncludeSystem src/
+
+# Build with warnings
+cmake --build build -- -Wall -Wextra -Wpedantic
+```
+
+## Example Usage
+
+```text
+User: /cpp-review
+
+Agent:
+# C++ Code Review Report
+
+## Files Reviewed
+- src/handler/user.cpp (modified)
+- src/service/auth.cpp (modified)
+
+## Static Analysis Results
+✓ clang-tidy: 2 warnings
+✓ cppcheck: No issues
+
+## Issues Found
+
+[CRITICAL] Memory Leak
+File: src/service/auth.cpp:45
+Issue: Raw `new` without matching `delete`
+```cpp
+auto* session = new Session(userId);  // Memory leak!
+cache[userId] = session;
+```
+Fix: Use `std::unique_ptr`
+```cpp
+auto session = std::make_unique<Session>(userId);
+cache[userId] = std::move(session);
+```
+
+[HIGH] Missing const Reference
+File: src/handler/user.cpp:28
+Issue: Large object passed by value
+```cpp
+void processUser(User user) {  // Unnecessary copy
+```
+Fix: Pass by const reference
+```cpp
+void processUser(const User& user) {
+```
+
+## Summary
+- CRITICAL: 1
+- HIGH: 1
+- MEDIUM: 0
+
+Recommendation: FAIL: Block merge until CRITICAL issue is fixed
+```
+
+## Approval Criteria
+
+| Status | Condition |
+|--------|-----------|
+| PASS: Approve | No CRITICAL or HIGH issues |
+| WARNING: Warning | Only MEDIUM issues (merge with caution) |
+| FAIL: Block | CRITICAL or HIGH issues found |
+
+## Integration with Other Commands
+
+- Use `/cpp-test` first to ensure tests pass
+- Use `/cpp-build` if build errors occur
+- Use `/cpp-review` before committing
+- Use `/code-review` for non-C++ specific concerns
+
+## Related
+
+- Agent: `agents/cpp-reviewer.md`
+- Skills: `skills/cpp-coding-standards/`, `skills/cpp-testing/`