@empline/preflight 1.0.20

package/dist/checks/code-quality/magic-number-detection.js

@@ -0,0 +1,405 @@
+#!/usr/bin/env tsx
+"use strict";
+/**
+ * Magic Number Detection Preflight (NON-BLOCKING)
+ *
+ * Detects hardcoded "magic numbers" that should be named constants.
+ * Magic numbers reduce code readability and make maintenance difficult.
+ *
+ * Patterns detected:
+ * - Hardcoded timeouts (setTimeout/setInterval with raw numbers)
+ * - Hardcoded limits (pagination, array slices)
+ * - Hardcoded dimensions (width, height, size)
+ * - Hardcoded business values (prices, percentages, thresholds)
+ *
+ * Allowed patterns:
+ * - 0, 1, -1 (common programming idioms)
+ * - Numbers in comments
+ * - Numbers in test files
+ * - Numbers assigned to named constants
+ *
+ * Usage:
+ *   pnpm preflight:magic-numbers
+ *   pnpm preflight:magic-numbers --verbose
+ */
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.tags = exports.description = exports.blocking = exports.category = exports.name = exports.id = void 0;
+const fs = __importStar(require("fs"));
+const path = __importStar(require("path"));
+const console_chars_1 = require("../../utils/console-chars");
+const file_cache_1 = require("../../shared/file-cache");
+const glob_patterns_1 = require("../../shared/glob-patterns");
+const universal_progress_reporter_1 = require("../system/universal-progress-reporter");
+// Check metadata
+exports.id = "code-quality/magic-number-detection";
+exports.name = "Magic Number Detection";
+exports.category = "code-quality";
+exports.blocking = false;
+exports.description = "Magic Number Detection Preflight (NON-BLOCKING)";
+exports.tags = ["code-quality"];
+const issues = [];
+// Common acceptable numbers (programming idioms)
+const ALLOWED_NUMBERS = new Set([
+    "0",
+    "1",
+    "-1",
+    "2",
+    "10",
+    "100",
+    "1000",
+    "0.5",
+    "0.25",
+    "0.75",
+    "24",
+    "60",
+    "365", // Time-related
+    "16",
+    "32",
+    "64",
+    "128",
+    "256",
+    "512",
+    "1024", // Powers of 2
+    // Common UI dimensions / breakpoints (Tailwind/MUI-adjacent idioms)
+    "110",
+    "112",
+    "120",
+    "130",
+    "140",
+    "150",
+    "160",
+    "180",
+    "200",
+    "220",
+    "240",
+    "250",
+    "264",
+    "280",
+    "300",
+    "320",
+    "350",
+    "360",
+    "400",
+    "420",
+    "450",
+    "480",
+    "500",
+    "560",
+    "600",
+    "630",
+    "640",
+    "641",
+    "720",
+    "767",
+    "768",
+    "800",
+    "840",
+    "900",
+    "1023",
+    "1199",
+    "1200",
+    "1535",
+    "1536",
+    "1680",
+    "1920",
+    "2048",
+]);
+// Patterns that indicate magic numbers
+const MAGIC_NUMBER_PATTERNS = [
+    {
+        // Timeout with raw number > 1000
+        regex: /setTimeout\s*\([^,]+,\s*(\d{4,})\s*\)/g,
+        category: "timeout",
+        message: "Hardcoded timeout - use named constant (e.g., DEBOUNCE_MS, API_TIMEOUT_MS)",
+        severity: "warning",
+        minValue: 1000,
+    },
+    {
+        // setInterval with raw number
+        regex: /setInterval\s*\([^,]+,\s*(\d{4,})\s*\)/g,
+        category: "interval",
+        message: "Hardcoded interval - use named constant (e.g., POLL_INTERVAL_MS)",
+        severity: "warning",
+        minValue: 1000,
+    },
+    {
+        // Pagination limits
+        regex: /(?:limit|pageSize|take)\s*[=:]\s*(\d{2,})/gi,
+        category: "pagination",
+        message: "Hardcoded pagination limit - use constant (e.g., DEFAULT_PAGE_SIZE)",
+        severity: "info",
+        minValue: 10,
+    },
+    {
+        // Array slice with magic number
+        regex: /\.slice\s*\(\s*\d*\s*,\s*(\d{2,})\s*\)/g,
+        category: "slice",
+        message: "Hardcoded slice limit - consider using named constant",
+        severity: "info",
+        minValue: 10,
+    },
+    {
+        // Width/height with pixel values
+        regex: /(?:width|height|size)\s*[=:]\s*[{]?\s*(\d{3,})\s*[}]?/gi,
+        category: "dimension",
+        message: "Hardcoded dimension - use design token or constant",
+        severity: "info",
+        minValue: 100,
+    },
+    {
+        // Percentage thresholds
+        regex: /(?:threshold|percent|ratio)\s*[=:><!]\s*(\d+(?:\.\d+)?)/gi,
+        category: "threshold",
+        message: "Hardcoded threshold - use named constant for clarity",
+        severity: "info",
+        minValue: 0,
+    },
+    {
+        // Price/money values (suspicious if > 100)
+        regex: /(?:price|cost|amount|fee)\s*[=:><!]\s*(\d{3,}(?:\.\d+)?)/gi,
+        category: "money",
+        message: "Hardcoded monetary value - should come from config or database",
+        severity: "warning",
+        minValue: 100,
+    },
+    {
+        // Retry counts
+        regex: /(?:retries|attempts|maxRetries)\s*[=:]\s*(\d+)/gi,
+        category: "retry",
+        message: "Hardcoded retry count - use constant (e.g., MAX_RETRIES)",
+        severity: "info",
+        minValue: 2,
+    },
+    {
+        // Cache TTL
+        regex: /(?:ttl|maxAge|cacheTime)\s*[=:]\s*(\d{4,})/gi,
+        category: "cache",
+        message: "Hardcoded cache TTL - use constant (e.g., CACHE_TTL_MS)",
+        severity: "warning",
+        minValue: 1000,
+    },
+];
+// Skip patterns
+const SKIP_PATTERNS = (0, glob_patterns_1.extendExcludes)(glob_patterns_1.STANDARD_EXCLUDES, [
+    "node_modules",
+    ".next",
+    "dist",
+    ".git",
+    "*.test.ts",
+    "*.test.tsx",
+    "*.spec.ts",
+    "*.spec.tsx",
+    "__mocks__",
+    "tests/",
+    "stories/",
+    "*.stories.tsx",
+    "/constants",
+    "/config",
+]);
+function shouldSkip(filePath) {
+    const normalized = filePath.replace(/\\/g, "/");
+    return SKIP_PATTERNS.some((pattern) => {
+        if (pattern.startsWith("*")) {
+            return normalized.endsWith(pattern.slice(1));
+        }
+        return normalized.includes(pattern);
+    });
+}
+function isInComment(content, index) {
+    const beforeMatch = content.slice(0, index);
+    const lastNewline = beforeMatch.lastIndexOf("\n");
+    const lineStart = lastNewline === -1 ? 0 : lastNewline + 1;
+    const lineContent = content.slice(lineStart, index);
+    // Check for single-line comment
+    if (lineContent.includes("//"))
+        return true;
+    // Check for multi-line comment (simplified)
+    const lastCommentStart = beforeMatch.lastIndexOf("/*");
+    const lastCommentEnd = beforeMatch.lastIndexOf("*/");
+    if (lastCommentStart > lastCommentEnd)
+        return true;
+    return false;
+}
+function isConstantAssignment(content, index) {
+    const beforeMatch = content.slice(Math.max(0, index - 100), index);
+    // Check if this is a const declaration with UPPER_CASE name
+    return /const\s+[A-Z][A-Z0-9_]+\s*=\s*$/.test(beforeMatch);
+}
+async function scanFile(filePath) {
+    if (shouldSkip(filePath))
+        return;
+    const content = fs.readFileSync(filePath, "utf-8");
+    const lines = content.split("\n");
+    for (const pattern of MAGIC_NUMBER_PATTERNS) {
+        let match;
+        const regex = new RegExp(pattern.regex.source, pattern.regex.flags);
+        while ((match = regex.exec(content)) !== null) {
+            const numberStr = match[1];
+            const numberVal = parseFloat(numberStr);
+            const numberIndex = match.index + match[0].indexOf(numberStr);
+            // Skip allowed numbers
+            if (ALLOWED_NUMBERS.has(numberStr))
+                continue;
+            // Skip if below minimum threshold
+            if (pattern.minValue !== undefined && numberVal < pattern.minValue)
+                continue;
+            // Skip if in comment
+            if (isInComment(content, numberIndex))
+                continue;
+            // Skip if it's a constant assignment
+            if (isConstantAssignment(content, numberIndex))
+                continue;
+            const beforeMatch = content.slice(0, match.index);
+            const lineNumber = beforeMatch.split("\n").length;
+            const line = lines[lineNumber - 1] || "";
+            issues.push({
+                file: filePath,
+                line: lineNumber,
+                number: numberStr,
+                context: line.trim().slice(0, 60),
+                category: pattern.category,
+                severity: pattern.severity,
+                message: pattern.message,
+            });
+        }
+    }
+}
+async function main() {
+    const reporter = (0, universal_progress_reporter_1.createUniversalProgressReporter)(path.basename(__filename, ".ts"));
+    const verbose = process.argv.includes("--verbose") || process.argv.includes("-v");
+    const strict = process.argv.includes("--strict");
+    const jsonIdx = process.argv.indexOf("--json");
+    const jsonPath = jsonIdx !== -1 ? process.argv[jsonIdx + 1] : process.env.MAGIC_NUMBERS_JSON;
+    console.log(`\n${console_chars_1.emoji.search} Magic Number Detection`);
+    console.log((0, console_chars_1.createDivider)(60, "heavy"));
+    const files = await file_cache_1.fileCache.getAppCodeFiles();
+    for (const file of files) {
+        await scanFile(file);
+    }
+    // Deduplicate
+    const seen = new Set();
+    const uniqueIssues = issues.filter((i) => {
+        const key = `${i.file}:${i.line}:${i.number}`;
+        if (seen.has(key))
+            return false;
+        seen.add(key);
+        return true;
+    });
+    const errors = uniqueIssues.filter((i) => i.severity === "error");
+    const warnings = uniqueIssues.filter((i) => i.severity === "warning");
+    const infos = uniqueIssues.filter((i) => i.severity === "info");
+    // Group by category for summary
+    const byCategory = new Map();
+    for (const issue of uniqueIssues) {
+        byCategory.set(issue.category, (byCategory.get(issue.category) || 0) + 1);
+    }
+    if (verbose || warnings.length > 0 || errors.length > 0) {
+        if (errors.length > 0) {
+            console.log(`\n${console_chars_1.emoji.error} ERRORS:`);
+            errors.slice(0, 10).forEach((issue) => {
+                console.log(`   ${issue.file}:${issue.line}`);
+                console.log(`      Number: ${issue.number} (${issue.category})`);
+                console.log(`      ${issue.message}`);
+            });
+        }
+        if (warnings.length > 0) {
+            console.log(`\n${console_chars_1.emoji.warning}  WARNINGS:`);
+            warnings.slice(0, 15).forEach((issue) => {
+                console.log(`   ${issue.file}:${issue.line}`);
+                console.log(`      Number: ${issue.number} (${issue.category})`);
+                console.log(`      ${issue.message}`);
+            });
+            if (warnings.length > 15) {
+                console.log(`   ... and ${warnings.length - 15} more warnings`);
+            }
+        }
+        if (verbose && infos.length > 0) {
+            console.log(`\n${console_chars_1.emoji.info} INFO:`);
+            infos.slice(0, 10).forEach((issue) => {
+                console.log(`   ${issue.file}:${issue.line} - ${issue.number} (${issue.category})`);
+            });
+            if (infos.length > 10) {
+                console.log(`   ... and ${infos.length - 10} more`);
+            }
+        }
+    }
+    console.log("\n" + (0, console_chars_1.createDivider)(60, "heavy"));
+    console.log(`Files scanned: ${files.length}`);
+    console.log(`Magic numbers found: ${uniqueIssues.length}`);
+    if (jsonPath) {
+        try {
+            fs.writeFileSync(jsonPath, JSON.stringify({
+                generatedAt: new Date().toISOString(),
+                filesScanned: files.length,
+                total: uniqueIssues.length,
+                byCategory: Object.fromEntries(byCategory.entries()),
+                issues: uniqueIssues,
+            }, null, 2), "utf-8");
+            console.log(`${console_chars_1.emoji.info} Wrote JSON report: ${jsonPath}`);
+        }
+        catch (error) {
+            console.log(`${console_chars_1.emoji.warning} Failed to write JSON report: ${jsonPath}`);
+            console.log(String(error));
+        }
+    }
+    if (byCategory.size > 0) {
+        console.log("\nBy category:");
+        for (const [cat, count] of Array.from(byCategory.entries())) {
+            console.log(`   ${cat}: ${count}`);
+        }
+    }
+    // Non-blocking by default, blocking in strict mode
+    if (strict && (errors.length > 0 || warnings.length > 0)) {
+        console.log(`\n${console_chars_1.emoji.error} Magic Number Detection FAILED (strict mode)`);
+        console.log("\n" + console_chars_1.emoji.hint + " Fix by extracting to constants:");
+        console.log("  // Before");
+        console.log("  setTimeout(callback, 5000);");
+        console.log("");
+        console.log("  // After");
+        console.log("  const DEBOUNCE_MS = 5000;");
+        console.log("  setTimeout(callback, DEBOUNCE_MS);");
+        process.exit(1);
+    }
+    if (warnings.length > 0 || infos.length > 0) {
+        console.log(`\n${console_chars_1.emoji.warning}  Magic Number Detection completed with suggestions`);
+        console.log("   Consider extracting frequently-used numbers to named constants");
+    }
+    else {
+        console.log(`\n${console_chars_1.emoji.success} Magic Number Detection PASSED`);
+    }
+}
+main().catch(console.error);
+//# sourceMappingURL=magic-number-detection.js.map

package/dist/checks/code-quality/magic-number-detection.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"magic-number-detection.js","sourceRoot":"","sources":["../../../src/checks/code-quality/magic-number-detection.ts"],"names":[],"mappings":";;AACA;;;;;;;;;;;;;;;;;;;;;GAqBG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAEH,uCAAyB;AACzB,2CAA6B;AAC7B,6DAAiE;AACjE,wDAAoD;AACpD,8DAA+E;AAC/E,uFAAwF;AAGxF,iBAAiB;AACJ,QAAA,EAAE,GAAG,qCAAqC,CAAC;AAC3C,QAAA,IAAI,GAAG,wBAAwB,CAAC;AAChC,QAAA,QAAQ,GAAG,cAAc,CAAC;AAC1B,QAAA,QAAQ,GAAG,KAAK,CAAC;AACjB,QAAA,WAAW,GAAG,iDAAiD,CAAC;AAChE,QAAA,IAAI,GAAG,CAAC,cAAc,CAAC,CAAC;AAYrC,MAAM,MAAM,GAAY,EAAE,CAAC;AAE3B,iDAAiD;AACjD,MAAM,eAAe,GAAG,IAAI,GAAG,CAAC;IAC9B,GAAG;IACH,GAAG;IACH,IAAI;IACJ,GAAG;IACH,IAAI;IACJ,KAAK;IACL,MAAM;IACN,KAAK;IACL,MAAM;IACN,MAAM;IACN,IAAI;IACJ,IAAI;IACJ,KAAK,EAAE,eAAe;IACtB,IAAI;IACJ,IAAI;IACJ,IAAI;IACJ,KAAK;IACL,KAAK;IACL,KAAK;IACL,MAAM,EAAE,cAAc;IAEtB,oEAAoE;IACpE,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,KAAK;IACL,MAAM;IACN,MAAM;IACN,MAAM;IACN,MAAM;IACN,MAAM;IACN,MAAM;IACN,MAAM;IACN,MAAM;CACP,CAAC,CAAC;AAEH,uCAAuC;AACvC,MAAM,qBAAqB,GAAG;IAC5B;QACE,iCAAiC;QACjC,KAAK,EAAE,wCAAwC;QAC/C,QAAQ,EAAE,SAAS;QACnB,OAAO,EAAE,4EAA4E;QACrF,QAAQ,EAAE,SAAkB;QAC5B,QAAQ,EAAE,IAAI;KACf;IACD;QACE,8BAA8B;QAC9B,KAAK,EAAE,yCAAyC;QAChD,QAAQ,EAAE,UAAU;QACpB,OAAO,EAAE,kEAAkE;QAC3E,QAAQ,EAAE,SAAkB;QAC5B,QAAQ,EAAE,IAAI;KACf;IACD;QACE,oBAAoB;QACpB,KAAK,EAAE,6CAA6C;QACpD,QAAQ,EAAE,YAAY;QACtB,OAAO,EAAE,qEAAqE;QAC9E,QAAQ,EAAE,MAAe;QACzB,QAAQ,EAAE,EAAE;KACb;IACD;QACE,gCAAgC;QAChC,KAAK,EAAE,yCAAyC;QAChD,QAAQ,EAAE,OAAO;QACjB,OAAO,EAAE,uDAAuD;QAChE,QAAQ,EAAE,MAAe;QACzB,QAAQ,EAAE,EAAE;KACb;IACD;QACE,iCAAiC;QACjC,KAAK,EAAE,yDAAyD;QAChE,QAAQ,EAAE,WAAW;QACrB,OAAO,EAAE,oDAAoD;QAC7D,QAAQ,EAAE,MAAe;QACzB,QAAQ,EAAE,GAAG;KACd;IACD;QACE,wBAAwB;QACxB,KAAK,EAAE,2DAA2D;QAClE,QAAQ,EAAE,WAAW;QACrB,OAAO,EAAE,sDAAsD;QAC/D,QAAQ,EAAE,MAAe;QACzB,QAAQ,EAAE,CAAC;KACZ;IACD;QACE,2CAA2C;QAC3C,KAAK,EAAE,4DAA4D;QACnE,QAAQ,EAAE,OAAO;QACjB,OAAO,EAAE,gEAAgE;QACzE,QAAQ,EAAE,SAAkB;QAC5B,QAAQ,EAAE,GAAG;KACd;IACD;QACE,eAAe;QACf,KAAK,EAAE,kDAAkD;QACzD,QAAQ,EAAE,OAAO;QACjB,OAAO,EAAE,0DAA0D;QACnE,QAAQ,EAAE,MAAe;QACzB,QAAQ,EAAE,CAAC;KACZ;IACD;QACE,YAAY;QACZ,KAAK,EAAE,8CAA8C;QACrD,QAAQ,EAAE,OAAO;QACjB,OAAO,EAAE,yDAAyD;QAClE,QAAQ,EAAE,SAAkB;QAC5B,QAAQ,EAAE,IAAI;KACf;CACF,CAAC;AAEF,gBAAgB;AAChB,MAAM,aAAa,GAAG,IAAA,8BAAc,EAAC,iCAAiB,EAAE;IACtD,cAAc;IACd,OAAO;IACP,MAAM;IACN,MAAM;IACN,WAAW;IACX,YAAY;IACZ,WAAW;IACX,YAAY;IACZ,WAAW;IACX,QAAQ;IACR,UAAU;IACV,eAAe;IACf,YAAY;IACZ,SAAS;CACV,CAAC,CAAC;AAEH,SAAS,UAAU,CAAC,QAAgB;IAClC,MAAM,UAAU,GAAG,QAAQ,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC;IAChD,OAAO,aAAa,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE;QACpC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;YAC5B,OAAO,UAAU,CAAC,QAAQ,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;QAC/C,CAAC;QACD,OAAO,UAAU,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC;IACtC,CAAC,CAAC,CAAC;AACL,CAAC;AAED,SAAS,WAAW,CAAC,OAAe,EAAE,KAAa;IACjD,MAAM,WAAW,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC;IAC5C,MAAM,WAAW,GAAG,WAAW,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;IAClD,MAAM,SAAS,GAAG,WAAW,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,WAAW,GAAG,CAAC,CAAC;IAC3D,MAAM,WAAW,GAAG,OAAO,CAAC,KAAK,CAAC,SAAS,EAAE,KAAK,CAAC,CAAC;IAEpD,gCAAgC;IAChC,IAAI,WAAW,CAAC,QAAQ,CAAC,IAAI,CAAC;QAAE,OAAO,IAAI,CAAC;IAE5C,4CAA4C;IAC5C,MAAM,gBAAgB,GAAG,WAAW,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;IACvD,MAAM,cAAc,GAAG,WAAW,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;IACrD,IAAI,gBAAgB,GAAG,cAAc;QAAE,OAAO,IAAI,CAAC;IAEnD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,oBAAoB,CAAC,OAAe,EAAE,KAAa;IAC1D,MAAM,WAAW,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,KAAK,GAAG,GAAG,CAAC,EAAE,KAAK,CAAC,CAAC;IACnE,4DAA4D;IAC5D,OAAO,iCAAiC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;AAC7D,CAAC;AAED,KAAK,UAAU,QAAQ,CAAC,QAAgB;IACtC,IAAI,UAAU,CAAC,QAAQ,CAAC;QAAE,OAAO;IAEjC,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;IACnD,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAElC,KAAK,MAAM,OAAO,IAAI,qBAAqB,EAAE,CAAC;QAC5C,IAAI,KAAK,CAAC;QACV,MAAM,KAAK,GAAG,IAAI,MAAM,CAAC,OAAO,CAAC,KAAK,CAAC,MAAM,EAAE,OAAO,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QAEpE,OAAO,CAAC,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;YAC9C,MAAM,SAAS,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YAC3B,MAAM,SAAS,GAAG,UAAU,CAAC,SAAS,CAAC,CAAC;YACxC,MAAM,WAAW,GAAG,KAAK,CAAC,KAAK,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC;YAE9D,uBAAuB;YACvB,IAAI,eAAe,CAAC,GAAG,CAAC,SAAS,CAAC;gBAAE,SAAS;YAE7C,kCAAkC;YAClC,IAAI,OAAO,CAAC,QAAQ,KAAK,SAAS,IAAI,SAAS,GAAG,OAAO,CAAC,QAAQ;gBAAE,SAAS;YAE7E,qBAAqB;YACrB,IAAI,WAAW,CAAC,OAAO,EAAE,WAAW,CAAC;gBAAE,SAAS;YAEhD,qCAAqC;YACrC,IAAI,oBAAoB,CAAC,OAAO,EAAE,WAAW,CAAC;gBAAE,SAAS;YAEzD,MAAM,WAAW,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC;YAClD,MAAM,UAAU,GAAG,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC;YAClD,MAAM,IAAI,GAAG,KAAK,CAAC,UAAU,GAAG,CAAC,CAAC,IAAI,EAAE,CAAC;YAEzC,MAAM,CAAC,IAAI,CAAC;gBACV,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE,UAAU;gBAChB,MAAM,EAAE,SAAS;gBACjB,OAAO,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC;gBACjC,QAAQ,EAAE,OAAO,CAAC,QAAQ;gBAC1B,QAAQ,EAAE,OAAO,CAAC,QAAQ;gBAC1B,OAAO,EAAE,OAAO,CAAC,OAAO;aACzB,CAAC,CAAC;QACL,CAAC;IACH,CAAC;AACH,CAAC;AAED,KAAK,UAAU,IAAI;IACjB,MAAM,QAAQ,GAAG,IAAA,6DAA+B,EAAC,IAAI,CAAC,QAAQ,CAAC,UAAU,EAAE,KAAK,CAAC,CAAC,CAAC;IACnF,MAAM,OAAO,GAAG,OAAO,CAAC,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,IAAI,OAAO,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAClF,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC;IACjD,MAAM,OAAO,GAAG,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;IAC/C,MAAM,QAAQ,GAAG,OAAO,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,OAAO,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,kBAAkB,CAAC;IAE7F,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,MAAM,yBAAyB,CAAC,CAAC;IACxD,OAAO,CAAC,GAAG,CAAC,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAExC,MAAM,KAAK,GAAG,MAAM,sBAAS,CAAC,eAAe,EAAE,CAAC;IAEhD,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,MAAM,QAAQ,CAAC,IAAI,CAAC,CAAC;IACvB,CAAC;IAED,cAAc;IACd,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;IAC/B,MAAM,YAAY,GAAG,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE;QACvC,MAAM,GAAG,GAAG,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,MAAM,EAAE,CAAC;QAC9C,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAO,KAAK,CAAC;QAChC,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;QACd,OAAO,IAAI,CAAC;IACd,CAAC,CAAC,CAAC;IAEH,MAAM,MAAM,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC;IAClE,MAAM,QAAQ,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC;IACtE,MAAM,KAAK,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,MAAM,CAAC,CAAC;IAEhE,gCAAgC;IAChC,MAAM,UAAU,GAAG,IAAI,GAAG,EAAkB,CAAC;IAC7C,KAAK,MAAM,KAAK,IAAI,YAAY,EAAE,CAAC;QACjC,UAAU,CAAC,GAAG,CAAC,KAAK,CAAC,QAAQ,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC,KAAK,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC;IAC5E,CAAC;IAED,IAAI,OAAO,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACxD,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACtB,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,KAAK,UAAU,CAAC,CAAC;YACxC,MAAM,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;gBACpC,OAAO,CAAC,GAAG,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC;gBAC9C,OAAO,CAAC,GAAG,CAAC,iBAAiB,KAAK,CAAC,MAAM,KAAK,KAAK,CAAC,QAAQ,GAAG,CAAC,CAAC;gBACjE,OAAO,CAAC,GAAG,CAAC,SAAS,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;YACxC,CAAC,CAAC,CAAC;QACL,CAAC;QAED,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACxB,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,OAAO,aAAa,CAAC,CAAC;YAC7C,QAAQ,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;gBACtC,OAAO,CAAC,GAAG,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC;gBAC9C,OAAO,CAAC,GAAG,CAAC,iBAAiB,KAAK,CAAC,MAAM,KAAK,KAAK,CAAC,QAAQ,GAAG,CAAC,CAAC;gBACjE,OAAO,CAAC,GAAG,CAAC,SAAS,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;YACxC,CAAC,CAAC,CAAC;YACH,IAAI,QAAQ,CAAC,MAAM,GAAG,EAAE,EAAE,CAAC;gBACzB,OAAO,CAAC,GAAG,CAAC,cAAc,QAAQ,CAAC,MAAM,GAAG,EAAE,gBAAgB,CAAC,CAAC;YAClE,CAAC;QACH,CAAC;QAED,IAAI,OAAO,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAChC,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,IAAI,QAAQ,CAAC,CAAC;YACrC,KAAK,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;gBACnC,OAAO,CAAC,GAAG,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,KAAK,CAAC,IAAI,MAAM,KAAK,CAAC,MAAM,KAAK,KAAK,CAAC,QAAQ,GAAG,CAAC,CAAC;YACtF,CAAC,CAAC,CAAC;YACH,IAAI,KAAK,CAAC,MAAM,GAAG,EAAE,EAAE,CAAC;gBACtB,OAAO,CAAC,GAAG,CAAC,cAAc,KAAK,CAAC,MAAM,GAAG,EAAE,OAAO,CAAC,CAAC;YACtD,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,kBAAkB,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC;IAC9C,OAAO,CAAC,GAAG,CAAC,wBAAwB,YAAY,CAAC,MAAM,EAAE,CAAC,CAAC;IAE3D,IAAI,QAAQ,EAAE,CAAC;QACb,IAAI,CAAC;YACH,EAAE,CAAC,aAAa,CACd,QAAQ,EACR,IAAI,CAAC,SAAS,CACZ;gBACE,WAAW,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;gBACrC,YAAY,EAAE,KAAK,CAAC,MAAM;gBAC1B,KAAK,EAAE,YAAY,CAAC,MAAM;gBAC1B,UAAU,EAAE,MAAM,CAAC,WAAW,CAAC,UAAU,CAAC,OAAO,EAAE,CAAC;gBACpD,MAAM,EAAE,YAAY;aACrB,EACD,IAAI,EACJ,CAAC,CACF,EACD,OAAO,CACR,CAAC;YACF,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,IAAI,uBAAuB,QAAQ,EAAE,CAAC,CAAC;QAC9D,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,OAAO,iCAAiC,QAAQ,EAAE,CAAC,CAAC;YACzE,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC;QAC7B,CAAC;IACH,CAAC;IAED,IAAI,UAAU,CAAC,IAAI,GAAG,CAAC,EAAE,CAAC;QACxB,OAAO,CAAC,GAAG,CAAC,gBAAgB,CAAC,CAAC;QAC9B,KAAK,MAAM,CAAC,GAAG,EAAE,KAAK,CAAC,IAAI,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC;YAC5D,OAAO,CAAC,GAAG,CAAC,MAAM,GAAG,KAAK,KAAK,EAAE,CAAC,CAAC;QACrC,CAAC;IACH,CAAC;IAED,mDAAmD;IACnD,IAAI,MAAM,IAAI,CAAC,MAAM,CAAC,MAAM,GAAG,CAAC,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,EAAE,CAAC;QACzD,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,KAAK,8CAA8C,CAAC,CAAC;QAC5E,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,qBAAK,CAAC,IAAI,GAAG,kCAAkC,CAAC,CAAC;QACpE,OAAO,CAAC,GAAG,CAAC,aAAa,CAAC,CAAC;QAC3B,OAAO,CAAC,GAAG,CAAC,+BAA+B,CAAC,CAAC;QAC7C,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QAChB,OAAO,CAAC,GAAG,CAAC,YAAY,CAAC,CAAC;QAC1B,OAAO,CAAC,GAAG,CAAC,6BAA6B,CAAC,CAAC;QAC3C,OAAO,CAAC,GAAG,CAAC,sCAAsC,CAAC,CAAC;QACpD,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC5C,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,OAAO,qDAAqD,CAAC,CAAC;QACrF,OAAO,CAAC,GAAG,CAAC,mEAAmE,CAAC,CAAC;IACnF,CAAC;SAAM,CAAC;QACN,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,OAAO,gCAAgC,CAAC,CAAC;IAClE,CAAC;AACH,CAAC;AAED,IAAI,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC"}

package/dist/checks/code-quality/mock-function-detection.d.ts

@@ -0,0 +1,32 @@
+#!/usr/bin/env tsx
+/**
+ * Mock Function Detection Preflight
+ *
+ * Detects mock/simulated functions in production code that don't do real work.
+ * These are placeholder implementations that should be replaced with actual logic.
+ *
+ * Patterns detected:
+ * - Functions with "mock", "simulate", "fake", "stub", "dummy" in comments
+ * - Functions that only await setTimeout/Promise delays
+ * - Functions with TODO/FIXME comments about implementing real logic
+ * - Empty update objects that don't actually update anything
+ *
+ * Usage:
+ *   pnpm tsx scripts/active/preflights/code-quality/mock-function-detection.ts
+ */
+export declare const id = "code-quality/mock-function-detection";
+export declare const name = "Mock Function Detection";
+export declare const description = "Detects mock/simulated functions in production code";
+export declare const category = "code-quality";
+export declare const blocking = true;
+export declare const tags: string[];
+interface MockFunction {
+    file: string;
+    line: number;
+    functionName: string;
+    reason: string;
+    snippet: string;
+}
+declare function detectMockFunctions(): Promise<MockFunction[]>;
+export { detectMockFunctions };
+//# sourceMappingURL=mock-function-detection.d.ts.map

package/dist/checks/code-quality/mock-function-detection.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"mock-function-detection.d.ts","sourceRoot":"","sources":["../../../src/checks/code-quality/mock-function-detection.ts"],"names":[],"mappings":";AACA;;;;;;;;;;;;;;GAcG;AAMH,eAAO,MAAM,EAAE,yCAAyC,CAAC;AACzD,eAAO,MAAM,IAAI,4BAA4B,CAAC;AAC9C,eAAO,MAAM,WAAW,wDAAwD,CAAC;AACjF,eAAO,MAAM,QAAQ,iBAAiB,CAAC;AACvC,eAAO,MAAM,QAAQ,OAAO,CAAC;AAC7B,eAAO,MAAM,IAAI,UAA4D,CAAC;AAW9E,UAAU,YAAY;IACpB,IAAI,EAAE,MAAM,CAAC;IACb,IAAI,EAAE,MAAM,CAAC;IACb,YAAY,EAAE,MAAM,CAAC;IACrB,MAAM,EAAE,MAAM,CAAC;IACf,OAAO,EAAE,MAAM,CAAC;CACjB;AA8CD,iBAAe,mBAAmB,IAAI,OAAO,CAAC,YAAY,EAAE,CAAC,CA6G5D;AA2DD,OAAO,EAAE,mBAAmB,EAAE,CAAC"}