@empline/preflight 1.0.20

package/dist/checks/code-hygiene/api-error-handling.js

@@ -0,0 +1,285 @@
+#!/usr/bin/env tsx
+"use strict";
+/**
+ * API Error Handling Preflight (BLOCKING)
+ *
+ * Ensures all API routes have proper error handling with try-catch.
+ * Unhandled errors in API routes cause 500 errors and poor UX.
+ *
+ * Checks:
+ * - All route handlers (GET, POST, PUT, DELETE, PATCH) have try-catch
+ * - Catch blocks return proper error responses
+ * - No bare throw statements without context
+ * - Safe JSON parsing (request.json() wrapped in try-catch)
+ * - Centralized logging (logger.error vs console.error)
+ *
+ * Consolidated from:
+ * - code-hygiene/api-error-handling.ts (primary)
+ * - observability/api-error-handling-validation.ts (merged)
+ *
+ * Usage:
+ *   pnpm preflight:api-error-handling
+ *   pnpm preflight:api-error-handling --warning
+ */
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.tags = exports.description = exports.blocking = exports.category = exports.name = exports.id = void 0;
+const fs = __importStar(require("fs"));
+const path = __importStar(require("path"));
+const console_chars_1 = require("../../utils/console-chars");
+const file_cache_1 = require("../../shared/file-cache");
+const universal_progress_reporter_1 = require("../system/universal-progress-reporter");
+// Check metadata
+exports.id = "code-hygiene/api-error-handling";
+exports.name = "Api Error Handling";
+exports.category = "code-hygiene";
+exports.blocking = true;
+exports.description = "API Error Handling Preflight (BLOCKING)";
+exports.tags = ["code-hygiene"];
+const HTTP_METHODS = ["GET", "POST", "PUT", "DELETE", "PATCH", "HEAD", "OPTIONS"];
+// Test/debug routes that are intentionally simple (skip validation)
+const TEST_ROUTE_PATTERNS = [
+    /api[\/\\]auth[\/\\]test[\/\\]/,
+    /api[\/\\]auth[\/\\]test-route[\/\\]/,
+    /api[\/\\]test-vercel[\/\\]/,
+    /api[\/\\]test-db[\/\\]/,
+    /api[\/\\]test-nextauth[\/\\]/,
+    /api[\/\\]debug/,
+    /api[\/\\]auth-debug[\/\\]/,
+];
+// CACHED FILE LISTS - Scan once, use everywhere
+let _cachedApiRouteFiles = null;
+async function getApiRouteFiles() {
+    if (!_cachedApiRouteFiles) {
+        _cachedApiRouteFiles = await file_cache_1.fileCache.getAPIRouteFiles();
+    }
+    return _cachedApiRouteFiles;
+}
+async function checkApiErrorHandling() {
+    const violations = [];
+    // Find all API route files
+    const files = await getApiRouteFiles();
+    for (const file of files) {
+        const content = fs.readFileSync(file, "utf-8");
+        const relativePath = file.replace(/\\/g, "/");
+        // Skip test/debug routes
+        if (TEST_ROUTE_PATTERNS.some((p) => p.test(relativePath))) {
+            continue;
+        }
+        // Check each HTTP method handler
+        for (const method of HTTP_METHODS) {
+            // Check for exported handler
+            const handlerPatterns = [
+                new RegExp(`export\\s+(async\\s+)?function\\s+${method}\\s*\\(`),
+                new RegExp(`export\\s+const\\s+${method}\\s*=`),
+            ];
+            const hasHandler = handlerPatterns.some((p) => p.test(content));
+            if (!hasHandler)
+                continue;
+            // Find the handler function start position
+            const functionStartMatch = content.match(new RegExp(`export\\s+(async\\s+)?function\\s+${method}\\s*\\([^)]*\\)\\s*\\{`)) ||
+                content.match(new RegExp(`export\\s+const\\s+${method}\\s*=\\s*(async\\s*)?\\([^)]*\\)\\s*=>\\s*\\{`)) ||
+                content.match(new RegExp(`export\\s+const\\s+${method}\\s*=\\s*(async\\s*)?function\\s*\\([^)]*\\)\\s*\\{`));
+            if (!functionStartMatch)
+                continue;
+            // Extract the function body by counting braces
+            const startIndex = content.indexOf(functionStartMatch[0]);
+            const bodyStartIndex = content.indexOf("{", startIndex);
+            let braceCount = 0;
+            let endIndex = bodyStartIndex;
+            for (let i = bodyStartIndex; i < content.length; i++) {
+                if (content[i] === "{")
+                    braceCount++;
+                if (content[i] === "}")
+                    braceCount--;
+                if (braceCount === 0) {
+                    endIndex = i + 1;
+                    break;
+                }
+            }
+            const handlerBody = content.slice(startIndex, endIndex);
+            // Check for try-catch or withErrorHandler wrapper
+            const hasTryCatch = /try\s*\{[\s\S]*?\}\s*catch/.test(handlerBody);
+            const hasWithErrorHandler = /return\s+withErrorHandler(?:<[^>]+>)?\s*\(/.test(handlerBody);
+            if (!hasTryCatch && !hasWithErrorHandler) {
+                // Check if it's a simple handler that might not need try-catch
+                const isSimple = handlerBody.split("\n").length < 10 &&
+                    !handlerBody.includes("await") &&
+                    !handlerBody.includes("prisma");
+                // Check if it's a dev/test route that returns early in production
+                const isDevOnly = /process\.env\.NODE_ENV\s*[!=]==?\s*['"](?:development|production)['"]/.test(handlerBody) || /process\.env\.VERCEL_ENV\s*===?\s*['"]production['"]/.test(handlerBody);
+                if (!isSimple && !isDevOnly) {
+                    violations.push({
+                        file: relativePath,
+                        handler: method,
+                        issue: "no-try-catch",
+                    });
+                }
+            }
+            else if (hasTryCatch) {
+                // Only check catch block quality for explicit try-catch (withErrorHandler handles this internally)
+                // Check for empty catch blocks
+                if (/catch\s*\([^)]*\)\s*\{\s*\}/.test(handlerBody)) {
+                    violations.push({
+                        file: relativePath,
+                        handler: method,
+                        issue: "empty-catch",
+                    });
+                }
+                // Check if catch returns proper error response
+                const catchMatch = handlerBody.match(/catch\s*\([^)]*\)\s*\{([^}]*)\}/);
+                if (catchMatch) {
+                    const catchBody = catchMatch[1];
+                    const hasErrorResponse = /NextResponse\.json\s*\([^)]*status:\s*[45]\d\d/.test(catchBody) ||
+                        /Response\.json\s*\([^)]*status:\s*[45]\d\d/.test(catchBody) ||
+                        /new\s+Response\s*\([^)]*status:\s*[45]\d\d/.test(catchBody) ||
+                        /return\s+.*error/i.test(catchBody);
+                    if (!hasErrorResponse && catchBody.trim().length > 0) {
+                        // Check if it re-throws or logs
+                        const rethrows = /throw\s/.test(catchBody);
+                        const logs = /console\.(error|log)/.test(catchBody);
+                        if (!rethrows && !logs) {
+                            violations.push({
+                                file: relativePath,
+                                handler: method,
+                                issue: "no-error-response",
+                            });
+                        }
+                    }
+                }
+            }
+            // Check for unsafe JSON parsing (from observability/api-error-handling-validation.ts)
+            // request.json() should be wrapped in try-catch to handle invalid JSON
+            if (/request\.json\(\)/.test(handlerBody)) {
+                const hasTryCatchWrapper = /try\s*\{[\s\S]*?\}\s*catch/.test(handlerBody);
+                const hasSafeJsonParse = /try\s*\{[^}]*request\.json\(\)[^}]*\}\s*catch/s.test(handlerBody);
+                if (!hasTryCatchWrapper && !hasSafeJsonParse) {
+                    violations.push({
+                        file: relativePath,
+                        handler: method,
+                        issue: "unsafe-json-parse",
+                    });
+                }
+            }
+            // Check for centralized logging (warn only)
+            // Prefer logger.error over console.error for observability
+            if (/console\.error/.test(handlerBody) && !/logger\.(error|warn)\s*\(/.test(handlerBody)) {
+                violations.push({
+                    file: relativePath,
+                    handler: method,
+                    issue: "no-centralized-logging",
+                });
+            }
+        }
+    }
+    return violations;
+}
+async function main() {
+    const reporter = (0, universal_progress_reporter_1.createUniversalProgressReporter)(path.basename(__filename, ".ts"));
+    const args = process.argv.slice(2);
+    const warningOnly = args.includes("--warning") || args.includes("--warn");
+    const verbose = args.includes("--verbose") || args.includes("-v");
+    console.log("\n" + (0, console_chars_1.createDivider)(70, "double"));
+    console.log("  API ERROR HANDLING CHECK" + (warningOnly ? " (warning mode)" : " (BLOCKING)"));
+    console.log((0, console_chars_1.createDivider)(70, "double"));
+    const violations = await checkApiErrorHandling();
+    // Count total API routes
+    const allRoutes = await getApiRouteFiles();
+    if (violations.length === 0) {
+        console.log(`\n${console_chars_1.emoji.success} All ${allRoutes.length} API routes have proper error handling\n`);
+        process.exit(0);
+    }
+    // Group by issue type
+    const byIssue = new Map();
+    for (const v of violations) {
+        if (!byIssue.has(v.issue))
+            byIssue.set(v.issue, []);
+        byIssue.get(v.issue).push(v);
+    }
+    console.log(`\n${console_chars_1.emoji.error} Found ${violations.length} API error handling issues:\n`);
+    const issueLabels = {
+        "no-try-catch": `${console_chars_1.emoji.bell} Missing try-catch (crashes on error)`,
+        "empty-catch": `${console_chars_1.emoji.warning}  Empty catch block (silent failure)`,
+        "no-error-response": `${console_chars_1.emoji.warning}  No error response in catch`,
+        "unsafe-json-parse": `${console_chars_1.emoji.warning}  Unsafe request.json() (crashes on invalid JSON)`,
+        "no-centralized-logging": `${console_chars_1.emoji.info}  Using console.error instead of logger`,
+    };
+    for (const [issue, items] of byIssue) {
+        console.log(`\n${issueLabels[issue]} (${items.length}):`);
+        const toShow = verbose ? items : items.slice(0, 5);
+        for (const v of toShow) {
+            console.log(`   ${v.file} ${console_chars_1.chars.arrow} ${v.handler}()`);
+        }
+        if (!verbose && items.length > 5) {
+            console.log(`   ... and ${items.length - 5} more`);
+        }
+    }
+    console.log("\n" + (0, console_chars_1.createDivider)(70, "light"));
+    console.log(`${console_chars_1.emoji.hint} Proper API error handling pattern:`);
+    console.log("");
+    console.log("   export async function POST(request: Request) {");
+    console.log("     try {");
+    console.log("       let body;");
+    console.log("       try {");
+    console.log("         body = await request.json();");
+    console.log("       } catch {");
+    console.log('         return NextResponse.json({ error: "Invalid JSON" }, { status: 400 });');
+    console.log("       }");
+    console.log("       // ... your code");
+    console.log("       return NextResponse.json({ success: true });");
+    console.log("     } catch (error) {");
+    console.log('       logger.error("API Error:", { error, route: "/api/example" });');
+    console.log("       return NextResponse.json(");
+    console.log('         { error: "Internal server error" },');
+    console.log("         { status: 500 }");
+    console.log("       );");
+    console.log("     }");
+    console.log("   }");
+    console.log((0, console_chars_1.createDivider)(70, "light") + "\n");
+    if (warningOnly) {
+        console.log(`${console_chars_1.emoji.warning}  Warning mode - not blocking\n`);
+        process.exit(0);
+    }
+    // Only block on critical issues (no try-catch)
+    const critical = violations.filter((v) => v.issue === "no-try-catch");
+    if (critical.length > 0) {
+        console.log(`${console_chars_1.emoji.error} ${critical.length} API routes missing try-catch - blocking\n`);
+        process.exit(1);
+    }
+    console.log(`${console_chars_1.emoji.info}  No critical issues - passing with warnings\n`);
+    process.exit(0);
+}
+main().catch(console.error);
+//# sourceMappingURL=api-error-handling.js.map

package/dist/checks/code-hygiene/api-error-handling.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"api-error-handling.js","sourceRoot":"","sources":["../../../src/checks/code-hygiene/api-error-handling.ts"],"names":[],"mappings":";;AACA;;;;;;;;;;;;;;;;;;;;GAoBG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAEH,uCAAyB;AACzB,2CAA6B;AAC7B,6DAAwE;AACxE,wDAAoD;AACpD,uFAAwF;AAGxF,iBAAiB;AACJ,QAAA,EAAE,GAAG,iCAAiC,CAAC;AACvC,QAAA,IAAI,GAAG,oBAAoB,CAAC;AAC5B,QAAA,QAAQ,GAAG,cAAc,CAAC;AAC1B,QAAA,QAAQ,GAAG,IAAI,CAAC;AAChB,QAAA,WAAW,GAAG,yCAAyC,CAAC;AACxD,QAAA,IAAI,GAAG,CAAC,cAAc,CAAC,CAAC;AAcrC,MAAM,YAAY,GAAG,CAAC,KAAK,EAAE,MAAM,EAAE,KAAK,EAAE,QAAQ,EAAE,OAAO,EAAE,MAAM,EAAE,SAAS,CAAC,CAAC;AAElF,oEAAoE;AACpE,MAAM,mBAAmB,GAAG;IAC1B,+BAA+B;IAC/B,qCAAqC;IACrC,4BAA4B;IAC5B,wBAAwB;IACxB,8BAA8B;IAC9B,gBAAgB;IAChB,2BAA2B;CAC5B,CAAC;AAEF,gDAAgD;AAEhD,IAAI,oBAAoB,GAAoB,IAAI,CAAC;AACjD,KAAK,UAAU,gBAAgB;IAC7B,IAAI,CAAC,oBAAoB,EAAE,CAAC;QAC1B,oBAAoB,GAAG,MAAM,sBAAS,CAAC,gBAAgB,EAAE,CAAC;IAC5D,CAAC;IACD,OAAO,oBAAoB,CAAC;AAC9B,CAAC;AAED,KAAK,UAAU,qBAAqB;IAClC,MAAM,UAAU,GAAgB,EAAE,CAAC;IAEnC,2BAA2B;IAC3B,MAAM,KAAK,GAAG,MAAM,gBAAgB,EAAE,CAAC;IAEvC,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;QAC/C,MAAM,YAAY,GAAG,IAAI,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC;QAE9C,yBAAyB;QACzB,IAAI,mBAAmB,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC,EAAE,CAAC;YAC1D,SAAS;QACX,CAAC;QAED,iCAAiC;QACjC,KAAK,MAAM,MAAM,IAAI,YAAY,EAAE,CAAC;YAClC,6BAA6B;YAC7B,MAAM,eAAe,GAAG;gBACtB,IAAI,MAAM,CAAC,qCAAqC,MAAM,SAAS,CAAC;gBAChE,IAAI,MAAM,CAAC,sBAAsB,MAAM,OAAO,CAAC;aAChD,CAAC;YAEF,MAAM,UAAU,GAAG,eAAe,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC;YAChE,IAAI,CAAC,UAAU;gBAAE,SAAS;YAE1B,2CAA2C;YAC3C,MAAM,kBAAkB,GACtB,OAAO,CAAC,KAAK,CACX,IAAI,MAAM,CAAC,qCAAqC,MAAM,wBAAwB,CAAC,CAChF;gBACD,OAAO,CAAC,KAAK,CACX,IAAI,MAAM,CAAC,sBAAsB,MAAM,+CAA+C,CAAC,CACxF;gBACD,OAAO,CAAC,KAAK,CACX,IAAI,MAAM,CACR,sBAAsB,MAAM,qDAAqD,CAClF,CACF,CAAC;YAEJ,IAAI,CAAC,kBAAkB;gBAAE,SAAS;YAElC,+CAA+C;YAC/C,MAAM,UAAU,GAAG,OAAO,CAAC,OAAO,CAAC,kBAAkB,CAAC,CAAC,CAAC,CAAC,CAAC;YAC1D,MAAM,cAAc,GAAG,OAAO,CAAC,OAAO,CAAC,GAAG,EAAE,UAAU,CAAC,CAAC;YAExD,IAAI,UAAU,GAAG,CAAC,CAAC;YACnB,IAAI,QAAQ,GAAG,cAAc,CAAC;YAC9B,KAAK,IAAI,CAAC,GAAG,cAAc,EAAE,CAAC,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;gBACrD,IAAI,OAAO,CAAC,CAAC,CAAC,KAAK,GAAG;oBAAE,UAAU,EAAE,CAAC;gBACrC,IAAI,OAAO,CAAC,CAAC,CAAC,KAAK,GAAG;oBAAE,UAAU,EAAE,CAAC;gBACrC,IAAI,UAAU,KAAK,CAAC,EAAE,CAAC;oBACrB,QAAQ,GAAG,CAAC,GAAG,CAAC,CAAC;oBACjB,MAAM;gBACR,CAAC;YACH,CAAC;YAED,MAAM,WAAW,GAAG,OAAO,CAAC,KAAK,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;YAExD,kDAAkD;YAClD,MAAM,WAAW,GAAG,4BAA4B,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;YACnE,MAAM,mBAAmB,GAAG,4CAA4C,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;YAE3F,IAAI,CAAC,WAAW,IAAI,CAAC,mBAAmB,EAAE,CAAC;gBACzC,+DAA+D;gBAC/D,MAAM,QAAQ,GACZ,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,GAAG,EAAE;oBACnC,CAAC,WAAW,CAAC,QAAQ,CAAC,OAAO,CAAC;oBAC9B,CAAC,WAAW,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC;gBAElC,kEAAkE;gBAClE,MAAM,SAAS,GACb,uEAAuE,CAAC,IAAI,CAC1E,WAAW,CACZ,IAAI,sDAAsD,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;gBAEhF,IAAI,CAAC,QAAQ,IAAI,CAAC,SAAS,EAAE,CAAC;oBAC5B,UAAU,CAAC,IAAI,CAAC;wBACd,IAAI,EAAE,YAAY;wBAClB,OAAO,EAAE,MAAM;wBACf,KAAK,EAAE,cAAc;qBACtB,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;iBAAM,IAAI,WAAW,EAAE,CAAC;gBACvB,mGAAmG;gBACnG,+BAA+B;gBAC/B,IAAI,6BAA6B,CAAC,IAAI,CAAC,WAAW,CAAC,EAAE,CAAC;oBACpD,UAAU,CAAC,IAAI,CAAC;wBACd,IAAI,EAAE,YAAY;wBAClB,OAAO,EAAE,MAAM;wBACf,KAAK,EAAE,aAAa;qBACrB,CAAC,CAAC;gBACL,CAAC;gBAED,+CAA+C;gBAC/C,MAAM,UAAU,GAAG,WAAW,CAAC,KAAK,CAAC,iCAAiC,CAAC,CAAC;gBACxE,IAAI,UAAU,EAAE,CAAC;oBACf,MAAM,SAAS,GAAG,UAAU,CAAC,CAAC,CAAC,CAAC;oBAChC,MAAM,gBAAgB,GACpB,gDAAgD,CAAC,IAAI,CAAC,SAAS,CAAC;wBAChE,4CAA4C,CAAC,IAAI,CAAC,SAAS,CAAC;wBAC5D,4CAA4C,CAAC,IAAI,CAAC,SAAS,CAAC;wBAC5D,mBAAmB,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;oBAEtC,IAAI,CAAC,gBAAgB,IAAI,SAAS,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;wBACrD,gCAAgC;wBAChC,MAAM,QAAQ,GAAG,SAAS,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;wBAC3C,MAAM,IAAI,GAAG,sBAAsB,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;wBAEpD,IAAI,CAAC,QAAQ,IAAI,CAAC,IAAI,EAAE,CAAC;4BACvB,UAAU,CAAC,IAAI,CAAC;gCACd,IAAI,EAAE,YAAY;gCAClB,OAAO,EAAE,MAAM;gCACf,KAAK,EAAE,mBAAmB;6BAC3B,CAAC,CAAC;wBACL,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YAED,sFAAsF;YACtF,uEAAuE;YACvE,IAAI,mBAAmB,CAAC,IAAI,CAAC,WAAW,CAAC,EAAE,CAAC;gBAC1C,MAAM,kBAAkB,GAAG,4BAA4B,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;gBAC1E,MAAM,gBAAgB,GAAG,gDAAgD,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;gBAE5F,IAAI,CAAC,kBAAkB,IAAI,CAAC,gBAAgB,EAAE,CAAC;oBAC7C,UAAU,CAAC,IAAI,CAAC;wBACd,IAAI,EAAE,YAAY;wBAClB,OAAO,EAAE,MAAM;wBACf,KAAK,EAAE,mBAAmB;qBAC3B,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;YAED,4CAA4C;YAC5C,2DAA2D;YAC3D,IAAI,gBAAgB,CAAC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,2BAA2B,CAAC,IAAI,CAAC,WAAW,CAAC,EAAE,CAAC;gBACzF,UAAU,CAAC,IAAI,CAAC;oBACd,IAAI,EAAE,YAAY;oBAClB,OAAO,EAAE,MAAM;oBACf,KAAK,EAAE,wBAAwB;iBAChC,CAAC,CAAC;YACL,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED,KAAK,UAAU,IAAI;IACjB,MAAM,QAAQ,GAAG,IAAA,6DAA+B,EAAC,IAAI,CAAC,QAAQ,CAAC,UAAU,EAAE,KAAK,CAAC,CAAC,CAAC;IACnF,MAAM,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IACnC,MAAM,WAAW,GAAG,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC;IAC1E,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAElE,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,IAAA,6BAAa,EAAC,EAAE,EAAE,QAAQ,CAAC,CAAC,CAAC;IAChD,OAAO,CAAC,GAAG,CAAC,4BAA4B,GAAG,CAAC,WAAW,CAAC,CAAC,CAAC,iBAAiB,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,CAAC;IAC9F,OAAO,CAAC,GAAG,CAAC,IAAA,6BAAa,EAAC,EAAE,EAAE,QAAQ,CAAC,CAAC,CAAC;IAEzC,MAAM,UAAU,GAAG,MAAM,qBAAqB,EAAE,CAAC;IAEjD,yBAAyB;IACzB,MAAM,SAAS,GAAG,MAAM,gBAAgB,EAAE,CAAC;IAE3C,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC5B,OAAO,CAAC,GAAG,CACT,KAAK,qBAAK,CAAC,OAAO,QAAQ,SAAS,CAAC,MAAM,0CAA0C,CACrF,CAAC;QACF,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,sBAAsB;IACtB,MAAM,OAAO,GAAG,IAAI,GAAG,EAAuB,CAAC;IAC/C,KAAK,MAAM,CAAC,IAAI,UAAU,EAAE,CAAC;QAC3B,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC;YAAE,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC;QACpD,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,KAAK,CAAE,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAChC,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,KAAK,UAAU,UAAU,CAAC,MAAM,+BAA+B,CAAC,CAAC;IAExF,MAAM,WAAW,GAAG;QAClB,cAAc,EAAE,GAAG,qBAAK,CAAC,IAAI,uCAAuC;QACpE,aAAa,EAAE,GAAG,qBAAK,CAAC,OAAO,sCAAsC;QACrE,mBAAmB,EAAE,GAAG,qBAAK,CAAC,OAAO,8BAA8B;QACnE,mBAAmB,EAAE,GAAG,qBAAK,CAAC,OAAO,mDAAmD;QACxF,wBAAwB,EAAE,GAAG,qBAAK,CAAC,IAAI,yCAAyC;KACjF,CAAC;IAEF,KAAK,MAAM,CAAC,KAAK,EAAE,KAAK,CAAC,IAAI,OAAO,EAAE,CAAC;QACrC,OAAO,CAAC,GAAG,CAAC,KAAK,WAAW,CAAC,KAAiC,CAAC,KAAK,KAAK,CAAC,MAAM,IAAI,CAAC,CAAC;QACtF,MAAM,MAAM,GAAG,OAAO,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;QACnD,KAAK,MAAM,CAAC,IAAI,MAAM,EAAE,CAAC;YACvB,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC,IAAI,IAAI,qBAAK,CAAC,KAAK,IAAI,CAAC,CAAC,OAAO,IAAI,CAAC,CAAC;QAC5D,CAAC;QACD,IAAI,CAAC,OAAO,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACjC,OAAO,CAAC,GAAG,CAAC,cAAc,KAAK,CAAC,MAAM,GAAG,CAAC,OAAO,CAAC,CAAC;QACrD,CAAC;IACH,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,IAAI,qCAAqC,CAAC,CAAC;IAChE,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IAChB,OAAO,CAAC,GAAG,CAAC,mDAAmD,CAAC,CAAC;IACjE,OAAO,CAAC,GAAG,CAAC,YAAY,CAAC,CAAC;IAC1B,OAAO,CAAC,GAAG,CAAC,kBAAkB,CAAC,CAAC;IAChC,OAAO,CAAC,GAAG,CAAC,cAAc,CAAC,CAAC;IAC5B,OAAO,CAAC,GAAG,CAAC,uCAAuC,CAAC,CAAC;IACrD,OAAO,CAAC,GAAG,CAAC,kBAAkB,CAAC,CAAC;IAChC,OAAO,CAAC,GAAG,CAAC,gFAAgF,CAAC,CAAC;IAC9F,OAAO,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;IACxB,OAAO,CAAC,GAAG,CAAC,yBAAyB,CAAC,CAAC;IACvC,OAAO,CAAC,GAAG,CAAC,qDAAqD,CAAC,CAAC;IACnE,OAAO,CAAC,GAAG,CAAC,wBAAwB,CAAC,CAAC;IACtC,OAAO,CAAC,GAAG,CAAC,sEAAsE,CAAC,CAAC;IACpF,OAAO,CAAC,GAAG,CAAC,kCAAkC,CAAC,CAAC;IAChD,OAAO,CAAC,GAAG,CAAC,8CAA8C,CAAC,CAAC;IAC5D,OAAO,CAAC,GAAG,CAAC,0BAA0B,CAAC,CAAC;IACxC,OAAO,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;IACzB,OAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC;IACtB,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;IACpB,OAAO,CAAC,GAAG,CAAC,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,GAAG,IAAI,CAAC,CAAC;IAE/C,IAAI,WAAW,EAAE,CAAC;QAChB,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,OAAO,iCAAiC,CAAC,CAAC;QAC/D,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,+CAA+C;IAC/C,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,KAAK,cAAc,CAAC,CAAC;IACtE,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACxB,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,KAAK,IAAI,QAAQ,CAAC,MAAM,4CAA4C,CAAC,CAAC;QAC3F,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,IAAI,gDAAgD,CAAC,CAAC;IAC3E,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;AAClB,CAAC;AAED,IAAI,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC"}

package/dist/checks/code-hygiene/broken-template-literals.d.ts

@@ -0,0 +1,24 @@
+#!/usr/bin/env tsx
+/**
+ * Broken Template Literals Preflight (BLOCKING)
+ *
+ * Detects template literal syntax inside regular strings, which means
+ * the variables never resolve:
+ *   "${emoji.error}"  - BROKEN (regular string)
+ *   `${emoji.error}`  - CORRECT (template literal)
+ *
+ * This is a targeted check for .mjs files where this pattern is common.
+ * TypeScript files rarely have this issue due to type checking.
+ *
+ * Usage:
+ *   pnpm preflight:broken-template-literals
+ *   pnpm preflight:broken-template-literals --warning
+ *   pnpm preflight:broken-template-literals --verbose
+ */
+export declare const id = "code-hygiene/broken-template-literals";
+export declare const name = "Broken Template Literals";
+export declare const category = "code-hygiene";
+export declare const blocking = true;
+export declare const description = "Broken Template Literals Preflight (BLOCKING)";
+export declare const tags: string[];
+//# sourceMappingURL=broken-template-literals.d.ts.map

package/dist/checks/code-hygiene/broken-template-literals.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"broken-template-literals.d.ts","sourceRoot":"","sources":["../../../src/checks/code-hygiene/broken-template-literals.ts"],"names":[],"mappings":";AACA;;;;;;;;;;;;;;;GAeG;AAUH,eAAO,MAAM,EAAE,0CAA0C,CAAC;AAC1D,eAAO,MAAM,IAAI,6BAA6B,CAAC;AAC/C,eAAO,MAAM,QAAQ,iBAAiB,CAAC;AACvC,eAAO,MAAM,QAAQ,OAAO,CAAC;AAC7B,eAAO,MAAM,WAAW,kDAAkD,CAAC;AAC3E,eAAO,MAAM,IAAI,UAAmB,CAAC"}

package/dist/checks/code-hygiene/broken-template-literals.js

@@ -0,0 +1,209 @@
+#!/usr/bin/env tsx
+"use strict";
+/**
+ * Broken Template Literals Preflight (BLOCKING)
+ *
+ * Detects template literal syntax inside regular strings, which means
+ * the variables never resolve:
+ *   "${emoji.error}"  - BROKEN (regular string)
+ *   `${emoji.error}`  - CORRECT (template literal)
+ *
+ * This is a targeted check for .mjs files where this pattern is common.
+ * TypeScript files rarely have this issue due to type checking.
+ *
+ * Usage:
+ *   pnpm preflight:broken-template-literals
+ *   pnpm preflight:broken-template-literals --warning
+ *   pnpm preflight:broken-template-literals --verbose
+ */
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.tags = exports.description = exports.blocking = exports.category = exports.name = exports.id = void 0;
+const fs = __importStar(require("fs"));
+const glob_1 = require("glob");
+const path = __importStar(require("path"));
+const console_chars_1 = require("../../utils/console-chars");
+const glob_patterns_1 = require("../../shared/glob-patterns");
+// Check metadata
+exports.id = "code-hygiene/broken-template-literals";
+exports.name = "Broken Template Literals";
+exports.category = "code-hygiene";
+exports.blocking = true;
+exports.description = "Broken Template Literals Preflight (BLOCKING)";
+exports.tags = ["code-hygiene"];
+const SKIP_PATTERNS = (0, glob_patterns_1.extendExcludes)(glob_patterns_1.STANDARD_EXCLUDES, [
+    "**/.git/**",
+    "**/test-results/**",
+    "**/backups/**",
+    "**/*.lock",
+    "**/*.json",
+    "**/pnpm-lock.yaml",
+]);
+// Files that legitimately discuss these patterns
+const ALLOWED_FILES = new Set([
+    "broken-template-literals.ts",
+    "fix-broken-template-literals.ts",
+    "preflight-reference.md",
+]);
+/**
+ * Detects broken template literals by checking if a line:
+ * 1. Contains console.log/warn/error with a regular string (not template literal)
+ * 2. That string contains ${...} syntax
+ *
+ * This is more accurate than regex because we track quote state.
+ */
+function findBrokenTemplateLiterals(line) {
+    // Only check console output lines
+    if (!/console\.(log|warn|error|info)\s*\(/.test(line)) {
+        return null;
+    }
+    // Find the console.log call
+    const consoleMatch = line.match(/console\.(log|warn|error|info)\s*\(/);
+    if (!consoleMatch || consoleMatch.index === undefined)
+        return null;
+    const startIdx = consoleMatch.index + consoleMatch[0].length;
+    let inSingleQuote = false;
+    let inDoubleQuote = false;
+    let inBacktick = false;
+    for (let i = startIdx; i < line.length; i++) {
+        const char = line[i];
+        const prevChar = i > 0 ? line[i - 1] : "";
+        // Skip escaped characters
+        if (prevChar === "\\")
+            continue;
+        // Track quote state
+        if (char === "'" && !inDoubleQuote && !inBacktick) {
+            inSingleQuote = !inSingleQuote;
+        }
+        else if (char === '"' && !inSingleQuote && !inBacktick) {
+            inDoubleQuote = !inDoubleQuote;
+        }
+        else if (char === "`" && !inSingleQuote && !inDoubleQuote) {
+            inBacktick = !inBacktick;
+        }
+        // Check for ${...} inside regular strings (not backticks)
+        if ((inSingleQuote || inDoubleQuote) && !inBacktick) {
+            if (char === "$" && line[i + 1] === "{") {
+                // Found ${...} inside a regular string - this is broken!
+                const endBrace = line.indexOf("}", i + 2);
+                if (endBrace > i) {
+                    return line.substring(i, endBrace + 1);
+                }
+                return "${...}";
+            }
+        }
+    }
+    return null;
+}
+async function scanFile(filePath) {
+    const violations = [];
+    const filename = path.basename(filePath);
+    if (ALLOWED_FILES.has(filename))
+        return [];
+    const content = fs.readFileSync(filePath, "utf8");
+    const lines = content.split("\n");
+    for (let i = 0; i < lines.length; i++) {
+        const line = lines[i];
+        const lineNum = i + 1;
+        const brokenPattern = findBrokenTemplateLiterals(line);
+        if (brokenPattern) {
+            violations.push({
+                file: filePath.replace(/\\/g, "/"),
+                line: lineNum,
+                content: line.trim().substring(0, 80),
+                pattern: brokenPattern,
+            });
+        }
+    }
+    return violations;
+}
+async function main() {
+    const args = process.argv.slice(2);
+    const warningOnly = args.includes("--warning") || args.includes("--warn");
+    const verbose = args.includes("--verbose") || args.includes("-v");
+    console.log("\n" + (0, console_chars_1.createDivider)(60, "heavy"));
+    console.log("  BROKEN TEMPLATE LITERALS CHECK" + (warningOnly ? " (warning)" : " (BLOCKING)"));
+    console.log((0, console_chars_1.createDivider)(60, "heavy"));
+    // Focus on .mjs files where this is most common, but also check .ts/.js
+    const scanDirs = [
+        "scripts/**/*.{ts,tsx,js,mjs}",
+        "app/**/*.{ts,tsx}",
+        "components/**/*.{ts,tsx}",
+        "lib/**/*.{ts,tsx}",
+    ];
+    const allFiles = [];
+    for (const pattern of scanDirs) {
+        const files = await (0, glob_1.glob)(pattern, { ignore: SKIP_PATTERNS });
+        allFiles.push(...files);
+    }
+    console.log(`\n${console_chars_1.emoji.search} Scanning ${allFiles.length} files...\n`);
+    const allViolations = [];
+    for (const file of allFiles) {
+        const violations = await scanFile(file);
+        allViolations.push(...violations);
+    }
+    if (allViolations.length === 0) {
+        console.log(`${console_chars_1.emoji.success} No broken template literals found\n`);
+        process.exit(0);
+    }
+    console.log(`${console_chars_1.emoji.warning} Found ${allViolations.length} broken template literal(s):\n`);
+    const toShow = verbose ? allViolations : allViolations.slice(0, 15);
+    for (const v of toShow) {
+        const relPath = path.relative(process.cwd(), v.file);
+        console.log(`  ${console_chars_1.chars.bullet} ${relPath}:${v.line}`);
+        console.log(`    Pattern: ${v.pattern}`);
+        console.log(`    ${v.content}`);
+        console.log("");
+    }
+    if (!verbose && allViolations.length > 15) {
+        console.log(`  ... and ${allViolations.length - 15} more (use --verbose to see all)\n`);
+    }
+    console.log((0, console_chars_1.createDivider)(60, "light"));
+    console.log(`${console_chars_1.emoji.hint} To fix: Change quotes to backticks for template literals`);
+    console.log(`   ${console_chars_1.chars.cross} console.log("\${var}")  (broken - regular string)`);
+    console.log(`   ${console_chars_1.chars.check} console.log(\`\${var}\`)  (correct - template literal)`);
+    console.log((0, console_chars_1.createDivider)(60, "light") + "\n");
+    if (warningOnly) {
+        console.log(`${console_chars_1.emoji.warning} Warning mode - not blocking\n`);
+        process.exit(0);
+    }
+    console.log(`${console_chars_1.emoji.error} Broken template literals detected - fix before committing\n`);
+    process.exit(1);
+}
+main().catch((err) => {
+    console.error(`${console_chars_1.emoji.error} Preflight error:`, err);
+    process.exit(1);
+});
+//# sourceMappingURL=broken-template-literals.js.map

package/dist/checks/code-hygiene/broken-template-literals.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"broken-template-literals.js","sourceRoot":"","sources":["../../../src/checks/code-hygiene/broken-template-literals.ts"],"names":[],"mappings":";;AACA;;;;;;;;;;;;;;;GAeG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAEH,uCAAyB;AACzB,+BAA4B;AAC5B,2CAA6B;AAC7B,6DAAwE;AACxE,8DAA+E;AAG/E,iBAAiB;AACJ,QAAA,EAAE,GAAG,uCAAuC,CAAC;AAC7C,QAAA,IAAI,GAAG,0BAA0B,CAAC;AAClC,QAAA,QAAQ,GAAG,cAAc,CAAC;AAC1B,QAAA,QAAQ,GAAG,IAAI,CAAC;AAChB,QAAA,WAAW,GAAG,+CAA+C,CAAC;AAC9D,QAAA,IAAI,GAAG,CAAC,cAAc,CAAC,CAAC;AASrC,MAAM,aAAa,GAAG,IAAA,8BAAc,EAAC,iCAAiB,EAAE;IACtD,YAAY;IACZ,oBAAoB;IACpB,eAAe;IACf,WAAW;IACX,WAAW;IACX,mBAAmB;CACpB,CAAC,CAAC;AAEH,iDAAiD;AACjD,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC;IAC5B,6BAA6B;IAC7B,iCAAiC;IACjC,wBAAwB;CACzB,CAAC,CAAC;AAEH;;;;;;GAMG;AACH,SAAS,0BAA0B,CAAC,IAAY;IAC9C,kCAAkC;IAClC,IAAI,CAAC,qCAAqC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;QACtD,OAAO,IAAI,CAAC;IACd,CAAC;IAED,4BAA4B;IAC5B,MAAM,YAAY,GAAG,IAAI,CAAC,KAAK,CAAC,qCAAqC,CAAC,CAAC;IACvE,IAAI,CAAC,YAAY,IAAI,YAAY,CAAC,KAAK,KAAK,SAAS;QAAE,OAAO,IAAI,CAAC;IAEnE,MAAM,QAAQ,GAAG,YAAY,CAAC,KAAK,GAAG,YAAY,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC;IAC7D,IAAI,aAAa,GAAG,KAAK,CAAC;IAC1B,IAAI,aAAa,GAAG,KAAK,CAAC;IAC1B,IAAI,UAAU,GAAG,KAAK,CAAC;IAEvB,KAAK,IAAI,CAAC,GAAG,QAAQ,EAAE,CAAC,GAAG,IAAI,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QAC5C,MAAM,IAAI,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;QACrB,MAAM,QAAQ,GAAG,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QAE1C,0BAA0B;QAC1B,IAAI,QAAQ,KAAK,IAAI;YAAE,SAAS;QAEhC,oBAAoB;QACpB,IAAI,IAAI,KAAK,GAAG,IAAI,CAAC,aAAa,IAAI,CAAC,UAAU,EAAE,CAAC;YAClD,aAAa,GAAG,CAAC,aAAa,CAAC;QACjC,CAAC;aAAM,IAAI,IAAI,KAAK,GAAG,IAAI,CAAC,aAAa,IAAI,CAAC,UAAU,EAAE,CAAC;YACzD,aAAa,GAAG,CAAC,aAAa,CAAC;QACjC,CAAC;aAAM,IAAI,IAAI,KAAK,GAAG,IAAI,CAAC,aAAa,IAAI,CAAC,aAAa,EAAE,CAAC;YAC5D,UAAU,GAAG,CAAC,UAAU,CAAC;QAC3B,CAAC;QAED,0DAA0D;QAC1D,IAAI,CAAC,aAAa,IAAI,aAAa,CAAC,IAAI,CAAC,UAAU,EAAE,CAAC;YACpD,IAAI,IAAI,KAAK,GAAG,IAAI,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,GAAG,EAAE,CAAC;gBACxC,yDAAyD;gBACzD,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC;gBAC1C,IAAI,QAAQ,GAAG,CAAC,EAAE,CAAC;oBACjB,OAAO,IAAI,CAAC,SAAS,CAAC,CAAC,EAAE,QAAQ,GAAG,CAAC,CAAC,CAAC;gBACzC,CAAC;gBACD,OAAO,QAAQ,CAAC;YAClB,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,IAAI,CAAC;AACd,CAAC;AAED,KAAK,UAAU,QAAQ,CAAC,QAAgB;IACtC,MAAM,UAAU,GAAgB,EAAE,CAAC;IACnC,MAAM,QAAQ,GAAG,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC;IAEzC,IAAI,aAAa,CAAC,GAAG,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IAE3C,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;IAClD,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAElC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QACtC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAE,CAAC;QACvB,MAAM,OAAO,GAAG,CAAC,GAAG,CAAC,CAAC;QAEtB,MAAM,aAAa,GAAG,0BAA0B,CAAC,IAAI,CAAC,CAAC;QACvD,IAAI,aAAa,EAAE,CAAC;YAClB,UAAU,CAAC,IAAI,CAAC;gBACd,IAAI,EAAE,QAAQ,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC;gBAClC,IAAI,EAAE,OAAO;gBACb,OAAO,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC,SAAS,CAAC,CAAC,EAAE,EAAE,CAAC;gBACrC,OAAO,EAAE,aAAa;aACvB,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED,KAAK,UAAU,IAAI;IACjB,MAAM,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IACnC,MAAM,WAAW,GAAG,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC;IAC1E,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAElE,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,kCAAkC,GAAG,CAAC,WAAW,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,CAAC;IAC/F,OAAO,CAAC,GAAG,CAAC,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAExC,wEAAwE;IACxE,MAAM,QAAQ,GAAG;QACf,8BAA8B;QAC9B,mBAAmB;QACnB,0BAA0B;QAC1B,mBAAmB;KACpB,CAAC;IAEF,MAAM,QAAQ,GAAa,EAAE,CAAC;IAC9B,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;QAC/B,MAAM,KAAK,GAAG,MAAM,IAAA,WAAI,EAAC,OAAO,EAAE,EAAE,MAAM,EAAE,aAAa,EAAE,CAAC,CAAC;QAC7D,QAAQ,CAAC,IAAI,CAAC,GAAG,KAAK,CAAC,CAAC;IAC1B,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,MAAM,aAAa,QAAQ,CAAC,MAAM,aAAa,CAAC,CAAC;IAExE,MAAM,aAAa,GAAgB,EAAE,CAAC;IACtC,KAAK,MAAM,IAAI,IAAI,QAAQ,EAAE,CAAC;QAC5B,MAAM,UAAU,GAAG,MAAM,QAAQ,CAAC,IAAI,CAAC,CAAC;QACxC,aAAa,CAAC,IAAI,CAAC,GAAG,UAAU,CAAC,CAAC;IACpC,CAAC;IAED,IAAI,aAAa,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC/B,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,OAAO,sCAAsC,CAAC,CAAC;QACpE,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,OAAO,UAAU,aAAa,CAAC,MAAM,gCAAgC,CAAC,CAAC;IAE5F,MAAM,MAAM,GAAG,OAAO,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,CAAC,aAAa,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;IACpE,KAAK,MAAM,CAAC,IAAI,MAAM,EAAE,CAAC;QACvB,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC;QACrD,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,MAAM,IAAI,OAAO,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;QACtD,OAAO,CAAC,GAAG,CAAC,gBAAgB,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;QACzC,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;QAChC,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IAClB,CAAC;IAED,IAAI,CAAC,OAAO,IAAI,aAAa,CAAC,MAAM,GAAG,EAAE,EAAE,CAAC;QAC1C,OAAO,CAAC,GAAG,CAAC,aAAa,aAAa,CAAC,MAAM,GAAG,EAAE,oCAAoC,CAAC,CAAC;IAC1F,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IACxC,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,IAAI,2DAA2D,CAAC,CAAC;IACtF,OAAO,CAAC,GAAG,CAAC,MAAM,qBAAK,CAAC,KAAK,oDAAoD,CAAC,CAAC;IACnF,OAAO,CAAC,GAAG,CAAC,MAAM,qBAAK,CAAC,KAAK,yDAAyD,CAAC,CAAC;IACxF,OAAO,CAAC,GAAG,CAAC,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,GAAG,IAAI,CAAC,CAAC;IAE/C,IAAI,WAAW,EAAE,CAAC;QAChB,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,OAAO,gCAAgC,CAAC,CAAC;QAC9D,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,GAAG,qBAAK,CAAC,KAAK,8DAA8D,CAAC,CAAC;IAC1F,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;AAClB,CAAC;AAED,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC,GAAG,EAAE,EAAE;IACnB,OAAO,CAAC,KAAK,CAAC,GAAG,qBAAK,CAAC,KAAK,mBAAmB,EAAE,GAAG,CAAC,CAAC;IACtD,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;AAClB,CAAC,CAAC,CAAC"}

package/dist/checks/code-hygiene/comment-hygiene.d.ts

@@ -0,0 +1,26 @@
+#!/usr/bin/env tsx
+/**
+ * Comment Hygiene Preflight (BLOCKING)
+ *
+ * Detects problematic comment patterns that indicate code smell:
+ * 1. Commented-out code - Dead code that should be deleted, not commented
+ * 2. Excessive comment ratio - Files where comments exceed 30% of total lines
+ * 3. Stale comment detection - Comments referencing removed/renamed identifiers
+ *
+ * Opt-out per file: add `preflight:allow-commented-code` anywhere in the file
+ *
+ * Usage:
+ *   pnpm preflight:comment-hygiene
+ *   pnpm preflight:comment-hygiene --warning
+ *   pnpm preflight:comment-hygiene --verbose
+ *   pnpm preflight:comment-hygiene --fix (removes commented-out code)
+ *
+ * @since 2026-01-06
+ */
+export declare const id = "code-hygiene/comment-hygiene";
+export declare const name = "Comment Hygiene";
+export declare const category = "code-hygiene";
+export declare const blocking = true;
+export declare const description = "Comment Hygiene Preflight (BLOCKING)";
+export declare const tags: string[];
+//# sourceMappingURL=comment-hygiene.d.ts.map

package/dist/checks/code-hygiene/comment-hygiene.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"comment-hygiene.d.ts","sourceRoot":"","sources":["../../../src/checks/code-hygiene/comment-hygiene.ts"],"names":[],"mappings":";AACA;;;;;;;;;;;;;;;;;GAiBG;AAQH,eAAO,MAAM,EAAE,iCAAiC,CAAC;AACjD,eAAO,MAAM,IAAI,oBAAoB,CAAC;AACtC,eAAO,MAAM,QAAQ,iBAAiB,CAAC;AACvC,eAAO,MAAM,QAAQ,OAAO,CAAC;AAC7B,eAAO,MAAM,WAAW,yCAAyC,CAAC;AAClE,eAAO,MAAM,IAAI,UAAmB,CAAC"}