@empline/preflight 1.0.20

package/dist/checks/code-quality/feature-flag-hygiene.js

@@ -0,0 +1,353 @@
+#!/usr/bin/env tsx
+"use strict";
+/**
+ * Feature Flag Hygiene Preflight (NON-BLOCKING)
+ *
+ * Detects stale or problematic feature flags that accumulate as tech debt.
+ * Feature flags should be temporary and cleaned up after rollout.
+ *
+ * Patterns detected:
+ * - Feature flags older than 90 days (based on git history)
+ * - Feature flags without corresponding env variable
+ * - Hardcoded feature flags (always true/false)
+ * - Inconsistent feature flag naming
+ * - Feature flags used but never defined
+ * - Dead feature flag code paths
+ *
+ * Usage:
+ *   pnpm preflight:feature-flag-hygiene
+ *   pnpm preflight:feature-flag-hygiene --verbose
+ */
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.tags = exports.description = exports.blocking = exports.category = exports.name = exports.id = void 0;
+const child_process_1 = require("child_process");
+const fs = __importStar(require("fs"));
+const path = __importStar(require("path"));
+const console_chars_1 = require("../../utils/console-chars");
+const file_cache_1 = require("../../shared/file-cache");
+const glob_patterns_1 = require("../../shared/glob-patterns");
+const universal_progress_reporter_1 = require("../system/universal-progress-reporter");
+// Check metadata
+exports.id = "code-quality/feature-flag-hygiene";
+exports.name = "Feature Flag Hygiene";
+exports.category = "code-quality";
+exports.blocking = false;
+exports.description = "Feature Flag Hygiene Preflight (NON-BLOCKING)";
+exports.tags = ["code-quality"];
+const issues = [];
+const foundFlags = new Map();
+// Feature flag patterns to detect
+const FLAG_PATTERNS = [
+    {
+        // Environment variable feature flags
+        regex: /process\.env\.(?:NEXT_PUBLIC_)?(?:FEATURE_|FF_|ENABLE_|DISABLE_)(\w+)/g,
+        type: "env",
+    },
+    {
+        // Feature flag constants
+        regex: /(?:const|let|var)\s+(?:FEATURE_|FF_|ENABLE_|DISABLE_|IS_)(\w+)_(?:ENABLED|DISABLED|ACTIVE)\s*=/g,
+        type: "constant",
+    },
+    {
+        // Feature flag function calls
+        regex: /(?:isFeatureEnabled|hasFeature|checkFeature|useFeatureFlag)\s*\(\s*['"`]([^'"`]+)['"`]\s*\)/g,
+        type: "function",
+    },
+    {
+        // Inline feature checks
+        regex: /(?:featureFlags|features|flags)\s*\.\s*(\w+)/g,
+        type: "inline",
+    },
+];
+// Problematic patterns
+const PROBLEM_PATTERNS = [
+    {
+        // Hardcoded true (flag should be removed)
+        regex: /(?:FEATURE_|FF_|ENABLE_)(\w+)\s*=\s*true\s*(?:;|,|\n)/g,
+        code: "HARDCODED_TRUE",
+        message: "Feature flag hardcoded to true - remove flag and dead code",
+        severity: "warning",
+    },
+    {
+        // Hardcoded false (dead code)
+        regex: /(?:FEATURE_|FF_|ENABLE_)(\w+)\s*=\s*false\s*(?:;|,|\n)/g,
+        code: "HARDCODED_FALSE",
+        message: "Feature flag hardcoded to false - remove flag and dead code",
+        severity: "warning",
+    },
+    {
+        // TODO/FIXME with feature flag
+        regex: /(?:TODO|FIXME)[^]*?(?:FEATURE_|FF_|feature.?flag)(\w*)/gi,
+        code: "TODO_FLAG",
+        message: "TODO/FIXME referencing feature flag - needs cleanup",
+        severity: "info",
+    },
+    {
+        // Inconsistent naming (camelCase vs UPPER_CASE)
+        regex: /(?:featureFlag|feature_flag)\.([a-z][a-zA-Z]+)/g,
+        code: "INCONSISTENT_NAMING",
+        message: "Inconsistent feature flag naming - use UPPER_SNAKE_CASE",
+        severity: "info",
+    },
+];
+// Skip patterns
+const SKIP_PATTERNS = (0, glob_patterns_1.extendExcludes)(glob_patterns_1.STANDARD_EXCLUDES, [
+    "node_modules",
+    ".next",
+    "dist",
+    ".git",
+    "__mocks__",
+    "*.test.ts",
+    "*.spec.ts",
+]);
+function shouldSkip(filePath) {
+    const normalized = filePath.replace(/\\/g, "/");
+    return SKIP_PATTERNS.some((pattern) => {
+        if (pattern.startsWith("*")) {
+            return normalized.endsWith(pattern.slice(1));
+        }
+        return normalized.includes(pattern);
+    });
+}
+function getFileAge(filePath) {
+    try {
+        const result = (0, child_process_1.execSync)(`git log -1 --format=%ct -- "${filePath}"`, {
+            encoding: "utf-8",
+            stdio: ["pipe", "pipe", "ignore"],
+        }).trim();
+        if (!result)
+            return null;
+        const timestamp = parseInt(result, 10);
+        const now = Date.now() / 1000;
+        return Math.floor((now - timestamp) / (24 * 60 * 60)); // Days
+    }
+    catch {
+        return null;
+    }
+}
+function getFlagFirstCommit(flagName) {
+    try {
+        const result = (0, child_process_1.execSync)(`git log --all --format=%ct -S "${flagName}" --reverse | head -1`, {
+            encoding: "utf-8",
+            stdio: ["pipe", "pipe", "ignore"],
+        }).trim();
+        if (!result)
+            return null;
+        const timestamp = parseInt(result, 10);
+        const now = Date.now() / 1000;
+        return Math.floor((now - timestamp) / (24 * 60 * 60)); // Days
+    }
+    catch {
+        return null;
+    }
+}
+async function scanFile(filePath) {
+    if (shouldSkip(filePath))
+        return;
+    const content = fs.readFileSync(filePath, "utf-8");
+    const lines = content.split("\n");
+    // Find feature flags
+    for (const pattern of FLAG_PATTERNS) {
+        let match;
+        const regex = new RegExp(pattern.regex.source, pattern.regex.flags);
+        while ((match = regex.exec(content)) !== null) {
+            const flagName = match[1];
+            const beforeMatch = content.slice(0, match.index);
+            const lineNumber = beforeMatch.split("\n").length;
+            const flag = {
+                name: flagName,
+                file: filePath,
+                line: lineNumber,
+                type: pattern.type,
+            };
+            if (!foundFlags.has(flagName)) {
+                foundFlags.set(flagName, []);
+            }
+            foundFlags.get(flagName).push(flag);
+        }
+    }
+    // Find problematic patterns
+    for (const pattern of PROBLEM_PATTERNS) {
+        let match;
+        const regex = new RegExp(pattern.regex.source, pattern.regex.flags);
+        while ((match = regex.exec(content)) !== null) {
+            const flagName = match[1] || "unknown";
+            const beforeMatch = content.slice(0, match.index);
+            const lineNumber = beforeMatch.split("\n").length;
+            // Skip comments
+            const line = lines[lineNumber - 1] || "";
+            if (line.trim().startsWith("//") && pattern.code !== "TODO_FLAG") {
+                continue;
+            }
+            issues.push({
+                flag: flagName,
+                file: filePath,
+                line: lineNumber,
+                severity: pattern.severity,
+                code: pattern.code,
+                message: pattern.message,
+            });
+        }
+    }
+}
+async function checkEnvDefinitions() {
+    // Check if env flags are defined in .env.example
+    const envExamplePath = path.join(process.cwd(), ".env.example");
+    let envExample = "";
+    if (fs.existsSync(envExamplePath)) {
+        envExample = fs.readFileSync(envExamplePath, "utf-8");
+    }
+    for (const [flagName, usages] of Array.from(foundFlags.entries())) {
+        // Only check env-type flags
+        const envUsages = usages.filter((u) => u.type === "env");
+        if (envUsages.length === 0)
+            continue;
+        const envVarName = `FEATURE_${flagName}`;
+        const altEnvVarName = `NEXT_PUBLIC_FEATURE_${flagName}`;
+        if (!envExample.includes(envVarName) && !envExample.includes(altEnvVarName)) {
+            issues.push({
+                flag: flagName,
+                file: envUsages[0].file,
+                line: envUsages[0].line,
+                severity: "warning",
+                code: "MISSING_ENV_DEFINITION",
+                message: `Feature flag ${envVarName} used but not defined in .env.example`,
+            });
+        }
+    }
+}
+async function checkStaleFlags() {
+    const STALE_THRESHOLD_DAYS = 90;
+    for (const [flagName, usages] of Array.from(foundFlags.entries())) {
+        const age = getFlagFirstCommit(flagName);
+        if (age !== null && age > STALE_THRESHOLD_DAYS) {
+            issues.push({
+                flag: flagName,
+                file: usages[0].file,
+                line: usages[0].line,
+                severity: "info",
+                code: "STALE_FLAG",
+                message: `Feature flag is ${age} days old (>${STALE_THRESHOLD_DAYS}) - consider cleanup`,
+            });
+        }
+    }
+}
+async function main() {
+    const reporter = (0, universal_progress_reporter_1.createUniversalProgressReporter)(path.basename(__filename, ".ts"));
+    const verbose = process.argv.includes("--verbose") || process.argv.includes("-v");
+    const strict = process.argv.includes("--strict");
+    console.log(`\n${console_chars_1.emoji.flag} Feature Flag Hygiene`);
+    console.log((0, console_chars_1.createDivider)(60, "heavy"));
+    const files = await file_cache_1.fileCache.getAppCodeFiles();
+    for (const file of files) {
+        await scanFile(file);
+    }
+    // Additional checks
+    await checkEnvDefinitions();
+    await checkStaleFlags();
+    // Deduplicate
+    const seen = new Set();
+    const uniqueIssues = issues.filter((i) => {
+        const key = `${i.file}:${i.line}:${i.code}`;
+        if (seen.has(key))
+            return false;
+        seen.add(key);
+        return true;
+    });
+    const errors = uniqueIssues.filter((i) => i.severity === "error");
+    const warnings = uniqueIssues.filter((i) => i.severity === "warning");
+    const infos = uniqueIssues.filter((i) => i.severity === "info");
+    // Summary
+    console.log(`\nFeature flags found: ${foundFlags.size}`);
+    if (verbose) {
+        for (const [name, usages] of Array.from(foundFlags.entries())) {
+            console.log(`   ${name}: ${usages.length} usage(s)`);
+        }
+    }
+    if (uniqueIssues.length > 0) {
+        if (errors.length > 0) {
+            console.log(`\n${console_chars_1.emoji.error} ERRORS:`);
+            errors.forEach((issue) => {
+                console.log(`   ${issue.file}:${issue.line} [${issue.code}]`);
+                console.log(`      Flag: ${issue.flag}`);
+                console.log(`      ${issue.message}`);
+            });
+        }
+        if (warnings.length > 0) {
+            console.log(`\n${console_chars_1.emoji.warning}  WARNINGS:`);
+            warnings.slice(0, 15).forEach((issue) => {
+                console.log(`   ${issue.file}:${issue.line} [${issue.code}]`);
+                console.log(`      Flag: ${issue.flag}`);
+                console.log(`      ${issue.message}`);
+            });
+            if (warnings.length > 15) {
+                console.log(`   ... and ${warnings.length - 15} more warnings`);
+            }
+        }
+        if (verbose && infos.length > 0) {
+            console.log(`\n${console_chars_1.emoji.info} INFO:`);
+            infos.slice(0, 10).forEach((issue) => {
+                console.log(`   ${issue.file}:${issue.line} - ${issue.flag}: ${issue.message}`);
+            });
+            if (infos.length > 10) {
+                console.log(`   ... and ${infos.length - 10} more`);
+            }
+        }
+    }
+    console.log("\n" + (0, console_chars_1.createDivider)(60, "heavy"));
+    console.log(`Files scanned: ${files.length}`);
+    console.log(`Feature flags: ${foundFlags.size}`);
+    console.log(`Issues: ${uniqueIssues.length} (${errors.length} errors, ${warnings.length} warnings)`);
+    // Non-blocking by default
+    if (strict && (errors.length > 0 || warnings.length > 0)) {
+        console.log(`\n${console_chars_1.emoji.error} Feature Flag Hygiene FAILED (strict mode)`);
+        console.log("\n" + console_chars_1.emoji.hint + " Cleanup steps:");
+        console.log("  1. Remove hardcoded true/false flags");
+        console.log("  2. Delete dead code behind disabled flags");
+        console.log("  3. Add missing flags to .env.example");
+        console.log("  4. Review flags older than 90 days");
+        process.exit(1);
+    }
+    if (warnings.length > 0 || infos.length > 0) {
+        console.log(`\n${console_chars_1.emoji.warning}  Feature Flag Hygiene completed with suggestions`);
+        console.log("   Review stale flags and consider cleanup");
+    }
+    else {
+        console.log(`\n${console_chars_1.emoji.success} Feature Flag Hygiene PASSED`);
+    }
+}
+main().catch(console.error);
+//# sourceMappingURL=feature-flag-hygiene.js.map

package/dist/checks/code-quality/feature-flag-hygiene.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"feature-flag-hygiene.js","sourceRoot":"","sources":["../../../src/checks/code-quality/feature-flag-hygiene.ts"],"names":[],"mappings":";;AACA;;;;;;;;;;;;;;;;;GAiBG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAEH,iDAAyC;AACzC,uCAAyB;AACzB,2CAA6B;AAC7B,6DAAiE;AACjE,wDAAoD;AACpD,8DAA+E;AAC/E,uFAAwF;AAGxF,iBAAiB;AACJ,QAAA,EAAE,GAAG,mCAAmC,CAAC;AACzC,QAAA,IAAI,GAAG,sBAAsB,CAAC;AAC9B,QAAA,QAAQ,GAAG,cAAc,CAAC;AAC1B,QAAA,QAAQ,GAAG,KAAK,CAAC;AACjB,QAAA,WAAW,GAAG,+CAA+C,CAAC;AAC9D,QAAA,IAAI,GAAG,CAAC,cAAc,CAAC,CAAC;AAmBrC,MAAM,MAAM,GAAY,EAAE,CAAC;AAC3B,MAAM,UAAU,GAAG,IAAI,GAAG,EAAyB,CAAC;AAEpD,kCAAkC;AAClC,MAAM,aAAa,GAAG;IACpB;QACE,qCAAqC;QACrC,KAAK,EAAE,wEAAwE;QAC/E,IAAI,EAAE,KAAc;KACrB;IACD;QACE,yBAAyB;QACzB,KAAK,EACH,iGAAiG;QACnG,IAAI,EAAE,UAAmB;KAC1B;IACD;QACE,8BAA8B;QAC9B,KAAK,EACH,8FAA8F;QAChG,IAAI,EAAE,UAAmB;KAC1B;IACD;QACE,wBAAwB;QACxB,KAAK,EAAE,+CAA+C;QACtD,IAAI,EAAE,QAAiB;KACxB;CACF,CAAC;AAEF,uBAAuB;AACvB,MAAM,gBAAgB,GAAG;IACvB;QACE,0CAA0C;QAC1C,KAAK,EAAE,wDAAwD;QAC/D,IAAI,EAAE,gBAAgB;QACtB,OAAO,EAAE,4DAA4D;QACrE,QAAQ,EAAE,SAAkB;KAC7B;IACD;QACE,8BAA8B;QAC9B,KAAK,EAAE,yDAAyD;QAChE,IAAI,EAAE,iBAAiB;QACvB,OAAO,EAAE,6DAA6D;QACtE,QAAQ,EAAE,SAAkB;KAC7B;IACD;QACE,+BAA+B;QAC/B,KAAK,EAAE,0DAA0D;QACjE,IAAI,EAAE,WAAW;QACjB,OAAO,EAAE,qDAAqD;QAC9D,QAAQ,EAAE,MAAe;KAC1B;IACD;QACE,gDAAgD;QAChD,KAAK,EAAE,iDAAiD;QACxD,IAAI,EAAE,qBAAqB;QAC3B,OAAO,EAAE,yDAAyD;QAClE,QAAQ,EAAE,MAAe;KAC1B;CACF,CAAC;AAEF,gBAAgB;AAChB,MAAM,aAAa,GAAG,IAAA,8BAAc,EAAC,iCAAiB,EAAE;IACtD,cAAc;IACd,OAAO;IACP,MAAM;IACN,MAAM;IACN,WAAW;IACX,WAAW;IACX,WAAW;CACZ,CAAC,CAAC;AAEH,SAAS,UAAU,CAAC,QAAgB;IAClC,MAAM,UAAU,GAAG,QAAQ,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC;IAChD,OAAO,aAAa,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE;QACpC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;YAC5B,OAAO,UAAU,CAAC,QAAQ,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;QAC/C,CAAC;QACD,OAAO,UAAU,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC;IACtC,CAAC,CAAC,CAAC;AACL,CAAC;AAED,SAAS,UAAU,CAAC,QAAgB;IAClC,IAAI,CAAC;QACH,MAAM,MAAM,GAAG,IAAA,wBAAQ,EAAC,+BAA+B,QAAQ,GAAG,EAAE;YAClE,QAAQ,EAAE,OAAO;YACjB,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,QAAQ,CAAC;SAClC,CAAC,CAAC,IAAI,EAAE,CAAC;QACV,IAAI,CAAC,MAAM;YAAE,OAAO,IAAI,CAAC;QACzB,MAAM,SAAS,GAAG,QAAQ,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;QACvC,MAAM,GAAG,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,IAAI,CAAC;QAC9B,OAAO,IAAI,CAAC,KAAK,CAAC,CAAC,GAAG,GAAG,SAAS,CAAC,GAAG,CAAC,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO;IAChE,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,IAAI,CAAC;IACd,CAAC;AACH,CAAC;AAED,SAAS,kBAAkB,CAAC,QAAgB;IAC1C,IAAI,CAAC;QACH,MAAM,MAAM,GAAG,IAAA,wBAAQ,EAAC,kCAAkC,QAAQ,uBAAuB,EAAE;YACzF,QAAQ,EAAE,OAAO;YACjB,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,QAAQ,CAAC;SAClC,CAAC,CAAC,IAAI,EAAE,CAAC;QACV,IAAI,CAAC,MAAM;YAAE,OAAO,IAAI,CAAC;QACzB,MAAM,SAAS,GAAG,QAAQ,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;QACvC,MAAM,GAAG,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,IAAI,CAAC;QAC9B,OAAO,IAAI,CAAC,KAAK,CAAC,CAAC,GAAG,GAAG,SAAS,CAAC,GAAG,CAAC,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO;IAChE,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,IAAI,CAAC;IACd,CAAC;AACH,CAAC;AAED,KAAK,UAAU,QAAQ,CAAC,QAAgB;IACtC,IAAI,UAAU,CAAC,QAAQ,CAAC;QAAE,OAAO;IAEjC,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;IACnD,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAElC,qBAAqB;IACrB,KAAK,MAAM,OAAO,IAAI,aAAa,EAAE,CAAC;QACpC,IAAI,KAAK,CAAC;QACV,MAAM,KAAK,GAAG,IAAI,MAAM,CAAC,OAAO,CAAC,KAAK,CAAC,MAAM,EAAE,OAAO,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QAEpE,OAAO,CAAC,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;YAC9C,MAAM,QAAQ,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YAC1B,MAAM,WAAW,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC;YAClD,MAAM,UAAU,GAAG,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC;YAElD,MAAM,IAAI,GAAgB;gBACxB,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE,UAAU;gBAChB,IAAI,EAAE,OAAO,CAAC,IAAI;aACnB,CAAC;YAEF,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,CAAC;gBAC9B,UAAU,CAAC,GAAG,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC;YAC/B,CAAC;YACD,UAAU,CAAC,GAAG,CAAC,QAAQ,CAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACvC,CAAC;IACH,CAAC;IAED,4BAA4B;IAC5B,KAAK,MAAM,OAAO,IAAI,gBAAgB,EAAE,CAAC;QACvC,IAAI,KAAK,CAAC;QACV,MAAM,KAAK,GAAG,IAAI,MAAM,CAAC,OAAO,CAAC,KAAK,CAAC,MAAM,EAAE,OAAO,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QAEpE,OAAO,CAAC,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;YAC9C,MAAM,QAAQ,GAAG,KAAK,CAAC,CAAC,CAAC,IAAI,SAAS,CAAC;YACvC,MAAM,WAAW,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC;YAClD,MAAM,UAAU,GAAG,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC;YAElD,gBAAgB;YAChB,MAAM,IAAI,GAAG,KAAK,CAAC,UAAU,GAAG,CAAC,CAAC,IAAI,EAAE,CAAC;YACzC,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,IAAI,KAAK,WAAW,EAAE,CAAC;gBACjE,SAAS;YACX,CAAC;YAED,MAAM,CAAC,IAAI,CAAC;gBACV,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE,UAAU;gBAChB,QAAQ,EAAE,OAAO,CAAC,QAAQ;gBAC1B,IAAI,EAAE,OAAO,CAAC,IAAI;gBAClB,OAAO,EAAE,OAAO,CAAC,OAAO;aACzB,CAAC,CAAC;QACL,CAAC;IACH,CAAC;AACH,CAAC;AAED,KAAK,UAAU,mBAAmB;IAChC,iDAAiD;IACjD,MAAM,cAAc,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,cAAc,CAAC,CAAC;IAChE,IAAI,UAAU,GAAG,EAAE,CAAC;IACpB,IAAI,EAAE,CAAC,UAAU,CAAC,cAAc,CAAC,EAAE,CAAC;QAClC,UAAU,GAAG,EAAE,CAAC,YAAY,CAAC,cAAc,EAAE,OAAO,CAAC,CAAC;IACxD,CAAC;IAED,KAAK,MAAM,CAAC,QAAQ,EAAE,MAAM,CAAC,IAAI,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC;QAClE,4BAA4B;QAC5B,MAAM,SAAS,GAAG,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,KAAK,CAAC,CAAC;QACzD,IAAI,SAAS,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QAErC,MAAM,UAAU,GAAG,WAAW,QAAQ,EAAE,CAAC;QACzC,MAAM,aAAa,GAAG,uBAAuB,QAAQ,EAAE,CAAC;QAExD,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,aAAa,CAAC,EAAE,CAAC;YAC5E,MAAM,CAAC,IAAI,CAAC;gBACV,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI;gBACvB,IAAI,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI;gBACvB,QAAQ,EAAE,SAAS;gBACnB,IAAI,EAAE,wBAAwB;gBAC9B,OAAO,EAAE,gBAAgB,UAAU,uCAAuC;aAC3E,CAAC,CAAC;QACL,CAAC;IACH,CAAC;AACH,CAAC;AAED,KAAK,UAAU,eAAe;IAC5B,MAAM,oBAAoB,GAAG,EAAE,CAAC;IAEhC,KAAK,MAAM,CAAC,QAAQ,EAAE,MAAM,CAAC,IAAI,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC;QAClE,MAAM,GAAG,GAAG,kBAAkB,CAAC,QAAQ,CAAC,CAAC;QACzC,IAAI,GAAG,KAAK,IAAI,IAAI,GAAG,GAAG,oBAAoB,EAAE,CAAC;YAC/C,MAAM,CAAC,IAAI,CAAC;gBACV,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,IAAI;gBACpB,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,IAAI;gBACpB,QAAQ,EAAE,MAAM;gBAChB,IAAI,EAAE,YAAY;gBAClB,OAAO,EAAE,mBAAmB,GAAG,eAAe,oBAAoB,sBAAsB;aACzF,CAAC,CAAC;QACL,CAAC;IACH,CAAC;AACH,CAAC;AAED,KAAK,UAAU,IAAI;IACjB,MAAM,QAAQ,GAAG,IAAA,6DAA+B,EAAC,IAAI,CAAC,QAAQ,CAAC,UAAU,EAAE,KAAK,CAAC,CAAC,CAAC;IACnF,MAAM,OAAO,GAAG,OAAO,CAAC,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,IAAI,OAAO,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAClF,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC;IAEjD,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,IAAI,uBAAuB,CAAC,CAAC;IACpD,OAAO,CAAC,GAAG,CAAC,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAExC,MAAM,KAAK,GAAG,MAAM,sBAAS,CAAC,eAAe,EAAE,CAAC;IAEhD,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,MAAM,QAAQ,CAAC,IAAI,CAAC,CAAC;IACvB,CAAC;IAED,oBAAoB;IACpB,MAAM,mBAAmB,EAAE,CAAC;IAC5B,MAAM,eAAe,EAAE,CAAC;IAExB,cAAc;IACd,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;IAC/B,MAAM,YAAY,GAAG,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE;QACvC,MAAM,GAAG,GAAG,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC;QAC5C,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAO,KAAK,CAAC;QAChC,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;QACd,OAAO,IAAI,CAAC;IACd,CAAC,CAAC,CAAC;IAEH,MAAM,MAAM,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC;IAClE,MAAM,QAAQ,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC;IACtE,MAAM,KAAK,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,MAAM,CAAC,CAAC;IAEhE,UAAU;IACV,OAAO,CAAC,GAAG,CAAC,0BAA0B,UAAU,CAAC,IAAI,EAAE,CAAC,CAAC;IACzD,IAAI,OAAO,EAAE,CAAC;QACZ,KAAK,MAAM,CAAC,IAAI,EAAE,MAAM,CAAC,IAAI,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC;YAC9D,OAAO,CAAC,GAAG,CAAC,MAAM,IAAI,KAAK,MAAM,CAAC,MAAM,WAAW,CAAC,CAAC;QACvD,CAAC;IACH,CAAC;IAED,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC5B,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACtB,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,KAAK,UAAU,CAAC,CAAC;YACxC,MAAM,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;gBACvB,OAAO,CAAC,GAAG,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,KAAK,CAAC,IAAI,KAAK,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;gBAC9D,OAAO,CAAC,GAAG,CAAC,eAAe,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC;gBACzC,OAAO,CAAC,GAAG,CAAC,SAAS,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;YACxC,CAAC,CAAC,CAAC;QACL,CAAC;QAED,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACxB,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,OAAO,aAAa,CAAC,CAAC;YAC7C,QAAQ,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;gBACtC,OAAO,CAAC,GAAG,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,KAAK,CAAC,IAAI,KAAK,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC;gBAC9D,OAAO,CAAC,GAAG,CAAC,eAAe,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC;gBACzC,OAAO,CAAC,GAAG,CAAC,SAAS,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;YACxC,CAAC,CAAC,CAAC;YACH,IAAI,QAAQ,CAAC,MAAM,GAAG,EAAE,EAAE,CAAC;gBACzB,OAAO,CAAC,GAAG,CAAC,cAAc,QAAQ,CAAC,MAAM,GAAG,EAAE,gBAAgB,CAAC,CAAC;YAClE,CAAC;QACH,CAAC;QAED,IAAI,OAAO,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAChC,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,IAAI,QAAQ,CAAC,CAAC;YACrC,KAAK,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;gBACnC,OAAO,CAAC,GAAG,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,KAAK,CAAC,IAAI,MAAM,KAAK,CAAC,IAAI,KAAK,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;YAClF,CAAC,CAAC,CAAC;YACH,IAAI,KAAK,CAAC,MAAM,GAAG,EAAE,EAAE,CAAC;gBACtB,OAAO,CAAC,GAAG,CAAC,cAAc,KAAK,CAAC,MAAM,GAAG,EAAE,OAAO,CAAC,CAAC;YACtD,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,kBAAkB,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC;IAC9C,OAAO,CAAC,GAAG,CAAC,kBAAkB,UAAU,CAAC,IAAI,EAAE,CAAC,CAAC;IACjD,OAAO,CAAC,GAAG,CACT,WAAW,YAAY,CAAC,MAAM,KAAK,MAAM,CAAC,MAAM,YAAY,QAAQ,CAAC,MAAM,YAAY,CACxF,CAAC;IAEF,0BAA0B;IAC1B,IAAI,MAAM,IAAI,CAAC,MAAM,CAAC,MAAM,GAAG,CAAC,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,EAAE,CAAC;QACzD,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,KAAK,4CAA4C,CAAC,CAAC;QAC1E,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,qBAAK,CAAC,IAAI,GAAG,iBAAiB,CAAC,CAAC;QACnD,OAAO,CAAC,GAAG,CAAC,wCAAwC,CAAC,CAAC;QACtD,OAAO,CAAC,GAAG,CAAC,6CAA6C,CAAC,CAAC;QAC3D,OAAO,CAAC,GAAG,CAAC,wCAAwC,CAAC,CAAC;QACtD,OAAO,CAAC,GAAG,CAAC,sCAAsC,CAAC,CAAC;QACpD,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC5C,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,OAAO,mDAAmD,CAAC,CAAC;QACnF,OAAO,CAAC,GAAG,CAAC,4CAA4C,CAAC,CAAC;IAC5D,CAAC;SAAM,CAAC;QACN,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,OAAO,8BAA8B,CAAC,CAAC;IAChE,CAAC;AACH,CAAC;AAED,IAAI,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC"}

package/dist/checks/code-quality/grading-config-usage.d.ts

@@ -0,0 +1,29 @@
+#!/usr/bin/env tsx
+/**
+ * Grading Config Usage Preflight
+ *
+ * Ensures the centralized grading config (lib/grading/grading-config.ts) is used
+ * consistently across the codebase. Detects:
+ *
+ * 1. Hardcoded grade validation that should use the config
+ * 2. Hardcoded grading company lists that might drift
+ * 3. Magic numbers for grade min/max values
+ *
+ * Usage:
+ *   pnpm tsx scripts/active/preflights/code-quality/grading-config-usage.ts
+ */
+export declare const id = "code-quality/grading-config-usage";
+export declare const name = "Grading Config Usage";
+export declare const description = "Ensures centralized grading config is used consistently";
+export declare const category = "code-quality";
+export declare const blocking = true;
+export declare const tags: string[];
+interface Violation {
+    file: string;
+    line: number;
+    issue: string;
+    snippet: string;
+}
+declare function detectViolations(): Promise<Violation[]>;
+export { detectViolations };
+//# sourceMappingURL=grading-config-usage.d.ts.map

package/dist/checks/code-quality/grading-config-usage.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"grading-config-usage.d.ts","sourceRoot":"","sources":["../../../src/checks/code-quality/grading-config-usage.ts"],"names":[],"mappings":";AACA;;;;;;;;;;;;GAYG;AAMH,eAAO,MAAM,EAAE,sCAAsC,CAAC;AACtD,eAAO,MAAM,IAAI,yBAAyB,CAAC;AAC3C,eAAO,MAAM,WAAW,4DAA4D,CAAC;AACrF,eAAO,MAAM,QAAQ,iBAAiB,CAAC;AACvC,eAAO,MAAM,QAAQ,OAAO,CAAC;AAC7B,eAAO,MAAM,IAAI,UAA0D,CAAC;AAW5E,UAAU,SAAS;IACjB,IAAI,EAAE,MAAM,CAAC;IACb,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,EAAE,MAAM,CAAC;IACd,OAAO,EAAE,MAAM,CAAC;CACjB;AA+CD,iBAAe,gBAAgB,IAAI,OAAO,CAAC,SAAS,EAAE,CAAC,CAiEtD;AA0DD,OAAO,EAAE,gBAAgB,EAAE,CAAC"}

package/dist/checks/code-quality/grading-config-usage.js

@@ -0,0 +1,210 @@
+#!/usr/bin/env tsx
+"use strict";
+/**
+ * Grading Config Usage Preflight
+ *
+ * Ensures the centralized grading config (lib/grading/grading-config.ts) is used
+ * consistently across the codebase. Detects:
+ *
+ * 1. Hardcoded grade validation that should use the config
+ * 2. Hardcoded grading company lists that might drift
+ * 3. Magic numbers for grade min/max values
+ *
+ * Usage:
+ *   pnpm tsx scripts/active/preflights/code-quality/grading-config-usage.ts
+ */
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.tags = exports.blocking = exports.category = exports.description = exports.name = exports.id = void 0;
+exports.detectViolations = detectViolations;
+// =============================================================================
+// METADATA
+// =============================================================================
+exports.id = "code-quality/grading-config-usage";
+exports.name = "Grading Config Usage";
+exports.description = "Ensures centralized grading config is used consistently";
+exports.category = "code-quality";
+exports.blocking = true;
+exports.tags = ["code-quality", "grading", "centralization", "config"];
+// =============================================================================
+// IMPLEMENTATION
+// =============================================================================
+const fs = __importStar(require("fs"));
+const path = __importStar(require("path"));
+const console_chars_js_1 = require("../../utils/console-chars.js");
+const file_cache_js_1 = require("../../shared/file-cache.js");
+// Patterns that indicate hardcoded grading logic
+const HARDCODED_PATTERNS = [
+    // Hardcoded grade ranges
+    { pattern: /grade\s*[<>=]+\s*10(?!\d)/gi, issue: "Hardcoded max grade (10)" },
+    { pattern: /grade\s*[<>=]+\s*100(?!\d)/gi, issue: "Hardcoded VGA max grade (100)" },
+    // Hardcoded grading company arrays (not in the config file)
+    {
+        pattern: /\[\s*["']PSA["']\s*,\s*["']BGS["']/gi,
+        issue: "Hardcoded grading company list - use getGradingCompaniesForProductType()",
+    },
+    {
+        pattern: /\[\s*["']WATA["']\s*,\s*["']VGA["']/gi,
+        issue: "Hardcoded video game grader list - use getGradingCompaniesForProductType()",
+    },
+    // Hardcoded half-grade logic
+    {
+        pattern: /allowsHalfGrades\s*[=:]\s*(true|false)/gi,
+        issue: "Hardcoded half-grade setting - should come from grading config",
+    },
+    // Hardcoded valid grades arrays
+    {
+        pattern: /validGrades\s*[=:]\s*\[[\d\s,\.]+\]/gi,
+        issue: "Hardcoded valid grades array - should come from grading config",
+    },
+    // Hardcoded step values for grades
+    {
+        pattern: /step\s*[=:]\s*0\.5.*grade/gi,
+        issue: "Hardcoded grade step value - should come from grading config",
+    },
+];
+// Files that are allowed to have these patterns (the config itself, tests, etc.)
+const ALLOWED_FILES = [
+    "grading-config.ts",
+    "grading-config-usage.ts", // This preflight
+    ".test.ts",
+    ".spec.ts",
+    "__mocks__",
+    "__tests__",
+];
+async function detectViolations() {
+    const violations = [];
+    // Scan component and lib files
+    const componentFiles = await file_cache_js_1.fileCache.getComponentFiles();
+    const libFiles = await file_cache_js_1.fileCache.getLibFiles();
+    const allFiles = [...componentFiles, ...libFiles];
+    for (const file of allFiles) {
+        const relativePath = path.relative(process.cwd(), file);
+        // Skip allowed files
+        if (ALLOWED_FILES.some((allowed) => relativePath.includes(allowed))) {
+            continue;
+        }
+        const content = fs.readFileSync(file, "utf8");
+        const lines = content.split("\n");
+        // Check each pattern
+        for (const { pattern, issue } of HARDCODED_PATTERNS) {
+            // Reset regex state
+            pattern.lastIndex = 0;
+            let match;
+            while ((match = pattern.exec(content)) !== null) {
+                // Find line number
+                const beforeMatch = content.slice(0, match.index);
+                const lineNum = beforeMatch.split("\n").length;
+                const snippet = lines[lineNum - 1]?.trim() || "";
+                // Skip if this file imports from grading-config (it's using the config)
+                if (content.includes('from "@/lib/grading/grading-config"') ||
+                    content.includes("from '@/lib/grading/grading-config'")) {
+                    // Still flag if they're defining their own hardcoded values
+                    if (!snippet.includes("getGrading") && !snippet.includes("autoCorrect")) {
+                        violations.push({
+                            file: relativePath,
+                            line: lineNum,
+                            issue,
+                            snippet: snippet.slice(0, 100),
+                        });
+                    }
+                }
+                else {
+                    violations.push({
+                        file: relativePath,
+                        line: lineNum,
+                        issue,
+                        snippet: snippet.slice(0, 100),
+                    });
+                }
+            }
+        }
+    }
+    // Deduplicate
+    const seen = new Set();
+    return violations.filter((v) => {
+        const key = `${v.file}:${v.line}:${v.issue}`;
+        if (seen.has(key))
+            return false;
+        seen.add(key);
+        return true;
+    });
+}
+function printResults(violations) {
+    console.log("\n" + (0, console_chars_js_1.createDivider)(70, "heavy"));
+    console.log("  GRADING CONFIG USAGE CHECK");
+    console.log((0, console_chars_js_1.createDivider)(70, "heavy") + "\n");
+    if (violations.length === 0) {
+        console.log(`  ${console_chars_js_1.emoji.success} No hardcoded grading logic detected\n`);
+        console.log("  All grading validation uses the centralized config.\n");
+        return;
+    }
+    console.log(`  ${console_chars_js_1.emoji.warning} Found ${violations.length} potential issues:\n`);
+    for (const v of violations) {
+        console.log(`  ${console_chars_js_1.emoji.file} ${v.file}:${v.line}`);
+        console.log(`     Issue: ${v.issue}`);
+        console.log(`     Code: ${v.snippet}\n`);
+    }
+    console.log("  " + (0, console_chars_js_1.createDivider)(66, "light"));
+    console.log("  RECOMMENDATION:");
+    console.log("  " + (0, console_chars_js_1.createDivider)(66, "light"));
+    console.log("  Use the centralized grading config:");
+    console.log("    import { getGradingConfig, autoCorrectGrade } from '@/lib/grading/grading-config';");
+    console.log("  This ensures consistent validation across all grading companies.\n");
+}
+async function main() {
+    const args = process.argv.slice(2);
+    const warnOnly = args.includes("--warn");
+    console.log(`\n${console_chars_js_1.emoji.search} Checking grading config usage...`);
+    const startTime = Date.now();
+    const violations = await detectViolations();
+    const duration = ((Date.now() - startTime) / 1000).toFixed(1);
+    printResults(violations);
+    console.log((0, console_chars_js_1.createDivider)(70, "heavy"));
+    console.log(`  Duration: ${duration}s | Issues found: ${violations.length}`);
+    console.log((0, console_chars_js_1.createDivider)(70, "heavy") + "\n");
+    // This is a WARNING preflight, not blocking
+    // Hardcoded values might be intentional in some cases
+    if (violations.length > 0) {
+        console.log(`${console_chars_js_1.emoji.warning} Potential hardcoded grading logic found (review recommended)\n`);
+        process.exit(0); // Warning only, don't block
+    }
+    else {
+        console.log(`${console_chars_js_1.emoji.success} Grading config usage check passed\n`);
+        process.exit(0);
+    }
+}
+main().catch(console.error);
+//# sourceMappingURL=grading-config-usage.js.map

package/dist/checks/code-quality/grading-config-usage.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"grading-config-usage.js","sourceRoot":"","sources":["../../../src/checks/code-quality/grading-config-usage.ts"],"names":[],"mappings":";;AACA;;;;;;;;;;;;GAYG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAqMM,4CAAgB;AAnMzB,gFAAgF;AAChF,WAAW;AACX,gFAAgF;AAEnE,QAAA,EAAE,GAAG,mCAAmC,CAAC;AACzC,QAAA,IAAI,GAAG,sBAAsB,CAAC;AAC9B,QAAA,WAAW,GAAG,yDAAyD,CAAC;AACxE,QAAA,QAAQ,GAAG,cAAc,CAAC;AAC1B,QAAA,QAAQ,GAAG,IAAI,CAAC;AAChB,QAAA,IAAI,GAAG,CAAC,cAAc,EAAE,SAAS,EAAE,gBAAgB,EAAE,QAAQ,CAAC,CAAC;AAE5E,gFAAgF;AAChF,iBAAiB;AACjB,gFAAgF;AAEhF,uCAAyB;AACzB,2CAA6B;AAC7B,mEAAoE;AACpE,8DAAuD;AASvD,iDAAiD;AACjD,MAAM,kBAAkB,GAAG;IACzB,yBAAyB;IACzB,EAAE,OAAO,EAAE,6BAA6B,EAAE,KAAK,EAAE,0BAA0B,EAAE;IAC7E,EAAE,OAAO,EAAE,8BAA8B,EAAE,KAAK,EAAE,+BAA+B,EAAE;IAEnF,4DAA4D;IAC5D;QACE,OAAO,EAAE,sCAAsC;QAC/C,KAAK,EAAE,0EAA0E;KAClF;IACD;QACE,OAAO,EAAE,uCAAuC;QAChD,KAAK,EAAE,4EAA4E;KACpF;IAED,6BAA6B;IAC7B;QACE,OAAO,EAAE,0CAA0C;QACnD,KAAK,EAAE,gEAAgE;KACxE;IAED,gCAAgC;IAChC;QACE,OAAO,EAAE,uCAAuC;QAChD,KAAK,EAAE,gEAAgE;KACxE;IAED,mCAAmC;IACnC;QACE,OAAO,EAAE,6BAA6B;QACtC,KAAK,EAAE,8DAA8D;KACtE;CACF,CAAC;AAEF,iFAAiF;AACjF,MAAM,aAAa,GAAG;IACpB,mBAAmB;IACnB,yBAAyB,EAAE,iBAAiB;IAC5C,UAAU;IACV,UAAU;IACV,WAAW;IACX,WAAW;CACZ,CAAC;AAEF,KAAK,UAAU,gBAAgB;IAC7B,MAAM,UAAU,GAAgB,EAAE,CAAC;IAEnC,+BAA+B;IAC/B,MAAM,cAAc,GAAG,MAAM,yBAAS,CAAC,iBAAiB,EAAE,CAAC;IAC3D,MAAM,QAAQ,GAAG,MAAM,yBAAS,CAAC,WAAW,EAAE,CAAC;IAC/C,MAAM,QAAQ,GAAG,CAAC,GAAG,cAAc,EAAE,GAAG,QAAQ,CAAC,CAAC;IAElD,KAAK,MAAM,IAAI,IAAI,QAAQ,EAAE,CAAC;QAC5B,MAAM,YAAY,GAAG,IAAI,CAAC,QAAQ,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,IAAI,CAAC,CAAC;QAExD,qBAAqB;QACrB,IAAI,aAAa,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC,EAAE,CAAC;YACpE,SAAS;QACX,CAAC;QAED,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;QAC9C,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QAElC,qBAAqB;QACrB,KAAK,MAAM,EAAE,OAAO,EAAE,KAAK,EAAE,IAAI,kBAAkB,EAAE,CAAC;YACpD,oBAAoB;YACpB,OAAO,CAAC,SAAS,GAAG,CAAC,CAAC;YAEtB,IAAI,KAAK,CAAC;YACV,OAAO,CAAC,KAAK,GAAG,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;gBAChD,mBAAmB;gBACnB,MAAM,WAAW,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC;gBAClD,MAAM,OAAO,GAAG,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC;gBAC/C,MAAM,OAAO,GAAG,KAAK,CAAC,OAAO,GAAG,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;gBAEjD,wEAAwE;gBACxE,IACE,OAAO,CAAC,QAAQ,CAAC,qCAAqC,CAAC;oBACvD,OAAO,CAAC,QAAQ,CAAC,qCAAqC,CAAC,EACvD,CAAC;oBACD,4DAA4D;oBAC5D,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,YAAY,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,aAAa,CAAC,EAAE,CAAC;wBACxE,UAAU,CAAC,IAAI,CAAC;4BACd,IAAI,EAAE,YAAY;4BAClB,IAAI,EAAE,OAAO;4BACb,KAAK;4BACL,OAAO,EAAE,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC;yBAC/B,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;qBAAM,CAAC;oBACN,UAAU,CAAC,IAAI,CAAC;wBACd,IAAI,EAAE,YAAY;wBAClB,IAAI,EAAE,OAAO;wBACb,KAAK;wBACL,OAAO,EAAE,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC;qBAC/B,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,cAAc;IACd,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;IAC/B,OAAO,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE;QAC7B,MAAM,GAAG,GAAG,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,KAAK,EAAE,CAAC;QAC7C,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAO,KAAK,CAAC;QAChC,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;QACd,OAAO,IAAI,CAAC;IACd,CAAC,CAAC,CAAC;AACL,CAAC;AAED,SAAS,YAAY,CAAC,UAAuB;IAC3C,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,IAAA,gCAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,8BAA8B,CAAC,CAAC;IAC5C,OAAO,CAAC,GAAG,CAAC,IAAA,gCAAa,EAAC,EAAE,EAAE,OAAO,CAAC,GAAG,IAAI,CAAC,CAAC;IAE/C,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC5B,OAAO,CAAC,GAAG,CAAC,KAAK,wBAAK,CAAC,OAAO,wCAAwC,CAAC,CAAC;QACxE,OAAO,CAAC,GAAG,CAAC,yDAAyD,CAAC,CAAC;QACvE,OAAO;IACT,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,KAAK,wBAAK,CAAC,OAAO,UAAU,UAAU,CAAC,MAAM,sBAAsB,CAAC,CAAC;IAEjF,KAAK,MAAM,CAAC,IAAI,UAAU,EAAE,CAAC;QAC3B,OAAO,CAAC,GAAG,CAAC,KAAK,wBAAK,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;QACnD,OAAO,CAAC,GAAG,CAAC,eAAe,CAAC,CAAC,KAAK,EAAE,CAAC,CAAC;QACtC,OAAO,CAAC,GAAG,CAAC,cAAc,CAAC,CAAC,OAAO,IAAI,CAAC,CAAC;IAC3C,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,IAAA,gCAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,mBAAmB,CAAC,CAAC;IACjC,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,IAAA,gCAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,uCAAuC,CAAC,CAAC;IACrD,OAAO,CAAC,GAAG,CAAC,wFAAwF,CAAC,CAAC;IACtG,OAAO,CAAC,GAAG,CAAC,sEAAsE,CAAC,CAAC;AACtF,CAAC;AAED,KAAK,UAAU,IAAI;IACjB,MAAM,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IACnC,MAAM,QAAQ,GAAG,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC;IAEzC,OAAO,CAAC,GAAG,CAAC,KAAK,wBAAK,CAAC,MAAM,mCAAmC,CAAC,CAAC;IAElE,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;IAC7B,MAAM,UAAU,GAAG,MAAM,gBAAgB,EAAE,CAAC;IAC5C,MAAM,QAAQ,GAAG,CAAC,CAAC,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS,CAAC,GAAG,IAAI,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC;IAE9D,YAAY,CAAC,UAAU,CAAC,CAAC;IAEzB,OAAO,CAAC,GAAG,CAAC,IAAA,gCAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IACxC,OAAO,CAAC,GAAG,CAAC,eAAe,QAAQ,qBAAqB,UAAU,CAAC,MAAM,EAAE,CAAC,CAAC;IAC7E,OAAO,CAAC,GAAG,CAAC,IAAA,gCAAa,EAAC,EAAE,EAAE,OAAO,CAAC,GAAG,IAAI,CAAC,CAAC;IAE/C,4CAA4C;IAC5C,sDAAsD;IACtD,IAAI,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC1B,OAAO,CAAC,GAAG,CAAC,GAAG,wBAAK,CAAC,OAAO,iEAAiE,CAAC,CAAC;QAC/F,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,4BAA4B;IAC/C,CAAC;SAAM,CAAC;QACN,OAAO,CAAC,GAAG,CAAC,GAAG,wBAAK,CAAC,OAAO,sCAAsC,CAAC,CAAC;QACpE,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;AACH,CAAC;AAED,IAAI,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC"}

package/dist/checks/code-quality/legacy-data-pattern-detection.d.ts

@@ -0,0 +1,36 @@
+#!/usr/bin/env tsx
+/**
+ * Legacy Data Pattern Detection Preflight
+ *
+ * Detects patterns that indicate lingering legacy/migration code that should
+ * be cleaned up after data migrations are complete.
+ *
+ * Patterns detected:
+ * 1. Fallback chains (newField || legacyField, newField ?? oldField)
+ * 2. Dual-write patterns (writing to both old and new fields)
+ * 3. Deprecated field access (reading columns marked for removal)
+ * 4. Migration compatibility shims
+ * 5. Temporary backwards compatibility code
+ *
+ * Why this matters:
+ * - Legacy patterns accumulate technical debt
+ * - Dual-writes waste database resources
+ * - Old field access prevents schema cleanup
+ * - Fallback chains mask data quality issues
+ *
+ * Usage:
+ *   pnpm preflight:legacy-data
+ *   pnpm preflight:legacy-data --verbose
+ *   pnpm preflight:legacy-data --strict  (fail on any match)
+ *
+ * BLOCKING: No (informational by default)
+ */
+export declare const id = "code-quality/legacy-data-pattern-detection";
+export declare const name = "Legacy Data Pattern Detection";
+export declare const description = "Detects lingering legacy/migration code patterns";
+export declare const category = "code-quality";
+export declare const blocking = false;
+export declare const tags: string[];
+declare function main(): Promise<void>;
+export { main as run };
+//# sourceMappingURL=legacy-data-pattern-detection.d.ts.map

package/dist/checks/code-quality/legacy-data-pattern-detection.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"legacy-data-pattern-detection.d.ts","sourceRoot":"","sources":["../../../src/checks/code-quality/legacy-data-pattern-detection.ts"],"names":[],"mappings":";AACA;;;;;;;;;;;;;;;;;;;;;;;;;GAyBG;AAYH,eAAO,MAAM,EAAE,+CAA+C,CAAC;AAC/D,eAAO,MAAM,IAAI,kCAAkC,CAAC;AACpD,eAAO,MAAM,WAAW,qDAAqD,CAAC;AAC9E,eAAO,MAAM,QAAQ,iBAAiB,CAAC;AACvC,eAAO,MAAM,QAAQ,QAAQ,CAAC;AAC9B,eAAO,MAAM,IAAI,UAA6D,CAAC;AA6U/E,iBAAe,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC,CAkHnC;AAUD,OAAO,EAAE,IAAI,IAAI,GAAG,EAAE,CAAC"}