@empline/preflight 1.0.20

package/dist/checks/code-quality/legacy-data-pattern-detection.js

@@ -0,0 +1,450 @@
+#!/usr/bin/env tsx
+"use strict";
+/**
+ * Legacy Data Pattern Detection Preflight
+ *
+ * Detects patterns that indicate lingering legacy/migration code that should
+ * be cleaned up after data migrations are complete.
+ *
+ * Patterns detected:
+ * 1. Fallback chains (newField || legacyField, newField ?? oldField)
+ * 2. Dual-write patterns (writing to both old and new fields)
+ * 3. Deprecated field access (reading columns marked for removal)
+ * 4. Migration compatibility shims
+ * 5. Temporary backwards compatibility code
+ *
+ * Why this matters:
+ * - Legacy patterns accumulate technical debt
+ * - Dual-writes waste database resources
+ * - Old field access prevents schema cleanup
+ * - Fallback chains mask data quality issues
+ *
+ * Usage:
+ *   pnpm preflight:legacy-data
+ *   pnpm preflight:legacy-data --verbose
+ *   pnpm preflight:legacy-data --strict  (fail on any match)
+ *
+ * BLOCKING: No (informational by default)
+ */
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.tags = exports.blocking = exports.category = exports.description = exports.name = exports.id = void 0;
+exports.run = main;
+const fs = __importStar(require("fs"));
+const glob_1 = require("glob");
+const path = __importStar(require("path"));
+const console_chars_1 = require("../../utils/console-chars");
+const glob_patterns_1 = require("../../shared/glob-patterns");
+// =============================================================================
+// METADATA
+// =============================================================================
+exports.id = "code-quality/legacy-data-pattern-detection";
+exports.name = "Legacy Data Pattern Detection";
+exports.description = "Detects lingering legacy/migration code patterns";
+exports.category = "code-quality";
+exports.blocking = false;
+exports.tags = ["code-quality", "migration", "cleanup", "technical-debt"];
+// =============================================================================
+// CONFIGURATION
+// =============================================================================
+// Common legacy field naming patterns
+const LEGACY_FIELD_PATTERNS = [
+    // Explicit legacy/old naming
+    /\b(legacy|old|deprecated|previous|former|v1|_old|_legacy|_deprecated)\w*/i,
+    // Migration naming
+    /\b(migrated|migration|temp|temporary|compat|compatibility)\w*/i,
+];
+// Known deprecated fields (customize per project)
+// These can be extended via config file
+const KNOWN_DEPRECATED_FIELDS = [
+    // Add project-specific deprecated fields here
+    "legacyId",
+    "deprecatedField",
+    "v1Data",
+    "_backup",
+];
+// Fields that LOOK like legacy patterns but are legitimate current fields
+// These will be excluded from detection
+const LEGITIMATE_FIELD_PATTERNS = [
+    // Audit/history fields (tracking old values is intentional)
+    /\.oldValue$/i,
+    /\.oldValues$/i,
+    /\.oldData$/i,
+    /\.oldStatus$/i,
+    /\.oldPrice$/i, // Price tracking feature
+    /\.previousValue$/i,
+    /\.previousQuantity$/i,
+    /\.previousLabel$/i,
+    /\.previousAttempts$/i, // Retry tracking
+    /\.previousGuess$/i, // AI/ML iteration tracking
+    // Template system (not legacy, actual current fields)
+    /\.template$/i,
+    /\.templates$/i,
+    /\.templateType$/i,
+    /\.templateTypes$/i,
+    /\.templateCard$/i,
+    /\.templateFormat$/i,
+    /\.templateRegistry$/i,
+    /\.templateLoading$/i,
+    // Sorting enum values
+    /\.OLDEST_FIRST$/i,
+    // Migration feature (legitimate use for data migration UI)
+    /\.migratedPair/i,
+    /\.migratedPairs/i,
+    // Temporary storage metrics (intentional naming)
+    /\.temporaryStorage/i,
+    // ID prefixes (intentional naming)
+    /\.TEMPLATE$/i,
+    // eBay integration (legitimate field)
+    /\.legacyItemId$/i, // eBay uses this naming
+];
+// Patterns that indicate fallback chains
+// More specific patterns to reduce false positives
+const FALLBACK_PATTERNS = [
+    // Property access fallbacks: newData.field || legacyData.field
+    {
+        pattern: /\.\w+\s*\|\|\s*\w+\.(?:legacy|old|deprecated|_old|v1)\w*/gi,
+        type: "fallback-chain",
+        message: "Fallback to legacy field property",
+    },
+    // Variable fallbacks: newField || legacyField (but not boolean checks like !oldValue ||)
+    {
+        pattern: /(?<![!])\b(\w+)\s*\|\|\s*(legacy\w*|deprecated\w*|_old\w*|v1\w*)\b/gi,
+        type: "fallback-chain",
+        message: "Fallback to legacy variable",
+    },
+    // ?? null coalesce with legacy naming (property access)
+    {
+        pattern: /\.\w+\s*\?\?\s*\w+\.(?:legacy|old|deprecated|_old|v1)\w*/gi,
+        type: "null-coalesce-legacy",
+        message: "Null coalesce fallback to legacy property",
+    },
+    // ?? null coalesce with legacy variable
+    {
+        pattern: /(?<![!])\b(\w+)\s*\?\?\s*(legacy\w*|deprecated\w*|_old\w*|v1\w*)\b/gi,
+        type: "null-coalesce-legacy",
+        message: "Null coalesce fallback to legacy variable",
+    },
+];
+// Patterns that indicate dual-writes
+const DUAL_WRITE_PATTERNS = [
+    // Setting both old and new fields
+    {
+        pattern: /(\w+)\s*=.*;\s*\n?\s*\1(?:_old|_legacy|Legacy|Old)\s*=/gm,
+        type: "dual-write",
+        message: "Dual-write to old and new fields",
+    },
+    // Explicit dual-write comments
+    {
+        pattern: /\/\/\s*(?:dual.?write|write.?both|also.?(?:write|update).?(?:legacy|old))/gi,
+        type: "dual-write",
+        message: "Commented dual-write pattern",
+    },
+];
+// Patterns that indicate backwards compatibility code
+const COMPAT_PATTERNS = [
+    // Explicit backwards compat comments
+    {
+        pattern: /\/\/\s*(?:backwards?.?compat|legacy.?support|for.?backwards|migration.?compat)/gi,
+        type: "backwards-compat",
+        message: "Backwards compatibility comment",
+    },
+    // TODO: remove after migration comments
+    {
+        pattern: /\/\/\s*(?:TODO|FIXME).*(?:remove|delete|cleanup).*(?:migration|legacy|old)/gi,
+        type: "migration-shim",
+        message: "Migration cleanup TODO",
+    },
+    // Temporary migration code
+    {
+        pattern: /\/\/\s*(?:TEMP|TEMPORARY).*(?:migration|until|legacy)/gi,
+        type: "migration-shim",
+        message: "Temporary migration code",
+    },
+];
+// Paths to scan
+const SCAN_PATHS = [
+    "app/**/*.{ts,tsx}",
+    "components/**/*.{ts,tsx}",
+    "lib/**/*.{ts,tsx}",
+    "hooks/**/*.{ts,tsx}",
+    "services/**/*.{ts,tsx}",
+    "utils/**/*.{ts,tsx}",
+];
+const EXCLUDED = [
+    ...glob_patterns_1.STANDARD_EXCLUDES,
+    "**/migrations/**",
+    "**/seeds/**",
+    "**/*.test.ts",
+    "**/*.test.tsx",
+    "**/*.spec.ts",
+    "**/*.d.ts",
+];
+// =============================================================================
+// DETECTION FUNCTIONS
+// =============================================================================
+function detectFallbackChains(file, content, lines) {
+    const patterns = [];
+    lines.forEach((line, index) => {
+        const trimmed = line.trim();
+        // Skip comments
+        if (trimmed.startsWith("//") || trimmed.startsWith("*"))
+            return;
+        // Skip if marked to ignore
+        if (trimmed.includes("preflight-ignore") || trimmed.includes("legacy-ok"))
+            return;
+        for (const { pattern, type, message } of FALLBACK_PATTERNS) {
+            // Reset regex state
+            pattern.lastIndex = 0;
+            const match = pattern.exec(line);
+            if (match) {
+                patterns.push({
+                    file,
+                    line: index + 1,
+                    type,
+                    severity: "warning",
+                    message,
+                    snippet: trimmed.substring(0, 100),
+                    suggestion: "Remove fallback once migration is complete",
+                });
+            }
+        }
+    });
+    return patterns;
+}
+function detectDualWrites(file, content, lines) {
+    const patterns = [];
+    // Check for dual-write patterns in full content (multiline)
+    for (const { pattern, type, message } of DUAL_WRITE_PATTERNS) {
+        pattern.lastIndex = 0;
+        let match;
+        while ((match = pattern.exec(content)) !== null) {
+            // Find line number
+            const beforeMatch = content.substring(0, match.index);
+            const lineNum = beforeMatch.split("\n").length;
+            patterns.push({
+                file,
+                line: lineNum,
+                type,
+                severity: "warning",
+                message,
+                snippet: match[0].substring(0, 80),
+                suggestion: "Remove dual-write after migration verification",
+            });
+        }
+    }
+    return patterns;
+}
+function isLegitimateField(fieldAccess) {
+    return LEGITIMATE_FIELD_PATTERNS.some((pattern) => pattern.test(fieldAccess));
+}
+function detectDeprecatedFieldAccess(file, content, lines) {
+    const patterns = [];
+    lines.forEach((line, index) => {
+        const trimmed = line.trim();
+        if (trimmed.startsWith("//") || trimmed.startsWith("*"))
+            return;
+        if (trimmed.includes("preflight-ignore"))
+            return;
+        // Check for known deprecated fields
+        for (const field of KNOWN_DEPRECATED_FIELDS) {
+            if (line.includes(field) && !isLegitimateField(`.${field}`)) {
+                patterns.push({
+                    file,
+                    line: index + 1,
+                    type: "deprecated-field",
+                    severity: "info",
+                    message: `Access to deprecated field: ${field}`,
+                    snippet: trimmed.substring(0, 100),
+                    suggestion: "Update to use current field name",
+                });
+            }
+        }
+        // Check for legacy field patterns in property access
+        for (const pattern of LEGACY_FIELD_PATTERNS) {
+            // Only flag property access patterns like .legacyField or ['legacyField']
+            const accessPattern = new RegExp(`\\.${pattern.source}|\\[['"](${pattern.source})['"]]`, "gi");
+            const match = accessPattern.exec(line);
+            if (match) {
+                // Don't flag if it's a legitimate current field
+                if (isLegitimateField(match[0]))
+                    continue;
+                // Don't flag if it's a type/interface definition
+                if (/(?:interface|type)\s+\w+/.test(line))
+                    continue;
+                // Don't flag if it's in a string/comment
+                if (/['"`].*(?:legacy|old|deprecated).*['"`]/.test(line))
+                    continue;
+                patterns.push({
+                    file,
+                    line: index + 1,
+                    type: "deprecated-field",
+                    severity: "info",
+                    message: `Potential legacy field access: ${match[0]}`,
+                    snippet: trimmed.substring(0, 100),
+                    suggestion: "Verify if this field should be migrated",
+                });
+            }
+        }
+    });
+    return patterns;
+}
+function detectCompatPatterns(file, content, lines) {
+    const patterns = [];
+    lines.forEach((line, index) => {
+        for (const { pattern, type, message } of COMPAT_PATTERNS) {
+            pattern.lastIndex = 0;
+            if (pattern.test(line)) {
+                patterns.push({
+                    file,
+                    line: index + 1,
+                    type,
+                    severity: type === "migration-shim" ? "warning" : "info",
+                    message,
+                    snippet: line.trim().substring(0, 100),
+                    suggestion: "Review and remove after migration completion",
+                });
+            }
+        }
+    });
+    return patterns;
+}
+// =============================================================================
+// MAIN FUNCTION
+// =============================================================================
+async function main() {
+    const args = process.argv.slice(2);
+    const verbose = args.includes("--verbose") || args.includes("-v");
+    const strict = args.includes("--strict");
+    console.log(`\n${console_chars_1.emoji.search} Legacy Data Pattern Detection\n`);
+    console.log("Scanning for legacy/migration patterns that may need cleanup...\n");
+    // Gather files
+    let allFiles = [];
+    for (const pattern of SCAN_PATHS) {
+        const files = await (0, glob_1.glob)(pattern, { ignore: EXCLUDED });
+        allFiles.push(...files);
+    }
+    allFiles = [...new Set(allFiles)];
+    console.log(`Scanning ${allFiles.length} files...\n`);
+    const allPatterns = [];
+    for (const file of allFiles) {
+        const content = fs.readFileSync(file, "utf-8");
+        const lines = content.split("\n");
+        const relativePath = path.relative(process.cwd(), file);
+        allPatterns.push(...detectFallbackChains(relativePath, content, lines));
+        allPatterns.push(...detectDualWrites(relativePath, content, lines));
+        allPatterns.push(...detectDeprecatedFieldAccess(relativePath, content, lines));
+        allPatterns.push(...detectCompatPatterns(relativePath, content, lines));
+    }
+    // Group by type
+    const byType = new Map();
+    for (const pattern of allPatterns) {
+        if (!byType.has(pattern.type)) {
+            byType.set(pattern.type, []);
+        }
+        byType.get(pattern.type).push(pattern);
+    }
+    // Report
+    console.log((0, console_chars_1.createDivider)(70, "heavy"));
+    if (allPatterns.length === 0) {
+        console.log(`\n${console_chars_1.emoji.success} No legacy data patterns detected!\n`);
+        process.exit(0);
+    }
+    const warnings = allPatterns.filter((p) => p.severity === "warning");
+    const infos = allPatterns.filter((p) => p.severity === "info");
+    // Print by type
+    const typeLabels = {
+        "fallback-chain": "Fallback Chains (|| legacy)",
+        "dual-write": "Dual-Write Patterns",
+        "deprecated-field": "Deprecated Field Access",
+        "migration-shim": "Migration Shims",
+        "null-coalesce-legacy": "Null Coalesce Legacy (?? old)",
+        "backwards-compat": "Backwards Compatibility Code",
+    };
+    for (const [type, patterns] of byType) {
+        if (patterns.length === 0)
+            continue;
+        const icon = patterns.some((p) => p.severity === "warning")
+            ? console_chars_1.emoji.warning
+            : console_chars_1.emoji.info;
+        console.log(`\n${icon} ${typeLabels[type]} (${patterns.length}):\n`);
+        // Group by file
+        const byFile = new Map();
+        for (const p of patterns) {
+            if (!byFile.has(p.file)) {
+                byFile.set(p.file, []);
+            }
+            byFile.get(p.file).push(p);
+        }
+        for (const [file, filePatterns] of byFile) {
+            console.log(`  ${console_chars_1.emoji.file} ${file}`);
+            for (const p of filePatterns) {
+                console.log(`     Line ${p.line}: ${p.message}`);
+                if (verbose) {
+                    console.log(`       ${p.snippet}`);
+                    if (p.suggestion) {
+                        console.log(`       ${console_chars_1.emoji.hint} ${p.suggestion}`);
+                    }
+                }
+            }
+        }
+    }
+    console.log("\n" + (0, console_chars_1.createDivider)(70, "heavy"));
+    console.log(`\n${console_chars_1.emoji.chart} Summary:`);
+    console.log(`   Warnings: ${warnings.length}`);
+    console.log(`   Info: ${infos.length}`);
+    console.log(`   Total: ${allPatterns.length}`);
+    // Type breakdown
+    console.log(`\n   By Type:`);
+    for (const [type, patterns] of byType) {
+        if (patterns.length > 0) {
+            console.log(`     ${typeLabels[type]}: ${patterns.length}`);
+        }
+    }
+    if (strict && allPatterns.length > 0) {
+        console.log(`\n${console_chars_1.emoji.error} FAILED (strict mode - legacy patterns found)\n`);
+        process.exit(1);
+    }
+    console.log(`\n${console_chars_1.emoji.success} PASSED (${allPatterns.length} legacy patterns found for review)\n`);
+    console.log("These patterns are informational. Review and clean up after migrations.\n");
+}
+// Run if executed directly
+if (require.main === module) {
+    main().catch((error) => {
+        console.error("Preflight error:", error);
+        process.exit(1);
+    });
+}
+//# sourceMappingURL=legacy-data-pattern-detection.js.map

package/dist/checks/code-quality/legacy-data-pattern-detection.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"legacy-data-pattern-detection.js","sourceRoot":"","sources":["../../../src/checks/code-quality/legacy-data-pattern-detection.ts"],"names":[],"mappings":";;AACA;;;;;;;;;;;;;;;;;;;;;;;;;GAyBG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AA0dc,mBAAG;AAxdpB,uCAAyB;AACzB,+BAA4B;AAC5B,2CAA6B;AAC7B,6DAAiE;AACjE,8DAA+D;AAE/D,gFAAgF;AAChF,WAAW;AACX,gFAAgF;AAEnE,QAAA,EAAE,GAAG,4CAA4C,CAAC;AAClD,QAAA,IAAI,GAAG,+BAA+B,CAAC;AACvC,QAAA,WAAW,GAAG,kDAAkD,CAAC;AACjE,QAAA,QAAQ,GAAG,cAAc,CAAC;AAC1B,QAAA,QAAQ,GAAG,KAAK,CAAC;AACjB,QAAA,IAAI,GAAG,CAAC,cAAc,EAAE,WAAW,EAAE,SAAS,EAAE,gBAAgB,CAAC,CAAC;AAwB/E,gFAAgF;AAChF,gBAAgB;AAChB,gFAAgF;AAEhF,sCAAsC;AACtC,MAAM,qBAAqB,GAAG;IAC5B,6BAA6B;IAC7B,2EAA2E;IAC3E,mBAAmB;IACnB,gEAAgE;CACjE,CAAC;AAEF,kDAAkD;AAClD,wCAAwC;AACxC,MAAM,uBAAuB,GAAG;IAC9B,8CAA8C;IAC9C,UAAU;IACV,iBAAiB;IACjB,QAAQ;IACR,SAAS;CACV,CAAC;AAEF,0EAA0E;AAC1E,wCAAwC;AACxC,MAAM,yBAAyB,GAAG;IAChC,4DAA4D;IAC5D,cAAc;IACd,eAAe;IACf,aAAa;IACb,eAAe;IACf,cAAc,EAAE,yBAAyB;IACzC,mBAAmB;IACnB,sBAAsB;IACtB,mBAAmB;IACnB,sBAAsB,EAAE,iBAAiB;IACzC,mBAAmB,EAAE,2BAA2B;IAChD,sDAAsD;IACtD,cAAc;IACd,eAAe;IACf,kBAAkB;IAClB,mBAAmB;IACnB,kBAAkB;IAClB,oBAAoB;IACpB,sBAAsB;IACtB,qBAAqB;IACrB,sBAAsB;IACtB,kBAAkB;IAClB,2DAA2D;IAC3D,iBAAiB;IACjB,kBAAkB;IAClB,iDAAiD;IACjD,qBAAqB;IACrB,mCAAmC;IACnC,cAAc;IACd,sCAAsC;IACtC,kBAAkB,EAAE,wBAAwB;CAC7C,CAAC;AAEF,yCAAyC;AACzC,mDAAmD;AACnD,MAAM,iBAAiB,GAAG;IACxB,+DAA+D;IAC/D;QACE,OAAO,EAAE,4DAA4D;QACrE,IAAI,EAAE,gBAAyB;QAC/B,OAAO,EAAE,mCAAmC;KAC7C;IACD,yFAAyF;IACzF;QACE,OAAO,EAAE,sEAAsE;QAC/E,IAAI,EAAE,gBAAyB;QAC/B,OAAO,EAAE,6BAA6B;KACvC;IACD,wDAAwD;IACxD;QACE,OAAO,EAAE,4DAA4D;QACrE,IAAI,EAAE,sBAA+B;QACrC,OAAO,EAAE,2CAA2C;KACrD;IACD,wCAAwC;IACxC;QACE,OAAO,EAAE,sEAAsE;QAC/E,IAAI,EAAE,sBAA+B;QACrC,OAAO,EAAE,2CAA2C;KACrD;CACF,CAAC;AAEF,qCAAqC;AACrC,MAAM,mBAAmB,GAAG;IAC1B,kCAAkC;IAClC;QACE,OAAO,EAAE,0DAA0D;QACnE,IAAI,EAAE,YAAqB;QAC3B,OAAO,EAAE,kCAAkC;KAC5C;IACD,+BAA+B;IAC/B;QACE,OAAO,EAAE,6EAA6E;QACtF,IAAI,EAAE,YAAqB;QAC3B,OAAO,EAAE,8BAA8B;KACxC;CACF,CAAC;AAEF,sDAAsD;AACtD,MAAM,eAAe,GAAG;IACtB,qCAAqC;IACrC;QACE,OAAO,EAAE,kFAAkF;QAC3F,IAAI,EAAE,kBAA2B;QACjC,OAAO,EAAE,iCAAiC;KAC3C;IACD,wCAAwC;IACxC;QACE,OAAO,EAAE,8EAA8E;QACvF,IAAI,EAAE,gBAAyB;QAC/B,OAAO,EAAE,wBAAwB;KAClC;IACD,2BAA2B;IAC3B;QACE,OAAO,EAAE,yDAAyD;QAClE,IAAI,EAAE,gBAAyB;QAC/B,OAAO,EAAE,0BAA0B;KACpC;CACF,CAAC;AAEF,gBAAgB;AAChB,MAAM,UAAU,GAAG;IACjB,mBAAmB;IACnB,0BAA0B;IAC1B,mBAAmB;IACnB,qBAAqB;IACrB,wBAAwB;IACxB,qBAAqB;CACtB,CAAC;AAEF,MAAM,QAAQ,GAAG;IACf,GAAG,iCAAiB;IACpB,kBAAkB;IAClB,aAAa;IACb,cAAc;IACd,eAAe;IACf,cAAc;IACd,WAAW;CACZ,CAAC;AAEF,gFAAgF;AAChF,sBAAsB;AACtB,gFAAgF;AAEhF,SAAS,oBAAoB,CAC3B,IAAY,EACZ,OAAe,EACf,KAAe;IAEf,MAAM,QAAQ,GAAoB,EAAE,CAAC;IAErC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE;QAC5B,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;QAC5B,gBAAgB;QAChB,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC;YAAE,OAAO;QAChE,2BAA2B;QAC3B,IAAI,OAAO,CAAC,QAAQ,CAAC,kBAAkB,CAAC,IAAI,OAAO,CAAC,QAAQ,CAAC,WAAW,CAAC;YAAE,OAAO;QAElF,KAAK,MAAM,EAAE,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,IAAI,iBAAiB,EAAE,CAAC;YAC3D,oBAAoB;YACpB,OAAO,CAAC,SAAS,GAAG,CAAC,CAAC;YACtB,MAAM,KAAK,GAAG,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACjC,IAAI,KAAK,EAAE,CAAC;gBACV,QAAQ,CAAC,IAAI,CAAC;oBACZ,IAAI;oBACJ,IAAI,EAAE,KAAK,GAAG,CAAC;oBACf,IAAI;oBACJ,QAAQ,EAAE,SAAS;oBACnB,OAAO;oBACP,OAAO,EAAE,OAAO,CAAC,SAAS,CAAC,CAAC,EAAE,GAAG,CAAC;oBAClC,UAAU,EAAE,4CAA4C;iBACzD,CAAC,CAAC;YACL,CAAC;QACH,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,SAAS,gBAAgB,CACvB,IAAY,EACZ,OAAe,EACf,KAAe;IAEf,MAAM,QAAQ,GAAoB,EAAE,CAAC;IAErC,4DAA4D;IAC5D,KAAK,MAAM,EAAE,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,IAAI,mBAAmB,EAAE,CAAC;QAC7D,OAAO,CAAC,SAAS,GAAG,CAAC,CAAC;QACtB,IAAI,KAAK,CAAC;QACV,OAAO,CAAC,KAAK,GAAG,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;YAChD,mBAAmB;YACnB,MAAM,WAAW,GAAG,OAAO,CAAC,SAAS,CAAC,CAAC,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC;YACtD,MAAM,OAAO,GAAG,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC;YAE/C,QAAQ,CAAC,IAAI,CAAC;gBACZ,IAAI;gBACJ,IAAI,EAAE,OAAO;gBACb,IAAI;gBACJ,QAAQ,EAAE,SAAS;gBACnB,OAAO;gBACP,OAAO,EAAE,KAAK,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,EAAE,EAAE,CAAC;gBAClC,UAAU,EAAE,gDAAgD;aAC7D,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,SAAS,iBAAiB,CAAC,WAAmB;IAC5C,OAAO,yBAAyB,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,CAAC;AAChF,CAAC;AAED,SAAS,2BAA2B,CAClC,IAAY,EACZ,OAAe,EACf,KAAe;IAEf,MAAM,QAAQ,GAAoB,EAAE,CAAC;IAErC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE;QAC5B,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;QAC5B,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC;YAAE,OAAO;QAChE,IAAI,OAAO,CAAC,QAAQ,CAAC,kBAAkB,CAAC;YAAE,OAAO;QAEjD,oCAAoC;QACpC,KAAK,MAAM,KAAK,IAAI,uBAAuB,EAAE,CAAC;YAC5C,IAAI,IAAI,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,CAAC,iBAAiB,CAAC,IAAI,KAAK,EAAE,CAAC,EAAE,CAAC;gBAC5D,QAAQ,CAAC,IAAI,CAAC;oBACZ,IAAI;oBACJ,IAAI,EAAE,KAAK,GAAG,CAAC;oBACf,IAAI,EAAE,kBAAkB;oBACxB,QAAQ,EAAE,MAAM;oBAChB,OAAO,EAAE,+BAA+B,KAAK,EAAE;oBAC/C,OAAO,EAAE,OAAO,CAAC,SAAS,CAAC,CAAC,EAAE,GAAG,CAAC;oBAClC,UAAU,EAAE,kCAAkC;iBAC/C,CAAC,CAAC;YACL,CAAC;QACH,CAAC;QAED,qDAAqD;QACrD,KAAK,MAAM,OAAO,IAAI,qBAAqB,EAAE,CAAC;YAC5C,0EAA0E;YAC1E,MAAM,aAAa,GAAG,IAAI,MAAM,CAC9B,MAAM,OAAO,CAAC,MAAM,YAAY,OAAO,CAAC,MAAM,QAAQ,EACtD,IAAI,CACL,CAAC;YACF,MAAM,KAAK,GAAG,aAAa,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACvC,IAAI,KAAK,EAAE,CAAC;gBACV,gDAAgD;gBAChD,IAAI,iBAAiB,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;oBAAE,SAAS;gBAC1C,iDAAiD;gBACjD,IAAI,0BAA0B,CAAC,IAAI,CAAC,IAAI,CAAC;oBAAE,SAAS;gBACpD,yCAAyC;gBACzC,IAAI,yCAAyC,CAAC,IAAI,CAAC,IAAI,CAAC;oBAAE,SAAS;gBAEnE,QAAQ,CAAC,IAAI,CAAC;oBACZ,IAAI;oBACJ,IAAI,EAAE,KAAK,GAAG,CAAC;oBACf,IAAI,EAAE,kBAAkB;oBACxB,QAAQ,EAAE,MAAM;oBAChB,OAAO,EAAE,kCAAkC,KAAK,CAAC,CAAC,CAAC,EAAE;oBACrD,OAAO,EAAE,OAAO,CAAC,SAAS,CAAC,CAAC,EAAE,GAAG,CAAC;oBAClC,UAAU,EAAE,yCAAyC;iBACtD,CAAC,CAAC;YACL,CAAC;QACH,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,SAAS,oBAAoB,CAC3B,IAAY,EACZ,OAAe,EACf,KAAe;IAEf,MAAM,QAAQ,GAAoB,EAAE,CAAC;IAErC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE;QAC5B,KAAK,MAAM,EAAE,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,IAAI,eAAe,EAAE,CAAC;YACzD,OAAO,CAAC,SAAS,GAAG,CAAC,CAAC;YACtB,IAAI,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;gBACvB,QAAQ,CAAC,IAAI,CAAC;oBACZ,IAAI;oBACJ,IAAI,EAAE,KAAK,GAAG,CAAC;oBACf,IAAI;oBACJ,QAAQ,EAAE,IAAI,KAAK,gBAAgB,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,MAAM;oBACxD,OAAO;oBACP,OAAO,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC,SAAS,CAAC,CAAC,EAAE,GAAG,CAAC;oBACtC,UAAU,EAAE,8CAA8C;iBAC3D,CAAC,CAAC;YACL,CAAC;QACH,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,gFAAgF;AAChF,gBAAgB;AAChB,gFAAgF;AAEhF,KAAK,UAAU,IAAI;IACjB,MAAM,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IACnC,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;IAClE,MAAM,MAAM,GAAG,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC;IAEzC,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,MAAM,kCAAkC,CAAC,CAAC;IACjE,OAAO,CAAC,GAAG,CAAC,mEAAmE,CAAC,CAAC;IAEjF,eAAe;IACf,IAAI,QAAQ,GAAa,EAAE,CAAC;IAC5B,KAAK,MAAM,OAAO,IAAI,UAAU,EAAE,CAAC;QACjC,MAAM,KAAK,GAAG,MAAM,IAAA,WAAI,EAAC,OAAO,EAAE,EAAE,MAAM,EAAE,QAAQ,EAAE,CAAC,CAAC;QACxD,QAAQ,CAAC,IAAI,CAAC,GAAG,KAAK,CAAC,CAAC;IAC1B,CAAC;IACD,QAAQ,GAAG,CAAC,GAAG,IAAI,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC;IAElC,OAAO,CAAC,GAAG,CAAC,YAAY,QAAQ,CAAC,MAAM,aAAa,CAAC,CAAC;IAEtD,MAAM,WAAW,GAAoB,EAAE,CAAC;IAExC,KAAK,MAAM,IAAI,IAAI,QAAQ,EAAE,CAAC;QAC5B,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC;QAC/C,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QAClC,MAAM,YAAY,GAAG,IAAI,CAAC,QAAQ,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,IAAI,CAAC,CAAC;QAExD,WAAW,CAAC,IAAI,CAAC,GAAG,oBAAoB,CAAC,YAAY,EAAE,OAAO,EAAE,KAAK,CAAC,CAAC,CAAC;QACxE,WAAW,CAAC,IAAI,CAAC,GAAG,gBAAgB,CAAC,YAAY,EAAE,OAAO,EAAE,KAAK,CAAC,CAAC,CAAC;QACpE,WAAW,CAAC,IAAI,CAAC,GAAG,2BAA2B,CAAC,YAAY,EAAE,OAAO,EAAE,KAAK,CAAC,CAAC,CAAC;QAC/E,WAAW,CAAC,IAAI,CAAC,GAAG,oBAAoB,CAAC,YAAY,EAAE,OAAO,EAAE,KAAK,CAAC,CAAC,CAAC;IAC1E,CAAC;IAED,gBAAgB;IAChB,MAAM,MAAM,GAAG,IAAI,GAAG,EAAsC,CAAC;IAC7D,KAAK,MAAM,OAAO,IAAI,WAAW,EAAE,CAAC;QAClC,IAAI,CAAC,MAAM,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;YAC9B,MAAM,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;QAC/B,CAAC;QACD,MAAM,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAE,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IAC1C,CAAC;IAED,SAAS;IACT,OAAO,CAAC,GAAG,CAAC,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAExC,IAAI,WAAW,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC7B,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,OAAO,sCAAsC,CAAC,CAAC;QACtE,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,MAAM,QAAQ,GAAG,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC;IACrE,MAAM,KAAK,GAAG,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,MAAM,CAAC,CAAC;IAE/D,gBAAgB;IAChB,MAAM,UAAU,GAAsC;QACpD,gBAAgB,EAAE,6BAA6B;QAC/C,YAAY,EAAE,qBAAqB;QACnC,kBAAkB,EAAE,yBAAyB;QAC7C,gBAAgB,EAAE,iBAAiB;QACnC,sBAAsB,EAAE,+BAA+B;QACvD,kBAAkB,EAAE,8BAA8B;KACnD,CAAC;IAEF,KAAK,MAAM,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,MAAM,EAAE,CAAC;QACtC,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QAEpC,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,SAAS,CAAC;YACzD,CAAC,CAAC,qBAAK,CAAC,OAAO;YACf,CAAC,CAAC,qBAAK,CAAC,IAAI,CAAC;QAEf,OAAO,CAAC,GAAG,CAAC,KAAK,IAAI,IAAI,UAAU,CAAC,IAAI,CAAC,KAAK,QAAQ,CAAC,MAAM,MAAM,CAAC,CAAC;QAErE,gBAAgB;QAChB,MAAM,MAAM,GAAG,IAAI,GAAG,EAA2B,CAAC;QAClD,KAAK,MAAM,CAAC,IAAI,QAAQ,EAAE,CAAC;YACzB,IAAI,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC;gBACxB,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;YACzB,CAAC;YACD,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAE,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAC9B,CAAC;QAED,KAAK,MAAM,CAAC,IAAI,EAAE,YAAY,CAAC,IAAI,MAAM,EAAE,CAAC;YAC1C,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,IAAI,IAAI,IAAI,EAAE,CAAC,CAAC;YACvC,KAAK,MAAM,CAAC,IAAI,YAAY,EAAE,CAAC;gBAC7B,OAAO,CAAC,GAAG,CAAC,aAAa,CAAC,CAAC,IAAI,KAAK,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;gBACjD,IAAI,OAAO,EAAE,CAAC;oBACZ,OAAO,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;oBACnC,IAAI,CAAC,CAAC,UAAU,EAAE,CAAC;wBACjB,OAAO,CAAC,GAAG,CAAC,UAAU,qBAAK,CAAC,IAAI,IAAI,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC;oBACtD,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,IAAI,GAAG,IAAA,6BAAa,EAAC,EAAE,EAAE,OAAO,CAAC,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,KAAK,WAAW,CAAC,CAAC;IACzC,OAAO,CAAC,GAAG,CAAC,gBAAgB,QAAQ,CAAC,MAAM,EAAE,CAAC,CAAC;IAC/C,OAAO,CAAC,GAAG,CAAC,YAAY,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC;IACxC,OAAO,CAAC,GAAG,CAAC,aAAa,WAAW,CAAC,MAAM,EAAE,CAAC,CAAC;IAE/C,iBAAiB;IACjB,OAAO,CAAC,GAAG,CAAC,eAAe,CAAC,CAAC;IAC7B,KAAK,MAAM,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,MAAM,EAAE,CAAC;QACtC,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACxB,OAAO,CAAC,GAAG,CAAC,QAAQ,UAAU,CAAC,IAAI,CAAC,KAAK,QAAQ,CAAC,MAAM,EAAE,CAAC,CAAC;QAC9D,CAAC;IACH,CAAC;IAED,IAAI,MAAM,IAAI,WAAW,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACrC,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,KAAK,iDAAiD,CAAC,CAAC;QAC/E,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IAED,OAAO,CAAC,GAAG,CAAC,KAAK,qBAAK,CAAC,OAAO,YAAY,WAAW,CAAC,MAAM,sCAAsC,CAAC,CAAC;IACpG,OAAO,CAAC,GAAG,CAAC,2EAA2E,CAAC,CAAC;AAC3F,CAAC;AAED,2BAA2B;AAC3B,IAAI,OAAO,CAAC,IAAI,KAAK,MAAM,EAAE,CAAC;IAC5B,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC,KAAK,EAAE,EAAE;QACrB,OAAO,CAAC,KAAK,CAAC,kBAAkB,EAAE,KAAK,CAAC,CAAC;QACzC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC,CAAC,CAAC;AACL,CAAC"}

package/dist/checks/code-quality/magic-number-detection.d.ts

@@ -0,0 +1,30 @@
+#!/usr/bin/env tsx
+/**
+ * Magic Number Detection Preflight (NON-BLOCKING)
+ *
+ * Detects hardcoded "magic numbers" that should be named constants.
+ * Magic numbers reduce code readability and make maintenance difficult.
+ *
+ * Patterns detected:
+ * - Hardcoded timeouts (setTimeout/setInterval with raw numbers)
+ * - Hardcoded limits (pagination, array slices)
+ * - Hardcoded dimensions (width, height, size)
+ * - Hardcoded business values (prices, percentages, thresholds)
+ *
+ * Allowed patterns:
+ * - 0, 1, -1 (common programming idioms)
+ * - Numbers in comments
+ * - Numbers in test files
+ * - Numbers assigned to named constants
+ *
+ * Usage:
+ *   pnpm preflight:magic-numbers
+ *   pnpm preflight:magic-numbers --verbose
+ */
+export declare const id = "code-quality/magic-number-detection";
+export declare const name = "Magic Number Detection";
+export declare const category = "code-quality";
+export declare const blocking = false;
+export declare const description = "Magic Number Detection Preflight (NON-BLOCKING)";
+export declare const tags: string[];
+//# sourceMappingURL=magic-number-detection.d.ts.map

package/dist/checks/code-quality/magic-number-detection.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"magic-number-detection.d.ts","sourceRoot":"","sources":["../../../src/checks/code-quality/magic-number-detection.ts"],"names":[],"mappings":";AACA;;;;;;;;;;;;;;;;;;;;;GAqBG;AAWH,eAAO,MAAM,EAAE,wCAAwC,CAAC;AACxD,eAAO,MAAM,IAAI,2BAA2B,CAAC;AAC7C,eAAO,MAAM,QAAQ,iBAAiB,CAAC;AACvC,eAAO,MAAM,QAAQ,QAAQ,CAAC;AAC9B,eAAO,MAAM,WAAW,oDAAoD,CAAC;AAC7E,eAAO,MAAM,IAAI,UAAmB,CAAC"}