@eifi1/ui-kit 0.53.0 → 0.55.0

package/src/feedback/feedback-vocabulary.ts

@@ -1,263 +0,0 @@
-import {
-  Ban,
-  Bug,
-  CheckCircle2,
-  ClipboardCheck,
-  CloudUpload,
-  Eye,
-  HelpCircle,
-  Inbox,
-  Lightbulb,
-  MoreHorizontal,
-  OctagonAlert,
-  PauseCircle,
-  RotateCcw,
-  Wrench,
-} from "lucide-react";
-import type { LucideIcon } from "lucide-react";
-
-/**
- * The feedback **vocabulary**: the nine statuses and five categories, the glyph and tone
- * of each, their orders, and the policy for how a report moves from status to status.
- *
- * Data and plain functions, no components. Until 0.34 this lived at the top of
- * feedback-inbox.tsx, so the feedback menu every app mounts in its top bar imported the
- * inbox — its components and the attachment field they render — for one constant (a
- * category's glyph), and only tree-shaking kept the rest out of every app's entry chunk.
- * From here the top bar's imports reach none of it (MOD-1, refactor audit 2026-10).
- * feedback-inbox.tsx re-exports every name here, so nothing an app imports has moved.
- */
-
-/** The nine states a report can be in.
- *
- *  Shared value for value across the apps on purpose: it is what lets one habit,
- *  and one agent prompt, work on any repo. Five are a chain and three sit off
- *  it — see {@link visibleFeedbackStatuses} for what that buys. `READY` joined in 0.31
- *  (feedback contract §8.2): OPEN is "filed, not yet triaged", READY "released for
- *  implementation", and nobody works an OPEN row. `REWORK` joined in 0.40 (§10.2
- *  decisions 2, 4): "sent back, released for work again" — a READY that came back. */
-export type FeedbackStatus =
-  "OPEN" | "READY" | "REWORK" | "IN_PROGRESS" | "IN_EVALUATION" | "NEEDS_LIVE_TEST" | "POSTPONED" | "DONE" | "WONT_DO";
-
-/** What a report is about. `CRASH` is filed by an error boundary and never
- *  chosen, which is exactly why it is loud below and absent from every picker. */
-export type FeedbackCategory = "CRASH" | "BUG" | "IDEA" | "QUESTION" | "OTHER";
-
-/**
- * A glyph and a tone per status.
- *
- * Colour alone is not a label — two of these sit a hue apart, and a consumer who
- * moves `--brand` can park it beside any of the others — so every status carries
- * its own shape as well. Declaration order is chain order, and
- * {@link FEEDBACK_STATUS_ORDER} is derived from it rather than restated, because
- * a restated list cannot be checked for exhaustiveness: an eighth status would
- * break the build here and leave a literal eight long (as READY did in 0.31).
- */
-export const FEEDBACK_STATUS_META: Record<FeedbackStatus, { icon: LucideIcon; activeBg: string; activeText: string }> =
-  {
-    OPEN: {
-      icon: Inbox,
-      activeBg: "bg-active",
-      activeText: "text-primary",
-    },
-    // Triaged and released for implementation (feedback contract §8.2, keksdose live
-    // #396): OPEN is "filed, nobody has looked yet", READY is "go". The brand tint at full
-    // strength, so it reads as the go-ahead beside OPEN's neutral fill and
-    // NEEDS_LIVE_TEST's muted brand.
-    READY: {
-      icon: ClipboardCheck,
-      activeBg: "bg-brand-soft",
-      activeText: "text-brand",
-    },
-    // Sent back by its author or an admin and released for work again (0.40, feedback
-    // contract §10.2 decision 4): the Rework button's `RotateCcw`, in the danger tint so the
-    // queue shows reworks apart from new reports. Not IN_PROGRESS's warning tint — that is
-    // where a REWORK row moves next — and WONT_DO, the only other red, sits at the far end
-    // with `Ban`.
-    REWORK: {
-      icon: RotateCcw,
-      activeBg: "bg-danger-soft",
-      activeText: "text-danger",
-    },
-    IN_PROGRESS: {
-      icon: Wrench,
-      activeBg: "bg-warning-soft",
-      activeText: "text-warning",
-    },
-    // Where solved work is parked, waiting on the person who reported it. Its own
-    // colour, because "somebody has to check this" is a state you want to find by
-    // scanning rather than by reading.
-    IN_EVALUATION: {
-      icon: Eye,
-      activeBg: "bg-info-soft",
-      activeText: "text-info",
-    },
-    // Resolved but only checkable on a deployed build — the SOFT brand tint, so it
-    // reads as "waiting on something" rather than as a done or a refusal, and it
-    // follows whatever the consumer's brand is instead of pinning an indigo island
-    // beside it.
-    NEEDS_LIVE_TEST: {
-      icon: CloudUpload,
-      activeBg: "bg-brand-soft",
-      activeText: "text-brand-muted",
-    },
-    // Parked on purpose. Muted, not `--danger`: it is not a refusal.
-    POSTPONED: {
-      icon: PauseCircle,
-      activeBg: "bg-active",
-      activeText: "text-secondary",
-    },
-    // The one status with nowhere to move to: the vocabulary has a brand, an info, a
-    // warning and a danger, and nothing that means "succeeded". Deliberately NOT
-    // borrowed from a family that means something else — `--status-synced` is a
-    // FIELD's trip to the database rather than an outcome, and tokens.css says so in
-    // as many words. Green beside WONT_DO's red is the classic CVD-unsafe pair, which
-    // is why both carry a glyph and neither leans on colour alone.
-    DONE: {
-      icon: CheckCircle2,
-      activeBg: "bg-success-soft",
-      activeText: "text-success",
-    },
-    WONT_DO: {
-      icon: Ban,
-      activeBg: "bg-danger-soft",
-      activeText: "text-danger",
-    },
-  };
-
-/** Chain order, then the three off it. The order a picker offers, and the rank a
- *  status column sorts by — so a list sorted by status reads as a queue rather
- *  than as an alphabet. */
-export const FEEDBACK_STATUS_ORDER = Object.keys(FEEDBACK_STATUS_META) as FeedbackStatus[];
-
-/** States that sit OFF the linear chain: reachable from anywhere, leading
- *  nowhere by themselves. `WONT_DO` has always worked this way; `POSTPONED`
- *  ("not now") and `NEEDS_LIVE_TEST` ("resolved, but only provable on a deployed
- *  build") are the same shape — a row can be parked or handed to the next deploy
- *  from any point, and comes back to the chain when somebody picks a real state
- *  for it.
- *
- *  Kept out of the forward chain deliberately: putting them in it would mean an
- *  "advance" gesture could park an item, and every row would have to pass
- *  through them to reach `DONE`. */
-const OFF_CHAIN: FeedbackStatus[] = ["NEEDS_LIVE_TEST", "POSTPONED", "WONT_DO"];
-
-const FORWARD_CHAIN: FeedbackStatus[] = ["OPEN", "READY", "IN_PROGRESS", "IN_EVALUATION", "DONE"];
-
-/** The next status along the chain, or null at the end (or off it, as `WONT_DO`
- *  is). What a swipe-to-advance gesture commits. `REWORK` (0.40) is not in the chain —
- *  "advance" from READY still goes to IN_PROGRESS — but it leads there too: a reworked
- *  row is READY's twin. */
-export function nextFeedbackStatus(current: FeedbackStatus): FeedbackStatus | null {
-  if (current === "REWORK") return "IN_PROGRESS";
-  const at = FORWARD_CHAIN.indexOf(current);
-  return at !== -1 && at < FORWARD_CHAIN.length - 1 ? FORWARD_CHAIN[at + 1] : null;
-}
-
-/**
- * The steps that make sense from where a row currently stands.
- *
- * For the compact control in a table cell: it is a glanceable triage affordance,
- * and a row of nine icons in a cell is noise. One step forward, one step back
- * (so an item can be sent back for rework), and any of the three off-chain
- * verdicts — which is what makes those usable as verdicts at all.
- *
- * The two parking states are not dead ends: each offers the step that resumes
- * work and the ones that close it, but deliberately **not each other** —
- * "postponed" and "waiting on a deploy" are different answers to different
- * questions, and a row moving between them directly is a re-triage, which starts
- * by picking the work back up.
- */
-export function visibleFeedbackStatuses(current: FeedbackStatus): FeedbackStatus[] {
-  const set = new Set<FeedbackStatus>([current]);
-  const at = FORWARD_CHAIN.indexOf(current);
-  if (current === "REWORK") {
-    // READY's twin (0.40, §10.2 decision 4): the step that picks the work up, and the
-    // verdicts a released row can still get.
-    set.add("IN_PROGRESS");
-    for (const off of OFF_CHAIN) set.add(off);
-  } else if (at !== -1) {
-    if (at < FORWARD_CHAIN.length - 1) set.add(FORWARD_CHAIN[at + 1]);
-    if (at > 0) set.add(FORWARD_CHAIN[at - 1]);
-    for (const off of OFF_CHAIN) set.add(off);
-  } else if (current !== "WONT_DO") {
-    set.add("IN_PROGRESS");
-    set.add("DONE");
-    set.add("WONT_DO");
-  }
-  // WONT_DO falls through with nothing added: it stays terminal, reopened by a
-  // note from its author rather than by a status pill.
-  return FEEDBACK_STATUS_ORDER.filter((status) => set.has(status));
-}
-
-/**
- * Every status, in chain order — what an EXPANDED row offers.
- *
- * {@link visibleFeedbackStatuses} narrows the choice to the steps that make
- * sense from where a row is, which is right for a table cell. Once the row is
- * open in front of you, that same narrowing turns every non-adjacent move into a
- * walk: OPEN to DONE meant three round trips, and WONT_DO could not be left at
- * all except through a rework note.
- *
- * Takes a `current` it does not use, so the two policies read as one pair at the
- * call sites and a future rule ("terminal rows still cannot jump to X") has a
- * place to live.
- */
-export function selectableFeedbackStatuses(_current: FeedbackStatus): FeedbackStatus[] {
-  return [...FEEDBACK_STATUS_ORDER];
-}
-
-/**
- * Per-category badge treatment, the counterpart to the status meta above.
- *
- * A category cell that is one grey pill holding the raw enum makes a CRASH —
- * filed automatically, by somebody staring at a broken page right now — read
- * exactly like a QUESTION, and sit unnoticed in the queue. `--danger` plus its own
- * glyph is what makes that impossible; the hand-filed categories stay
- * deliberately quiet so that the loud one means something.
- *
- * Declaration order is triage order, CRASH first.
- */
-export const FEEDBACK_CATEGORY_META: Record<
-  FeedbackCategory,
-  { icon: LucideIcon; badgeBg: string; badgeText: string }
-> = {
-  CRASH: {
-    icon: OctagonAlert,
-    badgeBg: "bg-danger-soft",
-    badgeText: "text-danger",
-  },
-  BUG: {
-    icon: Bug,
-    badgeBg: "bg-warning-soft",
-    badgeText: "text-warning",
-  },
-  IDEA: {
-    icon: Lightbulb,
-    badgeBg: "bg-surface-2",
-    badgeText: "text-secondary",
-  },
-  QUESTION: {
-    icon: HelpCircle,
-    badgeBg: "bg-surface-2",
-    badgeText: "text-secondary",
-  },
-  OTHER: {
-    icon: MoreHorizontal,
-    badgeBg: "bg-surface-2",
-    badgeText: "text-secondary",
-  },
-};
-
-/** Triage order, CRASH first — also a category column's sort key and the option
- *  order in its filter. Sorting by the raw enum is alphabetical, which parks
- *  CRASH between BUG and IDEA. */
-export const FEEDBACK_CATEGORY_ORDER = Object.keys(FEEDBACK_CATEGORY_META) as FeedbackCategory[];
-
-/** A category's rank for a column sort. Anything this build has never heard of —
- *  an older client against a newer API — sorts LAST rather than to `indexOf`'s
- *  −1, which would rank it above CRASH. */
-export function feedbackCategoryRank(category: FeedbackCategory): number {
-  const at = FEEDBACK_CATEGORY_ORDER.indexOf(category);
-  return at === -1 ? FEEDBACK_CATEGORY_ORDER.length : at;
-}

package/src/feedback/feedback-vote-button.tsx

@@ -1,124 +0,0 @@
-import { useRef, useState } from "react";
-import { ThumbsUp } from "lucide-react";
-import { Button } from "../components/button";
-import { Tooltip } from "../components/tooltip";
-import type { CommitScope } from "../components/write-lock";
-import { useKitLabels, useKitLocale, type LabelOverride } from "../i18n/kit-labels";
-import { cn } from "../lib/cn";
-import { formatNumber } from "../lib/format";
-import type { FeedbackVoteState } from "./feedback-public-types";
-import { DEFAULT_FEEDBACK_VOTE_LABELS } from "./feedback-thread-parts-labels";
-
-/**
- * "I want this too" — the one rating a report has (docs/feedback-harmonization.md §9.6,
- * decision 2): an upvote, one per person, a count. No down-vote, no stars.
- *
- * - **A toggle** (`aria-pressed`): the thumb, the count, and "I want this too" as its
- *   name — written out at `size="md"`, the Tooltip and the accessible name at `"sm"`
- *   (a list row's cell).
- * - **Optimistic with rollback:** the press shows the new state at once, `onVote(next)`
- *   sends `PUT` (`true`) or `DELETE` (`false`) and its answer — the server's count —
- *   replaces the guess; a rejection puts back what was there. The error is the app's
- *   to toast (its mutation's `onError`), as with every kit part that takes a promise —
- *   the server's `detail`, else `feedbackToast.voteFailed` (0.38.1).
- * - **The author's own report** counts as their vote (§9.6, decision 20): `own` shows it
- *   pressed and `aria-disabled` with "Your report" as the reason (the server would
- *   answer 409).
- * - A new `votes` / `voted` from the app (a refetch) wins over the last answer.
- */
-
-/** The `feedbackVote` namespace of `<UiKitProvider labels>`. */
-export interface FeedbackVoteLabels {
-  /** The button's name. de-CH: "Will ich auch" */
-  vote: string;
-  /** Why the author's own button is disabled. de-CH: "Ihr Bericht" */
-  own: string;
-}
-
-export { DEFAULT_FEEDBACK_VOTE_LABELS };
-
-export interface FeedbackVoteButtonProps {
-  /** People who want this — the author's own vote included. */
-  votes: number;
-  /** The viewer has voted. */
-  voted: boolean;
-  /** The viewer filed it: pressed, disabled, "Your report". */
-  own?: boolean;
-  /** `PUT` (`next` true) or `DELETE` (`false`) `/feedback/{id}/vote`; resolve with the
-   *  answer, reject to roll back. */
-  onVote: (next: boolean) => Promise<FeedbackVoteState>;
-  /** Not now (e.g. a demo): plain `disabled`. A string is the reason, as Button's. */
-  disabled?: boolean | string;
-  /** The vote COMMITS — see Button's `commit`. */
-  commit?: CommitScope;
-  /** `"sm"`: the count alone, for a table cell. Default `"md"`. */
-  size?: "sm" | "md";
-  labels?: LabelOverride<FeedbackVoteLabels>;
-  className?: string;
-}
-
-export function FeedbackVoteButton({
-  votes,
-  voted,
-  own = false,
-  onVote,
-  disabled = false,
-  commit,
-  size = "md",
-  labels: labelsProp,
-  className,
-}: FeedbackVoteButtonProps) {
-  const labels = useKitLabels("feedbackVote", DEFAULT_FEEDBACK_VOTE_LABELS, labelsProp);
-  const locale = useKitLocale();
-  // The last press's state, valid only while the app's props are still the ones it was
-  // pressed against: a refetch that brings new numbers is the truth.
-  const [shown, setShown] = useState<{ base: FeedbackVoteState; state: FeedbackVoteState } | null>(null);
-  const busy = useRef(false);
-  const current = shown && shown.base.votes === votes && shown.base.voted === voted ? shown.state : { votes, voted };
-  const pressed = own || current.voted;
-
-  const press = () => {
-    if (own || disabled || busy.current) return;
-    const base = { votes, voted };
-    const before = current;
-    const next = !before.voted;
-    busy.current = true;
-    setShown({ base, state: { votes: Math.max(0, before.votes + (next ? 1 : -1)), voted: next } });
-    onVote(next)
-      .then(
-        (answer) => setShown({ base, state: { votes: answer.votes, voted: answer.voted } }),
-        () => setShown({ base, state: before }),
-      )
-      .finally(() => {
-        busy.current = false;
-      });
-  };
-
-  const count = formatNumber(current.votes, { locale });
-  const button = (
-    <Button
-      type="button"
-      variant="secondary"
-      size="sm"
-      pressed={pressed}
-      commit={own ? undefined : commit}
-      disabled={disabled === true}
-      disabledReason={own ? labels.own : typeof disabled === "string" ? disabled : undefined}
-      onClick={(event) => {
-        // A row around it may expand on a click.
-        event.stopPropagation();
-        press();
-      }}
-      data-feedback-vote=""
-      className={cn("gap-1.5", className)}
-    >
-      <ThumbsUp className="size-3.5 shrink-0" aria-hidden />
-      <span className={size === "sm" ? "sr-only" : undefined}>{labels.vote}</span>
-      <span className="tabular-nums" data-feedback-votes="">
-        {count}
-      </span>
-    </Button>
-  );
-  // At "sm" the name is not on screen: the Tooltip shows it (the own reason has its own).
-  return size === "sm" && !own ? <Tooltip label={labels.vote}>{button}</Tooltip> : button;
-}

package/src/feedback.ts

@@ -1,116 +0,0 @@
-// `@eifi1/ui-kit/feedback` — the report form and the parts an inbox is built from.
-//
-// A re-slicing of the main barrel, not a new API. The kit owns the status vocabulary,
-// the transition policy and the look; each app still wires its own API, columns,
-// strings and permissions — see the note at the top of feedback/feedback-inbox.tsx.
-export * from "./feedback/feedback-attachment";
-export * from "./feedback/feedback-dialog";
-export * from "./feedback/feedback-inbox";
-export * from "./feedback/feedback-thread";
-// 0.27.0: the feedback harmonization (docs/feedback-harmonization.md) — one record,
-// one menu, dialog, table, detail and crash reporter for keksdose, kastlan, Kurvenschmiede.
-//
-// Named, not `*`, for six of its modules: 0.53 took the slice's share of the 55 names no app
-// reads off the surface (deprecated in 0.52, refactor audit 2026-10-30, API-4) —
-// `feedbackAttachmentLine`, `FEEDBACK_UNDO_DURATION`, `FEEDBACK_SWIPE_ACTIONS`,
-// `feedbackColumns`, `feedbackSubmitter`, `feedbackSubmitterEmail`, `feedbackEnvironment`,
-// `feedbackPagePath`, `feedbackAttachmentUrls`, `feedbackRowAccess`, `useFeedbackDetailLabels`
-// and `feedbackPublicSwitchAllowed`, which their modules keep for the kit's own use.
-// `feedbackPageHref` and `feedbackPageUrl` went whole: nothing read them.
-export {
-  DEFAULT_ATTACHMENT_ACCEPT,
-  DEFAULT_MAX_ATTACHMENT_BYTES,
-  DEFAULT_MAX_ATTACHMENTS,
-  FEEDBACK_ATTACHMENT_ACCEPT,
-  FEEDBACK_PICKABLE_CATEGORIES,
-  FEEDBACK_REWORKABLE_STATUSES,
-  FEEDBACK_QUEUE_STATUSES,
-  FEEDBACK_AUTHOR_EDITABLE_STATUSES,
-  FEEDBACK_AWAITING_STATUSES,
-  FEEDBACK_DECIDED_STATUSES,
-  FEEDBACK_COMMENT_MAX,
-  FEEDBACK_REPLY_MAX,
-  appendRework,
-  reworkCount,
-  feedbackReworkCount,
-  splitBodyAttachments,
-  splitDescription,
-  replaceDescription,
-  isImageAttachment,
-  attachmentName,
-  type FeedbackEnvironment,
-  type FeedbackContext,
-  type FeedbackRecord,
-} from "./feedback/feedback-record";
-export * from "./feedback/feedback-labels";
-export {
-  useFeedbackStatusUndo,
-  type FeedbackStatusPatch,
-  type FeedbackStatusMutateAsync,
-  type FeedbackStatusRow,
-  type FeedbackStatusChange,
-  type FeedbackStatusUndoOptions,
-} from "./feedback/feedback-status-undo";
-export {
-  DEFAULT_FEEDBACK_SWIPE,
-  feedbackSwipePlan,
-  feedbackSwipeOmitShown,
-  type FeedbackSwipeAction,
-  type FeedbackSwipeBinding,
-  type FeedbackSwipeOptions,
-} from "./feedback/feedback-swipe";
-export * from "./feedback/feedback-menu";
-export * from "./feedback/feedback-context";
-export * from "./feedback/feedback-capture";
-export * from "./feedback/feedback-submit";
-export {
-  DEFAULT_FEEDBACK_PAGE_LABELS,
-  useFeedbackPageLabels,
-  isFeedbackAwaiting,
-  useFeedbackRenderDate,
-  FeedbackSubject,
-  useFeedbackColumns,
-  feedbackMobileGroupBy,
-  FeedbackMobileCard,
-  FeedbackAwaitingToggle,
-  FeedbackEmptyState,
-  type FeedbackPageLabels,
-  type FeedbackTableRow,
-  type FeedbackRenderDate,
-  type FeedbackSubjectProps,
-  type FeedbackColumnsOptions,
-  type UseFeedbackColumnsOptions,
-  type FeedbackMobileCardProps,
-  type FeedbackAwaitingToggleProps,
-  type FeedbackEmptyStateProps,
-} from "./feedback/feedback-table";
-export {
-  DEFAULT_FEEDBACK_DETAIL_LABELS,
-  FeedbackReworkSection,
-  FeedbackRowDetail,
-  type FeedbackDetailLabels,
-  type FeedbackRowAccess,
-  type FeedbackDetailPatch,
-  type FeedbackDetailUpdateAsync,
-  type FeedbackUpload,
-  type FeedbackReworkSend,
-  type FeedbackReworkSectionProps,
-  type FeedbackRowDetailProps,
-} from "./feedback/feedback-row-detail";
-export * from "./feedback/feedback-crash";
-// 0.38.0: the public pages (§9.15) — the "Visible to others" switch, the list every user
-// reads and one report opened.
-export {
-  FeedbackPublicSwitch,
-  type FeedbackPublicSwitchRow,
-  type FeedbackPublicSwitchViewer,
-  type FeedbackPublicSwitchProps,
-} from "./feedback/feedback-public-switch";
-export * from "./feedback/feedback-public-list";
-// 0.38.0: public feedback (docs/feedback-harmonization.md §9) — the shapes, the vote, the
-// comment thread, the replies' timeline and composer.
-export * from "./feedback/feedback-public-types";
-export * from "./feedback/feedback-vote-button";
-export * from "./feedback/feedback-comment-thread";
-export * from "./feedback/feedback-replies";
-export * from "./feedback/feedback-entry-file";