@dizzlkheinz/ynab-mcpb 0.18.4 → 0.19.0

package/src/tools/__tests__/compareTransactions.window.test.ts

@@ -1,147 +1,151 @@
-import { describe, it, expect } from 'vitest';
-import { inWindow } from '../../utils/money.js';
-
-describe('compareTransactions statement window filtering', () => {
-  describe('inWindow function', () => {
-    it('excludes transactions outside statement window', () => {
-      const statementStart = '2024-01-01';
-      const statementEnd = '2024-01-31';
-
-      // Transaction within window
-      expect(inWindow('2024-01-15', statementStart, statementEnd)).toBe(true);
-
-      // Transaction before window
-      expect(inWindow('2023-12-31', statementStart, statementEnd)).toBe(false);
-
-      // Transaction after window
-      expect(inWindow('2024-02-01', statementStart, statementEnd)).toBe(false);
-
-      // Boundary dates
-      expect(inWindow('2024-01-01', statementStart, statementEnd)).toBe(true);
-      expect(inWindow('2024-01-31', statementStart, statementEnd)).toBe(true);
-    });
-
-    it('handles partial window bounds', () => {
-      // Only end date specified
-      expect(inWindow('2024-01-15', undefined, '2024-01-31')).toBe(true);
-      expect(inWindow('2024-02-01', undefined, '2024-01-31')).toBe(false);
-
-      // Only start date specified
-      expect(inWindow('2024-01-15', '2024-01-01', undefined)).toBe(true);
-      expect(inWindow('2023-12-31', '2024-01-01', undefined)).toBe(false);
-
-      // No bounds specified (all transactions pass)
-      expect(inWindow('2024-01-15', undefined, undefined)).toBe(true);
-    });
-
-    it('filters candidates before matching logic', () => {
-      const allTransactions = [
-        { date: '2023-12-31', amount: 100 }, // Before window
-        { date: '2024-01-15', amount: 200 }, // In window
-        { date: '2024-01-20', amount: 300 }, // In window
-        { date: '2024-02-01', amount: 400 }, // After window
-      ];
-
-      const filteredTxns = allTransactions.filter((t) =>
-        inWindow(t.date, '2024-01-01', '2024-01-31'),
-      );
-
-      expect(filteredTxns).toHaveLength(2);
-      expect(filteredTxns[0]?.amount).toBe(200);
-      expect(filteredTxns[1]?.amount).toBe(300);
-    });
-  });
-
-  describe('statement window clamping', () => {
-    it('clamps bank and YNAB candidates to statement window', () => {
-      const bankTxns = [
-        { date: '2023-12-25', description: 'Before window' },
-        { date: '2024-01-10', description: 'In window' },
-        { date: '2024-02-05', description: 'After window' },
-      ];
-
-      const ynabTxns = [
-        { date: '2023-12-30', payee: 'Before window' },
-        { date: '2024-01-12', payee: 'In window' },
-        { date: '2024-02-10', payee: 'After window' },
-      ];
-
-      const statementStart = '2024-01-01';
-      const statementEnd = '2024-01-31';
-
-      const filteredBank = bankTxns.filter((t) => inWindow(t.date, statementStart, statementEnd));
-      const filteredYnab = ynabTxns.filter((t) => inWindow(t.date, statementStart, statementEnd));
-
-      // Only transactions in January 2024 should remain
-      expect(filteredBank).toHaveLength(1);
-      expect(filteredBank[0]?.description).toBe('In window');
-
-      expect(filteredYnab).toHaveLength(1);
-      expect(filteredYnab[0]?.payee).toBe('In window');
-    });
-
-    it('matches use filtered transactions not original counts', () => {
-      // This test validates that when statement window filtering is applied,
-      // the matching algorithm operates on filtered transactions,
-      // and the summary counts reflect filtered transactions, not original totals
-      const originalBankCount = 5;
-      const originalYnabCount = 4;
-      const filteredBankCount = 2; // After window filtering
-      const filteredYnabCount = 3; // After window filtering
-
-      // The summary should show filtered counts, not original
-      expect(filteredBankCount).toBeLessThan(originalBankCount);
-      expect(filteredYnabCount).toBeLessThan(originalYnabCount);
-    });
-  });
-
-  describe('integration with modular compareTransactions', () => {
-    it('should apply window filtering in the main handler', () => {
-      // This test verifies that the main handler correctly applies window filtering
-      // to both bank and YNAB transactions before passing them to the matcher
-      const testDate1 = '2024-01-15'; // In window
-      const testDate2 = '2024-02-15'; // Out of window
-      const statementStart = '2024-01-01';
-      const statementEnd = '2024-01-31';
-
-      // Test that filtering logic works as expected
-      expect(inWindow(testDate1, statementStart, statementEnd)).toBe(true);
-      expect(inWindow(testDate2, statementStart, statementEnd)).toBe(false);
-    });
-
-    it('should filter transactions before matching in modular structure', () => {
-      // This test documents that window filtering happens in the main handler
-      // before passing transactions to the matcher module
-      const bankTransactions = [
-        { date: '2023-12-31', amount: 100, description: 'Before' },
-        { date: '2024-01-15', amount: 200, description: 'During' },
-        { date: '2024-02-01', amount: 300, description: 'After' },
-      ];
-
-      const ynabTransactions = [
-        { date: '2023-12-30', amount: 150, payee: 'Before' },
-        { date: '2024-01-16', amount: 250, payee: 'During' },
-        { date: '2024-02-02', amount: 350, payee: 'After' },
-      ];
-
-      const statementStart = '2024-01-01';
-      const statementEnd = '2024-01-31';
-
-      // Simulate the filtering that happens in the main handler
-      const filteredBank = bankTransactions.filter((t) =>
-        inWindow(t.date, statementStart, statementEnd),
-      );
-      const filteredYnab = ynabTransactions.filter((t) =>
-        inWindow(t.date, statementStart, statementEnd),
-      );
-
-      expect(filteredBank).toHaveLength(1);
-      expect(filteredBank[0]?.description).toBe('During');
-      expect(filteredYnab).toHaveLength(1);
-      expect(filteredYnab[0]?.payee).toBe('During');
-
-      // The matcher would receive these filtered arrays, not the original ones
-      // This ensures that out-of-window transactions don't affect matching
-    });
-  });
+import { describe, expect, it } from "vitest";
+import { inWindow } from "../../utils/money.js";
+
+describe("compareTransactions statement window filtering", () => {
+	describe("inWindow function", () => {
+		it("excludes transactions outside statement window", () => {
+			const statementStart = "2024-01-01";
+			const statementEnd = "2024-01-31";
+
+			// Transaction within window
+			expect(inWindow("2024-01-15", statementStart, statementEnd)).toBe(true);
+
+			// Transaction before window
+			expect(inWindow("2023-12-31", statementStart, statementEnd)).toBe(false);
+
+			// Transaction after window
+			expect(inWindow("2024-02-01", statementStart, statementEnd)).toBe(false);
+
+			// Boundary dates
+			expect(inWindow("2024-01-01", statementStart, statementEnd)).toBe(true);
+			expect(inWindow("2024-01-31", statementStart, statementEnd)).toBe(true);
+		});
+
+		it("handles partial window bounds", () => {
+			// Only end date specified
+			expect(inWindow("2024-01-15", undefined, "2024-01-31")).toBe(true);
+			expect(inWindow("2024-02-01", undefined, "2024-01-31")).toBe(false);
+
+			// Only start date specified
+			expect(inWindow("2024-01-15", "2024-01-01", undefined)).toBe(true);
+			expect(inWindow("2023-12-31", "2024-01-01", undefined)).toBe(false);
+
+			// No bounds specified (all transactions pass)
+			expect(inWindow("2024-01-15", undefined, undefined)).toBe(true);
+		});
+
+		it("filters candidates before matching logic", () => {
+			const allTransactions = [
+				{ date: "2023-12-31", amount: 100 }, // Before window
+				{ date: "2024-01-15", amount: 200 }, // In window
+				{ date: "2024-01-20", amount: 300 }, // In window
+				{ date: "2024-02-01", amount: 400 }, // After window
+			];
+
+			const filteredTxns = allTransactions.filter((t) =>
+				inWindow(t.date, "2024-01-01", "2024-01-31"),
+			);
+
+			expect(filteredTxns).toHaveLength(2);
+			expect(filteredTxns[0]?.amount).toBe(200);
+			expect(filteredTxns[1]?.amount).toBe(300);
+		});
+	});
+
+	describe("statement window clamping", () => {
+		it("clamps bank and YNAB candidates to statement window", () => {
+			const bankTxns = [
+				{ date: "2023-12-25", description: "Before window" },
+				{ date: "2024-01-10", description: "In window" },
+				{ date: "2024-02-05", description: "After window" },
+			];
+
+			const ynabTxns = [
+				{ date: "2023-12-30", payee: "Before window" },
+				{ date: "2024-01-12", payee: "In window" },
+				{ date: "2024-02-10", payee: "After window" },
+			];
+
+			const statementStart = "2024-01-01";
+			const statementEnd = "2024-01-31";
+
+			const filteredBank = bankTxns.filter((t) =>
+				inWindow(t.date, statementStart, statementEnd),
+			);
+			const filteredYnab = ynabTxns.filter((t) =>
+				inWindow(t.date, statementStart, statementEnd),
+			);
+
+			// Only transactions in January 2024 should remain
+			expect(filteredBank).toHaveLength(1);
+			expect(filteredBank[0]?.description).toBe("In window");
+
+			expect(filteredYnab).toHaveLength(1);
+			expect(filteredYnab[0]?.payee).toBe("In window");
+		});
+
+		it("matches use filtered transactions not original counts", () => {
+			// This test validates that when statement window filtering is applied,
+			// the matching algorithm operates on filtered transactions,
+			// and the summary counts reflect filtered transactions, not original totals
+			const originalBankCount = 5;
+			const originalYnabCount = 4;
+			const filteredBankCount = 2; // After window filtering
+			const filteredYnabCount = 3; // After window filtering
+
+			// The summary should show filtered counts, not original
+			expect(filteredBankCount).toBeLessThan(originalBankCount);
+			expect(filteredYnabCount).toBeLessThan(originalYnabCount);
+		});
+	});
+
+	describe("integration with modular compareTransactions", () => {
+		it("should apply window filtering in the main handler", () => {
+			// This test verifies that the main handler correctly applies window filtering
+			// to both bank and YNAB transactions before passing them to the matcher
+			const testDate1 = "2024-01-15"; // In window
+			const testDate2 = "2024-02-15"; // Out of window
+			const statementStart = "2024-01-01";
+			const statementEnd = "2024-01-31";
+
+			// Test that filtering logic works as expected
+			expect(inWindow(testDate1, statementStart, statementEnd)).toBe(true);
+			expect(inWindow(testDate2, statementStart, statementEnd)).toBe(false);
+		});
+
+		it("should filter transactions before matching in modular structure", () => {
+			// This test documents that window filtering happens in the main handler
+			// before passing transactions to the matcher module
+			const bankTransactions = [
+				{ date: "2023-12-31", amount: 100, description: "Before" },
+				{ date: "2024-01-15", amount: 200, description: "During" },
+				{ date: "2024-02-01", amount: 300, description: "After" },
+			];
+
+			const ynabTransactions = [
+				{ date: "2023-12-30", amount: 150, payee: "Before" },
+				{ date: "2024-01-16", amount: 250, payee: "During" },
+				{ date: "2024-02-02", amount: 350, payee: "After" },
+			];
+
+			const statementStart = "2024-01-01";
+			const statementEnd = "2024-01-31";
+
+			// Simulate the filtering that happens in the main handler
+			const filteredBank = bankTransactions.filter((t) =>
+				inWindow(t.date, statementStart, statementEnd),
+			);
+			const filteredYnab = ynabTransactions.filter((t) =>
+				inWindow(t.date, statementStart, statementEnd),
+			);
+
+			expect(filteredBank).toHaveLength(1);
+			expect(filteredBank[0]?.description).toBe("During");
+			expect(filteredYnab).toHaveLength(1);
+			expect(filteredYnab[0]?.payee).toBe("During");
+
+			// The matcher would receive these filtered arrays, not the original ones
+			// This ensures that out-of-window transactions don't affect matching
+		});
+	});
 });

package/src/tools/__tests__/deltaFetcher.scheduled.integration.test.ts

@@ -1,76 +1,80 @@
-import { describe, it, expect, beforeAll, beforeEach, afterEach } from 'vitest';
-import * as ynab from 'ynab';
-import { CacheManager } from '../../server/cacheManager.js';
-import { ServerKnowledgeStore } from '../../server/serverKnowledgeStore.js';
-import { DeltaCache } from '../../server/deltaCache.js';
-import { DeltaFetcher } from '../deltaFetcher.js';
+import { afterEach, beforeAll, beforeEach, describe, expect, it } from "vitest";
+import * as ynab from "ynab";
+import { CacheManager } from "../../server/cacheManager.js";
+import { DeltaCache } from "../../server/deltaCache.js";
+import { ServerKnowledgeStore } from "../../server/serverKnowledgeStore.js";
+import { DeltaFetcher } from "../deltaFetcher.js";
 
-const shouldSkip = ['true', '1', 'yes', 'y', 'on'].includes(
-  (process.env['SKIP_E2E_TESTS'] || '').toLowerCase().trim(),
+const shouldSkip = ["true", "1", "yes", "y", "on"].includes(
+	(process.env.SKIP_E2E_TESTS || "").toLowerCase().trim(),
 );
-const hasToken = !!process.env['YNAB_ACCESS_TOKEN'];
+const hasToken = !!process.env.YNAB_ACCESS_TOKEN;
 const skipTests = shouldSkip || !hasToken;
 const describeIntegration = skipTests ? describe.skip : describe;
 
-describeIntegration('Delta fetcher scheduled transactions integration', () => {
-  let ynabAPI: ynab.API;
-  let testBudgetId: string;
-  let deltaFetcher: DeltaFetcher;
-  let previousNodeEnv: string | undefined;
+describeIntegration("Delta fetcher scheduled transactions integration", () => {
+	let ynabAPI: ynab.API;
+	let testBudgetId: string;
+	let deltaFetcher: DeltaFetcher;
+	let previousNodeEnv: string | undefined;
 
-  beforeAll(async () => {
-    const accessToken = process.env['YNAB_ACCESS_TOKEN']!;
-    ynabAPI = new ynab.API(accessToken);
-    const budgetsResponse = await ynabAPI.budgets.getBudgets();
-    const budget = budgetsResponse.data.budgets[0];
-    if (!budget) {
-      throw new Error('No budgets available for delta integration tests.');
-    }
-    testBudgetId = budget.id;
-  });
+	beforeAll(async () => {
+		const accessToken = process.env.YNAB_ACCESS_TOKEN!;
+		ynabAPI = new ynab.API(accessToken);
+		const budgetsResponse = await ynabAPI.budgets.getBudgets();
+		const budget = budgetsResponse.data.budgets[0];
+		if (!budget) {
+			throw new Error("No budgets available for delta integration tests.");
+		}
+		testBudgetId = budget.id;
+	});
 
-  beforeEach(() => {
-    previousNodeEnv = process.env['NODE_ENV'];
-    process.env['NODE_ENV'] = 'integration';
-    const cacheManager = new CacheManager();
-    const knowledgeStore = new ServerKnowledgeStore();
-    const deltaCache = new DeltaCache(cacheManager, knowledgeStore);
-    deltaFetcher = new DeltaFetcher(ynabAPI, deltaCache);
-    process.env['YNAB_MCP_ENABLE_DELTA'] = 'true';
-  });
+	beforeEach(() => {
+		previousNodeEnv = process.env.NODE_ENV;
+		process.env.NODE_ENV = "integration";
+		const cacheManager = new CacheManager();
+		const knowledgeStore = new ServerKnowledgeStore();
+		const deltaCache = new DeltaCache(cacheManager, knowledgeStore);
+		deltaFetcher = new DeltaFetcher(ynabAPI, deltaCache);
+		process.env.YNAB_MCP_ENABLE_DELTA = "true";
+	});
 
-  afterEach(() => {
-    delete process.env['YNAB_MCP_ENABLE_DELTA'];
-    if (previousNodeEnv === undefined) {
-      delete process.env['NODE_ENV'];
-    } else {
-      process.env['NODE_ENV'] = previousNodeEnv;
-    }
-    previousNodeEnv = undefined;
-  });
+	afterEach(() => {
+		process.env.YNAB_MCP_ENABLE_DELTA = undefined;
+		if (previousNodeEnv === undefined) {
+			process.env.NODE_ENV = undefined;
+		} else {
+			process.env.NODE_ENV = previousNodeEnv;
+		}
+		previousNodeEnv = undefined;
+	});
 
-  it(
-    'caches scheduled transactions on repeated fetches',
-    { meta: { tier: 'domain', domain: 'delta' } },
-    async () => {
-      const firstResult = await deltaFetcher.fetchScheduledTransactions(testBudgetId);
-      expect(firstResult.wasCached).toBe(false);
-      expect(firstResult.serverKnowledge).toBeGreaterThanOrEqual(0);
-      // Validate data structure
-      expect(Array.isArray(firstResult.data)).toBe(true);
-      if (firstResult.data.length > 0) {
-        const sample = firstResult.data[0];
-        expect(sample).toHaveProperty('id');
-        expect(sample).toHaveProperty('date_first');
-        expect(sample).toHaveProperty('frequency');
-      }
+	it(
+		"caches scheduled transactions on repeated fetches",
+		{ meta: { tier: "domain", domain: "delta" } },
+		async () => {
+			const firstResult =
+				await deltaFetcher.fetchScheduledTransactions(testBudgetId);
+			expect(firstResult.wasCached).toBe(false);
+			expect(firstResult.serverKnowledge).toBeGreaterThanOrEqual(0);
+			// Validate data structure
+			expect(Array.isArray(firstResult.data)).toBe(true);
+			if (firstResult.data.length > 0) {
+				const sample = firstResult.data[0];
+				expect(sample).toHaveProperty("id");
+				expect(sample).toHaveProperty("date_first");
+				expect(sample).toHaveProperty("frequency");
+			}
 
-      const secondResult = await deltaFetcher.fetchScheduledTransactions(testBudgetId);
-      expect(secondResult.wasCached).toBe(true);
-      expect(secondResult.serverKnowledge).toBeGreaterThanOrEqual(firstResult.serverKnowledge);
-      // Validate cached data structure matches
-      expect(Array.isArray(secondResult.data)).toBe(true);
-      expect(secondResult.data.length).toBe(firstResult.data.length);
-    },
-  );
+			const secondResult =
+				await deltaFetcher.fetchScheduledTransactions(testBudgetId);
+			expect(secondResult.wasCached).toBe(true);
+			expect(secondResult.serverKnowledge).toBeGreaterThanOrEqual(
+				firstResult.serverKnowledge,
+			);
+			// Validate cached data structure matches
+			expect(Array.isArray(secondResult.data)).toBe(true);
+			expect(secondResult.data.length).toBe(firstResult.data.length);
+		},
+	);
 });