@dizzlkheinz/ynab-mcpb 0.18.4 → 0.19.0

package/dist/tools/reconciliation/csvParser.js

@@ -1,52 +1,52 @@
-import Papa from 'papaparse';
-import * as chrono from 'chrono-node';
-import { randomUUID } from 'crypto';
+import { randomUUID } from "node:crypto";
+import * as chrono from "chrono-node";
+import Papa from "papaparse";
 export const BANK_PRESETS = {
     td: {
-        name: 'TD Canada Trust',
+        name: "TD Canada Trust",
         header: false,
-        dateColumn: ['0', 'Date'],
-        amountColumn: ['Amount'],
-        debitColumn: '2',
-        creditColumn: '3',
-        descriptionColumn: ['1', 'Description'],
-        dateFormat: 'MDY',
+        dateColumn: ["0", "Date"],
+        amountColumn: ["Amount"],
+        debitColumn: "2",
+        creditColumn: "3",
+        descriptionColumn: ["1", "Description"],
+        dateFormat: "MDY",
     },
     rbc: {
-        name: 'RBC Royal Bank',
-        dateColumn: ['Transaction Date', 'Date'],
-        debitColumn: 'Debit',
-        creditColumn: 'Credit',
-        descriptionColumn: ['Description 1', 'Description', 'Transaction'],
-        dateFormat: 'YMD',
+        name: "RBC Royal Bank",
+        dateColumn: ["Transaction Date", "Date"],
+        debitColumn: "Debit",
+        creditColumn: "Credit",
+        descriptionColumn: ["Description 1", "Description", "Transaction"],
+        dateFormat: "YMD",
     },
     scotiabank: {
-        name: 'Scotiabank',
-        dateColumn: ['Date', 'Transaction Date'],
-        amountColumn: ['Amount'],
-        descriptionColumn: ['Description', 'Transaction Details'],
-        dateFormat: 'DMY',
+        name: "Scotiabank",
+        dateColumn: ["Date", "Transaction Date"],
+        amountColumn: ["Amount"],
+        descriptionColumn: ["Description", "Transaction Details"],
+        dateFormat: "DMY",
     },
     wealthsimple: {
-        name: 'Wealthsimple',
-        dateColumn: ['Date'],
-        amountColumn: ['Amount'],
-        descriptionColumn: ['Description', 'Payee'],
+        name: "Wealthsimple",
+        dateColumn: ["Date"],
+        amountColumn: ["Amount"],
+        descriptionColumn: ["Description", "Payee"],
         amountMultiplier: 1,
-        dateFormat: 'YMD',
+        dateFormat: "YMD",
     },
     tangerine: {
-        name: 'Tangerine',
-        dateColumn: ['Date', 'Transaction date'],
-        amountColumn: ['Amount'],
-        descriptionColumn: ['Name', 'Transaction name', 'Memo'],
-        dateFormat: 'MDY',
+        name: "Tangerine",
+        dateColumn: ["Date", "Transaction date"],
+        amountColumn: ["Amount"],
+        descriptionColumn: ["Name", "Transaction name", "Memo"],
+        dateFormat: "MDY",
     },
 };
-export const SAFE_DELIMITERS = [',', ';', '\t', '|', ' '];
+export const SAFE_DELIMITERS = [",", ";", "\t", "|", " "];
 function validateDelimiter(delimiter) {
     if (!SAFE_DELIMITERS.includes(delimiter)) {
-        throw new Error(`Unsafe delimiter "${delimiter}". Allowed delimiters: ${SAFE_DELIMITERS.join(', ')}`);
+        throw new Error(`Unsafe delimiter "${delimiter}". Allowed delimiters: ${SAFE_DELIMITERS.join(", ")}`);
     }
 }
 function autoDetectFormat(content) {
@@ -68,7 +68,7 @@ function autoDetectFormat(content) {
             return { preset: key, header: true };
     }
     if (checkTDPattern(rows)) {
-        return { preset: 'td', header: false };
+        return { preset: "td", header: false };
     }
     return undefined;
 }
@@ -78,7 +78,7 @@ function checkTDPattern(rows) {
         return false;
     let matchCount = 0;
     for (const row of validRows) {
-        if (!/^\d{1,2}\/\d{1,2}\/\d{4}$/.test(row[0] || ''))
+        if (!/^\d{1,2}\/\d{1,2}\/\d{4}$/.test(row[0] || ""))
             continue;
         const isDebitNumeric = !row[2] || /^-?[\d,.]+$/.test(row[2]);
         const isCreditNumeric = !row[3] || /^-?[\d,.]+$/.test(row[3]);
@@ -134,9 +134,9 @@ export function parseCSV(content, options = {}) {
         for (const err of parsed.errors) {
             errors.push({
                 row: err.row ?? 0,
-                field: 'csv',
+                field: "csv",
                 message: err.message,
-                rawValue: '',
+                rawValue: "",
             });
         }
     }
@@ -156,10 +156,15 @@ export function parseCSV(content, options = {}) {
             : undefined;
     const dateCandidates = options.columns?.date
         ? [options.columns.date]
-        : (preset?.dateColumn ?? ['Date', 'Transaction Date', 'Posted Date']);
+        : (preset?.dateColumn ?? ["Date", "Transaction Date", "Posted Date"]);
     const descCandidates = options.columns?.description
         ? [options.columns.description]
-        : (preset?.descriptionColumn ?? ['Description', 'Payee', 'Merchant', 'Name']);
+        : (preset?.descriptionColumn ?? [
+            "Description",
+            "Payee",
+            "Merchant",
+            "Name",
+        ]);
     const dateCol = findColumn(columns, dateCandidates, !hasHeader);
     const descCol = findColumn(columns, descCandidates, !hasHeader);
     let amountCol = null;
@@ -179,32 +184,32 @@ export function parseCSV(content, options = {}) {
     else {
         const amountCandidates = options.columns?.amount
             ? [options.columns.amount]
-            : (preset?.amountColumn ?? ['Amount', 'CAD$', 'Value']);
+            : (preset?.amountColumn ?? ["Amount", "CAD$", "Value"]);
         amountCol = findColumn(columns, amountCandidates, !hasHeader);
     }
     if (!dateCol) {
         errors.push({
             row: 0,
-            field: 'date',
-            message: `Could not identify date column from: ${columns.join(', ')}. Try using preset option (td, rbc, scotiabank, etc.) or specify columns manually with columns.date`,
-            rawValue: columns.join(', '),
+            field: "date",
+            message: `Could not identify date column from: ${columns.join(", ")}. Try using preset option (td, rbc, scotiabank, etc.) or specify columns manually with columns.date`,
+            rawValue: columns.join(", "),
         });
     }
     if (!amountCol && (!debitCol || !creditCol)) {
         if (!debitCol && !creditCol) {
             errors.push({
                 row: 0,
-                field: 'amount',
-                message: `Could not identify amount column from: ${columns.join(', ')}. Try using preset option or specify columns manually with columns.amount (or columns.debit/credit for split columns)`,
-                rawValue: columns.join(', '),
+                field: "amount",
+                message: `Could not identify amount column from: ${columns.join(", ")}. Try using preset option or specify columns manually with columns.amount (or columns.debit/credit for split columns)`,
+                rawValue: columns.join(", "),
             });
         }
         else if (!debitCol || !creditCol) {
             errors.push({
                 row: 0,
-                field: 'amount',
-                message: `Could not identify debit/credit columns pair from: ${columns.join(', ')}. Found ${debitCol ? 'debit' : 'credit'} but missing ${debitCol ? 'credit' : 'debit'}. Specify both with columns.debit and columns.credit`,
-                rawValue: columns.join(', '),
+                field: "amount",
+                message: `Could not identify debit/credit columns pair from: ${columns.join(", ")}. Found ${debitCol ? "debit" : "credit"} but missing ${debitCol ? "credit" : "debit"}. Specify both with columns.debit and columns.credit`,
+                rawValue: columns.join(", "),
             });
         }
     }
@@ -216,21 +221,21 @@ export function parseCSV(content, options = {}) {
             continue;
         const getValue = (colName) => {
             if (!colName)
-                return '';
+                return "";
             if (Array.isArray(row)) {
-                const idx = parseInt(colName, 10);
-                return String(row[idx] ?? '');
+                const idx = Number.parseInt(colName, 10);
+                return String(row[idx] ?? "");
             }
-            return String(row[colName] ?? '');
+            return String(row[colName] ?? "");
         };
         const rowNum = i + (hasHeader ? 2 : 1);
         const rowWarnings = [];
-        const rawDate = getValue(dateCol)?.trim() ?? '';
+        const rawDate = getValue(dateCol)?.trim() ?? "";
         const parsedDate = parseDate(rawDate, dateFormat);
         if (!parsedDate) {
             errors.push({
                 row: rowNum,
-                field: 'date',
+                field: "date",
                 message: `Could not parse date: "${rawDate}"`,
                 rawValue: rawDate,
             });
@@ -240,12 +245,12 @@ export function parseCSV(content, options = {}) {
         let amountMilliunits;
         let rawAmount;
         if (amountCol) {
-            rawAmount = getValue(amountCol)?.trim() ?? '';
+            rawAmount = getValue(amountCol)?.trim() ?? "";
             const parsedAmount = parseAmount(rawAmount);
             if (!parsedAmount.valid) {
                 errors.push({
                     row: rowNum,
-                    field: 'amount',
+                    field: "amount",
                     message: parsedAmount.reason ?? `Invalid amount: "${rawAmount}"`,
                     rawValue: rawAmount,
                 });
@@ -254,15 +259,15 @@ export function parseCSV(content, options = {}) {
             amountMilliunits = parsedAmount.valueMilliunits;
         }
         else if (debitCol && creditCol) {
-            const debit = getValue(debitCol)?.trim() ?? '';
-            const credit = getValue(creditCol)?.trim() ?? '';
+            const debit = getValue(debitCol)?.trim() ?? "";
+            const credit = getValue(creditCol)?.trim() ?? "";
             rawAmount = debit || credit;
             const parsedDebit = parseAmount(debit);
             const parsedCredit = parseAmount(credit);
             if (!parsedDebit.valid && debit) {
                 errors.push({
                     row: rowNum,
-                    field: 'amount',
+                    field: "amount",
                     message: parsedDebit.reason ?? `Invalid debit amount: "${debit}"`,
                     rawValue: debit,
                 });
@@ -271,14 +276,18 @@ export function parseCSV(content, options = {}) {
             if (!parsedCredit.valid && credit) {
                 errors.push({
                     row: rowNum,
-                    field: 'amount',
+                    field: "amount",
                     message: parsedCredit.reason ?? `Invalid credit amount: "${credit}"`,
                     rawValue: credit,
                 });
                 continue;
             }
-            const debitMilliunits = parsedDebit.valid ? parsedDebit.valueMilliunits : 0;
-            const creditMilliunits = parsedCredit.valid ? parsedCredit.valueMilliunits : 0;
+            const debitMilliunits = parsedDebit.valid
+                ? parsedDebit.valueMilliunits
+                : 0;
+            const creditMilliunits = parsedCredit.valid
+                ? parsedCredit.valueMilliunits
+                : 0;
             if (Math.abs(debitMilliunits) > 0 && Math.abs(creditMilliunits) > 0) {
                 const warning = `Both Debit (${debit}) and Credit (${credit}) have values - using Debit`;
                 rowWarnings.push(warning);
@@ -293,8 +302,8 @@ export function parseCSV(content, options = {}) {
             else {
                 errors.push({
                     row: rowNum,
-                    field: 'amount',
-                    message: 'Missing debit/credit amount',
+                    field: "amount",
+                    message: "Missing debit/credit amount",
                     rawValue: `${debit}|${credit}`,
                 });
                 continue;
@@ -308,20 +317,22 @@ export function parseCSV(content, options = {}) {
         else {
             continue;
         }
-        const multiplier = options.invertAmounts ? -1 : (preset?.amountMultiplier ?? 1);
+        const multiplier = options.invertAmounts
+            ? -1
+            : (preset?.amountMultiplier ?? 1);
         amountMilliunits *= multiplier;
-        let rawDesc = getValue(descCol)?.trim() ?? '';
+        let rawDesc = getValue(descCol)?.trim() ?? "";
         rawDesc = rawDesc
-            .replace(/[\u0000-\u001F\u007F-\u009F]/g, '')
-            .replace(/[\u202A-\u202E\u2066-\u2069]/g, '')
-            .replace(/[\u200B-\u200D\uFEFF]/g, '')
-            .replace(/[\u2028-\u2029]/g, '')
+            .replace(/[\u0000-\u001F\u007F-\u009F]/g, "")
+            .replace(/[\u202A-\u202E\u2066-\u2069]/g, "")
+            .replace(/\u200B|\u200C|\u200D|\uFEFF/g, "")
+            .replace(/[\u2028-\u2029]/g, "")
             .substring(0, 500);
         transactions.push({
             id: randomUUID(),
             date: dateStr,
             amount: amountMilliunits,
-            payee: rawDesc || 'Unknown',
+            payee: rawDesc || "Unknown",
             sourceRow: rowNum,
             raw: {
                 date: rawDate,
@@ -336,7 +347,7 @@ export function parseCSV(content, options = {}) {
         errors,
         warnings,
         meta: {
-            detectedDelimiter: parsed.meta.delimiter || ',',
+            detectedDelimiter: parsed.meta.delimiter || ",",
             detectedColumns: columns,
             totalRows: rows.length,
             validRows: transactions.length,
@@ -350,27 +361,33 @@ function parseDate(raw, formatHint) {
     const isoMatch = raw.match(/^(\d{4})-(\d{2})-(\d{2})/);
     if (isoMatch) {
         const [, year, month, day] = isoMatch;
-        return new Date(Date.UTC(parseInt(year), parseInt(month) - 1, parseInt(day)));
+        if (!year || !month || !day)
+            return null;
+        return new Date(Date.UTC(Number.parseInt(year, 10), Number.parseInt(month, 10) - 1, Number.parseInt(day, 10)));
     }
     const numericMatch = raw.match(/^(\d{1,4})[/-](\d{1,2})[/-](\d{1,4})$/);
     if (numericMatch && formatHint) {
         const [, a, b, c] = numericMatch;
-        let year, month, day;
+        if (!a || !b || !c)
+            return null;
+        let year;
+        let month;
+        let day;
         switch (formatHint) {
-            case 'YMD':
-                year = parseInt(a);
-                month = parseInt(b);
-                day = parseInt(c);
+            case "YMD":
+                year = Number.parseInt(a, 10);
+                month = Number.parseInt(b, 10);
+                day = Number.parseInt(c, 10);
                 break;
-            case 'MDY':
-                month = parseInt(a);
-                day = parseInt(b);
-                year = parseInt(c);
+            case "MDY":
+                month = Number.parseInt(a, 10);
+                day = Number.parseInt(b, 10);
+                year = Number.parseInt(c, 10);
                 break;
-            case 'DMY':
-                day = parseInt(a);
-                month = parseInt(b);
-                year = parseInt(c);
+            case "DMY":
+                day = Number.parseInt(a, 10);
+                month = Number.parseInt(b, 10);
+                year = Number.parseInt(c, 10);
                 break;
         }
         if (year < 100)
@@ -387,8 +404,8 @@ function parseDate(raw, formatHint) {
 }
 function formatLocalDate(date) {
     const year = date.getUTCFullYear();
-    const month = String(date.getUTCMonth() + 1).padStart(2, '0');
-    const day = String(date.getUTCDate()).padStart(2, '0');
+    const month = String(date.getUTCMonth() + 1).padStart(2, "0");
+    const day = String(date.getUTCDate()).padStart(2, "0");
     return `${year}-${month}-${day}`;
 }
 function findColumn(available, candidates, exactIndex = false) {
@@ -417,14 +434,14 @@ function findColumn(available, candidates, exactIndex = false) {
 }
 function detectPreset(columns) {
     const colSet = new Set(columns.map((c) => c.toLowerCase()));
-    if (colSet.has('description 1') || colSet.has('account type')) {
-        return BANK_PRESETS['rbc'];
+    if (colSet.has("description 1") || colSet.has("account type")) {
+        return BANK_PRESETS["rbc"];
     }
-    if (columns.some((c) => c.toLowerCase().includes('cad$'))) {
-        return BANK_PRESETS['td'];
+    if (columns.some((c) => c.toLowerCase().includes("cad$"))) {
+        return BANK_PRESETS["td"];
     }
-    if (colSet.has('date') && colSet.has('description') && colSet.has('amount')) {
-        return BANK_PRESETS['td'];
+    if (colSet.has("date") && colSet.has("description") && colSet.has("amount")) {
+        return BANK_PRESETS["td"];
     }
     return undefined;
 }
@@ -432,21 +449,28 @@ const CURRENCY_SYMBOLS = /[$€£¥]/g;
 const CURRENCY_CODES = /\b(CAD|USD|EUR|GBP)\b/gi;
 function parseAmount(str) {
     if (!str || !str.trim()) {
-        return { valid: false, valueMilliunits: 0, reason: 'Missing amount value' };
+        return { valid: false, valueMilliunits: 0, reason: "Missing amount value" };
     }
-    let cleaned = str.replace(CURRENCY_SYMBOLS, '').replace(CURRENCY_CODES, '').trim();
-    if (cleaned.startsWith('(') && cleaned.endsWith(')')) {
-        cleaned = '-' + cleaned.slice(1, -1);
+    let cleaned = str
+        .replace(CURRENCY_SYMBOLS, "")
+        .replace(CURRENCY_CODES, "")
+        .trim();
+    if (cleaned.startsWith("(") && cleaned.endsWith(")")) {
+        cleaned = `-${cleaned.slice(1, -1)}`;
     }
     if (/^-?\d{1,3}(\.\d{3})+,\d{2}$/.test(cleaned)) {
-        cleaned = cleaned.replace(/\./g, '').replace(',', '.');
+        cleaned = cleaned.replace(/\./g, "").replace(",", ".");
     }
-    if (cleaned.includes('.')) {
-        cleaned = cleaned.replace(/,/g, '');
+    if (cleaned.includes(".")) {
+        cleaned = cleaned.replace(/,/g, "");
     }
-    const dollars = parseFloat(cleaned);
+    const dollars = Number.parseFloat(cleaned);
     if (!Number.isFinite(dollars)) {
-        return { valid: false, valueMilliunits: 0, reason: `Invalid amount: "${str}"` };
+        return {
+            valid: false,
+            valueMilliunits: 0,
+            reason: `Invalid amount: "${str}"`,
+        };
     }
     return { valid: true, valueMilliunits: Math.round(dollars * 1000) };
 }

package/dist/tools/reconciliation/executor.d.ts

@@ -1,7 +1,7 @@
-import type * as ynab from 'ynab';
-import type { ProgressCallback } from '../../server/toolRegistry.js';
-import type { ReconciliationAnalysis } from './types.js';
-import type { ReconcileAccountRequest } from './index.js';
+import type * as ynab from "ynab";
+import type { ProgressCallback } from "../../server/toolRegistry.js";
+import type { ReconcileAccountRequest } from "./index.js";
+import type { ReconciliationAnalysis } from "./types.js";
 export interface AccountSnapshot {
     balance: number;
     cleared_balance: number;