@dizzlkheinz/ynab-mcpb 0.18.4 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (343) hide show
  1. package/CLAUDE.md +87 -8
  2. package/bin/ynab-mcp-server.cjs +2 -2
  3. package/bin/ynab-mcp-server.js +3 -3
  4. package/biome.json +39 -0
  5. package/dist/bundle/index.cjs +67 -67
  6. package/dist/index.d.ts +1 -1
  7. package/dist/index.js +27 -27
  8. package/dist/server/YNABMCPServer.d.ts +3 -4
  9. package/dist/server/YNABMCPServer.js +111 -116
  10. package/dist/server/budgetResolver.d.ts +6 -5
  11. package/dist/server/budgetResolver.js +46 -36
  12. package/dist/server/cacheKeys.js +6 -6
  13. package/dist/server/cacheManager.js +14 -11
  14. package/dist/server/completions.d.ts +2 -2
  15. package/dist/server/completions.js +20 -15
  16. package/dist/server/config.d.ts +10 -5
  17. package/dist/server/config.js +24 -7
  18. package/dist/server/deltaCache.d.ts +2 -2
  19. package/dist/server/deltaCache.js +22 -16
  20. package/dist/server/deltaCache.merge.d.ts +2 -2
  21. package/dist/server/diagnostics.d.ts +4 -4
  22. package/dist/server/diagnostics.js +38 -32
  23. package/dist/server/errorHandler.d.ts +5 -12
  24. package/dist/server/errorHandler.js +219 -217
  25. package/dist/server/prompts.d.ts +2 -2
  26. package/dist/server/prompts.js +45 -45
  27. package/dist/server/rateLimiter.js +4 -4
  28. package/dist/server/requestLogger.d.ts +1 -1
  29. package/dist/server/requestLogger.js +40 -35
  30. package/dist/server/resources.d.ts +3 -3
  31. package/dist/server/resources.js +55 -52
  32. package/dist/server/responseFormatter.js +6 -6
  33. package/dist/server/securityMiddleware.d.ts +2 -2
  34. package/dist/server/securityMiddleware.js +22 -20
  35. package/dist/server/serverKnowledgeStore.js +1 -1
  36. package/dist/server/toolRegistry.d.ts +3 -3
  37. package/dist/server/toolRegistry.js +47 -40
  38. package/dist/tools/__tests__/deltaTestUtils.d.ts +3 -3
  39. package/dist/tools/__tests__/deltaTestUtils.js +2 -2
  40. package/dist/tools/accountTools.d.ts +9 -8
  41. package/dist/tools/accountTools.js +47 -47
  42. package/dist/tools/adapters.d.ts +13 -8
  43. package/dist/tools/adapters.js +21 -11
  44. package/dist/tools/budgetTools.d.ts +8 -7
  45. package/dist/tools/budgetTools.js +22 -22
  46. package/dist/tools/categoryTools.d.ts +9 -8
  47. package/dist/tools/categoryTools.js +68 -59
  48. package/dist/tools/compareTransactions/formatter.d.ts +3 -3
  49. package/dist/tools/compareTransactions/formatter.js +9 -9
  50. package/dist/tools/compareTransactions/index.d.ts +6 -6
  51. package/dist/tools/compareTransactions/index.js +58 -43
  52. package/dist/tools/compareTransactions/matcher.d.ts +1 -1
  53. package/dist/tools/compareTransactions/matcher.js +28 -15
  54. package/dist/tools/compareTransactions/parser.d.ts +2 -2
  55. package/dist/tools/compareTransactions/parser.js +144 -138
  56. package/dist/tools/compareTransactions/types.d.ts +4 -4
  57. package/dist/tools/compareTransactions.d.ts +1 -1
  58. package/dist/tools/compareTransactions.js +1 -1
  59. package/dist/tools/deltaFetcher.d.ts +2 -2
  60. package/dist/tools/deltaFetcher.js +16 -15
  61. package/dist/tools/deltaSupport.d.ts +4 -4
  62. package/dist/tools/deltaSupport.js +35 -41
  63. package/dist/tools/exportTransactions.d.ts +5 -4
  64. package/dist/tools/exportTransactions.js +61 -59
  65. package/dist/tools/monthTools.d.ts +7 -6
  66. package/dist/tools/monthTools.js +31 -29
  67. package/dist/tools/payeeTools.d.ts +7 -6
  68. package/dist/tools/payeeTools.js +28 -28
  69. package/dist/tools/reconcileAdapter.d.ts +2 -2
  70. package/dist/tools/reconcileAdapter.js +19 -12
  71. package/dist/tools/reconciliation/analyzer.d.ts +4 -4
  72. package/dist/tools/reconciliation/analyzer.js +73 -59
  73. package/dist/tools/reconciliation/csvParser.d.ts +3 -3
  74. package/dist/tools/reconciliation/csvParser.js +128 -104
  75. package/dist/tools/reconciliation/executor.d.ts +4 -4
  76. package/dist/tools/reconciliation/executor.js +148 -109
  77. package/dist/tools/reconciliation/index.d.ts +10 -10
  78. package/dist/tools/reconciliation/index.js +96 -83
  79. package/dist/tools/reconciliation/matcher.d.ts +3 -3
  80. package/dist/tools/reconciliation/matcher.js +17 -16
  81. package/dist/tools/reconciliation/payeeNormalizer.js +19 -8
  82. package/dist/tools/reconciliation/recommendationEngine.d.ts +1 -1
  83. package/dist/tools/reconciliation/recommendationEngine.js +40 -40
  84. package/dist/tools/reconciliation/reportFormatter.d.ts +2 -2
  85. package/dist/tools/reconciliation/reportFormatter.js +59 -58
  86. package/dist/tools/reconciliation/signDetector.d.ts +1 -1
  87. package/dist/tools/reconciliation/types.d.ts +16 -16
  88. package/dist/tools/reconciliation/ynabAdapter.d.ts +2 -2
  89. package/dist/tools/schemas/common.d.ts +1 -1
  90. package/dist/tools/schemas/common.js +1 -1
  91. package/dist/tools/schemas/outputs/accountOutputs.d.ts +1 -1
  92. package/dist/tools/schemas/outputs/accountOutputs.js +24 -18
  93. package/dist/tools/schemas/outputs/budgetOutputs.d.ts +1 -1
  94. package/dist/tools/schemas/outputs/budgetOutputs.js +14 -11
  95. package/dist/tools/schemas/outputs/categoryOutputs.d.ts +1 -1
  96. package/dist/tools/schemas/outputs/categoryOutputs.js +49 -29
  97. package/dist/tools/schemas/outputs/comparisonOutputs.d.ts +1 -1
  98. package/dist/tools/schemas/outputs/comparisonOutputs.js +12 -12
  99. package/dist/tools/schemas/outputs/index.d.ts +14 -14
  100. package/dist/tools/schemas/outputs/index.js +14 -14
  101. package/dist/tools/schemas/outputs/monthOutputs.d.ts +1 -1
  102. package/dist/tools/schemas/outputs/monthOutputs.js +56 -41
  103. package/dist/tools/schemas/outputs/payeeOutputs.d.ts +1 -1
  104. package/dist/tools/schemas/outputs/payeeOutputs.js +10 -10
  105. package/dist/tools/schemas/outputs/reconciliationOutputs.d.ts +2 -2
  106. package/dist/tools/schemas/outputs/reconciliationOutputs.js +45 -45
  107. package/dist/tools/schemas/outputs/transactionMutationOutputs.d.ts +1 -1
  108. package/dist/tools/schemas/outputs/transactionMutationOutputs.js +28 -22
  109. package/dist/tools/schemas/outputs/transactionOutputs.d.ts +1 -1
  110. package/dist/tools/schemas/outputs/transactionOutputs.js +43 -35
  111. package/dist/tools/schemas/outputs/utilityOutputs.d.ts +1 -1
  112. package/dist/tools/schemas/outputs/utilityOutputs.js +5 -3
  113. package/dist/tools/schemas/shared/commonOutputs.d.ts +1 -1
  114. package/dist/tools/schemas/shared/commonOutputs.js +15 -9
  115. package/dist/tools/transactionReadTools.d.ts +11 -0
  116. package/dist/tools/transactionReadTools.js +202 -0
  117. package/dist/tools/transactionSchemas.d.ts +7 -7
  118. package/dist/tools/transactionSchemas.js +77 -57
  119. package/dist/tools/transactionTools.d.ts +6 -24
  120. package/dist/tools/transactionTools.js +7 -1499
  121. package/dist/tools/transactionUtils.d.ts +6 -6
  122. package/dist/tools/transactionUtils.js +78 -63
  123. package/dist/tools/transactionWriteTools.d.ts +20 -0
  124. package/dist/tools/transactionWriteTools.js +1342 -0
  125. package/dist/tools/utilityTools.d.ts +5 -4
  126. package/dist/tools/utilityTools.js +11 -11
  127. package/dist/types/index.d.ts +7 -7
  128. package/dist/types/index.js +6 -6
  129. package/dist/types/reconciliation.d.ts +1 -1
  130. package/dist/types/toolRegistration.d.ts +14 -12
  131. package/dist/utils/amountUtils.js +1 -1
  132. package/dist/utils/dateUtils.js +4 -4
  133. package/dist/utils/errors.d.ts +3 -3
  134. package/dist/utils/errors.js +4 -4
  135. package/dist/utils/money.d.ts +2 -2
  136. package/dist/utils/money.js +8 -8
  137. package/dist/utils/validationError.d.ts +1 -1
  138. package/dist/utils/validationError.js +1 -1
  139. package/docs/assets/examples/reconciliation-with-recommendations.json +66 -66
  140. package/docs/assets/schemas/reconciliation-v2.json +360 -336
  141. package/esbuild.config.mjs +53 -50
  142. package/meta.json +12548 -12548
  143. package/package.json +98 -111
  144. package/scripts/analyze-bundle.mjs +33 -30
  145. package/scripts/create-pr-description.js +169 -120
  146. package/scripts/run-all-tests.js +178 -169
  147. package/scripts/run-domain-integration-tests.js +28 -18
  148. package/scripts/run-generate-mcpb.js +19 -17
  149. package/scripts/run-throttled-integration-tests.js +92 -83
  150. package/scripts/test-delta-params.mjs +149 -120
  151. package/scripts/test-recommendations.ts +36 -32
  152. package/scripts/tmpTransaction.ts +80 -43
  153. package/scripts/validate-env.js +98 -91
  154. package/scripts/verify-build.js +78 -76
  155. package/src/__tests__/comprehensive.integration.test.ts +1281 -1154
  156. package/src/__tests__/performance.test.ts +723 -671
  157. package/src/__tests__/setup.ts +442 -395
  158. package/src/__tests__/smoke.e2e.test.ts +41 -39
  159. package/src/__tests__/testRunner.ts +314 -295
  160. package/src/__tests__/testUtils.ts +456 -364
  161. package/src/__tests__/tools/reconciliation/csvParser.integration.test.ts +109 -107
  162. package/src/__tests__/tools/reconciliation/real-world.integration.test.ts +41 -41
  163. package/src/index.ts +68 -59
  164. package/src/server/CLAUDE.md +480 -0
  165. package/src/server/YNABMCPServer.ts +821 -794
  166. package/src/server/__tests__/YNABMCPServer.integration.test.ts +929 -893
  167. package/src/server/__tests__/YNABMCPServer.test.ts +903 -899
  168. package/src/server/__tests__/budgetResolver.test.ts +466 -423
  169. package/src/server/__tests__/cacheManager.test.ts +891 -874
  170. package/src/server/__tests__/completions.integration.test.ts +115 -106
  171. package/src/server/__tests__/completions.test.ts +334 -313
  172. package/src/server/__tests__/config.test.ts +98 -86
  173. package/src/server/__tests__/deltaCache.merge.test.ts +774 -703
  174. package/src/server/__tests__/deltaCache.swr.test.ts +198 -153
  175. package/src/server/__tests__/deltaCache.test.ts +946 -759
  176. package/src/server/__tests__/diagnostics.test.ts +825 -792
  177. package/src/server/__tests__/errorHandler.integration.test.ts +512 -462
  178. package/src/server/__tests__/errorHandler.test.ts +402 -397
  179. package/src/server/__tests__/prompts.test.ts +424 -347
  180. package/src/server/__tests__/rateLimiter.test.ts +313 -309
  181. package/src/server/__tests__/requestLogger.test.ts +443 -403
  182. package/src/server/__tests__/resources.template.test.ts +196 -185
  183. package/src/server/__tests__/resources.test.ts +294 -288
  184. package/src/server/__tests__/security.integration.test.ts +487 -421
  185. package/src/server/__tests__/securityMiddleware.test.ts +519 -444
  186. package/src/server/__tests__/server-startup.integration.test.ts +509 -490
  187. package/src/server/__tests__/serverKnowledgeStore.test.ts +174 -173
  188. package/src/server/__tests__/toolRegistration.test.ts +239 -210
  189. package/src/server/__tests__/toolRegistry.test.ts +907 -845
  190. package/src/server/budgetResolver.ts +221 -181
  191. package/src/server/cacheKeys.ts +6 -6
  192. package/src/server/cacheManager.ts +498 -484
  193. package/src/server/completions.ts +267 -243
  194. package/src/server/config.ts +35 -14
  195. package/src/server/deltaCache.merge.ts +146 -128
  196. package/src/server/deltaCache.ts +352 -309
  197. package/src/server/diagnostics.ts +257 -242
  198. package/src/server/errorHandler.ts +747 -744
  199. package/src/server/prompts.ts +181 -176
  200. package/src/server/rateLimiter.ts +131 -129
  201. package/src/server/requestLogger.ts +350 -322
  202. package/src/server/resources.ts +442 -374
  203. package/src/server/responseFormatter.ts +41 -37
  204. package/src/server/securityMiddleware.ts +223 -205
  205. package/src/server/serverKnowledgeStore.ts +67 -67
  206. package/src/server/toolRegistry.ts +508 -474
  207. package/src/tools/CLAUDE.md +604 -0
  208. package/src/tools/__tests__/accountTools.delta.integration.test.ts +128 -111
  209. package/src/tools/__tests__/accountTools.integration.test.ts +129 -111
  210. package/src/tools/__tests__/accountTools.test.ts +685 -638
  211. package/src/tools/__tests__/adapters.test.ts +142 -108
  212. package/src/tools/__tests__/budgetTools.delta.integration.test.ts +73 -73
  213. package/src/tools/__tests__/budgetTools.integration.test.ts +132 -124
  214. package/src/tools/__tests__/budgetTools.test.ts +442 -413
  215. package/src/tools/__tests__/categoryTools.delta.integration.test.ts +76 -68
  216. package/src/tools/__tests__/categoryTools.integration.test.ts +314 -288
  217. package/src/tools/__tests__/categoryTools.test.ts +656 -625
  218. package/src/tools/__tests__/compareTransactions/formatter.test.ts +535 -462
  219. package/src/tools/__tests__/compareTransactions/index.test.ts +378 -358
  220. package/src/tools/__tests__/compareTransactions/matcher.test.ts +497 -398
  221. package/src/tools/__tests__/compareTransactions/parser.test.ts +765 -747
  222. package/src/tools/__tests__/compareTransactions.test.ts +352 -332
  223. package/src/tools/__tests__/compareTransactions.window.test.ts +150 -146
  224. package/src/tools/__tests__/deltaFetcher.scheduled.integration.test.ts +69 -65
  225. package/src/tools/__tests__/deltaFetcher.test.ts +325 -265
  226. package/src/tools/__tests__/deltaSupport.test.ts +211 -184
  227. package/src/tools/__tests__/deltaTestUtils.ts +37 -33
  228. package/src/tools/__tests__/exportTransactions.test.ts +205 -200
  229. package/src/tools/__tests__/monthTools.delta.integration.test.ts +68 -68
  230. package/src/tools/__tests__/monthTools.integration.test.ts +178 -166
  231. package/src/tools/__tests__/monthTools.test.ts +561 -512
  232. package/src/tools/__tests__/payeeTools.delta.integration.test.ts +68 -68
  233. package/src/tools/__tests__/payeeTools.integration.test.ts +158 -142
  234. package/src/tools/__tests__/payeeTools.test.ts +486 -434
  235. package/src/tools/__tests__/transactionSchemas.test.ts +1202 -1186
  236. package/src/tools/__tests__/transactionTools.integration.test.ts +875 -825
  237. package/src/tools/__tests__/transactionTools.test.ts +4923 -4366
  238. package/src/tools/__tests__/transactionUtils.test.ts +1004 -977
  239. package/src/tools/__tests__/utilityTools.integration.test.ts +32 -32
  240. package/src/tools/__tests__/utilityTools.test.ts +68 -58
  241. package/src/tools/accountTools.ts +293 -271
  242. package/src/tools/adapters.ts +120 -63
  243. package/src/tools/budgetTools.ts +121 -116
  244. package/src/tools/categoryTools.ts +379 -339
  245. package/src/tools/compareTransactions/formatter.ts +131 -119
  246. package/src/tools/compareTransactions/index.ts +249 -214
  247. package/src/tools/compareTransactions/matcher.ts +259 -209
  248. package/src/tools/compareTransactions/parser.ts +517 -487
  249. package/src/tools/compareTransactions/types.ts +38 -38
  250. package/src/tools/compareTransactions.ts +1 -1
  251. package/src/tools/deltaFetcher.ts +281 -260
  252. package/src/tools/deltaSupport.ts +264 -259
  253. package/src/tools/exportTransactions.ts +230 -218
  254. package/src/tools/monthTools.ts +180 -165
  255. package/src/tools/payeeTools.ts +152 -140
  256. package/src/tools/reconcileAdapter.ts +297 -252
  257. package/src/tools/reconciliation/CLAUDE.md +506 -0
  258. package/src/tools/reconciliation/__tests__/adapter.causes.test.ts +133 -124
  259. package/src/tools/reconciliation/__tests__/adapter.test.ts +249 -230
  260. package/src/tools/reconciliation/__tests__/analyzer.test.ts +408 -400
  261. package/src/tools/reconciliation/__tests__/csvParser.test.ts +71 -69
  262. package/src/tools/reconciliation/__tests__/executor.integration.test.ts +348 -323
  263. package/src/tools/reconciliation/__tests__/executor.progress.test.ts +503 -457
  264. package/src/tools/reconciliation/__tests__/executor.test.ts +898 -831
  265. package/src/tools/reconciliation/__tests__/matcher.test.ts +667 -663
  266. package/src/tools/reconciliation/__tests__/payeeNormalizer.test.ts +296 -276
  267. package/src/tools/reconciliation/__tests__/recommendationEngine.integration.test.ts +692 -624
  268. package/src/tools/reconciliation/__tests__/recommendationEngine.test.ts +1008 -989
  269. package/src/tools/reconciliation/__tests__/reconciliation.delta.integration.test.ts +187 -146
  270. package/src/tools/reconciliation/__tests__/reportFormatter.test.ts +583 -533
  271. package/src/tools/reconciliation/__tests__/scenarios/adapterCurrency.scenario.test.ts +75 -74
  272. package/src/tools/reconciliation/__tests__/scenarios/extremes.scenario.test.ts +70 -62
  273. package/src/tools/reconciliation/__tests__/scenarios/repeatAmount.scenario.test.ts +102 -88
  274. package/src/tools/reconciliation/__tests__/schemaUrl.test.ts +56 -55
  275. package/src/tools/reconciliation/__tests__/signDetector.test.ts +209 -206
  276. package/src/tools/reconciliation/__tests__/ynabAdapter.test.ts +66 -60
  277. package/src/tools/reconciliation/analyzer.ts +564 -504
  278. package/src/tools/reconciliation/csvParser.ts +656 -609
  279. package/src/tools/reconciliation/executor.ts +1290 -1128
  280. package/src/tools/reconciliation/index.ts +580 -528
  281. package/src/tools/reconciliation/matcher.ts +256 -240
  282. package/src/tools/reconciliation/payeeNormalizer.ts +92 -78
  283. package/src/tools/reconciliation/recommendationEngine.ts +357 -345
  284. package/src/tools/reconciliation/reportFormatter.ts +343 -307
  285. package/src/tools/reconciliation/signDetector.ts +89 -83
  286. package/src/tools/reconciliation/types.ts +164 -159
  287. package/src/tools/reconciliation/ynabAdapter.ts +17 -15
  288. package/src/tools/schemas/CLAUDE.md +546 -0
  289. package/src/tools/schemas/common.ts +1 -1
  290. package/src/tools/schemas/outputs/__tests__/accountOutputs.test.ts +410 -409
  291. package/src/tools/schemas/outputs/__tests__/budgetOutputs.test.ts +305 -299
  292. package/src/tools/schemas/outputs/__tests__/categoryOutputs.test.ts +431 -430
  293. package/src/tools/schemas/outputs/__tests__/comparisonOutputs.test.ts +510 -495
  294. package/src/tools/schemas/outputs/__tests__/dateValidation.test.ts +179 -153
  295. package/src/tools/schemas/outputs/__tests__/discrepancyDirection.test.ts +293 -254
  296. package/src/tools/schemas/outputs/__tests__/monthOutputs.test.ts +457 -457
  297. package/src/tools/schemas/outputs/__tests__/payeeOutputs.test.ts +362 -356
  298. package/src/tools/schemas/outputs/__tests__/reconciliationOutputs.test.ts +402 -399
  299. package/src/tools/schemas/outputs/__tests__/transactionMutationSchemas.test.ts +225 -211
  300. package/src/tools/schemas/outputs/__tests__/transactionOutputs.test.ts +457 -454
  301. package/src/tools/schemas/outputs/__tests__/utilityOutputs.test.ts +316 -315
  302. package/src/tools/schemas/outputs/accountOutputs.ts +40 -34
  303. package/src/tools/schemas/outputs/budgetOutputs.ts +24 -19
  304. package/src/tools/schemas/outputs/categoryOutputs.ts +76 -56
  305. package/src/tools/schemas/outputs/comparisonOutputs.ts +192 -169
  306. package/src/tools/schemas/outputs/index.ts +163 -163
  307. package/src/tools/schemas/outputs/monthOutputs.ts +95 -80
  308. package/src/tools/schemas/outputs/payeeOutputs.ts +18 -18
  309. package/src/tools/schemas/outputs/reconciliationOutputs.ts +386 -373
  310. package/src/tools/schemas/outputs/transactionMutationOutputs.ts +259 -231
  311. package/src/tools/schemas/outputs/transactionOutputs.ts +81 -71
  312. package/src/tools/schemas/outputs/utilityOutputs.ts +90 -84
  313. package/src/tools/schemas/shared/commonOutputs.ts +27 -19
  314. package/src/tools/toolCategories.ts +114 -114
  315. package/src/tools/transactionReadTools.ts +327 -0
  316. package/src/tools/transactionSchemas.ts +322 -291
  317. package/src/tools/transactionTools.ts +84 -2246
  318. package/src/tools/transactionUtils.ts +507 -422
  319. package/src/tools/transactionWriteTools.ts +2110 -0
  320. package/src/tools/utilityTools.ts +46 -41
  321. package/src/types/CLAUDE.md +477 -0
  322. package/src/types/__tests__/index.test.ts +51 -51
  323. package/src/types/index.ts +43 -39
  324. package/src/types/integration-tests.d.ts +26 -26
  325. package/src/types/reconciliation.ts +29 -29
  326. package/src/types/toolAnnotations.ts +30 -30
  327. package/src/types/toolRegistration.ts +43 -32
  328. package/src/utils/CLAUDE.md +508 -0
  329. package/src/utils/__tests__/dateUtils.test.ts +174 -168
  330. package/src/utils/__tests__/money.test.ts +193 -187
  331. package/src/utils/amountUtils.ts +5 -5
  332. package/src/utils/baseError.ts +5 -5
  333. package/src/utils/dateUtils.ts +29 -26
  334. package/src/utils/errors.ts +14 -14
  335. package/src/utils/money.ts +66 -52
  336. package/src/utils/validationError.ts +1 -1
  337. package/tsconfig.json +29 -29
  338. package/tsconfig.prod.json +16 -16
  339. package/vitest-reporters/split-json-reporter.ts +247 -204
  340. package/vitest.config.ts +99 -95
  341. package/.prettierignore +0 -10
  342. package/.prettierrc.json +0 -10
  343. package/eslint.config.js +0 -49
@@ -1,30 +1,34 @@
1
- import { randomUUID } from 'crypto';
1
+ import { randomUUID } from "node:crypto";
2
+ import {
3
+ fromMilli,
4
+ toMoneyValue,
5
+ toMoneyValueFromDecimal,
6
+ } from "../../utils/money.js";
2
7
  import type {
3
- ActionableRecommendation,
4
- CreateTransactionRecommendation,
5
- UpdateClearedRecommendation,
6
- ReviewDuplicateRecommendation,
7
- ManualReviewRecommendation,
8
- RecommendationContext,
9
- ReconciliationInsight,
10
- TransactionMatch,
11
- BankTransaction,
12
- YNABTransaction,
13
- } from './types.js';
14
- import { toMoneyValue, toMoneyValueFromDecimal, fromMilli } from '../../utils/money.js';
15
-
16
- const RECOMMENDATION_VERSION = '1.0';
8
+ ActionableRecommendation,
9
+ BankTransaction,
10
+ CreateTransactionRecommendation,
11
+ ManualReviewRecommendation,
12
+ RecommendationContext,
13
+ ReconciliationInsight,
14
+ ReviewDuplicateRecommendation,
15
+ TransactionMatch,
16
+ UpdateClearedRecommendation,
17
+ YNABTransaction,
18
+ } from "./types.js";
19
+
20
+ const RECOMMENDATION_VERSION = "1.0";
17
21
 
18
22
  /**
19
23
  * Confidence scores for different recommendation types
20
24
  */
21
25
  const CONFIDENCE = {
22
- CREATE_EXACT_MATCH: 0.95,
23
- NEAR_MATCH_REVIEW: 0.7,
24
- REPEAT_AMOUNT: 0.75,
25
- ANOMALY_REVIEW: 0.5,
26
- UNMATCHED_BANK: 0.8,
27
- UPDATE_CLEARED: 0.6,
26
+ CREATE_EXACT_MATCH: 0.95,
27
+ NEAR_MATCH_REVIEW: 0.7,
28
+ REPEAT_AMOUNT: 0.75,
29
+ ANOMALY_REVIEW: 0.5,
30
+ UNMATCHED_BANK: 0.8,
31
+ UPDATE_CLEARED: 0.6,
28
32
  } as const;
29
33
 
30
34
  /**
@@ -56,44 +60,44 @@ const PRIORITY_ORDER = { high: 3, medium: 2, low: 1 } as const;
56
60
  * // Returns recommendations like create_transaction, update_cleared, etc.
57
61
  */
58
62
  export function generateRecommendations(
59
- context: RecommendationContext,
63
+ context: RecommendationContext,
60
64
  ): ActionableRecommendation[] {
61
- const recommendations: ActionableRecommendation[] = [];
65
+ const recommendations: ActionableRecommendation[] = [];
62
66
 
63
- // Process insights from analyzer
64
- for (const insight of context.analysis.insights) {
65
- const recs = processInsight(insight, context);
66
- recommendations.push(...recs);
67
- }
67
+ // Process insights from analyzer
68
+ for (const insight of context.analysis.insights) {
69
+ const recs = processInsight(insight, context);
70
+ recommendations.push(...recs);
71
+ }
68
72
 
69
- // Process unmatched transactions
70
- const unmatchedRecs = processUnmatchedTransactions(context);
71
- recommendations.push(...unmatchedRecs);
73
+ // Process unmatched transactions
74
+ const unmatchedRecs = processUnmatchedTransactions(context);
75
+ recommendations.push(...unmatchedRecs);
72
76
 
73
- // Sort by priority and confidence
74
- return sortRecommendations(recommendations);
77
+ // Sort by priority and confidence
78
+ return sortRecommendations(recommendations);
75
79
  }
76
80
 
77
81
  /**
78
82
  * Process a single insight into recommendations
79
83
  */
80
84
  function processInsight(
81
- insight: ReconciliationInsight,
82
- context: RecommendationContext,
85
+ insight: ReconciliationInsight,
86
+ context: RecommendationContext,
83
87
  ): ActionableRecommendation[] {
84
- switch (insight.type) {
85
- case 'near_match':
86
- return [createNearMatchRecommendation(insight, context)];
88
+ switch (insight.type) {
89
+ case "near_match":
90
+ return [createNearMatchRecommendation(insight, context)];
87
91
 
88
- case 'repeat_amount':
89
- return createRepeatAmountRecommendations(insight, context);
92
+ case "repeat_amount":
93
+ return createRepeatAmountRecommendations(insight, context);
90
94
 
91
- case 'anomaly':
92
- return [createManualReviewRecommendation(insight, context)];
95
+ case "anomaly":
96
+ return [createManualReviewRecommendation(insight, context)];
93
97
 
94
- default:
95
- return [];
96
- }
98
+ default:
99
+ return [];
100
+ }
97
101
  }
98
102
 
99
103
  /**
@@ -136,274 +140,281 @@ function processInsight(
136
140
  * ); // Returns: create_transaction
137
141
  */
138
142
  function createSuggestedMatchRecommendation(
139
- match: TransactionMatch,
140
- context: RecommendationContext,
141
- ): CreateTransactionRecommendation | ReviewDuplicateRecommendation | ManualReviewRecommendation {
142
- const bankTxn = match.bankTransaction;
143
-
144
- // If there's a suggested YNAB transaction, review as possible duplicate
145
- if (match.ynabTransaction && match.confidence !== 'none') {
146
- return {
147
- id: randomUUID(),
148
- action_type: 'review_duplicate',
149
- priority: 'high',
150
- confidence: Math.max(0, Math.min(1, match.confidenceScore / 100)),
151
- message: `Review possible match: ${bankTxn.payee}`,
152
- reason: match.matchReason,
153
- estimated_impact: toMoneyValueFromDecimal(
154
- 0,
155
- context.analysis.balance_info.current_cleared.currency,
156
- ),
157
- account_id: context.account_id,
158
- metadata: {
159
- version: RECOMMENDATION_VERSION,
160
- created_at: new Date().toISOString(),
161
- },
162
- parameters: {
163
- candidate_ids: [match.ynabTransaction.id],
164
- bank_transaction: bankTxn,
165
- suggested_match_id: match.ynabTransaction.id,
166
- },
167
- };
168
- }
169
-
170
- // Check for combination matches (multiple YNAB transactions that together match the bank transaction)
171
- const isCombinationMatch = (match.candidates?.length ?? 0) > 1;
172
-
173
- if (isCombinationMatch) {
174
- return createCombinationReviewRecommendation(match, context);
175
- }
176
-
177
- // Otherwise suggest creating new transaction
178
- const parameters: CreateTransactionRecommendation['parameters'] = {
179
- account_id: context.account_id,
180
- date: bankTxn.date,
181
- amount: bankTxn.amount, // Amount is already milliunits
182
- payee_name: bankTxn.payee,
183
- cleared: 'cleared',
184
- approved: true,
185
- };
186
-
187
- if (bankTxn.memo) {
188
- parameters.memo = bankTxn.memo;
189
- }
190
-
191
- return {
192
- id: randomUUID(),
193
- action_type: 'create_transaction',
194
- priority: 'high',
195
- confidence: CONFIDENCE.CREATE_EXACT_MATCH,
196
- message: `Create transaction for ${bankTxn.payee}`,
197
- reason: `This transaction exactly matches your discrepancy`,
198
- estimated_impact: toMoneyValue(
199
- bankTxn.amount,
200
- context.analysis.balance_info.current_cleared.currency,
201
- ),
202
- account_id: context.account_id,
203
- metadata: {
204
- version: RECOMMENDATION_VERSION,
205
- created_at: new Date().toISOString(),
206
- },
207
- parameters,
208
- };
143
+ match: TransactionMatch,
144
+ context: RecommendationContext,
145
+ ):
146
+ | CreateTransactionRecommendation
147
+ | ReviewDuplicateRecommendation
148
+ | ManualReviewRecommendation {
149
+ const bankTxn = match.bankTransaction;
150
+
151
+ // If there's a suggested YNAB transaction, review as possible duplicate
152
+ if (match.ynabTransaction && match.confidence !== "none") {
153
+ return {
154
+ id: randomUUID(),
155
+ action_type: "review_duplicate",
156
+ priority: "high",
157
+ confidence: Math.max(0, Math.min(1, match.confidenceScore / 100)),
158
+ message: `Review possible match: ${bankTxn.payee}`,
159
+ reason: match.matchReason,
160
+ estimated_impact: toMoneyValueFromDecimal(
161
+ 0,
162
+ context.analysis.balance_info.current_cleared.currency,
163
+ ),
164
+ account_id: context.account_id,
165
+ metadata: {
166
+ version: RECOMMENDATION_VERSION,
167
+ created_at: new Date().toISOString(),
168
+ },
169
+ parameters: {
170
+ candidate_ids: [match.ynabTransaction.id],
171
+ bank_transaction: bankTxn,
172
+ suggested_match_id: match.ynabTransaction.id,
173
+ },
174
+ };
175
+ }
176
+
177
+ // Check for combination matches (multiple YNAB transactions that together match the bank transaction)
178
+ const isCombinationMatch = (match.candidates?.length ?? 0) > 1;
179
+
180
+ if (isCombinationMatch) {
181
+ return createCombinationReviewRecommendation(match, context);
182
+ }
183
+
184
+ // Otherwise suggest creating new transaction
185
+ const parameters: CreateTransactionRecommendation["parameters"] = {
186
+ account_id: context.account_id,
187
+ date: bankTxn.date,
188
+ amount: bankTxn.amount, // Amount is already milliunits
189
+ payee_name: bankTxn.payee,
190
+ cleared: "cleared",
191
+ approved: true,
192
+ };
193
+
194
+ if (bankTxn.memo) {
195
+ parameters.memo = bankTxn.memo;
196
+ }
197
+
198
+ return {
199
+ id: randomUUID(),
200
+ action_type: "create_transaction",
201
+ priority: "high",
202
+ confidence: CONFIDENCE.CREATE_EXACT_MATCH,
203
+ message: `Create transaction for ${bankTxn.payee}`,
204
+ reason: "This transaction exactly matches your discrepancy",
205
+ estimated_impact: toMoneyValue(
206
+ bankTxn.amount,
207
+ context.analysis.balance_info.current_cleared.currency,
208
+ ),
209
+ account_id: context.account_id,
210
+ metadata: {
211
+ version: RECOMMENDATION_VERSION,
212
+ created_at: new Date().toISOString(),
213
+ },
214
+ parameters,
215
+ };
209
216
  }
210
217
 
211
218
  /**
212
219
  * Create recommendation for combination match (multiple YNAB transactions matching one bank transaction)
213
220
  */
214
221
  function createCombinationReviewRecommendation(
215
- match: TransactionMatch,
216
- context: RecommendationContext,
222
+ match: TransactionMatch,
223
+ context: RecommendationContext,
217
224
  ): ManualReviewRecommendation {
218
- const bankTxn = match.bankTransaction;
219
- const candidateIds = match.candidates?.map((candidate) => candidate.ynab_transaction.id) ?? [];
220
-
221
- // Calculate total amount from candidates for context (convert from milliunits to decimal)
222
- const candidateTotalAmount =
223
- match.candidates?.reduce((sum, candidate) => {
224
- const amount = candidate.ynab_transaction.amount;
225
- if (!Number.isFinite(amount)) {
226
- console.warn(`Invalid candidate amount: ${amount}`);
227
- return sum;
228
- }
229
- return sum + fromMilli(amount);
230
- }, 0) ?? 0;
231
-
232
- return {
233
- id: randomUUID(),
234
- action_type: 'manual_review',
235
- priority: 'medium',
236
- confidence: CONFIDENCE.NEAR_MATCH_REVIEW,
237
- message: `Review combination match: ${bankTxn.payee}`,
238
- reason:
239
- match.recommendation ??
240
- 'Multiple YNAB transactions appear to match this bank transaction. Review before creating anything new.',
241
- estimated_impact: toMoneyValueFromDecimal(
242
- 0,
243
- context.analysis.balance_info.current_cleared.currency,
244
- ),
245
- account_id: context.account_id,
246
- metadata: {
247
- version: RECOMMENDATION_VERSION,
248
- created_at: new Date().toISOString(),
249
- bank_transaction_amount: toMoneyValue(
250
- bankTxn.amount,
251
- context.analysis.balance_info.current_cleared.currency,
252
- ),
253
- candidate_total_amount: toMoneyValueFromDecimal(
254
- candidateTotalAmount,
255
- context.analysis.balance_info.current_cleared.currency,
256
- ),
257
- candidate_count: match.candidates?.length ?? 0,
258
- },
259
- parameters: {
260
- issue_type: 'complex_match',
261
- related_transactions: [
262
- {
263
- source: 'bank',
264
- id: bankTxn.id,
265
- description: bankTxn.payee,
266
- },
267
- ...candidateIds.map((id) => ({
268
- source: 'ynab' as const,
269
- id,
270
- description:
271
- match.candidates?.find((c) => c.ynab_transaction.id === id)?.ynab_transaction.payee ??
272
- 'Unknown',
273
- })),
274
- ],
275
- },
276
- };
225
+ const bankTxn = match.bankTransaction;
226
+ const candidateIds =
227
+ match.candidates?.map((candidate) => candidate.ynab_transaction.id) ?? [];
228
+
229
+ // Calculate total amount from candidates for context (convert from milliunits to decimal)
230
+ const candidateTotalAmount =
231
+ match.candidates?.reduce((sum, candidate) => {
232
+ const amount = candidate.ynab_transaction.amount;
233
+ if (!Number.isFinite(amount)) {
234
+ console.warn(`Invalid candidate amount: ${amount}`);
235
+ return sum;
236
+ }
237
+ return sum + fromMilli(amount);
238
+ }, 0) ?? 0;
239
+
240
+ return {
241
+ id: randomUUID(),
242
+ action_type: "manual_review",
243
+ priority: "medium",
244
+ confidence: CONFIDENCE.NEAR_MATCH_REVIEW,
245
+ message: `Review combination match: ${bankTxn.payee}`,
246
+ reason:
247
+ match.recommendation ??
248
+ "Multiple YNAB transactions appear to match this bank transaction. Review before creating anything new.",
249
+ estimated_impact: toMoneyValueFromDecimal(
250
+ 0,
251
+ context.analysis.balance_info.current_cleared.currency,
252
+ ),
253
+ account_id: context.account_id,
254
+ metadata: {
255
+ version: RECOMMENDATION_VERSION,
256
+ created_at: new Date().toISOString(),
257
+ bank_transaction_amount: toMoneyValue(
258
+ bankTxn.amount,
259
+ context.analysis.balance_info.current_cleared.currency,
260
+ ),
261
+ candidate_total_amount: toMoneyValueFromDecimal(
262
+ candidateTotalAmount,
263
+ context.analysis.balance_info.current_cleared.currency,
264
+ ),
265
+ candidate_count: match.candidates?.length ?? 0,
266
+ },
267
+ parameters: {
268
+ issue_type: "complex_match",
269
+ related_transactions: [
270
+ {
271
+ source: "bank",
272
+ id: bankTxn.id,
273
+ description: bankTxn.payee,
274
+ },
275
+ ...candidateIds.map((id) => ({
276
+ source: "ynab" as const,
277
+ id,
278
+ description:
279
+ match.candidates?.find((c) => c.ynab_transaction.id === id)
280
+ ?.ynab_transaction.payee ?? "Unknown",
281
+ })),
282
+ ],
283
+ },
284
+ };
277
285
  }
278
286
 
279
287
  /**
280
288
  * Create recommendation for near match insight (possible duplicate)
281
289
  */
282
290
  function createNearMatchRecommendation(
283
- insight: ReconciliationInsight,
284
- context: RecommendationContext,
291
+ insight: ReconciliationInsight,
292
+ context: RecommendationContext,
285
293
  ): ManualReviewRecommendation {
286
- return {
287
- id: randomUUID(),
288
- action_type: 'manual_review',
289
- priority: 'medium',
290
- confidence: CONFIDENCE.NEAR_MATCH_REVIEW,
291
- message: `Review: ${insight.title}`,
292
- reason: insight.description,
293
- estimated_impact: toMoneyValueFromDecimal(
294
- 0,
295
- context.analysis.balance_info.current_cleared.currency,
296
- ),
297
- account_id: context.account_id,
298
- source_insight_id: insight.id,
299
- metadata: {
300
- version: RECOMMENDATION_VERSION,
301
- created_at: new Date().toISOString(),
302
- current_discrepancy: context.analysis.balance_info.discrepancy,
303
- insight_severity: insight.severity,
304
- },
305
- parameters: {
306
- issue_type: 'complex_match',
307
- },
308
- };
294
+ return {
295
+ id: randomUUID(),
296
+ action_type: "manual_review",
297
+ priority: "medium",
298
+ confidence: CONFIDENCE.NEAR_MATCH_REVIEW,
299
+ message: `Review: ${insight.title}`,
300
+ reason: insight.description,
301
+ estimated_impact: toMoneyValueFromDecimal(
302
+ 0,
303
+ context.analysis.balance_info.current_cleared.currency,
304
+ ),
305
+ account_id: context.account_id,
306
+ source_insight_id: insight.id,
307
+ metadata: {
308
+ version: RECOMMENDATION_VERSION,
309
+ created_at: new Date().toISOString(),
310
+ current_discrepancy: context.analysis.balance_info.discrepancy,
311
+ insight_severity: insight.severity,
312
+ },
313
+ parameters: {
314
+ issue_type: "complex_match",
315
+ },
316
+ };
309
317
  }
310
318
 
311
319
  /**
312
320
  * Create recommendations for repeat amount pattern
313
321
  */
314
322
  function createRepeatAmountRecommendations(
315
- insight: ReconciliationInsight,
316
- context: RecommendationContext,
323
+ insight: ReconciliationInsight,
324
+ context: RecommendationContext,
317
325
  ): ManualReviewRecommendation[] {
318
- // For repeat amounts, suggest manual review since we need to identify the specific transactions
319
- return [
320
- {
321
- id: randomUUID(),
322
- action_type: 'manual_review',
323
- priority: 'medium',
324
- confidence: CONFIDENCE.REPEAT_AMOUNT,
325
- message: `Review recurring pattern: ${insight.title}`,
326
- reason: insight.description,
327
- estimated_impact: toMoneyValueFromDecimal(
328
- 0,
329
- context.analysis.balance_info.current_cleared.currency,
330
- ),
331
- account_id: context.account_id,
332
- source_insight_id: insight.id,
333
- metadata: {
334
- version: RECOMMENDATION_VERSION,
335
- created_at: new Date().toISOString(),
336
- current_discrepancy: context.analysis.balance_info.discrepancy,
337
- insight_severity: insight.severity,
338
- },
339
- parameters: {
340
- issue_type: 'complex_match',
341
- },
342
- },
343
- ];
326
+ // For repeat amounts, suggest manual review since we need to identify the specific transactions
327
+ return [
328
+ {
329
+ id: randomUUID(),
330
+ action_type: "manual_review",
331
+ priority: "medium",
332
+ confidence: CONFIDENCE.REPEAT_AMOUNT,
333
+ message: `Review recurring pattern: ${insight.title}`,
334
+ reason: insight.description,
335
+ estimated_impact: toMoneyValueFromDecimal(
336
+ 0,
337
+ context.analysis.balance_info.current_cleared.currency,
338
+ ),
339
+ account_id: context.account_id,
340
+ source_insight_id: insight.id,
341
+ metadata: {
342
+ version: RECOMMENDATION_VERSION,
343
+ created_at: new Date().toISOString(),
344
+ current_discrepancy: context.analysis.balance_info.discrepancy,
345
+ insight_severity: insight.severity,
346
+ },
347
+ parameters: {
348
+ issue_type: "complex_match",
349
+ },
350
+ },
351
+ ];
344
352
  }
345
353
 
346
354
  /**
347
355
  * Create manual review recommendation (fallback)
348
356
  */
349
357
  function createManualReviewRecommendation(
350
- insight: ReconciliationInsight,
351
- context: RecommendationContext,
358
+ insight: ReconciliationInsight,
359
+ context: RecommendationContext,
352
360
  ): ManualReviewRecommendation {
353
- return {
354
- id: randomUUID(),
355
- action_type: 'manual_review',
356
- priority: 'low',
357
- confidence: CONFIDENCE.ANOMALY_REVIEW,
358
- message: `Review: ${insight.title}`,
359
- reason: insight.description,
360
- estimated_impact: toMoneyValueFromDecimal(
361
- 0,
362
- context.analysis.balance_info.current_cleared.currency,
363
- ),
364
- account_id: context.account_id,
365
- source_insight_id: insight.id,
366
- metadata: {
367
- version: RECOMMENDATION_VERSION,
368
- created_at: new Date().toISOString(),
369
- current_discrepancy: context.analysis.balance_info.discrepancy,
370
- insight_severity: insight.severity,
371
- },
372
- parameters: {
373
- issue_type: insight.severity === 'critical' ? 'large_discrepancy' : 'unknown',
374
- },
375
- };
361
+ return {
362
+ id: randomUUID(),
363
+ action_type: "manual_review",
364
+ priority: "low",
365
+ confidence: CONFIDENCE.ANOMALY_REVIEW,
366
+ message: `Review: ${insight.title}`,
367
+ reason: insight.description,
368
+ estimated_impact: toMoneyValueFromDecimal(
369
+ 0,
370
+ context.analysis.balance_info.current_cleared.currency,
371
+ ),
372
+ account_id: context.account_id,
373
+ source_insight_id: insight.id,
374
+ metadata: {
375
+ version: RECOMMENDATION_VERSION,
376
+ created_at: new Date().toISOString(),
377
+ current_discrepancy: context.analysis.balance_info.discrepancy,
378
+ insight_severity: insight.severity,
379
+ },
380
+ parameters: {
381
+ issue_type:
382
+ insight.severity === "critical" ? "large_discrepancy" : "unknown",
383
+ },
384
+ };
376
385
  }
377
386
 
378
387
  /**
379
388
  * Process unmatched transactions into recommendations
380
389
  */
381
- function processUnmatchedTransactions(context: RecommendationContext): ActionableRecommendation[] {
382
- const recommendations: ActionableRecommendation[] = [];
383
-
384
- // Unmatched bank transactions → create_transaction
385
- for (const bankTxn of context.analysis.unmatched_bank) {
386
- recommendations.push(createUnmatchedBankRecommendation(bankTxn, context));
387
- }
388
-
389
- // Suggested matches → review as potential duplicates or auto-match
390
- const matchesForReview = [
391
- ...context.analysis.suggested_matches,
392
- ...context.analysis.auto_matches,
393
- ];
394
-
395
- for (const match of matchesForReview) {
396
- recommendations.push(createSuggestedMatchRecommendation(match, context));
397
- }
398
-
399
- // Unmatched YNAB uncleared → update_cleared (lower priority)
400
- for (const ynabTxn of context.analysis.unmatched_ynab) {
401
- if (ynabTxn.cleared === 'uncleared') {
402
- recommendations.push(createUpdateClearedRecommendation(ynabTxn, context));
403
- }
404
- }
405
-
406
- return recommendations;
390
+ function processUnmatchedTransactions(
391
+ context: RecommendationContext,
392
+ ): ActionableRecommendation[] {
393
+ const recommendations: ActionableRecommendation[] = [];
394
+
395
+ // Unmatched bank transactions → create_transaction
396
+ for (const bankTxn of context.analysis.unmatched_bank) {
397
+ recommendations.push(createUnmatchedBankRecommendation(bankTxn, context));
398
+ }
399
+
400
+ // Suggested matches → review as potential duplicates or auto-match
401
+ const matchesForReview = [
402
+ ...context.analysis.suggested_matches,
403
+ ...context.analysis.auto_matches,
404
+ ];
405
+
406
+ for (const match of matchesForReview) {
407
+ recommendations.push(createSuggestedMatchRecommendation(match, context));
408
+ }
409
+
410
+ // Unmatched YNAB uncleared → update_cleared (lower priority)
411
+ for (const ynabTxn of context.analysis.unmatched_ynab) {
412
+ if (ynabTxn.cleared === "uncleared") {
413
+ recommendations.push(createUpdateClearedRecommendation(ynabTxn, context));
414
+ }
415
+ }
416
+
417
+ return recommendations;
407
418
  }
408
419
 
409
420
  /**
@@ -418,40 +429,40 @@ function processUnmatchedTransactions(context: RecommendationContext): Actionabl
418
429
  * @returns create_transaction recommendation with medium priority and 0.8 confidence
419
430
  */
420
431
  function createUnmatchedBankRecommendation(
421
- txn: BankTransaction,
422
- context: RecommendationContext,
432
+ txn: BankTransaction,
433
+ context: RecommendationContext,
423
434
  ): CreateTransactionRecommendation {
424
- const parameters: CreateTransactionRecommendation['parameters'] = {
425
- account_id: context.account_id,
426
- date: txn.date,
427
- amount: txn.amount, // Amount is already milliunits
428
- payee_name: txn.payee,
429
- cleared: 'cleared',
430
- approved: true,
431
- };
432
-
433
- if (txn.memo) {
434
- parameters.memo = txn.memo;
435
- }
436
-
437
- return {
438
- id: randomUUID(),
439
- action_type: 'create_transaction',
440
- priority: 'medium',
441
- confidence: CONFIDENCE.UNMATCHED_BANK,
442
- message: `Create missing transaction: ${txn.payee}`,
443
- reason: 'Transaction appears on bank statement but not in YNAB',
444
- estimated_impact: toMoneyValue(
445
- txn.amount,
446
- context.analysis.balance_info.current_cleared.currency,
447
- ),
448
- account_id: context.account_id,
449
- metadata: {
450
- version: RECOMMENDATION_VERSION,
451
- created_at: new Date().toISOString(),
452
- },
453
- parameters,
454
- };
435
+ const parameters: CreateTransactionRecommendation["parameters"] = {
436
+ account_id: context.account_id,
437
+ date: txn.date,
438
+ amount: txn.amount, // Amount is already milliunits
439
+ payee_name: txn.payee,
440
+ cleared: "cleared",
441
+ approved: true,
442
+ };
443
+
444
+ if (txn.memo) {
445
+ parameters.memo = txn.memo;
446
+ }
447
+
448
+ return {
449
+ id: randomUUID(),
450
+ action_type: "create_transaction",
451
+ priority: "medium",
452
+ confidence: CONFIDENCE.UNMATCHED_BANK,
453
+ message: `Create missing transaction: ${txn.payee}`,
454
+ reason: "Transaction appears on bank statement but not in YNAB",
455
+ estimated_impact: toMoneyValue(
456
+ txn.amount,
457
+ context.analysis.balance_info.current_cleared.currency,
458
+ ),
459
+ account_id: context.account_id,
460
+ metadata: {
461
+ version: RECOMMENDATION_VERSION,
462
+ created_at: new Date().toISOString(),
463
+ },
464
+ parameters,
465
+ };
455
466
  }
456
467
 
457
468
  /**
@@ -467,44 +478,45 @@ function createUnmatchedBankRecommendation(
467
478
  * @returns update_cleared recommendation with low priority and 0.6 confidence
468
479
  */
469
480
  function createUpdateClearedRecommendation(
470
- txn: YNABTransaction,
471
- context: RecommendationContext,
481
+ txn: YNABTransaction,
482
+ context: RecommendationContext,
472
483
  ): UpdateClearedRecommendation {
473
- return {
474
- id: randomUUID(),
475
- action_type: 'update_cleared',
476
- priority: 'low',
477
- confidence: CONFIDENCE.UPDATE_CLEARED,
478
- message: `Mark transaction as cleared: ${txn.payee || 'Unknown'}`,
479
- reason: 'Transaction exists in YNAB but not yet cleared',
480
- estimated_impact: toMoneyValueFromDecimal(
481
- 0,
482
- context.analysis.balance_info.current_cleared.currency,
483
- ),
484
- account_id: context.account_id,
485
- metadata: {
486
- version: RECOMMENDATION_VERSION,
487
- created_at: new Date().toISOString(),
488
- },
489
- parameters: {
490
- transaction_id: txn.id,
491
- cleared: 'cleared',
492
- },
493
- };
484
+ return {
485
+ id: randomUUID(),
486
+ action_type: "update_cleared",
487
+ priority: "low",
488
+ confidence: CONFIDENCE.UPDATE_CLEARED,
489
+ message: `Mark transaction as cleared: ${txn.payee || "Unknown"}`,
490
+ reason: "Transaction exists in YNAB but not yet cleared",
491
+ estimated_impact: toMoneyValueFromDecimal(
492
+ 0,
493
+ context.analysis.balance_info.current_cleared.currency,
494
+ ),
495
+ account_id: context.account_id,
496
+ metadata: {
497
+ version: RECOMMENDATION_VERSION,
498
+ created_at: new Date().toISOString(),
499
+ },
500
+ parameters: {
501
+ transaction_id: txn.id,
502
+ cleared: "cleared",
503
+ },
504
+ };
494
505
  }
495
506
 
496
507
  /**
497
508
  * Sort recommendations by priority and confidence
498
509
  */
499
510
  function sortRecommendations(
500
- recommendations: ActionableRecommendation[],
511
+ recommendations: ActionableRecommendation[],
501
512
  ): ActionableRecommendation[] {
502
- return recommendations.sort((a, b) => {
503
- // Sort by priority first
504
- const priorityDiff = PRIORITY_ORDER[b.priority] - PRIORITY_ORDER[a.priority];
505
- if (priorityDiff !== 0) return priorityDiff;
506
-
507
- // Then by confidence
508
- return b.confidence - a.confidence;
509
- });
513
+ return recommendations.sort((a, b) => {
514
+ // Sort by priority first
515
+ const priorityDiff =
516
+ PRIORITY_ORDER[b.priority] - PRIORITY_ORDER[a.priority];
517
+ if (priorityDiff !== 0) return priorityDiff;
518
+
519
+ // Then by confidence
520
+ return b.confidence - a.confidence;
521
+ });
510
522
  }