@critiq/rules 0.3.0 → 0.4.0

package/rules/typescript/ts.correctness.regexp-pattern-unusual-control-character.rule.yaml

@@ -5,6 +5,8 @@ metadata:
   title: Unusual ASCII control characters in regexp pattern
   summary: The regular expression pattern embeds low ASCII control characters outside common whitespace.
   rationale: Literal control characters in patterns are hard to read, easy to corrupt in editors, and often indicate copy-paste or encoding mistakes.
+  aliases:
+    - JS-0004
   tags:
     - correctness
     - language

package/rules/typescript/ts.correctness.regexp-useless-backreference.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.regexp-useless-backreference
+  title: Useless regex backreference
+  summary: Detects useless regex backreference issues in JavaScript and TypeScript source.
+  rationale: Useless regex backreference patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0039
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.regexp-useless-backreference
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix useless regex backreference
+    summary: "`${captures.issue.text}` matches ts.correctness.regexp-useless-backreference."
+  remediation:
+    summary: Refactor the code to remove the useless regex backreference pattern.

package/rules/typescript/ts.correctness.require-outside-import.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.require-outside-import
+  title: Require outside import statement
+  summary: Use ES module `import` syntax instead of `require()` calls.
+  rationale: Prefer ES module `import` syntax over CommonJS `require()` in JavaScript and TypeScript files.
+  aliases:
+    - JS-0359
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.require-outside-import
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Replace require() with ES module import
+    summary: "`${captures.issue.text}` uses require() instead of import."
+  remediation:
+    summary: Replace the `require()` call with an ES module `import` statement.

package/rules/typescript/ts.correctness.restricted-global-variable.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.restricted-global-variable
+  title: Restricted global variable
+  summary: Detects restricted global variable issues in JavaScript and TypeScript source.
+  rationale: Restricted global variable patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0122
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.restricted-global-variable
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix restricted global variable
+    summary: "`${captures.issue.text}` matches ts.correctness.restricted-global-variable."
+  remediation:
+    summary: Refactor the code to remove the restricted global variable pattern.

package/rules/typescript/ts.correctness.restricted-object-property.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.restricted-object-property
+  title: Restricted object property access
+  summary: Detects restricted object property access issues in JavaScript and TypeScript source.
+  rationale: Restricted object property access is a style and safety concern, not a security issue; most flagged properties are deliberate surface reductions.
+  aliases:
+    - JS-0110
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.restricted-object-property
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: low
+    confidence: 0.50
+    tags:
+      - correctness
+      - language
+  message:
+    title: Remove assignment to restricted property on built-in prototype
+    summary: "`${captures.issue.text}` assigns to a restricted property on a built-in prototype. Mutating built-in prototypes affects all instances globally and can cause unpredictable behavior across the entire application."
+  remediation:
+    summary: Refactor the code to remove the restricted object property access pattern.

package/rules/typescript/ts.correctness.self-assignment.rule.yaml

@@ -4,6 +4,8 @@ metadata:
   id: ts.correctness.self-assignment
   title: Self assignment
   summary: An assignment uses the same expression on the left and right side.
+  aliases:
+    - JS-0088
   rationale: Self-assignments are almost always dead code or a typo where a different value was intended.
   tags:
     - correctness

package/rules/typescript/ts.correctness.setter-return-value.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.setter-return-value
+  title: Return value from setter
+  summary: Detects return value from setter issues in JavaScript and TypeScript source.
+  rationale: Return value from setter patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0037
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.setter-return-value
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix return value from setter
+    summary: "`${captures.issue.text}` matches ts.correctness.setter-return-value."
+  remediation:
+    summary: Refactor the code to remove the return value from setter pattern.

package/rules/typescript/ts.correctness.simplify-boolean-return.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.simplify-boolean-return
+  title: Complex boolean return
+  summary: Return statements that explicitly return true/false based on a condition can be simplified.
+  rationale: "`if (x) return true; else return false;` is equivalent to `return x;`. The complex form adds noise and makes the code harder to read."
+  aliases:
+    - JS-W1041
+  tags:
+    - correctness
+    - language
+    - simplification
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: block
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.complex-boolean-return
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 0.95
+    tags:
+      - correctness
+      - language
+  message:
+    title: Simplify boolean return
+    summary: "`${captures.issue.text}` can be simplified to a direct boolean return."
+  remediation:
+    summary: Replace the if/else or ternary with `return <condition>;`.

package/rules/typescript/ts.correctness.sparse-array-literal.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.sparse-array-literal
+  title: Sparse array literal
+  summary: An array literal contains empty slots that create a sparse array.
+  rationale: Sparse arrays have surprising iteration semantics and often indicate typos or incomplete edits.
+  aliases:
+    - JS-0023
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - crq-cor-045
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.sparse-array-literal
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: low
+    confidence: 0.50
+    tags:
+      - correctness
+      - language
+  message:
+    title: Avoid sparse array literals
+    summary: "`${captures.issue.text}` creates an array with empty slots."
+  remediation:
+    summary: Fill missing entries explicitly or use a dense data structure when holes are not intentional.

package/rules/typescript/ts.correctness.switch-case-fallthrough.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.switch-case-fallthrough
+  title: Switch case fallthrough
+  summary: Detects switch case fallthrough issues in JavaScript and TypeScript source.
+  rationale: Switch case fallthrough patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0064
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.switch-case-fallthrough
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix switch case fallthrough
+    summary: "`${captures.issue.text}` matches ts.correctness.switch-case-fallthrough."
+  remediation:
+    summary: Refactor the code to remove the switch case fallthrough pattern.

package/rules/typescript/ts.correctness.template-placeholder-in-string.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.template-placeholder-in-string
+  title: Template placeholder in regular string
+  summary: Detects template placeholder in regular string issues in JavaScript and TypeScript source.
+  rationale: Template placeholder in regular string patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0038
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.template-placeholder-in-string
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix template placeholder in regular string
+    summary: "`${captures.issue.text}` matches ts.correctness.template-placeholder-in-string."
+  remediation:
+    summary: Refactor the code to remove the template placeholder in regular string pattern.

package/rules/typescript/ts.correctness.this-before-super.rule.yaml

@@ -5,11 +5,14 @@ metadata:
   title: this used before super()
   summary: Do not use this or super members before calling super() in a subclass constructor.
   rationale: Accessing this before super() in a derived constructor throws at runtime.
+  aliases:
+    - JS-0235
   tags:
     - correctness
     - language
     - rules-catalog
     - crq-cor-035
+    - public-directory-parity
   stability: stable
   appliesTo: file
 scope:

package/rules/typescript/ts.correctness.this-outside-class.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.this-outside-class
+  title: Found `this` keyword outside of classes
+  summary: Do not use the `this` keyword outside of a class body.
+  rationale: Using `this` outside of a class typically refers to the global object (undefined in strict mode), which is rarely the intended behavior and can lead to subtle bugs.
+  aliases:
+    - JS-B002
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: experimental
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.this-outside-class
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 0.95
+    tags:
+      - correctness
+      - language
+  message:
+    title: Remove `this` usage outside of class
+    summary: "`${captures.issue.text}` uses `this` outside of a class body."
+  remediation:
+    summary: Refactor the code to avoid using `this` outside of a class. Replace `this` with the intended reference or use a local variable instead.

package/rules/typescript/ts.correctness.undeclared-variable.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.undeclared-variable
+  title: Undeclared variable reference
+  summary: Detects undeclared variable reference issues in JavaScript and TypeScript source.
+  rationale: Undeclared variable reference patterns are scope-analysis hints that rarely represent runtime bugs; most are parser artifacts or dynamic-pattern noise.
+  aliases:
+    - JS-0125
+    - JS-0423
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.undeclared-variable
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: low
+    confidence: 0.50
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix undeclared variable reference
+    summary: "`${captures.issue.text}` matches ts.correctness.undeclared-variable."
+  remediation:
+    summary: Refactor the code to remove the undeclared variable reference pattern.

package/rules/typescript/ts.correctness.unhandled-async-error.rule.yaml

@@ -16,6 +16,12 @@ scope:
   languages:
     - typescript
     - javascript
+  paths:
+    exclude:
+      - "**/*.test.*"
+      - "**/*.spec.*"
+      - "**/__tests__/**"
+      - "**/tests/**"
 match:
   fact:
     kind: async.unhandled-async-error
@@ -23,7 +29,7 @@ match:
 emit:
   finding:
     category: correctness.async
-    severity: high
+    severity: medium
     confidence: 0.85
     tags:
       - correctness

package/rules/typescript/ts.correctness.unnecessary-return-await.rule.yaml

@@ -5,6 +5,8 @@ metadata:
   title: Unnecessary Return Await
   summary: Remove redundant return await
   rationale: Remove redundant return await:return await in async functions outside try/catch adds stack overhead without changing behavior.
+  aliases:
+    - JS-0111
   tags:
     - correctness
     - rules-catalog

package/rules/typescript/ts.correctness.unresolved-import.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.unresolved-import
+  title: Avoid unresolved module imports
+  summary: Import declarations should reference modules that exist on disk or in node_modules.
+  rationale: Importing a module that cannot be resolved will cause a build or runtime error. This typically happens after refactoring, file renames, or incorrect module paths.
+  aliases:
+    - JS-E1010
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: experimental
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.unresolved-import
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Import path does not resolve to a file or package
+    summary: "`${captures.issue.text}` could not be resolved to an existing module."
+  remediation:
+    summary: Update the import path or install the missing dependency.

package/rules/typescript/ts.correctness.unsafe-negation-in-relational.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.unsafe-negation-in-relational
+  title: Negated left operand in relational expression
+  summary: A relational or membership test applies unary `!` to the left operand instead of negating the whole comparison.
+  rationale: Expressions like `!key in object` parse as `(!key) in object`, which is usually not what authors intend.
+  aliases:
+    - JS-0019
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - crq-cor-042
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.unsafe-negation-in-relational
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.9
+    tags:
+      - correctness
+      - language
+  message:
+    title: Parenthesize negated relational comparisons
+    summary: "`${captures.issue.text}` negates only the left operand of a relational or membership operator."
+  remediation:
+    summary: Wrap the full comparison in parentheses, for example `!(left in right)` or `!(left instanceof Type)`.

package/rules/typescript/ts.correctness.unused-expression.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.unused-expression
+  title: Unused expressions found
+  summary: Expression statement has no side effects and its result is discarded.
+  rationale: Expressions without side effects whose results are discarded indicate dead code or a programming mistake (e.g., `a && b` instead of `if (a) b()`).
+  aliases:
+    - JS-B003
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.unused-expression
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.70
+    tags:
+      - correctness
+      - language
+  message:
+    title: Remove or use the result of this expression
+    summary: "`${captures.issue.text}` has no side effects and its result is discarded."
+  remediation:
+    summary: Either assign the expression result to a variable, use it in a condition, or remove the dead code entirely.

package/rules/typescript/ts.correctness.unused-variable.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.unused-variable
+  title: Unused variable
+  summary: Detects unused variable issues in JavaScript and TypeScript source.
+  rationale: Unused variables represent dead code and cleanup opportunities; they rarely indicate correctness bugs.
+  aliases:
+    - JS-0128
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.unused-variable
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: low
+    confidence: 0.55
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix unused variable
+    summary: "`${captures.issue.text}` matches ts.correctness.unused-variable."
+  remediation:
+    summary: Refactor the code to remove the unused variable pattern.

package/rules/typescript/ts.correctness.use-number-is-nan.rule.yaml

@@ -5,6 +5,8 @@ metadata:
   title: Use Number.isNaN for NaN checks
   summary: Do not compare values to NaN with `===` or `==`.
   rationale: NaN is not equal to itself; identity comparisons are always false.
+  aliases:
+    - JS-0027
   tags:
     - correctness
     - language

package/rules/typescript/ts.correctness.used-before-definition.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.used-before-definition
+  title: Variable used before definition
+  summary: Detects variable used before definition issues in JavaScript and TypeScript source.
+  rationale: Variable used-before-definition patterns are mostly hoisting and TDZ analysis artifacts; they rarely indicate real bugs.
+  aliases:
+    - JS-0129
+    - JS-0357
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.used-before-definition
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: low
+    confidence: 0.50
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix variable used before definition
+    summary: "`${captures.issue.text}` matches ts.correctness.used-before-definition."
+  remediation:
+    summary: Refactor the code to remove the variable used before definition pattern.