@critiq/rules 0.3.0 → 0.4.0

package/rules/php/php.correctness.invalid-return-typehint.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.invalid-return-typehint
+  title: Use valid function return typehints
+  summary: Use valid function return typehints
+  rationale: Use valid function return typehints
+  aliases:
+    - PHP-T1002
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: stable
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.invalid-return-typehint
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: critical
+    confidence: 0.9
+    tags:
+      - correctness
+      - php
+  message:
+    title: Use valid function return typehints
+    summary: "`${captures.issue.text}` matches php.correctness.invalid-return-typehint."
+  remediation:
+    summary: Use valid function return typehints

package/rules/php/php.correctness.invalid-static-method.rule.yaml

@@ -0,0 +1,40 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.invalid-static-method
+  title: Static call to instance method
+  summary: "Calling self::method() or static::method() when the method is not declared as static will produce a deprecation notice in PHP 8.2+ and an error in future versions."
+  aliases:
+    - PHP-E1003
+  rationale: "PHP deprecates static calls to non-static methods as of PHP 8.2. Single-file heuristic checks the enclosing class body for the method declaration and verifies it has the static keyword. Classes extending other classes are skipped."
+  detection:
+    kind: pattern
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.invalid-static-method
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: critical
+    confidence: 0.65
+    tags:
+      - correctness
+      - php
+  message:
+    title: Static call to instance method ${captures.issue.text}
+    summary: "Method ${captures.issue.text}() is called via self:: or static:: but is not declared as static in the enclosing class."
+  remediation:
+    summary: Add the static keyword to the method declaration or use $this->method() for instance calls.

package/rules/php/php.correctness.invalid-string-interpolation-type.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.invalid-string-interpolation-type
+  title: Avoid using non-scalar types in string interpolation
+  summary: String interpolation with objects, arrays, or array literals using `${...}` syntax produces unexpected results. The resulting string will contain "Object" or "Array" rather than a meaningful representation.
+  aliases:
+    - PHP-W1043
+  rationale: PHP's string interpolation converts objects and arrays to the strings "Object" and "Array" respectively, which is almost never the intended output. Objects must implement __toString() and arrays must be handled explicitly.
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.invalid-string-interpolation-type
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 0.7
+    tags:
+      - correctness
+      - php
+  message:
+    title: Non-scalar type used in string interpolation
+    summary: "`${captures.issue.text}` uses a non-scalar expression inside string interpolation. The result will not be the intended value."
+  remediation:
+    summary: Convert the value to a string explicitly before interpolation, or use sprintf for structured formatting.

package/rules/php/php.correctness.invalid-type-cast.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.invalid-type-cast
+  title: Use valid PHP cast types
+  summary: Use valid PHP cast types
+  rationale: Use valid PHP cast types
+  aliases:
+    - PHP-W1042
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: stable
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.invalid-type-cast
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: critical
+    confidence: 0.9
+    tags:
+      - correctness
+      - php
+  message:
+    title: Use valid PHP cast types
+    summary: "`${captures.issue.text}` matches php.correctness.invalid-type-cast."
+  remediation:
+    summary: Use valid PHP cast types

package/rules/php/php.correctness.invalid-use-keyword.rule.yaml

@@ -0,0 +1,48 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.invalid-use-keyword
+  title: Invalid use of `use` keyword
+  summary: The `use` keyword is used in a context where it does not apply — inside interfaces, anonymous classes, or referencing a non-trait class.
+  aliases:
+    - PHP-W1011
+  rationale: >-
+    The `use` keyword in a class/interface/trait body imports a trait. Applying it
+    inside an interface or anonymous class is invalid. Using it with a non-trait
+    class name also causes a fatal error. Cross-file trait existence is not checked
+    in this single-file heuristic, which may produce false negatives.
+  detection:
+    kind: pattern
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.invalid-use-keyword
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: critical
+    confidence: 0.75
+    tags:
+      - correctness
+      - php
+  message:
+    title: Invalid use of `use` keyword in ${captures.issue.text}
+    summary: >-
+      ${captures.issue.text} uses `use` in an interface body, anonymous class body,
+      or references a non-trait class — PHP will raise a fatal error.
+  remediation:
+    summary: >-
+      Remove the `use` statement from interface and anonymous class bodies.
+      When using `use` in a class body, ensure the referenced name is a trait.

package/rules/php/php.correctness.missing-member-visibility.rule.yaml

@@ -4,6 +4,8 @@ metadata:
   id: php.correctness.missing-member-visibility
   title: Declare explicit member visibility
   summary: Class properties and methods should declare public, protected, or private visibility.
+  aliases:
+    - PHP-W1088
   rationale: Missing visibility relies on legacy defaults and makes class contracts harder to review.
   tags:
     - correctness

package/rules/php/php.correctness.missing-return-statement.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.missing-return-statement
+  title: Add missing return statement
+  summary: Functions and methods with non-void return types should contain at least one return statement.
+  aliases:
+    - PHP-E1004
+  rationale: A function or method declared with a return type that never reaches a return statement will cause a runtime error.
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.missing-return-statement
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: critical
+    confidence: 0.55
+    tags:
+      - correctness
+      - php
+  message:
+    title: Add missing return statement
+    summary: "`${captures.issue.text}` has a return type declaration but no return statement."
+  remediation:
+    summary: Ensure every code path in a typed function or method returns a value matching the declared return type.

package/rules/php/php.correctness.named-arg-before-positional.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.named-arg-before-positional
+  title: Positional arguments cannot follow named arguments
+  summary: Positional arguments cannot follow named arguments
+  rationale: Positional arguments cannot follow named arguments
+  aliases:
+    - PHP-W1020
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: stable
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.named-arg-before-positional
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: critical
+    confidence: 0.9
+    tags:
+      - correctness
+      - php
+  message:
+    title: Positional arguments cannot follow named arguments
+    summary: "`${captures.issue.text}` matches php.correctness.named-arg-before-positional."
+  remediation:
+    summary: Positional arguments cannot follow named arguments

package/rules/php/php.correctness.nested-function-declaration.rule.yaml

@@ -4,6 +4,8 @@ metadata:
   id: php.correctness.nested-function-declaration
   title: Avoid nested function declarations
   summary: Declaring functions inside other functions is discouraged and hard to test.
+  aliases:
+    - PHP-W1023
   rationale: Nested functions create hidden scope and make code harder to reuse, mock, and reason about.
   tags:
     - correctness

package/rules/php/php.correctness.nested-switch.rule.yaml

@@ -4,6 +4,8 @@ metadata:
   id: php.correctness.nested-switch
   title: Avoid nested switch statements
   summary: Switch statements nested inside other switch statements are hard to follow.
+  aliases:
+    - PHP-W1091
   rationale: Nested switch blocks increase cognitive load and often hide missing decomposition or polymorphism.
   tags:
     - correctness

package/rules/php/php.correctness.nullable-mixed-type.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.nullable-mixed-type
+  title: Nullable mixed type is not allowed
+  summary: Nullable mixed type is not allowed
+  rationale: Nullable mixed type is not allowed
+  aliases:
+    - PHP-T1006
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: stable
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.nullable-mixed-type
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: critical
+    confidence: 0.9
+    tags:
+      - correctness
+      - php
+  message:
+    title: Nullable mixed type is not allowed
+    summary: "`${captures.issue.text}` matches php.correctness.nullable-mixed-type."
+  remediation:
+    summary: Nullable mixed type is not allowed

package/rules/php/php.correctness.nullsafe-returned-by-reference.rule.yaml

@@ -4,6 +4,9 @@ metadata:
   id: php.correctness.nullsafe-returned-by-reference
   title: Do not return nullsafe access by reference
   summary: By-reference arrow functions cannot safely return nullsafe property access.
+  aliases:
+    - PHP-W1019
+    - PHP-W1026
   rationale: Nullsafe access may evaluate to null, which cannot be returned by reference and triggers runtime errors.
   tags:
     - correctness

package/rules/php/php.correctness.print-invalid-value.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.print-invalid-value
+  title: Do not print non-string values
+  summary: print should only be used with strings. Objects, arrays, and array() expressions cannot be meaningfully converted to strings by print.
+  aliases:
+    - PHP-W1044
+  rationale: Using print with non-scalar values like objects or arrays produces unexpected output or warnings. Objects must implement __toString() for meaningful output; arrays always produce "Array" which is almost never the intent.
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: stable
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.print-invalid-value
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: critical
+    confidence: 0.85
+    tags:
+      - correctness
+      - php
+  message:
+    title: print called with non-string value
+    summary: "`${captures.issue.text}` passes a non-scalar value to print, which may produce a warning or unexpected output."
+  remediation:
+    summary: Convert the value to a string before printing, or use var_dump / print_r for debugging output.

package/rules/php/php.correctness.psr-class-constant-naming.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.psr-class-constant-naming
+  title: Use PSR-12 uppercase snake case for class constants
+  summary: Use PSR-12 uppercase snake case for class constants
+  rationale: Use PSR-12 uppercase snake case for class constants
+  aliases:
+    - PHP-C1000
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: stable
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.psr-class-constant-naming
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 0.9
+    tags:
+      - correctness
+      - php
+  message:
+    title: Use PSR-12 uppercase snake case for class constants
+    summary: "`${captures.issue.text}` matches php.correctness.psr-class-constant-naming."
+  remediation:
+    summary: Use PSR-12 uppercase snake case for class constants

package/rules/php/php.correctness.psr-method-camel-case.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.psr-method-camel-case
+  title: Use camelCase for class method names
+  summary: Use camelCase for class method names
+  rationale: Use camelCase for class method names
+  aliases:
+    - PHP-C1001
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: stable
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.psr-method-camel-case
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 0.9
+    tags:
+      - correctness
+      - php
+  message:
+    title: Use camelCase for class method names
+    summary: "`${captures.issue.text}` matches php.correctness.psr-method-camel-case."
+  remediation:
+    summary: Use camelCase for class method names

package/rules/php/php.correctness.redundant-final-method.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.redundant-final-method
+  title: Final methods are redundant in final classes
+  summary: Final methods are redundant in final classes
+  rationale: Final methods are redundant in final classes
+  aliases:
+    - PHP-W1082
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: stable
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.redundant-final-method
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 0.9
+    tags:
+      - correctness
+      - php
+  message:
+    title: Final methods are redundant in final classes
+    summary: "`${captures.issue.text}` matches php.correctness.redundant-final-method."
+  remediation:
+    summary: Final methods are redundant in final classes

package/rules/php/php.correctness.redundant-string-cast-concat.rule.yaml

@@ -4,6 +4,8 @@ metadata:
   id: php.correctness.redundant-string-cast-concat
   title: Remove redundant string casts before concatenation
   summary: Casting to string immediately before concatenation is usually redundant in PHP.
+  aliases:
+    - PHP-W1087
   rationale: Redundant casts add noise without changing behavior and can hide type problems that should be fixed directly.
   tags:
     - correctness

package/rules/php/php.correctness.self-assignment.rule.yaml

@@ -4,6 +4,8 @@ metadata:
   id: php.correctness.self-assignment
   title: Remove self assignments
   summary: Assigning a variable to itself has no effect.
+  aliases:
+    - PHP-W1077
   rationale: Self assignments usually indicate incomplete refactors or accidental duplication.
   tags:
     - correctness

package/rules/php/php.correctness.switch-multiple-default.rule.yaml

@@ -4,6 +4,8 @@ metadata:
   id: php.correctness.switch-multiple-default
   title: Use only one default case per switch
   summary: A switch statement must not declare more than one default branch.
+  aliases:
+    - PHP-E1114
   rationale: Multiple default cases are invalid PHP and indicate a copy-paste or merge mistake.
   tags:
     - correctness

package/rules/php/php.correctness.throw-as-expression.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.throw-as-expression
+  title: Throw expressions require PHP 8.0+
+  summary: Throw expressions require PHP 8.0+
+  rationale: Throw expressions require PHP 8.0+
+  aliases:
+    - PHP-W1017
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: stable
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.throw-as-expression
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: critical
+    confidence: 0.9
+    tags:
+      - correctness
+      - php
+  message:
+    title: Throw expressions require PHP 8.0+
+    summary: "`${captures.issue.text}` matches php.correctness.throw-as-expression."
+  remediation:
+    summary: Throw expressions require PHP 8.0+

package/rules/php/php.correctness.throw-non-exception.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.throw-non-exception
+  title: Only throw Exception and Error instances
+  summary: Throw statements should only raise objects that extend Exception or Error.
+  aliases:
+    - PHP-E1001
+  rationale: Throwing an object that is not an Exception or Error violates PHP type contracts and causes fatal errors.
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.throw-non-exception
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: critical
+    confidence: 0.55
+    tags:
+      - correctness
+      - php
+  message:
+    title: Throw only Exception and Error instances
+    summary: "`${captures.issue.text}` may throw a class that is not a valid exception class."
+  remediation:
+    summary: Ensure thrown objects extend \\Exception or \\Error, or implement Throwable.

package/rules/php/php.correctness.trait-as-attribute.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: php.correctness.trait-as-attribute
+  title: Traits cannot be used as attributes
+  summary: Traits cannot be used as attributes
+  rationale: Traits cannot be used as attributes
+  aliases:
+    - PHP-W1016
+  tags:
+    - correctness
+    - php
+    - rules-catalog
+  stability: stable
+  appliesTo: block
+scope:
+  languages:
+    - php
+  paths:
+    include:
+      - "**/*.php"
+match:
+  fact:
+    kind: php.correctness.trait-as-attribute
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: critical
+    confidence: 0.9
+    tags:
+      - correctness
+      - php
+  message:
+    title: Traits cannot be used as attributes
+    summary: "`${captures.issue.text}` matches php.correctness.trait-as-attribute."
+  remediation:
+    summary: Traits cannot be used as attributes