@critiq/rules 0.3.0 → 0.4.0

package/rules/typescript/ts.angularjs.no-deprecated-directive-replace.rule.yaml

@@ -0,0 +1,36 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.angularjs.no-deprecated-directive-replace
+  title: Avoid deprecated directive replace property
+  summary: "The `replace` property in AngularJS directive definitions is deprecated and removed in AngularJS 1.7+."
+  rationale: AngularJS removed the `replace` property from directive definition objects. It causes unexpected DOM behavior and is not compatible with component-based architecture.
+  aliases:
+    - JS-0531
+  tags:
+    - angularjs
+    - deprecated
+    - rules-catalog
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: framework.angularjs.deprecated-directive-replace
+    bind: issue
+emit:
+  finding:
+    category: correctness.deprecated
+    severity: high
+    confidence: 0.81
+    tags:
+      - angularjs
+      - deprecated
+  message:
+    title: Remove deprecated directive replace property
+    summary: "`${captures.issue.text}` uses the deprecated `replace` property in a directive definition."
+  remediation:
+    summary: Remove the `replace` property from the directive definition. AngularJS no longer supports replacing the directive element with the template content. Wrap template content in the directive element instead.

package/rules/typescript/ts.angularjs.no-deprecated-http-success-error.rule.yaml

@@ -0,0 +1,36 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.angularjs.no-deprecated-http-success-error
+  title: Avoid deprecated $http success/error methods
+  summary: "`.success()` and `.error()` on `$http` promise are deprecated in favor of `.then()` and `.catch()`."
+  rationale: The non-standard `.success()` and `.error()` methods were removed from AngularJS $http in version 1.6+. They do not follow standard Promise conventions and unwrap the response data, making error handling inconsistent.
+  aliases:
+    - JS-0532
+  tags:
+    - angularjs
+    - deprecated
+    - rules-catalog
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: framework.angularjs.deprecated-http-success-error
+    bind: issue
+emit:
+  finding:
+    category: correctness.deprecated
+    severity: high
+    confidence: 0.81
+    tags:
+      - angularjs
+      - deprecated
+  message:
+    title: Replace .success/.error with .then/.catch
+    summary: "`${captures.issue.text}` uses deprecated `.success()` or `.error()` method on $http."
+  remediation:
+    summary: Replace `.success(function(data, status, headers, config))` with `.then(function(response) { ... })` and `.error(function(data, status, headers, config))` with `.catch(function(response) { ... })`. Access response data via `response.data`.

package/rules/typescript/ts.angularjs.no-jquery-wrapping-angular-element.rule.yaml

@@ -0,0 +1,36 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.angularjs.no-jquery-wrapping-angular-element
+  title: Avoid wrapping angular.element with jQuery/$
+  summary: "Wrapping `angular.element()` objects with jQuery or `$()` is unnecessary and can cause issues."
+  rationale: The `angular.element()` function already returns a jqLite object with jQuery-like methods. Wrapping it again with `$()` or `jQuery()` is redundant and may cause interoperability issues between jqLite and jQuery.
+  aliases:
+    - JS-0561
+  tags:
+    - angularjs
+    - correctness
+    - rules-catalog
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: framework.angularjs.no-jquery-wrapping-angular-element
+    bind: issue
+emit:
+  finding:
+    category: correctness.ui
+    severity: high
+    confidence: 0.81
+    tags:
+      - angularjs
+      - correctness
+  message:
+    title: Remove redundant jQuery wrapping of angular.element
+    summary: "`${captures.issue.text}` wraps `angular.element()` with jQuery, which is redundant."
+  remediation:
+    summary: AngularJS's `angular.element()` already returns a jqLite wrapper. Use `angular.element(...)` directly instead of wrapping it with `$(angular.element(...))` or `jQuery(angular.element(...))`.

package/rules/typescript/ts.angularjs.prefer-angular-for-each.rule.yaml

@@ -0,0 +1,36 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.angularjs.prefer-angular-for-each
+  title: Prefer angular.forEach over native Array.forEach
+  summary: "Use `angular.forEach` instead of native `Array.prototype.forEach` in AngularJS contexts."
+  rationale: AngularJS's `angular.forEach` provides consistent iteration behavior, works on both arrays and objects, and ensures proper AngularJS digest cycle compatibility.
+  aliases:
+    - JS-0556
+  tags:
+    - angularjs
+    - maintainability
+    - rules-catalog
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: framework.angularjs.prefer-angular-for-each
+    bind: issue
+emit:
+  finding:
+    category: maintainability.ui
+    severity: high
+    confidence: 0.81
+    tags:
+      - angularjs
+      - maintainability
+  message:
+    title: Replace native .forEach() with angular.forEach()
+    summary: "`${captures.issue.text}` uses native `.forEach()` in an AngularJS context."
+  remediation:
+    summary: Replace `array.forEach(callback)` with `angular.forEach(array, callback)`. The angular.forEach variant works on objects too and follows AngularJS conventions.

package/rules/typescript/ts.angularjs.prefer-angular-is-string.rule.yaml

@@ -0,0 +1,36 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.angularjs.prefer-angular-is-string
+  title: Prefer angular.isString over typeof comparisons
+  summary: "Use `angular.isString(value)` instead of `typeof value === 'string'` in AngularJS code."
+  rationale: AngularJS provides `angular.isString()` as a type-check utility that is consistent with AngularJS's other type-check helpers and works correctly with cross-frame / cross-realm values where `typeof` may behave unexpectedly.
+  aliases:
+    - JS-0568
+  tags:
+    - angularjs
+    - maintainability
+    - rules-catalog
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: framework.angularjs.prefer-angular-is-string
+    bind: issue
+emit:
+  finding:
+    category: maintainability.ui
+    severity: high
+    confidence: 0.81
+    tags:
+      - angularjs
+      - maintainability
+  message:
+    title: Replace typeof check with angular.isString
+    summary: "`${captures.issue.text}` uses typeof comparison where `angular.isString()` is preferred."
+  remediation:
+    summary: Replace `typeof value === 'string'` with `angular.isString(value)`. AngularJS provides consistent type-checking helpers that work across execution contexts.

package/rules/typescript/ts.correctness.array-callback-missing-return.rule.yaml

@@ -5,6 +5,8 @@ metadata:
   title: Array callback missing return
   summary: Array iteration callbacks with block bodies should return a value when required.
   rationale: map, filter, reduce, every, and some expect callback return values; missing returns yield undefined elements or incorrect predicates.
+  aliases:
+    - JS-0042
   tags:
     - correctness
     - language

package/rules/typescript/ts.correctness.array-sort-without-compare.rule.yaml

@@ -4,7 +4,9 @@ metadata:
   id: ts.correctness.array-sort-without-compare
   title: Array.sort without compare function
   summary: Provide a compare function when sorting non-string arrays.
-  rationale: Default sort coerces elements to strings, which misorders numbers and many objects.
+  rationale: Default sort coerces elements to strings, which misorders numbers; however default sort is correct for string arrays and this is a code-style hint in most codebases.
+  aliases:
+    - JS-0375
   tags:
     - correctness
     - language
@@ -23,8 +25,8 @@ match:
 emit:
   finding:
     category: correctness.language
-    severity: medium
-    confidence: 0.88
+    severity: low
+    confidence: 0.55
     tags:
       - correctness
       - language

package/rules/typescript/ts.correctness.assignment-in-condition.rule.yaml

@@ -5,6 +5,8 @@ metadata:
   title: Assignment used as a conditional test
   summary: Control-flow conditions should compare values, not perform assignments.
   rationale: Using `=` where `===` was intended is a common defect; assignments in conditions also obscure data flow.
+  aliases:
+    - JS-0001
   tags:
     - correctness
     - language
@@ -24,8 +26,8 @@ match:
 emit:
   finding:
     category: correctness.language
-    severity: medium
-    confidence: 0.9
+    severity: low
+    confidence: 0.55
     tags:
       - correctness
       - language

package/rules/typescript/ts.correctness.assignment-to-exports.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.assignment-to-exports
+  title: Assignment to exports
+  summary: Detected direct assignment to the `exports` variable.
+  rationale: In CommonJS modules, reassigning `exports` breaks the `module.exports` reference, making all subsequent exports unreachable.
+  aliases:
+    - JS-0256
+  tags:
+    - correctness
+    - modules
+    - rules-catalog
+    - crq-cor-049
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.assignment-to-exports
+    bind: issue
+emit:
+  finding:
+    category: correctness.modules
+    severity: high
+    confidence: 0.9
+    tags:
+      - correctness
+      - modules
+  message:
+    title: Do not reassign exports
+    summary: "`${captures.issue.text}` reassigns `exports`, which breaks the module.exports reference."
+  remediation:
+    summary: Use `module.exports = ...` instead of `exports = ...`, or mutate individual `exports.*` properties.

package/rules/typescript/ts.correctness.assignment-to-import-binding.rule.yaml

@@ -4,6 +4,8 @@ metadata:
   id: ts.correctness.assignment-to-import-binding
   title: Assignment to an imported binding
   summary: Code assigns to or updates a symbol declared by an import.
+  aliases:
+    - JS-0035
   rationale: ES module imports are read-only bindings; reassignment fails at runtime and signals a mistaken refactor.
   tags:
     - correctness

package/rules/typescript/ts.correctness.async-promise-executor.rule.yaml

@@ -4,6 +4,8 @@ metadata:
   id: ts.correctness.async-promise-executor
   title: Async Promise executor function
   summary: The executor passed to `new Promise` is declared `async`.
+  aliases:
+    - JS-0031
   rationale: Async executors defer errors and can swallow rejections; prefer a synchronous executor that calls `resolve`/`reject`.
   tags:
     - correctness

package/rules/typescript/ts.correctness.blocking-call-in-async-flow.rule.yaml

@@ -16,6 +16,17 @@ scope:
   languages:
     - typescript
     - javascript
+  paths:
+    exclude:
+      - "**/*.test.*"
+      - "**/*.spec.*"
+      - "**/__tests__/**"
+      - "**/tests/**"
+      - "**/test/**"
+      - "**/e2e/**"
+      - "**/*.integration.test.*"
+      - "**/*.browser.test.*"
+      - "**/*.e2e.test.*"
 match:
   fact:
     kind: async.blocking-call-in-async-flow
@@ -29,7 +40,7 @@ emit:
       - correctness
       - async
   message:
-    title: Avoid blocking sync calls in async flows
-    summary: "`${captures.issue.text}` uses a blocking sync API inside an async function."
+    title: Blocking sync call `${captures.issue.text}` inside async function
+    summary: "`${captures.issue.text}` uses a blocking sync API inside an async function, stalling the event loop and defeating the throughput benefit of async control flow."
   remediation:
-    summary: Replace the sync API with its asynchronous equivalent or move the blocking work out of the async request path.
+    summary: Replace the sync API with its async equivalent (await + promise-based API) or move the blocking work off the request path into a worker thread or CLI-only path.

package/rules/typescript/ts.correctness.callback-missing-error-handling.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.callback-missing-error-handling
+  title: Callback missing error handling
+  summary: Require error handling in callbacks.
+  rationale: Callbacks that accept an error parameter but never reference it may silently swallow failures, making debugging difficult.
+  aliases:
+    - JS-0254
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - crq-cor-051
+    - public-directory-parity
+  stability: experimental
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.callback-missing-error-handling
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.7
+    tags:
+      - correctness
+      - language
+  message:
+    title: Handle the error parameter in the callback
+    summary: "Callback accepts an error parameter but never uses it."
+  remediation:
+    summary: Check the error parameter and handle it (e.g., `if (err) return callback(err)`).

package/rules/typescript/ts.correctness.callback-not-error-first.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.callback-not-error-first
+  title: Non-error-first callback pattern
+  summary: Ensure Node.js-style error-first callback pattern is followed.
+  rationale: Node.js conventions place the error as the first parameter; breaking this convention signals a potential bug or misunderstanding.
+  aliases:
+    - JS-0255
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - crq-cor-052
+    - public-directory-parity
+  stability: experimental
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.callback-not-error-first
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.65
+    tags:
+      - correctness
+      - language
+  message:
+    title: Follow error-first callback convention
+    summary: "Callback first parameter is not `err` or `error`."
+  remediation:
+    summary: Reorder callback parameters so the error parameter comes first, or rename the first parameter to `err` or `error`.

package/rules/typescript/ts.correctness.compound-assignment-with-await.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.compound-assignment-with-await
+  title: Compound assignment with await
+  summary: Detects compound assignment with await issues in JavaScript and TypeScript source.
+  rationale: Compound assignment with await patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0040
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.compound-assignment-with-await
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix compound assignment with await
+    summary: "`${captures.issue.text}` matches ts.correctness.compound-assignment-with-await."
+  remediation:
+    summary: Refactor the code to remove the compound assignment with await pattern.

package/rules/typescript/ts.correctness.confusing-multiline-expression.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.confusing-multiline-expression
+  title: Confusing multiline expression
+  summary: Detects confusing multiline expression issues in JavaScript and TypeScript source.
+  rationale: Confusing multiline expression patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0024
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.confusing-multiline-expression
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix confusing multiline expression
+    summary: "`${captures.issue.text}` matches ts.correctness.confusing-multiline-expression."
+  remediation:
+    summary: Refactor the code to remove the confusing multiline expression pattern.

package/rules/typescript/ts.correctness.constructor-return-value.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.constructor-return-value
+  title: Return value in constructor
+  summary: Detects return value in constructor issues in JavaScript and TypeScript source.
+  rationale: Return value in constructor patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0109
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.constructor-return-value
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix return value in constructor
+    summary: "`${captures.issue.text}` matches ts.correctness.constructor-return-value."
+  remediation:
+    summary: Refactor the code to remove the return value in constructor pattern.

package/rules/typescript/ts.correctness.control-flow-in-finally.rule.yaml

@@ -5,6 +5,8 @@ metadata:
   title: Control flow in finally block
   summary: Avoid return, throw, break, or continue inside finally blocks.
   rationale: Control-flow statements in finally override try/catch completion and can hide errors or skip cleanup intent.
+  aliases:
+    - JS-0026
   tags:
     - correctness
     - language

package/rules/typescript/ts.correctness.declaration-in-nested-block.rule.yaml

@@ -0,0 +1,39 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.declaration-in-nested-block
+  title: Function or var declaration in nested block
+  summary: A `function` or `var` declaration appears inside a nested block instead of the enclosing scope top level.
+  rationale: Nested function and `var` declarations have confusing hoisting semantics and differ across engines in non-strict legacy code.
+  aliases:
+    - JS-0016
+    - JS-0073
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - crq-cor-040
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.declaration-in-nested-block
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: low
+    confidence: 0.40
+    tags:
+      - correctness
+      - language
+  message:
+    title: Move declarations out of nested blocks
+    summary: "`${captures.issue.text}` declares a function or `var` inside a nested block."
+  remediation:
+    summary: Hoist the declaration to the module or function body top level, or use block-scoped `let`/`const` when appropriate.

package/rules/typescript/ts.correctness.delete-on-variable.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.delete-on-variable
+  title: Delete operator on variable
+  summary: Detects delete operator on variable issues in JavaScript and TypeScript source.
+  rationale: Delete operator on variable patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0120
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.delete-on-variable
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix delete operator on variable
+    summary: "`${captures.issue.text}` matches ts.correctness.delete-on-variable."
+  remediation:
+    summary: Refactor the code to remove the delete operator on variable pattern.

package/rules/typescript/ts.correctness.deprecated-api-usage.rule.yaml

@@ -0,0 +1,39 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.deprecated-api-usage
+  title: Deprecated API usage
+  summary: Use of known deprecated APIs should be replaced with modern alternatives.
+  rationale: Deprecated APIs are removed in future versions and often have safer or more performant replacements.
+  detection:
+    kind: pattern
+  aliases:
+    - JS-0272
+  tags:
+    - correctness
+    - deprecation
+    - rules-catalog
+    - public-directory-parity
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.deprecated-api
+    bind: issue
+emit:
+  finding:
+    category: correctness.deprecation
+    severity: high
+    confidence: 0.9
+    tags:
+      - correctness
+      - deprecation
+  message:
+    title: Replace deprecated API
+    summary: "`${captures.issue.text}` uses a deprecated API. Prefer the modern replacement."
+  remediation:
+    summary: Use the modern replacement for the deprecated API. Check language and framework documentation for the recommended alternative.

package/rules/typescript/ts.correctness.duplicate-class-member.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.duplicate-class-member
+  title: Duplicate class member
+  summary: Detects duplicate class member issues in JavaScript and TypeScript source.
+  rationale: Duplicate class member patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0231
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.duplicate-class-member
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix duplicate class member
+    summary: "`${captures.issue.text}` matches ts.correctness.duplicate-class-member."
+  remediation:
+    summary: Refactor the code to remove the duplicate class member pattern.