@critiq/rules 0.3.0 → 0.4.0

package/rules/typescript/ts.correctness.new-symbol-instance.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.new-symbol-instance
+  title: new Symbol() instantiation
+  summary: Found new operator used with the `Symbol` object.
+  rationale: Symbol is not a constructor; calling `new Symbol()` throws a TypeError at runtime.
+  aliases:
+    - JS-0233
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - crq-cor-046
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.new-symbol-instance
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 1.0
+    tags:
+      - correctness
+      - language
+  message:
+    title: Do not use new with Symbol
+    summary: "`${captures.issue.text}` uses `new Symbol()`, which throws at runtime."
+  remediation:
+    summary: Replace `new Symbol(...)` with `Symbol(...)` — Symbol is not a constructor.

package/rules/typescript/ts.correctness.no-confusing-label-in-switch.rule.yaml

@@ -0,0 +1,39 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.no-confusing-label-in-switch
+  title: Confusing label inside switch
+  summary: Labeled statements inside switch blocks can be confused with case clauses.
+  rationale: Labels nested inside switch cases are rarely intentional and create confusing control flow that is hard to distinguish from case/default clauses.
+  aliases:
+    - JS-W1036
+  tags:
+    - correctness
+    - language
+    - switch
+    - readability
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.confusing-label-in-switch
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 0.90
+    tags:
+      - correctness
+      - language
+  message:
+    title: Confusing label inside switch
+    summary: "`${captures.issue.text}` is a labeled statement inside a switch block."
+  remediation:
+    summary: Remove the label or restructure the switch statement to avoid labeled statements inside cases.

package/rules/typescript/ts.correctness.no-href-with-nuxt-link.rule.yaml

@@ -0,0 +1,39 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.no-href-with-nuxt-link
+  title: NuxtLink should use `to` instead of `href`
+  summary: The `href` attribute on NuxtLink should be replaced with `to` for internal navigation.
+  rationale: NuxtLink is a Vue Router component that uses the `to` prop for route navigation, not `href`. Using `href` bypasses Vue Router and may cause full page reloads.
+  aliases:
+    - JS-W1034
+  tags:
+    - correctness
+    - nuxt
+    - vue
+    - routing
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: block
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: nuxt-correctness.nuxt-link-href
+    bind: issue
+emit:
+  finding:
+    category: correctness.routing
+    severity: high
+    confidence: 0.95
+    tags:
+      - correctness
+      - nuxt
+  message:
+    title: Use `to` instead of `href` on NuxtLink
+    summary: "`${captures.issue.text}` uses `href` on a NuxtLink component. Replace with `to`."
+  remediation:
+    summary: Replace the `href` attribute with `to` to leverage client-side navigation through Vue Router.

package/rules/typescript/ts.correctness.no-ts-suppress-directive.rule.yaml

@@ -0,0 +1,36 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.no-ts-suppress-directive
+  title: TypeScript suppress directive
+  summary: Avoid `@ts-ignore`, `@ts-nocheck`, and `@ts-expect-error` directives.
+  rationale: Suppressing TypeScript checks hides type errors that can lead to runtime defects. Use proper types or explicit casts instead.
+  aliases:
+    - JS-0295
+  tags:
+    - correctness
+    - typescript
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+match:
+  fact:
+    kind: language.ts-suppress-directive
+    bind: issue
+emit:
+  finding:
+    category: correctness.type-safety
+    severity: high
+    confidence: 0.9
+    tags:
+      - correctness
+      - typescript
+  message:
+    title: Remove TypeScript suppress directive
+    summary: "`${captures.issue.text}` suppresses TypeScript type checking. Fix the underlying type issue instead."
+  remediation:
+    summary: Replace `@ts-ignore`, `@ts-nocheck`, or `@ts-expect-error` with proper type annotations, type guards, or explicit casts.

package/rules/typescript/ts.correctness.non-existent-assignment-operators.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.non-existent-assignment-operators
+  title: Found non-existent assignment operators
+  summary: Detects patterns like `=+`, `=-`, `=!`, `=~` that suggest a typo in a compound assignment operator.
+  rationale: "Writing `x =+ 1` is valid JS (meaning `x = +1`) but looks like a bug (intending `x += 1`). These patterns are common typos."
+  aliases:
+    - JS-W1033
+  tags:
+    - correctness
+    - language
+    - operator
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.non-existent-assignment-operator
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Non-existent assignment operator
+    summary: "`${captures.issue.text}` looks like a non-existent compound assignment operator."
+  remediation:
+    summary: Replace with the correct compound assignment operator or add a space to clarify intent.

package/rules/typescript/ts.correctness.off-by-one-loop-boundary.rule.yaml

@@ -5,6 +5,8 @@ metadata:
   title: Off-by-one error in loop boundaries
   summary: Index-based loops should not skip the first element or iterate one step past the collection boundary.
   rationale: Off-by-one loop conditions frequently cause undefined reads, missed work, or stale guard logic around array bounds.
+  aliases:
+    - JS-0029
   tags:
     - correctness
     - logic

package/rules/typescript/ts.correctness.parse-int-on-number-literal.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.parse-int-on-number-literal
+  title: parseInt on a number literal
+  summary: Found `parseInt()` or `Number.parseInt()` called on a number literal.
+  rationale: Passing a number literal to parseInt is always unnecessary since the value is already an integer or can be converted with Math methods.
+  aliases:
+    - JS-0253
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - crq-cor-048
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.parse-int-on-number-literal
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 1.0
+    tags:
+      - correctness
+      - language
+  message:
+    title: parseInt on a number literal is unnecessary
+    summary: "`${captures.issue.text}` calls parseInt on a number literal."
+  remediation:
+    summary: Remove the parseInt call; the value is already a number.

package/rules/typescript/ts.correctness.prefer-as-const-over-literal-type.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.prefer-as-const-over-literal-type
+  title: Prefer as const over literal type annotation
+  summary: Use `as const` assertion instead of an explicit literal type annotation.
+  rationale: Using `as const` is more concise and idiomatic than declaring a literal type annotation.
+  aliases:
+    - JS-0360
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: typescript.prefer-as-const-over-literal-type
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Use `as const` instead of literal type annotation
+    summary: "`${captures.issue.text}` uses a literal type annotation instead of `as const`."
+  remediation:
+    summary: Replace the literal type annotation with an `as const` assertion on the value.

package/rules/typescript/ts.correctness.prefer-includes-over-indexof.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.prefer-includes-over-indexof
+  title: Prefer includes over indexOf comparison
+  summary: Use `.includes()` instead of `.indexOf()` comparison for readability.
+  rationale: Using `.includes()` is more readable and semantically clearer than comparing `.indexOf()` to -1 or 0.
+  aliases:
+    - JS-0363
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.prefer-includes-over-indexof
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: low
+    confidence: 0.45
+    tags:
+      - correctness
+      - language
+  message:
+    title: Replace indexOf comparison with includes
+    summary: "`${captures.issue.text}` compares `.indexOf()` result when `.includes()` would be clearer."
+  remediation:
+    summary: Replace `.indexOf()` comparison with `.includes()` for better readability.

package/rules/typescript/ts.correctness.prefer-nullish-coalescing.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.prefer-nullish-coalescing
+  title: Prefer nullish coalescing operator
+  summary: Use the nullish coalescing operator `??` instead of `||` for null/undefined defaults.
+  rationale: The `||` operator treats all falsy values (0, '', false) as absent. The `??` operator only treats null and undefined as absent, which is often the intended behavior.
+  aliases:
+    - JS-0365
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.prefer-nullish-coalescing
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.80
+    tags:
+      - correctness
+      - language
+  message:
+    title: Use nullish coalescing operator `??`
+    summary: "`${captures.issue.text}` uses `||` on a potentially nullish value."
+  remediation:
+    summary: Replace `||` with `??` when the intent is to default only for null or undefined, not other falsy values.

package/rules/typescript/ts.correctness.private-member-should-be-readonly.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.private-member-should-be-readonly
+  title: Private members should be readonly
+  summary: Class members declared `private` that are never reassigned should be marked `readonly`.
+  rationale: Marking private members as `readonly` clarifies intent and prevents accidental mutation.
+  aliases:
+    - JS-0368
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: typescript.private-member-should-be-readonly
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Mark private member as readonly
+    summary: "`${captures.issue.text}` is a private member that could be marked `readonly`."
+  remediation:
+    summary: Add the `readonly` modifier to this private member to clarify that it is not reassigned after initialization.

package/rules/typescript/ts.correctness.promise-reject-non-error.rule.yaml

@@ -5,6 +5,8 @@ metadata:
   title: Reject or throw non-Error values
   summary: Promise rejections and async throws should use Error objects.
   rationale: Non-Error rejections lose stack traces and are harder to handle consistently in async code.
+  aliases:
+    - JS-0114
   tags:
     - correctness
     - async

package/rules/typescript/ts.correctness.prototype-builtin-called-directly.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.prototype-builtin-called-directly
+  title: Object.prototype builtin called directly
+  summary: A method from `Object.prototype` is invoked directly on a receiver object.
+  rationale: Direct prototype calls break when objects null-prototype or shadow built-in methods; use `Object.hasOwn` or `Object.prototype.*.call` instead.
+  aliases:
+    - JS-0021
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - crq-cor-044
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.prototype-builtin-called-directly
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.9
+    tags:
+      - correctness
+      - language
+  message:
+    title: Avoid direct Object.prototype method calls
+    summary: "`${captures.issue.text}` calls an Object.prototype builtin on a dynamic receiver."
+  remediation:
+    summary: Prefer `Object.hasOwn(obj, key)` or `Object.prototype.hasOwnProperty.call(obj, key)` for prototype-safe checks.

package/rules/typescript/ts.correctness.reassign-catch-binding.rule.yaml

@@ -5,6 +5,8 @@ metadata:
   title: Reassignment of catch binding
   summary: The catch clause parameter is assigned or updated after it is bound.
   rationale: Catch bindings are immutable in strict mode and confusing in sloppy mode; reassignment usually indicates a mistaken mutation of the caught error.
+  aliases:
+    - JS-0011
   tags:
     - correctness
     - language

package/rules/typescript/ts.correctness.reassign-class-member.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.reassign-class-member
+  title: Reassigning class member
+  summary: Detects reassigning class member issues in JavaScript and TypeScript source.
+  rationale: Reassigning class member patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0228
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.reassign-class-member
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: high
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix reassigning class member
+    summary: "`${captures.issue.text}` matches ts.correctness.reassign-class-member."
+  remediation:
+    summary: Refactor the code to remove the reassigning class member pattern.

package/rules/typescript/ts.correctness.reassign-const-binding.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.reassign-const-binding
+  title: Reassigning const binding
+  summary: Detects reassigning const binding issues in JavaScript and TypeScript source.
+  rationale: Reassigning const binding patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0230
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.reassign-const-binding
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix reassigning const binding
+    summary: "`${captures.issue.text}` matches ts.correctness.reassign-const-binding."
+  remediation:
+    summary: Refactor the code to remove the reassigning const binding pattern.

package/rules/typescript/ts.correctness.reassign-function-declaration.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.reassign-function-declaration
+  title: Reassignment of function declaration
+  summary: A declared function name is later reassigned, which breaks hoisting expectations.
+  rationale: Rebinding function declarations obscures call targets and often hides logic errors during refactors.
+  aliases:
+    - JS-0015
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - crq-cor-039
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.reassign-function-declaration
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: low
+    confidence: 0.55
+    tags:
+      - correctness
+      - language
+  message:
+    title: Do not reassign function declarations
+    summary: "`${captures.issue.text}` reassigns a function declaration binding."
+  remediation:
+    summary: Use a separate variable for the new function value or convert the declaration to a `const` arrow function.

package/rules/typescript/ts.correctness.regexp-constructor-invalid-pattern.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.regexp-constructor-invalid-pattern
+  title: Invalid pattern string in RegExp constructor
+  summary: A string literal passed to `RegExp` or `new RegExp` is not a valid regular expression.
+  rationale: Invalid constructor patterns throw at runtime and are easy to miss when the pattern is built from a static string.
+  aliases:
+    - JS-0017
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - crq-cor-041
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.regexp-constructor-invalid-pattern
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.95
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix the RegExp constructor pattern
+    summary: "The RegExp constructor is called with an invalid pattern literal near `${captures.issue.text}`."
+  remediation:
+    summary: Correct the pattern syntax or build the expression with a validated helper before constructing the RegExp.

package/rules/typescript/ts.correctness.regexp-empty-character-class.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.regexp-empty-character-class
+  title: Empty character class in regular expression
+  summary: The regular expression pattern contains an empty character class that never matches.
+  rationale: Empty `[]` classes are almost always accidental and make patterns silently fail to match.
+  aliases:
+    - JS-0010
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - crq-cor-038
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.regexp-empty-character-class
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.9
+    tags:
+      - correctness
+      - language
+  message:
+    title: Remove or fix empty regex character classes
+    summary: "The pattern `${captures.issue.text}` includes `[]`, which matches nothing."
+  remediation:
+    summary: Add intended characters inside the class or remove the empty class from the pattern.

package/rules/typescript/ts.correctness.regexp-multicodepoint-character-class.rule.yaml

@@ -0,0 +1,37 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.correctness.regexp-multicodepoint-character-class
+  title: Multi-code-point character in regex class
+  summary: Detects multi-code-point character in regex class issues in JavaScript and TypeScript source.
+  rationale: Multi-code-point character in regex class patterns are a common source of bugs and confusing runtime behavior.
+  aliases:
+    - JS-0036
+  tags:
+    - correctness
+    - language
+    - rules-catalog
+    - public-directory-parity
+  stability: stable
+  appliesTo: file
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: language.regexp-multicodepoint-character-class
+    bind: issue
+emit:
+  finding:
+    category: correctness.language
+    severity: medium
+    confidence: 0.85
+    tags:
+      - correctness
+      - language
+  message:
+    title: Fix multi-code-point character in regex class
+    summary: "`${captures.issue.text}` matches ts.correctness.regexp-multicodepoint-character-class."
+  remediation:
+    summary: Refactor the code to remove the multi-code-point character in regex class pattern.