@bongos/core 1.24.79 → 1.24.81

package/tests/module_manifest.mjs

@@ -428,3 +428,32 @@ test('category: every bundled module declares one (core modules get categories t
     .filter((k) => !JSON.parse(fs.readFileSync(path.join(dir, k, 'module.json'), 'utf8')).category);
   assert.deepEqual(missing, [], `declare "category": { "parent": … } in: ${missing.join(', ')}`);
 });
+
+// --- language (task 1004794) ---
+
+test('language: absent defaults to javascript; "javascript" is accepted', () => {
+  const plain = baseManifest();
+  assert.equal(validateManifest(plain).valid, true);
+  const js = { ...baseManifest(), language: 'javascript' };
+  assert.equal(validateManifest(js).valid, true, validateManifest(js).errors.join('; '));
+});
+
+test('language: a value off the closed list is refused with the allowed list', () => {
+  for (const bad of ['python', 'JavaScript', '', 42, null]) {
+    const r = validateManifest({ ...baseManifest(), language: bad });
+    assert.equal(r.valid, false, `language ${JSON.stringify(bad)} should be refused`);
+    assert.ok(r.errors.some((e) => e.startsWith('language:') && e.includes('allowed: javascript')), r.errors.join('; '));
+  }
+});
+
+test('language: every module.json in the repo still validates (existing modules load unchanged)', async () => {
+  const fs = await import('node:fs');
+  const dir = path.join(ROOT, 'modules');
+  const keys = fs.readdirSync(dir).filter((k) => fs.existsSync(path.join(dir, k, 'module.json')));
+  assert.ok(keys.length > 10, 'expected the bundled modules, saw ' + keys.length);
+  for (const k of keys) {
+    const m = JSON.parse(fs.readFileSync(path.join(dir, k, 'module.json'), 'utf8'));
+    const r = validateManifest(m);
+    assert.equal(r.valid, true, `${k}: ${r.errors.join('; ')}`);
+  }
+});

package/tests/module_skills_hook.mjs

@@ -23,11 +23,11 @@ function t(name, fn) {
 
 t('an artist-craft builder gets the skills', () => {
   assert.equal(wantsModuleSkills({ builder: { preferred_disciplines: ['artist'] } }), true);
-  assert.equal(wantsModuleSkills({ builder: { preferred_disciplines: ['engineer', 'artist'] } }), true);
+  assert.equal(wantsModuleSkills({ builder: { preferred_disciplines: ['artisan', 'artist'] } }), true);
 });
 
 t('anyone else gets nothing (the 2026-09-02 rule holds)', () => {
-  assert.equal(wantsModuleSkills({ builder: { preferred_disciplines: ['engineer'] } }), false);
+  assert.equal(wantsModuleSkills({ builder: { preferred_disciplines: ['artisan'] } }), false);
   assert.equal(wantsModuleSkills({ builder: { preferred_disciplines: [] } }), false);
   assert.equal(wantsModuleSkills({ builder: {} }), false);
 });

package/tests/modules.mjs

@@ -130,11 +130,15 @@ test('isModuleEnabled throws on an unknown module name (programmer error)', () =
   assert.throws(() => isModuleEnabled('nope', resolveModules({})), /unknown module/);
 });
 
-test('disciplines: engineer + artist + ideator are CORE — offered with no modules on', () => {
+test('disciplines: artisan + artist are CORE — offered with no modules on', () => {
   // Ideation is methodology core (idea_inbox / capture / triage ship to every
   // instance). 'artist' joined them at task 1003719 / ADR 0271 — see the
   // CORE_DISCIPLINES comment for why the R59 module gate had stopped existing.
-  assert.deepEqual(enabledDisciplines(resolveModules({})), ['engineer', 'artist', 'ideator']);
+  // Since task 1005141 (BONGOS-V3) engineer is 'artisan' and ideator folded into
+  // 'artist', so the core crafts are two, not three.
+  assert.deepEqual(enabledDisciplines(resolveModules({})), ['artisan', 'artist']);
+  assert.ok(!enabledDisciplines(resolveModules({})).includes('engineer'), 'the old spelling is not offered');
+  assert.ok(!enabledDisciplines(resolveModules({})).includes('ideator'), 'ideator is not a separate craft');
 });
 
 test('THE REGRESSION: every craft the DB CHECK accepts is offered by SOME instance shape', () => {
@@ -153,8 +157,10 @@ test('THE REGRESSION: every craft the DB CHECK accepts is offered by SOME instan
   const widest = new Set(enabledDisciplines(resolveModules({ instance: { modules: Object.fromEntries(
     Object.keys(EFFECTIVE).map((k) => [k, true])
   ) }, registry: EFFECTIVE })));
-  // Mirrors the CHECK on builders.preferred_disciplines (migrations 086 + 176).
-  for (const craft of ['engineer', 'artist', 'ideator', 'ui']) {
+  // Mirrors the CURRENT-spelling crafts in the CHECK on builders.preferred_disciplines
+  // (migrations 086 + 176, renamed by core_296). The CHECK also still admits the old
+  // 'engineer'/'ideator' for rollback — those are normalized on input, never offered.
+  for (const craft of ['artisan', 'artist', 'ui']) {
     assert.ok(
       widest.has(craft),
       `the DB accepts preferred_disciplines='${craft}' but no instance shape offers it — ` +
@@ -182,7 +188,7 @@ test('clientModules is a safe boolean projection covering every known module + d
   const c = clientModules(resolveModules({ instance: OTB, registry: SAMPLE_REG }));
   for (const k of KNOWN_MODULES) assert.equal(typeof c.enabled[k], 'boolean');
   assert.ok(Array.isArray(c.disciplines));
-  assert.ok(c.disciplines.includes('engineer'));
+  assert.ok(c.disciplines.includes('artisan'));
 });
 
 test('the resolved set is frozen (callers cannot mutate the singleton)', () => {
@@ -249,11 +255,12 @@ test('a branded sibling (GDS_BRANDING_FILE set, no GDS_MODULES_FILE) defaults to
   // A non-default brand must fall through to the neutral (all-off) module set.
   const m = loadModules({ env: { GDS_BRANDING_FILE: 'config/branding.cloudbongos.json' } });
   for (const k of KNOWN_MODULES) assert.equal(m[k], false, `${k} must be off for a branded sibling`);
-  // The three core crafts (engineer + artist + ideator — task 1003719 / ADR 0271),
+  // The two core crafts (artisan + artist — task 1003719 / ADR 0271, renamed and
+  // folded by task 1005141),
   // plus 'ui' from ui-design, which is default-on for EVERY instance ("every
   // instance has a face") and is not one of KNOWN_MODULES, so the all-off
   // assertion above never reaches it (task 1003487).
-  assert.deepEqual(enabledDisciplines(m), ['engineer', 'artist', 'ideator', 'ui']);
+  assert.deepEqual(enabledDisciplines(m), ['artisan', 'artist', 'ui']);
 });
 
 // ── the DB override layer (task 1002857, migration core_248) ────────────────────

package/tests/nav_permission_atoms.mjs

@@ -102,7 +102,8 @@ test('the hall-preview fixture carries every atom /me resolves', () => {
 // task 1005051: Roadmap left it (folded into Goals; /roadmap redirects).
 // task 1005070: the remembered nav (the rail paints before /me).
 // task 1005088: the sidebar mark is drawn by reference to the one brand mark.
-const SHELL_SHA = 'e9c13c142bcd2a95';
+// task 1005144: My agents, Project settings, Permissions and Modules left for the options menu.
+const SHELL_SHA = 'a4d41b30b41e49f4';
 
 test('shell.js has not changed without its cache-bust being bumped', () => {
   const actual = crypto.createHash('sha256').update(SHELL).digest('hex').slice(0, 16);

package/tests/needs_rebase.mjs

@@ -52,7 +52,7 @@ try {
   // core_233) and the seeds already hold that slot, so a 'planning' row here fails setup (task 1004861).
   await q(`INSERT INTO versions (id,name,status,track) VALUES ($1,'nr','building','internal') ON CONFLICT (id) DO NOTHING`, [VER]);
   await q(`INSERT INTO builders (id,github_id,github_login,display_name,rank) VALUES ($1,'nr-w','nr-worker','NR Worker','thetes')`, [WORKER]);
-  await q(`INSERT INTO tasks (id,version_id,title,status,credits_reward,kind,shipped_by,discipline) VALUES ($1,$2,'nr fixture','confirmed',10,'feature',$3,'engineer')`, [TASK, VER, WORKER]);
+  await q(`INSERT INTO tasks (id,version_id,title,status,credits_reward,kind,shipped_by,discipline) VALUES ($1,$2,'nr fixture','confirmed',10,'feature',$3,'artisan')`, [TASK, VER, WORKER]);
   await q(`INSERT INTO claims (task_id,builder_id,claimed_at) VALUES ($1,$2,now())`, [TASK, WORKER]);
 
   // 1) flag a CONFIRMED task → flagged, reason + at set, returns true.

package/tests/newcomer_restock.mjs

@@ -23,11 +23,11 @@ function t(name, fn) {
 
 // ---- parseSeq ----
 t('parseSeq: matches discipline+template, rejects others', () => {
-  assert.equal(r.parseSeq('tmpl:engineer:docs-hygiene-pass:5', 'engineer', 'docs-hygiene-pass'), 5);
-  assert.equal(r.parseSeq('tmpl:engineer:docs-hygiene-pass:5', 'artist', 'docs-hygiene-pass'), null);
-  assert.equal(r.parseSeq('tmpl:engineer:other:5', 'engineer', 'docs-hygiene-pass'), null);
-  assert.equal(r.parseSeq('manual:engineer:x', 'engineer', 'docs-hygiene-pass'), null);
-  assert.equal(r.parseSeq('tmpl:engineer:docs-hygiene-pass:nope', 'engineer', 'docs-hygiene-pass'), null);
+  assert.equal(r.parseSeq('tmpl:artisan:docs-hygiene-pass:5', 'artisan', 'docs-hygiene-pass'), 5);
+  assert.equal(r.parseSeq('tmpl:artisan:docs-hygiene-pass:5', 'artist', 'docs-hygiene-pass'), null);
+  assert.equal(r.parseSeq('tmpl:artisan:other:5', 'artisan', 'docs-hygiene-pass'), null);
+  assert.equal(r.parseSeq('manual:artisan:x', 'artisan', 'docs-hygiene-pass'), null);
+  assert.equal(r.parseSeq('tmpl:artisan:docs-hygiene-pass:nope', 'artisan', 'docs-hygiene-pass'), null);
 });
 
 // ---- buildDescription ----
@@ -40,22 +40,22 @@ t('buildDescription: folds done-when + "always one waiting" footer', () => {
 
 // ---- templateIdFromRef ----
 t('templateIdFromRef: extracts the template_id, honouring the discipline', () => {
-  assert.equal(r.templateIdFromRef('tmpl:engineer:unit-test-pass:3', 'engineer'), 'unit-test-pass');
-  assert.equal(r.templateIdFromRef('tmpl:engineer:unit-test-pass:3', 'artist'), null, 'discipline mismatch');
-  assert.equal(r.templateIdFromRef('manual:engineer:x', 'engineer'), null, 'non-chore ref');
-  assert.equal(r.templateIdFromRef('tmpl:engineer:unit-test-pass', 'engineer'), null, 'too few parts');
+  assert.equal(r.templateIdFromRef('tmpl:artisan:unit-test-pass:3', 'artisan'), 'unit-test-pass');
+  assert.equal(r.templateIdFromRef('tmpl:artisan:unit-test-pass:3', 'artist'), null, 'discipline mismatch');
+  assert.equal(r.templateIdFromRef('manual:artisan:x', 'artisan'), null, 'non-chore ref');
+  assert.equal(r.templateIdFromRef('tmpl:artisan:unit-test-pass', 'artisan'), null, 'too few parts');
 });
 
 // ---- loadTemplates: real templates.json (per-discipline LIST since task 1488) ----
 t('loadTemplates: real file is a per-discipline list of valid chores', () => {
   const tmpl = r.loadTemplates();
-  for (const disc of ['engineer', 'artist', 'ideator']) {
+  for (const disc of ['artisan', 'artist', 'artist']) {
     assert.ok(Array.isArray(tmpl[disc]) && tmpl[disc].length >= 1, `${disc} is a non-empty list`);
     for (const c of tmpl[disc]) {
       assert.ok(c.template_id && c.version_id && c.title, `${disc}/${c.template_id || '?'} has id/version/title`);
     }
   }
-  const engIds = tmpl.engineer.map((c) => c.template_id);
+  const engIds = tmpl.artisan.map((c) => c.template_id);
   assert.ok(engIds.includes('unit-test-pass') && engIds.includes('docs-hygiene-pass'),
     `engineer offers the unit-test chore + the docs sweep (got ${engIds.join(', ')})`);
 });
@@ -63,7 +63,7 @@ t('loadTemplates: real file is a per-discipline list of valid chores', () => {
 // ---- loadFloors: real config, floor >= 2 so one is always left on claim ----
 t('loadFloors: real config keeps floor >= 2 per discipline (a spare on every claim)', () => {
   const f = r.loadFloors();
-  for (const disc of ['engineer', 'artist', 'ideator']) {
+  for (const disc of ['artisan', 'artist', 'artist']) {
     assert.ok(f[disc] >= 2, `${disc} floor ${f[disc]} must be >= 2 so one remains the instant one is claimed`);
   }
 });
@@ -147,7 +147,7 @@ t('restockForClaim threads its loaded map into the no-match fallback', () => {
 // ---- restockForClaim: skip path is DB-free (awaited) ----
 // (returns an array of per-template results; the skip path is a 1-element array.)
 assert.deepEqual(await r.restockForClaim(null), [{ skipped: true }]);
-assert.deepEqual(await r.restockForClaim({ source: 'auto-newcomer-floor-ai', discipline: 'engineer' }), [{ skipped: true }]);
+assert.deepEqual(await r.restockForClaim({ source: 'auto-newcomer-floor-ai', discipline: 'artisan' }), [{ skipped: true }]);
 assert.deepEqual(await r.restockForClaim({ source: 'newcomer-floor-manual', discipline: 'artist' }), [{ skipped: true }]);
 assert.deepEqual(await r.restockForClaim({ source: 'newcomer-template', discipline: 'bogus' }), [{ skipped: true }]);
 passed += 1;

package/tests/page_notes_panel.mjs

@@ -1,8 +1,8 @@
 // tests/page_notes_panel.mjs — the hall side of the artist's page feedback doc
 // (task 1004496): the docked review panel craft-mode.js puts at the right edge
-// in Artistry (task 1004771: no top-bar button), and the reader in page-notes.js. The server half is tests/page_notes.mjs.
+// in Artist (Artistry until task 1005141; task 1004771: no top-bar button), and the reader in page-notes.js. The server half is tests/page_notes.mjs.
 //
-// Runs the REAL craft-mode.js over a small DOM: the panel docks in Artistry
+// Runs the REAL craft-mode.js over a small DOM: the panel docks in Artist
 // alone and closes when the mode changes, page-notes.js loads once (same ?v as
 // craft-mode.js) and a ?note= link opens the doc in any mode. Then
 // the REAL page-notes.js reader: it escapes the doc and shows only this module's
@@ -75,19 +75,19 @@ function boot({ session = {}, search = '' } = {}) {
 }
 const flush = () => new Promise((r) => setTimeout(r, 0));
 
-test('THE PANEL: docked at the edge in Artistry alone, with no top-bar button, and closed when the mode changes', async () => {
-  const p = boot({ session: { 'hall-craft': 'artistry' } });
+test('THE PANEL: docked at the edge in Artist alone, with no top-bar button, and closed when the mode changes', async () => {
+  const p = boot({ session: { 'hall-craft': 'artist' } });
   await flush();
-  assert.deepEqual(p.tools().map((t) => t.id), ['craft-tool-paintbrush'], 'the top bar keeps Edit words alone (task 1004771)');
-  assert.equal(p.tools()[0].nextSibling, p.sw, 'right before the mode switch');
+  assert.deepEqual(p.tools().map((t) => t.id), ['craft-tool-paintbrush', 'craft-tool-lightbulb'], 'the top bar keeps Edit words, and the lightbulb that joined from Ideating (task 1005141) — no Review button (task 1004771)');
+  assert.equal(p.tools()[0].nextSibling, p.tools()[1], 'in TOOLS order');
+  assert.equal(p.tools()[1].nextSibling, p.sw, 'right before the mode switch');
   assert.deepEqual(p.opened, ['dock'], 'the review panel docks instead');
-  for (const m of ['building', 'governing']) p.craft.choose(m);
-  assert.deepEqual(p.opened, ['dock', 'close', 'close'], 'and leaves with Artistry');
-  p.craft.choose('ideating');
-  assert.deepEqual(p.tools().map((t) => t.id), ['craft-tool-lightbulb'], 'Ideating shows its lightbulb alone (task 1004498)');
-  p.craft.choose('artistry');
+  for (const m of ['artisan', 'patron']) p.craft.choose(m);
+  assert.deepEqual(p.opened, ['dock', 'close', 'close'], 'and leaves with Artist');
+  assert.deepEqual(p.tools().map((t) => t.id), [], 'Artisan and Patron carry no tool, the lightbulb included');
+  p.craft.choose('artist');
   await flush();
-  assert.equal(p.opened.filter((x) => x === 'dock').length, 2, 'back in Artistry it docks again');
+  assert.equal(p.opened.filter((x) => x === 'dock').length, 2, 'back in Artist it docks again');
   const none = boot();
   await flush();
   assert.equal(none.tools().length, 0, 'no tools with no mode at all');
@@ -95,9 +95,9 @@ test('THE PANEL: docked at the edge in Artistry alone, with no top-bar button, a
 });
 
 test('the panel script loads once, at the same version as craft-mode.js', async () => {
-  const p = boot({ session: { 'hall-craft': 'artistry' } });
+  const p = boot({ session: { 'hall-craft': 'artist' } });
   await flush();
-  p.craft.choose('artistry');
+  p.craft.choose('artist');
   await flush();
   assert.deepEqual(p.loaded, ['/builders/page-notes.js?v=2026-10-04-test']);
 });
@@ -106,7 +106,7 @@ test('a ?note= link opens that doc on arrival, in any mode', async () => {
   const p = boot({ search: '?note=42' });
   await flush();
   assert.deepEqual(p.opened, ['note 42']);
-  const q = boot({ session: { 'hall-craft': 'governing' }, search: '?x=1&note=7' });
+  const q = boot({ session: { 'hall-craft': 'patron' }, search: '?x=1&note=7' });
   await flush();
   assert.deepEqual(q.opened, ['note 7']);
   const bad = boot({ search: '?note=7x' });
@@ -204,7 +204,7 @@ function dockedPanel({ reviewing = null, opened = false } = {}) {
     reviewing: () => reviewing,
     review: (id) => { reviewing = id; calls.push('review ' + id); },
     stopReview: () => { reviewing = null; calls.push('stop'); },
-    experiences: () => [{ id: 'ideating', label: 'Ideator experience', short: 'Ideating' }, { id: 'building', label: 'Building experience', short: 'Building' }],
+    experiences: () => [{ id: 'patron', label: 'Patron experience', short: 'Patron' }, { id: 'artisan', label: 'Artisan experience', short: 'Artisan' }],
     iconHtml: () => '<svg></svg>',
   };
   const window = { OTB: realOTB(), location: { pathname: '/studio' }, OTBCraftMode: craft };
@@ -256,17 +256,17 @@ test('DOCKED: a touch never peeks, the tab click toggles, Escape and the X tuck
   assert.ok(p.collapsed(), 'docked, the X tucks it away too');
   assert.equal(p.sheet.parentNode, p.body, 'and leaves the tab on the page, the only way back in');
   p.api.close();
-  assert.equal(p.sheet.parentNode, null, 'leaving Artistry (close) is what removes it');
+  assert.equal(p.sheet.parentNode, null, 'leaving Artist (close) is what removes it');
 });
 
 test('THE MODE ROW names each mode in the mode switch word and starts a review on a press', () => {
   const p = dockedPanel();
-  assert.match(p.sheet.innerHTML, /<span>Ideating<\/span>/, 'the switch says Ideating, so the row does');
-  assert.doesNotMatch(p.sheet.innerHTML, />Ideator</);
+  assert.match(p.sheet.innerHTML, /<span>Patron<\/span>/, 'the switch says Patron, so the row does');
+  assert.doesNotMatch(p.sheet.innerHTML, /Patron experience/, 'the switch word, never the long label');
   assert.doesNotMatch(p.sheet.innerHTML, /Stop reviewing/, 'no way out of a review that has not started');
-  p.press('data-pn-mode', 'building');
-  assert.ok(p.calls.includes('review building'));
-  assert.match(p.sheet.querySelector('#pn-modes').innerHTML, /data-pn-mode="building" aria-pressed="true"/, 'the row repaints with the live one pressed');
+  p.press('data-pn-mode', 'artisan');
+  assert.ok(p.calls.includes('review artisan'));
+  assert.match(p.sheet.querySelector('#pn-modes').innerHTML, /data-pn-mode="artisan" aria-pressed="true"/, 'the row repaints with the live one pressed');
   assert.match(p.sheet.querySelector('#pn-modes').innerHTML, /Stop reviewing/);
   p.press('data-pn-mode', '');
   assert.ok(p.calls.includes('stop'), 'Stop reviewing ends it');

package/tests/page_tweak_no_block.mjs

@@ -58,7 +58,7 @@ try {
     await q(`INSERT INTO builders (id,github_id,github_login,display_name,rank) VALUES ($1,$2,$2,$2,'archon')`, [id, login]);
   }
   const seedTask = (id, title, status, touches, source = null) => q(
-    `INSERT INTO tasks (id,version_id,title,status,credits_reward,kind,discipline,touches,source) VALUES ($1,$2,$3,$4,10,'feature','engineer',$5,$6)`,
+    `INSERT INTO tasks (id,version_id,title,status,credits_reward,kind,discipline,touches,source) VALUES ($1,$2,$3,$4,10,'feature','artisan',$5,$6)`,
     [id, VER, title, status, touches, source]
   );
 

package/tests/paintbrush.mjs

@@ -1,4 +1,4 @@
-// tests/paintbrush.mjs — the Artistry paintbrush (task 1004497): a page's own
+// tests/paintbrush.mjs — the Artist paintbrush (task 1004497): a page's own
 // words, edited where they stand, as a proposed wording change.
 //
 // Runs the REAL paintbrush.js, with the REAL tweak-editor-lib.js and
@@ -192,12 +192,12 @@ function boot({ round = null, draft = null, claim = { status: 200, body: { ok: t
 }
 const settle = () => new Promise((r) => setTimeout(r, 5));
 
-test('craft-mode.js puts the paintbrush beside the palette in Artistry, loading its own script', () => {
+test('craft-mode.js puts the paintbrush beside the palette in Artist, loading its own script', () => {
   assert.match(CRAFT, /\{ id: 'paintbrush', icon: 'brush', short: 'Edit words', label: 'Edit this page\\'s words', script: 'paintbrush.js', api: 'OTBPaintbrush' \}/);
   const tools = /var TOOLS = \{([\s\S]*?)\n  \};/.exec(CRAFT)[1];
-  assert.match(tools, /^\s*artistry: \[/m, 'it is an Artistry tool');
-  assert.doesNotMatch(tools, /building:|governing:/, 'Building and Governing have none');
-  assert.doesNotMatch(/ideating: \[([\s\S]*?)\]/.exec(tools)[1], /paintbrush/, 'and the paintbrush is not Ideating\'s (task 1004498)');
+  assert.match(tools, /^\s*artist: \[/m, 'it is an Artist tool (Artistry until task 1005141)');
+  assert.doesNotMatch(tools, /artisan:|patron:/, 'Artisan and Patron have none');
+  assert.doesNotMatch(tools, /building:|artistry:|ideating:|governing:/, 'no tool list survives under a pre-rename mode id');
 });
 
 test('pressing it on a page nobody holds OFFERS the page — nothing is editable and nothing is written until the artist takes it', async () => {
@@ -398,7 +398,7 @@ test('emptying a line\'s words and leaving it marks it to be removed, instead of
   assert.deepEqual(JSON.parse(JSON.stringify(put.body.lines)), [{ key: 'L0002', remove: true }]);
 });
 
-test('REVIEW lists a removal as its own row, says it goes to an engineer, and SEND submits it with the rewrites', async () => {
+test('REVIEW lists a removal as its own row, says it goes to an artisan, and SEND submits it with the rewrites', async () => {
   const p = held();
   p.brush.open();
   await settle();
@@ -409,7 +409,7 @@ test('REVIEW lists a removal as its own row, says it goes to an engineer, and SE
   await settle();
   const html = p.bar().innerHTML;
   assert.match(html, /pb__change--remove[\s\S]*Remove<\/span> See every goal/);
-  assert.match(html, /A line you remove goes to an engineer to take out\./);
+  assert.match(html, /A line you remove goes to an artisan to take out\./);
   p.press('data-pb-send');
   await settle();
   const lastPut = p.writes().filter((c) => c.method === 'PUT').pop();

package/tests/privacy_matrix.mjs

@@ -491,6 +491,7 @@ require.cache[moduleApiPath] = {
   loaded: true,
   exports: {
     pool,
+    crafts: require('../src/crafts.js'),
     parsePagination: helpers.parsePagination,
     validateOrRespond: helpers.validateOrRespond,
     corsPublicGet: () => (_req, _res, next) => next(),

package/tests/profile_activity.mjs

@@ -4,7 +4,7 @@
 // you did, by role", including the idea trail.
 //
 // The done-when, as assertions: the owner opens their profile, switches to the
-// ideator view, sees EVERY idea they ever captured with what became of it, and
+// artist view (the ideas trail), sees EVERY idea they ever captured with what became of it, and
 // can click through to the task a promotion produced.
 //
 // Five things are pinned here, and each one is a bug that is invisible in review:
@@ -212,7 +212,7 @@ await test('goals: a private goal is walled off in SQL, before the LIMIT', async
 
 await test("goals: a goal's craft is what its TASKS carry — no discipline column on goals", async () => {
   resetSql();
-  await activity.activityGoalsByBuilder(95, { role: 'engineer' });
+  await activity.activityGoalsByBuilder(95, { role: 'artisan' });
   const sql = listSql().sql;
   assert.ok(/array_agg\(DISTINCT COALESCE\(t\.discipline/.test(sql), 'the craft set is derived from the tasks');
   assert.ok(/= ANY\(c\.disciplines\)/.test(sql), 'the craft filter tests that derived set');
@@ -304,7 +304,7 @@ seams.registerProvider('lifecycle', {
   recentShippedTasksByBuilder: async () => [],
   activityTasksByBuilder: async (id, opts) => {
     portCalls.push(['tasks', id, opts]);
-    return { rows: [{ id: 42, title: 'A work', discipline: 'engineer' }], total: 1 };
+    return { rows: [{ id: 42, title: 'A work', discipline: 'artisan' }], total: 1 };
   },
   activityGoalsByBuilder: async (id, opts) => {
     portCalls.push(['goals', id, opts]);
@@ -440,7 +440,7 @@ const TRAIL = [
 
 
 
-await test('the ideator view shows EVERY idea filed, whatever became of it', async () => {
+await test("the artist tab's idea trail shows EVERY idea filed, whatever became of it", async () => {
   const p = bootProfile();
   await settle(); await settle(); await settle();
   const html = p.htmlFor('activity-ideas');
@@ -469,33 +469,30 @@ await test('the other three outcomes each say what happened', async () => {
 });
 
 // Task 1004435 (WA6.RP05): one tab per role the person has, each its craft's
-// own record. The engineer tab is the works and goals, WHOLE (no craft filter:
-// most of the corpus is unclassified); the ideator tab is the trail; the artist
-// tab is the approved pages. No tab is "tasks carrying that label" any more.
+// own record. The artisan tab is the works and goals, WHOLE (no craft filter:
+// most of the corpus is unclassified); the artist tab (task 1005141 — the old
+// ideator folded into it) is the approved pages AND the idea trail. No tab is
+// "tasks carrying that label" any more.
 await test('each role tab asks the server for that craft\'s OWN record', async () => {
-  const p = bootProfile({ roles: ['ideator', 'engineer', 'artist'] });
+  const p = bootProfile({ roles: ['artist', 'artisan'] });
   await settle(); await settle(); await settle();
-  assert.ok(p.requests.some((u) => u.includes('/inbox/by-builder/')), 'the first tab (the ideator) reads the trail');
-  assert.ok(!p.requests.some((u) => u.includes('section=goals')), 'and no goals ledger until the engineer tab opens');
-  let before = p.requests.length;
-  p.switchCraft('engineer');
+  assert.ok(p.requests.some((u) => u.includes('/inbox/by-builder/')), 'the first tab (the artist) reads the idea trail');
+  assert.ok(p.requests.some((u) => /\/copy-desk\/artists\/95\/pages\?limit=\d+&offset=0/.test(u)), 'and their approved pages, a few at a time');
+  assert.ok(!p.requests.some((u) => u.includes('role=artist')), 'never "tasks labelled artist"');
+  assert.ok(!p.requests.some((u) => u.includes('section=goals')), 'and no goals ledger until the artisan tab opens');
+  const before = p.requests.length;
+  p.switchCraft('artisan');
   await settle(); await settle();
-  let after = p.requests.slice(before);
-  assert.ok(after.some((u) => u.includes('section=tasks') && !u.includes('role=')), 'the engineer tab reads the whole works ledger');
+  const after = p.requests.slice(before);
+  assert.ok(after.some((u) => u.includes('section=tasks') && !u.includes('role=')), 'the artisan tab reads the whole works ledger');
   assert.ok(after.some((u) => u.includes('section=goals') && !u.includes('role=')), 'and the whole goals ledger');
-  before = p.requests.length;
-  p.switchCraft('artist');
-  await settle(); await settle();
-  after = p.requests.slice(before);
-  assert.ok(after.some((u) => /\/copy-desk\/artists\/95\/pages\?limit=\d+&offset=0/.test(u)), 'the artist tab reads their approved pages, a few at a time');
-  assert.ok(!after.some((u) => u.includes('role=artist')), 'never "tasks labelled artist"');
 });
 
 await test('a role the person does not have gets no tab and no read', async () => {
-  const p = bootProfile({ roles: ['engineer'] });
+  const p = bootProfile({ roles: ['artisan'] });
   await settle(); await settle(); await settle();
-  assert.ok(p.requests.some((u) => u.includes('section=tasks')), 'the only tab is the engineer\'s');
-  assert.ok(!p.requests.some((u) => u.includes('/inbox/by-builder/')), 'no trail read for a person with no ideator role');
+  assert.ok(p.requests.some((u) => u.includes('section=tasks')), 'the only tab is the artisan\'s');
+  assert.ok(!p.requests.some((u) => u.includes('/inbox/by-builder/')), 'no trail read for a person with no artist role');
   assert.ok(!p.requests.some((u) => u.includes('/copy-desk/artists/')), 'no pages read for a person with no artist role');
 });
 

package/tests/profile_earnings.mjs

@@ -183,7 +183,7 @@ const PEOPLE = [
     end: '412 credits',
   },
   {
-    who: 'ideator', id: 2002, name: 'Builder 9',
+    who: 'artist', id: 2002, name: 'Builder 9',
     lede: 'Builder 9 has never shipped a task. Every credit here came from ideas.',
     kinds: [['Ideas that became shipped work', '96'], ['Work split from their ideas', '38'], ['Ratified by the board', '30'], ['Full Ideas passed', '22']],
     end: '186 credits',

package/tests/profile_nudge_prefs.mjs

@@ -25,12 +25,12 @@ test('missingProfileFields: empty, whitespace, and absent all count as missing',
 
 test('missingProfileFields: a real value on either side drops only that entry', () => {
   assert.deepEqual(p.missingProfileFields({ bio: 'I build things', preferredDisciplines: [] }), ['disciplines']);
-  assert.deepEqual(p.missingProfileFields({ bio: '', preferredDisciplines: ['engineer'] }), ['bio']);
-  assert.deepEqual(p.missingProfileFields({ bio: 'x', preferredDisciplines: ['engineer'] }), []);
+  assert.deepEqual(p.missingProfileFields({ bio: '', preferredDisciplines: ['artisan'] }), ['bio']);
+  assert.deepEqual(p.missingProfileFields({ bio: 'x', preferredDisciplines: ['artisan'] }), []);
 });
 
 test('missingProfileFields: a non-array disciplines value is missing, not a crash', () => {
-  assert.deepEqual(p.missingProfileFields({ bio: 'x', preferredDisciplines: 'engineer' }), ['disciplines']);
+  assert.deepEqual(p.missingProfileFields({ bio: 'x', preferredDisciplines: 'artisan' }), ['disciplines']);
   assert.deepEqual(p.missingProfileFields({ bio: 'x', preferredDisciplines: {} }), ['disciplines']);
 });
 
@@ -47,7 +47,7 @@ test('nudgeDismissed: defaults to NOT dismissed; only a real boolean overrides',
 
 test('shouldNudge: shows only when something is missing AND not dismissed', () => {
   const missing = { bio: '', preferredDisciplines: [] };
-  const complete = { bio: 'x', preferredDisciplines: ['engineer'] };
+  const complete = { bio: 'x', preferredDisciplines: ['artisan'] };
   assert.equal(p.shouldNudge({ behaviorPrefs: {}, ...missing }), true);
   assert.equal(p.shouldNudge({ behaviorPrefs: { profile_nudge_dismissed: true }, ...missing }), false);
   assert.equal(p.shouldNudge({ behaviorPrefs: {}, ...complete }), false);